Home | Search | chromium - Builders
Login

Builder Win7 FYI x64 Release (NVIDIA) Build 1665 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision8e2ccd76952b57016daccdd19fde7a54d1719a7b
Got Revision8e2ccd76952b57016daccdd19fde7a54d1719a7b

Execution:

Steps and Logfiles:

Show:
  1. ( 552 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 359 ms ) remove .cipd
  4. ( 1 mins 9 secs ) bot_update
    [49GB/299GB used (16%)]
  5. ( 0 ) ensure_goma
  6. ( 623 ms ) swarming.py --version
    0.13
  7. ( 1 mins 18 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  9. ( 2 secs ) build directory
  10. ( 51 secs ) extract build
  11. ( 392 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 5 mins 55 secs ) angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:05:43.711760
  14. ( 5 mins 30 secs ) angle_gles1_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:04:46.139650
    Shard duration: 43s
  15. ( 50 secs ) angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 46s
  16. ( 32 secs ) angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 29s
  17. ( 2 mins 2 secs ) tab_capture_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:55.583040
  18. ( 45 secs ) gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 39s
  19. ( 32 secs ) gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 30s
  20. ( 29 secs ) gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 26s
  21. ( 1 mins 25 secs ) gles2_conform_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:21.865240
  22. ( 1 mins 29 secs ) gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:27.778660
  23. ( 1 mins 22 secs ) gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:20.811010
  24. ( 43 secs ) gpu_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 40s
  25. ( 22 secs ) swiftshader_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 21s
  26. ( 38 secs ) video_decode_accelerator_d3d11_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 33s
  27. ( 43 secs ) video_decode_accelerator_d3d9_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 41s
  28. ( 42 secs ) video_decode_accelerator_gl_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 39s
  29. ( 2 mins 41 secs ) context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:38.377000
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 1 mins 53 secs ) depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:51.376800
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 3 mins 16 secs ) gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:09.757030
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 2 mins 17 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:13.168730
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 1 mins 58 secs ) info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:52.523120
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 2 mins 7 secs ) maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:59.073100
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 4 mins 40 secs ) pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:04:28.018060
    Total tests: 48
    * Passed: 48 (48 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 2 mins 53 secs ) screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:47.780320
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 3 mins 6 secs ) trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:02.318930
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 2 mins 35 secs ) viz_screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:29.286700
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 11 mins 58 secs ) webgl2_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:03:14.792630 (shard #19)
    Max shard duration: 0:09:57.268540 (shard #0)
    Min shard duration: 0:08:08.516320 (shard #2)
    Total tests: 2761
    * Passed: 2697 (2697 expected, 0 unexpected)
    * Skipped: 64 (64 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 7 mins 28 secs ) webgl_conformance_d3d11_validating_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:20.383430 (shard #1)
    Min shard duration: 0:04:25.784360 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 7 mins 27 secs ) webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:16.894410 (shard #1)
    Min shard duration: 0:04:00.158760 (shard #0)
    Total tests: 922
    * Passed: 913 (913 expected, 0 unexpected)
    * Skipped: 9 (9 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 7 mins 17 secs ) webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:06:57.193570 (shard #1)
    Min shard duration: 0:04:58.523090 (shard #0)
    Total tests: 922
    * Passed: 911 (911 expected, 0 unexpected)
    * Skipped: 11 (11 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  43. ( 7 mins 13 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:07.846820 (shard #1)
    Min shard duration: 0:03:55.053430 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  44. ( 7 mins 43 secs ) webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:35.727580 (shard #1)
    Min shard duration: 0:05:20.623630 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  45. ( 219 ms ) Tests statistics
     
    Stats
    Total shards: 56
    Total runtime: 3:18:36.628999
     
  46. ( 583 ms ) process_dumps
  47. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm765-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531424382060960, "id": "8941178863114952288", "project": "chromium", "tags": ["builder:Win7 FYI x64 Release (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8e2ccd76952b57016daccdd19fde7a54d1719a7b", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win x64 Builder", "parent_buildnumber:8563", "scheduler_invocation_id:9106608925417230832", "scheduler_job_id:chromium/Win7 FYI x64 Release (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 FYI x64 Release (NVIDIA)" setup_build
buildnumber 1665 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win x64 Builder" setup_build
parent_got_angle_revision "1617e69e3883e77f8ae05680576d08d905fcc70f" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "8e2ccd76952b57016daccdd19fde7a54d1719a7b" setup_build
parent_got_revision_cp "refs/heads/master@{#574648}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23952}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "8e2ccd76952b57016daccdd19fde7a54d1719a7b" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "8e2ccd76952b57016daccdd19fde7a54d1719a7b" bot_update
got_revision_cp "refs/heads/master@{#574648}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update
swarm_hashes {"angle_end2end_tests": "cf4dc2232bfe80c1147ddbbd232f466c5269ddf8", "angle_gles1_conformance_tests": "fdc50c2621b9cf4a9cfc2dd160b4fc78605b5209", "angle_unittests": "019ed87aea82cc09240d84519e9f8ad0698bd3df", "angle_white_box_tests": "36d875b3249169d15048497b6d06df401d156153", "browser_tests": "7e9313a0896c394258cf773193bb6d2dd30a26ed", "gl_tests": "889698f6efa51d29e94a2726c1e9d1c525521e88", "gl_unittests": "629daeced3b086b61b8e3fe27fc157d80bf25083", "gles2_conform_test": "02830794e231eb0bf331c7d7088782a1d8b9c32e", "gpu_unittests": "6737eca9dbe75987d692c44d208438770411366f", "swiftshader_unittests": "3cff7d66703862ad76d07ba5a206b67e63505e79", "telemetry_gpu_integration_test": "d0f4f7096639ab81f1948709d53fdf95e34d9065", "video_decode_accelerator_unittest": "b49476a39a6be82d07ddc5bc194533aff94aaa0d"} find isolated tests

Blamelist:

  1. Manu Cornet (manucornetohnoyoudont@chromium.org)
  2. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  3. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  4. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  5. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  6. wutao (wutaoohnoyoudont@chromium.org)
  7. Helen Li (xunjieliohnoyoudont@chromium.org)
  8. Juan Antonio Navarro Perez (perezjuohnoyoudont@chromium.org)
  9. John Chen (johnchenohnoyoudont@chromium.org)
  10. Becca Hughes (beccahughesohnoyoudont@chromium.org)
  11. sebsg (sebsgohnoyoudont@chromium.org)
  12. Krishna Govind (govindohnoyoudont@chromium.org)
  13. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  14. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  15. Paul Miller (paulmillerohnoyoudont@google.com)
  16. chcunningham (chcunninghamohnoyoudont@chromium.org)
  17. David Black (dmblackohnoyoudont@google.com)
  18. David Black (dmblackohnoyoudont@google.com)
  19. Jared Saul (jsaulohnoyoudont@google.com)
  20. khmel@google.com (khmelohnoyoudont@google.com)
  21. erikchen (erikchenohnoyoudont@chromium.org)
  22. Mark Pilgrim (pilgrimohnoyoudont@chromium.org)
  23. Takumi Fujimoto (takumifohnoyoudont@chromium.org)
  24. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  25. Ella Ge (eirageohnoyoudont@chromium.org)
  26. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  27. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  28. Carlos IL (carlosilohnoyoudont@chromium.org)
  29. Mark Pilgrim (pilgrimohnoyoudont@chromium.org)
  30. David Black (dmblackohnoyoudont@google.com)
  31. David Black (dmblackohnoyoudont@google.com)
  32. Peter K. Lee (pklohnoyoudont@chromium.org)
  33. Ian Clelland (iclellandohnoyoudont@chromium.org)
  34. Peter Kvitek (kvitekpohnoyoudont@chromium.org)
  35. Justin Novosad (junovohnoyoudont@chromium.org)
  36. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  37. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  38. Anna Offenwanger (offenwangerohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 19:39:42 UTC
Start Thursday, 12-Jul-18 19:39:45 UTC
End Thursday, 12-Jul-18 21:28:41 UTC
Pending 3 secs
Execution 1 hrs 48 mins

All Changes:

  1. Shelf new UI: center items on the total shelf size

    Changed by Manu Cornet - manucornetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:46:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e2ccd76952b57016daccdd19fde7a54d1719a7b

    Comments

    Shelf new UI: center items on the total shelf size
    
    Bug: 805612
    Change-Id: I9c6e0c0aab7f39681bec850ee18d890a9410990c
    Reviewed-on: https://chromium-review.googlesource.com/1135298
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574648}

    Changed files

    • ash/shelf/shelf_view.cc
  2. [Unity][Android] Update personalized sign-in promo descriptions

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:43:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1806fde687718fd19118e7a6f09e0d5610239cb5

    Comments

    [Unity][Android] Update personalized sign-in promo descriptions
    
    This CL adds a second set of description strings for personalized
    sign-in promos. This set of strings is shown if UnifiedConsent feature
    is enabled.
    
    Bug: 814728
    Change-Id: I1d90a2ec786397326b6d80011c0de6d31468431b
    Reviewed-on: https://chromium-review.googlesource.com/1131500
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574647}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoController.java
    • chrome/android/java/strings/android_chrome_strings.grd
    • chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
  3. [Background Fetch] Fix dispatched event name on failure.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7523f88574031a353b4ce24fa9cb87dfbcc2b11

    Comments

    [Background Fetch] Fix dispatched event name on failure.
    
    TBR=falken@chromium.org
    
    Change-Id: Iba46fbe0eee3a886a847fc259d45e51ecfa81dd1
    Reviewed-on: https://chromium-review.googlesource.com/1135451
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574646}

    Changed files

    • third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
  4. Fix tabstrip edges not redrawing when entering/leaving single tab mode

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 901634eeb056e61914c0b70b43adff655d156c2b

    Comments

    Fix tabstrip edges not redrawing when entering/leaving single tab mode
    
    BUG=860859
    R=pkasting
    
    Change-Id: I9766d6c175fa6bdd8906c58448bf94ae85a17141
    Reviewed-on: https://chromium-review.googlesource.com/1135512
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574645}

    Changed files

    • chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
  5. [Fuchsia] Update webrunner to quit when sys::Runner is closed.

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:33:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c40e749cd5d48a9ee9fd02f822c18857d52b813b

    Comments

    [Fuchsia] Update webrunner to quit when sys::Runner is closed.
    
    appmgr process normally creates a single sys::Runner connection for
    each runner process and then closes it when it no longer needs the
    runner. Updagted webrunner implementation to quit after sys::Runned
    is destroyed.
    
    Bug: 856416
    Change-Id: I071b37093917a932a837eebfdf1f1a6e23e837de
    Reviewed-on: https://chromium-review.googlesource.com/1134415
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574644}

    Changed files

    • base/fuchsia/scoped_service_binding.h
    • base/fuchsia/service_directory_unittest.cc
    • webrunner/app/main.cc
  6. Assistant: Fix the notification type

    Changed by wutao - wutaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:33:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94e0357b298de459bbfb9c75942fc8193db16203

    Comments

    Assistant: Fix the notification type
    
    Changed the assistant notification type to SYSTEM_COMPONENT.
    
    Bug: b/79493568
    Test: manual.
    Change-Id: I12bb925f3e430fbd74c518be89aba9bd7d31b871
    Reviewed-on: https://chromium-review.googlesource.com/1135574
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574643}

    Changed files

    • ash/assistant/assistant_notification_controller.cc
  7. Reland "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by Helen Li - xunjieliohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:30:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d24ee7bc5a14573a8a761c45222f68efb4bef3b0

    Comments

    Reland "Make NetworkConnectionTracker survive network service crashes and restarts"
    
    This reverts commit 197e9188dc5be69cb34e1ebd67f86a1146439367.
    
    Reason for revert: There is a racy test expectation that causes the test to timeout.
    This CL fixes the test.
    
    Bug: 862883, 821009
    Change-Id: I1cb4d8db6ea3f5c683f95bcc3187f6c6b4d6fdbd
    Reviewed-on: https://chromium-review.googlesource.com/1135290
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Commit-Queue: Helen Li <xunjieli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574642}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  8. [tools/perf] git-ignore artifacts and html result files

    Changed by Juan Antonio Navarro Perez - perezjuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:26:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab977857ed343bd565c6eb43846b77f7928b5bcd

    Comments

    [tools/perf] git-ignore artifacts and html result files
    
    Also move relevant ignores from the root of the project into tools/perf.
    
    Change-Id: I30e025dcdfea768aa8dbd6f3a8f6dc05eafdb6c8
    Reviewed-on: https://chromium-review.googlesource.com/1135129
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574641}

    Changed files

    • .gitignore
    • tools/perf/.gitignore
  9. [ChromeDriver] Return debugging port in capabilities

    Changed by John Chen - johnchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:24:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 403b2e9ab1b7ebe8d476a38052fc8a242b9f7d1a

    Comments

    [ChromeDriver] Return debugging port in capabilities
    
    Add a new entry chrome.debuggerAddress in the capabilities returned from
    InitSession command. It contains the hostname and port to reach Chrome's
    remote debugging port.
    
    Also removed an unused constructor in struct BrowserInfo.
    
    Bug: chromedriver:2379
    Change-Id: Ic36c08eb7fe42b27fa1ba796ee10c511d76ef804
    Reviewed-on: https://chromium-review.googlesource.com/1133421
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574640}

    Changed files

    • chrome/test/chromedriver/chrome/browser_info.cc
    • chrome/test/chromedriver/chrome/browser_info.h
    • chrome/test/chromedriver/chrome/devtools_http_client.cc
    • chrome/test/chromedriver/session_commands.cc
  10. [Media Controls] Localize CC to S by locale

    Changed by Becca Hughes - beccahughesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:21:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0109bbaa2074acaefbe6fcc72d66499f19137813

    Comments

    [Media Controls] Localize CC to S by locale
    
    Use a "S" icon for the captions button by default
    except for "en", "en-US", "es-419" and "pt-BR" which
    should continue to use the CC icon.
    
    I added some clarification about which locales in the
    bug since there was some regions that were not locales
    supported by Chrome.
    
    BUG=353120
    
    Change-Id: I41e05058a6b1589eddce0605d39272b4dd965248
    Reviewed-on: https://chromium-review.googlesource.com/1134480
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574639}

    Changed files

    • third_party/WebKit/LayoutTests/media/controls/closed-captions-locale.html
    • third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
    • third_party/blink/renderer/modules/media_controls/resources/ic_subtitles.svg
    • third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
  11. [AF] Add fieldtrial_testing_config for AutofillDynamicForms.

    Changed by sebsg - sebsgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:19:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ad13746662b2eb310c8732a69b6ca1357f9fad6

    Comments

    [AF] Add fieldtrial_testing_config for AutofillDynamicForms.
    
    Change-Id: I99d7f3d5a95c34d29c98a00473f8dab11f3b46f6
    Reviewed-on: https://chromium-review.googlesource.com/1132129
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574638}

    Changed files

    • chrome/browser/autofill/autofill_interactive_uitest.cc
    • testing/variations/fieldtrial_testing_config.json
  12. Updating XTBs based on .GRDs from branch master

    Changed by Krishna Govind - govindohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:16:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7edd65b959ed3edbb808bd0bd2c914e5a92cfff

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=cmasso@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I20b9e67c2fb01e36dfb995b00252ca0158ca14ee
    Reviewed-on: https://chromium-review.googlesource.com/1135575
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574637}

    Changed files

    • ash/components/strings/ash_components_strings_de.xtb
    • ash/components/strings/ash_components_strings_es-419.xtb
    • ash/components/strings/ash_components_strings_id.xtb
    • ash/components/strings/ash_components_strings_it.xtb
    • ash/components/strings/ash_components_strings_ko.xtb
    • ash/components/strings/ash_components_strings_ro.xtb
    • ash/components/strings/ash_components_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ro.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_vi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb
    • chrome/app/resources/chromium_strings_am.xtb
    • chrome/app/resources/chromium_strings_bg.xtb
    • chrome/app/resources/chromium_strings_ca.xtb
    • chrome/app/resources/chromium_strings_de.xtb
    • chrome/app/resources/chromium_strings_el.xtb
    • chrome/app/resources/chromium_strings_en-GB.xtb
    • chrome/app/resources/chromium_strings_es.xtb
    • chrome/app/resources/chromium_strings_et.xtb
    • chrome/app/resources/chromium_strings_fil.xtb
    • chrome/app/resources/chromium_strings_fr.xtb
    • chrome/app/resources/chromium_strings_hi.xtb
    • chrome/app/resources/chromium_strings_hr.xtb
    • chrome/app/resources/chromium_strings_hu.xtb
    • chrome/app/resources/chromium_strings_id.xtb
    • chrome/app/resources/chromium_strings_it.xtb
    • chrome/app/resources/chromium_strings_iw.xtb
    • chrome/app/resources/chromium_strings_kn.xtb
    • chrome/app/resources/chromium_strings_lt.xtb
    • chrome/app/resources/chromium_strings_lv.xtb
    • chrome/app/resources/chromium_strings_ml.xtb
    • chrome/app/resources/chromium_strings_ms.xtb
    • chrome/app/resources/chromium_strings_nl.xtb
    • chrome/app/resources/chromium_strings_pl.xtb
    • chrome/app/resources/chromium_strings_ro.xtb
    • chrome/app/resources/chromium_strings_ru.xtb
    • chrome/app/resources/chromium_strings_sk.xtb
    • chrome/app/resources/chromium_strings_sr.xtb
    • chrome/app/resources/chromium_strings_th.xtb
    • chrome/app/resources/chromium_strings_uk.xtb
    • chrome/app/resources/chromium_strings_vi.xtb
    • chrome/app/resources/chromium_strings_zh-TW.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_am.xtb
    • chrome/app/resources/google_chrome_strings_bg.xtb
    • chrome/app/resources/google_chrome_strings_ca.xtb
    • chrome/app/resources/google_chrome_strings_de.xtb
    • chrome/app/resources/google_chrome_strings_el.xtb
    • chrome/app/resources/google_chrome_strings_en-GB.xtb
    • chrome/app/resources/google_chrome_strings_es.xtb
    • chrome/app/resources/google_chrome_strings_et.xtb
    • chrome/app/resources/google_chrome_strings_fil.xtb
    • chrome/app/resources/google_chrome_strings_fr.xtb
    • chrome/app/resources/google_chrome_strings_hi.xtb
    • chrome/app/resources/google_chrome_strings_hr.xtb
    • chrome/app/resources/google_chrome_strings_hu.xtb
    • chrome/app/resources/google_chrome_strings_id.xtb
    • chrome/app/resources/google_chrome_strings_it.xtb
    • chrome/app/resources/google_chrome_strings_iw.xtb
    • chrome/app/resources/google_chrome_strings_kn.xtb
    • chrome/app/resources/google_chrome_strings_lt.xtb
    • chrome/app/resources/google_chrome_strings_lv.xtb
    • chrome/app/resources/google_chrome_strings_ml.xtb
    • chrome/app/resources/google_chrome_strings_ms.xtb
    • chrome/app/resources/google_chrome_strings_nl.xtb
    • chrome/app/resources/google_chrome_strings_pl.xtb
    • chrome/app/resources/google_chrome_strings_ro.xtb
    • chrome/app/resources/google_chrome_strings_ru.xtb
    • chrome/app/resources/google_chrome_strings_sk.xtb
    • chrome/app/resources/google_chrome_strings_sr.xtb
    • chrome/app/resources/google_chrome_strings_th.xtb
    • chrome/app/resources/google_chrome_strings_uk.xtb
    • chrome/app/resources/google_chrome_strings_vi.xtb
    • chrome/app/resources/google_chrome_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bg.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_da.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_es.xtb
    • components/policy/resources/policy_templates_et.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fil.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_gu.xtb
    • components/policy/resources/policy_templates_hi.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_hu.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_iw.xtb
    • components/policy/resources/policy_templates_ja.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ko.xtb
    • components/policy/resources/policy_templates_lt.xtb
    • components/policy/resources/policy_templates_lv.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_mr.xtb
    • components/policy/resources/policy_templates_ms.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_no.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ro.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sl.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/policy/resources/policy_templates_zh-CN.xtb
    • components/policy/resources/policy_templates_zh-TW.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_am.xtb
    • content/app/strings/translations/content_strings_ar.xtb
    • content/app/strings/translations/content_strings_bg.xtb
    • content/app/strings/translations/content_strings_bn.xtb
    • content/app/strings/translations/content_strings_ca.xtb
    • content/app/strings/translations/content_strings_cs.xtb
    • content/app/strings/translations/content_strings_da.xtb
    • content/app/strings/translations/content_strings_de.xtb
    • content/app/strings/translations/content_strings_el.xtb
    • content/app/strings/translations/content_strings_en-GB.xtb
    • content/app/strings/translations/content_strings_es-419.xtb
    • content/app/strings/translations/content_strings_es.xtb
    • content/app/strings/translations/content_strings_et.xtb
    • content/app/strings/translations/content_strings_fa.xtb
    • content/app/strings/translations/content_strings_fi.xtb
    • content/app/strings/translations/content_strings_fil.xtb
    • content/app/strings/translations/content_strings_fr.xtb
    • content/app/strings/translations/content_strings_gu.xtb
    • content/app/strings/translations/content_strings_hi.xtb
    • content/app/strings/translations/content_strings_hr.xtb
    • content/app/strings/translations/content_strings_hu.xtb
    • content/app/strings/translations/content_strings_id.xtb
    • content/app/strings/translations/content_strings_it.xtb
    • content/app/strings/translations/content_strings_iw.xtb
    • content/app/strings/translations/content_strings_ja.xtb
    • content/app/strings/translations/content_strings_kn.xtb
    • content/app/strings/translations/content_strings_ko.xtb
    • content/app/strings/translations/content_strings_lt.xtb
    • content/app/strings/translations/content_strings_lv.xtb
    • content/app/strings/translations/content_strings_ml.xtb
    • content/app/strings/translations/content_strings_mr.xtb
    • content/app/strings/translations/content_strings_ms.xtb
    • content/app/strings/translations/content_strings_nl.xtb
    • content/app/strings/translations/content_strings_no.xtb
    • content/app/strings/translations/content_strings_pl.xtb
    • content/app/strings/translations/content_strings_pt-BR.xtb
    • content/app/strings/translations/content_strings_pt-PT.xtb
    • content/app/strings/translations/content_strings_ro.xtb
    • content/app/strings/translations/content_strings_ru.xtb
    • content/app/strings/translations/content_strings_sk.xtb
    • content/app/strings/translations/content_strings_sl.xtb
    • content/app/strings/translations/content_strings_sr.xtb
    • content/app/strings/translations/content_strings_sv.xtb
    • content/app/strings/translations/content_strings_sw.xtb
    • content/app/strings/translations/content_strings_ta.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • content/app/strings/translations/content_strings_th.xtb
    • content/app/strings/translations/content_strings_tr.xtb
    • content/app/strings/translations/content_strings_uk.xtb
    • content/app/strings/translations/content_strings_vi.xtb
    • content/app/strings/translations/content_strings_zh-CN.xtb
    • content/app/strings/translations/content_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_bg.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_es.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_et.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_iw.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ms.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ro.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_uk.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_bg.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_es.xtb
    • ios/chrome/app/strings/resources/ios_strings_et.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hi.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_iw.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_ms.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_ro.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • ios/chrome/app/strings/resources/ios_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-TW.xtb
    • ui/strings/translations/ui_strings_en-GB.xtb
  13. [ios] Use ActionSheetCoordinator in ClearBrowsingData

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:16:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ba261495b02e475848d7b253a0d1c1c8606c2ff1

    Comments

    [ios] Use ActionSheetCoordinator in ClearBrowsingData
    
    - Uses ActionSheetCoordinator instead of UIAlertController to help handle presenting the popover in non-compact devices.
    - Adds title to avoid seemingly odd double "clear browsing data" button in non-compact devices.
    
    Screenshots:  https://drive.google.com/open?id=1OjP2BL_TNf5W1L1lluI-8Q52x-nnzOAj
    https://drive.google.com/open?id=1_QnxFfKE0r6VqwjNoPFPYnLPfB42nL6W
    
    Change-Id: Iedac56cc0217567206630baed8feb32ea50ae2de
    Reviewed-on: https://chromium-review.googlesource.com/1120850
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574636}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/metrics/ukm_egtest.mm
    • ios/chrome/browser/ui/history/history_ui_egtest.mm
    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager.h
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_ui_constants.h
    • ios/chrome/browser/ui/settings/clear_browsing_data_ui_constants.mm
    • ios/chrome/browser/ui/settings/settings_egtest.mm
    • ios/chrome/test/earl_grey/chrome_matchers.h
    • ios/chrome/test/earl_grey/chrome_matchers.mm
  14. Import wpt@e462f618e3765749ca8b0101987759d37d746d32

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:12:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347fe160e3d49452f2c4c56406230237937b570d

    Comments

    Import wpt@e462f618e3765749ca8b0101987759d37d746d32
    
    Using wpt-import in Chromium 3fb53cf0d187b9537160ad967975f17641d59c1f.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21189
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    meade@chromium.org:
      external/wpt/web-animations
    rouslan@chromium.org, mathp@chromium.org:
      external/wpt/payment-request
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I87288052fdbcab0a3a1b79325c964085695ab2a5
    Reviewed-on: https://chromium-review.googlesource.com/1135205
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574635}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-label-element/label-attributes.sub-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-label-element/label-attributes.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/closing-the-input-stream/document.close-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/003.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/005.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/006.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/007.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/008-1.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/008.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/009.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/010-1.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/010.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/011-1.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/011.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/011.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/012.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/012.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/013.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/013.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/014.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/015.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/016.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/017.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/018.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/019.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/020.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/021.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/022.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/023.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/024.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/025.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/026.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/027.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/028.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/029.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/030.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/031.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/032.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/033.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/034.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/035.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/036.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/037.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/038.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/039.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/040.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/041.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/042.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/043.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/044.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/045.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/046.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/047.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/048.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/049.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/050.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/051.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/contentType.window-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/contentType.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/document.write-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/document.write-02.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/empty.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_003.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_005.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_009.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/nested-document-write-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/nested-document-write-2.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/nested-document-write-external.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/original-id.json
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_003.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_009.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_011.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_012.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_013.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/write-active-document-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/write-active-document.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/document.writeln-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/document.writeln-02.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/document.writeln-03.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/original-id.json
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/001-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/004-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/005-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/008-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/009.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/009.https.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010-2.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/011-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/011.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/012-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/012.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/013-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/013.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/014-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/014.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/015-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/015-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/015.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/016-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/016-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/016.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-02.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-03-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-03-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-03.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/encoding.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/event-listeners.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/mutation-events.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/aborted-parser-async-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/aborted-parser-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/encoding-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/type-argument-plaintext-subframe.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/type-argument-plaintext.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/type-argument.window.js
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/payment-request.idl
    • third_party/WebKit/LayoutTests/external/wpt/lint.whitelist
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/idlharness.https.window.js
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/timelines/update-and-send-events.html
  15. WebView: Support loading .svgz assets/resources

    Changed by Paul Miller - paulmillerohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:04:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a5feed58d4c2e2e8870d1dbd9e05e61039b9d27

    Comments

    WebView: Support loading .svgz assets/resources
    
    Loading .svgz files from the web works because of a special case in
    URLRequestFileJob::SetUpSourceStream(). Add a special case in
    AndroidProtocolHandler so that e.g.
    WebView.loadUrl("file:///android_asset/foo.svgz") works as well.
    
    BUG=854282
    
    Change-Id: I995f8b602bd6e3b05818ede763f3774465850d82
    Reviewed-on: https://chromium-review.googlesource.com/1134429
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Paul Miller <paulmiller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574634}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AndroidProtocolHandler.java
    • android_webview/javatests/src/org/chromium/android_webview/test/AndroidProtocolHandlerTest.java
    • android_webview/test/BUILD.gn
    • android_webview/test/shell/assets/star.svg
    • android_webview/test/shell/assets/star.svgz
  16. RELAND: InMemory MediaCapabilities DB for Guest/Incognito

    Changed by chcunningham - chcunninghamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:04:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9205ea89ebb4bd23b2f0099726f641a27ed269bb

    Comments

    RELAND: InMemory MediaCapabilities DB for Guest/Incognito
    
    Original CL was reverted:
    https://chromium-review.googlesource.com/c/chromium/src/+/1092156
    
    Reland now possible thanks to:
    https://chromium-review.googlesource.com/c/chromium/src/+/1123396
    
    
    Prior to this change, Guest mode has an empty read-only DB and Incongito
    has a read-only DB. This CL allows both profiles to write to an "in
    memory" database that disapears when the profile is destroyed.
    
    This improves the experience for the user and avoids the possibility
    of using MediaCapabilites to detect incognito/guest profiles.
    
    Bug: 796280, 855631, 855215
    Change-Id: Ideb9dd2eabab2e594a24dd9b514557e473c3afc0
    Reviewed-on: https://chromium-review.googlesource.com/1123687
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574633}

    Changed files

    • chrome/browser/DEPS
    • chrome/browser/profiles/off_the_record_profile_impl.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • media/capabilities/BUILD.gn
    • media/capabilities/in_memory_video_decode_stats_db_impl.cc
    • media/capabilities/in_memory_video_decode_stats_db_impl.h
    • media/capabilities/in_memory_video_decode_stats_db_unittest.cc
    • media/capabilities/video_decode_stats_db.cc
    • media/capabilities/video_decode_stats_db.h
    • media/capabilities/video_decode_stats_db_impl.cc
    • media/capabilities/video_decode_stats_db_impl.h
    • media/capabilities/video_decode_stats_db_provider.cc
    • media/capabilities/video_decode_stats_db_provider.h
    • media/capabilities/video_decode_stats_db_unittest.cc
    • media/mojo/services/video_decode_perf_history.cc
    • media/mojo/services/video_decode_perf_history.h
    • media/mojo/services/video_decode_perf_history_unittest.cc
  17. Adds support for Assistant explore deep link.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:00:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9

    Comments

    Adds support for Assistant explore deep link.
    
    Deep link opens in the Assistant UI container.
    See bug for demo.
    
    Bug: b:111319842
    Change-Id: I1bf3d227beae70471986ff5f169488ec3b44bbcd
    Reviewed-on: https://chromium-review.googlesource.com/1132475
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574632}

    Changed files

    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
  18. Add Constructed/Destroying events to AssistantControllerObserver.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:59:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f58bcc5d430370a17613c0d8ff18d6ded2b16a1

    Comments

    Add Constructed/Destroying events to AssistantControllerObserver.
    
    These events are used to reduce the complexity of the circular
    dependency between AssistantController's sub-controllers.
    
    Bug: b:80542452
    Change-Id: If266ca01f844ec97d7f0b5f6a7216dac0da4e17f
    Reviewed-on: https://chromium-review.googlesource.com/1133587
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574631}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_controller_observer.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/assistant_screen_context_controller.cc
    • ash/assistant/assistant_screen_context_controller.h
    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/assistant_ui_controller.h
  19. [Autofill] Finalize cardholder name tooltip, and only show if textfield is prefilled

    Changed by Jared Saul - jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:58:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82955ec9a3ee0930e91b93cf7b6e50261b175192

    Comments

    [Autofill] Finalize cardholder name tooltip, and only show if textfield is prefilled
    
    Bug: 848955
    Change-Id: I0df815936fa2e9a09a9571760613277f34e2b1c5
    Reviewed-on: https://chromium-review.googlesource.com/1134394
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574630}

    Changed files

    • chrome/browser/ui/views/autofill/dialog_view_ids.h
    • chrome/browser/ui/views/autofill/save_card_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill_strings.grdp
  20. arc: Remove data on child transition fail.

    Changed by khmel@google.com - khmelohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:54:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef49be42c92ed17ab5ae4635843eeb4c35737eb5

    Comments

    arc: Remove data on child transition fail.
    
    This optionally resets ARC++ container in case child transition fails.
    This shows confirmation dialog and in case user accepts removes data and
    restart ARC++.
    
    TEST=Manually
    BUG=841939
    
    Change-Id: I07ecb1153acab7368f17ac15a957803132d6a101
    Reviewed-on: https://chromium-review.googlesource.com/1132529
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Yury Khmel <khmel@google.com>
    Cr-Commit-Position: refs/heads/master@{#574629}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/browser/chromeos/arc/auth/arc_auth_service.cc
    • chrome/browser/chromeos/arc/auth/arc_auth_service.h
    • chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/app_list/arc/arc_data_removal_dialog.h
    • chrome/browser/ui/browser_dialogs.h
    • chrome/browser/ui/views/arc_data_removal_dialog_view.cc
  21. [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:52:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e0fccc527819cb8e09682bc280fb35d4b3fafdd

    Comments

    [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.
    
    The first CL caused test failures because the browser_test was ignoring the
    "shift" key when searching for menu items. The IDC_SELECT_NEXT_TAB and
    IDC_SELECT_PREVIOUS_TAB only differ by the presence of "shift", so it cannot be
    ignored.
    
    > This matches other macOS application like Safari, Terminal, etc. All existing
    > hotkeys will still work.
    >
    > This CL uses the same hotkey for "previous tab" that Safari and Terminal use,
    > which is [ctr + shift + "Horizontal Tab"]. This also causes tests to pass.
    > However, pressing that key combination actually generates [ctr + shift + "End of
    > Medium"], which renderers in the Main Menu as a backwards tab. This CL updates
    > NSMenuItem(ChromeAdditions) to check for this special case.
    >
    > This CL removes two incorrect DCHECKs from render_widget_host_view_cocoa.mm. I
    > regularly hit both of them when running Chromium on a local build. They both
    > rely on the false assumption that keyEquivalents in the main menu must have the
    > command modifier.
    >
    > Bug: 851714
    > Reviewed-on: https://chromium-review.googlesource.com/1106659
    > Commit-Queue: Erik Chen <erikchen@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574211}
    
    Change-Id: Id87f364f5c5b303e8b9668e79f813a1c23376c98
    TBR: avi@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134203
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574628}

    Changed files

    • chrome/app/nibs/MainMenu.xib
    • chrome/browser/global_keyboard_shortcuts_mac.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
    • content/browser/renderer_host/render_widget_host_view_cocoa.mm
    • ui/events/test/cocoa_test_event_utils.mm
  22. Migrate AffiliationFetcher to SimpleURLLoader

    Changed by Mark Pilgrim - pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:48:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 176a3a3154870bc3e0722934c03d6dc3b5dae748

    Comments

    Migrate AffiliationFetcher to SimpleURLLoader
    
    Bug: 844947
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I08b3921d4a6e8ad2489a175cea5a5b883af32bbb
    Reviewed-on: https://chromium-review.googlesource.com/1129322
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574627}

    Changed files

    • chrome/browser/password_manager/password_store_factory.cc
    • components/password_manager/core/browser/BUILD.gn
    • components/password_manager/core/browser/DEPS
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.h
    • components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.h
    • components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/test_affiliation_fetcher_factory.h
    • components/password_manager/core/browser/password_store_factory_util.cc
    • components/password_manager/core/browser/password_store_factory_util.h
    • ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
  23. Fix a crash in MediaRouterDialogControllerViews

    Changed by Takumi Fujimoto - takumifohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:44:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ebcff160836f5c7057cad3694d19e7237475c26

    Comments

    Fix a crash in MediaRouterDialogControllerViews
    
    When trying to show the Views Cast Dialog, abort if a browser instance
    for the initiator WebContents is not found.
    
    Bug: 862671
    Change-Id: I00fd25490f8790624e87d2f77c9bfc8b95f59403
    Reviewed-on: https://chromium-review.googlesource.com/1134043
    Reviewed-by: Derek Cheng <imcheng@chromium.org>
    Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574626}

    Changed files

    • chrome/browser/ui/views/media_router/media_router_dialog_controller_views.cc
  24. [CrOS MultiDevice] Improve logging performance.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f39a6efa39053b51201f6c601a43955a5dd58a5f

    Comments

    [CrOS MultiDevice] Improve logging performance.
    
    Previously std::stringstream::str() was called twice, which generates
    two distinct (but identical) strings. This CL caches the result of the
    call and uses it twice.
    
    Bug: 862725
    Change-Id: I0384981a259b12d6c3ecf1420436f71e1e002fe6
    Reviewed-on: https://chromium-review.googlesource.com/1134218
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574625}

    Changed files

    • chromeos/components/proximity_auth/logging/logging.cc
  25. update hoverable pointerevent wpt

    Changed by Ella Ge - eirageohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:39:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df94a28e9988135e91dc8d0d841864344b7cde7c

    Comments

    update hoverable pointerevent wpt
    
    Update test wpt/pointerevent_attributes_hoverable_pointers
    
    This test was failing occationally on manual test, when we have
    clientX == box.right or clientY == box.bottom.
    update the test assertion so coordinates on border can be consider
    inside box.
    
    Note that on right border can also be outside box for the mouseevents.
    because we truncate the coordinates into interger.
    
    Bug: 863029
    Change-Id: Id20fbe0b6cf8566e6cdee229f427a0c747ed0c0a
    Reviewed-on: https://chromium-review.googlesource.com/1135432
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574624}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_attributes_hoverable_pointers-manual.html
  26. Reland "Fix OOPIF hit testing in layout tests."

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:38:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c09ebfd64bd9d402997f4c1ab5624d95347e2245

    Comments

    Reland "Fix OOPIF hit testing in layout tests."
    
    This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    
    The revert of this CL was determined to be the cause of some flaky tests
    on the chromeos bot. However those tests are disabled on linux and
    have been flaky on chromeos for a long time. See
    https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&builder=chromium.chromiumos%3Alinux-chromeos-rel&sortOrder=forward&sortColumn=test
    
    Original change's description:
    > Fix OOPIF hit testing in layout tests.
    >
    > If we haven't received an activated surface yet ensure that we fallback
    > to querying the renderer for the target of input events.
    >
    > BUG=601584
    >
    > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
    > Reviewed-on: https://chromium-review.googlesource.com/1131219
    > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573789}
    
    TBR=kenrb@chromium.org
    
    Bug: 601584
    Change-Id: Ifdd26f20bf6d44e704c33a7b7c4380a2de8c3696
    Reviewed-on: https://chromium-review.googlesource.com/1135471
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574623}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  27. Merge vr_shell/ Java namespace into vr/ namespace.

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:35:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbe916af89d21e6e4be335879b819bf3efaf8353

    Comments

    Merge vr_shell/ Java namespace into vr/ namespace.
    
    Bug: 862741
    
    NOPRESUBMIT=true
    TBR=yusufo@chromium.org
    
    Change-Id: If26bb6664b6b882db33327d381ccac6594d5ef65
    Reviewed-on: https://chromium-review.googlesource.com/1134091
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574622}

    Changed files

    • WATCHLISTS
    • base/android/jni_generator/jni_exception_list.gni
    • chrome/android/BUILD.gn
    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
    • chrome/android/java/src/org/chromium/chrome/browser/NavigationBarColorController.java
    • chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidUiGestureTarget.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidVSyncHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/EmptySniffingVrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/NoopCanvas.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnDispatchTouchEventCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnExitVrRequestListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VR_JAVA_OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrAlertDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCancelAnimationActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapperImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCompositorSurfaceManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreInfo.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionChecker.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionCheckerImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApi.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApiImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialogManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFeedbackStatus.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrInputConnection.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrMainActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrModalPresenter.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrPopupWindow.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToast.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToastManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrUiWidgetFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrWindowAndroid.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/BuildConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/GvrKeyboardLoaderClient.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/TextEditAction.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/VrInputMethodManagerWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/EmulatedVrController.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrFeedbackInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrInstallUpdateInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellCompositorViewHolderTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellControllerInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellDialogTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNativeUiTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNavigationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellWebInputEditingTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrDeviceTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTabTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockBrowserKeyboardInterface.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrCoreVersionCheckerImpl.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrDaydreamApi.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/AndroidManifest.xml
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/SimNfcActivity.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/HeadTrackingMode.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestriction.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestrictionRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/HeadTrackingUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NativeUiUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NfcSimUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/TransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrInfoBarUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrShellDelegateUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/vr_test_framework.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/browser/android/vr/BUILD.gn
    • chrome/browser/android/vr/vr_core_info.h
    • chrome/browser/android/vr/vr_shell_delegate.h
    • chrome/browser/vr/metrics/session_metrics_helper.h
    • chrome/browser/vr/test/vr_xr_browser_test.h
    • chrome/browser/vr/text_edit_action.h
    • chrome/browser/vr/ui_test_input.h
    • chrome/browser/vr/ui_unsupported_mode.h
    • chrome/browser/vr/webvr_input_browser_test.cc
    • chrome/browser/vr/webvr_tab_browser_test.cc
    • chrome/browser/vr/webvr_transition_browser_test.cc
    • chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeJUnit4ClassRunner.java
    • tools/perf/contrib/vr_benchmarks/vr_browsing_mode_pages.py
  28. Changed committed-interstitials flag from switch to feature.

    Changed by Carlos IL - carlosilohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49040ae795592d3b0c6a5b03533565caeb9ae266

    Comments

    Changed committed-interstitials flag from switch to feature.
    
    Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
    base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
    doing separate rampups for each kind of committed interstitial. Switch was
    changed to Feature so that it can be enabled via variations.
    
    Bug: 755632
    Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
    Reviewed-on: https://chromium-review.googlesource.com/1118975
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574621}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
    • chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
    • chrome/browser/ssl/connection_help_tab_helper.cc
    • chrome/browser/ssl/connection_help_tab_helper_browsertest.cc
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest_util.cc
    • chrome/browser/ssl/ssl_error_controller_client.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
    • chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
    • tools/metrics/histograms/enums.xml
  29. Migrate captive_portal to BindOnce

    Changed by Mark Pilgrim - pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:31:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dc10fe1b9fb22e9c1fb5a412b8440ba873866cf

    Comments

    Migrate captive_portal to BindOnce
    
    Bug: 714018
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia2bf1a8fa963f7540272a0d28961bfc961f14dd0
    Reviewed-on: https://chromium-review.googlesource.com/1131994
    Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574620}

    Changed files

    • chrome/browser/captive_portal/captive_portal_service.cc
    • components/captive_portal/captive_portal_detector.cc
    • components/captive_portal/captive_portal_detector.h
    • components/captive_portal/captive_portal_detector_unittest.cc
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.h
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.mm
  30. Removes Assistant horizontal page.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:30:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3753827af78b5c5e3f458acaf9017c1afd082459

    Comments

    Removes Assistant horizontal page.
    
    No longer needed.
    
    Bug: b:111315529
    Change-Id: Ic16af0891a296a535d67c46d43bc63eb86f6f6f1
    Reviewed-on: https://chromium-review.googlesource.com/1132347
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574619}

    Changed files

    • ash/app_list/BUILD.gn
    • ash/app_list/views/assistant_container_view.cc
    • ash/app_list/views/assistant_container_view.h
    • ash/app_list/views/horizontal_page_container.cc
    • ash/app_list/views/horizontal_page_container.h
  31. Adds caption bar to AssistantWebView UI.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:25:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 633097c22fed7171c82aabd1a3d001aab4510c78

    Comments

    Adds caption bar to AssistantWebView UI.
    
    In addition, this CL:
    - Adds a back button to the caption bar.
    - Adds API to change caption button visibility.
    
    Known issue:
    When navigating back from AssistantWebView UI, the Assistant
    container should not shrink. This is tracked in b/110433519.
    
    See bug for demo.
    
    Bug: b:111009446
    Change-Id: I63b47337d7ffcc8861c36529d04e9139800f4f4b
    Reviewed-on: https://chromium-review.googlesource.com/1132298
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#574618}

    Changed files

    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/ui/assistant_main_view.cc
    • ash/assistant/ui/assistant_web_view.cc
    • ash/assistant/ui/assistant_web_view.h
    • ash/assistant/ui/caption_bar.cc
    • ash/assistant/ui/caption_bar.h
    • ash/assistant/util/deep_link_util.cc
  32. [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895

    Changed by Peter K. Lee - pklohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:23:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f873a34ef2a72ed5d6bfcad35f5317c259d25fc7

    Comments

    [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895
    
    Added MDCShapedView.
    
    Bug: 863001
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ibfdc8430ff9d3f184eac341cd8d6fdf1fe5041d2
    Reviewed-on: https://chromium-review.googlesource.com/1135191
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574617}

    Changed files

    • DEPS
    • ios/third_party/material_components_ios/BUILD.gn
  33. Finish renaming "whitelist" to "allowlist".

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:17:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a27b817c70dec1ea68f4ea4b8711697ca694fb62

    Comments

    Finish renaming "whitelist" to "allowlist".
    
    Bug: 822317
    Change-Id: I155df06759c529dbd3183530c4722be3c4e0feb1
    Reviewed-on: https://chromium-review.googlesource.com/1133308
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574616}

    Changed files

    • content/browser/frame_host/render_frame_host_feature_policy_unittest.cc
    • third_party/blink/public/mojom/feature_policy/feature_policy.mojom
    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/feature_policy/feature_policy.h
  34. Separated harness and target page base urls.

    Changed by Peter Kvitek - kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2eb30bfc9ba51a4ac3a4f28bf2c728c3252620d

    Comments

    Separated harness and target page base urls.
    
    Change-Id: Ie6b2097fd8c03b486c2cab8ec3357a8c55907e92
    Reviewed-on: https://chromium-review.googlesource.com/1134498
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574615}

    Changed files

    • headless/test/data/protocol/inspector-protocol-test.html
    • headless/test/headless_protocol_browsertest.cc
    • third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
  35. Refactor canvas code to centralize CanvasResourceProvider ownership

    Changed by Justin Novosad - junovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8b8872f2080130c2b5bdf026f32f46aad7598da

    Comments

    Refactor canvas code to centralize CanvasResourceProvider ownership
    
    With this change, CanvasResourceProvider is always owned
    by CanvasResourceHost, except for a a few special case that use
    ephemeral resource providers.  This is a step towards unifying
    canvas and OffscreenCanvas presentation code paths.
    
    BUG=788439
    TBR=fserb@chromium.org, zmo@chromium.org
    NOTRY=true
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Id9bdbb2c3e93b264f67946b887419b47599df65d
    Reviewed-on: https://chromium-review.googlesource.com/1134182
    Commit-Queue: Justin Novosad <junov@chromium.org>
    Reviewed-by: Justin Novosad <junov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574614}

    Changed files

    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.h
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
    • third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
    • third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
    • third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.cc
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.h
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h
  36. Deflake resource loading hints and previews browsertest

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:14:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a875a2ea21d8a321295a11440c80af01bcf7fa86

    Comments

    Deflake resource loading hints and previews browsertest
    
    Attempt to deflake resource loading hints and previews
    browsertest by waiting for hints to be processed.
    
    Currently, the hints are processed on the background thread,
    and so may not be processed immediately.
    
    Log from the failed Linux test bots seem to indicate that
    the hints are not processed in time.
    See http://shortn/_IjBGHDP2Rp
    
    Bug: 789542,831838
    Change-Id: I6b30b1a86dc5d2cdef1cd8274cf5c6088bec8634
    Reviewed-on: https://chromium-review.googlesource.com/1134598
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574613}

    Changed files

    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  37. [NTP] Anchor custom backgrounds to the center of the window

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06072d0984b80b680e26ed0f498911ef35800af2

    Comments

    [NTP] Anchor custom backgrounds to the center of the window
    
    Bug: 862789
    Change-Id: Ia23e75d07d738e02571010aaf9cbd0a1bc486060
    Reviewed-on: https://chromium-review.googlesource.com/1134435
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574612}

    Changed files

    • chrome/renderer/searchbox/searchbox_extension.cc
  38. Modify XRSession so that session geometry is only sent when it changes

    Changed by Anna Offenwanger - offenwangerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a32f749ecae1923fda1485aa423b8e46dafddcf

    Comments

    Modify XRSession so that session geometry is only sent when it changes
    
    Making it so that instead of receiving geometry every frame, ar_core
    only gets geometry (frame size and rotation) when it changes. This saves
    some processing every frame, and allows the GetFrameData interface to be
    made uniform for AR and VR.
    
    Bug: 856259,846521
    Change-Id: I5828f57e1292f932c68148ac1e6b898f966b8d00
    Reviewed-on: https://chromium-review.googlesource.com/1115776
    Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Klaus Weidner <klausw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574611}

    Changed files

    • chrome/browser/android/vr/arcore_device/arcore_device.cc
    • chrome/browser/android/vr/arcore_device/arcore_device.h
    • chrome/browser/android/vr/arcore_device/arcore_gl.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl.h
    • device/vr/vr_device_base.cc
    • device/vr/vr_device_base.h
    • device/vr/vr_display_impl.cc
    • device/vr/vr_display_impl.h
    • third_party/blink/renderer/modules/xr/xr_frame_provider.cc
    • third_party/blink/renderer/modules/xr/xr_frame_provider.h
    • third_party/blink/renderer/modules/xr/xr_session.cc
    • third_party/blink/renderer/modules/xr/xr_session.h