Home | Search | chromium - Builders
Login

Builder Win7 FYI x64 Release (NVIDIA) Build 1660 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision75c9e38bcfe01f3a7c2637050ddcb2f342dd3034
Got Revision75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

Execution:

Steps and Logfiles:

Show:
  1. ( 525 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 359 ms ) remove .cipd
  4. ( 1 mins 3 secs ) bot_update
    [49GB/299GB used (16%)]
  5. ( 0 ) ensure_goma
  6. ( 655 ms ) swarming.py --version
    0.13
  7. ( 1 mins 22 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  9. ( 2 secs ) build directory
  10. ( 57 secs ) extract build
  11. ( 454 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 8 mins 51 secs ) angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:08:37.195730
  14. ( 48 secs ) angle_gles1_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 46s
  15. ( 50 secs ) angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 45s
  16. ( 1 ms ) test_pre_run (4)
  17. ( 28 secs ) angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 25s
  18. ( 1 mins 55 secs ) tab_capture_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:48.959910
  19. ( 32 secs ) gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 28s
  20. ( 30 secs ) gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 27s
  21. ( 24 secs ) gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 21s
  22. ( 1 mins 19 secs ) gles2_conform_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:17.521900
  23. ( 1 mins 29 secs ) gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:22.953370
  24. ( 1 mins 12 secs ) gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:07.342250
  25. ( 7 mins 39 secs ) gpu_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:07:01.766140
    Shard duration: 33s
  26. ( 26 secs ) swiftshader_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 24s
  27. ( 36 secs ) video_decode_accelerator_d3d11_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 34s
  28. ( 36 secs ) video_decode_accelerator_d3d9_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 34s
  29. ( 40 secs ) video_decode_accelerator_gl_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 39s
  30. ( 2 mins 52 secs ) context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:49.773840
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 2 mins 10 secs ) depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:08.135570
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 2 mins 30 secs ) gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:21.287140
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 1 mins 52 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:49.669230
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 2 mins 1 secs ) info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:00.326320
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 2 mins 7 secs ) maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:01.235990
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 4 mins 22 secs ) pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:04:18.291210
    Total tests: 48
    * Passed: 48 (48 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 2 mins 8 secs ) screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:05.230770
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 2 mins 36 secs ) trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:28.640190
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 2 mins 51 secs ) viz_screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:42.216600
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 19 mins 13 secs ) webgl2_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:09:44.805900 (shard #19)
    Max shard duration: 0:10:09.919310 (shard #18)
    Min shard duration: 0:07:48.627870 (shard #2)
    Total tests: 2761
    * Passed: 2697 (2697 expected, 0 unexpected)
    * Skipped: 64 (64 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 7 mins 31 secs ) webgl_conformance_d3d11_validating_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:18.079900 (shard #1)
    Min shard duration: 0:04:16.435880 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 7 mins 37 secs ) webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:18.723850 (shard #1)
    Min shard duration: 0:04:54.607700 (shard #0)
    Total tests: 922
    * Passed: 913 (913 expected, 0 unexpected)
    * Skipped: 9 (9 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  43. ( 7 mins 6 secs ) webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:06:58.436340 (shard #1)
    Min shard duration: 0:04:49.405890 (shard #0)
    Total tests: 922
    * Passed: 911 (911 expected, 0 unexpected)
    * Skipped: 11 (11 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  44. ( 7 mins 26 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:12.215920 (shard #1)
    Min shard duration: 0:04:06.439290 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  45. ( 7 mins 21 secs ) webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:16.515790 (shard #1)
    Min shard duration: 0:04:57.344140 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  46. ( 220 ms ) Tests statistics
     
    Stats
    Total shards: 56
    Total runtime: 3:23:43.432001
     
  47. ( 594 ms ) process_dumps
  48. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm765-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531387955595450, "id": "8941217059032251056", "project": "chromium", "tags": ["builder:Win7 FYI x64 Release (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win x64 Builder", "parent_buildnumber:8527", "scheduler_invocation_id:9106647121168956304", "scheduler_job_id:chromium/Win7 FYI x64 Release (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 FYI x64 Release (NVIDIA)" setup_build
buildnumber 1660 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win x64 Builder" setup_build
parent_got_angle_revision "c9c259cccb2ece20c516b45f2c3782e31860a528" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" setup_build
parent_got_revision_cp "refs/heads/master@{#574507}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" bot_update
got_revision_cp "refs/heads/master@{#574507}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
swarm_hashes {"angle_end2end_tests": "d91ba55ec4203a3327124d390a1e79f7b6cc2653", "angle_gles1_conformance_tests": "babf6f40646c8c46abe88eef2080e6da1050b963", "angle_unittests": "465acb1948dbe9a483a6621f616e50b2a5dd528f", "angle_white_box_tests": "a2dc2d57b731c13f5516267fdc51efe6e6a7e8e7", "browser_tests": "0836c039e97eb7bd0bc79d087a458601ef18524a", "gl_tests": "ee89005268093f9ae78a563b2ebd857a60990ab3", "gl_unittests": "5f9ca052779a443db42395280a411ef51fb6277a", "gles2_conform_test": "206dceff1d61d4070cc9763e4c70c5b86b109569", "gpu_unittests": "58348d13305c7c6855182abe034d3daa0fc7fb96", "swiftshader_unittests": "11f63153aac84e0aee89912da7f883de5eaac1a6", "telemetry_gpu_integration_test": "8f40dfcf07c4d7a5796e035efb2d9152e2494439", "video_decode_accelerator_unittest": "8755c21e5e436a003e702f67c42f1fee0137116e"} find isolated tests

Blamelist:

  1. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  2. rajendrant (rajendrantohnoyoudont@chromium.org)
  3. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  4. Aleks Totic (atoticohnoyoudont@chromium.org)
  5. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  6. Anita Woodruff (awdfohnoyoudont@chromium.org)
  7. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  8. Luciano Pacheco (lucmultohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 09:32:35 UTC
Start Thursday, 12-Jul-18 09:32:47 UTC
End Thursday, 12-Jul-18 11:31:15 UTC
Pending 12 secs
Execution 1 hrs 58 mins

All Changes:

  1. Add service worker README.md.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

    Comments

    Add service worker README.md.
    
    Bug: 795989
    Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d
    Reviewed-on: https://chromium-review.googlesource.com/1134718
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574507}

    Changed files

    • content/browser/service_worker/README.md
    • content/common/service_worker/README.md
    • third_party/blink/common/service_worker/README.md
    • third_party/blink/public/common/service_worker/README.md
    • third_party/blink/public/mojom/service_worker/README.md
    • third_party/blink/public/platform/modules/service_worker/README.md
    • third_party/blink/public/web/modules/service_worker/README.md
    • third_party/blink/renderer/modules/service_worker/README.md
  2. Use PLM for data saver site-breakdown

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62

    Comments

    Use PLM for data saver site-breakdown
    
    This CL adds PLM observer for site-breakdown that records the data use
    by host. The new codepath is enabled and the old data use asriber observer
    based site-breakdown codepath is disabled, based on a feature.
    
    Bug: 836029
    Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219
    Reviewed-on: https://chromium-review.googlesource.com/1050868
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574506}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • chrome/test/BUILD.gn
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
  3. Add new methods to EntryList and tests

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76bc398de31290a2d97ee6b7ea804a55d1d5451d

    Comments

    Add new methods to EntryList and tests
    
    Change the logic to add entries to My Files to account for volume being
    mounted/unmounted. This fixes some broken tests when running with the
    flag enabled by default, so test to cover this is on
    crrev.com/c/1131025.
    
    Fix test getMetadata function name.
    
    Bug: 857335
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id056b0e0d5c77a07c2561f6566bfc99111864917
    Reviewed-on: https://chromium-review.googlesource.com/1133613
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574505}

    Changed files

    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
  4. [LayoutNG] Fix static position for inline containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f321a196a45bce7d32257d0b93b472dba89e205a

    Comments

    [LayoutNG] Fix static position for inline containing block
    
    Bug: 740993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Iacdfc2694b2522c06a2512000ed1ca7f043b7541
    Reviewed-on: https://chromium-review.googlesource.com/1134386
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574504}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  5. NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:13:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 670a4fd7d5c89c8904f638edda72083e41e5d016

    Comments

    NetS13nServiceWorker: Add more info to traces in SWNavigationLoader
    
    Bug: 806658
    Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17
    Reviewed-on: https://chromium-review.googlesource.com/1134711
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574503}

    Changed files

    • content/browser/service_worker/service_worker_navigation_loader.cc
  6. [Android PageInfo] Refactor PageInfoController to enable testing

    Changed by Anita Woodruff - awdfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:05:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfb08c4ccef342639df17f6a423643df1784b767

    Comments

    [Android PageInfo] Refactor PageInfoController to enable testing
    
    - Extracted PermissionParamsListBuilder from PageInfoController
    to handle all the permission-related logic when displaying
    permissions in page info. This new class requires fewer
    hard-to-unit-test dependencies so its logic can now be tested.
    
    Bug: 691898
    Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4
    Reviewed-on: https://chromium-review.googlesource.com/1103564
    Commit-Queue: Anita Woodruff <awdf@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574502}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
  7. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc
  8. Change test to use full-path-for-testing attribute selector

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js