Home | Search | chromium - Builders
Login

Builder Win7 FYI Release (NVIDIA) Build 1613 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisione6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a
Got Revisione6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a

Execution:

Steps and Logfiles:

Show:
  1. ( 666 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 366 ms ) remove .cipd
  4. ( 1 mins 2 secs ) bot_update
    [51GB/299GB used (17%)]
  5. ( 638 ms ) swarming.py --version
    0.13
  6. ( 1 mins 17 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  8. ( 4 secs ) build directory
  9. ( 1 mins 29 secs ) extract build
  10. ( 359 ms ) find isolated tests
  11. ( 6 mins 7 secs ) angle_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:05:46.569430
  12. ( 2 mins 34 secs ) angle_gles1_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:51.244590
    Shard duration: 42s
  13. ( 1 mins 6 secs ) angle_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 59s
  14. ( 29 secs ) angle_white_box_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 27s
  15. ( 2 mins 12 secs ) tab_capture_end2end_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:09.796300
  16. ( 41 secs ) gl_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 36s
  17. ( 27 secs ) gl_tests_passthrough on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 26s
  18. ( 21 secs ) gl_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 18s
  19. ( 1 mins 38 secs ) gles2_conform_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:36.584530
  20. ( 1 mins 29 secs ) gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:26.996800
  21. ( 1 mins 27 secs ) gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:22.972990
  22. ( 40 secs ) gpu_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 34s
  23. ( 24 secs ) swiftshader_unittests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 19s
  24. ( 36 secs ) video_decode_accelerator_d3d11_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 33s
  25. ( 38 secs ) video_decode_accelerator_d3d9_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 36s
  26. ( 40 secs ) video_decode_accelerator_gl_unittest on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 37s
  27. ( 2 mins 54 secs ) context_lost_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:47.647040
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 2 mins 6 secs ) depth_capture_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:02.967230
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 3 mins 3 secs ) gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:57.530130
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 2 mins 28 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:26.804550
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 1 mins 52 secs ) info_collection_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:47.342180
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 3 mins 47 secs ) maps_pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:44.823530
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 5 mins 39 secs ) pixel_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:05:29.556100
    Total tests: 48
    * Passed: 48 (48 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 2 mins 54 secs ) screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:49.514410
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 3 mins 12 secs ) trace_test on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:09.678070
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 2 mins 51 secs ) viz_screenshot_sync_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:46.870130
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 14 mins 38 secs ) webgl2_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:05:16.854680 (shard #19)
    Max shard duration: 0:09:49.183640 (shard #1)
    Min shard duration: 0:08:03.931890 (shard #14)
    Total tests: 2761
    * Passed: 2697 (2697 expected, 0 unexpected)
    * Skipped: 64 (64 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 8 mins 47 secs ) webgl_conformance_d3d11_validating_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:08:29.606500 (shard #1)
    Min shard duration: 0:04:25.069710 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 7 mins 30 secs ) webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:15.657310 (shard #1)
    Min shard duration: 0:03:56.637530 (shard #0)
    Total tests: 922
    * Passed: 913 (913 expected, 0 unexpected)
    * Skipped: 9 (9 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 8 mins 49 secs ) webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:08:36.014330 (shard #1)
    Min shard duration: 0:03:51.871580 (shard #0)
    Total tests: 922
    * Passed: 911 (911 expected, 0 unexpected)
    * Skipped: 11 (11 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 7 mins 30 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:17.157740 (shard #1)
    Min shard duration: 0:04:01.783810 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 7 mins 58 secs ) webgl_conformance_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:07:44.853520 (shard #1)
    Min shard duration: 0:04:12.844610 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  43. ( 235 ms ) Tests statistics
     
    Stats
    Total shards: 56
    Total runtime: 3:20:07.858000
     
  44. ( 568 ms ) process_dumps
  45. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm752-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531407159615760, "id": "8941196922158024432", "project": "chromium", "tags": ["builder:Win7 FYI Release (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win Builder", "parent_buildnumber:8990", "scheduler_invocation_id:9106626984276452400", "scheduler_job_id:chromium/Win7 FYI Release (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 FYI Release (NVIDIA)" setup_build
buildnumber 1613 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win Builder" setup_build
parent_got_angle_revision "9ff9c7732a8731cac249127ee68f1f5f02d8eb63" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a" setup_build
parent_got_revision_cp "refs/heads/master@{#574555}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23950}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a" bot_update
got_revision_cp "refs/heads/master@{#574555}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes {"angle_end2end_tests": "1c76b648fd3fd833456aa6533c88da3853721d5b", "angle_gles1_conformance_tests": "004f7ade8b65c664a410b96c7aac973096c77306", "angle_perftests": "8fd4d930a1937fbb528545693ece7892fcd18ec4", "angle_unittests": "90c8beef0f4addb1ead1fafad6830353f5af6bf2", "angle_white_box_tests": "cce73f4682cac6d13d63ba3b2eba6f851f1d1e22", "browser_tests": "de44aad7dc0a07a2f15f0d215a47868e1dec8733", "command_buffer_perftests": "7252b6c184a3c6d281dbdade90ecc2ce330d382f", "gl_tests": "2f965ea318490fd42bf28cefc594342d860fcf86", "gl_unittests": "1d2a3f58fd69b5b4866a4f4f789be9b1347810a1", "gles2_conform_test": "2664756404fec6bb76621f5fecd5db82adbfa7fd", "gpu_unittests": "932987c25d70e8bd0840f5700d5274a136b65fab", "swiftshader_unittests": "4d3ed60eb67bdeaaddcf1f84dcaed738c07d6ef1", "telemetry_gpu_integration_test": "78aa922dc16dbf31a46d42874600652bc0bfa210", "video_decode_accelerator_unittest": "d2f49c2b164015567e173e02b372c3a09e6ffee1"} find isolated tests

Blamelist:

  1. Tiger Oakes (tigeroohnoyoudont@google.com)
  2. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. clamy (clamyohnoyoudont@chromium.org)
  4. Jan Wilken Doerrie (jdoerrieohnoyoudont@chromium.org)
  5. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  6. Colin Blundell (blundellohnoyoudont@chromium.org)
  7. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  8. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  9. Nico Weber (thakisohnoyoudont@chromium.org)
  10. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  11. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  12. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  13. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  14. Emily Hanley (eyaichohnoyoudont@google.com)
  15. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  16. Yoshisato Yanagisawa (yyanagisawaohnoyoudont@chromium.org)
  17. Mike West (mkwstohnoyoudont@chromium.org)
  18. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  19. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  20. Kent Tamura (tkentohnoyoudont@chromium.org)
  21. Ivan Sandrk (isandrkohnoyoudont@google.com)
  22. Mike West (mkwstohnoyoudont@chromium.org)
  23. Arthur Hemery (ahemeryohnoyoudont@chromium.org)
  24. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  25. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  26. Shik Chen (shikohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 14:52:39 UTC
Start Thursday, 12-Jul-18 14:52:44 UTC
End Thursday, 12-Jul-18 16:49:39 UTC
Pending 4 secs
Execution 1 hrs 56 mins

All Changes:

  1. Adds favicon for supersize UI

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 14:25:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6d9ffa49bc8e4b239cf5ebe1e7b886764280f5a

    Comments

    Adds favicon for supersize UI
    
    Creates a simple icon by taking the pie chart icon and giving it colors
    from the Chromium logo.
    (https://material.io/tools/icons/?search=pie_chart&icon=pie_chart)
    
    Icon:
    https://notwoods.github.io/chrome-supersize-reports/icon.png
    
    Bug: 847599
    Change-Id: Ib711bf0c717b9339914ec4ba2d9f369b33fb84d7
    Reviewed-on: https://chromium-review.googlesource.com/1134195
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Cr-Commit-Position: refs/heads/master@{#574555}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/favicon.ico
    • tools/binary_size/libsupersize/template_tree_view/index.html
  2. Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 14:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84a2e1ca7620207a3183a275d73d247035d4c078

    Comments

    Roll src/third_party/skia 4d6a844365e7..56a426a516d0 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/4d6a844365e7..56a426a516d0
    
    
    git log 4d6a844365e7..56a426a516d0 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5598148b7613..c9c259cccb2e (1 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    
    
    Created with:
      gclient setdep -r src/third_party/skia@56a426a516d0
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Iae08a82a8704081e534320f9183df4acbccb30d5
    Reviewed-on: https://chromium-review.googlesource.com/1134950
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574554}

    Changed files

    • DEPS
  3. Store multiple NavigationRequests in RenderFrameHost

    Changed by clamy - clamyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:52:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3bfdb09875f6b6cdadd5075d7c1f7305b5118ec

    Comments

    Store multiple NavigationRequests in RenderFrameHost
    
    This CL makes it so that RenderFrameHost can store several
    NavigationRequests waiting to commit instead of just one. This avoids
    deleting a NavigationRequest that would later commit (which can happen
    in quick navigations with a renderer process that is slow to process the
    commit).
    
    The regression test was originally written by arthursonzogni@chromium.org in
    https://chromium-review.googlesource.com/c/chromium/src/+/671351.
    
    The background for this change can be found in the following design doc:
    https://docs.google.com/document/d/1mXjxYJptb_bZ_EqGMF-c4LTSnhjt6Gn_WVvSrsinpq8/edit#.
    
    Bug: 738177
    Change-Id: Idd666e41bd2094c90fa576c77cdc26fb7b54cd7f
    Reviewed-on: https://chromium-review.googlesource.com/1082440
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574553}

    Changed files

    • content/browser/browser_side_navigation_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_browsertest.cc
    • content/browser/frame_host/navigation_controller_impl_unittest.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigator_impl_unittest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
    • content/browser/frame_host/render_frame_host_manager.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_browsertest.cc
    • content/browser/security_exploit_browsertest.cc
    • content/browser/site_per_process_browsertest.cc
    • content/browser/web_contents/web_contents_impl_unittest.cc
    • content/browser/webauth/webauth_browsertest.cc
    • content/public/test/browser_test_utils.cc
    • content/public/test/navigation_simulator.cc
    • content/public/test/test_renderer_host.cc
    • content/test/data/infinite_load_1.html
    • content/test/data/infinite_load_2.html
    • content/test/did_commit_provisional_load_interceptor.cc
    • content/test/did_commit_provisional_load_interceptor.h
    • content/test/test_render_frame_host.cc
    • content/test/test_render_frame_host.h
    • content/test/test_web_contents.cc
  4. [bluetooth] Move Map of Characteristics in Gatt Service

    Changed by Jan Wilken Doerrie - jdoerrieohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efd642e61e6933f8e78a607f02b2478652547e92

    Comments

    [bluetooth] Move Map of Characteristics in Gatt Service
    
    This change cleans up BluetoothRemoteGattService and its implementations
    by moving the map of characteristics into the base class. This allows
    for less code duplication and a simplified interface. Furthermore, a
    AddCharacterisitic helper method is introduced.
    
    Bug: 821766
    Change-Id: Ib370c599f1c8519d497a379c976c89c48d7ecb56
    Reviewed-on: https://chromium-review.googlesource.com/1131178
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574552}

    Changed files

    • content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
    • device/bluetooth/bluetooth_remote_gatt_characteristic.h
    • device/bluetooth/bluetooth_remote_gatt_service.cc
    • device/bluetooth/bluetooth_remote_gatt_service.h
    • device/bluetooth/bluetooth_remote_gatt_service_android.cc
    • device/bluetooth/bluetooth_remote_gatt_service_android.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.h
    • device/bluetooth/bluetooth_remote_gatt_service_mac.mm
    • device/bluetooth/bluetooth_remote_gatt_service_win.cc
    • device/bluetooth/bluetooth_remote_gatt_service_win.h
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.cc
    • device/bluetooth/bluetooth_remote_gatt_service_winrt.h
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.cc
    • device/bluetooth/bluez/bluetooth_remote_gatt_service_bluez.h
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.cc
    • device/bluetooth/cast/bluetooth_remote_gatt_service_cast.h
    • device/bluetooth/device_unittest.cc
    • device/bluetooth/test/fake_remote_gatt_service.cc
    • device/bluetooth/test/fake_remote_gatt_service.h
    • device/bluetooth/test/mock_bluetooth_gatt_service.cc
    • device/bluetooth/test/mock_bluetooth_gatt_service.h
    • device/fido/fido_ble_connection_unittest.cc
  5. [iOS] Create FindInPage UI for UI Refresh

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:41:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 81f3e175814bb20d103aa178a71272c2cd422193

    Comments

    [iOS] Create FindInPage UI for UI Refresh
    
    This CL creates the FindInPage UI to be used with UI Refresh.
    
    Bug: 805504
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ib6f5adcfde4560a589fed323a717b02c4566621d
    Reviewed-on: https://chromium-review.googlesource.com/1133160
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574551}

    Changed files

    • ios/chrome/browser/ui/find_bar/BUILD.gn
    • ios/chrome/browser/ui/find_bar/find_bar_controller_ios.mm
    • ios/chrome/browser/ui/find_bar/find_bar_ui_element.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.h
    • ios/chrome/browser/ui/find_bar/find_bar_view.mm
  6. MutablePO2TS: Fire token available when adding invalid token at startup

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:40:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d373e8d468f12b8ca7bbf6b979961e3a3f29cc73

    Comments

    MutablePO2TS: Fire token available when adding invalid token at startup
    
    ProfileOAuth2TokenService maintains the invariant that if the user is
    signed in at startup, the primary account is always present in
    PO2TS::GetAccounts().
    
    To maintain this invariant, MutableProfileOAuth2TokenServiceDelegate
    performs the following action when the load of tokens from the on-disk
    database is complete: if the user is signed in, it checks whether there
    is a token present for the primary account and if not, inserts an
    invalid token for that account. (The token can be absent due to e.g. a
    failure to decrypt the database on disk for whatever reason).
    
    However, MutablePO2TSDelegate does *not* fire the
    OnRefreshTokenAvailable() callback in that case. This breaks the
    implicit expectation of clients that when ProfileOAuth2TokenService adds
    an account, it will always fire OnRefreshTokenAvailable(). It is also
    inconsistent with the behavior if the primary account happens to have
    an invalid token on disk that is successfully decrypted: in that case,
    MutablePO2TSDelegate will fire the observer callback, but of course,
    from clients' POV there is no difference whatsoever between these two
    cases.
    
    In particular, the failure of this invariant can cause IdentityManager
    to crash if a user in this situation later signs out, as the token
    being revoked violates IdentityManager's expectation that it had
    previously been made aware of that token via a notification that it
    was available.
    
    This CL remedies the problem by firing OnRefreshTokenAvailable() in
    this case. It also extends the relevant MutablePO2TSDelegate unittest
    to fail without this change and succeed with this change.
    
    Bug: 860011
    Change-Id: I66cebda29ec56d79f209f6b2c93dff67797c57b4
    Reviewed-on: https://chromium-review.googlesource.com/1126861
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574550}

    Changed files

    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
    • chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
  7. [iOS] Hide clear button when the textfield is empty.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0056ea7bc75754d4ac5388b0ee9108cc604945d

    Comments

    [iOS] Hide clear button when the textfield is empty.
    
    Makes UI Refresh omnibox hide the clear button when the textfield
    is empty.
    
    Bug: 854622
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I7905efa0c5ead8c7c2884c27474ec992b970355c
    Reviewed-on: https://chromium-review.googlesource.com/1122627
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574549}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
  8. [Dice] Add drop down button to signin button in user menu

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:27:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dcd444b288c6dc6237db97575abc35e4e4d81ce

    Comments

    [Dice] Add drop down button to signin button in user menu
    
    The "Sync to another account" button in the user menu
    is removed and instead a drop down button is added to
    the right of the sign-in button.
    
    Bug: 824546
    Change-Id: I8b1b892962b17229dfdc057169a7f18132ffb58b
    Reviewed-on: https://chromium-review.googlesource.com/1133978
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574548}

    Changed files

    • chrome/browser/ui/views/profiles/profile_chooser_view.cc
  9. Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:25:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb527397d46f689b27ba693793620d1a2fb98493

    Comments

    Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.
    
    Bug: 843511
    Change-Id: I082a2c9e4d5e573f07bef1e0176f32db6344f2f0
    Reviewed-on: https://chromium-review.googlesource.com/1132400
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574547}

    Changed files

    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  10. Remove webkit-appearance.tentative.html WPT test

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:22:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af6945a93a039f0717fbc6037dd66a1db081fa65

    Comments

    Remove webkit-appearance.tentative.html WPT test
    
    This test is not a good indicator of -webkit-appearance support; it only
    checks whether computed-value == applied-value for -webkit-appearance
    values specified on a vanilla <div>. In reality most values of
    -webkit-appearance are not of interest to other UAs (see
    https://github.com/whatwg/compat/issues/6), and the behavior is
    different on different elements (e.g. <input>).
    
    Since this has caused issues across different platforms on Chrome (see
    bug), remove it.
    
    Bug: 810162
    Change-Id: I9d469cb624569f453978f3c56cc180eb07435b5b
    Reviewed-on: https://chromium-review.googlesource.com/1134387
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574546}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/compat/webkit-appearance.tentative.html
    • third_party/WebKit/LayoutTests/platform/mac/external/wpt/compat/webkit-appearance.tentative-expected.txt
  11. Avoid incomplete live region text change announcements

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:04:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a32928f26183dce010284f0abcee28508e44a6f8

    Comments

    Avoid incomplete live region text change announcements
    
    When a live region change occurs we sometimes fire text change events
    for only part of the text. For example, if "car" changes to "cat", we
    fire an event that makes it look like only the "t" changed.
    
    This changes the heuristic so that when a live region occurs that is
    not in an editor, it will prefer to indicate that entire text nodes
    have changed.
    
    Bug: 778478
    Change-Id: If87f1ac8c9c0b237bd422e8b7217d8d0347a13ab
    Reviewed-on: https://chromium-review.googlesource.com/1134201
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574545}

    Changed files

    • content/test/data/accessibility/event/description-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/name-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
    • ui/accessibility/platform/ax_platform_node_win.h
  12. Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0aeff28f34f12485a9148321c00383c633d48c63

    Comments

    Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/68d04f284423..5ff09fb5ee90
    
    
    git log 68d04f284423..5ff09fb5ee90 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 art-snake@yandex-team.ru Remove CPDF_HintTables::GetItemLength()
    2018-07-12 art-snake@yandex-team.ru Implement CPDF_HintsTable::SharedObjGroupInfo.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@5ff09fb5ee90
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I687479f194e638319b40fa5357179d8144f4b197
    Reviewed-on: https://chromium-review.googlesource.com/1134948
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574544}

    Changed files

    • DEPS
  13. Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e1637ff7a416934beedc7a637455779b85f6042

    Comments

    Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)
    
    https://webrtc.googlesource.com/src.git/+log/5795489e83ad..58c79f66dd3a
    
    
    git log 5795489e83ad..58c79f66dd3a --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 saza@webrtc.org Add saza to fuzzer owners
    2018-07-12 ilnik@webrtc.org Temporarly disable KSVC perf tests on Mac because of crashes
    2018-07-12 mbonadei@webrtc.org Removing -Wno-reorder from audio_device.
    2018-07-12 danilchap@webrtc.org Fix buffer overflow in ulpfec recovery
    2018-07-12 danilchap@webrtc.org Fix handling invalid empty red packets
    2018-07-12 buildbot@webrtc.org Roll chromium_revision 720dadbc21..efbdada3f7 (574387:574489)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@58c79f66dd3a
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:856823,chromium:856823,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I2e736098249694bb9480b4f170b065e60ddd44a2
    Reviewed-on: https://chromium-review.googlesource.com/1134949
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574543}

    Changed files

    • DEPS
  14. Updating names for job triggers on nexus5x and win 10 perf

    Changed by Emily Hanley - eyaichohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:55:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896ba71bc975b53346521228a32536296ea5d80e

    Comments

    Updating names for job triggers on nexus5x and win 10 perf
    
    Dependent on crrev.com/c/1131227
    
    NOTRY=True
    
    Bug: 758326
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: Icd5c18a166e815be5c2570cafd511bae4c545975
    Reviewed-on: https://chromium-review.googlesource.com/1131230
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574542}

    Changed files

    • infra/config/global/luci-milo-dev.cfg
    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py
  15. [unified-consent] USER_EVENT has its own sync pref group

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:50:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4432c3f9d16a93276eeb9c60a860190223888d96

    Comments

    [unified-consent] USER_EVENT has its own sync pref group
    
    This CL passes the information that unified consent is enabled to
    the sync service. It then uses it to move USER_EVENTS data type in
    a separate pref group (instead of having it tied to TYPED_URLS as
    before).
    
    The goal is not to un-link USER_EVENTS from HISTORY, but to have a
    separate toggle for USER_EVENTS (which will be linked to HISTORY toggle
    in the toggle UI).
    
    Unit tests have been updated accordingly.
    
    Bug: 860515
    
    Change-Id: Ic5461470114c0b05ec770817890c9123b81f3d77
    Reviewed-on: https://chromium-review.googlesource.com/1128876
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574541}

    Changed files

    • chrome/browser/android/contextualsearch/contextual_search_delegate.cc
    • chrome/browser/sync/profile_sync_service_factory.cc
    • chrome/browser/sync/test/integration/enable_disable_test.cc
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/sync/base/sync_prefs.cc
    • components/sync/base/sync_prefs.h
    • components/sync/base/sync_prefs_unittest.cc
  16. compare_build_artifacts: make ninja path command line option.

    Changed by Yoshisato Yanagisawa - yyanagisawaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:49:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3f55b21a7a48593a9ce1622346dad112a8b2e2f

    Comments

    compare_build_artifacts: make ninja path command line option.
    
    ninja seems not be in PATH when compare_build_artifacts.py is executed.
    Then compare_build_artifacts cannot compare object files difference,
    and just fails with exception.
    To fix that, let me make ninja path given with command line option.
    
    Bug: 862917
    Change-Id: Ieb7d7bd1db30217222f5cd5006e120244da28fd5
    Reviewed-on: https://chromium-review.googlesource.com/1134710
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574540}

    Changed files

    • tools/determinism/compare_build_artifacts.py
  17. Mark several layout tests as flaky.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:44:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704b3f013b80c7a5f93296e3d146758d5c0b0ccc

    Comments

    Mark several layout tests as flaky.
    
    - css3/filters/effect-brightness-clamping-hw.html
    - virtual/gpu/fast/canvas/canvas-blending-image-over-image.html
    - css3/filters/effect-drop-shadow-hw.html
    - external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862716, 862729, 862806, 862826
    Change-Id: I08126b22afdc0a7a4ef776dde8cc1120643acdcc
    Reviewed-on: https://chromium-review.googlesource.com/1134990
    Commit-Queue: Mike West <mkwst@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574539}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  18. macviews: switch back to Cocoa menus for Views context menus

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus
    
    This change:
    1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
       the Cocoa menu runner code;
    2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
    3) Fixes a latent bug in Textfield that could cause it to delete its context
       menu while handling a context menu activation - this is fine with Views menus
       but forbidden with Cocoa menus.
    
    Bug: 860673
    Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
    Reviewed-on: https://chromium-review.googlesource.com/1131564
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc
  19. Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:32:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78a0a24222fde0f77a45d4f78b1f4502496c434e

    Comments

    Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c228d491eb86..3973c26575e2
    
    
    git log c228d491eb86..3973c26575e2 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 dhanyaganesh@chromium.org CreateTarball: Add debug code with lsof
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@3973c26575e2
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Iabf74616719c8b90e6b34c6576772eeb313a7183
    Reviewed-on: https://chromium-review.googlesource.com/1134906
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574537}

    Changed files

    • DEPS
  20. Oilpan: Do not include wtf/functional.h

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

    Comments

    Oilpan: Do not include wtf/functional.h
    
    No one in platform/heap/ needs wtf/functional.h, though persistent.h
    needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.
    
    This CL reduces the pre-processed size of handle.h by 31KB.
    
    Bug: 242216
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
    Reviewed-on: https://chromium-review.googlesource.com/1134809
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574536}

    Changed files

    • third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
    • third_party/blink/renderer/modules/budget/budget_service.cc
    • third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
    • third_party/blink/renderer/modules/filesystem/directory_reader.cc
    • third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
    • third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
    • third_party/blink/renderer/modules/locks/lock.cc
    • third_party/blink/renderer/modules/mediastream/media_devices_test.cc
    • third_party/blink/renderer/modules/payments/payment_manager.cc
    • third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
    • third_party/blink/renderer/modules/webusb/usb_device.cc
    • third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/skia_texture_holder.h
    • third_party/blink/renderer/platform/heap/persistent.h
    • third_party/blink/renderer/platform/heap/thread_state.h
    • third_party/blink/renderer/platform/testing/empty_web_media_player.h
    • third_party/blink/renderer/platform/testing/unit_test_helpers.cc
  21. Add UMA for locked-fullscreen state

    Changed by Ivan Sandrk - isandrkohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fe933a784678f6aa62203b7d57a638051c15f2a

    Comments

    Add UMA for locked-fullscreen state
    
    Locked-fullscreen state will be used for giving student quizzes on managed
    Chrome OS devices in schools. Add a UMA to track feature adoption.
    
    Change-Id: I59f809e2aecd67a4e9f10ee21a28658796c03b15
    Reviewed-on: https://chromium-review.googlesource.com/1126241
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574535}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  22. Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84356c12447981846eda650f06085913fa831126

    Comments

    Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862907
    Change-Id: If6ce15cb1633ae74177e385774a1cef7010e67c0
    Reviewed-on: https://chromium-review.googlesource.com/1134989
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574534}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  23. Navigation: Refactoring WebContents unittests to use NavigationSimulator

    Changed by Arthur Hemery - ahemeryohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:20:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c65bc1abc46c630c53a3e21bb0670dc602e8d37d

    Comments

    Navigation: Refactoring WebContents unittests to use NavigationSimulator
    
    Removed the usage of TestWebContents->DidNavigate variants in
    web_contents_impl_unittest.cc. Some usage remains, linked to
    overlapping navigations and other specific usages.
    
    Bug: 728571
    Change-Id: Ie2d6b73cb5deea077f720114fdd45ab4ee714c0a
    Reviewed-on: https://chromium-review.googlesource.com/1076240
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Commit-Queue: Arthur Hemery <ahemery@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574533}

    Changed files

    • content/browser/web_contents/web_contents_impl_unittest.cc
  24. Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a66959734236ca95f9372334bfa18bbc7a5a1b52

    Comments

    Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)
    
    https://skia.googlesource.com/skia.git/+log/fcc10da18eb5..4d6a844365e7
    
    
    git log fcc10da18eb5..4d6a844365e7 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
    2018-07-12 herb@google.com Use new SkGlyphIDSet - v3
    2018-07-12 bungeman@google.com Remove SkDrawFilter.
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5c8113d3c20f..5598148b7613 (8 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 robertphillips@google.com Revert "build debug on linux for gdb"
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 caryclark@google.com build debug on linux for gdb
    2018-07-12 benjaminwagner@google.com Update Win10 in Skolo.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@4d6a844365e7
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ifd4c74ca893ddae66e41fe10ff663287be1cf325
    Reviewed-on: https://chromium-review.googlesource.com/1134148
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574532}

    Changed files

    • DEPS
  25. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification
    
    When a non-ARC normal window (eg. Chrome browser window) was active, the
    inline textbox didn't work for the second time and later. This CL solves
    this issue.
    
    This was because the widget was not activated correctly (IsActive() was
    true but CanActivate() was false) in that case. This CL removes the
    IsActive() guard to make the widget active correctly whenever the inline
    reply opens.
    
    Bug: b/111100376
    Bug: 858938
    Test: manual (inline reply can be used multiple times)
    
    Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
    Reviewed-on: https://chromium-review.googlesource.com/1133039
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
  26. media: sync the camera metadata definitions

    Changed by Shik Chen - shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions
    
    We need some new metadata tags for external camera, so regenerate and
    sync all of them in arc-camera, chromium, and ARC++.
    
    Some "arc" are replaced by "cros" manually.
    
    BUG=b:77833131
    TEST=Verify CCA works on Nautilus.
    
    Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
    Reviewed-on: https://chromium-review.googlesource.com/1117970
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom