Home | Search | chromium - Builders
Login

Builder Win7 FYI Release (AMD) Build 2182 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision39e00c42d85fedf2a20f7ee4889a7f101def4975
Got Revision39e00c42d85fedf2a20f7ee4889a7f101def4975

Execution:

Steps and Logfiles:

Show:
  1. ( 547 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 1 mins 12 secs ) bot_update
    [56GB/299GB used (18%)]
  4. ( 676 ms ) swarming.py --version
    0.13
  5. ( 20 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  7. ( 4 secs ) build directory
  8. ( 1 mins 29 secs ) extract build
  9. ( 423 ms ) find isolated tests
  10. ( 4 secs ) angle_end2end_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:06:05.541470
  11. ( 2 secs ) angle_gles1_conformance_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:17.828960
  12. ( 4 secs ) angle_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 51s
  13. ( 1 secs ) angle_white_box_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 31s
  14. ( 2 mins 30 secs ) tab_capture_end2end_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:25.984040
  15. ( 35 secs ) gl_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 32s
  16. ( 28 secs ) gl_tests_passthrough on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 26s
  17. ( 21 secs ) gl_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 19s
  18. ( 2 mins 10 secs ) gles2_conform_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:07.120090
  19. ( 1 mins 53 secs ) gles2_conform_d3d9_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:47.380260
  20. ( 1 mins 44 secs ) gles2_conform_gl_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:37.514300
  21. ( 44 secs ) gpu_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 36s
  22. ( 1 secs ) swiftshader_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 22s
  23. ( 39 secs ) video_decode_accelerator_d3d11_unittest on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 34s
  24. ( 35 secs ) video_decode_accelerator_d3d9_unittest on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 33s
  25. ( 39 secs ) video_decode_accelerator_gl_unittest on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 35s
  26. ( 3 mins 34 secs ) context_lost_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:27.744270
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 2 mins 19 secs ) depth_capture_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:12.885900
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 3 mins 22 secs ) gpu_process_launch_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:16.131410
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 2 mins 37 secs ) hardware_accelerated_feature_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:32.988130
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 3 mins 51 secs ) info_collection_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:48.534160
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 2 mins 30 secs ) maps_pixel_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:29.429420
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 6 mins 39 secs ) pixel_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:06:30.233870
    Total tests: 53
    * Passed: 53 (53 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 2 mins 43 secs ) screenshot_sync_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:40.886900
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 3 mins 2 secs ) trace_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:56.218280
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 2 mins 41 secs ) viz_screenshot_sync_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:35.239210
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 15 mins 43 secs ) webgl2_conformance_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 42s (shard #19)
    Max shard duration: 0:15:28.563380 (shard #11)
    Min shard duration: 0:09:06.908490 (shard #15)
    Total tests: 2767
    * Passed: 2704 (2704 expected, 0 unexpected)
    * Skipped: 63 (63 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 9 mins 39 secs ) webgl_conformance_d3d11_validating_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:09:34.940730 (shard #1)
    Min shard duration: 0:05:59.261650 (shard #0)
    Total tests: 924
    * Passed: 917 (917 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 9 mins 22 secs ) webgl_conformance_d3d9_passthrough_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:09:04.347130 (shard #1)
    Min shard duration: 0:04:50.164400 (shard #0)
    Total tests: 924
    * Passed: 916 (916 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 9 mins 15 secs ) webgl_conformance_d3d9_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:08:56.409410 (shard #1)
    Min shard duration: 0:04:47.468800 (shard #0)
    Total tests: 924
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 10 (10 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 9 mins 9 secs ) webgl_conformance_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:08:49.895770 (shard #1)
    Min shard duration: 0:05:37.314650 (shard #0)
    Total tests: 924
    * Passed: 917 (917 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 204 ms ) Tests statistics
     
    Stats
    Total shards: 54
    Total runtime: 4:10:49.526999
     
  42. ( 590 ms ) process_dumps
  43. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm758-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1533962295788780, "id": "8938517667689956064", "project": "chromium", "tags": ["builder:Win7 FYI Release (AMD)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/39e00c42d85fedf2a20f7ee4889a7f101def4975", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win Builder", "parent_buildnumber:11609", "scheduler_invocation_id:9103947730090852640", "scheduler_job_id:chromium/Win7 FYI Release (AMD)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 FYI Release (AMD)" setup_build
buildnumber 2182 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win Builder" setup_build
parent_got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" setup_build
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" setup_build
parent_got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" setup_build
parent_got_revision "39e00c42d85fedf2a20f7ee4889a7f101def4975" setup_build
parent_got_revision_cp "refs/heads/master@{#582427}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" setup_build
parent_got_v8_revision_cp "refs/heads/7.0.193@{#2}" setup_build
parent_got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#24263}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "39e00c42d85fedf2a20f7ee4889a7f101def4975" setup_build
got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" bot_update
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" bot_update
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" bot_update
got_revision "39e00c42d85fedf2a20f7ee4889a7f101def4975" bot_update
got_revision_cp "refs/heads/master@{#582427}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" bot_update
got_v8_revision_cp "refs/heads/7.0.193@{#2}" bot_update
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" bot_update
got_webrtc_revision_cp "refs/heads/master@{#24263}" bot_update
swarm_hashes {"angle_end2end_tests": "ce9fe03acf0e177c529767d64c11f5f6dc74319f", "angle_gles1_conformance_tests": "9d9f2bb8ce58d49e9beb711b5f66ba6132610061", "angle_perftests": "419088b844417057a98a499e9c988a6c926bf213", "angle_unittests": "2802893c3d5ada714ff22a0cc67366ae7f73cc17", "angle_white_box_tests": "54e16d9c109b22cd4241432864aa6d1af8299313", "browser_tests": "d453764b6a5542a51391ac1129148808ab81b913", "command_buffer_perftests": "c71245e666f8520df0eff93f825678d8277f69d0", "gl_tests": "6db82eb706dc29234eb4886f7e0acdd792c6be22", "gl_unittests": "175b19ae8459da08a4011cc60f5c95df983ce622", "gles2_conform_test": "d3d239abd997c9da03fa5985c85369f091c16042", "gpu_unittests": "ebd4074a2c21165660ce3aa8845ee395c19f44dd", "swiftshader_unittests": "6562d4a309a834b0cf6c572a94d9b5611643cb83", "telemetry_gpu_integration_test": "9459b70cc440672587743c40398bacd498f3ab83", "video_decode_accelerator_unittest": "0235c9b9d215fa931d4ba55c08e64b45557d8081"} find isolated tests

Blamelist:

  1. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  2. Julie Jeongeun Kim (jkimohnoyoudont@igalia.com)
  3. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 04:38:15 UTC
Start Saturday, 11-Aug-18 04:38:20 UTC
End Saturday, 11-Aug-18 06:25:17 UTC
Pending 4 secs
Execution 1 hrs 46 mins

All Changes:

  1. Revert "chromeos: add SingleProcessMash mode"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 03:38:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39e00c42d85fedf2a20f7ee4889a7f101def4975

    Comments

    Revert "chromeos: add SingleProcessMash mode"
    
    This reverts commit b092ae622b9ab3856d64d3eca543e4ecb243be77.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 582411 as the
    culprit for failures in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2IwOTJhZTYyMmI5YWIzODU2ZDY0ZDNlY2E1NDNlNGVjYjI0M2JlNzcM
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/7241
    
    Sample Failed Step: ash_content_unittests
    
    Original change's description:
    > chromeos: add SingleProcessMash mode
    > 
    > This makes Ash create an Env if passed SingleProcessMash. In addition this
    > makes all window creation go through a factory that ensures the right env is
    > supplied.
    > 
    > See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
    > for more details.
    > 
    > This also adds the feature to ui/base.
    > 
    > BUG=847992
    > TEST=covered by tests
    > 
    > Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
    > Reviewed-on: https://chromium-review.googlesource.com/1168282
    > Commit-Queue: Scott Violet <sky@chromium.org>
    > Reviewed-by: James Cook <jamescook@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582411}
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    BUG=847992
    
    Change-Id: I9e2e3c0d92dc7b51f08fa35a2dfacd5ca8af57f2
    Reviewed-on: https://chromium-review.googlesource.com/1171706
    Cr-Commit-Position: refs/heads/master@{#582427}

    Changed files

    • ash/BUILD.gn
    • ash/README.md
    • ash/app_launch_unittest.cc
    • ash/ash_service_unittest.cc
    • ash/components/fast_ink/fast_ink_view.cc
    • ash/display/cursor_window_controller.cc
    • ash/display/display_manager_unittest.cc
    • ash/display/display_util.cc
    • ash/display/mirror_window_controller.cc
    • ash/display/mouse_cursor_event_filter_unittest.cc
    • ash/display/root_window_transformers_unittest.cc
    • ash/display/screen_ash.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/display/unified_mouse_warp_controller_unittest.cc
    • ash/display/window_tree_host_manager_unittest.cc
    • ash/drag_drop/drag_drop_tracker.cc
    • ash/events/event_rewriter_controller.cc
    • ash/extended_desktop_unittest.cc
    • ash/frame/detached_title_area_renderer.cc
    • ash/frame/header_view.cc
    • ash/host/DEPS
    • ash/host/ash_window_tree_host.cc
    • ash/host/ash_window_tree_host_platform.cc
    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/keyboard/test_keyboard_ui.cc
    • ash/magnifier/docked_magnifier_controller.cc
    • ash/magnifier/magnification_controller_unittest.cc
    • ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
    • ash/public/cpp/frame_border_hit_test.cc
    • ash/root_window_controller.cc
    • ash/root_window_controller_unittest.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_window_watcher_unittest.cc
    • ash/shell.cc
    • ash/shell.h
    • ash/shell_unittest.cc
    • ash/system/message_center/arc/arc_notification_content_view_unittest.cc
    • ash/system/message_center/arc/arc_notification_view_unittest.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.h
    • ash/system/night_light/night_light_controller.cc
    • ash/system/overview/overview_button_tray_unittest.cc
    • ash/system/tray/tray_background_view.cc
    • ash/test/ash_test_base.cc
    • ash/test/ash_test_helper.cc
    • ash/test/ash_test_suite.cc
    • ash/test/ui_controls_factory_ash.cc
    • ash/utility/screenshot_controller_unittest.cc
    • ash/wayland/wayland_server_controller.cc
    • ash/wayland/wayland_server_controller.h
    • ash/window_factory.cc
    • ash/window_factory.h
    • ash/window_user_data_unittest.cc
    • ash/wm/ash_focus_rules_unittest.cc
    • ash/wm/cursor_manager_chromeos.cc
    • ash/wm/drag_window_controller.cc
    • ash/wm/drag_window_resizer_unittest.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • ash/wm/native_cursor_manager_ash_classic.cc
    • ash/wm/non_client_frame_controller.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/stacking_controller_unittest.cc
    • ash/wm/system_gesture_event_filter_unittest.cc
    • ash/wm/system_modal_container_layout_manager_unittest.cc
    • ash/wm/top_level_window_factory.cc
    • ash/wm/toplevel_window_event_handler.cc
    • ash/wm/toplevel_window_event_handler_unittest.cc
    • ash/wm/video_detector.cc
    • ash/wm/window_dimmer.cc
    • ash/wm/window_dimmer_unittest.cc
    • ash/wm/workspace/workspace_event_handler_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • ash/wm/workspace/workspace_window_resizer_unittest.cc
    • ash/wm/workspace_controller_unittest.cc
    • ash/ws/window_service_owner.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/ui/ash/ksv/DEPS
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
    • components/exo/test/exo_test_base.cc
    • components/exo/wayland/clients/test/wayland_client_test.cc
    • ui/aura/env.cc
    • ui/aura/env.h
    • ui/aura/test/test_windows.cc
    • ui/aura/test/test_windows.h
    • ui/aura/window.cc
    • ui/aura/window.h
    • ui/aura/window_tree_host_platform.cc
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  2. Deliver bounds information to CreateTooltipWidget

    Changed by Julie Jeongeun Kim - jkimohnoyoudont@igalia.com
    Changed at Saturday, 11-Aug-18 03:37:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 490c27babbe440762253c71c8ddc2438d3814d0e

    Comments

    Deliver bounds information to CreateTooltipWidget
    
    When 'CreateTooltipWidget' creates 'Widget' for tooltip and
    initializes it, it needs its bounds at InitParams. If it
    doesn't have the bounds information, some platform widgets
    get crashed and DesktopWindowTreeHostX11 keeps
    |sanitized_params| to avoid this case.
    
    This patch delivers the bounds for the tooltip widget and
    adds DCHECK to find what causes the empty bounds.
    
    Bug: 849585
    Change-Id: I3de067a917e4343bab642c3a1b13434b6cfaeee0
    Reviewed-on: https://chromium-review.googlesource.com/1086820
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#582426}

    Changed files

    • ui/platform_window/x11/x11_window_base.cc
    • ui/views/corewm/tooltip_aura.cc
    • ui/views/corewm/tooltip_aura.h
  3. Updating trunk VERSION from 3519.0 to 3520.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 03:08:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c172804c44cf480776c1acfb741e756bbf7cb1e

    Comments

    Updating trunk VERSION from 3519.0 to 3520.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=amineer@chromium.org
    
    Change-Id: I4cabb60493cd431bb673a5459e1283c615c6c0ec
    Reviewed-on: https://chromium-review.googlesource.com/1171982
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582425}

    Changed files

    • chrome/VERSION