Home | Search | chromium - Builders
Login

Builder Win7 FYI Debug (AMD) Build 1053 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision4c172804c44cf480776c1acfb741e756bbf7cb1e
Got Revision4c172804c44cf480776c1acfb741e756bbf7cb1e

Execution:

Steps and Logfiles:

Show:
  1. ( 628 ms ) setup_build
    running recipe: "chromium"
  2. ( 6 secs ) taskkill
  3. ( 1 mins 12 secs ) bot_update
    [59GB/299GB used (19%)]
  4. ( 697 ms ) swarming.py --version
    0.13
  5. ( 20 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  7. ( 5 secs ) build directory
  8. ( 1 mins 53 secs ) extract build
  9. ( 955 ms ) find isolated tests
  10. ( 4 secs ) angle_end2end_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:09:25.710020
  11. ( 1 secs ) angle_gles1_conformance_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:06.925740
  12. ( 4 secs ) angle_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:48.700050
  13. ( 1 secs ) angle_white_box_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 33s
  14. ( 52 secs ) gl_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 47s
  15. ( 39 secs ) gl_tests_passthrough on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 36s
  16. ( 27 secs ) gl_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 26s
  17. ( 2 mins 30 secs ) gles2_conform_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:29.079440
  18. ( 2 mins 36 secs ) gles2_conform_d3d9_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:33.447340
  19. ( 2 mins 39 secs ) gles2_conform_gl_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:37.506050
  20. ( 1 mins 15 secs ) gpu_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:01:09.000540
  21. ( 1 secs ) swiftshader_unittests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 24s
  22. ( 52 secs ) video_decode_accelerator_d3d11_unittest on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 48s
  23. ( 40 secs ) video_decode_accelerator_d3d9_unittest on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 38s
  24. ( 50 secs ) video_decode_accelerator_gl_unittest on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 47s
  25. ( 4 mins 18 secs ) context_lost_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:04:11.028750
    Total tests: 8
    * Passed: 7 (7 expected, 0 unexpected)
    * Skipped: 1 (1 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 2 mins 8 secs ) depth_capture_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:01.651740
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 3 mins 10 secs ) gpu_process_launch_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:05.392910
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 3 mins 25 secs ) hardware_accelerated_feature_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:19.173560
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 3 mins 36 secs ) info_collection_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:29.621280
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 4 mins 17 secs ) maps_pixel_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:04:08.625170
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 7 mins 5 secs ) pixel_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:06:54.658320
    Total tests: 53
    * Passed: 53 (53 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 4 mins 8 secs ) screenshot_sync_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:04:03.074420
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 3 mins 8 secs ) trace_test on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:03:00.614090
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 2 mins 44 secs ) viz_screenshot_sync_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:02:40.362090
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 25 mins 59 secs ) webgl_conformance_d3d11_validating_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:25:54.769890 (shard #1)
    Min shard duration: 0:10:29.534880 (shard #0)
    Total tests: 924
    * Passed: 917 (917 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 24 mins 59 secs ) webgl_conformance_d3d9_passthrough_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:24:50.837490 (shard #1)
    Min shard duration: 0:08:33.793810 (shard #0)
    Total tests: 924
    * Passed: 916 (916 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 25 mins 16 secs ) webgl_conformance_d3d9_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:25:07.057110 (shard #1)
    Min shard duration: 0:08:12.251260 (shard #0)
    Total tests: 924
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 10 (10 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 25 mins 45 secs ) webgl_conformance_tests on ATI GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max shard duration: 0:25:41.136480 (shard #1)
    Min shard duration: 0:10:36.946350 (shard #0)
    Total tests: 924
    * Passed: 917 (917 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 236 ms ) Tests statistics
     
    Stats
    Total shards: 33
    Total runtime: 2:42:55.133001
     
  40. ( 611 ms ) process_dumps
  41. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm759-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1533958985678700, "id": "8938521138592173168", "project": "chromium", "tags": ["builder:Win7 FYI Debug (AMD)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/4c172804c44cf480776c1acfb741e756bbf7cb1e", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win Builder (dbg)", "parent_buildnumber:7856", "scheduler_invocation_id:9103951200698557360", "scheduler_job_id:chromium/Win7 FYI Debug (AMD)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 FYI Debug (AMD)" setup_build
buildnumber 1053 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win Builder (dbg)" setup_build
parent_got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" setup_build
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" setup_build
parent_got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" setup_build
parent_got_revision "4c172804c44cf480776c1acfb741e756bbf7cb1e" setup_build
parent_got_revision_cp "refs/heads/master@{#582425}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" setup_build
parent_got_v8_revision_cp "refs/heads/7.0.193@{#2}" setup_build
parent_got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#24263}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "4c172804c44cf480776c1acfb741e756bbf7cb1e" setup_build
got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" bot_update
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" bot_update
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" bot_update
got_revision "4c172804c44cf480776c1acfb741e756bbf7cb1e" bot_update
got_revision_cp "refs/heads/master@{#582425}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" bot_update
got_v8_revision_cp "refs/heads/7.0.193@{#2}" bot_update
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" bot_update
got_webrtc_revision_cp "refs/heads/master@{#24263}" bot_update
swarm_hashes {"angle_end2end_tests": "82871d384257bcd75a40a9df6f16d581c2f3f625", "angle_gles1_conformance_tests": "b205dd177de402e325bd1ec1fd4e94756dc8d283", "angle_unittests": "a6cb9de014d074826d8a7ffac2a258420ee9438c", "angle_white_box_tests": "f2b4d4c76b974af6fa96cd413c59c5b3db653aef", "browser_tests": "d22415575f636ef6b41c8582ca2bdf781d2287e0", "gl_tests": "b59bb5a731a8a2994dd92717c339ec83b41b69ce", "gl_unittests": "64da409b25a94e1608606a27d73d8712d657d999", "gles2_conform_test": "19cd2e3d7673acdbc1218f37238f5b1710b43803", "gpu_unittests": "1979785a465c6bde859b0e395b3b0dd93c72feff", "swiftshader_unittests": "ddfcb6cfe44d600df736c1b55e16841f9e861149", "telemetry_gpu_integration_test": "f4f0b9279fed39fdda37729bd51023dec2058039", "video_decode_accelerator_unittest": "499718da70bf4c25b3163472c90599e5205e4bab"} find isolated tests

Blamelist:

  1. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  2. Peter Kasting (pkastingohnoyoudont@chromium.org)
  3. Peter Kasting (pkastingohnoyoudont@chromium.org)
  4. Ned Nguyen (nednguyenohnoyoudont@google.com)
  5. Wez (wezohnoyoudont@chromium.org)
  6. Stephen Martinis (martinissohnoyoudont@chromium.org)
  7. Peter Kasting (pkastingohnoyoudont@chromium.org)
  8. Yafei Duan (romaxohnoyoudont@chromium.org)
  9. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  10. Joe Mason (joenotcharlesohnoyoudont@chromium.org)
  11. Chris Palmer (palmerohnoyoudont@chromium.org)
  12. Kai Ninomiya (kaininoohnoyoudont@chromium.org)
  13. siyua (siyuaohnoyoudont@chromium.org)
  14. Antoine Labour (pimanohnoyoudont@chromium.org)
  15. Scott Violet (skyohnoyoudont@chromium.org)
  16. Jun Mukai (mukaiohnoyoudont@chromium.org)
  17. Matthew Cary (mattcaryohnoyoudont@chromium.org)
  18. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  19. Wenzhao Zang (wzangohnoyoudont@chromium.org)
  20. Stephen Martinis (martinissohnoyoudont@chromium.org)
  21. Lei Zhang (thestigohnoyoudont@chromium.org)
  22. John Chen (johnchenohnoyoudont@chromium.org)
  23. Adolfo Victoria (adokarohnoyoudont@google.com)
  24. angle-chromium-autoroll (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  25. Emil A Eklund (eaeohnoyoudont@chromium.org)
  26. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
  27. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  28. Dale Curtis (dalecurtisohnoyoudont@chromium.org)
  29. Zhenyao Mo (zmoohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 03:43:05 UTC
Start Saturday, 11-Aug-18 03:43:08 UTC
End Saturday, 11-Aug-18 06:24:53 UTC
Pending 3 secs
Execution 2 hrs 41 mins

All Changes:

  1. Updating trunk VERSION from 3519.0 to 3520.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 03:08:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c172804c44cf480776c1acfb741e756bbf7cb1e

    Comments

    Updating trunk VERSION from 3519.0 to 3520.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=amineer@chromium.org
    
    Change-Id: I4cabb60493cd431bb673a5459e1283c615c6c0ec
    Reviewed-on: https://chromium-review.googlesource.com/1171982
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582425}

    Changed files

    • chrome/VERSION
  2. Revert "Make //content layer default to --site-per-process mode on desktop."

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 02:23:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2595d82ddfcf666d41d33e1ce881e52401d31454

    Comments

    Revert "Make //content layer default to --site-per-process mode on desktop."
    
    This reverts commit 3b8db25cc597a642ee4b7cbaf2655c631353a799.
    
    Reason for revert: Checking to see whether this caused https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477343009904/+/steps/content_browsertests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings/0 and similar.
    
    Original change's description:
    > Make //content layer default to --site-per-process mode on desktop.
    > 
    > After this CL site-per-process is the default in all layers on desktop
    > platforms, except:
    > 
    > - Layout Tests which still run with no isolation by default
    >   (see https://crbug.com/856734#c5 for the explanation why)
    > 
    > - //content embedders that don't want to use site-per-process: //chromecast
    > 
    > - //content embedders that don't yet support site-per-process, but will
    >   need to migrate eventually: //headless
    > 
    > 
    > Also note that even after this CL:
    > 
    > - //content on Android still defaults to no isolation.
    >   This is compatible with not_site_per_process_* test steps
    >   because such steps are not run on Android bots...
    > 
    > - //chrome layer ChromeContentBrowserClient controls usage of
    >   site-per-process in the Chrome browser and continues to be controlled
    >   by a field trial (note that Android is not covered by the field trial
    >   or by testing/variations/fieldtrial_testing_config.json).
    > 
    > 
    > Bug: 856734
    > Change-Id: Iebd46e5502583f84a4b0a7c2ee8d8b0e081c6ff2
    > Reviewed-on: https://chromium-review.googlesource.com/1153981
    > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    > Reviewed-by: Stephen Lanham <slan@chromium.org>
    > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > Reviewed-by: Bo <boliu@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582223}
    
    TBR=thakis@chromium.org,boliu@chromium.org,skyostil@chromium.org,alexmos@chromium.org,slan@chromium.org,lukasza@chromium.org
    
    Change-Id: Ieca3a36422b0f90dccc0040eeece799523c954e0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 856734
    Reviewed-on: https://chromium-review.googlesource.com/1171705
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582424}

    Changed files

    • android_webview/browser/aw_content_browser_client.cc
    • android_webview/browser/aw_content_browser_client.h
    • chromecast/browser/cast_content_browser_client.cc
    • chromecast/browser/cast_content_browser_client.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/isolated_origin_browsertest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • content/shell/browser/layout_test/layout_test_content_browser_client.cc
    • content/shell/browser/layout_test/layout_test_content_browser_client.h
    • headless/lib/browser/headless_content_browser_client.cc
    • headless/lib/browser/headless_content_browser_client.h
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/client.v8.chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/test_suites.pyl
  3. Revert "[Mac] Add Offset to TextSuggestionsTouchBarController Text Selection"

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 02:05:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c0a0f0be53c7c705076cac5dfc933dc85650e435

    Comments

    Revert "[Mac] Add Offset to TextSuggestionsTouchBarController Text Selection"
    
    This reverts commit 1e3c17435eea13b5ba5d2794985655aa221091d1.
    
    Reason for revert: Breaks Mac tests, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477492727648/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/TextSuggestionsTouchBarControllerTest.Offset/0
    
    Original change's description:
    > [Mac] Add Offset to TextSuggestionsTouchBarController Text Selection
    > 
    > When the text surrounding the current selection gets too long, only
    > part of it is received by TextSuggestionsTouchBarController. The
    > location of the received text within the total block of text is
    > denoted by an offset. Previously, TextSuggestionsTouchBarController
    > did not take this offset into account, causing crashes when the
    > selection range was past the end of the received text.
    > 
    > The offset is passed along with the text and selection range. The
    > selection range within the received text is calculated using the
    > offset and received selection range. The editing word range is stored
    > both as the range within the received text and the range within the
    > total text for checking when to ignore text selection updates.
    > 
    > RenderWidgetHostView::GetOffsetForSurroundingText() was added to
    > retrieve the offset on WebContents update.
    > 
    > Browser tests were modified to account for the new offset parameter. A
    > new browser test, TextSuggestionsTouchBarController.Offset, was added
    > to test that the controller properly handles offsets.
    > 
    > Bug: 717553
    > Change-Id: I6dce1405fd5c115ca6ddfdbe4157faf75ccc3a6c
    > Reviewed-on: https://chromium-review.googlesource.com/1169597
    > Commit-Queue: Tessa Nijssen <tnijssen@google.com>
    > Reviewed-by: Avi Drissman <avi@chromium.org>
    > Reviewed-by: Sarah Chan <spqchan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582205}
    
    TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com
    
    Change-Id: If0acdd0494b5270c4b4e221e16b8e901ce2cacc3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 717553
    Reviewed-on: https://chromium-review.googlesource.com/1171704
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582423}

    Changed files

    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller_browsertest.mm
    • content/browser/frame_host/render_widget_host_view_guest.cc
    • content/browser/frame_host/render_widget_host_view_guest.h
    • content/browser/renderer_host/render_widget_host_delegate.h
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_mac.mm
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
    • content/public/browser/render_widget_host_view.h
    • content/public/browser/web_contents_observer.h
  4. Always put Telemetry tests at the end to avoid starving fast tests

    Changed by Ned Nguyen - nednguyenohnoyoudont@google.com
    Changed at Saturday, 11-Aug-18 02:02:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2eb4f79024d096aa0363c946b1eb9a733283ed

    Comments

    Always put Telemetry tests at the end to avoid starving fast tests
    
    This also add this check to PRESUBMIT perf_json_config_validator script
    
    Bug: 873389
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I16fd762e567d5a41d75a221456e12e14a03f0b85
    Reviewed-on: https://chromium-review.googlesource.com/1171578
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#582422}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_json_config_validator.py
  5. Clean up some Ozone build files not to assume use of evdev.

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:51:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d6032964619538763f8ce4a782093f74b86ed49

    Comments

    Clean up some Ozone build files not to assume use of evdev.
    
    Bug: 808287
    Change-Id: Ic699462759818049666babb0587939e4ca687643
    Reviewed-on: https://chromium-review.googlesource.com/1167555
    Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
    Reviewed-by: Michael Spang <spang@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582421}

    Changed files

    • ui/events/BUILD.gn
    • ui/events/ozone/BUILD.gn
    • ui/events/ozone/keyboard/event_auto_repeat_handler.cc
    • ui/events/ozone/keyboard/event_auto_repeat_handler.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  6. Bump tablet tester execution timeout

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:49:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 711748ea30b592183f2d37f54091dda9f4fee9c2

    Comments

    Bump tablet tester execution timeout
    
    They seem to need longer timeout for now. Hopefully will be temporary.
    
    TBR=bpastene
    
    Bug: 853248
    Change-Id: I6665013085631c69e6d78fe1f43f195e12d3295c
    Reviewed-on: https://chromium-review.googlesource.com/1171909
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582420}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
  7. Disable flaky tests.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e064bc93ae45308ecc1b6fa886808ad20bd2225f

    Comments

    Disable flaky tests.
    
    Bug: 622387, 871692
    Change-Id: Ie03b640422b120d903ca56bf9f0650a1ffc23065
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171852
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582419}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
    • chrome/test/data/webui/extensions/cr_extensions_browsertest.js
    • chrome/test/data/webui/settings/cr_settings_browsertest.js
  8. [Offline Pages] Implement live page sharing.

    Changed by Yafei Duan - romaxohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 514ffca0bacb2fce140defae3a4ae3dcab37bfa0

    Comments

    [Offline Pages] Implement live page sharing.
    
    Implement live page sharing:
    - Adding a new temporary client namespace for the usage of live page
      sharing, which has a limit of one page per url and expiration period
      as one hour.
    - Adding saveAndSharePage in OfflinePageUtils, implementing the workflow
      of save page, get page and share page.
    
    Bug: 870895
    Change-Id: Iab5f074dfa955ba30f8b125a70cedb87e8610246
    Reviewed-on: https://chromium-review.googlesource.com/1162827
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Yafei Duan <romax@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582418}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/GetPagesByNamespaceForLivePageSharingCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/SavePageAndShareCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
    • chrome/android/java_sources.gni
    • components/offline_pages/core/client_namespace_constants.cc
    • components/offline_pages/core/client_namespace_constants.h
    • components/offline_pages/core/client_policy_controller.cc
    • components/offline_pages/core/client_policy_controller_unittest.cc
    • components/offline_pages/core/model/offline_page_model_utils.cc
    • tools/metrics/histograms/enums.xml
  9. Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:40:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51acd92215e6b735f2c0f80119f7ca51c031f797

    Comments

    Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)
    
    https://skia.googlesource.com/skia.git/+log/4eac21fee047..f3ca1c6abb07
    
    
    git log 4eac21fee047..f3ca1c6abb07 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 brucewang@google.com Implement FreeType COLR/CPAL support.
    2018-08-10 timliang@google.com fixed the size in bytes of vec3s to match Metal standard in Metal gpu backend
    2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-08-10 timliang@google.com only set color index if using dual source blending in Metal gpu backend
    2018-08-10 kjlubick@google.com [PathKit] Add various path effects
    2018-08-10 mtklein@google.com clean up SK_LEGACY_CONVERT_PIXELS_IMPL
    2018-08-10 caryclark@skia.org fix text blob example errors
    2018-08-10 caryclark@skia.org fix bookmaker check for enum size
    2018-08-10 liyuqian@google.com Reland "Update ShouldUseAAA with our better complexity estimation"
    2018-08-10 timliang@google.com enabled gms and most unit tests for Metal gpu backend
    2018-08-10 mtklein@google.com switch ubsan to blacklist
    2018-08-10 bungeman@google.com Change generateAdvance to never chain.
    2018-08-10 caryclark@skia.org refresh generated includes
    2018-08-10 fmalita@chromium.org [sksg] Simplify ScopedRenderContext
    2018-08-10 caryclark@skia.org new batch of docs
    2018-08-10 timliang@google.com implemented GrMtlGpuCommandBuffer for draws in Metal gpu backend
    2018-08-10 mtklein@google.com add bounds sanitizer to ASAN/UBSAN bots
    2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd662d210afc..c47cd435bf6f (1 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@f3ca1c6abb07
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=djsollen@chromium.org
    
    Change-Id: I5274deea227ad59efbb4157cf2401fcc016ae264
    Reviewed-on: https://chromium-review.googlesource.com/1171445
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582417}

    Changed files

    • DEPS
  10. Mojo: Add ArrayTraits for std::unordered_set

    Changed by Joe Mason - joenotcharlesohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:31:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 576c7e134e5ce40b4ef09482600d9bd51f52d152

    Comments

    Mojo: Add ArrayTraits for std::unordered_set
    
    This is required to typemap chrome_cleaner::PUPData.
    
    R=rockot
    
    Bug: 830892
    Change-Id: I42e29dbd928c1bd9064ba9a75a37493461209b7e
    Reviewed-on: https://chromium-review.googlesource.com/1171736
    Commit-Queue: Joe Mason <joenotcharles@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582416}

    Changed files

    • mojo/public/cpp/bindings/array_traits_stl.h
  11. Change the history state throttle interval from 60 to 120 Hz.

    Changed by Chris Palmer - palmerohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e4127dd506c501cd3f51d91dc22a3dfa8f5f1ca

    Comments

    Change the history state throttle interval from 60 to 120 Hz.
    
    This is a bit more lenient and may enable some callers, including a flaky test,
    to get (more of) what they need. The test's root problem seems to be data races
    (see issue 847326), however.
    
    Bug: 870861
    Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c
    Reviewed-on: https://chromium-review.googlesource.com/1171825
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582415}

    Changed files

    • third_party/blink/renderer/core/frame/history.cc
  12. Normalize rendering_desktop.json, rendering_mobile.json

    Changed by Kai Ninomiya - kaininoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 074cecb79d9d30ec9f2bf6b5b10edb6cd77a8b4f

    Comments

    Normalize rendering_desktop.json, rendering_mobile.json
    
    This is needed because re-recording archives (using record_wpr)
    causes these files to get re-alphabetized automatically.
    This commit lets us re-record an archive without producing an
    unreadable diff.
    
    Doing this also removes the duplicate key
    "androidpolice_mobile_sync_scroll_2018" from rendering_mobile.json.
    
    Tangentially, also delete the unused archive
    rendering_mobile_007.wprgo.sha1.
    
    Bug: 872551, 867368
    Change-Id: Ib15c9c0a8600e7fa510a146ad896aa92e4f9de45
    Reviewed-on: https://chromium-review.googlesource.com/1171677
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Kai Ninomiya <kainino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582414}

    Changed files

    • tools/perf/page_sets/data/rendering_desktop.json
    • tools/perf/page_sets/data/rendering_mobile.json
    • tools/perf/page_sets/data/rendering_mobile_007.wprgo.sha1
  13. Add Main Prompts for Card Migration Flow

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:24:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fec3aebc5358345210d473c0ec36fef86ba5937

    Comments

    Add Main Prompts for Card Migration Flow
    
    This is the 1st CL adding view skeleton.
    
    For project details please refer to go/ib-paradise.
    
    Bug: 852904
    Change-Id: Icc10a2598bb15659a6478fc2dbf2734094111494
    Reviewed-on: https://chromium-review.googlesource.com/1149514
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: Cait Phillips <caitkp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#582413}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_dialog.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_factory.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_state.h
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
    • chrome/browser/ui/views/harmony/chrome_layout_provider.cc
    • chrome/browser/ui/views/harmony/chrome_layout_provider.h
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
    • components/autofill_strings.grdp
    • components/resources/autofill_scaled_resources.grdp
    • components/resources/default_100_percent/autofill/migration_header.png
    • components/resources/default_200_percent/autofill/migration_header.png
    • components/resources/default_300_percent/autofill/migration_header.png
  14. Send SharedImage IPC with multi-flush

    Changed by Antoine Labour - pimanohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14ff32c26823fa7aff03d2d74790d04acdfb59ab

    Comments

    Send SharedImage IPC with multi-flush
    
    This generalizes the FlushParams to contain sync tokens + IPC::Message instead
    of ad-hoc fields transformed into Messages on the receiving side. This allows
    any Message (that doesn't have handles) to be included into the list, and
    simplifies the service-side handling.
    Existing AsyncFlush and DestroyTransferBuffer messages are now serialized
    client-side, and CreateSharedImage/DestroySharedImage are converted to this
    mechanism, to avoid extra IPCs per tile.
    
    Bug: 870116
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ib11298c03e249f49aec8e710a3db4195aea33e81
    Reviewed-on: https://chromium-review.googlesource.com/1168731
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582412}

    Changed files

    • gpu/command_buffer/common/command_buffer.h
    • gpu/ipc/client/command_buffer_proxy_impl.cc
    • gpu/ipc/client/command_buffer_proxy_impl_unittest.cc
    • gpu/ipc/client/gpu_channel_host.cc
    • gpu/ipc/client/gpu_channel_host.h
    • gpu/ipc/client/shared_image_interface_proxy.cc
    • gpu/ipc/common/BUILD.gn
    • gpu/ipc/common/flush_params.cc
    • gpu/ipc/common/flush_params.h
    • gpu/ipc/common/gpu_messages.h
    • gpu/ipc/common/gpu_param_traits_macros.h
    • gpu/ipc/service/gpu_channel.cc
    • gpu/ipc/service/shared_image_stub.cc
    • gpu/ipc/service/shared_image_stub.h
  15. chromeos: add SingleProcessMash mode

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b092ae622b9ab3856d64d3eca543e4ecb243be77

    Comments

    chromeos: add SingleProcessMash mode
    
    This makes Ash create an Env if passed SingleProcessMash. In addition this
    makes all window creation go through a factory that ensures the right env is
    supplied.
    
    See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
    for more details.
    
    This also adds the feature to ui/base.
    
    BUG=847992
    TEST=covered by tests
    
    Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
    Reviewed-on: https://chromium-review.googlesource.com/1168282
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582411}

    Changed files

    • ash/BUILD.gn
    • ash/README.md
    • ash/app_launch_unittest.cc
    • ash/ash_service_unittest.cc
    • ash/components/fast_ink/fast_ink_view.cc
    • ash/display/cursor_window_controller.cc
    • ash/display/display_manager_unittest.cc
    • ash/display/display_util.cc
    • ash/display/mirror_window_controller.cc
    • ash/display/mouse_cursor_event_filter_unittest.cc
    • ash/display/root_window_transformers_unittest.cc
    • ash/display/screen_ash.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/display/unified_mouse_warp_controller_unittest.cc
    • ash/display/window_tree_host_manager_unittest.cc
    • ash/drag_drop/drag_drop_tracker.cc
    • ash/events/event_rewriter_controller.cc
    • ash/extended_desktop_unittest.cc
    • ash/frame/detached_title_area_renderer.cc
    • ash/frame/header_view.cc
    • ash/host/DEPS
    • ash/host/ash_window_tree_host.cc
    • ash/host/ash_window_tree_host_platform.cc
    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/keyboard/test_keyboard_ui.cc
    • ash/magnifier/docked_magnifier_controller.cc
    • ash/magnifier/magnification_controller_unittest.cc
    • ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
    • ash/public/cpp/frame_border_hit_test.cc
    • ash/root_window_controller.cc
    • ash/root_window_controller_unittest.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_window_watcher_unittest.cc
    • ash/shell.cc
    • ash/shell.h
    • ash/shell_unittest.cc
    • ash/system/message_center/arc/arc_notification_content_view_unittest.cc
    • ash/system/message_center/arc/arc_notification_view_unittest.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.h
    • ash/system/night_light/night_light_controller.cc
    • ash/system/overview/overview_button_tray_unittest.cc
    • ash/system/tray/tray_background_view.cc
    • ash/test/ash_test_base.cc
    • ash/test/ash_test_helper.cc
    • ash/test/ash_test_suite.cc
    • ash/test/ui_controls_factory_ash.cc
    • ash/utility/screenshot_controller_unittest.cc
    • ash/wayland/wayland_server_controller.cc
    • ash/wayland/wayland_server_controller.h
    • ash/window_factory.cc
    • ash/window_factory.h
    • ash/window_user_data_unittest.cc
    • ash/wm/ash_focus_rules_unittest.cc
    • ash/wm/cursor_manager_chromeos.cc
    • ash/wm/drag_window_controller.cc
    • ash/wm/drag_window_resizer_unittest.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • ash/wm/native_cursor_manager_ash_classic.cc
    • ash/wm/non_client_frame_controller.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/stacking_controller_unittest.cc
    • ash/wm/system_gesture_event_filter_unittest.cc
    • ash/wm/system_modal_container_layout_manager_unittest.cc
    • ash/wm/top_level_window_factory.cc
    • ash/wm/toplevel_window_event_handler.cc
    • ash/wm/toplevel_window_event_handler_unittest.cc
    • ash/wm/video_detector.cc
    • ash/wm/window_dimmer.cc
    • ash/wm/window_dimmer_unittest.cc
    • ash/wm/workspace/workspace_event_handler_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • ash/wm/workspace/workspace_window_resizer_unittest.cc
    • ash/wm/workspace_controller_unittest.cc
    • ash/ws/window_service_owner.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/ui/ash/ksv/DEPS
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
    • components/exo/test/exo_test_base.cc
    • components/exo/wayland/clients/test/wayland_client_test.cc
    • ui/aura/env.cc
    • ui/aura/env.h
    • ui/aura/test/test_windows.cc
    • ui/aura/test/test_windows.h
    • ui/aura/window.cc
    • ui/aura/window.h
    • ui/aura/window_tree_host_platform.cc
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  16. refine window finder for mash

    Changed by Jun Mukai - mukaiohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c0f9aa861fdb9bc534829d3f764e2100cfff71c

    Comments

    refine window finder for mash
    
    Previously window_finder_chromeos (for mash) looks through the
    list of the toplevel browser windows, but it is too simple and
    doesn't work well on several cases.
    
    This CL moves the window finding code to ash, and let WindowTree
    notify the list of windows at the cursor to the client upon
    window moving.
    
    BUG=867074
    TEST=ash_unittests
    
    Change-Id: Ib44ad1a927a31c50cc108eee92ddba4d9bd918ee
    Reviewed-on: https://chromium-review.googlesource.com/1159346
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582410}

    Changed files

    • ash/BUILD.gn
    • ash/wm/window_finder.cc
    • ash/wm/window_finder.h
    • ash/wm/window_finder_unittest.cc
    • ash/ws/window_service_delegate_impl.cc
    • ash/ws/window_service_delegate_impl.h
    • ash/ws/window_service_delegate_impl_unittest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/tabs/DEPS
    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/window_finder.cc
    • chrome/browser/ui/views/tabs/window_finder.h
    • chrome/browser/ui/views/tabs/window_finder_chromeos.cc
    • content/renderer/mus/renderer_window_tree_client.cc
    • content/renderer/mus/renderer_window_tree_client.h
    • services/ui/public/interfaces/window_tree.mojom
    • services/ui/ws2/BUILD.gn
    • services/ui/ws2/test_change_tracker.cc
    • services/ui/ws2/test_change_tracker.h
    • services/ui/ws2/test_window_tree_client.cc
    • services/ui/ws2/test_window_tree_client.h
    • services/ui/ws2/topmost_window_observer.cc
    • services/ui/ws2/topmost_window_observer.h
    • services/ui/ws2/window_service_delegate.cc
    • services/ui/ws2/window_service_delegate.h
    • services/ui/ws2/window_tree.cc
    • services/ui/ws2/window_tree.h
    • ui/aura/BUILD.gn
    • ui/aura/mus/topmost_window_tracker.cc
    • ui/aura/mus/topmost_window_tracker.h
    • ui/aura/mus/window_tree_client.cc
    • ui/aura/mus/window_tree_client.h
    • ui/aura/test/mus/test_window_tree.cc
    • ui/aura/test/mus/test_window_tree.h
  17. Orderfile: renable misordered symbol threshold in check_orderfile.py.

    Changed by Matthew Cary - mattcaryohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bdba7075443440ec9b67631bc351866397558f0e

    Comments

    Orderfile: renable misordered symbol threshold in check_orderfile.py.
    
    Bug: 873380
    Change-Id: Iaa194b57f57985a6bc851a2b826555a6d087a57c
    Reviewed-on: https://chromium-review.googlesource.com/1171234
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582409}

    Changed files

    • tools/cygprofile/check_orderfile.py
    • tools/cygprofile/check_orderfile_unittest.py
  18. Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:08:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3bb07ab082388ed8e0590614162bc1cc9f756bdb

    Comments

    Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/284b5e0c60ac..6a4e31b4882f
    
    
    git log 284b5e0c60ac..6a4e31b4882f --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 ehmaldonado@chromium.org gclient_scm: Add option to specify the branch the patch is based on.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@6a4e31b4882f
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:870279
    TBR=agable@chromium.org
    
    Change-Id: I4563fb1540b017267659c6d67ca8dcbf6f3feb8f
    Reviewed-on: https://chromium-review.googlesource.com/1171443
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582408}

    Changed files

    • DEPS
  19. cros: Fix empty preview wallpaper description issue

    Changed by Wenzhao Zang - wzangohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:02:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a59fa8e81cbc0a8d5b5cbb61172d86a4ff4e10a

    Comments

    cros: Fix empty preview wallpaper description issue
    
    Bug: 873340
    Change-Id: Ia5979ba5305b154a27689157db573f8bc6803801
    Reviewed-on: https://chromium-review.googlesource.com/1171790
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582407}

    Changed files

    • chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
  20. Revert "Add debug chromium bots"

    Changed by Stephen Martinis - martinissohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:59:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f3cf71cc8609b20283f2e3eeb3a378a3c51d544

    Comments

    Revert "Add debug chromium bots"
    
    This reverts commit 2db4180229db1c343018f96400d97944534b7a77.
    
    Reason for revert: Bots are purple, will reland and make sure they're green later.
    
    Original change's description:
    > Add debug chromium bots
    > 
    > These are mirrors of the existing release bots
    > 
    > Bug: 867725
    > Change-Id: I6f59d04a82103572e801273e294534e822d3e03d
    > Reviewed-on: https://chromium-review.googlesource.com/1159172
    > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    > Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582390}
    
    TBR=iannucci@chromium.org,vadimsh@chromium.org,dpranke@chromium.org,kbr@chromium.org,nodir@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
    
    Change-Id: I28a27093f09db79c83239070325254df6a1a0dca
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 867725
    Reviewed-on: https://chromium-review.googlesource.com/1171430
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582406}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  21. Clean up PdfCompositorImpl.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:55:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b2f31335a925a33e3fec9a7d7e765698f4cc3de3

    Comments

    Clean up PdfCompositorImpl.
    
    - Make some methods const.
    - Update some comments.
    - Remove an unimplemented method declaration.
    - Remove an unused method parameter.
    
    Change-Id: I678d740f4915b4d55d5be5fdc6482b7bac18778b
    Reviewed-on: https://chromium-review.googlesource.com/1170401
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Wei Li <weili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582405}

    Changed files

    • components/services/pdf_compositor/pdf_compositor_impl.cc
    • components/services/pdf_compositor/pdf_compositor_impl.h
  22. [ChromeDriver] Fix version string in release branch

    Changed by John Chen - johnchenohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:52:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe92472c755ab9519221b35a96c1458a61293cf

    Comments

    [ChromeDriver] Fix version string in release branch
    
    The previous change (r581945) to update version string used by
    ChromeDriver in release branches didn't work, because the top-most
    commit doesn't have the necessary branch info. This CL adds the same
    commit filter used to generate the version string shown by Chrome.
    
    Bug: chromedriver:2080
    Change-Id: I4d7b57a139968d3e5e0f1ebad26d6ed648ab5d72
    Reviewed-on: https://chromium-review.googlesource.com/1171843
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582404}

    Changed files

    • chrome/test/chromedriver/embed_version_in_cpp.py
  23. Add vector of intervals range checking to Time Restrictions policy

    Changed by Adolfo Victoria - adokarohnoyoudont@google.com
    Changed at Saturday, 11-Aug-18 00:42:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3392d988ae23dc52d9b386af47dc6a53a2d22c8

    Comments

    Add vector of intervals range checking to Time Restrictions policy
    
    * Add function GetEndOfCurrent interval to obtain the last end of the
    interval which contains the current time.
    * Add function MaterializeIntervalsToLocalTimezone, which materializes
    the given intervals to the current local timezone.
    * Add function TimeIsInsideCrosSettingsIntervals, which checks if the
    current time is inside the intervals set in cros settings. It then
    returns the localized string of the end of the interval that contains
    the current time.
    
    BUG=chromium:852860
    TEST=added unittests
    
    Change-Id: Ife32e31c8a929827fd14ab9f108c49eacb9c32c3
    Reviewed-on: https://chromium-review.googlesource.com/1132676
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582403}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.cc
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils.h
    • chrome/browser/chromeos/policy/device_auto_update_time_restrictions_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.cc
    • chrome/browser/chromeos/policy/weekly_time/time_utils.h
    • chrome/browser/chromeos/policy/weekly_time/time_utils_unittest.cc
    • chrome/browser/chromeos/policy/weekly_time/weekly_time.h
    • chrome/browser/chromeos/policy/weekly_time/weekly_time_interval.h
  24. Roll src/third_party/angle 077cd858b2d4..ea926a362b77 (3 commits)

    Changed by angle-chromium-autoroll - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 00:41:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e4c26fa3e9b08e7dda082537ecfdc254c8d8db35

    Comments

    Roll src/third_party/angle 077cd858b2d4..ea926a362b77 (3 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/077cd858b2d4..ea926a362b77
    
    
    git log 077cd858b2d4..ea926a362b77 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 jmadill@chromium.org Add angle_perftests README file.
    2018-08-10 jmadill@chromium.org D3D: Use angle::Result error pattern.
    2018-08-10 jmadill@chromium.org Fix AMD detection in angle_end2end_tests.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@ea926a362b77
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I66ef52bae109017756c16854706a5a4b95d73c23
    Reviewed-on: https://chromium-review.googlesource.com/1171403
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582402}

    Changed files

    • DEPS
  25. Roll HarfBuzz to 1.8.7

    Changed by Emil A Eklund - eaeohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:35:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03427d53dc8e88fbde543f6115708a98c2b9b1f0

    Comments

    Roll HarfBuzz to 1.8.7
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/2b76767bf572364d3d647cdd139f2044a7ad06b2..b6fdcf4f8bd09e065c767939125861c9dc8ff18f
    
    Tbr: drott@chromium.org
    Change-Id: Ie65cb46846224bd90ffa86517a946c44f321f2c7
    Reviewed-on: https://chromium-review.googlesource.com/1170170
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582401}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/README.chromium
  26. [ChromeDriver] Fix testWindowMinimize and remove old code

    Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:34:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0bd3fb604e6b8598a546503e09f4979d4590ccb8

    Comments

    [ChromeDriver] Fix testWindowMinimize and remove old code
    
    Fix a test failure in Python test case testWindowMinimize, and
    clean up code related to not supported version.
    
    Change-Id: I076cdc90cdaca322bc64530c6bb9eabe6ae9069a
    Reviewed-on: https://chromium-review.googlesource.com/1171805
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582400}

    Changed files

    • chrome/test/chromedriver/test/run_py_tests.py
  27. Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 00:34:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24be12346d5a4ec8ebcc2c0615add14d150496e7

    Comments

    Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5a4110982f31..21cd5a309631
    
    
    git log 5a4110982f31..21cd5a309631 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 dtu@chromium.org [pinpoint] Ignore comparison_magnitude == 'None' for reruns.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@21cd5a309631
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:873331
    TBR=sullivan@chromium.org
    
    Change-Id: Ie322f1501b9f5411006fd4d603edf90941097a93
    Reviewed-on: https://chromium-review.googlesource.com/1171404
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582399}

    Changed files

    • DEPS
  28. Speculative fix for GSA crashes with MediaCodec callback API.

    Changed by Dale Curtis - dalecurtisohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:32:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7feecd556d5bb5fe3bd419703709c5ce38942123

    Comments

    Speculative fix for GSA crashes with MediaCodec callback API.
    
    Prevents any calls into the native bridge once release() has been
    called on MediaCodecBridge. I've also reordered some member
    variables of the bridge to match their lifetime.
    
    BUG=873094
    TEST=none
    
    Change-Id: Iccf648275bac2d466ce62c5e4e792f9a088b09a0
    Reviewed-on: https://chromium-review.googlesource.com/1171836
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582398}

    Changed files

    • media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
    • media/base/android/media_codec_bridge_impl.cc
    • media/base/android/media_codec_bridge_impl.h
  29. Reduce telemetry based isolate size

    Changed by Zhenyao Mo - zmoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:19:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1715e3f972fe31826c3aaa4eaef20d0aeb7794c6

    Comments

    Reduce telemetry based isolate size
    
    Excluding some large size data in third_party/catapult/ that are not needed
    in running the telemetry tests.
    
    R=kbr@chromium.org,nednguyen@chromium.org
    
    Change-Id: I10a1968b5a9b02415f5d7f66b33a247d64791578
    Bug: 872521
    Reviewed-on: https://chromium-review.googlesource.com/1166261
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582397}

    Changed files

    • chrome/test/BUILD.gn
    • tools/perf/chrome_telemetry_build/BUILD.gn