Home | Search | chromium - Builders
Login

Builder Win7 (32) Tests Build 39366 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisionae1d881f2c19438f9bf1efad82eaaaa11980b30f
Got Revisionae1d881f2c19438f9bf1efad82eaaaa11980b30f

Execution:

Steps and Logfiles:

Show:
  1. ( 752 ms ) setup_build
    running recipe: "chromium"
  2. ( 243 ms ) report builders
     
    running tester 'Win7 (32) Tests' on master 'chromium.win'
  3. ( 3 secs ) taskkill
  4. ( 41 secs ) bot_update
    [41GB/349GB used (11%)]
  5. ( 659 ms ) swarming.py --version
    0.13
  6. ( 14 secs ) gclient runhooks
  7. ( 609 ms ) read test spec (chromium.win.json)
    path: e:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 460 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "e:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 362 ms ) build directory
  10. ( 382 ms ) find isolated tests
  11. ( 3 secs ) base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 32s
  12. ( 2 secs ) sbox_integration_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  13. ( 2 secs ) sbox_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  14. ( 2 secs ) sbox_validation_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  15. ( 17 mins 42 secs ) browser_tests
    Run on OS: 'Windows-7-SP1'
    Max pending time: 0:10:08.596169 (shard #9)
    Max shard duration: 0:09:16.310496 (shard #2)
    Min shard duration: 0:05:01.613738 (shard #5)
  16. ( 196 ms ) Tests statistics
     
    Stats
    Total shards: 14
    Total runtime: 1:07:18.167000
     
  17. ( 590 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "e:\\b\\s\\w\\ir\\cache", "temp_dir": "e:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm29-m1" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539336149633535, "id": "8932882773520759920", "project": "chromium", "tags": ["builder:Win7 (32) Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/ae1d881f2c19438f9bf1efad82eaaaa11980b30f", "gitiles_ref:refs/heads/master", "parent_buildername:Win Builder", "parent_buildnumber:61413", "scheduler_invocation_id:9098312835737533424", "scheduler_job_id:chromium/Win7 (32) Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 (32) Tests" setup_build
buildnumber 39366 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "ae1d881f2c19438f9bf1efad82eaaaa11980b30f" setup_build
parent_got_revision_cp "refs/heads/master@{#599147}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25136}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "ae1d881f2c19438f9bf1efad82eaaaa11980b30f" setup_build
swarm_hashes {"accessibility_unittests": "9f6afeaa97d0001bcb4026301ad621690551bddf", "angle_unittests": "d5e5fb9640b3e20f3de2049c1ecdad817f7093ca", "app_shell_unittests": "a11b736451ac08c9494aa681138d65948c88f826", "aura_unittests": "fcd48a3a7da387a9172728e82271cb37abc6d84f", "base_unittests": "f52cc4e8d5f0c84f9acc7f82d2c3d870f9eb16ae", "blink_common_unittests": "514ff29f368832d72cd4c4ba13245c5a39beb066", "blink_fuzzer_unittests": "8359314a6892c1a4edf0288ad885757ec8d72cd3", "blink_heap_unittests": "27e0ac928cc285040b4cf941888f411ada5e3544", "blink_platform_unittests": "0f6010f40fa796a83874f04ee8e6fff1ca005c22", "boringssl_crypto_tests": "6f61fbc6e64e81fa37ec3670ecdf6c128774acc8", "boringssl_ssl_tests": "ebc32e2a0982a63a80b7a20b73c8a5e75417d0f9", "browser_tests": "497fc8880af9ae4a8345359e6015e14cc4d50009", "cacheinvalidation_unittests": "84efdbaf8b562950bea012de9d4ecc91e482bfa7", "capture_unittests": "0fda096d17eb44b41d4043a676b74ebbb8408a9d", "cast_unittests": "313cc08d721a8d4e4673d354d644f3501531ab5f", "cc_unittests": "f2ef9005c3484a090aac234856b7ea28ecf132a0", "chrome_app_unittests": "77bc0021ef94e37ded8e4989ea5786c29668a20e", "chrome_cleaner_unittests": "065f2f41ea93c37b8a7948ef786aa93ca72927b5", "chrome_elf_import_unittests": "540b91513c59bec804aeb5085b69466208026924", "chrome_elf_unittests": "91798571bf74002c4676c59dcb60c7ffe57e1316", "chromedriver_py_tests": "a3c3388e9094b16b4ac918daad094b9cca2ef316", "chromedriver_replay_unittests": "5013a0f078eac50a549885e896698d163bf73605", "chromedriver_unittests": "132e80249a3dce567cfb9328517f6e8a0c4f32a1", "components_browsertests": "64168c44ada00c3754b06be7d509708a2b8491ab", "components_perftests": "d5f4555cda2af87ec5eaff2f8c54a5a890764801", "components_unittests": "2c6883a4628120f946e259a0dd3f5ec279856d95", "compositor_unittests": "4ad39bcc7191b02aacb2ec090437f87bec5ddc29", "content_browsertests": "95a7e0705747cb26b94f8b7418434ecd635a0fa3", "content_shell_crash_test": "4c2fce92a742f370e1a1a53f01c625013a534269", "content_unittests": "b9b68dbc89aebbc12ebb199199cf577c584fa723", "courgette_unittests": "1108c1fb9469468e951727303e6d49d2073e0988", "crashpad_tests": "6fd81108a2b6cf41f417115cf722b1e932bcd166", "cronet_tests": "d84147df8e3a6eace8b363e91bf295f78b36ff2a", "cronet_unittests": "4fbff37be40b976ac669e13a41839e316b60efdc", "crypto_unittests": "ea488e34d8a8ed1d629fd8063503c36404858358", "device_unittests": "8085f2e47f6a8e3670d53371b5aac99454fc684d", "display_unittests": "7a05d306cf4f55c9768b840e6a18649578a55b65", "elevation_service_unittests": "36660c0f6cc020b5afe8714ea8a01d7c52ade612", "events_unittests": "bc22138e77dec385ecae6d14e88f156aeceac045", "extensions_browsertests": "f1066e6556eafd24c91586daca840b7e62b03a77", "extensions_unittests": "41666a1cfd48229df4e09a292aa234e698e68c49", "filesystem_service_unittests": "7e48dea46ebe0688ab86f5dd6f06c7dab95f9f20", "gcm_unit_tests": "1138a7b407e67b3e8aae1205bcad58c93484c6d2", "gfx_unittests": "28ab2b0a4d5c0581f4d51c3fc858f891055964e6", "gin_unittests": "106fcc55c736d23a727f428726df465b54e86d95", "google_apis_unittests": "e8e92fd6dfbb992c387892ae94dcdef9464eac17", "gpu_unittests": "d4630cee0380740bdb2a8aeb737f92376e55ff7a", "headless_browsertests": "c76b30ce61010203a26be125b5702dba0c0bd295", "headless_unittests": "c84277185bad252d26f9eba782930909eae62ce1", "install_static_unittests": "4bb0479f93cd2a40b69655bad12d6f4b5d71eedc", "installer_util_unittests": "02cc243517e24eebe5846070dbc833366fa78d8a", "interactive_ui_tests": "905779d6a4fc66ab9be9984145b7a06271f1e373", "ipc_tests": "4a28f129196cc700f1ea926e9faabb80e71340a2", "jingle_unittests": "35f3d9595bc49493dcc7219d6559b27971f2e56c", "latency_unittests": "be065a87e110a7871d03ce52424ce7f11d29c678", "leveldb_service_unittests": "e3a8ef9c71dda4f760bfb909e291008c827bdd16", "libjingle_xmpp_unittests": "595157ac319e440288b4b7faf9c5a540dfc0fc4c", "media_blink_unittests": "2ef25ef876cd1f9afa1b312fff23cbab9440960e", "media_service_unittests": "5c338ab80d1c1aa8dab8adf037d732fcdfa932cc", "media_unittests": "ef34ea1a879e33282bb85fccf424775110c14d68", "message_center_unittests": "40ff85fc04dd5f42dc18de96fff4415c40812d3c", "metrics_python_tests": "b4e4090d7c42df6b958c4a40710412bed7ee9ad6", "midi_unittests": "b9488e089df640d6e7ced4860384e05331d45adb", "mojo_core_unittests": "471d9055c87fd3c4da54dc32690891e4ea0fc90a", "mojo_unittests": "fcd97c1679e620e4130bdb2faf96f11fae3d257c", "nacl_loader_unittests": "5f8f17dd00b1de89f093a3116d07b74e4679034d", "native_theme_unittests": "735fc6cea8b5e70aa902223e4eda339353315779", "net_unittests": "754b2e915792795b50e5697de060090f2485d899", "pdf_unittests": "9eb2b9e5ae55feb3a1ae9322cefd6e7c034738e3", "ppapi_unittests": "faaf347b43181025ac7cb3923a70c723a31add12", "printing_unittests": "82a40c448ecaa80299c53e7168aeaced0116b73a", "remoting_unittests": "a440c5517e6524e4b767bac5ee52edf99b0e9667", "sbox_integration_tests": "854ef3111e5dcb322db877b51966102aa73a3f62", "sbox_unittests": "c44dd9417ff8697d3483f0f4c605a7f6468fdddf", "sbox_validation_tests": "e23579627ef4adbc8c1b3458e1a5f56235d4008c", "service_manager_unittests": "db1ff55b1695210f3b51031f5a0e24666a5a4842", "services_unittests": "a26f1207cdf19d142f4fb9d307f905810e344793", "setup_unittests": "e176120608538d713df440a5deee644b967c98cd", "shell_dialogs_unittests": "53dc897a1624012fc68f65a568b2a756985ebcb3", "skia_unittests": "8ab57746b7b1770f609d308448bbfe1e599bdf2e", "snapshot_unittests": "2758831b88ba7d80ec3a2e9dad75624cdc6208af", "sql_unittests": "8f7b392996bea8a1941d643cf3545b20383784b0", "storage_unittests": "eae711d91e5a75c207cd5284f4baaf2816382898", "sync_integration_tests": "6ef9e8d39e1f9581009f72a8a01121625caa4dc2", "telemetry_gpu_unittests": "8b70e5a50bfeb6fcf2fb857b32da33f75927404d", "telemetry_perf_unittests": "390899e73c15754707b910dd421e7399f6c560bf", "telemetry_unittests": "5ef8bb4dd42dc2ab263e81e86811ae81ba08e28a", "traffic_annotation_auditor_unittests": "d5134618926dc66ac0ecc72f3d33f0b8760195e0", "ui_base_unittests": "e7f818ff125e25ec0208e2cffef4ef660b6092da", "ui_touch_selection_unittests": "8675569317b97c00ad5c798e6ef27e82fe184ca9", "unit_tests": "c4822420bb6dc015004c7685af1c3fde0908602f", "url_unittests": "126c803664f384345781b92f4173fa469f3c0d52", "views_perftests": "111c62be73c04aecd63ffe8872b05ef8380c824a", "views_unittests": "8f721de0948a75920c35fcee04a5a68ad73bc58d", "viz_unittests": "6137d3f122e164da17cdb8179f7bbffcab5da436", "vr_common_unittests": "0b2c324fbde2038677e888e1942a5f72428c8fd1", "vr_pixeltests": "f259dc184b35f1747eb7f483479d8c615933fea7", "webkit_layout_tests_exparchive": "4a2510f2129e9ce2af7d7e4da2af838a1bace1bb", "webkit_python_tests": "8e975c2b6f5326b360a63430c935882bd414ef26", "webkit_unit_tests": "ebbb99ed9b065817b0f382bbb8138ddf8ab0acf5", "wm_unittests": "755858cacfa2df22538f4957a4436d9682113156", "wtf_unittests": "27dd5d199881e3130334e35a4703b9f81b55815d", "zucchini_unittests": "fab1c4386b157f239c41f21b98d9e38df28ee715"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "ae1d881f2c19438f9bf1efad82eaaaa11980b30f" bot_update
got_revision_cp "refs/heads/master@{#599147}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  3. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  4. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  5. Florent Castelli (orphisohnoyoudont@chromium.org)
  6. Fergal Daly (fergalohnoyoudont@chromium.org)
  7. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  8. A Olsen (olsenohnoyoudont@chromium.org)
  9. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 09:22:29 UTC
Start Friday, 12-Oct-18 09:22:35 UTC
End Friday, 12-Oct-18 09:45:49 UTC
Pending 5 secs
Execution 23 mins 14 secs

All Changes:

  1. Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 08:52:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae1d881f2c19438f9bf1efad82eaaaa11980b30f

    Comments

    Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/a54daf162fac..28d200c24624
    
    
    git log a54daf162fac..28d200c24624 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37b6d53f02..d47784f23e (598967:599082)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@28d200c24624
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I6547afd3d833e047bb877b0bece2206b5c8661ec
    Reviewed-on: https://chromium-review.googlesource.com/c/1278304
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599147}

    Changed files

    • DEPS
  2. Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:49:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 30958ae060dbfee80d985b84caa9e3c5f4d9c4cc

    Comments

    Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.
    
    TBR=sky@chromium.org
    
    Bug: 828999
    Change-Id: I46514f21581ab6d30e1c4b38719b66e43b075f42
    Reviewed-on: https://chromium-review.googlesource.com/c/1278129
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599146}

    Changed files

    • chrome/browser/browser_process_platform_part_chromeos.cc
    • chrome/browser/browser_process_platform_part_chromeos.h
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
  3. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  4. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  5. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  6. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h
  7. Chrome OS Powerwash screen: update icon and illustration.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afc97ac06f5d3677c1016d1530c1e196844e2432

    Comments

    Chrome OS Powerwash screen: update icon and illustration.
    
    
    Bug: 894280
    Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1278211
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599141}

    Changed files

    • chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
    • chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
    • chrome/browser/resources/chromeos/login/oobe_reset.css
    • chrome/browser/resources/chromeos/login/oobe_reset.html
  8. Move InstallAttributes to chromeos/settings

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6c62dce936e966e2db445045dd04414553642b

    Comments

    Move InstallAttributes to chromeos/settings
    
    Necessary for moving CrosSettings to chromeos/settings, so it
    can eventually be used by Mustash.
    
    The following changes were necessary:
    1. Move install_attributes{.h, .cc} and unit_test.cc
    2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    (destination)
    3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    which is included by install_attributes.h
    
    4. Unfortunately, that same dependency lead to a circular dependency.
    I was able to avoid that by separating out a "common_constants" rule in
    components/policy/core/common, so that chromeos/settings only depends on
    that, and not on all of components/policy. So I had to change
    components/policy/core/common/BUILD.gn
    and I removed an unnecessary include from
    components/policy/core/common/cloud/cloud_policy_constants.cc
    
    5. Update #include directives for install_attributes to point to new
    location. This is the other 22 files, all with diffs of +1 -1.
    
    Bug: 446937
    Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599140}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • chromeos/settings/install_attributes.cc
    • chromeos/settings/install_attributes.h
    • chromeos/settings/install_attributes_unittest.cc
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  9. Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0

    Comments

    Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
    
    Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hongchan@chromium.org, rtoy@chromium.org:
      external/wpt/webaudio
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02
    Reviewed-on: https://chromium-review.googlesource.com/c/1278059
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599139}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html