Home | Search | chromium - Builders
Login

Builder Win7 (32) Tests Build 35547 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisionb20bb048913985eae71b480db2a2017173ef73a2
Got Revisionb20bb048913985eae71b480db2a2017173ef73a2

Execution:

Steps and Logfiles:

Show:
  1. ( 456 ms ) setup_build
    running recipe: "chromium"
  2. ( 2 secs ) taskkill
  3. ( 315 ms ) remove .cipd
  4. ( 1 mins 26 secs ) bot_update
    [55GB/349GB used (15%)]
  5. ( 0 ) ensure_goma
  6. ( 646 ms ) swarming.py --version
    0.13
  7. ( 1 mins 15 secs ) gclient runhooks
  8. ( 452 ms ) read test spec (chromium.win.json)
    path: e:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  9. ( 7 secs ) build directory
  10. ( 3 mins 24 secs ) extract build
  11. ( 1 secs ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 2 secs ) test_pre_run.[trigger] base_unittests
    Run on OS: 'Windows-7-SP1'
  14. ( 1 secs ) test_pre_run.[trigger] battor_agent_unittests
    Run on OS: 'Windows-7-SP1'
  15. ( 8 secs ) test_pre_run.[trigger] browser_tests
    Run on OS: 'Windows-7-SP1'
  16. ( 1 secs ) test_pre_run.[trigger] sbox_integration_tests
    Run on OS: 'Windows-7-SP1'
  17. ( 1 secs ) test_pre_run.[trigger] sbox_unittests
    Run on OS: 'Windows-7-SP1'
  18. ( 1 secs ) test_pre_run.[trigger] sbox_validation_tests
    Run on OS: 'Windows-7-SP1'
  19. ( 21 secs ) base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 32s
  20. ( 2 secs ) battor_agent_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  21. ( 16 mins 27 secs ) browser_tests
    Run on OS: 'Windows-7-SP1'
    Max pending time: 0:09:06.979150 (shard #9)
    Max shard duration: 0:08:45.696030 (shard #0)
    Min shard duration: 0:05:20.509260 (shard #5)
  22. ( 2 secs ) sbox_integration_tests
    Run on OS: 'Windows-7-SP1'
    Pending time: 0:11:19.049030
    Shard duration: 24s
  23. ( 2 secs ) sbox_unittests
    Run on OS: 'Windows-7-SP1'
    Pending time: 0:11:45.617630
    Shard duration: 20s
  24. ( 1 secs ) sbox_validation_tests
    Run on OS: 'Windows-7-SP1'
    Pending time: 0:12:07.372820
    Shard duration: 18s
  25. ( 269 ms ) Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 1:06:20.392000
     
  26. ( 553 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "e:\\b\\s\\w\\ir\\cache", "temp_dir": "e:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm29-m1" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531429287845650, "id": "8941173719026862288", "project": "chromium", "tags": ["builder:Win7 (32) Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b20bb048913985eae71b480db2a2017173ef73a2", "gitiles_ref:refs/heads/master", "parent_buildername:Win Builder", "parent_buildnumber:57152", "scheduler_invocation_id:9106603781373341216", "scheduler_job_id:chromium/Win7 (32) Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 (32) Tests" setup_build
buildnumber 35547 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win Builder" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "b20bb048913985eae71b480db2a2017173ef73a2" setup_build
parent_got_revision_cp "refs/heads/master@{#574699}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23955}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "b20bb048913985eae71b480db2a2017173ef73a2" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "b20bb048913985eae71b480db2a2017173ef73a2" bot_update
got_revision_cp "refs/heads/master@{#574699}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23955}" bot_update
swarm_hashes {"accessibility_unittests": "97dac6193fdb6b81a878050093f234e5ee2753e3", "angle_unittests": "4d27dbca4190ee0aa5496454946ffe6f9ba84928", "app_shell_unittests": "ad83fe2ce73398226a4b0627459602766fca67a4", "aura_unittests": "75b9d8f6b63c359d321a615354eb3dcf687ed7c4", "base_unittests": "205339e144eb8282f04bc0e79049686472c6ae35", "battor_agent_unittests": "cf23af5cf23636d489e7457a9afaf38586dd434b", "blink_common_unittests": "a68bb595f7a20af90609742b4d15e65e398978e0", "blink_fuzzer_unittests": "af39b3b58102c140d120300d09d6b57251152454", "blink_heap_unittests": "010d87246061d534801e5cd95df85e355dd0c872", "blink_platform_unittests": "82b52dfbfa161659069447999ac106ebd4ddca23", "boringssl_crypto_tests": "a0e3d46942aec064f7b648b818267b2a2cdf57ec", "boringssl_ssl_tests": "0cc40b4ac00732e0ffdaa6cc9655be182bc32e36", "browser_tests": "6bed43ef7a5cdca8baa3e81ba25c3bcb93e90b3a", "cacheinvalidation_unittests": "025a59df167d0242446d18637cbe55e17cd43852", "capture_unittests": "d7f9276d8b5fd003a95d90911e19c8516a9dc3da", "cast_unittests": "07880a4c9699cc7dd9edb84a0edc26986d0b0a1a", "cc_unittests": "445892513893740706f9a294905fd68ca8b2d2f7", "chrome_app_unittests": "1e8285227322f29792118e5e35e3d791b62face9", "chrome_cleaner_unittests": "1eb1a1cfbba3f18e61c186484caa67772c6a5825", "chrome_elf_import_unittests": "a1288a66536aa6ada9e7ff3fec9862569eb72e9c", "chrome_elf_unittests": "a2514cd959eccba1b531336e2f93ee574fa44c18", "chromedriver_py_tests": "d3409c71a210f7c8c19895e569b8a4b54c4899e1", "chromedriver_unittests": "f13d46a0678430090b3daa0381e4ff98f6c1624e", "components_browsertests": "224c181052f6ae3257d50117a13e4ed73b394fe4", "components_perftests": "cfe8cf92757e45ceb0634b59c57479b06d32484b", "components_unittests": "7bfcbd37afa0e1bfda3dcc4323b505757acedb43", "compositor_unittests": "734598c2246100ab521fae997d653fee43f9279c", "content_browsertests": "a32729dad547a402bce2ff98ffd639ce3f591d2b", "content_shell_crash_test": "ecf4d53a8b9139b50096e21890f498357e4103c3", "content_unittests": "1045c53ec7f26c704829e776a1213a6c04cc7733", "courgette_unittests": "77c7ace7b0f2a5e472ff5356d930045283e804a1", "crashpad_tests": "f95c29ba88899e792f308369e0224fcd057152b1", "cronet_tests": "840aec0244c077bc352a8e8d4538df7eab2726bc", "cronet_unittests": "0155a597c6268ba0bf86f14d552ffd951f6e4c6d", "crypto_unittests": "8b943cf1f74348c1579bda8ad5f4eda2bf7ebe38", "device_unittests": "b1e0ff9bbd2eb376528827c30de0243a823019cd", "display_unittests": "f8ee59726e778eea314e16d3ae50c71eaae334a4", "elevation_service_unittests": "9a2998c8671b8627e00a98e7b0d0b0ea97544f26", "events_unittests": "b18864185187543bbd0432c7951b423d8343413e", "extensions_browsertests": "db7cb74dd4817c0b90bb8add8cdae29454d6d4af", "extensions_unittests": "7ddb7086cf23fa10fb41d61987bb48cd00c106ad", "filesystem_service_unittests": "b7169f50677675e1caf94a4423dbe3ad99d0301e", "gcm_unit_tests": "5a704a6b598152d4ca425633233cbe79fdafad0e", "gfx_unittests": "c144f33452f61882d3ecd753df96e28f60032992", "gin_unittests": "c08162a4eb25ffb559087388405a3c57af70a9a9", "google_apis_unittests": "3ca0fbe0cad5049106993acfea81ee1136a3b6a5", "gpu_unittests": "622b230f1281e5b5894d1adea3c013fd340a6eaa", "headless_browsertests": "be244028ea7a3455038b07abc9b81228afc16169", "headless_unittests": "de5673e4b1cdd19e5f3a867213b9fe337012f17d", "install_static_unittests": "5244f04bfaccb10700261a4d1518b7b475102eb8", "installer_util_unittests": "5405bd6bd61aab9ebb6e8125913532bfd6bb897e", "interactive_ui_tests": "c86e9e45491146c95fd8f82b773319a7bd2fe0e0", "ipc_tests": "f65eccc2df3fe16ef44c6673a65f77825b0b311f", "jingle_unittests": "66a8ff75c425dfcfb9ee31aea044f81bf96742d5", "latency_unittests": "8f9735cbe62d317edd77cec0e5d0b365fb206209", "leveldb_service_unittests": "4e2da1cd3cc568faae35db7e5edfe461c0fc90f2", "libjingle_xmpp_unittests": "2166bc1e74c60712e331abeddce9d9e49c93b88e", "media_blink_unittests": "638150a1f658e10ca92611f0084614a8a50346ea", "media_service_unittests": "7a234cdd959486145c7bc8b76890113ea38a676d", "media_unittests": "e89ffd00c23492a8ce12f1ea9013225b1c4d45dc", "message_center_unittests": "de8bc2580c6805aaee6cab4b50297dcdbab6ff95", "metrics_python_tests": "7003088f8844ddea2fbc6fc6ae3991c3f01cf7ec", "midi_unittests": "85d5cc07fe72d05f50666162122f6892ff44dcda", "mojo_core_unittests": "9d25704c77c667fbf99fbd8454dccb27d6cfa3d1", "mojo_unittests": "68257af00e80c0a91f043362ff567867751b5b56", "nacl_loader_unittests": "bc8d91a3c7f2395a2272ebb98998eb2d66e2505e", "native_theme_unittests": "503b704ba23b228b899210044ff4464c4998d32d", "net_unittests": "5bfd401e6db3997ee0c3e2326bdedc20d99992a5", "pdf_unittests": "feabcbde75844dc49392f4453345f605d3d4f56f", "ppapi_unittests": "31b715646edaac59356c379d2d3c75ee8357ad89", "printing_unittests": "3ba8e5f12871568e50feaf61a839c75e7a6f651e", "remoting_unittests": "b232a23c6a847ff384f02ddc3c9fc7bfe1de1d53", "sbox_integration_tests": "109ebfcfbdf5be8ff30ac702409e1da4431a1794", "sbox_unittests": "4911394ab0fc27bc405d19256b5fa613fa2a6278", "sbox_validation_tests": "a9a6a18bd16981209725cf5c16762166dff89658", "service_manager_unittests": "ecb7e8cd4ebe7f7ac8a663645db77d85b706df1c", "services_unittests": "32781d86f213c572b8a9f94e734cde4e884865a8", "setup_unittests": "0ca4f08fb431bfe356b677ed5488cc08809171db", "shell_dialogs_unittests": "541b536cdc6cd234a025693a8b7e0a42d81ad211", "skia_unittests": "cc694c6e7c71ca1d5507e4c211ec0d33301f11a2", "snapshot_unittests": "23c8b5367eff32ae3dc333b7c0b37b44b1fd1e21", "sql_unittests": "f2254ee23dd128e4dc8e4d4b21c588d8e4d62b8b", "storage_unittests": "7443b97d7e7c9ae7bd8250e90778d4f5efaec635", "sync_integration_tests": "ad0bdb7f6f48d7351bba72886bdc37d624c5e999", "telemetry_gpu_unittests": "0951a6007601345a5d8458f3bb05daad73b26cd4", "telemetry_perf_unittests": "82a1cded3feedd0f78fee3fddf4ed62ced4ffacc", "telemetry_unittests": "f134f98ea3b4cfec736551103aa11f0b07285e51", "ui_base_unittests": "3b0234f735a8dd258df47178231765ce1641395e", "ui_touch_selection_unittests": "212d4c679bb2e45bc89fb1eeefb96b611c65dced", "unit_tests": "5cf5517c7bcfd1697c125cc979fcb61052397072", "url_unittests": "2245484f3b16c139e3053deb924d08a25789abcc", "views_perftests": "00a96e96b1131bb8556f24fb1ff2d87c6b117e3b", "views_unittests": "c70b1166a643573f1c9dba405b2771634fce6d5e", "viz_unittests": "6c96f824cdcb4f1192e33b7f8fb890b6205212f5", "vr_common_unittests": "66aa3e41ace8509a9cd2e76d0c7b96425e71dc7f", "webkit_layout_tests_exparchive": "3d76f3c41f5530ac7fe9da40ee65433121df4654", "webkit_python_tests": "206eee6111b7e3be0e9571ec192d3d6b14ae42ea", "webkit_unit_tests": "3b2893dd0ac40d4f726d8ee2e8c4d73e28e539ee", "wm_unittests": "a7210d75bb7bbbac998ad5b901bfec2d2fb35107", "wtf_unittests": "cdbaf57b9a2a81c69b26926b535180717227e2cb", "zucchini_unittests": "7c98a6583b3aecbdf9c616a64a0d0c2e7ae81bd8"} find isolated tests

Blamelist:

  1. erikchen (erikchenohnoyoudont@chromium.org)
  2. Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
  3. Martin Kreichgauer (martinkrohnoyoudont@google.com)
  4. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  5. Nick Burris (nburrisohnoyoudont@google.com)
  6. Greg Kraynov (kraynovohnoyoudont@chromium.org)
  7. spqchan (spqchanohnoyoudont@chromium.org)
  8. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  9. Andrey Lushnikov (lushnikovohnoyoudont@chromium.org)
  10. Thomas Guilbert (tguilbertohnoyoudont@chromium.org)
  11. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  12. Amirhossein Simjour (asimjourohnoyoudont@chromium.org)
  13. Ryan Daum (rdaumohnoyoudont@chromium.org)
  14. Danyao Wang (danyaoohnoyoudont@chromium.org)
  15. Tarun Bansal (tbansalohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 21:01:27 UTC
Start Thursday, 12-Jul-18 21:01:28 UTC
End Thursday, 12-Jul-18 21:27:50 UTC
Pending 1 secs
Execution 26 mins 21 secs

All Changes:

  1. Remove assertion from DetachToOwnWindow on macOS 10.10.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b20bb048913985eae71b480db2a2017173ef73a2

    Comments

    Remove assertion from DetachToOwnWindow on macOS 10.10.
    
    On macOS 10.10, AppKit appears to use the test's generated events to
    asynchronously reactivate the first window. There's no way to tell when this
    asynchronous reactivation will happen, so just avoid checking the assertion in
    the test. This problem appears constrained to how we generate test events, and
    not to the actual behavior of Chrome.
    
    Bug: 862859
    Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
    Reviewed-on: https://chromium-review.googlesource.com/1135305
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574699}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
  2. Revert "[AF][IOS] Scan page for form changes when a field is focused"

    Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b937d53836386e51532fbe870938b33ce0455ed

    Comments

    Revert "[AF][IOS] Scan page for form changes when a field is focused"
    
    This reverts commit 77318515062e22c6dbcb5b4ae8c6daa4ef70d5b9.
    
    Reason for revert:
    This change caused a regression (crbug.com/860225). The cause of the regression is that when user focuses a field in order to edit it, Autofill::OnFormsSeen is called which in turn updates the cached form with the new user entered values. Once submitted, form values are discarded as they're thought to be the initial form values on page load. In its current implementation Autofill::OnFormsSeen is only intended to be called on page load.
    
    Original change's description:
    > [AF][IOS] Scan page for form changes when a field is focused
    >
    > This CL fixes a regression caused by crrev.com/c/1012979. Previously,
    > AutofillAgent would scan the whole page on form activities due to the
    > possiblity of Autofill having been enabled after page load.
    > crrev.com/c/1012979 replaced that logic in favor of observing the Pref
    > directly. This has a side effect where previously hidden fields can go
    > unnoticed by AutofillManager. This CL fixes that regression by scanning the
    > page when a field is focused. All fields receive focuse before their value
    > is set by Autofill, therefore, AutofillManager can get notified of
    > previously hidden fields.
    >
    > Bug: 855696
    > Change-Id: I175bf90e12d1ca356b746e6347943a295063c288
    > Reviewed-on: https://chromium-review.googlesource.com/1112493
    > Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    > Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#570713}
    
    TBR=olivierrobin@chromium.org,mahmadi@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 855696, 860225
    Change-Id: Icc39e67e6d502d75451dbec83d6271255639ee4c
    Reviewed-on: https://chromium-review.googlesource.com/1135671
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574698}

    Changed files

    • components/autofill/ios/browser/autofill_agent.mm
  3. device/fido/mac: integrate with browsing data deletion

    Changed by Martin Kreichgauer - martinkrohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:13:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d54b58e5b08b96664080795a01e0bd2373952e6e

    Comments

    device/fido/mac: integrate with browsing data deletion
    
    This updates browsing data deletion for DATA_TYPE_PASSWORDS to call
    device::fido::mac::DeleteWebAuthnCredentials, which deletes credentials
    created by the macOS platform authenticator from the OS keychain.
    
    Also combine the two Touch ID specific configuration methods in
    {Chrome,}AuthenticatorRequestDelegate and introduce a static variant for
    Chrome.
    
    Bug: 678128
    Change-Id: I0034e0815da068fb27c1ea60cad95f958956838e
    Reviewed-on: https://chromium-review.googlesource.com/1125177
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574697}

    Changed files

    • chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
    • chrome/browser/webauthn/chrome_authenticator_request_delegate.h
    • chrome/browser/webauthn/chrome_authenticator_request_delegate_unittest.cc
    • content/browser/webauth/authenticator_impl.cc
    • content/public/browser/authenticator_request_client_delegate.cc
    • content/public/browser/authenticator_request_client_delegate.h
    • device/fido/mac/authenticator.h
  4. Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 20:12:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 460febcbc6e56f2355493a4f43188b08753c2dc6

    Comments

    Roll src/third_party/webrtc 798ee75d2365..895617fa9bc3 (3 commits)
    
    https://webrtc.googlesource.com/src.git/+log/798ee75d2365..895617fa9bc3
    
    
    git log 798ee75d2365..895617fa9bc3 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 buildbot@webrtc.org Roll chromium_revision efbdada3f7..f7c234b027 (574489:574598)
    2018-07-12 magjed@webrtc.org Android: Add helper functions for comparing H264 codecs
    2018-07-12 saza@webrtc.org Remove useless import of arm.gni
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@895617fa9bc3
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I07750ee2f3c028532fb0dfbfa0386eeeb119c8f8
    Reviewed-on: https://chromium-review.googlesource.com/1135612
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574696}

    Changed files

    • DEPS
  5. Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:11:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda02794921ad4eca0b4c5d15c21bc0461e73fa

    Comments

    Chrome Cleanup UI: Extract GetLastUsedProfile call from scanner results
    
    Chrome runs into a fatal error when the cleaner detects unwanted
    software. This is because ChromeCleanerScannerResults is created in the
    IO thread, and ProfileManager::GetLastUsedProfile requires the UI
    thread. The tests passed because they run a test browser process.
    
    - Extract extension name fetching to a separate function.
    - Call this function in tests so they're not affected.
    - Follow-up CL: Call this function once the scanner results are on the
    UI thread, before they're sent to the web UI.
    
    Bug: 853339
    Change-Id: I9cc2425f7b196e923a22b2afd1e8eee7fca61f5b
    Reviewed-on: https://chromium-review.googlesource.com/1135194
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574695}

    Changed files

    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_impl_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.cc
    • chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_scanner_results.h
  6. Remove components/viz/test dependency from blink platform.

    Changed by Greg Kraynov - kraynovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:07:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a7df13b2932f8f83559de4c263c972e08f9301b

    Comments

    Remove components/viz/test dependency from blink platform.
    
    cc::OrderedSimpleTestTaskRunner isn't used there anymore.
    
    Bug: 841735
    Change-Id: I88a5bfa2ebaf01a08943396ce20f63c483a19b3a
    Reviewed-on: https://chromium-review.googlesource.com/1133177
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: Greg Kraynov <kraynov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574694}

    Changed files

    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/child/DEPS
    • third_party/blink/renderer/platform/scheduler/common/DEPS
    • third_party/blink/renderer/platform/scheduler/main_thread/DEPS
    • third_party/blink/renderer/platform/scheduler/renderer/DEPS
    • third_party/blink/renderer/platform/scheduler/worker/DEPS
    • third_party/blink/renderer/platform/testing/DEPS
  7. [Mac] Refactor BrowserWindowTouchBarMac

    Changed by spqchan - spqchanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:05:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e95b7292bae44c8e6fb9af5801f102ae28587d6c

    Comments

    [Mac] Refactor BrowserWindowTouchBarMac
    
    Separate BrowserWindowTouchBarMac into two classes:
    BrowserWindowDefaultTouchBar and
    BrowserWindowTouchBarController.
    
    BrowserWindowTouchBarController determines what
    touch bar should be used for browser window.
    BrowserWindowDefaultTouchBar creates a default
    touch bar for the browser.
    
    These changes are split from a bigger change to
    hook up touch bar support for web textfield in
    MacViews:
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1132597
    
    Bug: 856391
    Change-Id: I9be31c65bd0acc2ec4d39b5e2f6b06fc30e36bf7
    Reviewed-on: https://chromium-review.googlesource.com/1133705
    Commit-Queue: Sarah Chan <spqchan@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574693}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/browser_window_touch_bar_mac.h
    • chrome/browser/ui/cocoa/browser_window_controller.h
    • chrome/browser/ui/cocoa/browser_window_controller.mm
    • chrome/browser/ui/cocoa/framed_browser_window.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar_unittest.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/browser_window_touch_bar_controller_browsertest.mm
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/test/BUILD.gn
  8. milo: Add link to chromiumos tryserver to chromium's console.

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6678ca5e07d42a16c0e63b123543672ab94c3c29

    Comments

    milo: Add link to chromiumos tryserver to chromium's console.
    
    And alphabetize the list.
    
    R=hinoka
    
    Change-Id: I28d7c354c153f848fae7098e57b67445345cb850
    Reviewed-on: https://chromium-review.googlesource.com/1135691
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574692}

    Changed files

    • infra/config/global/luci-milo.cfg
  9. Make content::PermissionManager a delegate of PermissionController

    Changed by Andrey Lushnikov - lushnikovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ebff0440cc1ada42a20446c0f6d9ddf0619f64df

    Comments

    Make content::PermissionManager a delegate of PermissionController
    
    One-pager describing this refactoring: https://goo.gl/24gkCb
    
    Today, `content/` layer provides `permission_manager.h` interface that
    is supposed to be implemented by embedders and simultaneously used
    as API in `content/` layer. This leaves us with no place in content/ layer
    where we can put DevTools instrumentation.
    
    This patch separates content API from embedder interface. With this
    patch, `content/` layer provides 2 interfaces:
    - content::PermissionController - content-level API to manage permissions
    - content::PermissionManager - interface to be implemented by
    embedders. This is a delegate for content::PermissionController.
    
    This design enables DevTools to handle and override content permissions through
    DevTools protocol. The functionality will be encapsulated in
    PermissionController class.
    
    There's exactly one PermissionController for each BrowserContext.
    If embedder doesn't implement PermissionManager, then
    PermissionController rejects all permission requests.
    
    In a follow-up:
    - rename `content::PermissionManager` into `content::PermissionControllerDelegate`.
    - rename `BrowserContext::GetPermissionManager()` into `BrowserContext::GetPermissionControllerDelegate()`.
    - rename `TestBrowserContext::SetPermissionManager()` into `TestBrowserContext::SetPermissionControllerDelegate()`.
    
    R=dgozman
    TBR=sdefresne, tobiasjs, slan, thakis
    BUG=631464
    
    Change-Id: I5f6f1ea5b28e284c462a5055d9b072f12f30ce19
    Reviewed-on: https://chromium-review.googlesource.com/1111340
    Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574691}

    Changed files

    • android_webview/browser/aw_permission_manager.cc
    • chrome/browser/net/reporting_permissions_checker.cc
    • chrome/browser/notifications/platform_notification_service_impl.cc
    • chrome/browser/permissions/permission_manager.cc
    • chromecast/browser/cast_permission_manager.cc
    • components/domain_reliability/service.cc
    • components/domain_reliability/service_unittest.cc
    • components/payments/content/installable_payment_app_crawler.cc
    • content/browser/BUILD.gn
    • content/browser/background_sync/background_sync_manager.cc
    • content/browser/browser_context.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.cc
    • content/browser/generic_sensor/sensor_provider_proxy_impl.h
    • content/browser/geolocation/geolocation_service_impl.cc
    • content/browser/geolocation/geolocation_service_impl.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/notifications/blink_notification_service_impl.cc
    • content/browser/payments/payment_app_provider_impl.cc
    • content/browser/permissions/permission_controller_impl.cc
    • content/browser/permissions/permission_controller_impl.h
    • content/browser/permissions/permission_service_context.cc
    • content/browser/permissions/permission_service_impl.cc
    • content/browser/push_messaging/push_messaging_manager.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/browser_context.h
    • content/public/browser/permission_controller.h
    • content/public/browser/permission_manager.h
    • content/public/test/mock_permission_manager.cc
    • content/shell/browser/layout_test/layout_test_permission_manager.cc
    • content/shell/browser/shell_permission_manager.cc
    • headless/lib/browser/headless_permission_manager.cc
  10. Move content::MediaController to media/base

    Changed by Thomas Guilbert - tguilbertohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:02:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2784a2c6630a8de538a7b2bf6d993823d321a489

    Comments

    Move content::MediaController to media/base
    
    The MediaController interface and the upcoming MediaStatusObserver do
    not have to live in content/public/browser. The media/base folder and
    the media namespace is a more generic place for them to live, even if
    most of the code that will use them lives in content.
    
    Bug: 820277
    Change-Id: I2f91cd88c6f5238723aae8aeff1c323c02f738d4
    Reviewed-on: https://chromium-review.googlesource.com/1134090
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574690}

    Changed files

    • chrome/browser/media/android/remote/media_controller_bridge.h
    • chrome/browser/media/android/router/media_router_android.cc
    • chrome/browser/media/android/router/media_router_android.h
    • chrome/browser/media/android/router/media_router_android_bridge.cc
    • chrome/browser/media/android/router/media_router_android_bridge.h
    • chrome/browser/media/router/media_router.h
    • chrome/browser/media/router/media_router_base.cc
    • chrome/browser/media/router/media_router_base.h
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.cc
    • chrome/browser/media/router/presentation/presentation_service_delegate_impl.h
    • content/browser/media/flinging_renderer.cc
    • content/browser/media/flinging_renderer.h
    • content/browser/media/flinging_renderer_unittest.cc
    • content/browser/presentation/presentation_service_impl_unittest.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/presentation_service_delegate.h
    • media/base/BUILD.gn
    • media/base/media_controller.h
  11. Improved performance of AXPosition::operator less than

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adeaf13d9c8651fcf83c9e5a6a7d1173f1eb27e1

    Comments

    Improved performance of AXPosition::operator less than
    
    Only move up or down the tree using text equivalent positions (by calling CreateParentPosition and AsLeafTextPosition) when we absolutely need to.
    R=dmazzoni@chromium.org
    
    Tested: VoiceOver on Mac by navigating in Gmail and checking how many times you hear "Busy"
    Change-Id: Id9469e52ef87b8b8a0c6c5fac5325abec415382d
    Bug: 861567
    Reviewed-on: https://chromium-review.googlesource.com/1133334
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574689}

    Changed files

    • ui/accessibility/ax_node_position_unittest.cc
    • ui/accessibility/ax_position.h
  12. VR: fix autofill popup size

    Changed by Amirhossein Simjour - asimjourohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:01:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d07f06bb5c43657ce38efc57039e36287eac2a6

    Comments

    VR: fix autofill popup size
    
    Break SetAlertDialogSize into to methods. One to set the relative
    size to the main content, another one to set the absolute size.
    Also added comment to hosted_platform_ui to clarify the size of
    the rectangle in the model.
    
    Bug: 863071
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie102fcb00865d66052e4bb3c7817831fdcfe5dfa
    Reviewed-on: https://chromium-review.googlesource.com/1132140
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574688}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/model/hosted_platform_ui.h
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
  13. [chromecast] Support for top-down drag gesture.

    Changed by Ryan Daum - rdaumohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:00:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7281e2b2ea7ce739c6106b6005a2d58a9eedb86a

    Comments

    [chromecast] Support for top-down drag gesture.
    
    Bug: internal b/111304882
    Test: unit test and manual
    Change-Id: Iab32b58098a02eb054faeb94625e312d274cdae1
    Reviewed-on: https://chromium-review.googlesource.com/1135692
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Alex Sakhartchouk <alexst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574687}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/browser/cast_gesture_dispatcher_test.cc
  14. [Nav Experiment] Parameterize HistoryStateOperationsTest.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:57:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32bdecc1fac228cf335811bea0f31e2a29153f29

    Comments

    [Nav Experiment] Parameterize HistoryStateOperationsTest.
    
    So both LegacyNavigationManager and WKBasedNavigationManager can be
    tested on trybots.
    
    Fixed test expectation for StateReplacementBackForward to match the
    behavior of WebKit (and Safari on other platforms).
    
    Bug: 862724
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic01dcabf2e6ef6903d8f8ee348798951007660cc
    Reviewed-on: https://chromium-review.googlesource.com/1134472
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574686}

    Changed files

    • ios/web/navigation/history_state_operations_inttest.mm
  15. Network quality servicification of RTT and downlink estimates

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88c8cc52351f93d11e0bfac3b75ded5b420b131b

    Comments

    Network quality servicification of RTT and downlink estimates
    
    Send the RTT and downlink estimates over the mojo channel
    to the browser process. The RTT and downlink estimates are
    sent over an existing mojo message which carrier the current
    effective connection type estimate.
    
    The mojo message is sent only if there is a significant change
    in the values of either the RTT or the downlink estimate.
    
    In the next CL, I will move the network quality consumers
    in the browser process over to NetworkQualityTracker.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I01bbc7af2e7e3cf41f69e7ac19f8edd9ec59de90
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1130233
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574685}

    Changed files

    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • services/network/network_quality_estimator_manager.cc
    • services/network/network_quality_estimator_manager.h
    • services/network/network_quality_estimator_manager_unittest.cc
    • services/network/public/cpp/network_quality_tracker.cc
    • services/network/public/cpp/network_quality_tracker.h
    • services/network/public/cpp/network_quality_tracker_unittest.cc
    • services/network/public/mojom/network_quality_estimator_manager.mojom