Home | Search | chromium - Builders
Login

Builder Win7 (32) Tests Build 35537 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision3fb53cf0d187b9537160ad967975f17641d59c1f
Got Revision3fb53cf0d187b9537160ad967975f17641d59c1f

Execution:

Steps and Logfiles:

Show:
  1. ( 481 ms ) setup_build
    running recipe: "chromium"
  2. ( 2 secs ) taskkill
  3. ( 314 ms ) remove .cipd
  4. ( 1 mins 24 secs ) bot_update
    [55GB/349GB used (15%)]
  5. ( 669 ms ) swarming.py --version
    0.13
  6. ( 1 mins 21 secs ) gclient runhooks
  7. ( 586 ms ) read test spec (chromium.win.json)
    path: e:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 8 secs ) build directory
  9. ( 4 mins 51 secs ) extract build
  10. ( 1 secs ) find isolated tests
  11. ( 20 secs ) base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 31s
  12. ( 2 secs ) battor_agent_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  13. ( 16 mins 26 secs ) browser_tests
    Run on OS: 'Windows-7-SP1'
    Max pending time: 0:09:26.072660 (shard #9)
    Max shard duration: 0:09:08.911930 (shard #2)
    Min shard duration: 0:05:10.671840 (shard #5)
  14. ( 2 secs ) sbox_integration_tests
    Run on OS: 'Windows-7-SP1'
    Pending time: 0:11:09.450830
    Shard duration: 24s
  15. ( 2 secs ) sbox_unittests
    Run on OS: 'Windows-7-SP1'
    Pending time: 0:11:34.619660
    Shard duration: 19s
  16. ( 2 secs ) sbox_validation_tests
    Run on OS: 'Windows-7-SP1'
    Pending time: 0:11:55.193610
    Shard duration: 18s
  17. ( 258 ms ) Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 1:06:56.096000
     
  18. ( 580 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "e:\\b\\s\\w\\ir\\cache", "temp_dir": "e:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm29-m1" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531412336105520, "id": "8941191494214377680", "project": "chromium", "tags": ["builder:Win7 (32) Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/3fb53cf0d187b9537160ad967975f17641d59c1f", "gitiles_ref:refs/heads/master", "parent_buildername:Win Builder", "parent_buildnumber:57142", "scheduler_invocation_id:9106621556347218288", "scheduler_job_id:chromium/Win7 (32) Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win7 (32) Tests" setup_build
buildnumber 35537 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win Builder" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "3fb53cf0d187b9537160ad967975f17641d59c1f" setup_build
parent_got_revision_cp "refs/heads/master@{#574574}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23950}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "3fb53cf0d187b9537160ad967975f17641d59c1f" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "3fb53cf0d187b9537160ad967975f17641d59c1f" bot_update
got_revision_cp "refs/heads/master@{#574574}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes {"accessibility_unittests": "802e37d9be10bfecd227fd0264c99bc45b113648", "angle_unittests": "0c54387d547d6d953f2c1e2c1e2b99486bc45f8b", "app_shell_unittests": "2e8ed272534471f7659821100dfc476d422ac085", "aura_unittests": "da3aaf984a922518ef6a66ae344c39ac5950b12e", "base_unittests": "85025b76556833b50428bbc5d712d31d3d997e54", "battor_agent_unittests": "fe4c4d0d59bf74f529340ebcb6890ec9b39fb824", "blink_common_unittests": "f0eb126236b32f47ae68a38f74058f80e861a730", "blink_fuzzer_unittests": "69a584a6b5a1a01c482da6cb89f9caacd72d5d47", "blink_heap_unittests": "95575ccfc27264188de7a3917e5828b49c116036", "blink_platform_unittests": "1753ac47cc54922b88c628e7554867af448b13c3", "boringssl_crypto_tests": "e626759e6f09f00ac51cc84df3899d5c517542e5", "boringssl_ssl_tests": "ac9e29ce0ce3164e60ab0d2aca760282c0a4a94f", "browser_tests": "5e349a7b3fc356eff35032dfb7ca528f66ecec44", "cacheinvalidation_unittests": "aa3d3a08d70bb6063ba1f9d5c83bc21caeded8f7", "capture_unittests": "1b9e8bf92dbcd1fb005b4d0fac0fed2abf9e2982", "cast_unittests": "38bc89381fdcf2c92107bf0f26df595c0b44cc90", "cc_unittests": "b35083a439e66bcf52a2cf577a1a650b6374d792", "chrome_app_unittests": "668ddfebe16dc35c43252075758a58aeb6fb9812", "chrome_cleaner_unittests": "3b7d15bfdfa602446594c2588153f3b92d819967", "chrome_elf_import_unittests": "79d11259c1c6039ba28bd1cf84d89857f0948906", "chrome_elf_unittests": "1db449e8f26b5fade82d3296691658d1ca400e77", "chromedriver_py_tests": "19906ae785c94f1c768d5b36bd9cc5796b1a9493", "chromedriver_unittests": "13e0a50b8c3c8b042e6e8178489fddb5038cbb10", "components_browsertests": "90de8cbd33068bb77955219f53ee3d403366da82", "components_perftests": "c1537e3101a5d085a88374e3919999fd843988db", "components_unittests": "6db9cf13d02415a01120ccb4e36fee627a722cf2", "compositor_unittests": "fa2e2f99c8fb8258afcc294ec4dcdad04cb75ec0", "content_browsertests": "1d768e9854fbe462ab63250bcf1b7e1677e29e92", "content_shell_crash_test": "e93450ef472c35b1d73ded1b97785f76e6fd7940", "content_unittests": "79f1e3ef00c57430afdcb671af8cf4243670355f", "courgette_unittests": "ce2bb591c8aae93feb3ea15bfb79afd8d3055f15", "crashpad_tests": "73ba7e75c99cc8f13ed1230d3b8517837159f045", "cronet_tests": "303dd0e0649509e73b9d77d307e0129dfdc92889", "cronet_unittests": "e7ca848a388a2b30b5783d27b02031ff3de53d64", "crypto_unittests": "ac1382a3b5c19f32bf71478fb0a33126ec7c8631", "device_unittests": "3ccf05eb5ca949717406d938e98e9c7048aef9e2", "display_unittests": "f7c3733e27c2feeabb4505652a2e886fdd782116", "elevation_service_unittests": "6630f9c56bded9a1191c2b3f1fd1387cad3e4142", "events_unittests": "0272e9862ab3254dd79e2c01069258f05f0978c1", "extensions_browsertests": "ca8f0756f48bb1ce0dd18cb821c9da6862aa059e", "extensions_unittests": "e541fa20f0c11b7935a6139f4a1359afa2c24457", "filesystem_service_unittests": "78937a0f16c08523b1b6f6117fc882f93594b83a", "gcm_unit_tests": "f5eaf923f5c3f04240de90e5dfae020722738f4c", "gfx_unittests": "a29072a1d5b9f61aa296ea5bbc81801b2c55cee2", "gin_unittests": "ca880d091dcfbd0937a45253cdea10ceebdb7725", "google_apis_unittests": "36997a18fed10d298f7c77d56209f10ce0e65037", "gpu_unittests": "21d4560fb9ba62a74dcb1a88cf8dcbdb4e233132", "headless_browsertests": "f793d693f67c1d818fbcbae62c4965d4be07c53e", "headless_unittests": "632267aaeabed200594b22bd6d03f9d15b6d72d3", "install_static_unittests": "5816c31865c8e35f682844cadeacabbaa9f3fd0f", "installer_util_unittests": "09017e6d4d44ceee425f2f6e00c82dd87c336915", "interactive_ui_tests": "68cd6f5dfa087b122e5cc77c09fe0969442e2f8f", "ipc_tests": "4f250ab9f5085c18df948a2121852683dd60b16f", "jingle_unittests": "55c91e553401e4ff3ab494d05a5e8eee95c48382", "latency_unittests": "056d3686b6ed9a90f0784a69f9c2a5c569bb614e", "leveldb_service_unittests": "86ce0dd0bf20635260647cefdc517d789aa8f0fa", "libjingle_xmpp_unittests": "4cb13d440be90eb40e9d93bb0b52391033a0bfec", "media_blink_unittests": "89b234c3108a31cfe47e5a26f07683a79ad3e370", "media_service_unittests": "539e61d13477e733bbe857304ea3085957650a4f", "media_unittests": "6ba11c9fc6e48c62680c137d220c48242a078fff", "message_center_unittests": "a23d6344375fc5c115ea18cfb9c772dc856354cc", "metrics_python_tests": "7003088f8844ddea2fbc6fc6ae3991c3f01cf7ec", "midi_unittests": "865397aaca0762a4de422a769def358f6bf4b4fd", "mojo_core_unittests": "9b6b5e98ae4112fae6c6eb951c79849ea1bbfb38", "mojo_unittests": "a9fe00160862711f2288db46effb4bdfbd62c340", "nacl_loader_unittests": "71fedabd058f466c6d1caaccf294629fd5757ddd", "native_theme_unittests": "e402dd52b969d90f412c87f62cf3ee7afc0e9dc6", "net_unittests": "f6a4b0922eb04039251cd8047b0a939bd3df53dc", "pdf_unittests": "8fd3682e08764176f45bc78659de2f8a263047a0", "ppapi_unittests": "8792d1e68dfed39c95e6031b644414567d1ef1f6", "printing_unittests": "214fd88854b7e79e6ed0301125c018d3e1814ae3", "remoting_unittests": "99e3df393a9d8bdcf82234660d182dfc1fff3286", "sbox_integration_tests": "da1d2ee5675f9e65f42ae3dce9e205d3f9aa162e", "sbox_unittests": "785d68e74de3c0c6059ea3437cacd6c486d3b79a", "sbox_validation_tests": "daabc4da2038c8c4932f08b5f08684e88537165f", "service_manager_unittests": "82a0cb8234b76f8c149c63383fb6433a24c6cea9", "services_unittests": "59cfa89f620df24daa77fd159b279ff38bbbab72", "setup_unittests": "fde38440d83a0b9d8aa2ebdcc69bdc8691d4947c", "shell_dialogs_unittests": "ac64d6956be34f37ba7a683cb1a6c669f6a8f438", "skia_unittests": "7f37189a62b11da63a75d7598d844aa176059240", "snapshot_unittests": "b213bfaee7851213fc8e8c67977f547ae8988e24", "sql_unittests": "c6920432ee727d21243ddef64794038634026665", "storage_unittests": "4ea8fe1263d7cd76c68ecf5ffb0c71ab7b1ded27", "sync_integration_tests": "6944476ee7a92482470b89233971a61e8c97ee21", "telemetry_gpu_unittests": "0951a6007601345a5d8458f3bb05daad73b26cd4", "telemetry_perf_unittests": "09c96ebd9d58c814425114be12e7bd3ef77f5e75", "telemetry_unittests": "5e4f648ee01648fe97df4e269002765b66911a80", "ui_base_unittests": "7227c5d03d63b546bde700f6593abee777d1de3b", "ui_touch_selection_unittests": "70a89cb6a1b36bc064b53999308ad403d9fb155c", "unit_tests": "b97858ae315f204f1792d6dea6ff671eff02a427", "url_unittests": "c723ba87a0d3f19334865a6e1e8c3c4684ba6f07", "views_perftests": "29f8fe8ba7d03501cd01d423efb720ea7ef1faa4", "views_unittests": "5b2d7d6434a2916e97c855dc58414a84e1753596", "viz_unittests": "c4a95435e2486ccc31cb87cd0cf2e65333318d54", "vr_common_unittests": "b2cb846a650689d8ec2c40778c7659b49ab20d2a", "webkit_layout_tests_exparchive": "54b575c655593595f9c1b9a86a606f1afc0f5f7c", "webkit_python_tests": "d318cca88fb14c675b6d34bda29a0c7f97df603c", "webkit_unit_tests": "7fa6304b139c994e0ca0e0ab5d925ebc59d89865", "wm_unittests": "be37d569462f151d5df339c130471e200a2f7797", "wtf_unittests": "3f06c93c250c8a717a0f395d096accf653d96462", "zucchini_unittests": "a265adf07a8f7ad3b3ffa15f194cd7c679bc7848"} find isolated tests

Blamelist:

  1. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  2. Majid Valipour (majidvpohnoyoudont@chromium.org)
  3. kylechar (kylecharohnoyoudont@chromium.org)
  4. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  5. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  6. vitaliii (vitaliiiohnoyoudont@chromium.org)
  7. Ken Rockot (rockotohnoyoudont@chromium.org)
  8. John Abd-El-Malek (jamohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:18:56 UTC
Start Thursday, 12-Jul-18 16:18:56 UTC
End Thursday, 12-Jul-18 16:46:37 UTC
Pending 705 ms
Execution 27 mins 40 secs

All Changes:

  1. fuzzer: Don't assume that the out dir is inside the src git repository.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fb53cf0d187b9537160ad967975f17641d59c1f

    Comments

    fuzzer: Don't assume that the out dir is inside the src git repository.
    
    This might not be the case in general. Not only could a output directory
    exist elsewhere altogether (though this only fixes one issue that breaks
    when you do that), but it could be a symlink or another filesystem; in
    such cases git does not consider it part of the repository.
    
    This can be addressed by explicitly giving the path to src.git when issuing
    git commands.
    
    Change-Id: Ibf62466548e15d6ef57ed1e959d507ff70076352
    Reviewed-on: https://chromium-review.googlesource.com/1131842
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574574}

    Changed files

    • testing/libfuzzer/fuzzer_test.gni
    • testing/libfuzzer/gen_fuzzer_owners.py
  2. [testing] Move context menu ever timestamp test to a separate test

    Changed by Majid Valipour - majidvpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8696fc59786065ffc8a2e06f2db8f9e9ebc772a1

    Comments

    [testing] Move context menu ever timestamp test to a separate test
    
    ContextMenu interaction with other events is a suspected cause of
    flakiness of the original test. This CL is separating it from the
    rest as a potential fix.
    
    Bug: 846750
    Change-Id: I3d452388be65984ca82238d55a938d7a273fcf3f
    Reviewed-on: https://chromium-review.googlesource.com/1134180
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Commit-Queue: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574573}

    Changed files

    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/context-menu-event.html
    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html
  3. Update viz_content_browsertests filter.

    Changed by kylechar - kylecharohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e0d4f50a43ad0ec12342ccbd16bf63f571651a7

    Comments

    Update viz_content_browsertests filter.
    
    Undo revert in https://crrev.com/c/1134144 which didn't end up being
    needed. Revert was in response to FindIt and failures in
    SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest but that problem
    had already been addressed.
    
    TBR: jonross@chromium.org
    Bug: 848825, 848348
    Change-Id: Ie00ce45db8b380847dddf4fb099a120ce7ada987
    Reviewed-on: https://chromium-review.googlesource.com/1135146
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574572}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  4. [iOS] New location bar icons and fonts.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57bfd6b0cba9de19f7dd75558447eba072bf84da

    Comments

    [iOS] New location bar icons and fonts.
    
    Updates the logic to switch between larger and smaller fonts, replaces
    security state and voice/share icons.
    
    Bug: 856542
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iecc5da700dd9b3004e8480abaa842dc6e143bdca
    Reviewed-on: https://chromium-review.googlesource.com/1135128
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574571}

    Changed files

    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@3x.png
    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
  5. Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3b164c24e967409cad5205e6a1ed651615566aa

    Comments

    Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2
    
    Using wpt-import in Chromium d18929b41e24487865c4ed9da46129e6b037beeb.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21188
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    domenic@chromium.org, ricea@chromium.org:
      external/wpt/streams
    jsbell@chromium.org:
      external/wpt/encoding
    kojii@chromium.org:
      external/wpt/css/css-writing-modes
    mlamouri@chromium.org:
      external/wpt/screen-orientation
    
    TBR=foolip
    
    No-Export: true
    Change-Id: Ib04131d32533fd3a6687cc2999f6a0b409f08165
    Reviewed-on: https://chromium-review.googlesource.com/1134875
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574570}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/appmanifest/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-015.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-016.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-022.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-023.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-021.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-024.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-025.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/flexbox_align-items-stretch-writing-modes.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-018.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-017.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/writing-mode-vertical-rl-003.htm
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-basics.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-invalid-label.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-surrogates-utf8.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.html
    • third_party/WebKit/LayoutTests/external/wpt/encoding/replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-byte-order-marks.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-single-byte.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-ignorebom.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-labels.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-constructor-non-utf.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/unsupported-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-button-element/button-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-input-element/input-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-select-element/select-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-textarea-element/textarea-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/appmanifest.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/screen-orientation.idl
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/interfaces.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.dedicatedworker.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.js
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.serviceworker.https.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.sharedworker.html
    • third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/appmanifest/idlharness.window-expected.txt
  6. [Sync::Consent] Split ConsentAuditor interface from implementation.

    Changed by vitaliii - vitaliiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:40:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7782405912e05feca6e0cf3808ab8f3c8ff70f2f

    Comments

    [Sync::Consent] Split ConsentAuditor interface from implementation.
    
    Also rewrite FakeConsentAuditor to implement the interface instead of
    inheriting from the implementation. This unblocks enabling the separate
    datatype feature by default.
    
    Bug: 862186
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I474f74f12278221ef6278c120576f1ff1a224c4a
    Reviewed-on: https://chromium-review.googlesource.com/1131508
    Reviewed-by: Markus Heintz <markusheintz@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574569}

    Changed files

    • chrome/browser/consent_auditor/consent_auditor_factory.cc
    • chrome/browser/consent_auditor/consent_auditor_test_utils.cc
    • components/consent_auditor/BUILD.gn
    • components/consent_auditor/consent_auditor.cc
    • components/consent_auditor/consent_auditor.h
    • components/consent_auditor/consent_auditor_impl.cc
    • components/consent_auditor/consent_auditor_impl.h
    • components/consent_auditor/consent_auditor_impl_unittest.cc
    • components/consent_auditor/fake_consent_auditor.cc
    • components/consent_auditor/fake_consent_auditor.h
    • ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
    • ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm
  7. [content-service] Support basic View embedding

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:36:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c5bc74636041c26d31f3dae12c7fc51032ce27

    Comments

    [content-service] Support basic View embedding
    
    Adds support for embedding a View object within a client application's
    window tree. Currently Chrome OS only.
    
    Enables a new simple_browser test application to be launched via a
    command-line flag in DCHECK-enabled builds only, for manual developer
    testing. This application runs in a sandboxed utility process and embeds
    a View that can be navigated, displaying web contents within the
    application's UI, backed by a concrete WebContents owned by a Content
    Service instance in the browser process.
    
    Bug: 855092
    Change-Id: I95937f987e87ad303689d73b7e57c836ee706d28
    Test: Launch Chrome OS chrome --enable-features=Mash --launch-simple-browser and verify that you can navigate the cute little browser window that pops up.
    Reviewed-on: https://chromium-review.googlesource.com/1125342
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574568}

    Changed files

    • chrome/app/BUILD.gn
    • chrome/browser/BUILD.gn
    • chrome/browser/DEPS
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/common/BUILD.gn
    • chrome/common/features.gni
    • chrome/utility/BUILD.gn
    • chrome/utility/DEPS
    • chrome/utility/chrome_content_utility_client.cc
    • content/browser/browser_context.cc
    • content/browser/content_service_delegate_impl.cc
    • services/content/BUILD.gn
    • services/content/DEPS
    • services/content/public/cpp/BUILD.gn
    • services/content/public/cpp/DEPS
    • services/content/public/cpp/view.cc
    • services/content/public/cpp/view.h
    • services/content/public/features.gni
    • services/content/public/mojom/BUILD.gn
    • services/content/public/mojom/view.mojom
    • services/content/service_unittest.cc
    • services/content/simple_browser/BUILD.gn
    • services/content/simple_browser/DEPS
    • services/content/simple_browser/OWNERS
    • services/content/simple_browser/README.md
    • services/content/simple_browser/manifest.json
    • services/content/simple_browser/public/mojom/BUILD.gn
    • services/content/simple_browser/public/mojom/OWNERS
    • services/content/simple_browser/public/mojom/constants.mojom
    • services/content/simple_browser/simple_browser_service.cc
    • services/content/simple_browser/simple_browser_service.h
    • services/content/simple_browser/window.cc
    • services/content/simple_browser/window.h
    • services/content/view_delegate.h
    • services/content/view_impl.cc
    • services/content/view_impl.h
    • ui/views/mus/remote_view/BUILD.gn
  8. Fix crash with webRequest and network service when duplicate request IDs are seen.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:25:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4072ab48cadcd3f98481be63bdd59e5c623729d

    Comments

    Fix crash with webRequest and network service when duplicate request IDs are seen.
    
    The cause in this case was SimpleURLLoader always using a request ID of 0. These requests don't go through auth anyways (since there's no tab to associate them with). Gracefully handle this in WebRequestProxyingURLLoaderFactory by not crashing.
    
    Bug: 853118
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I856259f76caf67d7d6c0b8e48535cd56419ead1a
    Reviewed-on: https://chromium-review.googlesource.com/1133692
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574567}

    Changed files

    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter