Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 Build 29884 Microsoft Windows

Results:

Failure interactive_ui_tests on Windows-10-15063

Trigger Info:

Projectchromium
Revisioncc4b7196ecbd35a92870ed88bb47b4cd658aff4f
Got Revisioncc4b7196ecbd35a92870ed88bb47b4cd658aff4f

Execution:

Steps and Logfiles:

Show:
  1. ( 576 ms ) setup_build
    running recipe: "chromium"
  2. ( 265 ms ) report builders
     
    running tester 'Win10 Tests x64' on master 'chromium.win'
  3. ( 5 secs ) taskkill
  4. ( 1 mins 16 secs ) bot_update
    [66GB/299GB used (22%)]
  5. ( 607 ms ) swarming.py --version
    0.14
  6. ( 18 secs ) gclient runhooks
  7. ( 606 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 442 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 2 secs ) build directory
  10. ( 2 mins 35 secs ) extract build
  11. ( 475 ms ) find isolated tests
  12. ( 1 mins 35 secs ) test_installer
  13. ( 1 secs ) wait for tasks
  14. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  15. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  16. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  17. ( 2 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  18. ( 2 secs ) network_service_components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 47s
  19. ( 4 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  20. ( 2 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  21. ( 2 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  22. ( 3 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  23. ( 2 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  24. ( 2 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  25. ( 2 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  26. ( 2 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  27. ( 2 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  28. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  29. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  30. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  31. ( 2 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  32. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  33. ( 2 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  34. ( 2 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  35. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  36. ( 2 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  37. ( 2 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  38. ( 2 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:20.056810
  39. ( 2 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  40. ( 2 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  41. ( 2 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  42. ( 2 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 12s
  43. ( 2 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  44. ( 3 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:09.159947
  45. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  46. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  47. ( 2 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  48. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  49. ( 2 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  50. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  51. ( 4 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:25.580855
  52. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  53. ( 1 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  54. ( 3 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  55. ( 2 secs ) gcp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  56. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  57. ( 1 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  58. ( 2 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  59. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  60. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  61. ( 2 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  62. ( 2 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  63. ( 2 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  64. ( 2 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 47s
  65. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  66. ( 2 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  67. ( 1 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  68. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  69. ( 1 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:33.444768
  70. ( 2 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  71. ( 2 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  72. ( 2 secs ) webui_polymer2_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Pending time: 15s
    Shard duration: 0:01:44.660523
  73. ( 2 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  74. ( 14 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:18.909034
  75. ( 3 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  76. ( 2 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  77. ( 2 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  78. ( 2 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  79. ( 2 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 55s
  80. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  81. ( 4 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:05.808594
  82. ( 2 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  83. ( 2 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  84. ( 2 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  85. ( 2 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  86. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  87. ( 1 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  88. ( 2 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  89. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  90. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 12s
  91. ( 2 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  92. ( 1 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  93. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  94. ( 2 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  95. ( 2 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  96. ( 2 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  97. ( 4 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:04.371425
  98. ( 2 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  99. ( 2 secs ) network_service_extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:26.377952
  100. ( 2 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  101. ( 1 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  102. ( 3 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  103. ( 2 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  104. ( 1 secs ) wait for tasks (2)
  105. ( 2 secs ) webui_polymer2_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max pending time: 10s (shard #2)
    Max shard duration: 0:07:13.638630 (shard #2)
    Min shard duration: 0:05:23.362290 (shard #1)
  106. ( 3 secs ) network_service_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:11:53.388795 (shard #1)
    Min shard duration: 0:10:45.489614 (shard #0)
  107. ( 6 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:29.630691
  108. ( 3 secs ) interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:12:04.203072 (shard #0)
    Min shard duration: 0:08:35.806043 (shard #1)
    failures:
    WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus
    BookmarkBarViewTest24.ContextMenusKeyboardEscape
    FullscreenControllerStateInteractiveTest.STATE_BROWSER_FULLSCREEN__BUBBLE_EXIT_LINK__Empty
    PopupBlockerBrowserTest.OpenerSuppressed
    OmniboxViewTest.AcceptKeywordByTypingQuestionMark
    BrowserFocusTest.PopupLocationBar
    FullscreenControllerStateInteractiveTest.STATE_TO_NORMAL__BUBBLE_EXIT_LINK
    StarViewTest.HideOnSecondClick
    SitePerProcessInteractivePDFTest.ContextMenuPositionForEmbeddedPDFInCrossOriginFrame
    AppWindowHiddenKeepAliveTest.StaysHidden
    CommandsApiTest.RemoveBookmarkShortcutWithoutPermission
    BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc
    SadTabViewInteractiveUITest.SadTabKeyboardAccessibility
    PopupBlockerBrowserTest.PopupMetrics
    PasswordManagerInteractiveTest.UsernameChanged
    DevToolsManagerDelegateTest.NormalWindowChangeBounds
    BookmarkBarViewTest20.ContextMenuExitTest
    AutofillInteractiveTest.AutofillViaClick
    FullscreenControllerStateInteractiveTest.STATE_BROWSER_FULLSCREEN__WINDOW_CHANGE
    SadTabViewInteractiveUITest.ReloadMultipleSadTabs
    WebViewImeInteractiveTest.CompositionRangeUpdates
    BrowserFocusTest.AboutBlankNavigationLocationTest
    PlatformNotificationServiceBrowserTest.BlobAsNotificationImage
    PasswordGenerationInteractiveTest.PopupShownAndPasswordSelected
    FullscreenControllerStateInteractiveTest.STATE_TAB_BROWSER_FULLSCREEN__BUBBLE_EXIT_LINK__Empty
    PopupBlockerBrowserTest.PopupBlockedFakeClickOnAnchor
    FullscreenControllerStateInteractiveTest.STATE_TAB_FULLSCREEN__TAB_FULLSCREEN_TRUE
    BrowserViewTest.TabFullscreenShowTopView
    CommandsApiTest.ShortcutRemovedOnUpdate
    WebViewNewWindowInteractiveTest.NewWindow_NewWindowNameTakesPrecedence
    ... 165 more (195 total) ...
     
  109. ( 2 secs ) mini_installer_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:12.001867
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  110. ( 2 secs ) network_service_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max pending time: 16s (shard #2)
    Max shard duration: 0:11:38.199888 (shard #2)
    Min shard duration: 0:09:34.691492 (shard #1)
  111. ( 9 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:05:25.726933
  112. ( 2 secs ) sync_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:09:27.108880
  113. ( 5 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:16.800711
  114. ( 34 secs ) wait for tasks (3)
  115. ( 9 secs ) network_service_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max pending time: 10s (shard #11)
    Max shard duration: 0:15:52.391894 (shard #5)
    Min shard duration: 0:13:14.612394 (shard #4)
  116. ( 3 mins 39 secs ) wait for tasks (4)
  117. ( 3 secs ) content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:18:48.587792
  118. ( 9 secs ) browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:20:56.235595 (shard #2)
    Min shard duration: 0:16:36.529909 (shard #5)
  119. ( 220 ms ) Tests statistics
     
    Stats
    Total shards: 133
    Total runtime: 9:29:09.324000
     
  120. ( 457 ms ) process_dumps
  121. ( 5 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-c-wl5t" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544121031529731, "id": "8927865461202108144", "project": "chromium", "tags": ["builder:Win10 Tests x64", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/cc4b7196ecbd35a92870ed88bb47b4cd658aff4f", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder", "parent_buildnumber:59290", "scheduler_invocation_id:9093295523367456304", "scheduler_job_id:chromium/Win10 Tests x64", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 Tests x64" setup_build
buildnumber 29884 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder" setup_build
parent_got_angle_revision "d300548fcc2858fab34b7a744a000c48be845d06" setup_build
parent_got_buildtools_revision "04161ec8d7c781e4498c699254c69ba0dd959fde" setup_build
parent_got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" setup_build
parent_got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" setup_build
parent_got_revision "cc4b7196ecbd35a92870ed88bb47b4cd658aff4f" setup_build
parent_got_revision_cp "refs/heads/master@{#614392}" setup_build
parent_got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" setup_build
parent_got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" setup_build
parent_got_v8_revision_cp "refs/heads/7.3.39@{#1}" setup_build
parent_got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25919}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "cc4b7196ecbd35a92870ed88bb47b4cd658aff4f" setup_build
swarm_hashes {"accessibility_unittests": "b2f70edb1d2495ac675ab772be4c597a10a21fc5", "angle_unittests": "bf85e256c1bbfaa54d062a874e12ece5383f1183", "app_shell_unittests": "a824d862f816a9e37d22599252138659cea9661b", "aura_unittests": "e34858de74f394f6d857aff93eae15a0eb9fe75f", "base_unittests": "f7dcabd6412273c0fb80729da19bb03ebaac6124", "blink_common_unittests": "0721186b6c8cef47a2f8ac7156053094dcc5ddbc", "blink_fuzzer_unittests": "852a9ae86e9347189d2c6af12c9871fe89ded2c2", "blink_heap_unittests": "f2516e9a59bb5ca8a2e5d7463a7850f95a15654b", "blink_platform_unittests": "6bc39c7edf3dbfdd118407ac13fdcb3bd21de9a4", "boringssl_crypto_tests": "4128a666b494fe5fce5fb841e287e166fd987f7c", "boringssl_ssl_tests": "07f1ba6a2dde2a08bef7074756761f6105658464", "browser_tests": "33b6e7fc448db4a6719d1ae3cca68721096ffa5b", "cacheinvalidation_unittests": "10bad7ee8955bd0a098cdacca7cb7885c97146e8", "capture_unittests": "6c00371482c647067cbcea35728258d4fde08a89", "cast_unittests": "e63f05ed2d4462a96328b60d3bd969c97533feac", "cc_unittests": "710ba2dd845f153602ba3dc341eaf41427b48894", "chrome_app_unittests": "19e1dc1177d129e00b8abc8e87d42e76103bde14", "chrome_cleaner_unittests": "6b5d4db7c0474bc6f6a0301129a4ee41d1180496", "chrome_elf_import_unittests": "899c0a004839e5d6177d0ae2ce07a3ed9fb47b6b", "chrome_elf_unittests": "712d53bc57c9fbeacc84844887864624a8ba5d0d", "chromedriver_py_tests": "448e5d5f801e050ce8b38ed058669c8149488895", "chromedriver_replay_unittests": "5a53d4122909b4d13562b3f825fa3c5baf686c91", "chromedriver_unittests": "f8e2d415e6f650cedd280207056e1a14674e86a5", "components_browsertests": "34c21607384cbfe594844bc0ffc14aebcfefbccd", "components_perftests": "4448e7591223d506a85c2c16c6f99dbec2d82757", "components_unittests": "daa5ef756792765c42643e16d9a43d42bde60d55", "compositor_unittests": "d417e2d6a04c0b9b87c58cc99cd17b7e6a9d5bbb", "content_browsertests": "b87e70d1d6826830b6a3938c3a10bd72061db327", "content_shell_crash_test": "990965f5e63f7cee436a28aeeb3f4239882363d4", "content_unittests": "99b480df5679a26fb0e7f9c2d1c758fc52f14958", "courgette_unittests": "f5648b8de27eebaa19b972794bb02edc126d344b", "crashpad_tests": "fb026ee1b6ff2e551265f6d3a7c6d537f89e77e8", "cronet_tests": "7c48e6be85f47b6c4899abec0688b7927b520d93", "cronet_unittests": "c10381a9b95ec26471e34672bd2a8fc93d9045b9", "crypto_unittests": "9a5f48164858d5a521f9f88c26dbd2df4cac085b", "device_unittests": "6ff9fb69bf58c30c071bb24cc8b9379f0f17a01b", "display_unittests": "1a6a5cba46c8037b28db9aa84cb3c15bb28491c4", "elevation_service_unittests": "c82d7f09cbe2d8558e7dcee2fabba095e970cd4c", "events_unittests": "fa07246d9c53b47dfe659afb8bac50000727f9e1", "extensions_browsertests": "95b75ff9a58b34c8c2eca1d3e5459643cf57c761", "extensions_unittests": "aab73ca9c968167e3dc185577c7a62c5fcd33c7e", "filesystem_service_unittests": "e434314d795fcaf7903c6fd52cf5c77516b4ec08", "gcm_unit_tests": "1f90d5ae8891c23de537f2ef86721358c4541585", "gcp_unittests": "3494e7cade15a71a7461f85c156155c77fe44394", "gfx_unittests": "751ca18cf023e74468866584364fd5d55094b18b", "gin_unittests": "6af192d8ae86afdfd479844612135ba06af5c62b", "google_apis_unittests": "25263f30f1271624bccd6bac4a0ec9795cd3c309", "gpu_unittests": "35f3e0ad2b696f92af0ad115fdeb6b922cc46fc3", "headless_browsertests": "386b984a80b5d2904cf6cbea646a2824c0095181", "headless_unittests": "31e9851da93ca3dad14007176b122b889d000890", "install_static_unittests": "973117b455353ffb387f69294de2164b180a38d6", "installer_util_unittests": "a1a797ec92981af69c9be994fc8a2eb74ca5d727", "interactive_ui_tests": "d04e2d1253d5175916bed3e1410d38020bdc74ce", "ipc_tests": "b2fc8872097a19f8123f5c1db8a2dc60b36a0aec", "jingle_unittests": "5cee19be819bdcba7bd736a7cb00d61b740cfc00", "latency_unittests": "5388bec62e2c05b59ed377ef823886b8c3cbe8b0", "leveldb_service_unittests": "fae3cb9541379bad997f336ed206948acd1f3cb6", "libjingle_xmpp_unittests": "c2c2fe5db90a165cdfcdf1dc069be9535f88fdee", "media_blink_unittests": "94ca0610860a6b83fecb728cca5a294877b44edc", "media_service_unittests": "60b7cc8c57f96b3da97526d535eb49fa049df17a", "media_unittests": "6abc3cd29ca9be91171904034e96a0e057af3af9", "message_center_unittests": "4d7bf4570eb1702dfde4c34808d418931e052e2c", "metrics_python_tests": "b79d12d86ebc6d7c78cb4db38818431c5eae0a37", "midi_unittests": "268003b13e43fe4c734ae69addca975afdfb775f", "mini_installer_tests": "9286e45192613b480631103eb222f7011d572279", "mojo_core_unittests": "6df12c4101af79ad442879966da29ec291fcae29", "mojo_unittests": "776e4934b9166c416b1463709148c22f54dcc2a9", "nacl_loader_unittests": "563744629a05cb4ab453d4680624936fb7d1c34b", "native_theme_unittests": "e08c815240ab89d3137f206225ade4309d870180", "net_unittests": "9a6453e3d6f25e4fb1655145709973b24b2631a4", "notification_helper_unittests": "18782e5bddb692a7711a05e86187c9d08b8e69c8", "pdf_unittests": "ed99af0b62bee8e6dc8c59e1bea0b3bd1721d0c2", "ppapi_unittests": "627cdfaaaeca92ca167e8641e7bb2975734500dd", "printing_unittests": "abc408ab76285d50d0436cb71a31107db3db20f5", "remoting_unittests": "0c90dc46666a8c90b05f753f95b54eabd6df0f41", "sbox_integration_tests": "7db0093385e06bc884abe33c1768b5daee364ee1", "sbox_unittests": "39cda70ad96310390c4faa91be190bc138a0ceb6", "sbox_validation_tests": "ce8a64a3d593b217a3e5a1483ec4a50331a1ceda", "service_manager_unittests": "42fe45b7197e3299eeb272f6e903493222453057", "services_unittests": "ffb42543f7fbf7c8df0f35bd329469f5330098e0", "setup_unittests": "3c99d3886dfc81c5538c8ffa89534d9534eba008", "shell_dialogs_unittests": "0e5091e575d0dec9675c4cf88ca21161334ddeb1", "skia_unittests": "e1982b53ba22aa4fcd69c26019f986bfb210bdf3", "snapshot_unittests": "7e0aeb78b11f5e6fdfc397812a7fd20fdc469ff6", "sql_unittests": "7bd4e70c4b5c70a27e0de9df7c61d32d1cbaafbd", "storage_unittests": "8fefd1402123e75c84c0184449f1f77380451dfd", "sync_integration_tests": "f64a529987f72647f9bb8a4ccbcb65e2b5d161a1", "telemetry_gpu_unittests": "c61256922d522c59bcc6e1a83c6ea1a033c2db04", "telemetry_perf_unittests": "c0731d1053301f123cfe279f7d92fbdf1b8ba95e", "telemetry_unittests": "e6b2991ee87f8a92fc3c4c83d3901b1303af10f3", "traffic_annotation_auditor_unittests": "7a6087a089e5b9977a36d5257ea8c78b58f100a0", "ui_base_unittests": "6e9bdf3540f70153e46d29f6ff6428df90e07e04", "ui_touch_selection_unittests": "5a79ce001b750299c72033d6738bba7f0af141db", "unit_tests": "23678f38d5be9125d02d68e30b09b938399dec5d", "url_unittests": "e9379bfb13bc17d807d6475255ba3fa576dea1f0", "views_perftests": "216812ac6e99922e9de6188a6cfed9efb6ef57c5", "views_unittests": "548d91daa7c026eeb4a26ff300008a6fe27616a0", "viz_unittests": "5a00c36a8996f98fd57bf31c51742c210d687364", "vr_common_unittests": "b01739a537ee16322f36e5c31eca80e0f4bf8370", "vr_pixeltests": "38e3dc94f17e0bbd6ce15b23fa02cee5a1051a17", "webkit_python_tests": "fdf9d4afeaa39f3a6e786223836e8eba2522bd1b", "webkit_unit_tests": "670985140ae37838916769559ce8c659868abe38", "wm_unittests": "9432d041c303f94c17cbc09281a05d5dfa191081", "wtf_unittests": "416fca307b009d85b1ebc4d7481e742e3b718ec1", "zucchini_unittests": "1c959ba56d0b45c826d58979cc069de71948cdca"} setup_build
got_angle_revision "d300548fcc2858fab34b7a744a000c48be845d06" bot_update
got_buildtools_revision "04161ec8d7c781e4498c699254c69ba0dd959fde" bot_update
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "cc4b7196ecbd35a92870ed88bb47b4cd658aff4f" bot_update
got_revision_cp "refs/heads/master@{#614392}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "f5137533bdfac762e980b17eb7b4a2433dd07d1d" bot_update
got_v8_revision_cp "refs/heads/7.3.39@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes {"accessibility_unittests": "b2f70edb1d2495ac675ab772be4c597a10a21fc5", "angle_unittests": "bf85e256c1bbfaa54d062a874e12ece5383f1183", "app_shell_unittests": "a824d862f816a9e37d22599252138659cea9661b", "aura_unittests": "e34858de74f394f6d857aff93eae15a0eb9fe75f", "base_unittests": "f7dcabd6412273c0fb80729da19bb03ebaac6124", "blink_common_unittests": "0721186b6c8cef47a2f8ac7156053094dcc5ddbc", "blink_fuzzer_unittests": "852a9ae86e9347189d2c6af12c9871fe89ded2c2", "blink_heap_unittests": "f2516e9a59bb5ca8a2e5d7463a7850f95a15654b", "blink_platform_unittests": "6bc39c7edf3dbfdd118407ac13fdcb3bd21de9a4", "boringssl_crypto_tests": "4128a666b494fe5fce5fb841e287e166fd987f7c", "boringssl_ssl_tests": "07f1ba6a2dde2a08bef7074756761f6105658464", "browser_tests": "33b6e7fc448db4a6719d1ae3cca68721096ffa5b", "cacheinvalidation_unittests": "10bad7ee8955bd0a098cdacca7cb7885c97146e8", "capture_unittests": "6c00371482c647067cbcea35728258d4fde08a89", "cast_unittests": "e63f05ed2d4462a96328b60d3bd969c97533feac", "cc_unittests": "710ba2dd845f153602ba3dc341eaf41427b48894", "chrome_app_unittests": "19e1dc1177d129e00b8abc8e87d42e76103bde14", "chrome_cleaner_unittests": "6b5d4db7c0474bc6f6a0301129a4ee41d1180496", "chrome_elf_import_unittests": "899c0a004839e5d6177d0ae2ce07a3ed9fb47b6b", "chrome_elf_unittests": "712d53bc57c9fbeacc84844887864624a8ba5d0d", "chromedriver_py_tests": "448e5d5f801e050ce8b38ed058669c8149488895", "chromedriver_replay_unittests": "5a53d4122909b4d13562b3f825fa3c5baf686c91", "chromedriver_unittests": "f8e2d415e6f650cedd280207056e1a14674e86a5", "components_browsertests": "34c21607384cbfe594844bc0ffc14aebcfefbccd", "components_perftests": "4448e7591223d506a85c2c16c6f99dbec2d82757", "components_unittests": "daa5ef756792765c42643e16d9a43d42bde60d55", "compositor_unittests": "d417e2d6a04c0b9b87c58cc99cd17b7e6a9d5bbb", "content_browsertests": "b87e70d1d6826830b6a3938c3a10bd72061db327", "content_shell_crash_test": "990965f5e63f7cee436a28aeeb3f4239882363d4", "content_unittests": "99b480df5679a26fb0e7f9c2d1c758fc52f14958", "courgette_unittests": "f5648b8de27eebaa19b972794bb02edc126d344b", "crashpad_tests": "fb026ee1b6ff2e551265f6d3a7c6d537f89e77e8", "cronet_tests": "7c48e6be85f47b6c4899abec0688b7927b520d93", "cronet_unittests": "c10381a9b95ec26471e34672bd2a8fc93d9045b9", "crypto_unittests": "9a5f48164858d5a521f9f88c26dbd2df4cac085b", "device_unittests": "6ff9fb69bf58c30c071bb24cc8b9379f0f17a01b", "display_unittests": "1a6a5cba46c8037b28db9aa84cb3c15bb28491c4", "elevation_service_unittests": "c82d7f09cbe2d8558e7dcee2fabba095e970cd4c", "events_unittests": "fa07246d9c53b47dfe659afb8bac50000727f9e1", "extensions_browsertests": "95b75ff9a58b34c8c2eca1d3e5459643cf57c761", "extensions_unittests": "aab73ca9c968167e3dc185577c7a62c5fcd33c7e", "filesystem_service_unittests": "e434314d795fcaf7903c6fd52cf5c77516b4ec08", "gcm_unit_tests": "1f90d5ae8891c23de537f2ef86721358c4541585", "gcp_unittests": "3494e7cade15a71a7461f85c156155c77fe44394", "gfx_unittests": "751ca18cf023e74468866584364fd5d55094b18b", "gin_unittests": "6af192d8ae86afdfd479844612135ba06af5c62b", "google_apis_unittests": "25263f30f1271624bccd6bac4a0ec9795cd3c309", "gpu_unittests": "35f3e0ad2b696f92af0ad115fdeb6b922cc46fc3", "headless_browsertests": "386b984a80b5d2904cf6cbea646a2824c0095181", "headless_unittests": "31e9851da93ca3dad14007176b122b889d000890", "install_static_unittests": "973117b455353ffb387f69294de2164b180a38d6", "installer_util_unittests": "a1a797ec92981af69c9be994fc8a2eb74ca5d727", "interactive_ui_tests": "d04e2d1253d5175916bed3e1410d38020bdc74ce", "ipc_tests": "b2fc8872097a19f8123f5c1db8a2dc60b36a0aec", "jingle_unittests": "5cee19be819bdcba7bd736a7cb00d61b740cfc00", "latency_unittests": "5388bec62e2c05b59ed377ef823886b8c3cbe8b0", "leveldb_service_unittests": "fae3cb9541379bad997f336ed206948acd1f3cb6", "libjingle_xmpp_unittests": "c2c2fe5db90a165cdfcdf1dc069be9535f88fdee", "media_blink_unittests": "94ca0610860a6b83fecb728cca5a294877b44edc", "media_service_unittests": "60b7cc8c57f96b3da97526d535eb49fa049df17a", "media_unittests": "6abc3cd29ca9be91171904034e96a0e057af3af9", "message_center_unittests": "4d7bf4570eb1702dfde4c34808d418931e052e2c", "metrics_python_tests": "b79d12d86ebc6d7c78cb4db38818431c5eae0a37", "midi_unittests": "268003b13e43fe4c734ae69addca975afdfb775f", "mini_installer_tests": "9286e45192613b480631103eb222f7011d572279", "mojo_core_unittests": "6df12c4101af79ad442879966da29ec291fcae29", "mojo_unittests": "776e4934b9166c416b1463709148c22f54dcc2a9", "nacl_loader_unittests": "563744629a05cb4ab453d4680624936fb7d1c34b", "native_theme_unittests": "e08c815240ab89d3137f206225ade4309d870180", "net_unittests": "9a6453e3d6f25e4fb1655145709973b24b2631a4", "notification_helper_unittests": "18782e5bddb692a7711a05e86187c9d08b8e69c8", "pdf_unittests": "ed99af0b62bee8e6dc8c59e1bea0b3bd1721d0c2", "ppapi_unittests": "627cdfaaaeca92ca167e8641e7bb2975734500dd", "printing_unittests": "abc408ab76285d50d0436cb71a31107db3db20f5", "remoting_unittests": "0c90dc46666a8c90b05f753f95b54eabd6df0f41", "sbox_integration_tests": "7db0093385e06bc884abe33c1768b5daee364ee1", "sbox_unittests": "39cda70ad96310390c4faa91be190bc138a0ceb6", "sbox_validation_tests": "ce8a64a3d593b217a3e5a1483ec4a50331a1ceda", "service_manager_unittests": "42fe45b7197e3299eeb272f6e903493222453057", "services_unittests": "ffb42543f7fbf7c8df0f35bd329469f5330098e0", "setup_unittests": "3c99d3886dfc81c5538c8ffa89534d9534eba008", "shell_dialogs_unittests": "0e5091e575d0dec9675c4cf88ca21161334ddeb1", "skia_unittests": "e1982b53ba22aa4fcd69c26019f986bfb210bdf3", "snapshot_unittests": "7e0aeb78b11f5e6fdfc397812a7fd20fdc469ff6", "sql_unittests": "7bd4e70c4b5c70a27e0de9df7c61d32d1cbaafbd", "storage_unittests": "8fefd1402123e75c84c0184449f1f77380451dfd", "sync_integration_tests": "f64a529987f72647f9bb8a4ccbcb65e2b5d161a1", "telemetry_gpu_unittests": "c61256922d522c59bcc6e1a83c6ea1a033c2db04", "telemetry_perf_unittests": "c0731d1053301f123cfe279f7d92fbdf1b8ba95e", "telemetry_unittests": "e6b2991ee87f8a92fc3c4c83d3901b1303af10f3", "traffic_annotation_auditor_unittests": "7a6087a089e5b9977a36d5257ea8c78b58f100a0", "ui_base_unittests": "6e9bdf3540f70153e46d29f6ff6428df90e07e04", "ui_touch_selection_unittests": "5a79ce001b750299c72033d6738bba7f0af141db", "unit_tests": "23678f38d5be9125d02d68e30b09b938399dec5d", "url_unittests": "e9379bfb13bc17d807d6475255ba3fa576dea1f0", "views_perftests": "216812ac6e99922e9de6188a6cfed9efb6ef57c5", "views_unittests": "548d91daa7c026eeb4a26ff300008a6fe27616a0", "viz_unittests": "5a00c36a8996f98fd57bf31c51742c210d687364", "vr_common_unittests": "b01739a537ee16322f36e5c31eca80e0f4bf8370", "vr_pixeltests": "38e3dc94f17e0bbd6ce15b23fa02cee5a1051a17", "webkit_python_tests": "fdf9d4afeaa39f3a6e786223836e8eba2522bd1b", "webkit_unit_tests": "670985140ae37838916769559ce8c659868abe38", "wm_unittests": "9432d041c303f94c17cbc09281a05d5dfa191081", "wtf_unittests": "416fca307b009d85b1ebc4d7481e742e3b718ec1", "zucchini_unittests": "1c959ba56d0b45c826d58979cc069de71948cdca"} find isolated tests

Blamelist:

  1. Xida Chen (xidachenohnoyoudont@chromium.org)
  2. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  3. Roger McFarlane (rogermohnoyoudont@chromium.org)
  4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  5. Carlos Caballero (carlscabohnoyoudont@google.com)
  6. Dan Harrington (harringtondohnoyoudont@chromium.org)
  7. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  8. Anthony Vallee-Dubois (anthonyvdohnoyoudont@chromium.org)
  9. Clemens Arbesser (arbesserohnoyoudont@google.com)

Timing:

Create Thursday, 06-Dec-18 18:30:31 UTC
Start Thursday, 06-Dec-18 18:31:10 UTC
End Thursday, 06-Dec-18 19:01:19 UTC
Pending 39 secs
Execution 30 mins 8 secs

All Changes:

  1. [BrowserTest] Deflake TouchActionBrowserTest

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:12:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc4b7196ecbd35a92870ed88bb47b4cd658aff4f

    Comments

    [BrowserTest] Deflake TouchActionBrowserTest
    
    In these browser tests, we inject a synthetic gesture scroll, and jank
    the main thread sometimes, and then check the scroll offset by
    executing:
    "document.scrollingElement.scrollTop" and ".scrollLeft"
    
    From the resut when it is flaky, it seems that even though the
    compositor frame's metadata shows that the scroll offset is >=
    half of the expected scroll offset, the main thread's scroll offset
    might still smaller than half of the expected scroll offset.
    
    This CL makes change to just check that it actually scrolled on the
    expected axis (from the main thread), instead of checking the scroll
    offset.
    
    Bug: 876323
    Change-Id: Ieee6f44304c67e8db89bc4e899ae8e69e8416f33
    Reviewed-on: https://chromium-review.googlesource.com/c/1363863
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614392}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  2. Address race between device notifications and enumerations in AudioDeviceListenerMac

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:12:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01694e809e567530443ffb8687fd5f3956f79c0f

    Comments

    Address race between device notifications and enumerations in AudioDeviceListenerMac
    
    Originally AudioDeviceListenerMac assumed that once CoreAudio reports that a device does not exist,
    it was no longer possible to get notifications related to that device, so it was safe to remove
    the listener for that device.
    However, since notifications can come from multiple threads and the corresponding callbacks make
    a thread jump, we have observed that it is indeed possible to get notifications about removed devices
    which can lead to a crash if the listener for that notification has been removed.
    To address this issue, this CL does not remove listeners when the device is removed, but instead
    marks the listener as deleted and posts a task to remove listeners that have been marked as deleted
    for several seconds, at a time when we can confidently no longer expect notifications from the removed device.
    
    Bug: 911311
    Change-Id: I07cc9c8e24a0cfdfadcc04d0e8bd33e14ab61422
    Reviewed-on: https://chromium-review.googlesource.com/c/1363187
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Reviewed-by: Oskar Sundbom <ossu@chromium.org>
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614391}

    Changed files

    • media/audio/mac/audio_device_listener_mac.cc
    • media/audio/mac/audio_device_listener_mac.h
  3. [sheriff] Update TestExpectations for flaky layout test

    Changed by Roger McFarlane - rogermohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 17:10:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f668bb5e368b109bd420c2525055ffbd6de3f064

    Comments

    [sheriff] Update TestExpectations for flaky layout test
    
    compositing/visibility/overlays-persist-on-navigation.html
    
    TBR: jyasskin@chromium.org
    Bug: 912570
    Change-Id: Iab922b37a9081c3b0a83490e738bda1d03cf24d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365715
    Commit-Queue: Roger McFarlane <rogerm@chromium.org>
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614390}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  4. Roll src/third_party/depot_tools 2e00228777c0..f94f910e9a1f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 17:09:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c8d5c3b4617238d24caa5e87093bc9e80148b6e

    Comments

    Roll src/third_party/depot_tools 2e00228777c0..f94f910e9a1f (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e00228777c0..f94f910e9a1f
    
    
    git log 2e00228777c0..f94f910e9a1f --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 tikuta@chromium.org [ninjalog] disable log upload
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@f94f910e9a1f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:900161
    TBR=agable@chromium.org
    
    Change-Id: Id3ec9912b3cfeaff57a05c560c43f6945ba75dda
    Reviewed-on: https://chromium-review.googlesource.com/c/1365429
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614389}

    Changed files

    • DEPS
  5. [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in ssl_errors

    Changed by Carlos Caballero - carlscabohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 17:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e29ed936c19b696b115972f7016aefc417edb55

    Comments

    [scheduling] Use ScopedTaskEnvironment instead of MessageLoop in ssl_errors
    
    MessageLoop will go away, eventually.
    
    BUG=891670
    
    Change-Id: I297de47c1dd4d2a58276c136d8b48216ed4fd769
    Reviewed-on: https://chromium-review.googlesource.com/c/1353889
    Reviewed-by: Carlos IL <carlosil@chromium.org>
    Commit-Queue: Carlos Caballero <carlscab@google.com>
    Cr-Commit-Position: refs/heads/master@{#614388}

    Changed files

    • components/ssl_errors/error_classification_unittest.cc
  6. remove static destructable variables from add_unique_urls_task_unittest.cc

    Changed by Dan Harrington - harringtondohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:55:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e45074e7d2cef61213347c47fa6657c2b5904fa4

    Comments

    remove static destructable variables from add_unique_urls_task_unittest.cc
    
    Also updated a comment as suggested in a previous code review.
    
    Change-Id: If59276e9261ac2ba82ece5086798f34933df5040
    Reviewed-on: https://chromium-review.googlesource.com/c/1362473
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Commit-Queue: Dan H <harringtond@google.com>
    Cr-Commit-Position: refs/heads/master@{#614387}

    Changed files

    • components/offline_pages/core/prefetch/prefetch_item.h
    • components/offline_pages/core/prefetch/tasks/add_unique_urls_task_unittest.cc
  7. passwords: don't eat space KeyPressed on Mac

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:54:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 848e9aed3705fe5ca9392b26f90caf4221c96850

    Comments

    passwords: don't eat space KeyPressed on Mac
    
    On Mac, KeyPressed is what activates buttons, not KeyReleased, so eating
    KeyPressed breaks this button.
    
    Bug: 910070
    Change-Id: I4776bc3b14ac52879ad96c20d55f93126ba349d7
    Reviewed-on: https://chromium-review.googlesource.com/c/1361627
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614386}

    Changed files

    • chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc
    • chrome/browser/ui/views/passwords/manage_passwords_icon_views.h
  8. Remove iOS Translate Event Logging in Sync

    Changed by Anthony Vallee-Dubois - anthonyvdohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 16:54:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 375260f7da26d6910344c5904c849b916ff217c8

    Comments

    Remove iOS Translate Event Logging in Sync
    
    The feature is disabled by default, no config currently applies, and it
    was decided to stop collecting these events. This removes the iOS
    portion of the code because it allows removing a translate -> sync
    dependency that was preventing another change from landing.
    
    Bug: 896719,911781
    Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99
    Reviewed-on: https://chromium-review.googlesource.com/c/1361927
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: anthonyvd <anthonyvd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614385}

    Changed files

    • ios/chrome/browser/translate/BUILD.gn
    • ios/chrome/browser/translate/chrome_ios_translate_client.mm
  9. [Autofill Assistant] Onboarding buttons are now aligned with the Terms&Conditions box.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 16:53:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8e849191083c16cb2b18e3d219fbe008741c26d

    Comments

    [Autofill Assistant] Onboarding buttons are now aligned with the Terms&Conditions box.
    
    Before: https://screenshot.googleplex.com/ESkLNquDXJd.png
    After: https://screenshot.googleplex.com/tEssthOhzV9.png
    
    Bug: 806868
    Change-Id: I628e6aaa3bf11f453096c80dfc05266393db6ede
    Reviewed-on: https://chromium-review.googlesource.com/c/1365435
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#614384}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/init_screen.xml