Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 Build 29442 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision364c9149aef574f6fe179b8c47266ff4e9548163
Got Revision364c9149aef574f6fe179b8c47266ff4e9548163

Execution:

Steps and Logfiles:

Show:
  1. ( 590 ms ) setup_build
    running recipe: "chromium"
  2. ( 227 ms ) report builders
     
    running tester 'Win10 Tests x64' on master 'chromium.win'
  3. ( 5 secs ) taskkill
  4. ( 1 mins 16 secs ) bot_update
    [65GB/299GB used (21%)]
  5. ( 638 ms ) swarming.py --version
    0.13
  6. ( 19 secs ) gclient runhooks
  7. ( 2 secs ) get compile targets for scripts
  8. ( 634 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  9. ( 474 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  10. ( 3 secs ) build directory
  11. ( 2 mins 28 secs ) extract build
  12. ( 203 ms ) explain extract build
  13. ( 492 ms ) find isolated tests
  14. ( 1 mins 37 secs ) test_installer
  15. ( 2 secs ) wait for tasks
  16. ( 2 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  17. ( 1 secs ) Upload to test-results [cacheinvalidation_unittests on Windows-10-15063]
  18. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  19. ( 2 secs ) Upload to test-results [accessibility_unittests on Windows-10-15063]
  20. ( 2 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  21. ( 2 secs ) Upload to test-results [courgette_unittests on Windows-10-15063]
  22. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 12s
  23. ( 2 secs ) Upload to test-results [display_unittests on Windows-10-15063]
  24. ( 2 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  25. ( 2 secs ) Upload to test-results [printing_unittests on Windows-10-15063]
  26. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  27. ( 4 secs ) Upload to test-results [ui_touch_selection_unittests on Windows-10-15063]
  28. ( 2 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  29. ( 4 secs ) Upload to test-results [elevation_service_unittests on Windows-10-15063]
  30. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  31. ( 1 secs ) Upload to test-results [chromedriver_unittests on Windows-10-15063]
  32. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:07:49.019813
  33. ( 2 secs ) Upload to test-results [remoting_unittests on Windows-10-15063]
  34. ( 4 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:02.987842
  35. ( 8 secs ) Upload to test-results [content_unittests on Windows-10-15063]
  36. ( 2 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  37. ( 2 secs ) Upload to test-results [cast_unittests on Windows-10-15063]
  38. ( 2 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  39. ( 2 secs ) Upload to test-results [crashpad_tests on Windows-10-15063]
  40. ( 2 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  41. ( 1 secs ) Upload to test-results [crypto_unittests on Windows-10-15063]
  42. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  43. ( 3 secs ) Upload to test-results [storage_unittests on Windows-10-15063]
  44. ( 2 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  45. ( 3 secs ) Upload to test-results [url_unittests on Windows-10-15063]
  46. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  47. ( 2 secs ) Upload to test-results [device_unittests on Windows-10-15063]
  48. ( 2 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  49. ( 2 secs ) Upload to test-results [gin_unittests on Windows-10-15063]
  50. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  51. ( 1 secs ) Upload to test-results [nacl_loader_unittests on Windows-10-15063]
  52. ( 4 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:03.376886
  53. ( 14 secs ) Upload to test-results [angle_unittests on Windows-10-15063]
  54. ( 2 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  55. ( 1 secs ) Upload to test-results [wtf_unittests on Windows-10-15063]
  56. ( 2 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  57. ( 2 secs ) Upload to test-results [jingle_unittests on Windows-10-15063]
  58. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  59. ( 1 secs ) Upload to test-results [midi_unittests on Windows-10-15063]
  60. ( 2 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  61. ( 2 secs ) Upload to test-results [libjingle_xmpp_unittests on Windows-10-15063]
  62. ( 2 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  63. ( 1 secs ) Upload to test-results [ppapi_unittests on Windows-10-15063]
  64. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  65. ( 1 secs ) Upload to test-results [vr_pixeltests on Windows-10-15063]
  66. ( 2 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  67. ( 1 secs ) Upload to test-results [installer_util_unittests on Windows-10-15063]
  68. ( 14 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:14.787450
  69. ( 34 secs ) Upload to test-results [net_unittests on Windows-10-15063]
  70. ( 2 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  71. ( 9 secs ) Upload to test-results [skia_unittests on Windows-10-15063]
  72. ( 2 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  73. ( 2 secs ) Upload to test-results [setup_unittests on Windows-10-15063]
  74. ( 2 secs ) webui_polymer2_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:53.226586
  75. ( 1 secs ) Upload to test-results [webui_polymer2_interactive_ui_tests on Windows-10-15063]
  76. ( 2 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  77. ( 1 secs ) Upload to test-results [wm_unittests on Windows-10-15063]
  78. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  79. ( 1 secs ) Upload to test-results [ui_base_unittests on Windows-10-15063]
  80. ( 4 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 56s
  81. ( 5 secs ) Upload to test-results [services_unittests on Windows-10-15063]
  82. ( 2 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  83. ( 2 secs ) Upload to test-results [headless_unittests on Windows-10-15063]
  84. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  85. ( 1 secs ) Upload to test-results [cronet_unittests on Windows-10-15063]
  86. ( 2 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  87. ( 6 secs ) Upload to test-results [native_theme_unittests on Windows-10-15063]
  88. ( 3 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  89. ( 6 secs ) Upload to test-results [media_unittests on Windows-10-15063]
  90. ( 2 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  91. ( 2 secs ) Upload to test-results [service_manager_unittests on Windows-10-15063]
  92. ( 2 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  93. ( 1 secs ) Upload to test-results [blink_fuzzer_unittests on Windows-10-15063]
  94. ( 3 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  95. ( 3 secs ) Upload to test-results [media_blink_unittests on Windows-10-15063]
  96. ( 3 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  97. ( 8 secs ) Upload to test-results [gpu_unittests on Windows-10-15063]
  98. ( 2 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  99. ( 19 secs ) Upload to test-results [chrome_elf_import_unittests on Windows-10-15063]
  100. ( 2 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  101. ( 2 secs ) Upload to test-results [boringssl_crypto_tests on Windows-10-15063]
  102. ( 2 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  103. ( 3 secs ) Upload to test-results [google_apis_unittests on Windows-10-15063]
  104. ( 2 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  105. ( 2 secs ) Upload to test-results [snapshot_unittests on Windows-10-15063]
  106. ( 2 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  107. ( 1 secs ) Upload to test-results [media_service_unittests on Windows-10-15063]
  108. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  109. ( 9 secs ) Upload to test-results [events_unittests on Windows-10-15063]
  110. ( 2 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  111. ( 1 secs ) Upload to test-results [cronet_tests on Windows-10-15063]
  112. ( 2 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  113. ( 1 secs ) Upload to test-results [ipc_tests on Windows-10-15063]
  114. ( 2 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  115. ( 2 secs ) Upload to test-results [sbox_unittests on Windows-10-15063]
  116. ( 2 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  117. ( 1 secs ) Upload to test-results [mojo_core_unittests on Windows-10-15063]
  118. ( 2 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  119. ( 1 secs ) Upload to test-results [install_static_unittests on Windows-10-15063]
  120. ( 2 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  121. ( 1 secs ) Upload to test-results [sbox_validation_tests on Windows-10-15063]
  122. ( 2 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  123. ( 2 secs ) Upload to test-results [mojo_unittests on Windows-10-15063]
  124. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  125. ( 1 secs ) Upload to test-results [vr_common_unittests on Windows-10-15063]
  126. ( 3 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  127. ( 3 secs ) Upload to test-results [views_unittests on Windows-10-15063]
  128. ( 2 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  129. ( 2 secs ) Upload to test-results [sbox_integration_tests on Windows-10-15063]
  130. ( 3 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  131. ( 5 secs ) Upload to test-results [gfx_unittests on Windows-10-15063]
  132. ( 3 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  133. ( 4 secs ) Upload to test-results [blink_platform_unittests on Windows-10-15063]
  134. ( 2 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  135. ( 2 secs ) Upload to test-results [gcm_unit_tests on Windows-10-15063]
  136. ( 2 secs ) network_service_components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  137. ( 7 secs ) Upload to test-results [network_service_components_browsertests on Windows-10-15063]
  138. ( 2 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  139. ( 1 secs ) Upload to test-results [pdf_unittests on Windows-10-15063]
  140. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  141. ( 1 secs ) Upload to test-results [app_shell_unittests on Windows-10-15063]
  142. ( 2 secs ) network_service_extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:40.796325
  143. ( 1 secs ) Upload to test-results [network_service_extensions_browsertests on Windows-10-15063]
  144. ( 2 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  145. ( 1 secs ) Upload to test-results [traffic_annotation_auditor_unittests on Windows-10-15063]
  146. ( 2 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  147. ( 1 secs ) Upload to test-results [notification_helper_unittests on Windows-10-15063]
  148. ( 4 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:22.585691
  149. ( 5 secs ) Upload to test-results [cc_unittests on Windows-10-15063]
  150. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  151. ( 1 secs ) Upload to test-results [components_browsertests on Windows-10-15063]
  152. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  153. ( 1 secs ) Upload to test-results [blink_common_unittests on Windows-10-15063]
  154. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  155. ( 2 secs ) Upload to test-results [aura_unittests on Windows-10-15063]
  156. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  157. ( 1 secs ) Upload to test-results [blink_heap_unittests on Windows-10-15063]
  158. ( 2 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:34.116464
  159. ( 2 secs ) Upload to test-results [shell_dialogs_unittests on Windows-10-15063]
  160. ( 2 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:21.386522
  161. ( 3 secs ) Upload to test-results [extensions_browsertests on Windows-10-15063]
  162. ( 2 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  163. ( 1 secs ) Upload to test-results [leveldb_service_unittests on Windows-10-15063]
  164. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  165. ( 1 secs ) Upload to test-results [zucchini_unittests on Windows-10-15063]
  166. ( 2 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  167. ( 1 secs ) Upload to test-results [boringssl_ssl_tests on Windows-10-15063]
  168. ( 2 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  169. ( 1 secs ) Upload to test-results [message_center_unittests on Windows-10-15063]
  170. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  171. ( 2 secs ) Upload to test-results [chrome_cleaner_unittests on Windows-10-15063]
  172. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  173. ( 1 secs ) Upload to test-results [filesystem_service_unittests on Windows-10-15063]
  174. ( 2 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 42s
  175. ( 1 secs ) Upload to test-results [perfetto_content_browsertests on Windows-10-15063]
  176. ( 2 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  177. ( 1 secs ) Upload to test-results [latency_unittests on Windows-10-15063]
  178. ( 2 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  179. ( 4 secs ) Upload to test-results [extensions_unittests on Windows-10-15063]
  180. ( 2 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:03.465202
  181. ( 1 secs ) Upload to test-results [headless_browsertests on Windows-10-15063]
  182. ( 2 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  183. ( 3 secs ) Upload to test-results [chrome_app_unittests on Windows-10-15063]
  184. ( 2 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  185. ( 1 secs ) Upload to test-results [sql_unittests on Windows-10-15063]
  186. ( 2 secs ) gcp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  187. ( 1 secs ) Upload to test-results [gcp_unittests on Windows-10-15063]
  188. ( 4 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  189. ( 40 secs ) Upload to test-results [base_unittests on Windows-10-15063]
  190. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  191. ( 2 secs ) Upload to test-results [capture_unittests on Windows-10-15063]
  192. ( 2 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  193. ( 2 secs ) Upload to test-results [chrome_elf_unittests on Windows-10-15063]
  194. ( 2 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  195. ( 2 secs ) Upload to test-results [compositor_unittests on Windows-10-15063]
  196. ( 1 secs ) wait for tasks (2)
  197. ( 5 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:10.645521
  198. ( 13 secs ) Upload to test-results [webkit_unit_tests on Windows-10-15063]
  199. ( 4 secs ) interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:10:23.969282 (shard #2)
    Min shard duration: 0:08:22.403468 (shard #1)
  200. ( 4 secs ) Upload to test-results [interactive_ui_tests on Windows-10-15063]
  201. ( 5 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:23.789020
  202. ( 16 secs ) Upload to test-results [unit_tests on Windows-10-15063]
  203. ( 3 secs ) sync_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:09:18.997501
  204. ( 4 secs ) Upload to test-results [sync_integration_tests on Windows-10-15063]
  205. ( 2 secs ) mini_installer_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:04.819307
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  206. ( 2 secs ) Upload to test-results [mini_installer_tests]
  207. ( 4 secs ) network_service_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:11:46.236544 (shard #2)
    Min shard duration: 0:09:11.617675 (shard #1)
  208. ( 3 secs ) Upload to test-results [network_service_interactive_ui_tests on Windows-10-15063]
  209. ( 8 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:05:34.867132
  210. ( 18 secs ) Upload to test-results [components_unittests on Windows-10-15063]
  211. ( 3 secs ) network_service_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:12:05.839154 (shard #0)
    Min shard duration: 0:10:44.804826 (shard #1)
  212. ( 7 secs ) Upload to test-results [network_service_content_browsertests on Windows-10-15063]
  213. ( 3 secs ) webui_polymer2_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:05:58.768771 (shard #2)
    Min shard duration: 0:05:14.557543 (shard #3)
  214. ( 9 secs ) Upload to test-results [webui_polymer2_browser_tests on Windows-10-15063]
  215. ( 1 secs ) wait for tasks (3)
  216. ( 8 secs ) network_service_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:15:30.598605 (shard #8)
    Min shard duration: 0:12:39.157040 (shard #9)
  217. ( 45 secs ) Upload to test-results [network_service_browser_tests on Windows-10-15063]
  218. ( 2 mins 11 secs ) wait for tasks (4)
  219. ( 5 secs ) content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:18:33.181829
  220. ( 6 secs ) Upload to test-results [content_browsertests on Windows-10-15063]
  221. ( 1 mins 48 secs ) browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:21:24.122825 (shard #2)
    Min shard duration: 0:16:07.648347 (shard #4)
  222. ( 36 secs ) Upload to test-results [browser_tests on Windows-10-15063]
  223. ( 219 ms ) Tests statistics
     
    Stats
    Total shards: 133
    Total runtime: 9:12:00.828001
     
  224. ( 1 secs ) process_dumps
  225. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-c-wl5t" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542301983648122, "id": "8929772871152753248", "project": "chromium", "tags": ["builder:Win10 Tests x64", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/364c9149aef574f6fe179b8c47266ff4e9548163", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder", "parent_buildnumber:58809", "scheduler_invocation_id:9095202933284405344", "scheduler_job_id:chromium/Win10 Tests x64", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 Tests x64" setup_build
buildnumber 29442 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder" setup_build
parent_got_angle_revision "f3acb8c133fa825d5f25159eaf4ebf303bfef7a6" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "69b44ee6a1269afb5c7622189de236af0c4ec2a7" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "364c9149aef574f6fe179b8c47266ff4e9548163" setup_build
parent_got_revision_cp "refs/heads/master@{#608395}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "14d4267208e7ee70b79186955b9b1b8c0273f3ca" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.341@{#1}" setup_build
parent_got_webrtc_revision "a06bf8506fdfc0aff1098831bfc49bff4436399d" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25655}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "364c9149aef574f6fe179b8c47266ff4e9548163" setup_build
swarm_hashes {"accessibility_unittests": "a457663f7a7d448db5b9246c2c648207f055ad5a", "angle_unittests": "6599aa493f9830ba35a8b4a9f1d5b0061cedc6a1", "app_shell_unittests": "fff406b76de6b6ec35e913a6938e70f56e3f0f36", "aura_unittests": "d2f3e5f64a27119c7b09b9402700266583b3cce8", "base_unittests": "70f8cff5962121384ff1f4b1c033aced8dba002a", "blink_common_unittests": "c603d835006b371a4cb8713f19840ad742d95bb3", "blink_fuzzer_unittests": "fb116b5d650295e09bbdd0893b52e9d57656e388", "blink_heap_unittests": "d0fbc4ea5d8ceab8dd66d01a558a7a66043acd04", "blink_platform_unittests": "0b17a5d821316ca5d9f4f94899aa0a048addd808", "boringssl_crypto_tests": "469d6f7915033207e732219a235748e87f9c6811", "boringssl_ssl_tests": "2e1c97ead87792f1a0e004496bf3513ee3b827d8", "browser_tests": "461f56f02511a2a5bd2b8ed3e4087ae3488ce8ae", "cacheinvalidation_unittests": "ed5acb05aa5040c7965a210f8565663fdf08cfa0", "capture_unittests": "35ec15b7789c7ae0bec67f3b5b2cad6a882a521e", "cast_unittests": "38abc31cb2e8425363b5187195bf27ed5a21dac9", "cc_unittests": "bac54c9fd1c506ee61c3cf9449bd112e49338c74", "chrome_app_unittests": "2a5d89c2ad86af37cdf25d6c176e030b6faab7bb", "chrome_cleaner_unittests": "384c4afcabb6f93aaf886e30dd6c28ce326ed89d", "chrome_elf_import_unittests": "92016327b5bd8cbd80891dd4e33468b1c5bbaf3f", "chrome_elf_unittests": "ecebb077fd52c69e1d8ff19817781d39cd82ebe0", "chromedriver_py_tests": "6ea2fe234baaac1b9386c69429eaf043721c7dff", "chromedriver_replay_unittests": "608c0c89118b4704de3239f30dc69839a37605ef", "chromedriver_unittests": "ccb2bdd30630a3c775224718639433ceaa3ea494", "components_browsertests": "fcff43991031c90b9f8d2484867f37a30a2b7ad9", "components_perftests": "4c00c3b4350f1bf9a85a51827c6329b3dd5acf69", "components_unittests": "7b268c81a5e149162a1dff4f3f49ca700f0138b7", "compositor_unittests": "4ea2be30e87e2410310995f146dd8f09c01f9ce6", "content_browsertests": "412ee52c0da619671916fea617083d30a3d9fc1e", "content_shell_crash_test": "94165d8c616632f922af2c578f6020eb614e6da7", "content_unittests": "28ea23a22fdd0181bcca61f56184c7b878370c74", "courgette_unittests": "cab7642dd80ebb0d355e8f455e9f66f2f1459bd1", "crashpad_tests": "7a3e1fa9291794bb31e5764bc049b1bbbc519a92", "cronet_tests": "c4778a904eee1031cad95276e060798a72e6d41d", "cronet_unittests": "014594b42dbdbcba6235407d1270a4e45a1b75b8", "crypto_unittests": "dab4971d33a0d25779b0c3de2c4a1226180dbc01", "device_unittests": "2fe5f109a305823c900ce239d8a63b16128f28e3", "display_unittests": "b7f9cb347993dc4e8090249e7796db6a696f06e2", "elevation_service_unittests": "e4392a5b056ab152c5ab3b7a86c9633b8b6e2ef1", "events_unittests": "7c8ca4d11a50536249ac9ca7ece4e183929ba0b9", "extensions_browsertests": "040c3ff3870defce75d664630fe8394e71dac2ea", "extensions_unittests": "e09bc3c2ebdd10e929b24d6dde9427fbea575eac", "filesystem_service_unittests": "efe086edc4283af8030928ed8c02849432edb766", "gcm_unit_tests": "47c6fa71972bb18322aaef4fcf78a723fd638840", "gcp_unittests": "7b930012835c9b16b780516fdf8599de83a1ab2f", "gfx_unittests": "3238ebd5ea29f23c02ddb438a573af3233f83f74", "gin_unittests": "7b99f4de26e368d9068c3aa8e884da5efb95862d", "google_apis_unittests": "47f64b9385b398847c96f0425fe96b7d615f5f88", "gpu_unittests": "07ec4fd14676ab65fb5e3672839ea6c80534533f", "headless_browsertests": "4461e3787ced7c8186776a968ee53216e46032be", "headless_unittests": "f2be8cace3022b2bbce2d9f0b3564ec313922a78", "install_static_unittests": "e42bef873f612a33f1cf15fff8e8bbc560848ce3", "installer_util_unittests": "7af0c2b092f504eb0eadb71e6b207af24aff8843", "interactive_ui_tests": "7c22ff8f9f30087c3414deadcede602a86c177d4", "ipc_tests": "1c037794060a8f06caf5ac32665725017c7b9df2", "jingle_unittests": "8db7bf97a336e0001b66ed4523a1ab096bd1a120", "latency_unittests": "de6c2ec329ac385366a6b0811d90f62cf84cc723", "leveldb_service_unittests": "626da3c23a134e1e65f788778a4071a30dfd68f3", "libjingle_xmpp_unittests": "cb08b090a59b68f2f7afddad8fd3c142e59ab093", "media_blink_unittests": "fd6ba93dbc073a3a670330a450bec92fa21a27f0", "media_service_unittests": "387ff0fa63afed24ddd23cccdc3038ab9d2f9c3d", "media_unittests": "b0855067aad854bd2db8f1cbdc8f255b2d945235", "message_center_unittests": "63f2725f5b43b78c713d126625232f925156686d", "metrics_python_tests": "0aeb6201f6626ad16d6931a6376d63d6a9f0a254", "midi_unittests": "773c551ba69c0e3b89ac98ce5070a076d4c402a6", "mini_installer_tests": "56cb517e4d8b8c1e9a201fc82b630b7284494f68", "mojo_core_unittests": "061f80e67df02284c7a674868cddc180a978d4c6", "mojo_unittests": "8981aae02d7adff6c76bb5cf6201aa722702b9f3", "nacl_loader_unittests": "a96b17a370c3e309373479f987ba4312a8712d63", "native_theme_unittests": "3ec8d1db1a98774fc6fbba354b5011db4fa2db80", "net_unittests": "3ae754a649708f8bdfdbe865748d621878a57771", "notification_helper_unittests": "88f36f1792079d2b2c0363d3502894dfddaa3880", "pdf_unittests": "5fbeeb52b90207fa876ed6797405ba69c5385b5b", "ppapi_unittests": "30b81a8e2207ae28bbeab353d322da5cb38a5183", "printing_unittests": "668ece004b27dc7e628e49343e92a0a68296aa47", "remoting_unittests": "412f80ed78d8750fb495738a7bd03e0406fa22fe", "sbox_integration_tests": "a916a6cae3fb03ab3d0fbb20bf6df2c18ba4d669", "sbox_unittests": "02386457310da12833cf3c3d8edac1ac7f2a1bdf", "sbox_validation_tests": "3501c517bdb558ccb4eea45c2b902f7327a7b2d6", "service_manager_unittests": "54268181ce82e0851c12cb56ab6cdc6ecdce7b70", "services_unittests": "bd601d67ac1ecc078c5c534379d674001a13bf0a", "setup_unittests": "f8640b526eaafbfa2642c12a1f9230ba08988da8", "shell_dialogs_unittests": "b300861188495b695869aad26787be9943783fab", "skia_unittests": "374cbc79c4be60d7c36b3ca985ac4be0d5b5f378", "snapshot_unittests": "9f532fbe1cdfafdef290abef66dba313aca6f090", "sql_unittests": "4941886d58affa9deac4340e77a1ff842fa0799f", "storage_unittests": "407085cd4d5c7dfaf4ffb9a18bb4017b5b9c2af2", "sync_integration_tests": "f0193bfc1659ba70de0d4ab2f4378c58f94861ae", "telemetry_gpu_unittests": "0e6564d89c91edd7a3b78bd7966ee2e68f5e49ae", "telemetry_perf_unittests": "09fd510d3cc85220097912ac9ff252f03f5e1123", "telemetry_unittests": "443b5409105e7e19055aea95bcc15df36e8274ff", "traffic_annotation_auditor_unittests": "2facc112f13d9f245f294f6d62158a579b166f02", "ui_base_unittests": "f792665e2b75026e760511b6713afda5d5c4b279", "ui_touch_selection_unittests": "dc08c039a176cc9275c2b8f0fb7cd27531fcc45e", "unit_tests": "83f779c98891491640d6dc00bad612d7c338af2a", "url_unittests": "6d0fe5f9a7cd67093fd3f9570b86bc489e061f09", "views_perftests": "133689a7ba3906beafd972df7b87aca624586609", "views_unittests": "6e96638f2257ed57945b6558fb1777229cee466b", "viz_unittests": "485c1a07db3eb6c26c9b113f0b6e2ee5f9ebc75c", "vr_common_unittests": "39cfa067220db72ff52d95edc846b44afac38170", "vr_pixeltests": "b717de6769f9ef7b38f91fe2db32b2e99b53cab0", "webkit_python_tests": "53de65e1051ae6d2318cda429802041e7215409f", "webkit_unit_tests": "d6c2c3f3e4c757cae82fc7a25753693f329483d2", "wm_unittests": "34ae8b2eef5a166e2979f7ee1d0b5b8f41cf94ea", "wtf_unittests": "d5d4d4eea24a508eae5886b130904a60162d667e", "zucchini_unittests": "0f001447241eeade59673bce9625636fb49e0c0a"} setup_build
got_angle_revision "f3acb8c133fa825d5f25159eaf4ebf303bfef7a6" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "69b44ee6a1269afb5c7622189de236af0c4ec2a7" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "364c9149aef574f6fe179b8c47266ff4e9548163" bot_update
got_revision_cp "refs/heads/master@{#608395}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "14d4267208e7ee70b79186955b9b1b8c0273f3ca" bot_update
got_v8_revision_cp "refs/heads/7.2.341@{#1}" bot_update
got_webrtc_revision "a06bf8506fdfc0aff1098831bfc49bff4436399d" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25655}" bot_update
swarm_hashes {"accessibility_unittests": "a457663f7a7d448db5b9246c2c648207f055ad5a", "angle_unittests": "6599aa493f9830ba35a8b4a9f1d5b0061cedc6a1", "app_shell_unittests": "fff406b76de6b6ec35e913a6938e70f56e3f0f36", "aura_unittests": "d2f3e5f64a27119c7b09b9402700266583b3cce8", "base_unittests": "70f8cff5962121384ff1f4b1c033aced8dba002a", "blink_common_unittests": "c603d835006b371a4cb8713f19840ad742d95bb3", "blink_fuzzer_unittests": "fb116b5d650295e09bbdd0893b52e9d57656e388", "blink_heap_unittests": "d0fbc4ea5d8ceab8dd66d01a558a7a66043acd04", "blink_platform_unittests": "0b17a5d821316ca5d9f4f94899aa0a048addd808", "boringssl_crypto_tests": "469d6f7915033207e732219a235748e87f9c6811", "boringssl_ssl_tests": "2e1c97ead87792f1a0e004496bf3513ee3b827d8", "browser_tests": "461f56f02511a2a5bd2b8ed3e4087ae3488ce8ae", "cacheinvalidation_unittests": "ed5acb05aa5040c7965a210f8565663fdf08cfa0", "capture_unittests": "35ec15b7789c7ae0bec67f3b5b2cad6a882a521e", "cast_unittests": "38abc31cb2e8425363b5187195bf27ed5a21dac9", "cc_unittests": "bac54c9fd1c506ee61c3cf9449bd112e49338c74", "chrome_app_unittests": "2a5d89c2ad86af37cdf25d6c176e030b6faab7bb", "chrome_cleaner_unittests": "384c4afcabb6f93aaf886e30dd6c28ce326ed89d", "chrome_elf_import_unittests": "92016327b5bd8cbd80891dd4e33468b1c5bbaf3f", "chrome_elf_unittests": "ecebb077fd52c69e1d8ff19817781d39cd82ebe0", "chromedriver_py_tests": "6ea2fe234baaac1b9386c69429eaf043721c7dff", "chromedriver_replay_unittests": "608c0c89118b4704de3239f30dc69839a37605ef", "chromedriver_unittests": "ccb2bdd30630a3c775224718639433ceaa3ea494", "components_browsertests": "fcff43991031c90b9f8d2484867f37a30a2b7ad9", "components_perftests": "4c00c3b4350f1bf9a85a51827c6329b3dd5acf69", "components_unittests": "7b268c81a5e149162a1dff4f3f49ca700f0138b7", "compositor_unittests": "4ea2be30e87e2410310995f146dd8f09c01f9ce6", "content_browsertests": "412ee52c0da619671916fea617083d30a3d9fc1e", "content_shell_crash_test": "94165d8c616632f922af2c578f6020eb614e6da7", "content_unittests": "28ea23a22fdd0181bcca61f56184c7b878370c74", "courgette_unittests": "cab7642dd80ebb0d355e8f455e9f66f2f1459bd1", "crashpad_tests": "7a3e1fa9291794bb31e5764bc049b1bbbc519a92", "cronet_tests": "c4778a904eee1031cad95276e060798a72e6d41d", "cronet_unittests": "014594b42dbdbcba6235407d1270a4e45a1b75b8", "crypto_unittests": "dab4971d33a0d25779b0c3de2c4a1226180dbc01", "device_unittests": "2fe5f109a305823c900ce239d8a63b16128f28e3", "display_unittests": "b7f9cb347993dc4e8090249e7796db6a696f06e2", "elevation_service_unittests": "e4392a5b056ab152c5ab3b7a86c9633b8b6e2ef1", "events_unittests": "7c8ca4d11a50536249ac9ca7ece4e183929ba0b9", "extensions_browsertests": "040c3ff3870defce75d664630fe8394e71dac2ea", "extensions_unittests": "e09bc3c2ebdd10e929b24d6dde9427fbea575eac", "filesystem_service_unittests": "efe086edc4283af8030928ed8c02849432edb766", "gcm_unit_tests": "47c6fa71972bb18322aaef4fcf78a723fd638840", "gcp_unittests": "7b930012835c9b16b780516fdf8599de83a1ab2f", "gfx_unittests": "3238ebd5ea29f23c02ddb438a573af3233f83f74", "gin_unittests": "7b99f4de26e368d9068c3aa8e884da5efb95862d", "google_apis_unittests": "47f64b9385b398847c96f0425fe96b7d615f5f88", "gpu_unittests": "07ec4fd14676ab65fb5e3672839ea6c80534533f", "headless_browsertests": "4461e3787ced7c8186776a968ee53216e46032be", "headless_unittests": "f2be8cace3022b2bbce2d9f0b3564ec313922a78", "install_static_unittests": "e42bef873f612a33f1cf15fff8e8bbc560848ce3", "installer_util_unittests": "7af0c2b092f504eb0eadb71e6b207af24aff8843", "interactive_ui_tests": "7c22ff8f9f30087c3414deadcede602a86c177d4", "ipc_tests": "1c037794060a8f06caf5ac32665725017c7b9df2", "jingle_unittests": "8db7bf97a336e0001b66ed4523a1ab096bd1a120", "latency_unittests": "de6c2ec329ac385366a6b0811d90f62cf84cc723", "leveldb_service_unittests": "626da3c23a134e1e65f788778a4071a30dfd68f3", "libjingle_xmpp_unittests": "cb08b090a59b68f2f7afddad8fd3c142e59ab093", "media_blink_unittests": "fd6ba93dbc073a3a670330a450bec92fa21a27f0", "media_service_unittests": "387ff0fa63afed24ddd23cccdc3038ab9d2f9c3d", "media_unittests": "b0855067aad854bd2db8f1cbdc8f255b2d945235", "message_center_unittests": "63f2725f5b43b78c713d126625232f925156686d", "metrics_python_tests": "0aeb6201f6626ad16d6931a6376d63d6a9f0a254", "midi_unittests": "773c551ba69c0e3b89ac98ce5070a076d4c402a6", "mini_installer_tests": "56cb517e4d8b8c1e9a201fc82b630b7284494f68", "mojo_core_unittests": "061f80e67df02284c7a674868cddc180a978d4c6", "mojo_unittests": "8981aae02d7adff6c76bb5cf6201aa722702b9f3", "nacl_loader_unittests": "a96b17a370c3e309373479f987ba4312a8712d63", "native_theme_unittests": "3ec8d1db1a98774fc6fbba354b5011db4fa2db80", "net_unittests": "3ae754a649708f8bdfdbe865748d621878a57771", "notification_helper_unittests": "88f36f1792079d2b2c0363d3502894dfddaa3880", "pdf_unittests": "5fbeeb52b90207fa876ed6797405ba69c5385b5b", "ppapi_unittests": "30b81a8e2207ae28bbeab353d322da5cb38a5183", "printing_unittests": "668ece004b27dc7e628e49343e92a0a68296aa47", "remoting_unittests": "412f80ed78d8750fb495738a7bd03e0406fa22fe", "sbox_integration_tests": "a916a6cae3fb03ab3d0fbb20bf6df2c18ba4d669", "sbox_unittests": "02386457310da12833cf3c3d8edac1ac7f2a1bdf", "sbox_validation_tests": "3501c517bdb558ccb4eea45c2b902f7327a7b2d6", "service_manager_unittests": "54268181ce82e0851c12cb56ab6cdc6ecdce7b70", "services_unittests": "bd601d67ac1ecc078c5c534379d674001a13bf0a", "setup_unittests": "f8640b526eaafbfa2642c12a1f9230ba08988da8", "shell_dialogs_unittests": "b300861188495b695869aad26787be9943783fab", "skia_unittests": "374cbc79c4be60d7c36b3ca985ac4be0d5b5f378", "snapshot_unittests": "9f532fbe1cdfafdef290abef66dba313aca6f090", "sql_unittests": "4941886d58affa9deac4340e77a1ff842fa0799f", "storage_unittests": "407085cd4d5c7dfaf4ffb9a18bb4017b5b9c2af2", "sync_integration_tests": "f0193bfc1659ba70de0d4ab2f4378c58f94861ae", "telemetry_gpu_unittests": "0e6564d89c91edd7a3b78bd7966ee2e68f5e49ae", "telemetry_perf_unittests": "09fd510d3cc85220097912ac9ff252f03f5e1123", "telemetry_unittests": "443b5409105e7e19055aea95bcc15df36e8274ff", "traffic_annotation_auditor_unittests": "2facc112f13d9f245f294f6d62158a579b166f02", "ui_base_unittests": "f792665e2b75026e760511b6713afda5d5c4b279", "ui_touch_selection_unittests": "dc08c039a176cc9275c2b8f0fb7cd27531fcc45e", "unit_tests": "83f779c98891491640d6dc00bad612d7c338af2a", "url_unittests": "6d0fe5f9a7cd67093fd3f9570b86bc489e061f09", "views_perftests": "133689a7ba3906beafd972df7b87aca624586609", "views_unittests": "6e96638f2257ed57945b6558fb1777229cee466b", "viz_unittests": "485c1a07db3eb6c26c9b113f0b6e2ee5f9ebc75c", "vr_common_unittests": "39cfa067220db72ff52d95edc846b44afac38170", "vr_pixeltests": "b717de6769f9ef7b38f91fe2db32b2e99b53cab0", "webkit_python_tests": "53de65e1051ae6d2318cda429802041e7215409f", "webkit_unit_tests": "d6c2c3f3e4c757cae82fc7a25753693f329483d2", "wm_unittests": "34ae8b2eef5a166e2979f7ee1d0b5b8f41cf94ea", "wtf_unittests": "d5d4d4eea24a508eae5886b130904a60162d667e", "zucchini_unittests": "0f001447241eeade59673bce9625636fb49e0c0a"} find isolated tests

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Paul Jensen (pauljensenohnoyoudont@chromium.org)
  3. Elvin Lee (elvinohnoyoudont@chromium.org)
  4. Etienne Pierre-Doray (etiennepohnoyoudont@chromium.org)
  5. Vladimir Levin (vmpstrohnoyoudont@chromium.org)
  6. Sylvain Defresne (sdefresneohnoyoudont@chromium.org)
  7. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  8. Joe Mason (joenotcharlesohnoyoudont@google.com)
  9. Clemens Arbesser (arbesserohnoyoudont@google.com)
  10. Lindsay Pasricha (lindsaywohnoyoudont@google.com)
  11. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  12. Peter Wen (wnwenohnoyoudont@chromium.org)
  13. Finnur Thorarinsson (finnurohnoyoudont@chromium.org)
  14. Chris Harrelson (chrishtrohnoyoudont@chromium.org)
  15. Shivani Sharma (shivanishaohnoyoudont@chromium.org)
  16. Vadym Doroshenko (dvadymohnoyoudont@chromium.org)
  17. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  18. Friedrich Horschig (fhorschigohnoyoudont@chromium.org)
  19. Francois Doray (fdorayohnoyoudont@chromium.org)
  20. David Jean (djeanohnoyoudont@google.com)
  21. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  22. Tim Volodine (timvolodineohnoyoudont@google.com)
  23. Vladislav Kaznacheev (kaznacheevohnoyoudont@google.com)
  24. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  25. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  26. manuk (manukhohnoyoudont@chromium.org)
  27. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  28. Daniel Bratell (bratellohnoyoudont@opera.com)
  29. Stepan Khapugin (stkhapuginohnoyoudont@chromium.org)

Timing:

Create Thursday, 15-Nov-18 17:13:03 UTC
Start Thursday, 15-Nov-18 17:13:49 UTC
End Thursday, 15-Nov-18 17:42:44 UTC
Pending 45 secs
Execution 28 mins 55 secs

All Changes:

  1. Roll src/third_party/chromite a7e03047837c..d09518789d3f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 16:29:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 364c9149aef574f6fe179b8c47266ff4e9548163

    Comments

    Roll src/third_party/chromite a7e03047837c..d09518789d3f (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a7e03047837c..d09518789d3f


git log a7e03047837c..d09518789d3f --date=short --no-merges --format='%ad %ae %s'
2018-11-15 manojgupta@chromium.org Revert "generic_stages: temporarily ignore all target prebuilts."


Created with:
  gclient setdep -r src/third_party/chromite@d09518789d3f

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8036c02397e31dfef707f1ddb597d01d1f24bef6
Reviewed-on: https://chromium-review.googlesource.com/c/1337531
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608395}

    Changed files

    • DEPS

  2. Replace reflection with direct calls to Android P APIs.

    Changed by Paul Jensen - pauljensenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:28:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea711e1b730c21fd28739768fa0b09349dd86c78

    Comments

    Replace reflection with direct calls to Android P APIs.

This is possible now that Android P SDK is in Chromium.
The direct calls are placed in an ApiHelper class to avoid ART runtime
verification issues.

Change-Id: I88cf7788006aaa63b708a16f52aad00132e28c05
Reviewed-on: https://chromium-review.googlesource.com/c/1335874
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608394}

    Changed files

    • base/BUILD.gn
    • base/android/java/src/org/chromium/base/compat/ApiHelperForP.java
    • net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java

  3. Changes to support Android Things N on Cast master

    Changed by Elvin Lee - elvinohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:28:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c549deee6b8134b834191b7b3d236dc5f86f85a4

    Comments

    Changes to support Android Things N on Cast master

Test: Built and Run with Android N(on Cast Master) changes (Cast + setup) on the AT1
Bug: 118437285
Change-Id: Iff72a2a2d8eabda619940a256bab1b23daf00c26
Reviewed-on: https://chromium-review.googlesource.com/c/1331579
Commit-Queue: Elvin L <elvin@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608393}

    Changed files

    • chromecast/BUILD.gn
    • chromecast/base/BUILD.gn
    • chromecast/base/cast_sys_info_android_factory.cc
    • chromecast/browser/BUILD.gn
    • chromecast/browser/android/BUILD.gn
    • chromecast/chromecast.gni
    • chromecast/media/cma/backend/android/java/src/org/chromium/chromecast/cma/backend/android/VolumeMap.java

  4. Revert "[TaskScheduler]: Migrate off of ScopedAllowWait in /android_webview"

    Changed by Etienne Pierre-Doray - etiennepohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:26:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ab594e77fa994b5f5c7b16c31278afba4be3a8c

    Comments

    Revert "[TaskScheduler]: Migrate off of ScopedAllowWait in /android_webview"

This reverts commit bcc4146d6611e4979f5bc1f71274d17a4f2e1a1e.

Reason for revert: android.webkit.cts.WebViewStartupTest#testCookieManagerBlockingUiThread is consistently failing.

Bug: 905025

Original change's description:
> [TaskScheduler]: Migrate off of ScopedAllowWait in /android_webview
> 
> base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
> explicit counterpart.
> 
> It should have been replaced by :
>  * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
>  * base::ScopedAllowBaseSyncPrimitives in non-test files
>  * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
>    that don't allow blocking
> The last one is strongly frowned upon but this CL aims to document existing
> behavior rather than address it. Owners are encouraged to follow-up by fixing
> unnecessary waits and more particularly unnecessary waits
> outside-blocking-scope.
> 
> Note: The non-for-testing versions require friend'ing in thread_restrictions.h
> but care was taken to add these friends ahead of git cl split (since it wasn't
> possible to do a line-by-line associated CL split).
> Refer to the top-level CL if necessary :
> https://chromium-review.googlesource.com/c/chromium/src/+/1288533
> 
> Please CQ if LGTY!
> 
> This CL was uploaded by git cl split.
> 
> R=​torne@chromium.org
> 
> Bug: 766678
> Change-Id: I30e57cb0d9a0b1a449a4227561e97ea330ff6a12
> Reviewed-on: https://chromium-review.googlesource.com/c/1325195
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607674}

TBR=gab@chromium.org,torne@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 766678
Change-Id: If1ee0994f4387786662d7814617b297939b4dffb
Reviewed-on: https://chromium-review.googlesource.com/c/1337637
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608392}

    Changed files

    • android_webview/browser/aw_form_database_service.cc
    • android_webview/browser/cookie_manager.cc
    • base/threading/thread_restrictions.h

  5. OOP: Ensure to clear tiles when needed even if no display items.

    Changed by Vladimir Levin - vmpstrohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:25:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac3cbdf51a653088dfd3ee377192f63510b66e0b

    Comments

    OOP: Ensure to clear tiles when needed even if no display items.

This patch ensures that we don't early out under requires_clear when
doing OOP raster. If we early out, and we were doing a partial raster,
then we might end up with previous content on the texture.

R=enne@chromium.org, piman@chromium.org

Bug: 901897
Change-Id: I9e74e7f5b04d14385b733df50b08e027f5e6d1d3
Reviewed-on: https://chromium-review.googlesource.com/c/1335662
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608391}

    Changed files

    • cc/paint/oop_pixeltest.cc
    • gpu/command_buffer/client/raster_implementation.cc

  6. Add implementation for PrimaryAccountMutatorImpl [1/N]

    Changed by Sylvain Defresne - sdefresneohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:22:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 582d3964d03bdd1ab54f5ce02adc6adfb7053b9e

    Comments

    Add implementation for PrimaryAccountMutatorImpl [1/N]

Add implementation and test for PrimaryAccountMutatorImpl
methods {Set,Is}SettingPrimaryAccountAllowed.

Bug: 889902, 806778
Change-Id: Ibd75f2b3a988b4c403eab3b682a157e31e4b2e18
Reviewed-on: https://chromium-review.googlesource.com/c/1335937
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608390}

    Changed files

    • components/signin/core/browser/signin_manager.cc
    • components/signin/core/browser/signin_manager.h
    • components/signin/core/browser/signin_manager_base.h
    • services/identity/BUILD.gn
    • services/identity/public/cpp/BUILD.gn
    • services/identity/public/cpp/primary_account_mutator_impl.cc
    • services/identity/public/cpp/primary_account_mutator_unittest.cc

  7. [NTP] Correct arrow key navigation through tiles

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:21:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1435238d0479568e8fe957f618b36ad707c7e030

    Comments

    [NTP] Correct arrow key navigation through tiles

Make arrow key navigation through tiles not depend on the pixel width
of the dialog. When using the up and down keys first search for a tile
in the indicated direction that's in a different row ('top' is
different) then the tile that's in the same column ('left' is the same).

Bug: 896630
Change-Id: Ie5c9f7ebffba521dad1b8056626573c5015b3a36
Reviewed-on: https://chromium-review.googlesource.com/c/1335956
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608389}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.js

  8. Minor cleanups to chrome_cleaner/components and chrome_cleaner/cleaner

    Changed by Joe Mason - joenotcharlesohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 16:18:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a3bce7a8fb6803282c7d41bcea44be19988b59a

    Comments

    Minor cleanups to chrome_cleaner/components and chrome_cleaner/cleaner

Remove an unused constant that was moved to a test/ header
Fix copyright header format in cleaner dir
Fix comma in comments in constants dir

R=csharp@chromium.org

Bug: 830892
Change-Id: I8e91c4e320ceb3f8758d7182853dd46874968f6e
Reviewed-on: https://chromium-review.googlesource.com/c/1336048
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608388}

    Changed files

    • chrome/chrome_cleaner/cleaner/BUILD.gn
    • chrome/chrome_cleaner/cleaner/cleaner.h
    • chrome/chrome_cleaner/cleaner/noop_cleaner_impl.h
    • chrome/chrome_cleaner/components/system_report_component.cc
    • chrome/chrome_cleaner/constants/chrome_cleaner_switches.cc

  9. [Autofill Assistant] Removed overlay from the layout. This is now part of the TouchEventFilter.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 16:15:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc1aa6672a6794df1c8a84e3352c6326aeb5d5e5

    Comments

    [Autofill Assistant] Removed overlay from the layout. This is now part of the TouchEventFilter.

Essentially, this is accomplished by setting a TouchEventFilter with no touch-able area. This will gray out the entire view and look exactly like the overlay used to look.

Also, the unexpected tap counter is now reset each time a TouchEventFilter is disabled. This should result in more consistent and predictive behavior.

Bug: 806868
Change-Id: I308a3dc488e8d778245bfdc88714d1a9e621c8df
Reviewed-on: https://chromium-review.googlesource.com/c/1335940
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608387}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/TouchEventFilter.java

  10. Update edo build file.

    Changed by Lindsay Pasricha - lindsaywohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 16:14:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d11e8576d3018f2bff09db9f7b351ff674612297

    Comments

    Update edo build file.

Bug: 866147
Change-Id: Ibdb5bf46ec67c139b18ee6ca2c5853cac6dd99d8
Reviewed-on: https://chromium-review.googlesource.com/c/1337810
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608386}

    Changed files

    • ios/third_party/edo/BUILD.gn

  11. Roll src-internal a59368241b0c..32a6bd7b54fd (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 16:12:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f759a8d97207317596b99b300f01be40ad88f59

    Comments

    Roll src-internal a59368241b0c..32a6bd7b54fd (2 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a59368241b0c..32a6bd7b54fd


Created with:
  gclient setdep -r src-internal@32a6bd7b54fd

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id19178f2292e47a0e73124177b5907dda9f95051
Reviewed-on: https://chromium-review.googlesource.com/c/1337482
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608385}

    Changed files

    • DEPS

  12. Android: Remove javac dep for lint

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:07:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3943e93ebe81d301d080e479f16a8b9d9e347930

    Comments

    Android: Remove javac dep for lint

Remove android_lint targets' dependency on the corresponding
compile_java target. This allows javac and lint to run concurrently.

Add srcjar_deps for android_lint target since R.java is necessary to
determine which resources are used. These are no longer transitively
depended upon through compile_java.

Bug: 856189
Change-Id: If8b8abb1796bd50eb602443a36e3a198c3d35160
Reviewed-on: https://chromium-review.googlesource.com/c/1308100
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608384}

    Changed files

    • build/android/lint/suppressions.xml
    • build/config/android/internal_rules.gni

  13. Disable failing WebNavigationApiTest.GetFrame on Chrome OS.

    Changed by Finnur Thorarinsson - finnurohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e38f73b5094e0ff94b9f2d75f54685f9a88454bb

    Comments

    Disable failing WebNavigationApiTest.GetFrame on Chrome OS.

Started failing, apparently, in:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/8903

TBR=nasko@chromium.org

Bug: 874782
Change-Id: I5c7746682a08fea050bfa711c3f052edf2f7de07
Reviewed-on: https://chromium-review.googlesource.com/c/1337348
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608383}

    Changed files

    • chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

  14. Look recursively for composited scrollers, not just stopping

    Changed by Chris Harrelson - chrishtrohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 16:02:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4fe211a902905e0bace3144d1d8fef13b7395493

    Comments

    Look recursively for composited scrollers, not just stopping
at the enclosing scrolling ancestor.

Bug: 903067
Change-Id: Ice5deb0047862fa72a47e34b1f54f6a6955ae56c
Reviewed-on: https://chromium-review.googlesource.com/c/1336784
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608382}

    Changed files

    • third_party/WebKit/LayoutTests/compositing/overflow/non-composited-scroll-inside-composited-fixed-position-expected.html
    • third_party/WebKit/LayoutTests/compositing/overflow/non-composited-scroll-inside-composited-fixed-position.html
    • third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc

  15. Clear User Activation bits for main frames when new document is installed

    Changed by Shivani Sharma - shivanishaohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:58:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c4f56158b3c305e28ce9af4c27ed13c1c30d32fd

    Comments

    Clear User Activation bits for main frames when new document is installed

This is already being done in the renderer process during InstallNewDocument.
This change will do the clearing in the browser process FrameTreeNode and in
the RemoteFrame.

Test: content_browsertests --gtest_filter=*ClearUserActivationForNewDocument*
Bug: 901069
Change-Id: Ia11aa078ffd9376565893264a5b6ce4257f63908
Reviewed-on: https://chromium-review.googlesource.com/c/1320517
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608381}

    Changed files

    • content/browser/frame_host/frame_tree_browsertest.cc
    • content/browser/frame_host/frame_tree_node.cc
    • content/browser/frame_host/frame_tree_node.h
    • content/browser/frame_host/render_frame_host_impl.cc
    • third_party/blink/public/common/frame/user_activation_update_type.h
    • third_party/blink/renderer/core/exported/web_remote_frame_impl.cc
    • third_party/blink/renderer/core/frame/frame.cc
    • third_party/blink/renderer/core/frame/frame.h

  16. Do not offer password saving when saving is disabled.

    Changed by Vadym Doroshenko - dvadymohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:58:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fb05c46a907ec2cf0dfa053b30d8a0dd5ba3e4a

    Comments

    Do not offer password saving when saving is disabled.

This CL implements not saving of passwords in the new Password Manager
architecture when Password Manager saving if off (i.e.
"Offer to save passwords" settings is off).

Bug: 905048, 831123

Change-Id: Ic053f8ae9b28fc1e9d8d80ba5e1a469a4173fdec
Reviewed-on: https://chromium-review.googlesource.com/c/1337344
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608380}

    Changed files

    • components/password_manager/core/browser/password_manager.cc
    • components/password_manager/core/browser/password_manager_unittest.cc

  17. [Autofill Assistant] Remove cancel button.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:52:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0282b7ca5cb57f9af303368f858d9a79fe5bf935

    Comments

    [Autofill Assistant] Remove cancel button.

Before this patch, the main payment request view contained a cancel
button. That button is confusing since it shuts down autofill
assistant.

This patch removes the button. The payment request editor mode still
contains a cancel that goes back to the main payment request view.

R=arbesser@google.com, twellington@chromium.org

Bug: 806868
Change-Id: Ib5805d040f351035adbe209af149fb697715f949
Reviewed-on: https://chromium-review.googlesource.com/c/1337622
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608379}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request_bottom_bar.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java

  18. [Mfil Android] Move accessory bar shadow from tab into sheet

    Changed by Friedrich Horschig - fhorschigohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:49:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 979db04c46ffabdcc076d158f1c5be6b6a55accc

    Comments

    [Mfil Android] Move accessory bar shadow from tab into sheet

The fix for the missing shadow in https://crrev.com/c/1331400 was
intentionally short but not very clean. This CL fixes that by moving the
shadow into the accessory sheet. This ensures that the view state is
again reflected by the model.

Bug: 903824
Change-Id: I7a7de1cba5586997de8964551b2b4ec94cb38647
Reviewed-on: https://chromium-review.googlesource.com/c/1331587
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608378}

    Changed files

    • chrome/android/java/res/layout/keyboard_accessory_sheet.xml
    • chrome/android/java/res/layout/main.xml
    • chrome/android/java/res/layout/password_accessory_sheet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetProperties.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetView.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetProperties.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java

  19. RC: Update ProactiveTabFreezeAndDiscard testing config.

    Changed by Francois Doray - fdorayohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:45:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b731a1c8effd445c10a1daaf9ee2aac434a4730d

    Comments

    RC: Update ProactiveTabFreezeAndDiscard testing config.

This CL updates the ProactiveTabFreezeAndDiscard testing config to
match the server-side config.

See ProactiveTabFreezeAndDiscard.gcl.

Bug: 844426
Change-Id: Ib40252c10423e8f9bedf6a376328ed915f5fc2a8
Reviewed-on: https://chromium-review.googlesource.com/c/1336068
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608377}

    Changed files

    • testing/variations/fieldtrial_testing_config.json

  20. [ios] use view controller base class for manual fill passwords

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 15:37:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e676b7b4c45de16791c3148da4214c7e88a1a4bd

    Comments

    [ios] use view controller base class for manual fill passwords

Bug: 845472
Change-Id: I012839e8ee5dee6ae54d66327f1de5f38ff96d71
Reviewed-on: https://chromium-review.googlesource.com/c/1335599
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608376}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/password_view_controller.mm

  21. Roll src/third_party/webrtc 95140715009f..a06bf8506fdf (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 15:36:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e409d21b7a1ed490c90681d64db8e34cf1126017

    Comments

    Roll src/third_party/webrtc 95140715009f..a06bf8506fdf (1 commits)

https://webrtc.googlesource.com/src.git/+log/95140715009f..a06bf8506fdf


git log 95140715009f..a06bf8506fdf --date=short --no-merges --format='%ad %ae %s'
2018-11-15 tzik@chromium.org Add a presubmit check for absl/memory/memory.h inclusion


Created with:
  gclient setdep -r src/third_party/webrtc@a06bf8506fdf

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:752720
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iac7aba638ab8133c587b282f40892e534293ad38
Reviewed-on: https://chromium-review.googlesource.com/c/1337481
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608375}

    Changed files

    • DEPS

  22. [Web Speech API] Make it possible to enable speech-to-text separately from text-to-speech.

    Changed by Tim Volodine - timvolodineohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 15:34:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adfe3021565f243fe59911475cce301bf71bfefa

    Comments

    [Web Speech API] Make it possible to enable speech-to-text separately from text-to-speech.

Web Speech API [1] consists of two parts:
1. speech recognition (speech-to-text, STT)
2. speech synthesis (text-to-speech, TTS)

Currently Web Speech API can be either enabled or disabled completely,
by means of "disable-speech-api" command line flag. However we want to
be able to enable STT and TTS functionality separately. This has to do
with some security/privacy concerns regarding speech synthesis.

In particular we want to enable STT functionality in Android WebView,
but not TTS (at least until all concerns are addressed).

In this patch the ScriptedSpeech runtime blink flag is split into two:
ScriptedSpeechRecognition and ScriptedSpeechSynthesis. An additional
"disable-speech-synthesis-api" command line flag is added to control
how much of the Web Speech API we want to expose.

[1] https://w3c.github.io/speech-api/

BUG=487255

Change-Id: I959b73600bb8e7a0542661bfb997ceae1aa144ed
Reviewed-on: https://chromium-review.googlesource.com/c/1329150
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608374}

    Changed files

    • content/child/runtime_features.cc
    • content/public/common/content_switches.cc
    • content/public/common/content_switches.h
    • third_party/blink/public/platform/web_runtime_features.h
    • third_party/blink/renderer/modules/speech/speech_synthesis_error_event.idl
    • third_party/blink/renderer/modules/speech/speech_synthesis_event.idl
    • third_party/blink/renderer/modules/speech/speech_synthesis_utterance.idl
    • third_party/blink/renderer/modules/speech/window_speech.idl
    • third_party/blink/renderer/modules/speech/window_speech_synthesis.idl
    • third_party/blink/renderer/platform/exported/web_runtime_features.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5

  23. Bring back full range of icon sizes for Files app

    Changed by Vladislav Kaznacheev - kaznacheevohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 15:30:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9dca2f22e8863e5f8ec15ca228531f29cec5d5c

    Comments

    Bring back full range of icon sizes for Files app

Return to using icon sizes from before crrev.com/c/1243680.
This should exclude a possibility of any regressions.
Updating the icon look to the latest UI design.

Bug: 893548
Test: steps in bug
Change-Id: I596750416a5c87f0239119086b4db84554f3d3a0
Reviewed-on: https://chromium-review.googlesource.com/c/1336188
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608373}

    Changed files

    • ui/file_manager/audio_player/icons/audio-player-256.png
    • ui/file_manager/audio_player/icons/audio-player-32.png
    • ui/file_manager/audio_player/icons/audio-player-64.png
    • ui/file_manager/audio_player/icons/audio-player-96.png
    • ui/file_manager/audio_player/manifest.json
    • ui/file_manager/file_manager/common/images/icon256.png
    • ui/file_manager/file_manager/common/images/icon32.png
    • ui/file_manager/file_manager/common/images/icon64.png
    • ui/file_manager/file_manager/manifest.json
    • ui/file_manager/file_manager_resources.grd
    • ui/file_manager/gallery/images/icon256.png
    • ui/file_manager/gallery/images/icon32.png
    • ui/file_manager/gallery/images/icon64.png
    • ui/file_manager/gallery/images/icon96.png
    • ui/file_manager/gallery/manifest.json
    • ui/file_manager/video_player/images/icon/video-player-256.png
    • ui/file_manager/video_player/images/icon/video-player-32.png
    • ui/file_manager/video_player/images/icon/video-player-64.png
    • ui/file_manager/video_player/images/icon/video-player-96.png
    • ui/file_manager/video_player/manifest.json

  24. Import wpt@02dccc6b5ad45352ae5c3bdf23fcbd9b0deea071

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 15:26:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29bfc14f877f2cb18672f7b7504770ed7fe1364e

    Comments

    Import wpt@02dccc6b5ad45352ae5c3bdf23fcbd9b0deea071

Using wpt-import in Chromium 73b488158ac6d9426c8e0ff2f8f65e8026608705.
With Chromium commits locally applied on WPT:
f482e77e59 "Add report-only mode to Feature Policy"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org:
  external/wpt/infrastructure
jsbell@chromium.org:
  external/wpt/IndexedDB
  external/wpt/resources
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I4111c4acfe912b4ad363acce5b6216afd1b03ec6
Reviewed-on: https://chromium-review.googlesource.com/c/1337633
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608372}

    Changed files

    • third_party/WebKit/LayoutTests/NeverFixTests
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_advance_index2.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_advance_index3.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_advance_index5.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_continue_index5.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_continue_index6.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_continue_invalid.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_index.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_index2.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_objectstore.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_iterating_objectstore2.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbcursor_update_objectstore4.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_createObjectStore10-1000ends.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_createObjectStore7.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_deleteObjectStore4-not_reused.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbdatabase_transaction4.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_deleteDatabase3.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_open10.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_open11.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbfactory_open12.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-multientry-arraykeypath.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-multientry-big.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex-multientry.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbindex_indexNames.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex3-usable-right-away.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex4-deleteIndex-event_order.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex5-emptykeypath.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex6-event_order.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex7-event_order.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_createIndex8-valid_keys.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbobjectstore_deleted.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbtransaction-oncomplete.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbtransaction_abort.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/idbversionchangeevent.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keygenerator-constrainterror.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keygenerator-overflow.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keyorder.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/keypath_maxsize.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/request_bubble-and-capture.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction-lifetime-blocked.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction-lifetime.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction-requestqueue.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/transaction_bubble-and-capture.htm
    • third_party/WebKit/LayoutTests/external/wpt/IndexedDB/writer-starvation.htm
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/elementPosition.html.ini
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/metadata/infrastructure/testdriver/actions/eventOrder.html.ini
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/geometry.idl
    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove-manual.html
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js

  25. [DevTools] Speculative fix for ResetViewport crash

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:25:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d45720ead927ee7a2761c0a4cd1e76338c676c03

    Comments

    [DevTools] Speculative fix for ResetViewport crash

It seems that we can have no layer tree view, but a
visual_viewport_container_layer_, because we
set them up and wind down separately. Adding null-check
to fight the crash.

Note there is no stable repro for this crash, so it
might be something else.

Bug: 902413
Change-Id: I33dc8419f33ab11d8a49d0be543ac0c8119f9d19
Reviewed-on: https://chromium-review.googlesource.com/c/1334887
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608371}

    Changed files

    • third_party/blink/renderer/core/exported/web_view_impl.cc

  26. [chrome:omnibox] Add buttons to copy response data.

    Changed by manuk - manukhohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:22:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d557ace8644a84f3e217b13562c91d1bf20945d3

    Comments

    [chrome:omnibox] Add buttons to copy response data.

Two copy buttons are added. The first copies the visible table as text; display options, which affect the visibility of tables, columns, rows, also affect what text is copied. The second copies the responses as JSON.

Also, as this CL introduces a second outputs interface, I took this opportunity to consolidate this new interface and the previous OutputController (which served as an interface for OmniboxOutput) into a single interface, OmniboxController, which will be responsible for interfacing to individual Output classes responsible for:
1 render tables from responses
2 control visibility based on display options
3 control visibility and coloring based on search text
4 export/copy output
5 preserve inputs and reset default inputs
6 export/import inputs

Bug: 891303
Change-Id: I1b6e10e6aa2213912235863f61163c9d8e9f66f7
Reviewed-on: https://chromium-review.googlesource.com/c/1329842
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608370}

    Changed files

    • chrome/browser/resources/omnibox/BUILD.gn
    • chrome/browser/resources/omnibox/omnibox.html
    • chrome/browser/resources/omnibox/omnibox.js
    • chrome/browser/resources/omnibox/omnibox_inputs.js
    • chrome/browser/resources/omnibox/omnibox_output.js
    • third_party/closure_compiler/externs/pending.js

  27. Roll src/third_party/perfetto b93264e2b16b..c17c1dc0e795 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 15-Nov-18 15:20:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5104e13a609d57e6ede716c8f11611ad95315854

    Comments

    Roll src/third_party/perfetto b93264e2b16b..c17c1dc0e795 (1 commits)

https://android.googlesource.com/platform/external/perfetto.git/+log/b93264e2b16b..c17c1dc0e795


git log b93264e2b16b..c17c1dc0e795 --date=short --no-merges --format='%ad %ae %s'
2018-11-15 fmayer@google.com profiling: Include PIDs in heap dumps.


Created with:
  gclient setdep -r src/third_party/perfetto@c17c1dc0e795

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I283fb20d9a326b05c00ef13d485487d823db184b
Reviewed-on: https://chromium-review.googlesource.com/c/1337479
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#608369}

    Changed files

    • DEPS

  28. Restore the nonull warning in chrome/browser/ui for everything but mac

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Thursday, 15-Nov-18 15:11:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9c78579915f5035e97adb0000f2fa82bc6cb0e20

    Comments

    Restore the nonull warning in chrome/browser/ui for everything but mac

-Wno-null has been disabled for clang in chrome/browser/ui since 2015
but it seems to be enough to disable that warning for mac (the only
platform that used clang by default in 2015).

Bug: 383820
Change-Id: Iadc03f761c120db91fb806369ecf6f3bd8459c1c
Reviewed-on: https://chromium-review.googlesource.com/c/982057
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608368}

    Changed files

    • chrome/browser/ui/BUILD.gn

  29. Add owners for ntp_tile_views

    Changed by Stepan Khapugin - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 15:02:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 35385741e820020edddd9f116878779ca93f71a0

    Comments

    Add owners for ntp_tile_views

Adds gambard@ as OWNER of ntp_tile_views.
Gambard is the original author of ntp tiles before they were moved to
this folder.

Change-Id: Ie93a894cc685e4a0d5783e417ed714ae29901b14
Reviewed-on: https://chromium-review.googlesource.com/c/1337505
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608367}

    Changed files

    • ios/chrome/browser/ui/ntp_tile_views/OWNERS