Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 Build 29441 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision8700ed14ef6030b990233f03b729c1b60f81bc43
Got Revision8700ed14ef6030b990233f03b729c1b60f81bc43

Execution:

Steps and Logfiles:

Show:
  1. ( 585 ms ) setup_build
    running recipe: "chromium"
  2. ( 234 ms ) report builders
     
    running tester 'Win10 Tests x64' on master 'chromium.win'
  3. ( 5 secs ) taskkill
  4. ( 50 secs ) bot_update
    [65GB/299GB used (21%)]
  5. ( 622 ms ) swarming.py --version
    0.13
  6. ( 19 secs ) gclient runhooks
  7. ( 642 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 436 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 2 secs ) build directory
  10. ( 2 mins 34 secs ) extract build
  11. ( 1 secs ) find isolated tests
  12. ( 1 mins 40 secs ) test_installer
  13. ( 2 secs ) wait for tasks
  14. ( 2 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  15. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  16. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  17. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  18. ( 2 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  19. ( 2 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  20. ( 2 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  21. ( 2 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  22. ( 2 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  23. ( 2 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  24. ( 2 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  25. ( 2 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  26. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  27. ( 2 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  28. ( 4 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  29. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  30. ( 2 secs ) network_service_extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:26.993342
  31. ( 3 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  32. ( 2 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  33. ( 3 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  34. ( 2 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  35. ( 2 secs ) network_service_components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 43s
  36. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  37. ( 3 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  38. ( 2 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  39. ( 2 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  40. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  41. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  42. ( 2 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  43. ( 3 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  44. ( 3 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 51s
  45. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  46. ( 2 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  47. ( 2 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  48. ( 2 secs ) webui_polymer2_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:51.844658
  49. ( 3 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 52s
  50. ( 4 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:03.892453
  51. ( 2 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  52. ( 2 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  53. ( 2 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  54. ( 2 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  55. ( 2 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  56. ( 2 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  57. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  58. ( 2 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  59. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 39s
  60. ( 2 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  61. ( 2 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  62. ( 2 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  63. ( 2 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  64. ( 3 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:13.424402
  65. ( 2 secs ) gcp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  66. ( 2 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  67. ( 2 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  68. ( 2 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  69. ( 2 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  70. ( 2 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  71. ( 4 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  72. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  73. ( 2 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  74. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  75. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  76. ( 2 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  77. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  78. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  79. ( 2 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  80. ( 4 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  81. ( 2 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  82. ( 2 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  83. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  84. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  85. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 12s
  86. ( 2 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  87. ( 3 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  88. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  89. ( 2 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  90. ( 2 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  91. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  92. ( 2 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:27.091150
  93. ( 3 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  94. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  95. ( 3 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  96. ( 4 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:03.376886
  97. ( 2 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  98. ( 2 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  99. ( 2 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  100. ( 2 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:01.663534
  101. ( 1 secs ) wait for tasks (2)
  102. ( 2 secs ) mini_installer_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:12.549007
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  103. ( 7 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:19.846634
  104. ( 3 secs ) webui_polymer2_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:06:12.936434 (shard #2)
    Min shard duration: 0:05:30.400539 (shard #3)
  105. ( 3 secs ) network_service_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:11:17.226546 (shard #0)
    Min shard duration: 0:10:52.927363 (shard #1)
  106. ( 2 secs ) sync_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:09:04.546444
  107. ( 2 secs ) interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:09:51.551378 (shard #2)
    Min shard duration: 0:08:52.461222 (shard #1)
  108. ( 15 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:14.787450
  109. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:07:49.019813
  110. ( 7 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:14.337097
  111. ( 9 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:05:14.825112
  112. ( 2 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:34.116464
  113. ( 1 secs ) wait for tasks (3)
  114. ( 2 secs ) network_service_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:11:39.219719 (shard #2)
    Min shard duration: 0:09:29.704170 (shard #1)
  115. ( 1 secs ) wait for tasks (4)
  116. ( 8 secs ) network_service_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:15:58.825823 (shard #7)
    Min shard duration: 0:12:41.023507 (shard #9)
  117. ( 2 mins 11 secs ) wait for tasks (5)
  118. ( 3 secs ) content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:18:43.475249
  119. ( 1 mins 23 secs ) browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:21:02.833632 (shard #2)
    Min shard duration: 0:16:23.483427 (shard #4)
  120. ( 215 ms ) Tests statistics
     
    Stats
    Total shards: 133
    Total runtime: 9:13:19.863999
     
  121. ( 1 secs ) process_dumps
  122. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-c-wl5t" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542299493732225, "id": "8929775482018618944", "project": "chromium", "tags": ["builder:Win10 Tests x64", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8700ed14ef6030b990233f03b729c1b60f81bc43", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder", "parent_buildnumber:58808", "scheduler_invocation_id:9095205544054228976", "scheduler_job_id:chromium/Win10 Tests x64", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 Tests x64" setup_build
buildnumber 29441 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder" setup_build
parent_got_angle_revision "f3acb8c133fa825d5f25159eaf4ebf303bfef7a6" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "69b44ee6a1269afb5c7622189de236af0c4ec2a7" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "8700ed14ef6030b990233f03b729c1b60f81bc43" setup_build
parent_got_revision_cp "refs/heads/master@{#608366}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "14d4267208e7ee70b79186955b9b1b8c0273f3ca" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.341@{#1}" setup_build
parent_got_webrtc_revision "95140715009f10853b25736a314b84ccb8a7bdbd" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25654}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "8700ed14ef6030b990233f03b729c1b60f81bc43" setup_build
swarm_hashes {"accessibility_unittests": "a457663f7a7d448db5b9246c2c648207f055ad5a", "angle_unittests": "6599aa493f9830ba35a8b4a9f1d5b0061cedc6a1", "app_shell_unittests": "5abf006027f69508173b33706ce18f7e90a45d08", "aura_unittests": "f7f3b60b74331a9bd0f6fd3bc80f33f808e23c05", "base_unittests": "70f8cff5962121384ff1f4b1c033aced8dba002a", "blink_common_unittests": "c603d835006b371a4cb8713f19840ad742d95bb3", "blink_fuzzer_unittests": "fb116b5d650295e09bbdd0893b52e9d57656e388", "blink_heap_unittests": "a523568c4c492aee19f14c1c9a54d637d2077c75", "blink_platform_unittests": "f699a63b74840cced41b3ea4a9422f62bd75de19", "boringssl_crypto_tests": "469d6f7915033207e732219a235748e87f9c6811", "boringssl_ssl_tests": "2e1c97ead87792f1a0e004496bf3513ee3b827d8", "browser_tests": "612bcd7f724b57a2ffbf2f8738cff9910b9961a6", "cacheinvalidation_unittests": "ed5acb05aa5040c7965a210f8565663fdf08cfa0", "capture_unittests": "35ec15b7789c7ae0bec67f3b5b2cad6a882a521e", "cast_unittests": "38abc31cb2e8425363b5187195bf27ed5a21dac9", "cc_unittests": "1ca7f85ee9aa43987509b5f1127cc28a78e47e24", "chrome_app_unittests": "2a5d89c2ad86af37cdf25d6c176e030b6faab7bb", "chrome_cleaner_unittests": "194b20945391d1deda5313c90fd158991ef86bd1", "chrome_elf_import_unittests": "069f97a0076e553eade0f568a1be080f6511fcc2", "chrome_elf_unittests": "dc3cd26253caf18bcc2bf73428193270212a62ee", "chromedriver_py_tests": "a659dbcfa951e28a4e7615fbebb7435eb1123f7e", "chromedriver_replay_unittests": "608c0c89118b4704de3239f30dc69839a37605ef", "chromedriver_unittests": "40356d38436cf03161979c3a79c1e4e4ac0875c8", "components_browsertests": "b19af9c7a2082e0080d6568897abf391af649533", "components_perftests": "488a6e0a7819174370cfbc63b36cca25ab7abfdb", "components_unittests": "1aa302a23a2eeaf0fe2bc88127167b8ca77e3205", "compositor_unittests": "4ea2be30e87e2410310995f146dd8f09c01f9ce6", "content_browsertests": "57072180430b8803882854ce956ef92f8e820328", "content_shell_crash_test": "b3261f65a37823462b820e9e9932a1d4e85c099d", "content_unittests": "41ce1c911f2b671aa3e5940867b3cdfa8f974935", "courgette_unittests": "cab7642dd80ebb0d355e8f455e9f66f2f1459bd1", "crashpad_tests": "7a3e1fa9291794bb31e5764bc049b1bbbc519a92", "cronet_tests": "c4778a904eee1031cad95276e060798a72e6d41d", "cronet_unittests": "014594b42dbdbcba6235407d1270a4e45a1b75b8", "crypto_unittests": "dab4971d33a0d25779b0c3de2c4a1226180dbc01", "device_unittests": "2fe5f109a305823c900ce239d8a63b16128f28e3", "display_unittests": "b7f9cb347993dc4e8090249e7796db6a696f06e2", "elevation_service_unittests": "2040c4ad228681a8fc2cd2e3b540899418d430a3", "events_unittests": "7c8ca4d11a50536249ac9ca7ece4e183929ba0b9", "extensions_browsertests": "4115e2631ddbf751df0eb4a171072b0e656658c3", "extensions_unittests": "8b68f5fb4367976215296e300d29c613f1f54f19", "filesystem_service_unittests": "efe086edc4283af8030928ed8c02849432edb766", "gcm_unit_tests": "47c6fa71972bb18322aaef4fcf78a723fd638840", "gcp_unittests": "b837ef264c4fba155a902bb5cf7abf4af1d48384", "gfx_unittests": "3238ebd5ea29f23c02ddb438a573af3233f83f74", "gin_unittests": "7b99f4de26e368d9068c3aa8e884da5efb95862d", "google_apis_unittests": "47f64b9385b398847c96f0425fe96b7d615f5f88", "gpu_unittests": "cf4e3757a4145489d184c4d74f2457c5852d478d", "headless_browsertests": "50bdd92ede8d2638353a8b17ef50a8ba1113003b", "headless_unittests": "f2be8cace3022b2bbce2d9f0b3564ec313922a78", "install_static_unittests": "e42bef873f612a33f1cf15fff8e8bbc560848ce3", "installer_util_unittests": "b2e39a82463115c5ab8a019f8ef8d0eaba8549a3", "interactive_ui_tests": "05fc3011d33a058fbfb9264e2e13652dd84e8926", "ipc_tests": "1c037794060a8f06caf5ac32665725017c7b9df2", "jingle_unittests": "8db7bf97a336e0001b66ed4523a1ab096bd1a120", "latency_unittests": "de6c2ec329ac385366a6b0811d90f62cf84cc723", "leveldb_service_unittests": "626da3c23a134e1e65f788778a4071a30dfd68f3", "libjingle_xmpp_unittests": "cb08b090a59b68f2f7afddad8fd3c142e59ab093", "media_blink_unittests": "46fb569b171f8ede94e8aecfff843149887a2f58", "media_service_unittests": "387ff0fa63afed24ddd23cccdc3038ab9d2f9c3d", "media_unittests": "b0855067aad854bd2db8f1cbdc8f255b2d945235", "message_center_unittests": "4d252dc4a55dd71ae3f893d78476c25b927d6e0c", "metrics_python_tests": "0aeb6201f6626ad16d6931a6376d63d6a9f0a254", "midi_unittests": "773c551ba69c0e3b89ac98ce5070a076d4c402a6", "mini_installer_tests": "442d72b01851256e2745b6c754dc0622e6fa1443", "mojo_core_unittests": "061f80e67df02284c7a674868cddc180a978d4c6", "mojo_unittests": "8981aae02d7adff6c76bb5cf6201aa722702b9f3", "nacl_loader_unittests": "a96b17a370c3e309373479f987ba4312a8712d63", "native_theme_unittests": "3ec8d1db1a98774fc6fbba354b5011db4fa2db80", "net_unittests": "3ae754a649708f8bdfdbe865748d621878a57771", "notification_helper_unittests": "33c4b8ac2a0e0b0a1d772a665e4bb2a8f8be8a0e", "pdf_unittests": "5fbeeb52b90207fa876ed6797405ba69c5385b5b", "ppapi_unittests": "30b81a8e2207ae28bbeab353d322da5cb38a5183", "printing_unittests": "668ece004b27dc7e628e49343e92a0a68296aa47", "remoting_unittests": "412f80ed78d8750fb495738a7bd03e0406fa22fe", "sbox_integration_tests": "a916a6cae3fb03ab3d0fbb20bf6df2c18ba4d669", "sbox_unittests": "02386457310da12833cf3c3d8edac1ac7f2a1bdf", "sbox_validation_tests": "3501c517bdb558ccb4eea45c2b902f7327a7b2d6", "service_manager_unittests": "54268181ce82e0851c12cb56ab6cdc6ecdce7b70", "services_unittests": "4bb3e6265396f2332cf0d0b99c02110225f8fffa", "setup_unittests": "f8640b526eaafbfa2642c12a1f9230ba08988da8", "shell_dialogs_unittests": "b300861188495b695869aad26787be9943783fab", "skia_unittests": "374cbc79c4be60d7c36b3ca985ac4be0d5b5f378", "snapshot_unittests": "3edf8b33f404c775bb5145e6f43e25b4902967ac", "sql_unittests": "4941886d58affa9deac4340e77a1ff842fa0799f", "storage_unittests": "407085cd4d5c7dfaf4ffb9a18bb4017b5b9c2af2", "sync_integration_tests": "7d281373087808060c62c230e3f033e72fdce8d4", "telemetry_gpu_unittests": "0e6564d89c91edd7a3b78bd7966ee2e68f5e49ae", "telemetry_perf_unittests": "2ea5426df9a2078e403627c2df11c7c9884bcaeb", "telemetry_unittests": "12b0c615ee9f80c56b502fa35570fe64435ad302", "traffic_annotation_auditor_unittests": "2facc112f13d9f245f294f6d62158a579b166f02", "ui_base_unittests": "f792665e2b75026e760511b6713afda5d5c4b279", "ui_touch_selection_unittests": "dc08c039a176cc9275c2b8f0fb7cd27531fcc45e", "unit_tests": "e36a46c656363a7de218d3ad70d161db5dbf7441", "url_unittests": "6d0fe5f9a7cd67093fd3f9570b86bc489e061f09", "views_perftests": "7a0a514850d9e97222e95550940c1ef000d39616", "views_unittests": "573f6d8973a48e6c04def33fa463d2bed10e597e", "viz_unittests": "1394fa63b75d4d331a79c685c49b4f2d9f13ff72", "vr_common_unittests": "39cfa067220db72ff52d95edc846b44afac38170", "vr_pixeltests": "b717de6769f9ef7b38f91fe2db32b2e99b53cab0", "webkit_python_tests": "f8d164bc0c1046a10dc846aea592caeabd385338", "webkit_unit_tests": "33e966eac0c035ea183e42410bc09c685ca322e3", "wm_unittests": "3212499cdfc528a4c7998a04f7051beaf6055a8e", "wtf_unittests": "d5d4d4eea24a508eae5886b130904a60162d667e", "zucchini_unittests": "0f001447241eeade59673bce9625636fb49e0c0a"} setup_build
got_angle_revision "f3acb8c133fa825d5f25159eaf4ebf303bfef7a6" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "69b44ee6a1269afb5c7622189de236af0c4ec2a7" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "8700ed14ef6030b990233f03b729c1b60f81bc43" bot_update
got_revision_cp "refs/heads/master@{#608366}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "14d4267208e7ee70b79186955b9b1b8c0273f3ca" bot_update
got_v8_revision_cp "refs/heads/7.2.341@{#1}" bot_update
got_webrtc_revision "95140715009f10853b25736a314b84ccb8a7bdbd" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25654}" bot_update
swarm_hashes {"accessibility_unittests": "a457663f7a7d448db5b9246c2c648207f055ad5a", "angle_unittests": "6599aa493f9830ba35a8b4a9f1d5b0061cedc6a1", "app_shell_unittests": "5abf006027f69508173b33706ce18f7e90a45d08", "aura_unittests": "f7f3b60b74331a9bd0f6fd3bc80f33f808e23c05", "base_unittests": "70f8cff5962121384ff1f4b1c033aced8dba002a", "blink_common_unittests": "c603d835006b371a4cb8713f19840ad742d95bb3", "blink_fuzzer_unittests": "fb116b5d650295e09bbdd0893b52e9d57656e388", "blink_heap_unittests": "a523568c4c492aee19f14c1c9a54d637d2077c75", "blink_platform_unittests": "f699a63b74840cced41b3ea4a9422f62bd75de19", "boringssl_crypto_tests": "469d6f7915033207e732219a235748e87f9c6811", "boringssl_ssl_tests": "2e1c97ead87792f1a0e004496bf3513ee3b827d8", "browser_tests": "612bcd7f724b57a2ffbf2f8738cff9910b9961a6", "cacheinvalidation_unittests": "ed5acb05aa5040c7965a210f8565663fdf08cfa0", "capture_unittests": "35ec15b7789c7ae0bec67f3b5b2cad6a882a521e", "cast_unittests": "38abc31cb2e8425363b5187195bf27ed5a21dac9", "cc_unittests": "1ca7f85ee9aa43987509b5f1127cc28a78e47e24", "chrome_app_unittests": "2a5d89c2ad86af37cdf25d6c176e030b6faab7bb", "chrome_cleaner_unittests": "194b20945391d1deda5313c90fd158991ef86bd1", "chrome_elf_import_unittests": "069f97a0076e553eade0f568a1be080f6511fcc2", "chrome_elf_unittests": "dc3cd26253caf18bcc2bf73428193270212a62ee", "chromedriver_py_tests": "a659dbcfa951e28a4e7615fbebb7435eb1123f7e", "chromedriver_replay_unittests": "608c0c89118b4704de3239f30dc69839a37605ef", "chromedriver_unittests": "40356d38436cf03161979c3a79c1e4e4ac0875c8", "components_browsertests": "b19af9c7a2082e0080d6568897abf391af649533", "components_perftests": "488a6e0a7819174370cfbc63b36cca25ab7abfdb", "components_unittests": "1aa302a23a2eeaf0fe2bc88127167b8ca77e3205", "compositor_unittests": "4ea2be30e87e2410310995f146dd8f09c01f9ce6", "content_browsertests": "57072180430b8803882854ce956ef92f8e820328", "content_shell_crash_test": "b3261f65a37823462b820e9e9932a1d4e85c099d", "content_unittests": "41ce1c911f2b671aa3e5940867b3cdfa8f974935", "courgette_unittests": "cab7642dd80ebb0d355e8f455e9f66f2f1459bd1", "crashpad_tests": "7a3e1fa9291794bb31e5764bc049b1bbbc519a92", "cronet_tests": "c4778a904eee1031cad95276e060798a72e6d41d", "cronet_unittests": "014594b42dbdbcba6235407d1270a4e45a1b75b8", "crypto_unittests": "dab4971d33a0d25779b0c3de2c4a1226180dbc01", "device_unittests": "2fe5f109a305823c900ce239d8a63b16128f28e3", "display_unittests": "b7f9cb347993dc4e8090249e7796db6a696f06e2", "elevation_service_unittests": "2040c4ad228681a8fc2cd2e3b540899418d430a3", "events_unittests": "7c8ca4d11a50536249ac9ca7ece4e183929ba0b9", "extensions_browsertests": "4115e2631ddbf751df0eb4a171072b0e656658c3", "extensions_unittests": "8b68f5fb4367976215296e300d29c613f1f54f19", "filesystem_service_unittests": "efe086edc4283af8030928ed8c02849432edb766", "gcm_unit_tests": "47c6fa71972bb18322aaef4fcf78a723fd638840", "gcp_unittests": "b837ef264c4fba155a902bb5cf7abf4af1d48384", "gfx_unittests": "3238ebd5ea29f23c02ddb438a573af3233f83f74", "gin_unittests": "7b99f4de26e368d9068c3aa8e884da5efb95862d", "google_apis_unittests": "47f64b9385b398847c96f0425fe96b7d615f5f88", "gpu_unittests": "cf4e3757a4145489d184c4d74f2457c5852d478d", "headless_browsertests": "50bdd92ede8d2638353a8b17ef50a8ba1113003b", "headless_unittests": "f2be8cace3022b2bbce2d9f0b3564ec313922a78", "install_static_unittests": "e42bef873f612a33f1cf15fff8e8bbc560848ce3", "installer_util_unittests": "b2e39a82463115c5ab8a019f8ef8d0eaba8549a3", "interactive_ui_tests": "05fc3011d33a058fbfb9264e2e13652dd84e8926", "ipc_tests": "1c037794060a8f06caf5ac32665725017c7b9df2", "jingle_unittests": "8db7bf97a336e0001b66ed4523a1ab096bd1a120", "latency_unittests": "de6c2ec329ac385366a6b0811d90f62cf84cc723", "leveldb_service_unittests": "626da3c23a134e1e65f788778a4071a30dfd68f3", "libjingle_xmpp_unittests": "cb08b090a59b68f2f7afddad8fd3c142e59ab093", "media_blink_unittests": "46fb569b171f8ede94e8aecfff843149887a2f58", "media_service_unittests": "387ff0fa63afed24ddd23cccdc3038ab9d2f9c3d", "media_unittests": "b0855067aad854bd2db8f1cbdc8f255b2d945235", "message_center_unittests": "4d252dc4a55dd71ae3f893d78476c25b927d6e0c", "metrics_python_tests": "0aeb6201f6626ad16d6931a6376d63d6a9f0a254", "midi_unittests": "773c551ba69c0e3b89ac98ce5070a076d4c402a6", "mini_installer_tests": "442d72b01851256e2745b6c754dc0622e6fa1443", "mojo_core_unittests": "061f80e67df02284c7a674868cddc180a978d4c6", "mojo_unittests": "8981aae02d7adff6c76bb5cf6201aa722702b9f3", "nacl_loader_unittests": "a96b17a370c3e309373479f987ba4312a8712d63", "native_theme_unittests": "3ec8d1db1a98774fc6fbba354b5011db4fa2db80", "net_unittests": "3ae754a649708f8bdfdbe865748d621878a57771", "notification_helper_unittests": "33c4b8ac2a0e0b0a1d772a665e4bb2a8f8be8a0e", "pdf_unittests": "5fbeeb52b90207fa876ed6797405ba69c5385b5b", "ppapi_unittests": "30b81a8e2207ae28bbeab353d322da5cb38a5183", "printing_unittests": "668ece004b27dc7e628e49343e92a0a68296aa47", "remoting_unittests": "412f80ed78d8750fb495738a7bd03e0406fa22fe", "sbox_integration_tests": "a916a6cae3fb03ab3d0fbb20bf6df2c18ba4d669", "sbox_unittests": "02386457310da12833cf3c3d8edac1ac7f2a1bdf", "sbox_validation_tests": "3501c517bdb558ccb4eea45c2b902f7327a7b2d6", "service_manager_unittests": "54268181ce82e0851c12cb56ab6cdc6ecdce7b70", "services_unittests": "4bb3e6265396f2332cf0d0b99c02110225f8fffa", "setup_unittests": "f8640b526eaafbfa2642c12a1f9230ba08988da8", "shell_dialogs_unittests": "b300861188495b695869aad26787be9943783fab", "skia_unittests": "374cbc79c4be60d7c36b3ca985ac4be0d5b5f378", "snapshot_unittests": "3edf8b33f404c775bb5145e6f43e25b4902967ac", "sql_unittests": "4941886d58affa9deac4340e77a1ff842fa0799f", "storage_unittests": "407085cd4d5c7dfaf4ffb9a18bb4017b5b9c2af2", "sync_integration_tests": "7d281373087808060c62c230e3f033e72fdce8d4", "telemetry_gpu_unittests": "0e6564d89c91edd7a3b78bd7966ee2e68f5e49ae", "telemetry_perf_unittests": "2ea5426df9a2078e403627c2df11c7c9884bcaeb", "telemetry_unittests": "12b0c615ee9f80c56b502fa35570fe64435ad302", "traffic_annotation_auditor_unittests": "2facc112f13d9f245f294f6d62158a579b166f02", "ui_base_unittests": "f792665e2b75026e760511b6713afda5d5c4b279", "ui_touch_selection_unittests": "dc08c039a176cc9275c2b8f0fb7cd27531fcc45e", "unit_tests": "e36a46c656363a7de218d3ad70d161db5dbf7441", "url_unittests": "6d0fe5f9a7cd67093fd3f9570b86bc489e061f09", "views_perftests": "7a0a514850d9e97222e95550940c1ef000d39616", "views_unittests": "573f6d8973a48e6c04def33fa463d2bed10e597e", "viz_unittests": "1394fa63b75d4d331a79c685c49b4f2d9f13ff72", "vr_common_unittests": "39cfa067220db72ff52d95edc846b44afac38170", "vr_pixeltests": "b717de6769f9ef7b38f91fe2db32b2e99b53cab0", "webkit_python_tests": "f8d164bc0c1046a10dc846aea592caeabd385338", "webkit_unit_tests": "33e966eac0c035ea183e42410bc09c685ca322e3", "wm_unittests": "3212499cdfc528a4c7998a04f7051beaf6055a8e", "wtf_unittests": "d5d4d4eea24a508eae5886b130904a60162d667e", "zucchini_unittests": "0f001447241eeade59673bce9625636fb49e0c0a"} find isolated tests

Blamelist:

  1. Yves Gerey (yvesgohnoyoudont@google.com)
  2. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  3. Clemens Arbesser (arbesserohnoyoudont@google.com)
  4. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  5. David 'Digit' Turner (digitohnoyoudont@google.com)
  6. edchin (edchinohnoyoudont@chromium.org)
  7. Koji Ishii (kojiiohnoyoudont@chromium.org)
  8. Erik Chen (erikchenohnoyoudont@chromium.org)
  9. arthursonzogni (arthursonzogniohnoyoudont@chromium.org)

Timing:

Create Thursday, 15-Nov-18 16:31:33 UTC
Start Thursday, 15-Nov-18 16:32:21 UTC
End Thursday, 15-Nov-18 17:00:49 UTC
Pending 48 secs
Execution 28 mins 27 secs

All Changes:

  1. Revert "Disable all WebRtcBrowserTests on ASan"

    Changed by Yves Gerey - yvesgohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 14:56:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8700ed14ef6030b990233f03b729c1b60f81bc43

    Comments

    Revert "Disable all WebRtcBrowserTests on ASan"
    
    This reverts commit 6d582d186fc5763adc328767d84a39d1b0e98376.
    
    Reason for revert: The leaks are not caused by WebRTC code,
                       but merely revealed by the tests.
    We re-enable those tests: either the leaks have been fixed, or we'll add
    a suppression (less drastic than muting the whole WebRTC test suite).
    
    Original change's description:
    >Disable all WebRtcBrowserTests on ASan
    >
    >Many of these tests flakily leak and thus fail on ASan bots.
    >
    >TBR=phoglund@chromium.org
    >
    >Bug: 898546
    >Change-Id: Icd3cc5dc3a46d0194c807c27b66f7eb902b35794
    >Reviewed-on: https://chromium-review.googlesource.com/c/1299161
    >Reviewed-by: Marc Treib <treib@chromium.org>
    >Commit-Queue: Marc Treib <treib@chromium.org>
    >Cr-Commit-Position: refs/heads/master@{#602745}
    
    Bug: chromium:898546
    Change-Id: Idccff7827e6381e20060f7116cac75ee2b25018f
    Reviewed-on: https://chromium-review.googlesource.com/c/1337626
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Yves Gerey <yvesg@google.com>
    Cr-Commit-Position: refs/heads/master@{#608366}

    Changed files

    • chrome/browser/media/webrtc/webrtc_browsertest.cc
  2. [css-properties-values-api] Validate var() fallbacks.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:56:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 67e449b925663f3b91e0f588da99178bf696fbdf

    Comments

    [css-properties-values-api] Validate var() fallbacks.
    
    According to a recent spec edit, any fallback in a var()-reference must
    match the syntax of the referenced property, otherwise the var()-reference
    is invalid. This applies even if the fallback is not used.
    
    To implement this, ResolveFallback now returns kNone/kFail/kSuccess instead
    of a bool. This is necessary, because the kNone case may be both an error
    state and a success state, depending on whether the fallback is being
    used or not, hence a plain bool is not sufficient.
    
    R=futhark@chromium.org
    
    Bug: 641877
    Change-Id: I951eef6335bf1cd4064d59959d73ec4fa39c9ee0
    Reviewed-on: https://chromium-review.googlesource.com/c/1335576
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608365}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/var-reference-registered-properties.html
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.cc
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver.h
  3. [Autofill Assistant] Removed the link to the chrome settings from the expanded payment request.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 14:45:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 911038cc9bd6438ab2406664c5f00c6a77c90437

    Comments

    [Autofill Assistant] Removed the link to the chrome settings from the expanded payment request.
    
    It takes up space and is redundant, since the user can access more specific settings pages by tapping the edit/add buttons next to the payment methods and contact details.
    
    Bug: 806868
    Change-Id: I0ac076930dc605102931bfe2c7d958aa4ad36c3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1337503
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#608364}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
  4. [iOS] Fix SteadyView highlighted state shape

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:39:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33d9de49a9a8bf7105b7dc2bffb70c701355e6c1

    Comments

    [iOS] Fix SteadyView highlighted state shape
    
    This CL changes the state of the highlighted state of the location bar,
    to have it shaped like a pill, as the non-highlighted state.
    
    Bug: 905630
    Change-Id: Ieeb5180d514b928c158ed2cd4f5b39cfde2b7aec
    Reviewed-on: https://chromium-review.googlesource.com/c/1337500
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608363}

    Changed files

    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
  5. base/trace_event: Make TRACE_EVENTXX call sites smaller.

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Thursday, 15-Nov-18 14:37:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc57a1780b06d0444fde693de8c733f8247ece83

    Comments

    base/trace_event: Make TRACE_EVENTXX call sites smaller.
    
    Replaces two function calls by one at each trace macro call
    site. This should save about 12 kiB in 32-bit ARM libmonochrome.so
    
    BUG=898794
    R=primiano@chromium.org,oysteine@chromium.org,alexiln@chromium.org
    
    Change-Id: Icf64644355b584dd5ff9910920df02930344f837
    Reviewed-on: https://chromium-review.googlesource.com/c/1301913
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: oysteine <oysteine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608362}

    Changed files

    • base/trace_event/trace_event.h
    • base/trace_event/trace_log.cc
    • base/trace_event/trace_log.h
  6. [ios] Remove ExternalSearchProvider

    Changed by edchin - edchinohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:37:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2677c981faa69fd1b590fc6592ac1357f567aa81

    Comments

    [ios] Remove ExternalSearchProvider
    
    External Search was added for an app that no longer exists. This
    feature has never been enabled. This CL cleans up dead code.
    
    Bug: 904616
    Change-Id: Id7df06097ac2c5a598e7bc2f0f91657481de4a9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1332689
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608361}

    Changed files

    • ios/chrome/browser/BUILD.gn
    • ios/chrome/browser/about_flags.mm
    • ios/chrome/browser/ios_chrome_flag_descriptions.cc
    • ios/chrome/browser/ios_chrome_flag_descriptions.h
    • ios/chrome/browser/providers/BUILD.gn
    • ios/chrome/browser/providers/chromium_browser_provider.h
    • ios/chrome/browser/providers/chromium_browser_provider.mm
    • ios/chrome/browser/ui/BUILD.gn
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/commands/BUILD.gn
    • ios/chrome/browser/ui/commands/browser_commands.h
    • ios/chrome/browser/ui/commands/external_search_commands.h
    • ios/chrome/browser/ui/external_search/BUILD.gn
    • ios/chrome/browser/ui/external_search/external_search_coordinator.h
    • ios/chrome/browser/ui/external_search/external_search_coordinator.mm
    • ios/chrome/browser/ui/external_search/external_search_coordinator_unittest.mm
    • ios/chrome/browser/ui/external_search/external_search_mediator.h
    • ios/chrome/browser/ui/external_search/external_search_mediator.mm
    • ios/chrome/browser/ui/external_search/external_search_mediator_unittest.mm
    • ios/chrome/browser/ui/external_search/features.cc
    • ios/chrome/browser/ui/external_search/features.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/BUILD.gn
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.h
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_delegate.mm
    • ios/chrome/browser/ui/toolbar/keyboard_assist/toolbar_assistive_keyboard_views_utils.mm
    • ios/chrome/test/BUILD.gn
    • ios/public/provider/chrome/browser/BUILD.gn
    • ios/public/provider/chrome/browser/chrome_browser_provider.h
    • ios/public/provider/chrome/browser/chrome_browser_provider.mm
    • ios/public/provider/chrome/browser/external_search/BUILD.gn
    • ios/public/provider/chrome/browser/external_search/external_search_provider.h
    • ios/public/provider/chrome/browser/external_search/external_search_provider.mm
    • ios/public/provider/chrome/browser/external_search/test_external_search_provider.h
    • ios/public/provider/chrome/browser/external_search/test_external_search_provider.mm
    • ios/public/provider/chrome/browser/test_chrome_browser_provider.h
    • ios/public/provider/chrome/browser/test_chrome_browser_provider.mm
  7. [LayoutNG] Enable fragment caching when BFC block offset changes

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:32:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c1ee8a95439ceb6018ca296858ed417bd5c500

    Comments

    [LayoutNG] Enable fragment caching when BFC block offset changes
    
    This patch enables fragment caching when BFC block offset
    changes, as long as 1) either the cached or new doesn't have
    floats, and 2) the cached fragment doesn't propagate OOF
    objects. The latter may not be needed, but helps to simplify.
    
    Minor but mostly positive improvements are seen in pinpoint:
    blink_perf.layout https://pinpoint-dot-chromeperf.appspot.com/job/13a7a7f7e40000
    loading.desktop https://pinpoint-dot-chromeperf.appspot.com/job/17a7a7f7e40000
    
    2 block fragmentation tests fail with this change that this
    change is not enabled for block fragmentation for now.
    * virtual/layout_ng_experimental/fast/multicol/balance-breakafter-before-nested-block.html
    * virtual/layout_ng_experimental/fast/multicol/dynamic/spanner-becomes-regular-block.html
    
    Bug: 635619
    Change-Id: I46826b45defd556c8dadbf861fb1bbf61c5ae658
    Reviewed-on: https://chromium-review.googlesource.com/c/1335072
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608360}

    Changed files

    • third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
    • third_party/blink/renderer/core/layout/ng/ng_constraint_space.cc
    • third_party/blink/renderer/core/layout/ng/ng_constraint_space.h
    • third_party/blink/renderer/core/layout/ng/ng_layout_result.cc
    • third_party/blink/renderer/core/layout/ng/ng_layout_result.h
  8. macOS: Use system Xcode on 10.14.

    Changed by Erik Chen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:31:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2619f3b0f4807321f18065a469c2c371b006bb4

    Comments

    macOS: Use system Xcode on 10.14.
    
    A previous CL: https://chromium-review.googlesource.com/c/1333877 commented out
    an assert to allow default fallback to the local toolchain, but failed to update
    the subsequent conditional correctly.
    
    Bug: 904400
    Change-Id: I8d299e60645db4821dbb79c45b57ac1c01767d57
    Reviewed-on: https://chromium-review.googlesource.com/c/1335949
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608359}

    Changed files

    • build_overrides/build.gni
  9. Disable one flaky PaymentRequestPaymentAppTest

    Changed by arthursonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Thursday, 15-Nov-18 14:30:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bf868aa6237a473dfb1910112805f5cc3f671d4

    Comments

    Disable one flaky PaymentRequestPaymentAppTest
    
    Flaky test:
    org.chromium.chrome.browser.payments.PaymentRequestPaymentAppTest#testPayViaDelayedSlowBobPay
    
    TBR=rouslan@chromium.org
    
    Bug: 769851
    Change-Id: Ic9ea6a0ddd72055145fb2e738744f0d60a13df40
    Reviewed-on: https://chromium-review.googlesource.com/c/1337502
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608358}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestPaymentAppTest.java