Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 Build 29318 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision77b7b35987d9420138ebc3fcb7d24d786bf5549c
Got Revision77b7b35987d9420138ebc3fcb7d24d786bf5549c

Execution:

Steps and Logfiles:

Show:
  1. ( 628 ms ) setup_build
    running recipe: "chromium"
  2. ( 503 ms ) report builders
     
    running tester 'Win10 Tests x64' on master 'chromium.win'
  3. ( 6 secs ) taskkill
  4. ( 8 mins 47 secs ) bot_update
    [65GB/299GB used (21%)]
  5. ( 2 secs ) swarming.py --version
    0.13
  6. ( 59 secs ) gclient runhooks
  7. ( 777 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 502 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 8 secs ) build directory
  10. ( 2 mins 40 secs ) extract build
  11. ( 522 ms ) find isolated tests
  12. ( 1 mins 38 secs ) test_installer
  13. ( 2 secs ) wait for tasks
  14. ( 4 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:11.579774
  15. ( 2 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  16. ( 2 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  17. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  18. ( 2 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  19. ( 2 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  20. ( 2 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  21. ( 2 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  22. ( 2 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  23. ( 2 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  24. ( 2 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 57s
  25. ( 2 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:10.512262
  26. ( 2 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  27. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  28. ( 3 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  29. ( 2 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  30. ( 2 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  31. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  32. ( 2 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  33. ( 2 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  34. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  35. ( 2 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 43s
  36. ( 2 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  37. ( 2 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  38. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 36s
  39. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  40. ( 2 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  41. ( 2 secs ) gcp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  42. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  43. ( 2 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  44. ( 2 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  45. ( 2 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  46. ( 2 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  47. ( 2 secs ) network_service_components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 45s
  48. ( 2 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  49. ( 3 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  50. ( 2 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  51. ( 2 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:34.852038
  52. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 36s
  53. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  54. ( 2 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  55. ( 4 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  56. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  57. ( 4 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  58. ( 2 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  59. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  60. ( 4 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 50s
  61. ( 2 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  62. ( 2 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  63. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  64. ( 2 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  65. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  66. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  67. ( 2 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  68. ( 5 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:10.427476
  69. ( 2 secs ) webui_polymer2_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:08.473787
  70. ( 2 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  71. ( 2 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  72. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  73. ( 2 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  74. ( 2 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  75. ( 2 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  76. ( 2 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  77. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  78. ( 4 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:26.514730
  79. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  80. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  81. ( 2 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  82. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  83. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  84. ( 2 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  85. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  86. ( 2 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  87. ( 2 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  88. ( 2 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  89. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  90. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  91. ( 2 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  92. ( 3 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  93. ( 2 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  94. ( 2 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  95. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  96. ( 2 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  97. ( 2 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  98. ( 3 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 58s
  99. ( 3 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  100. ( 2 secs ) network_service_extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:25.085124
  101. ( 3 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  102. ( 1 secs ) wait for tasks (2)
  103. ( 2 secs ) mini_installer_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:19.216817
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  104. ( 2 secs ) sync_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:09:12.747823
  105. ( 4 secs ) network_service_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:11:52.685857 (shard #0)
    Min shard duration: 0:10:53.336463 (shard #1)
  106. ( 7 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:44.297869
  107. ( 8 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:14.764777
  108. ( 5 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:14.144777
  109. ( 17 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:26.810304
  110. ( 2 secs ) interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:10:19.477577 (shard #2)
    Min shard duration: 0:08:52.576728 (shard #1)
  111. ( 2 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:40.056838
  112. ( 1 secs ) wait for tasks (3)
  113. ( 2 secs ) network_service_interactive_ui_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:11:52.150794 (shard #2)
    Min shard duration: 0:09:33.582443 (shard #1)
  114. ( 1 secs ) wait for tasks (4)
  115. ( 8 secs ) network_service_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:15:28.949408 (shard #2)
    Min shard duration: 0:13:23.122020 (shard #9)
  116. ( 4 mins 12 secs ) wait for tasks (5)
  117. ( 9 secs ) browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:20:30.343173 (shard #2)
    Min shard duration: 0:16:33.922531 (shard #4)
  118. ( 3 secs ) content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:18:55.879123
  119. ( 34 secs ) webui_polymer2_browser_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:21:50.805567 (shard #3)
    Min shard duration: 0:05:30.746064 (shard #1)
  120. ( 202 ms ) Tests statistics
     
    Stats
    Total shards: 133
    Total runtime: 9:18:18.757000
     
  121. ( 1 secs ) process_dumps
  122. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-c-wl5t" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541784932084389, "id": "8930315039013510400", "project": "chromium", "tags": ["builder:Win10 Tests x64", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/77b7b35987d9420138ebc3fcb7d24d786bf5549c", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder", "parent_buildnumber:58668", "scheduler_invocation_id:9095745101429066736", "scheduler_job_id:chromium/Win10 Tests x64", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 Tests x64" setup_build
buildnumber 29318 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" setup_build
parent_got_revision_cp "refs/heads/master@{#606866}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.286@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" setup_build
swarm_hashes {"accessibility_unittests": "61cfa33d02141f1029ae7c04b4f83d2205442d16", "angle_unittests": "6be8f1942f7fe2473e9c4a9cf785e03e6f0f7edb", "app_shell_unittests": "4c0c12f7fe2e2fd765f9c93811c44a6e4cfdaedd", "aura_unittests": "3c8a68a1c2a96bdf80a7235b064c1655975b179b", "base_unittests": "ff13545ede0d743e78f19ca1988562e6796c012f", "blink_common_unittests": "60c74f5cd8530b715f263fc2b420d406e89da76c", "blink_fuzzer_unittests": "4f54c7d0061f99c240946cfe8b2f0d8eae981af0", "blink_heap_unittests": "43b4217442c625dbe37e83977310ce073ba51602", "blink_platform_unittests": "56205e95d4b08144b83b09208c8a1cc7401e41d1", "boringssl_crypto_tests": "15e830018ba9cc39a135abed18712755511e8dbe", "boringssl_ssl_tests": "17c2b7dbebdea7488f14f07a43abcb6347253ce5", "browser_tests": "39bc32ef0615967e9594b471d8132b596fce5a6b", "cacheinvalidation_unittests": "fb1a5a0ca563571f9f09484b13111173981b7838", "capture_unittests": "30ba0eeca1d8a399492dbd7e43b59b0c013fbf9c", "cast_unittests": "704be5be226b95fefe5cf4452f4fdc90fc639602", "cc_unittests": "6d7d9e7ebb563966f54a34e0f5e5e91fd77fa59f", "chrome_app_unittests": "461ff8fe6afe57d663ba9f5c58fd8caab90e3137", "chrome_cleaner_unittests": "82fd61ea4ccf902826db487319dd30fb32221bdc", "chrome_elf_import_unittests": "1a052867b461a6a6b25b00702eb8321651c17d37", "chrome_elf_unittests": "f10fb50bca4c279c5c54afba464df138f4617d28", "chromedriver_py_tests": "0b4e5b07591f19e73feff809b0c4e9cc2f78aa23", "chromedriver_replay_unittests": "608c0c89118b4704de3239f30dc69839a37605ef", "chromedriver_unittests": "32eeb7e474873584b361ea8f0274aa14e5a3e0ed", "components_browsertests": "40bf79c5484f81fd3e79f4d78c7923d083cf063f", "components_perftests": "7220e8aed6a2e427c15ceb1b90199df51f1c9c1c", "components_unittests": "0c3ba4e52b94e9cfa5a9ba2e4fb10abd4ed71524", "compositor_unittests": "8356bd7ac9af8f6d0def7e5d57b3f4c8e4f504f7", "content_browsertests": "d855e612181befaa101a18ddf5069e1cb110f1c7", "content_shell_crash_test": "0c2c94a71178d32de7727cf5f605aa076d0a4d1e", "content_unittests": "c255459d51c131ff235fbb88b67c89c187fc3da9", "courgette_unittests": "e4c82b31004494fec63f50cfe6d2be6bce88c6b6", "crashpad_tests": "545271de1e95238db3ea3236759d4afcb7829800", "cronet_tests": "48b2556065efef4fe8e9302c2d73edb2ced4c0e2", "cronet_unittests": "d5a57e903257d454d6e729fea98d95487fb7c6a0", "crypto_unittests": "35071834c10271a3a95e52c16e6248f2e728b7a0", "device_unittests": "ced009d4acb7c1f9e40d9191f36ae454b7c0ab3f", "display_unittests": "1f1d47c7c89824ae4f342b604fd4b1cb6f79c06f", "elevation_service_unittests": "721db3f5092c302995dc370899bf1d884712def9", "events_unittests": "8777280c7597270cb6a2279f3681dd3c4602fa20", "extensions_browsertests": "2b8b3e8c7d2eb0201f542b90b5ed2b6f4b0bf105", "extensions_unittests": "95d177df79d258601106095e35adaf5f24dab68c", "filesystem_service_unittests": "dc83bc9e907b7d3b46d39da6d78f85e9499c6845", "gcm_unit_tests": "c09d8941c1af5a7c7594f5422d6c39a98414fbeb", "gcp_unittests": "2706bbf9819ba68e21dbaff44623c07db22af951", "gfx_unittests": "fa9b872632794a5542b524ef5cf1648a85530558", "gin_unittests": "9de80e599b07f660439382dd2cdbd971047bd4c9", "google_apis_unittests": "8efc241cc47d9ef1fa9b5a142f0239174d23ea9e", "gpu_unittests": "a3dbf168adec8ca806f785e34124e22ca5aaffa4", "headless_browsertests": "823d04aca18e257851281b7469007b77f1e4692d", "headless_unittests": "83cafb74b0b5699cec27af2a2843754a11ec8638", "install_static_unittests": "3c23eb52a9e9e3e6c29bb48c62e99be0f3ab2669", "installer_util_unittests": "3c44fe6d90eb0aeda19a95f66d173e1a698c3ce0", "interactive_ui_tests": "35d7b96a374bdf0d0b19830cf2ce60e641d016c7", "ipc_tests": "bf757584d1e8283f5e87fca338e8b1163ae925e1", "jingle_unittests": "ba0d0672753fcf91a124aafe1bca8bb7e443bd37", "latency_unittests": "0656a788be353c3a25dba817a87b477ae0307ab1", "leveldb_service_unittests": "9130ad574453ee323754625a54849c159434f7c3", "libjingle_xmpp_unittests": "6ba269979adb48ccc34a948098de7141eddbf687", "media_blink_unittests": "e4bd107f45b89dc0b1f2f4ea3a89c2c55daecc35", "media_service_unittests": "09d134f7f73e7b807462669cacd712bc12199d34", "media_unittests": "335c6447552e317748af8784f97ee81a6c613813", "message_center_unittests": "f1242d7b2a2f99f720c3bc5e040b1dad914385ba", "metrics_python_tests": "0d27fb0b8e2f15ad925754ea764f4a676ce1782b", "midi_unittests": "211cb4ea6396812a5e42d33a96590575568e0d63", "mini_installer_tests": "fa9dc72f7c0aff29e5cbfbd0475f70471d9a1f5c", "mojo_core_unittests": "cc2a95c2dd43602ef02d193ee6700d3023ae9b94", "mojo_unittests": "fadc26c562aebef2a6633a6fc788fddd9ec93474", "nacl_loader_unittests": "3a3da4ef8ee97052a7f9cffa1b869d7060c15584", "native_theme_unittests": "eaed93790419976f1d9925586cb5062007ae8167", "net_unittests": "d402c77f09f329bc90db96c6be4ca42ccd5e1ed7", "notification_helper_unittests": "dbcb3b14a550dc030cc5568c673bac9654071c6e", "pdf_unittests": "26db84b2f7a772dcae24c5d7504b7a70f5bb8874", "ppapi_unittests": "ff0abd274af4a6c9e16a3ba5e3d50423b2b10e1e", "printing_unittests": "fed098a2f02b26bf6f448f3ab6d4da1daf4adb26", "remoting_unittests": "a9a97874911ac80de7f99c5b911c5a224e85b919", "sbox_integration_tests": "ac59c6985002b69b0220a86c36533be74955edfd", "sbox_unittests": "6983713dabc4a780d4609fca993726bf9bd93f10", "sbox_validation_tests": "0babb777bb1f9c0b8955fa6821d71356c21f5e6f", "service_manager_unittests": "1dab0aea56895ff15138b3d099e0f0869c453651", "services_unittests": "b2e244de92d4f536ce031bfb3f29b5ca2645deae", "setup_unittests": "55d7186c69e13e2dc0ae3ba3cc455c536d64f34e", "shell_dialogs_unittests": "212bb34b4c65c0718eebc31218a118674166ad7a", "skia_unittests": "7a8ae7ba626365701d1da61195b3d9d9eddb20d5", "snapshot_unittests": "df881e487ffb5a1575c7382dd51490cd99c191d5", "sql_unittests": "40b94a1146dc3e3615247788f4958ce372ff69ff", "storage_unittests": "74dcb0bc959500b3603ccff7a382e39f6f2b8b40", "sync_integration_tests": "86f4dd2fcb2266997fdcc08a10b71332c35820fe", "telemetry_gpu_unittests": "c5fc6377b7376ad35fd90a41e576205d9a6e1b4c", "telemetry_perf_unittests": "a3c964fa2657c4d2c645e02c5085bddb12035573", "telemetry_unittests": "fb5b18fdddf162e083d2a4f3e18a8689ff936fb5", "traffic_annotation_auditor_unittests": "55135dddef9fd70d10fc627d19780fe4b4fcac3e", "ui_base_unittests": "1e89a5c06b04b1d415965361dcdf278338582800", "ui_touch_selection_unittests": "c2f7c3ea3b75c92866814cba0081cde276bb6d6e", "unit_tests": "07f9321f343be47080404fe8225643490640c71f", "url_unittests": "0a5f9e481283cc68ecc074077fc1747c512627db", "views_perftests": "ec62db326aa34b390a538be718c3fa5cdfd19982", "views_unittests": "ce0ee119dce8fae77ca65db1e73781f24bdba5b5", "viz_unittests": "c52b046cfc6170276817c61d12f4fa5f3cbda1fa", "vr_common_unittests": "a80373fe0d73cd0705abb65a4d7cc448ca2a8232", "vr_pixeltests": "0d21d68ab2f0b1c2659510110e67231f7e3817f3", "webkit_python_tests": "55a1a7399f9c0ce591cd8b438847677aa63099c1", "webkit_unit_tests": "d144603dc55d04eb8a8d0a76afda2586e49fd7bf", "wm_unittests": "c989ded810353b00e928aae8342645ea9efe8c51", "wtf_unittests": "9d254e120d3622951218accba0a8f60e374a5147", "zucchini_unittests": "ea1e5eef6acf7329d3c5b7c031c7194ecb9e906e"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "77b7b35987d9420138ebc3fcb7d24d786bf5549c" bot_update
got_revision_cp "refs/heads/master@{#606866}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {"accessibility_unittests": "61cfa33d02141f1029ae7c04b4f83d2205442d16", "angle_unittests": "6be8f1942f7fe2473e9c4a9cf785e03e6f0f7edb", "app_shell_unittests": "4c0c12f7fe2e2fd765f9c93811c44a6e4cfdaedd", "aura_unittests": "3c8a68a1c2a96bdf80a7235b064c1655975b179b", "base_unittests": "ff13545ede0d743e78f19ca1988562e6796c012f", "blink_common_unittests": "60c74f5cd8530b715f263fc2b420d406e89da76c", "blink_fuzzer_unittests": "4f54c7d0061f99c240946cfe8b2f0d8eae981af0", "blink_heap_unittests": "43b4217442c625dbe37e83977310ce073ba51602", "blink_platform_unittests": "56205e95d4b08144b83b09208c8a1cc7401e41d1", "boringssl_crypto_tests": "15e830018ba9cc39a135abed18712755511e8dbe", "boringssl_ssl_tests": "17c2b7dbebdea7488f14f07a43abcb6347253ce5", "browser_tests": "39bc32ef0615967e9594b471d8132b596fce5a6b", "cacheinvalidation_unittests": "fb1a5a0ca563571f9f09484b13111173981b7838", "capture_unittests": "30ba0eeca1d8a399492dbd7e43b59b0c013fbf9c", "cast_unittests": "704be5be226b95fefe5cf4452f4fdc90fc639602", "cc_unittests": "6d7d9e7ebb563966f54a34e0f5e5e91fd77fa59f", "chrome_app_unittests": "461ff8fe6afe57d663ba9f5c58fd8caab90e3137", "chrome_cleaner_unittests": "82fd61ea4ccf902826db487319dd30fb32221bdc", "chrome_elf_import_unittests": "1a052867b461a6a6b25b00702eb8321651c17d37", "chrome_elf_unittests": "f10fb50bca4c279c5c54afba464df138f4617d28", "chromedriver_py_tests": "0b4e5b07591f19e73feff809b0c4e9cc2f78aa23", "chromedriver_replay_unittests": "608c0c89118b4704de3239f30dc69839a37605ef", "chromedriver_unittests": "32eeb7e474873584b361ea8f0274aa14e5a3e0ed", "components_browsertests": "40bf79c5484f81fd3e79f4d78c7923d083cf063f", "components_perftests": "7220e8aed6a2e427c15ceb1b90199df51f1c9c1c", "components_unittests": "0c3ba4e52b94e9cfa5a9ba2e4fb10abd4ed71524", "compositor_unittests": "8356bd7ac9af8f6d0def7e5d57b3f4c8e4f504f7", "content_browsertests": "d855e612181befaa101a18ddf5069e1cb110f1c7", "content_shell_crash_test": "0c2c94a71178d32de7727cf5f605aa076d0a4d1e", "content_unittests": "c255459d51c131ff235fbb88b67c89c187fc3da9", "courgette_unittests": "e4c82b31004494fec63f50cfe6d2be6bce88c6b6", "crashpad_tests": "545271de1e95238db3ea3236759d4afcb7829800", "cronet_tests": "48b2556065efef4fe8e9302c2d73edb2ced4c0e2", "cronet_unittests": "d5a57e903257d454d6e729fea98d95487fb7c6a0", "crypto_unittests": "35071834c10271a3a95e52c16e6248f2e728b7a0", "device_unittests": "ced009d4acb7c1f9e40d9191f36ae454b7c0ab3f", "display_unittests": "1f1d47c7c89824ae4f342b604fd4b1cb6f79c06f", "elevation_service_unittests": "721db3f5092c302995dc370899bf1d884712def9", "events_unittests": "8777280c7597270cb6a2279f3681dd3c4602fa20", "extensions_browsertests": "2b8b3e8c7d2eb0201f542b90b5ed2b6f4b0bf105", "extensions_unittests": "95d177df79d258601106095e35adaf5f24dab68c", "filesystem_service_unittests": "dc83bc9e907b7d3b46d39da6d78f85e9499c6845", "gcm_unit_tests": "c09d8941c1af5a7c7594f5422d6c39a98414fbeb", "gcp_unittests": "2706bbf9819ba68e21dbaff44623c07db22af951", "gfx_unittests": "fa9b872632794a5542b524ef5cf1648a85530558", "gin_unittests": "9de80e599b07f660439382dd2cdbd971047bd4c9", "google_apis_unittests": "8efc241cc47d9ef1fa9b5a142f0239174d23ea9e", "gpu_unittests": "a3dbf168adec8ca806f785e34124e22ca5aaffa4", "headless_browsertests": "823d04aca18e257851281b7469007b77f1e4692d", "headless_unittests": "83cafb74b0b5699cec27af2a2843754a11ec8638", "install_static_unittests": "3c23eb52a9e9e3e6c29bb48c62e99be0f3ab2669", "installer_util_unittests": "3c44fe6d90eb0aeda19a95f66d173e1a698c3ce0", "interactive_ui_tests": "35d7b96a374bdf0d0b19830cf2ce60e641d016c7", "ipc_tests": "bf757584d1e8283f5e87fca338e8b1163ae925e1", "jingle_unittests": "ba0d0672753fcf91a124aafe1bca8bb7e443bd37", "latency_unittests": "0656a788be353c3a25dba817a87b477ae0307ab1", "leveldb_service_unittests": "9130ad574453ee323754625a54849c159434f7c3", "libjingle_xmpp_unittests": "6ba269979adb48ccc34a948098de7141eddbf687", "media_blink_unittests": "e4bd107f45b89dc0b1f2f4ea3a89c2c55daecc35", "media_service_unittests": "09d134f7f73e7b807462669cacd712bc12199d34", "media_unittests": "335c6447552e317748af8784f97ee81a6c613813", "message_center_unittests": "f1242d7b2a2f99f720c3bc5e040b1dad914385ba", "metrics_python_tests": "0d27fb0b8e2f15ad925754ea764f4a676ce1782b", "midi_unittests": "211cb4ea6396812a5e42d33a96590575568e0d63", "mini_installer_tests": "fa9dc72f7c0aff29e5cbfbd0475f70471d9a1f5c", "mojo_core_unittests": "cc2a95c2dd43602ef02d193ee6700d3023ae9b94", "mojo_unittests": "fadc26c562aebef2a6633a6fc788fddd9ec93474", "nacl_loader_unittests": "3a3da4ef8ee97052a7f9cffa1b869d7060c15584", "native_theme_unittests": "eaed93790419976f1d9925586cb5062007ae8167", "net_unittests": "d402c77f09f329bc90db96c6be4ca42ccd5e1ed7", "notification_helper_unittests": "dbcb3b14a550dc030cc5568c673bac9654071c6e", "pdf_unittests": "26db84b2f7a772dcae24c5d7504b7a70f5bb8874", "ppapi_unittests": "ff0abd274af4a6c9e16a3ba5e3d50423b2b10e1e", "printing_unittests": "fed098a2f02b26bf6f448f3ab6d4da1daf4adb26", "remoting_unittests": "a9a97874911ac80de7f99c5b911c5a224e85b919", "sbox_integration_tests": "ac59c6985002b69b0220a86c36533be74955edfd", "sbox_unittests": "6983713dabc4a780d4609fca993726bf9bd93f10", "sbox_validation_tests": "0babb777bb1f9c0b8955fa6821d71356c21f5e6f", "service_manager_unittests": "1dab0aea56895ff15138b3d099e0f0869c453651", "services_unittests": "b2e244de92d4f536ce031bfb3f29b5ca2645deae", "setup_unittests": "55d7186c69e13e2dc0ae3ba3cc455c536d64f34e", "shell_dialogs_unittests": "212bb34b4c65c0718eebc31218a118674166ad7a", "skia_unittests": "7a8ae7ba626365701d1da61195b3d9d9eddb20d5", "snapshot_unittests": "df881e487ffb5a1575c7382dd51490cd99c191d5", "sql_unittests": "40b94a1146dc3e3615247788f4958ce372ff69ff", "storage_unittests": "74dcb0bc959500b3603ccff7a382e39f6f2b8b40", "sync_integration_tests": "86f4dd2fcb2266997fdcc08a10b71332c35820fe", "telemetry_gpu_unittests": "c5fc6377b7376ad35fd90a41e576205d9a6e1b4c", "telemetry_perf_unittests": "a3c964fa2657c4d2c645e02c5085bddb12035573", "telemetry_unittests": "fb5b18fdddf162e083d2a4f3e18a8689ff936fb5", "traffic_annotation_auditor_unittests": "55135dddef9fd70d10fc627d19780fe4b4fcac3e", "ui_base_unittests": "1e89a5c06b04b1d415965361dcdf278338582800", "ui_touch_selection_unittests": "c2f7c3ea3b75c92866814cba0081cde276bb6d6e", "unit_tests": "07f9321f343be47080404fe8225643490640c71f", "url_unittests": "0a5f9e481283cc68ecc074077fc1747c512627db", "views_perftests": "ec62db326aa34b390a538be718c3fa5cdfd19982", "views_unittests": "ce0ee119dce8fae77ca65db1e73781f24bdba5b5", "viz_unittests": "c52b046cfc6170276817c61d12f4fa5f3cbda1fa", "vr_common_unittests": "a80373fe0d73cd0705abb65a4d7cc448ca2a8232", "vr_pixeltests": "0d21d68ab2f0b1c2659510110e67231f7e3817f3", "webkit_python_tests": "55a1a7399f9c0ce591cd8b438847677aa63099c1", "webkit_unit_tests": "d144603dc55d04eb8a8d0a76afda2586e49fd7bf", "wm_unittests": "c989ded810353b00e928aae8342645ea9efe8c51", "wtf_unittests": "9d254e120d3622951218accba0a8f60e374a5147", "zucchini_unittests": "ea1e5eef6acf7329d3c5b7c031c7194ecb9e906e"} find isolated tests

Blamelist:

  1. David 'Digit' Turner (digitohnoyoudont@google.com)
  2. James Hawkins (jhawkinsohnoyoudont@chromium.org)
  3. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  4. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. Nico Weber (thakisohnoyoudont@chromium.org)
  9. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  10. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  11. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  12. Eugene But (eugenebutohnoyoudont@google.com)
  13. Eugene But (eugenebutohnoyoudont@google.com)
  14. Pavel Shmakov (pshmakovohnoyoudont@google.com)
  15. Tim Volodine (timvolodineohnoyoudont@chromium.org)
  16. Rayan Kanso (rayankansohnoyoudont@google.com)
  17. David Jean (djeanohnoyoudont@google.com)
  18. Aaron Krajeski (aaronhkohnoyoudont@google.com)
  19. Marc Treib (treibohnoyoudont@chromium.org)
  20. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  21. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  22. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  23. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  24. Lukasz Suder (lsuderohnoyoudont@google.com)
  25. Greg Thompson (grtohnoyoudont@chromium.org)
  26. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  27. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  28. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  29. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  30. Ioana Pandele (ioanapohnoyoudont@chromium.org)
  31. Sam Maier (smaierohnoyoudont@chromium.org)
  32. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  33. Rohit Rao (rohitraoohnoyoudont@chromium.org)
  34. Sigurdur Asgeirsson (siggiohnoyoudont@chromium.org)
  35. Mike Reed (reedohnoyoudont@google.com)
  36. Marc Treib (treibohnoyoudont@chromium.org)
  37. Marc Treib (treibohnoyoudont@chromium.org)
  38. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  39. Leonard Grey (lgreyohnoyoudont@chromium.org)
  40. Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
  41. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  42. Mark Cogan (marqohnoyoudont@google.com)
  43. gogerald (gogeraldohnoyoudont@google.com)
  44. Clemens Arbesser (arbesserohnoyoudont@google.com)
  45. Corentin Wallez (cwallezohnoyoudont@chromium.org)
  46. Xianzhu Wang (wangxianzhuohnoyoudont@chromium.org)
  47. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  48. Yuki Shiino (yukishiinoohnoyoudont@chromium.org)
  49. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  50. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  51. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  52. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  53. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  54. Michael Lippautz (mlippautzohnoyoudont@chromium.org)
  55. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  56. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  57. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  58. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  59. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  60. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  61. Colin Blundell (blundellohnoyoudont@chromium.org)
  62. Lukasz Suder (lsuderohnoyoudont@google.com)
  63. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  64. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  65. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  66. Clemens Arbesser (arbesserohnoyoudont@google.com)
  67. Benoît Lizé (lizebohnoyoudont@chromium.org)
  68. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  69. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  70. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  71. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  72. Sheng-Hao Tsao (shenghaoohnoyoudont@google.com)
  73. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  74. Yi Su (mrsuyiohnoyoudont@chromium.org)
  75. Arthur Sonzogni (arthursonzogniohnoyoudont@chromium.org)
  76. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  77. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  78. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  79. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  80. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  81. Koji Ishii (kojiiohnoyoudont@chromium.org)
  82. Balazs Engedy (engedyohnoyoudont@chromium.org)
  83. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  84. Colin Blundell (blundellohnoyoudont@chromium.org)
  85. 3su6n15k.default@developer.gserviceaccount.com (3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com)
  86. Balazs Engedy (engedyohnoyoudont@chromium.org)
  87. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  88. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  89. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  90. Peng Huang (penghuangohnoyoudont@chromium.org)
  91. Yi Su (mrsuyiohnoyoudont@chromium.org)
  92. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  93. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  94. David Jean (djeanohnoyoudont@google.com)
  95. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  96. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  97. Jia (jiamengohnoyoudont@chromium.org)
  98. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  99. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  100. Nick Harper (nharperohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Friday, 09-Nov-18 17:35:32 UTC
Start Friday, 09-Nov-18 17:35:39 UTC
End Friday, 09-Nov-18 18:14:56 UTC
Pending 7 secs
Execution 39 mins 16 secs

All Changes:

  1. Android: Fix resource extraction from splits for Hebrew and others.

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:32:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77b7b35987d9420138ebc3fcb7d24d786bf5549c

    Comments

    Android: Fix resource extraction from splits for Hebrew and others.
    
    This CL fixes a bug in the logic used to locate locale .pak files
    inside bundle splits. The reason for the bug is that bundletool
    wants to use deprecated language names (i.e. 'iw' instead of 'he')
    to store asset files.
    
    As an example, for Hebrew, Chrome was looking at:
    
      assets/locales#lang_he/he.pak
    
    While the file was really stored under:
    
      assets/locales#lang_iw/he.pak
    
    The CL fixes the issue for Hebrew, Yiddish and Indonesian and
    Filipino.
    
    BUG=902915
    R=benmason@chromium.org, tiborg@chromium.org, yfriedman@chromium.org, twellington@chromium.org
    
    Change-Id: I420158c30ba33c6203495af9453877722271e104
    Reviewed-on: https://chromium-review.googlesource.com/c/1327203
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606866}

    Changed files

    • ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java
    • ui/android/java/src/org/chromium/ui/resources/ResourceExtractor.java
    • ui/android/junit/src/org/chromium/ui/base/LocalizationUtilsTest.java
  2. Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7bfd5bb2031d217d0e0f87240b4ce16705abb3d

    Comments

    Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f
    Reviewed-on: https://chromium-review.googlesource.com/c/1325393
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606865}

    Changed files

    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
  3. Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 16:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f513b7c0c1803fe4688b8eee2dab06f48dabf081

    Comments

    Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy
    
    ... and remove the later.
    
    This is a follow up of mmenke's request in [1].
    
    [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70
    
    TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
    TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)
    
    BUG=773295
    
    Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1320769
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606864}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc
    • components/safe_browsing/browser/threat_details_cache.cc
    • content/browser/loader/resource_loader.cc
    • services/network/public/cpp/resource_response.cc
    • services/network/public/cpp/resource_response_info.cc
    • services/network/public/cpp/resource_response_info.h
    • services/network/url_loader.cc
  4. Ignore blur events caused by the password generation.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  5. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  6. Save transform context for filters

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  7. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  8. Remove v8_context_snapshot.bin determinism hack.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  9. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  10. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  11. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  12. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  13. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  14. Refactor Trusted Web Activity UI code to MVC

    Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java
  15. [AW NS] Add CTS test filter for Android WebView

    Changed by Tim Volodine - timvolodineohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:47:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e57afbcbc0d8a4fff7a9d8df6164bf0f6dcedd75

    Comments

    [AW NS] Add CTS test filter for Android WebView
    
    The idea of this CTS filter is similar to the filter we have for
    instrumentation tests, i.e.
    mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains
    failing tests and their corresponding issues / root causes.
    
    The current filter contains results from a local run for a subset of
    tests (the actual CTS is not running yet). The CTS filter also
    augments the instrumentation test filter for test coverage that is
    missing from instrumentation tests.
    
    BUG=903822,902330,841556
    
    Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1319677
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606852}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_webview_CTS_test.filter
  16. [Background Fetch] Report uploadTotal in the registration

    Changed by Rayan Kanso - rayankansohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a2e1006e2f0960cea11264c2cb65c73d0334b90

    Comments

    [Background Fetch] Report uploadTotal in the registration
    
    Also sets up some useful testing helpers for future upload features.
    
    Bug: 774054
    Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592
    Reviewed-on: https://chromium-review.googlesource.com/c/1329149
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606851}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.h
    • content/browser/background_fetch/storage/create_metadata_task.cc
  17. [ios] add manual fallback credit card and address coordinator

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:34:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b02a7719f78de1e78ded7807aa4d139f8c2b77d6

    Comments

    [ios] add manual fallback credit card and address coordinator
    
    And a common base class.
    
    Bug: 845472
    Change-Id: I12999d306804227e605e270c9b4f14bd8ee6a2bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1318914
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: David Jean <djean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606850}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/address_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
  18. Add RAF tests to blink_perf.canvas benchmark.

    Changed by Aaron Krajeski - aaronhkohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:28:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7149ab705c9a7c1c9c57c960c05e2de216680c7d

    Comments

    Add RAF tests to blink_perf.canvas benchmark.
    
    Current canvas benchmarks only measure CPU time.
    Using requestAnimationFrame (raf) in javascript we can
    measure CPU + raster + GPU time. This CL adds a mode to
    blink_perf.py that runs canvas all canvas test in a way
    that takes raster and GPU time into account.
    
    Roughly doubles the duration of `blink_perf.canvas`
    benchmark from ~2 minutes to ~4 minutes on a linux desktop.
    
    Bug: 894043
    Change-Id: I2fdd13af75615802266fa39a01db3e883f2c95bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1300038
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606849}

    Changed files

    • docs/speed/benchmark/harnesses/blink_perf.md
    • third_party/blink/perf_tests/canvas/OWNERS
    • third_party/blink/perf_tests/canvas/gpu-bound-shader.html
    • third_party/blink/perf_tests/canvas/resources/canvas_runner.js
    • third_party/blink/perf_tests/canvas/sheets-render.html
    • third_party/blink/perf_tests/canvas/upload-webgl-to-texture.html
    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/blink_perf.py
    • tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
    • tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py
    • tools/perf/contrib/blink_perf_xml_http_request/blink_perf_xml_http_request.py
    • tools/perf/core/shard_maps/android-nexus5x-perf_map.json
    • tools/perf/core/shard_maps/android_nexus5_perf_map.json
    • tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
    • tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
    • tools/perf/core/shard_maps/linux-perf_map.json
    • tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
    • tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
    • tools/perf/core/shard_maps/win-10-perf_map.json
    • tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
    • tools/perf/core/shard_maps/win_7_perf_map.json
  19. SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:27:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 413493e0052d3f0537cf96d619849e8acf248658

    Comments

    SyncStandaloneTransport: Add integration test for "Reset Sync" from dashboard
    
    Bug: 856179
    Change-Id: I0fb499c5bb5c0de6df4fa7c2f46d3b0b35f5f0df
    Reviewed-on: https://chromium-review.googlesource.com/c/1326901
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606848}

    Changed files

    • chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  20. Fix MergeAndOverrideOnConflict for custom properties.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:25:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3052bf26cacf33ea7dd70fda7cccb5bebb28cfe9

    Comments

    Fix MergeAndOverrideOnConflict for custom properties.
    
    Utilizing CSSPropertyName, to make the code much nicer.
    
    R=futhark@chromium.org
    
    Change-Id: I10733cabe27cc271eaaf3ecf62fa7713cf74eac3
    Reviewed-on: https://chromium-review.googlesource.com/c/1323650
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606847}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_value.cc
    • third_party/blink/renderer/core/css/css_property_value.h
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/css_property_value_set_test.cc
  21. Add redirected cases to CSP/import tests in wpt/worklets

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff65400edef4c2d8e8ed01f1e2bd60c1c55aa8c

    Comments

    Add redirected cases to CSP/import tests in wpt/worklets
    
    Also this CL replaces some of empty-worklet-script.js usage
    in CSP tests with empty-worklet-script-with-cors-header.js
    to make sure worklets are rejected due to CSP, not CORS.
    
    Change-Id: Ie463d206254c4c6728a79dae0ad79e4f7e333b92
    Reviewed-on: https://chromium-review.googlesource.com/c/1312146
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606846}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/csp-tests.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-insecure-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-remote-origin-redirected-empty-worklet-script.sub.js
    • third_party/WebKit/LayoutTests/external/wpt/worklets/resources/import-tests.js
  22. Add UseCounter for unknown namespace usage in selectors.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:21:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c413c91c21481af23cfb54d742e80fd2b589608

    Comments

    Add UseCounter for unknown namespace usage in selectors.
    
    R=chrishtr@chromium.org
    
    Bug: 901938
    Change-Id: I9e20fe19f2c97b98f8250c6c9914512b5a73d8c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1318891
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606845}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/frame/use_counter_test.cc
    • tools/metrics/histograms/enums.xml
  23. Retire NotificationInlineReplies runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:15:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5395d94feaf7a04c1a7fd9832d3750c636d6dea1

    Comments

    Retire NotificationInlineReplies runtime enabled flag.
    
    NotificationInlineReplies shipped in M70.
    
    BUG=834580
    
    Change-Id: Ibed1612aae4c21a239e9328d7134cd75169c713a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323615
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606844}

    Changed files

    • third_party/blink/renderer/modules/notifications/notification_action.idl
    • third_party/blink/renderer/modules/notifications/notification_event.idl
    • third_party/blink/renderer/modules/notifications/notification_event_init.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  24. [Autofill Assistant] Fixes Payement Request details bug.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be08662134b0c40ff6913cf531e2fefed5c2d4d9

    Comments

    [Autofill Assistant] Fixes Payement Request details bug.
    
    Before all details where asked each time.
    
    Bug: 806868
    Change-Id: Ie3a278e2882d4829cfe2c54ac641d10abf5af2e6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329167
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606843}

    Changed files

    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
  25. Fix the icons for the app menu and the upgrade item in it when an update is available.

    Changed by Greg Thompson - grtohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:12:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5a766d75a0eb8006212cb5cee94d704650c787b

    Comments

    Fix the icons for the app menu and the upgrade item in it when an update is available.
    
    A regression was introduced in r581520 that caused the wrong icon and/or
    the wrong coloring to be used in some circumstances. This CL fixes this
    in two parts:
    
    - AppMenuIconController may decide that the "annoyance level" from a
      pending update is too low to bother the user. One bug introduced in
      r581520 was that the controller still notified delegates that the
      UPGRADE_NOTIFICATION icon type should be used in this case. Now, the
      VERY_LOW annoyance level is ignore entirely for beta and stable
      channels.
    
    - AppMenuModel no longer bases its decision to include the upgrade menu
      item directly on the UpgradeDetector. Rather, it now queries the
      AppMenuIconController. This ensures that the same logic is used for
      both the badging of the app menu and for the presence of the upgrade
      item in the menu.
    
    BUG=898958
    
    Change-Id: I4b761844365968a24bc69030d711122fcaf16e28
    Reviewed-on: https://chromium-review.googlesource.com/c/1312475
    Commit-Queue: Greg Thompson <grt@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606842}

    Changed files

    • chrome/browser/ui/toolbar/app_menu_icon_controller.cc
    • chrome/browser/ui/toolbar/app_menu_icon_controller.h
    • chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
    • chrome/browser/ui/toolbar/app_menu_model.h
    • chrome/browser/ui/toolbar/app_menu_model_unittest.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
    • chrome/browser/ui/views/toolbar/browser_app_menu_button.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/BUILD.gn
  26. Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c42eb303c89bfba751ae499abfb7252e2ceb7532

    Comments

    Import wpt@47f0061f15dd2973dab11d87c03f0c8264d32e02
    
    Using wpt-import in Chromium 43d0eed3db77a5e6167b5ebbf6ecb3710790272a.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I4bcac484d08efe8d6e6412d40b1c7d73ffe512d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329061
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606841}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/selection-api.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/webrtc.idl
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  27. testing/buildbot: add fake bots to run Dawn's GPU tests.

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f2b5efa43dfe2ff69fab31ba83c352ecf8e62ab

    Comments

    testing/buildbot: add fake bots to run Dawn's GPU tests.
    
    BUG=chromium:901830
    
    Change-Id: I5c5b0b08fadddc34f6a2d176ae39ebfae7e7f706
    Reviewed-on: https://chromium-review.googlesource.com/c/1326157
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606840}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  28. Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 15:03:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01d002523922e64775a90ae4fbcb831f3aebf024

    Comments

    Roll src/third_party/perfetto 606ed681f4ea..fd986312652f (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/606ed681f4ea..fd986312652f
    
    
    git log 606ed681f4ea..fd986312652f --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 hjd@google.com Merge "perfetto-ui: Fix UI with counter only traces"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@fd986312652f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I602c7205239349ff0faf4467740388c6cb05725f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329044
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606839}

    Changed files

    • DEPS
  29. Roll src-internal c458532c0628..6166365225d6 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 14:56:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02a2080524dcf1a59efd81b88b8a6526fc6224ee

    Comments

    Roll src-internal c458532c0628..6166365225d6 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c458532c0628..6166365225d6
    
    
    Created with:
      gclient setdep -r src-internal@6166365225d6
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I57783466072640b229610c2550d50f9c46d0c4e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329043
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606838}

    Changed files

    • DEPS
  30. Add a provider for the Passwords UI in Settings

    Changed by Ioana Pandele - ioanapohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:51:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feda313fc19c2032e21eed604a1a0e58d42587ee

    Comments

    Add a provider for the Passwords UI in Settings
    
    This CL introduces ManagePasswordsUIProvider, a class which aims to allow
    for alternative UI surfaces to be shown if available.
    
    Bug: 903249
    Change-Id: I8c03f2f539772044bd5ba0fa944fd5e441d43c76
    Reviewed-on: https://chromium-review.googlesource.com/c/1326488
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606837}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/password_manager/ManagePasswordsUIProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
    • chrome/android/java_sources.gni
  31. Apk for test proguard flags ignoring classes which don't exist

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:50:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4fffd63b4281c67f7e142087c476ce903a5a08a

    Comments

    Apk for test proguard flags ignoring classes which don't exist
    
    Bug: 872904
    Change-Id: Ib178be906c8d74ecabd7cfafeba8e7cf3a3398ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1327331
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606836}

    Changed files

    • chrome/android/java/apk_for_test.flags
  32. Enable multiple WorkerFetchContext per one global scope

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:46:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7ede5922f5c054c81b5ea049651775ab0503582c

    Comments

    Enable multiple WorkerFetchContext per one global scope
    
    Currently WorkerFetchContext has the ownership of
    some objects originated from WebWorkerFetchContext.
    To create multiple WorkerFetchContexts
    for one WorkerOrWorkletGlobalScope/WebWorkerFetchContext,
    this CL moves these ownership outside WorkerFetchContext.
    Namely,
    - url_loader_factory_ and script_loader_factory_
      from WorkerFetchContext to WebWorketFetchContext subclasses, and
    - subresource_filter_ from WorkerFetchContext to
      WorkerOrWorkletGlobalScope.
      Still |WorkerFetchContext::subresource_filter_| is kept, but
      it is created in WorkerOrWorkletGlobalScope and passed to
      WorkerFetchContext.
    
    This CL doesn't change the observable behavior.
    This CL creates WebURLLoaderFactory a little more eagerly, i.e.
    when WorkerFetchContext is created,
    while previously it was created when
    WorkerFetchContext::CreateURLLoader() is called for the first time.
    
    Bug: 880027, 903579
    Change-Id: I84a8bafee25b7f293201a271d198260e2dfb8e68
    Reviewed-on: https://chromium-review.googlesource.com/c/1193385
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606835}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/service_worker/service_worker_fetch_context_impl.cc
    • content/renderer/service_worker/service_worker_fetch_context_impl.h
    • third_party/blink/public/platform/web_worker_fetch_context.h
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
    • third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
  33. [ios] Deletes unused code that was migrated from ios/clean.

    Changed by Rohit Rao - rohitraoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:41:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e3ace0051b91c7144046c60acd04c7d658c9b09

    Comments

    [ios] Deletes unused code that was migrated from ios/clean.
    
    BUG=None
    
    Change-Id: I3a14f465f152e9b1b514802723093e9702edc001
    Reviewed-on: https://chromium-review.googlesource.com/c/1326487
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606834}

    Changed files

    • ios/chrome/browser/browser_state/BUILD.gn
    • ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
    • ios/chrome/browser/ui/coordinators/BUILD.gn
    • ios/chrome/browser/ui/coordinators/browser_coordinator+internal.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.h
    • ios/chrome/browser/ui/coordinators/browser_coordinator_test_util.mm
    • ios/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.h
    • ios/chrome/browser/ui/coordinators/test_browser_coordinator.mm
    • ios/chrome/browser/ui/main_content/BUILD.gn
    • ios/chrome/browser/ui/main_content/main_content_coordinator.h
    • ios/chrome/browser/ui/main_content/main_content_coordinator.mm
    • ios/chrome/browser/ui/main_content/main_content_coordinator_unittest.mm
    • ios/chrome/browser/ui/overlays/BUILD.gn
    • ios/chrome/browser/ui/overlays/OWNERS
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.h
    • ios/chrome/browser/ui/overlays/browser_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_coordinator+internal.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/overlay_queue.h
    • ios/chrome/browser/ui/overlays/overlay_queue.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_manager_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/overlay_queue_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler.mm
    • ios/chrome/browser/ui/overlays/overlay_scheduler_observer.h
    • ios/chrome/browser/ui/overlays/overlay_scheduler_unittest.mm
    • ios/chrome/browser/ui/overlays/overlay_service.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.h
    • ios/chrome/browser/ui/overlays/overlay_service_factory.mm
    • ios/chrome/browser/ui/overlays/overlay_service_impl.h
    • ios/chrome/browser/ui/overlays/overlay_service_impl.mm
    • ios/chrome/browser/ui/overlays/overlay_service_observer.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.h
    • ios/chrome/browser/ui/overlays/overlay_service_observer_bridge.mm
    • ios/chrome/browser/ui/overlays/test/BUILD.gn
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.h
    • ios/chrome/browser/ui/overlays/test/overlay_coordinator_test.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_parent_coordinator.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_manager_observer.mm
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.h
    • ios/chrome/browser/ui/overlays/test/test_overlay_queue_observer.mm
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.h
    • ios/chrome/browser/ui/overlays/web_state_overlay_queue.mm
    • ios/chrome/test/BUILD.gn
  34. RC: Compress all chrome://discards resources.

    Changed by Sigurdur Asgeirsson - siggiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:35:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e826ee9592541ae9d53fd23c51761adf9df17cfc

    Comments

    RC: Compress all chrome://discards resources.
    
    I don't know whether to trust these numbers, but this is what I see
    for my local Windows release 32 bit build.
    
    Uncompressed:
    3,034,139 browser_resources.pak
    233,038,336 mini_installer.exe
    
    Compressed:
    2,869,382 browser_resources.pak
    232,873,472 mini_installer.exe
    
    Bug: 891310
    Change-Id: I3db92ad65afc97b80a9acfbd2fabf486739d7822
    Reviewed-on: https://chromium-review.googlesource.com/c/1327406
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606833}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/ui/webui/discards/discards_ui.cc
  35. use SkFontHinting

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a6d7fa9a9e6b3fe2c1c33cb52460998b0a991cf

    Comments

    use SkFontHinting
    
    Bug: skia:2664
    Change-Id: I22633705f2f21f95a223a193a1437d2311e5e205
    Reviewed-on: https://chromium-review.googlesource.com/c/1318416
    Commit-Queue: Mike Reed <reed@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606832}

    Changed files

    • cc/paint/oop_pixeltest.cc
    • cc/paint/paint_flags.cc
    • cc/paint/paint_flags.h
    • chrome/renderer/pepper/pepper_flash_renderer_host.cc
    • content/renderer/render_view_fuchsia.cc
    • content/renderer/render_view_linux.cc
    • skia/config/SkUserConfig.h
    • third_party/blink/public/platform/web_font_render_style.h
    • third_party/blink/renderer/platform/fonts/font_metrics.cc
    • third_party/blink/renderer/platform/fonts/mac/font_platform_data_mac.mm
    • third_party/blink/renderer/platform/fonts/web_font_render_style.cc
    • third_party/blink/renderer/platform/graphics/logging_canvas.cc
  36. PersonalDataManager: Rename AccountStorageForServer(Cards->Data)

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41c87263ae4560b264e15ec45be4832be2e79e86

    Comments

    PersonalDataManager: Rename AccountStorageForServer(Cards->Data)
    
    The account storage is now used for both server cards and server
    addresses.
    
    Bug: 864519
    Change-Id: Ia5fb5ebc4bd4e334b162378923ccd04562d4cac9
    Reviewed-on: https://chromium-review.googlesource.com/c/1329241
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606831}

    Changed files

    • chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
  37. PersonalDataManager: Store server (aka Wallet) addresses in the Server DB

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 274ab9c5685ffb50c277a68979c46b4abf9c9455

    Comments

    PersonalDataManager: Store server (aka Wallet) addresses in the Server DB
    
    Currently, this makes no functional difference: In full Sync mode, the
    local DB and the server DB are the same thing anyway, and in
    lightweight/Butter mode, we don't store server addresses at all.
    However,
    1) this change will unlock actually supporting Wallet addresses in
       Butter mode, and
    2) it's just less confusing if "server" things are actually stored in
       the "server" DB.
    
    Bug: 864519
    Change-Id: I4f5479faff87cfa4f7def6b98f6b2235294393b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1326492
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606830}

    Changed files

    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager_unittest.cc
  38. Ribbon: Apply values via CustomProperty.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:23:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 634f8db566f7e5401be35e6d6d98f8858a41e0d0

    Comments

    Ribbon: Apply values via CustomProperty.
    
    Instead of applying custom properties via the static Variable instance,
    use the new CustomProperty class (which knows about its name and
    registration) to apply values. This brings the custom property code path
    closer to the standard property code path.
    
    To assist CSSPropertyRef in producing a CSSProperty&, this CL adds the
    class CSSPropertyName. The idea is that CSSPropertyName can be used instead
    of CSSPropertyID/AtomicString where both standard and custom properties are
    expected. My intent is to store a CSSPropertyName in
    CSSPropertyValueMetadata (instead of the CSSProperty*), but this is a big
    change, as everything that creates property/value pairs must carry the
    CSSPropertyName. So, for now PropertyReference.Name() is faking it by
    digging the name out of the associated CSSValue.
    
    Note that CSSPropertyName::ToAtomicString intentionally does not return
    a const AtomicString&. This is because 1) I want to try and reduce the
    size of CSSPropertyName to one pointer, which means it will contain a
    StringImpl* rather than an AtomicString, and 2) I want CSSPropertyName to
    be something that can be passed to other threads if needed, which again
    means StringImpl* (or String, at least) rather than AtomicString.
    
    In general, this CL is a step on the path to achieve these things:
    
     1. Removing the useless and dangerous static Variable instance.
     2. Not having to piggy-back the custom property name in a CSSValue.
     3. Not having to smuggle initial/inherit/unset via the
        CSSCustomPropertyDeclaration (vs. applying CSSIdentifierValues
        holding these values, like civilized individuals).
    
    R=flackr@chromium.org, futhark@chromium.org
    
    Change-Id: I1a062138fc86c5a398542ac147bf9d71feed7b3c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323113
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606829}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/css_default_interpolation_type.cc
    • third_party/blink/renderer/core/animation/css_var_cycle_interpolation_type.cc
    • third_party/blink/renderer/core/animation/property_handle.h
    • third_party/blink/renderer/core/animation/property_handle_test.cc
    • third_party/blink/renderer/core/css/BUILD.gn
    • third_party/blink/renderer/core/css/css_property_name.cc
    • third_party/blink/renderer/core/css/css_property_name.h
    • third_party/blink/renderer/core/css/css_property_name_test.cc
    • third_party/blink/renderer/core/css/css_property_value_set.cc
    • third_party/blink/renderer/core/css/css_property_value_set.h
    • third_party/blink/renderer/core/css/properties/css_property_ref.cc
    • third_party/blink/renderer/core/css/properties/css_property_ref.h
    • third_party/blink/renderer/core/css/properties/css_property_ref_test.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.cc
    • third_party/blink/renderer/core/css/properties/longhands/custom_property.h
    • third_party/blink/renderer/core/css/properties/longhands/variable.cc
    • third_party/blink/renderer/core/css/properties/longhands/variable.h
    • third_party/blink/renderer/core/css/resolver/css_variable_resolver_test.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.cc
    • third_party/blink/renderer/core/css/resolver/style_builder.h
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
  39. Revert "Mac: Disallow dragging tab into blocked tabstrip"

    Changed by Leonard Grey - lgreyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 899b84ea267b8ce6ce522d2cf3b34453be3ac164

    Comments

    Revert "Mac: Disallow dragging tab into blocked tabstrip"
    
    This reverts commit 002dfaef6957632740a412c3d69af0913536e1dd.
    
    Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=903706#c1
    
    Original change's description:
    > Mac: Disallow dragging tab into blocked tabstrip
    > 
    > This is a really longwinded way for me to fix some NOTIMPLEMENTED spam,
    > though I'm pretty sure the thing that happens right now when you open
    > a certificate prompt and drag a tab into the parent window is bad.
    > 
    > This introduces a new method because we're not sure if it matches the
    > Aura semantics, and this is better than the nothing we were doing previously.
    > 
    > Bug: 825834
    > Change-Id: I316ca4fbaa7a27dacb09bce0866203b79567016d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1315956
    > Commit-Queue: Leonard Grey <lgrey@chromium.org>
    > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606619}
    
    TBR=ellyjones@chromium.org,lgrey@chromium.org
    
    Change-Id: If2a6470657f160a0e7fa2fd9978078ab46ae048a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 825834
    Reviewed-on: https://chromium-review.googlesource.com/c/1329341
    Reviewed-by: Leonard Grey <lgrey@chromium.org>
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606828}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/tab_drag_controller.h
  40. Fix h2o_junit_manifest_target_name on the bots

    Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a996f2946740acd659f5ed757b2ae364c0168c0

    Comments

    Fix h2o_junit_manifest_target_name on the bots
    
    This CL:
    - Makes the generated AndroidManifest.xml a data dependency of
    h2o_junit_manifest_target_name
    - Reenables LaunchTest.*
    
    BUG=902325
    
    Change-Id: I47e3c5c2226c78c696716712a4307127493c5903
    Reviewed-on: https://chromium-review.googlesource.com/c/1324875
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606827}

    Changed files

    • chrome/android/webapk/shell_apk/BUILD.gn
    • chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/h2o/LaunchTest.java
  41. [Autofill Assistant] Allow clicking on links.

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 14:16:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74c9dc10cd643cc6eec6928ae7a8c8d364b85738

    Comments

    [Autofill Assistant] Allow clicking on links.
    
    Before this patch, navigation triggered by clicking on a link or through
    javascript (renderer-initiated navigation) was considered an end state
    for Autofill assistant.
    
    With this patch, such actions are only considered an end state if the
    page that's navigated to has no scripts. This is necessary, as such
    navigation is part of the expected flow of some scripts.
    
    Going back a page or refreshing through the UI (non renderer-initiated
    navigation) are still considered an end state with this patch.
    
    Bug: 806868
    Change-Id: I5a38a82e7edf8b34a5830130b957dfad387e1b0d
    Reviewed-on: https://chromium-review.googlesource.com/c/1329242
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606826}

    Changed files

    • components/autofill_assistant/browser/controller.cc
  42. [iOS] Decouple completion handler from new tab creation in BVC.

    Changed by Mark Cogan - marqohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:15:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c86aa454442704cbfc07d7bf5aaf6a7e301b70c

    Comments

    [iOS] Decouple completion handler from new tab creation in BVC.
    
    This CL decouples the addition of a tab completion block from the other
    tab opening code in the BVC. This will allow the tab opening logic
    (which is just tab model manipulation) to be moved out of the BVC.
    
    Bug: 903338
    Change-Id: Ibc7ba411c2cbec58dd11ac7cb65e2b9284eb811c
    Reviewed-on: https://chromium-review.googlesource.com/c/1323558
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606825}

    Changed files

    • ios/chrome/app/application_delegate/url_opener_unittest.mm
    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/ui/browser_view_controller.h
    • ios/chrome/browser/ui/browser_view_controller.mm
  43. [Autofill Assistant] Fix tap operation and add browser tests

    Changed by gogerald - gogeraldohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 14:02:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c30a7925aa902990811797ff7dcd2cf89994947

    Comments

    [Autofill Assistant] Fix tap operation and add browser tests
    
    Bug: 806868
    Change-Id: I9730373e60f28b65fb515f9de42da0f6505db594
    Reviewed-on: https://chromium-review.googlesource.com/c/1324239
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606824}

    Changed files

    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
    • components/autofill_assistant/browser/web_controller_browsertest.cc
    • components/test/data/autofill_assistant/autofill_assistant_target_website.html
    • components/test/data/autofill_assistant/autofill_assistant_target_website_iframe_one.html
  44. [Autofill Assistant] Extended the amount of information available through feedback forms.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 13:57:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0eb90453d54daf47f522b220ba83dda94bba669

    Comments

    [Autofill Assistant] Extended the amount of information available through feedback forms.
    
    The stock android feedback form has an optional string field `feedbackContext', which can be used to provide extended information. Depending on when the user taps the feedback button, not all of the information may be available.
    
    Bug: 806868
    Change-Id: I5dfaaf813c48198f573f2e1fbd0d6468439d3a6c
    Reviewed-on: https://chromium-review.googlesource.com/c/1317911
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606823}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/FeedbackContext.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/mock_ui_controller.h
    • components/autofill_assistant/browser/script_tracker.cc
    • components/autofill_assistant/browser/script_tracker.h
    • components/autofill_assistant/browser/ui_controller.h
    • components/autofill_assistant/browser/ui_delegate.h
  45. Revert "Add resource load priority Service Worker tests"

    Changed by Corentin Wallez - cwallezohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:57:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c01e9b4c3145dbde2c4d472ab75dd00937663981

    Comments

    Revert "Add resource load priority Service Worker tests"
    
    This reverts commit 0f0d0b74734bf82737b893d03ed334ef360f9b0b.
    
    Reason for revert: super flaky on win7_chromium_rel_ng
    
    BUG=chromium:872776
    
    Original change's description:
    > Add resource load priority Service Worker tests
    > 
    > This CL adds resource load priority tests ensuring that the priority of
    > requests that pass through a Service Worker is preserved.
    > 
    > R=​kinuko@chromium.org, kouhei@chromium.org, yhirano@chromium.org
    > 
    > Bug: 872776
    > Change-Id: I74f334359b3255fcac5c13fbdb9f1e601af0f8f0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1316104
    > Commit-Queue: Dominic Farolino <domfarolino@gmail.com>
    > Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606689}
    
    TBR=falken@chromium.org,kinuko@chromium.org,yhirano@chromium.org,kouhei@chromium.org,domfarolino@gmail.com
    
    Change-Id: I6d997795ffc64f1005ed3821799300cd3401eea9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 872776
    Reviewed-on: https://chromium-review.googlesource.com/c/1329245
    Reviewed-by: Corentin Wallez <cwallez@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606822}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/priorities/resource-load-priorities-service-worker.https.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/common.js
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/async-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/defer-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/fetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/module-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/off-screen-image.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/parser-blocking-script.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/prefetch.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/render-blocking-stylesheet.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/resources/service-worker/xhr.html
    • third_party/WebKit/LayoutTests/http/tests/priorities/service-worker-get-priority.js
  46. [SPv2] Fix background invalidation on scroll

    Changed by Xianzhu Wang - wangxianzhuohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 089805f4087998a3c196305ad8f13cc488bb7655

    Comments

    [SPv2] Fix background invalidation on scroll
    
    The previous early return shortcut required invalidation of fixed-attachment
    background etc.
    
    Now in PaintLayerScrollableArea::InvalidatePaintForScrollOffsetChange():
    - always invalidate for fixed-attachment background
    - correct invalidation of local-attachment background for SPv2
    - remove the SetNeedsRepaint() logic for change of existence of
      ScrollTranslation because now PaintPropertyTreeBuilder will do that
      whenever a paint property node is created or removed
    
    Bug: 529963
    Change-Id: I5c9636cb318412cf8398f305a43bc0c55b9a3fc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1308988
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606821}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/full-viewport-repaint-for-background-attachment-fixed-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/scroll/overflow-scroll-local-background-text-color-change-expected.txt
    • third_party/WebKit/LayoutTests/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
    • third_party/blink/renderer/core/paint/box_paint_invalidator.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
    • third_party/blink/renderer/core/style/fill_layer.cc
    • third_party/blink/renderer/core/style/fill_layer.h
  47. Revert "Fix page slip issue after dragging"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:55:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a47b88e164851a0821bd9d6107b63deedb09656a

    Comments

    Revert "Fix page slip issue after dragging"
    
    This reverts commit 05e6d6110b8ee4c29a04943ac021bf59c1d62c72.
    
    Reason for revert: Breaks AppsGridViewDragTest.MouseDragMaxItemsInFolder/6 and a bunch of other tests. 
    
    ==23676==ERROR: AddressSanitizer: container-overflow on address 0x608000011e50 at pc 0x5580f7784dcd bp 0x7ffd9affb130 sp 0x7ffd9affb128
    READ of size 8 at 0x608000011e50 thread T0
        #0 0x5580f7784dcc in ViewAtBase ui/views/view_model.h:71:28
    
    See https://sheriff-o-matic.appspot.com/chromium/examine/chromium.memory.Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1).app_list_unittests.
    
    Original change's description:
    > Fix page slip issue after dragging
    > 
    > Changes:
    > Update the selected page to be the target page of dragged item at the
    > end of dragging.
    > 
    > Bug: 893832
    > Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
    > Reviewed-on: https://chromium-review.googlesource.com/c/1324851
    > Commit-Queue: Weidong Guo <weidongg@chromium.org>
    > Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606585}
    
    TBR=newcomer@chromium.org,weidongg@chromium.org
    
    Change-Id: I4177d2e3ac6226b415b627148db211614d0b7ec4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893832
    Reviewed-on: https://chromium-review.googlesource.com/c/1329170
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606820}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
  48. v8binding: Use explicitly-typed callback functions in custom elements

    Changed by Yuki Shiino - yukishiinoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:46:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f2d97b775634dcb3f099162f926af93924d29ab

    Comments

    v8binding: Use explicitly-typed callback functions in custom elements
    
    We're planning to not use cross origin ScriptStates everywhere,
    especially in IDL callback function and callback interface.
    Given that, we'd like to minimize use of ScriptState of callbacks,
    which will be nullptr in case of cross origin, so that the call sites
    of callbacks do not need to handle a SecurityError.
    
    This patch is a preparation of https://crrev.com/c/1314023 and
    removes the use of the ScriptState from custom elements.
    
    Bug: 886588, 892755
    Change-Id: I52068920b659efe119496ec092448cdc107e0631
    Reviewed-on: https://chromium-review.googlesource.com/c/1325585
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606819}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/BUILD.gn
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
    • third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.h
    • third_party/blink/renderer/bindings/scripts/v8_callback_function.py
    • third_party/blink/renderer/bindings/scripts/v8_callback_interface.py
    • third_party/blink/renderer/bindings/scripts/v8_types.py
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.h
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.h
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.h
    • third_party/blink/renderer/core/html/custom/custom_element_registry.idl
  49. DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:41:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 496cd36004b1f6d845e66930bbbd939de4e4f5bb

    Comments

    DisabletestModalNativeAppBannerCanBeTriggeredMultipleTimesCustomTab.
    
    It is flaky. See for instance
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/121816.
    
    Bug: 903658, 903657
    Change-Id: Ic682ac60329923a35745d135d101d0eb8b61b08b
    Tbr: mdjones@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1329161
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606818}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
  50. Update V8 to version 7.2.286.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3d9d78bc2653ea749eb1719fffdd70f53cedfc6

    Comments

    Update V8 to version 7.2.286.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/6130e69e..31b2546b
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I2a2852bb93f2c67cb5e6a1f0ed39315bab81006f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329062
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606817}

    Changed files

    • DEPS
  51. [Sync::USS] Fix for counting unsyncable bookmarks when loading model

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:34:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6a54aa7e9e0d98986cdbaa84a41d1441e17ad1c

    Comments

    [Sync::USS] Fix for counting unsyncable bookmarks when loading model
    
    On every start up, the bookmarks sync metadata are compared to the
    local model to check the integrity of the persisted data.
    If the model and the metadata don't match, sync infrastructure assumes
    the metadata are corrupted and start syncing from a clean state.
    
    Before this CL:
    Unsyncable bookmarks where considered at comparison. This resulted in the
    models to always never match, and issue an initial update at every
    start up.
    
    After this CL:
    Only syncable bookmarks are considering when comparing the model
    and the metadata.
    
    This issue could be observed using the UMA metric
    Sync.ModelTypeEntityChange3.BOOKMARK
    which should how frequently the client asks for initial updates.
    Before this patch, the client was unnecessarily asking for initial
    updates at every start up, and hence resulted in huge increase in
    the bucket in REMOTE_INITIAL_UPDATE of
    Sync.ModelTypeEntityChange3.BOOKMARK
    
    Bug: 516866
    Change-Id: I61c453359c4265af09a91253f2e13139034b2a53
    Reviewed-on: https://chromium-review.googlesource.com/c/1329001
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606816}

    Changed files

    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
  52. Roll src/third_party/perfetto 486203eeaffd..606ed681f4ea (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:33:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6318418e6bff257eaf360aa0661f49f993a8f3c1

    Comments

    Roll src/third_party/perfetto 486203eeaffd..606ed681f4ea (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/486203eeaffd..606ed681f4ea
    
    
    git log 486203eeaffd..606ed681f4ea --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 treehugger-gerrit@google.com Merge "Add comment on ftrace pid"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@606ed681f4ea
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: If0bd022a39477de441941826e42f178807d978bc
    Reviewed-on: https://chromium-review.googlesource.com/c/1329042
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606815}

    Changed files

    • DEPS
  53. Roll src-internal 73158cecda02..c458532c0628 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bde1aec4c859fd39a039a59a98da4c8b51f6f4f

    Comments

    Roll src-internal 73158cecda02..c458532c0628 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73158cecda02..c458532c0628
    
    
    Created with:
      gclient setdep -r src-internal@c458532c0628
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I8311db5f4432ad7184b609969b5a2ecd787fbe9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329041
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606814}

    Changed files

    • DEPS
  54. Revert "Enable unified garbage collections"

    Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c36eb8acab5820a2fcaefb9e856b698e3cc0ce52

    Comments

    Revert "Enable unified garbage collections"
    
    This reverts commit a8228cdc699831699180ecd3b327366305c830d2.
    
    Reason for revert: Reverting as we've cycled through the waterfalls and the other flag change on the content layer already got reverted.
    
    Original change's description:
    > Enable unified garbage collections
    > 
    > Enables unified heap garbage collection across V8 and Blink. The GC
    > computes a single transitive closure across V8's API boundary before
    > starting the separate sweepers.
    > 
    > Sheriffs: This is a dry-run of the feature and will be reverted after
    > cycling through the waterfall and performance bots.
    > 
    > Bug: 843903
    > Change-Id: I0d3e9fc76fa9b116f32d92a234c45afe11120cf9
    > Reviewed-on: https://chromium-review.googlesource.com/c/1290869
    > Reviewed-by: Hannes Payer <hpayer@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#605634}
    
    TBR=ulan@chromium.org,haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 843903
    Change-Id: I1d1f695431919864cb15dffe0d9b1e4ba85fd3c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329021
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606813}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  55. [perf] Add browse:media:youtube:2018 system_health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:09:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5ece11759649faaa791f155e7c88cc13c99d497

    Comments

    [perf] Add browse:media:youtube:2018 system_health story
    
    Due to many ads being loaded and certain requests will not work.
        [console:error:js]:       ~30
        [console:error:network]:  ~30
    
    Bug: 878390
    Change-Id: I3e09c9302514b1fb089d77b4671c59fb44afb22f
    Reviewed-on: https://chromium-review.googlesource.com/c/1296172
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606812}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_6b6bdda708.wprgo.sha1
    • tools/perf/page_sets/system_health/browsing_stories.py
  56. Disable AudioOutputDeviceTest.VerifyDataFlow.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:01:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4dc1efff9f39f75768c64004fea6a83b7b38d71

    Comments

    Disable AudioOutputDeviceTest.VerifyDataFlow.
    
    Flakily fails like this:
    ../../media/audio/audio_output_device_unittest.cc:411: Failure
    Actual function call count doesn't match EXPECT_CALL(env.callback,
        Render(kDelay, env.time_stamp, kFramesSkipped, NotNull()))...
             Expected: to be called once
               Actual: never called - unsatisfied and active
    
    See for instance
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/
        Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30025
    
    Tbr: olka@chromium.org
    Bug: 903696
    Change-Id: I621eab844322e47a36cfa55ddf6c09c04d825266
    Reviewed-on: https://chromium-review.googlesource.com/c/1328987
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606811}

    Changed files

    • media/audio/audio_output_device_unittest.cc
  57. Revert "Reenable direct composition without video layers"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:58:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fb9951ce0f87e70b86cb5b12b4cca635341cbad

    Comments

    Revert "Reenable direct composition without video layers"
    
    This reverts commit eec86ff6c03b228b426a4553c89724d04e0a0f56.
    
    Reason for revert: Appears to break cc_unittests on the Linux CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11190
    
    Original change's description:
    > Reenable direct composition without video layers
    > 
    > Reenable direct composition surface on devices without hardware overlays
    > since it enables other power improvements like flip mode swap chain and
    > disabling DWM redirection surface.
    > 
    > To mitigate the original concerns about direct composition, this change
    > makes DCLayerTree lazy initialize the video context and processor when
    > a video layer is first used.  On devices that don't support hardware
    > overlays, the video context and processor will never be initialized.
    > 
    > Bug: 894675, 900702
    > Change-Id: I8c9d5b78718de2620ca177410d4916390e7cb219
    > Reviewed-on: https://chromium-review.googlesource.com/c/1318808
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606312}
    
    TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 894675, 900702
    Change-Id: I094721159277c50d9061dfded252bbac1084977f
    Reviewed-on: https://chromium-review.googlesource.com/c/1328965
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606810}

    Changed files

    • content/browser/gpu/gpu_internals_ui.cc
    • content/renderer/render_thread_impl.cc
    • gpu/config/gpu_driver_bug_list.json
    • gpu/config/gpu_info.cc
    • gpu/config/gpu_info.h
    • gpu/config/gpu_util.cc
    • gpu/ipc/common/gpu_info.mojom
    • gpu/ipc/common/gpu_info_struct_traits.cc
    • gpu/ipc/common/gpu_info_struct_traits.h
    • gpu/ipc/common/struct_traits_unittest.cc
    • gpu/ipc/service/direct_composition_surface_win.cc
    • gpu/ipc/service/direct_composition_surface_win.h
    • gpu/ipc/service/gpu_init.cc
    • gpu/ipc/service/image_transport_surface_win.cc
    • ui/gl/gl_switches.cc
    • ui/gl/gl_switches.h
  58. [Android] Remove GmsCoreSyncListener

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:55:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c5f96267752a38d90b07932c438ca7354e92f3e3

    Comments

    [Android] Remove GmsCoreSyncListener
    
    This CL removes GmsCoreSyncListener class and some harness around it.
    This class was implemented for https://crbug.com/552106, but that
    feature was never finished. This CL also removes
    ProfileSyncService::GetCustomPassphraseKey that became unused.
    
    Bug: 903284
    Change-Id: I096b2ab74915d2ed93b4c4077902a1de9abb4cee
    Reviewed-on: https://chromium-review.googlesource.com/c/1326502
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606809}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/GmsCoreSyncListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  59. Revert "Fix a crash when switching to tablet mode in Unified Desktop mode"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:47:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f547d178e2b806007b88aa4c70ffe530de94f78

    Comments

    Revert "Fix a crash when switching to tablet mode in Unified Desktop mode"
    
    This reverts commit dcb55ce2871fe258d30386a85af754d496dfdb62.
    
    Reason for revert: Appears to cause crashes in LoginCursorTest.CursorHidden. See https://chromium-swarm.appspot.com/task?id=410f91874d359810&refresh=10&show_raw=1:
    BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x55c75309100f base::debug::StackTrace::StackTrace()
    #1 0x55c752aa8075 content::(anonymous namespace)::DumpStackTraceSignalHandler()
    #2 0x7f17e8b21cb0 <unknown>
    #3 0x55c751991a1d chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
    #4 0x55c751991c8e chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
    #5 0x55c7553a6063 views::WebDialogView::OnDialogClosed()
    #6 0x55c7553a5d92 views::WebDialogView::WindowClosing()
    #7 0x55c752f81eb0 views::Widget::OnNativeWidgetDestroying()
    #8 0x55c7548080ff views::DesktopWindowTreeHostMus::CloseNow()
    
    Original change's description:
    > Fix a crash when switching to tablet mode in Unified Desktop mode
    > 
    > 1) The Home Launcher used to use the wrong display ID when in
    >    Unified Desktop mode.
    > 2) If (1) is fixed, we hit https://crbug.com/902601. The captive
    >    portal dialog widget used to be leaked and never destroyed.
    > 3) If (2) is fixed, we crash on the first attempt to press the
    >    app list button. The reason is tablet mode triggers a switch
    >    to mirror mode. This switch happens asynchronously after the
    >    Home Launcher had already been created. Switching from Unified
    >    to mirror mode destroys the Unified host and the Home Launcher.
    >    That's why we need to ensure that the Home Launcher is
    >    recreated.
    > 
    > BUG=900956, 902601
    > TEST=Added a test that crashes without the fix.
    > 
    > Change-Id: If6eb9c2255dfa9d442aa115a3274db2d8a4110d7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325389
    > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    > Reviewed-by: Weidong Guo <weidongg@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606687}
    
    TBR=xiyuan@chromium.org,oshima@chromium.org,afakhry@chromium.org,jdufault@chromium.org,weidongg@chromium.org
    
    Change-Id: I2e0cacc2c29bbc44e8e8c9dfcb86fd8106c008ff
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 900956, 902601
    Reviewed-on: https://chromium-review.googlesource.com/c/1329004
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606808}

    Changed files

    • ash/app_list/app_list_controller_impl.cc
    • ash/app_list/app_list_controller_impl.h
    • ash/display/display_configuration_observer.cc
    • ash/display/display_manager_unittest.cc
    • chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
  60. Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget."

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:39:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b39a541429c5031a7a7d12d13ade6fd69a10356

    Comments

    Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget."
    
    This reverts commit 68d8dbc019fd37659252e273ade868aac7a9d8ac.
    
    Reason for revert: Looks like it makes PrerenderBrowserTest.PrerenderInfiniteLoop according to FindIt. 
    
    ../../chrome/browser/prerender/prerender_browsertest.cc:1721: Failure
    Expected equality of these values:
      1U
        Which is: 1
      GetLinkPrerenderCount()
        Which is: 2
    
    Original change's description:
    > Don't make a LayerTreeFrameSink for a non-visible RenderWidget.
    > 
    > Importantly, non-visible RenderWidgets include swapped out RenderWidgets
    > which are zombies, without a frame, and which should not be used.
    > 
    > This can happen if the RenderWidget swap out races with the posted task
    > from the compositor to make a LayerTreeFrameSink. When swapping out, the
    > compositor would be marked as not-visible, which would stop it from
    > making such requests, but one could already be in flight.
    > 
    > In the other case, honoring the request for a non-visible compositor is
    > more benign, but we can delay it until the compositor is actually
    > visible again. This means if a context is lost, backgrounded tabs would
    > not all attempt to reconnect to the Gpu process at once.
    > 
    > This is a better followup for the hacky
    > https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which
    > was meant only for merge to a release branch. It reverts that change as
    > part of this one.
    > 
    > R=​piman@chromium.org
    > 
    > Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7
    > Bug: 896836, 419087
    > Reviewed-on: https://chromium-review.googlesource.com/c/1292714
    > Commit-Queue: danakj <danakj@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606655}
    
    TBR=danakj@chromium.org,dcheng@chromium.org,piman@chromium.org
    
    Change-Id: I65238aba0abdb6c9192e9f3cb3691f8dd89b3ea5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 896836, 419087, 903696
    Reviewed-on: https://chromium-review.googlesource.com/c/1329003
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606807}

    Changed files

    • content/renderer/gpu/layer_tree_view.cc
    • content/renderer/gpu/layer_tree_view_delegate.h
    • content/renderer/input/widget_input_handler_impl.cc
    • content/renderer/input/widget_input_handler_manager.cc
    • content/renderer/render_frame_impl.cc
    • content/renderer/render_view_impl.cc
    • content/renderer/render_widget.cc
    • content/renderer/render_widget.h
    • content/test/stub_layer_tree_view_delegate.cc
    • content/test/stub_layer_tree_view_delegate.h
    • third_party/blink/renderer/core/exported/web_view_impl.cc
  61. Change Identity Service impl to depend only on signin internals

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24599fc67d36d611bdde3dc74d2f069491c7b9ca

    Comments

    Change Identity Service impl to depend only on signin internals
    
    Now that a distinct GN target exists just for the code backing
    IdentityManager/Identity Service, change the Identity Service
    implementation to depend only on that target. The change worked right
    out of the box -- good validation of the initial split.
    
    Bug: 901859
    Change-Id: I9b04ef952c34d9e9c0efcf137c55d41c8d616aff
    Reviewed-on: https://chromium-review.googlesource.com/c/1323649
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606806}

    Changed files

    • services/identity/BUILD.gn
  62. [Autofill Assistant] Adds loading animation for details.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 12:25:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 26202817850c96ec358bca6e4af023627108b2a7

    Comments

    [Autofill Assistant] Adds loading animation for details.
    
    Bug: 806868
    Change-Id: Ic6cb7c2450e41e6d4555e9950b15866a7167747d
    Reviewed-on: https://chromium-review.googlesource.com/c/1323651
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606805}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
  63. Revert "Reland^4 "[blink] Control ScriptStreamer with ScriptResource""

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:20:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43673375d85dfc8257c262cab39b6d62d7a81cfe

    Comments

    Revert "Reland^4 "[blink] Control ScriptStreamer with ScriptResource""
    
    This reverts commit aaeff5e6358a4b69fe1c92d30ffa04a703690879.
    
    Reason for revert: Findit thinks this CL makes delaying_onload_link_preload_after_discovery.html flaky with 70% confidence. Let's give it a shot and see if this fixes the flaking. Sorry, and let's hope the 5th reland goes better!
    
    Original change's description:
    > Reland^4 "[blink] Control ScriptStreamer with ScriptResource"
    > 
    > This is a reland of 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11
    > which was a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4,
    > which was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7,
    > which was a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
    > 
    > Relanding with no changes, seems that this wasn't the cause of
    > https://crbug.com/902832 after all.
    > 
    > Original change's description:
    > > Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
    > >
    > > This is a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4, which
    > > was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7, which was
    > > a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
    > >
    > > VR tests have been properly deflaked in https://crrev.com/c/1319715, this
    > > is otherwise unchanged.
    > >
    > > Original change's description:
    > > > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
    > > >
    > > > This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
    > > >
    > > > No changes from the original, VR flakes are caused by issues with
    > > > loadUrl and have been deflaked (see 894796 for details)
    > > >
    > > > Original change's description:
    > > > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
    > > > >
    > > > > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
    > > > >
    > > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
    > > > >
    > > > > Original change's description:
    > > > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
    > > > > >
    > > > > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
    > > > > >
    > > > > > No changes from the original, revert reason is fixed with
    > > > > > https://chromium-review.googlesource.com/c/1283037
    > > > > >
    > > > > > Original change's description:
    > > > > > > [blink] Control ScriptStreamer with ScriptResource
    > > > > > >
    > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
    > > > > > > ScriptResource. In the future, this will allow us to start streaming
    > > > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
    > > > > > > preload.
    > > > > > >
    > > > > > > The ClassicPendingScript now only sends one "finished" callback, from
    > > > > > > ScriptResource. This callback is either when the streaming completes,
    > > > > > > or when there is no streaming and the ClassicPendingScript has told
    > > > > > > the ScriptResource that it doesn't intend to start streaming. In the
    > > > > > > long run, we want all scripts to go through the streaming interface,
    > > > > > > and we want ScriptResource to control when streaming starts, so the
    > > > > > > "no more streaming" call will disappear -- however it is necessary to
    > > > > > > maintain the current behaviour, and be able to control it with a
    > > > > > > runtime flag.
    > > > > > >
    > > > > > > Bug: chromium:865098
    > > > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    > > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > > > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > > > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > > > > > > Cr-Commit-Position: refs/heads/master@{#599148}
    > > > > >
    > > > > > TBR=kouhei@chromium.org,kinuko@chromium.org
    > > > > >
    > > > > > Bug: chromium:865098
    > > > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
    > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > > > > > Cr-Commit-Position: refs/heads/master@{#601143}
    > > > >
    > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    > > > >
    > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > >
    > > > > Bug: chromium:865098
    > > > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
    > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#602310}
    > > >
    > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    > > >
    > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > >
    > > > Bug: chromium:865098
    > > > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
    > > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#605295}
    > >
    > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
    > >
    > > Bug: chromium:865098
    > > Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1318923
    > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#605815}
    > 
    > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
    > 
    > Bug: chromium:865098
    > Change-Id: I73854c4d524ab0cc8e08ef512c10334f0ab5ead4
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325921
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606448}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: I6d2bbe9085376921d819c015bf37832efe8d2d11
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098, chromium:903732
    Reviewed-on: https://chromium-review.googlesource.com/c/1328966
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606804}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  64. Revert "[autofill] add iOS helpers to get aria-label and aria-description"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:12:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62dd51a1163937c255844b681c661a78d387b4b8

    Comments

    Revert "[autofill] add iOS helpers to get aria-label and aria-description"
    
    This reverts commit 95c8ebc6e5b760aa85692b012f448c4fa10d53d6.
    
    Reason for revert: Breaks FillJsTest: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/1004
    
    JavaScript error: TypeError: __gCrWeb.fill.getAriaDescription is not a function.
    
    Original change's description:
    > [autofill] add iOS helpers to get aria-label and aria-description
    > 
    > This CL adds the getAriaLabel() and getAriaDescription() helper
    > functions to the __GCrWeb.fill "namespace". These functions return
    > the ARIA label and description strings associated with an element.
    > 
    > The ARIA Label is the text referenced by one or more containing element
    > ids in the labelled elements aria-labelledby attribute, or the value
    > of the element's aria-label attribute, with preference given to the
    > aria-labelledby attribute. For example:
    > 
    >     <div id='foo-label'>Label for Foo</div>
    >     <input name='foo' aria-labelledby='foo-label'>
    >     <input name='bar' aria-label='Label for Bar'>
    > 
    > The aria-description is similar to aria-labelledby. For example:
    > 
    >     <div id='foo-description'>Long descriptive text for Foo</div>
    >     <input name='foo' aria-describedby='foo-descrition'>
    > 
    > Bug: 896719
    > Change-Id: I300b84298fc20e1b86474f60d08cdd1c9569036b
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325032
    > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    > Commit-Queue: Roger McFarlane <rogerm@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606534}
    
    TBR=rogerm@chromium.org,sebsg@chromium.org,mahmadi@chromium.org
    
    Change-Id: I00eb534e6639c829f6ed5b312406ce51ba2aa429
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 896719
    Reviewed-on: https://chromium-review.googlesource.com/c/1329002
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606803}

    Changed files

    • components/autofill/ios/form_util/fill_js_unittest.mm
    • components/autofill/ios/form_util/resources/fill.js
  65. Roll src-internal 0ee41cbd4bf0..73158cecda02 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 12:01:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b80c161e76af7ca42437617fa5424948d0f207f

    Comments

    Roll src-internal 0ee41cbd4bf0..73158cecda02 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ee41cbd4bf0..73158cecda02
    
    
    Created with:
      gclient setdep -r src-internal@73158cecda02
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie142f038c6f81038911815c552aa5de603838b62
    Reviewed-on: https://chromium-review.googlesource.com/c/1328730
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606802}

    Changed files

    • DEPS
  66. [Autofill Assistant] All messages to the server now contain the active field trials of the client as part of the ClientContextProto.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 11:58:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 085bbd72774018acd197bab9921b470a42725408

    Comments

    [Autofill Assistant] All messages to the server now contain the active field trials of the client as part of the ClientContextProto.
    
    This will allow the server to log the field trial state, which in turn will allow us to analyze how user behavior changes with respect to the active field trials. Serializing all active field trials makes this easier to maintain at the cost of some additional message overhead and log storage. For each active field trial, the trial name and the name of the randomly selected trial group are sent.
    
    Bug: 806868
    Change-Id: I0417b3d548f36ca8c98c80182ec314e8bb20eba0
    Reviewed-on: https://chromium-review.googlesource.com/c/1326014
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#606801}

    Changed files

    • components/autofill_assistant/browser/protocol_utils.cc
    • components/autofill_assistant/browser/service.proto
  67. blink/bindings: Record compressed size and savings for ParkableString.

    Changed by Benoît Lizé - lizebohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 11:53:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d0eed3db77a5e6167b5ebbf6ecb3710790272a

    Comments

    blink/bindings: Record compressed size and savings for ParkableString.
    
    Records the total size of parkable strings, the total compressed size, the
    average compression ratio and the total savings from compression. As these
    values are correlated, separate histograms are required.
    
    The recording happens 30s after compression tasks are kicked off, provided that
    the renderer's state (foreground/background) hasn't changed in the meantime, to
    help with the interpretation of results. 30s is chosen as it's long enough for
    compression to be done, and short enough to minimize the risk of the renderer
    getting killed and/or moving back to foreground.
    
    Also remove an outdated comment in parkable_string.cc.
    
    Bug: 877044
    Change-Id: Ic8cf4a410d182387ffd1d37b23d84b5426d227cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1323549
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606800}

    Changed files

    • third_party/blink/renderer/platform/bindings/parkable_string.h
    • third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
    • third_party/blink/renderer/platform/bindings/parkable_string_manager.h
    • third_party/blink/renderer/platform/bindings/parkable_string_test.cc
    • tools/metrics/histograms/histograms.xml
  68. Import wpt@eed621bc2f995bced9481df2cead4c4632c72cdd

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:53:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 80ae982b6309cb7b9a9e8320524ef384deeed972

    Comments

    Import wpt@eed621bc2f995bced9481df2cead4c4632c72cdd
    
    Using wpt-import in Chromium f038ea3445a10c7f8116f52afe7add030b77d243.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    kojii@chromium.org:
      external/wpt/css/css-text/overflow-wrap
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I89a829c659b10bbbdfb07c86d8e997b9e9edbc08
    Reviewed-on: https://chromium-review.googlesource.com/c/1328711
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606799}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any.js
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/css/css-text/overflow-wrap/overflow-wrap-min-content-size-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-text/overflow-wrap/overflow-wrap-min-content-size-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-text/overflow-wrap/overflow-wrap-min-content-size-003.html
  69. Update V8 to version 7.2.284.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:52:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5cb8a569d871afd0b4ac8238e3edbe4b81fc6791

    Comments

    Update V8 to version 7.2.284.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c465c5ea..6130e69e
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ic5c1b7a01e1e1fb5cdc8f73ba76ff53f7d97c3bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1328712
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606798}

    Changed files

    • DEPS
  70. Roll src/third_party/perfetto 365e59b9d0c3..486203eeaffd (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:52:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e84fb354691adf1a8d49c2be3c5758718a9f8bb

    Comments

    Roll src/third_party/perfetto 365e59b9d0c3..486203eeaffd (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/365e59b9d0c3..486203eeaffd
    
    
    git log 365e59b9d0c3..486203eeaffd --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 hjd@google.com Merge "perfetto_cmd: Teach perfetto_cmd to parse pbtxt configs"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@486203eeaffd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: If1aa1235b1bf32d44d939c356c4b9b8d8bb590ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1328728
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606797}

    Changed files

    • DEPS
  71. Revert "media/gpu/VEA unittest: Test DMABuf-backed input buffers"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:31:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2ebf50601155e617b5966d1e585734cb4ffaade

    Comments

    Revert "media/gpu/VEA unittest: Test DMABuf-backed input buffers"
    
    This reverts commit c4e9ae1b9abc167c177d659dbcc3d1f794e93064.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 606788 as the
    culprit for failures in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M0ZTlhZTFiOWFiYzE2N2MxNzdkNjU5ZGJjYzNkMWY3OTRlOTMwNjQM
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-rel/5951
    
    Sample Failed Step: compile
    
    Original change's description:
    > media/gpu/VEA unittest: Test DMABuf-backed input buffers
    > 
    > This adds the command line option, --natvie_input, that VEA unittest passes
    > DMABuf-backed video frame to VEA.
    > DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    > Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    > also makes VEA unittest dependent on Ozone.
    > 
    > BUG=chromium:895230
    > TEST=VEA unittest on eve w/wo --native_input
    > 
    > Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc
    > Reviewed-on: https://chromium-review.googlesource.com/c/1295636
    > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    > Reviewed-by: Pawel Osciak <posciak@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606788}
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    BUG=chromium:895230
    
    Change-Id: I75c80e914ec2493c26b34ddb4644e53099ba6bf5
    Reviewed-on: https://chromium-review.googlesource.com/c/1328713
    Cr-Commit-Position: refs/heads/master@{#606796}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  72. Only open GCA if ARC is P or above

    Changed by Sheng-Hao Tsao - shenghaoohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 10:59:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c028d7085fdc469ffdf4efec3f9ae8d22d1e3640

    Comments

    Only open GCA if ARC is P or above
    
    This CL changes the consolidated camera app icon logic so that it
    launches GCA/GCA migration app only if ARC is P or above. This is to
    address 2 problems:
    
    1. Android N and below do not support external cameras. We would like
    users to use CCA so that they can still utilize external cameras.
    2. Managed users in Android N still have the problem where GCA could be
    stripped out.
    
    Bug: b:118860552,chromium:896140
    Test: Used N devices (caroline) with google.com account and verified
    that CCA is opened.
    
    Change-Id: I7836d2b4256856028901e5e542f460e7107fc8db
    Reviewed-on: https://chromium-review.googlesource.com/c/1316982
    Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606795}

    Changed files

    • chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
  73. [Autofill Assistant] Checkbox for terms acceptance.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 652ddcf5b36955638fa64b013c88c0dd2f939fd8

    Comments

    [Autofill Assistant] Checkbox for terms acceptance.
    
    This patch introduces a checkbox in the Autofill Assistant payment request UI.
    The state of which is communicated in the processed action results to
    the backend.
    
    This logic only exists on the Java side and is opaquely passed through
    the c++ layer.
    
    Issue: b/117920169
    Screenshot: https://screenshot.googleplex.com/iiHvY18nLqn.png
    
    Bug: 806868
    Change-Id: Ica17176c4cac695c126d1d5695a8b7e5a31020e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1316770
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606794}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
    • components/autofill_assistant/browser/payment_information.h
    • components/autofill_assistant/browser/service.proto
    • components/autofill_assistant_strings.grdp
  74. Change feature flag of Custom Search Engine to be enabled by default.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:53:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fbf09d888ad3453558caf7ba438acf381860d8a

    Comments

    Change feature flag of Custom Search Engine to be enabled by default.
    
    The feature of Custom Search Engine is nearly finished and ready to be
    tested. Chnage the feature flag to be enabled by default.
    
    Bug: 433824
    Change-Id: Ied1d61b1df73bd8ceee89a2088e3e53418cbf856
    Reviewed-on: https://chromium-review.googlesource.com/c/1326002
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606793}

    Changed files

    • ios/chrome/browser/search_engines/feature_flags.cc
  75. WebRequestProxyingURLLoader: Close the current loader before internal redirect.

    Changed by Arthur Sonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4d3cf41c0598cf64570d293b73399c0f82ba7ccd

    Comments

    WebRequestProxyingURLLoader: Close the current loader before internal redirect.
    
    Please see the explanation here:
    https://bugs.chromium.org/p/chromium/issues/detail?id=882661#c72
    
    Generating a fake internal redirect causes conflicts with what the
    current URLLoader is doing. The latter doesn't know anything about the
    redirect. To work properly, the current URLLoader must be destroyed
    first. The current code automatically handles creating a new
    URLLoader after FollowRedirect().
    
    Bug: 882661
    Change-Id: Ib17dc2f29a2c63da735794b4792ef7805e7dbc58
    Reviewed-on: https://chromium-review.googlesource.com/c/1326481
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606792}

    Changed files

    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
  76. Support ::placeholder after ::slotted().

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:48:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cd41aa340d600b3c1f1725d94c2e06e11635531

    Comments

    Support ::placeholder after ::slotted().
    
    Tree-abiding pseudo elements are allowed after ::slotted() according to
    css-scoping-1. According to css-pseudo-4 they are ::before, ::after,
    ::marker, and ::placeholder. We already allowed ::before and ::after. We
    do not support ::marker. This CL allows ::placeholder.
    
    TEST=external/wpt/css/css-scoping/slotted-parsing.html
    TEST=external/wpt/css/css-scoping/slotted-placeholder.html
    
    Bug: 902518
    Change-Id: I963fa93e68c8fbd33fc8090e930be9a00f3c9bd4
    Reviewed-on: https://chromium-review.googlesource.com/c/1323049
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Fergal Daly <fergal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606791}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/css/css-scoping/slotted-parsing-expected.txt
    • third_party/blink/renderer/core/css/css_selector.cc
    • third_party/blink/renderer/core/css/css_selector.h
    • third_party/blink/renderer/core/css/parser/css_parser_selector.h
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
  77. Roll src/third_party/skia 22b0ec4f83aa..88e15bdaf539 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:47:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f21161ed54556a4f278ed78747e7f96f4ad924d3

    Comments

    Roll src/third_party/skia 22b0ec4f83aa..88e15bdaf539 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/22b0ec4f83aa..88e15bdaf539
    
    
    git log 22b0ec4f83aa..88e15bdaf539 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
    2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d856ca48f425..5d2dfa46c05c (2 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@88e15bdaf539
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I669e2dcceb60198f833772e058db4e4ffd2de923
    Reviewed-on: https://chromium-review.googlesource.com/c/1328723
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606790}

    Changed files

    • DEPS
  78. Roll src-internal 53aa50a0dced..0ee41cbd4bf0 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:45:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8de008a2a6f8d8eaec1b095550660cb5322551e9

    Comments

    Roll src-internal 53aa50a0dced..0ee41cbd4bf0 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53aa50a0dced..0ee41cbd4bf0
    
    
    Created with:
      gclient setdep -r src-internal@0ee41cbd4bf0
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I97a39edb26a9fcecef541f317a1788d833f9fa14
    Reviewed-on: https://chromium-review.googlesource.com/c/1328727
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606789}

    Changed files

    • DEPS
  79. media/gpu/VEA unittest: Test DMABuf-backed input buffers

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:41:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c4e9ae1b9abc167c177d659dbcc3d1f794e93064

    Comments

    media/gpu/VEA unittest: Test DMABuf-backed input buffers
    
    This adds the command line option, --natvie_input, that VEA unittest passes
    DMABuf-backed video frame to VEA.
    DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    also makes VEA unittest dependent on Ozone.
    
    BUG=chromium:895230
    TEST=VEA unittest on eve w/wo --native_input
    
    Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1295636
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606788}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  80. Fix declaration of override method in IdentityManagerObserverBridge

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 10:36:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6586665e93e9211f934364c00eee32433027df9

    Comments

    Fix declaration of override method in IdentityManagerObserverBridge
    
    IdentityManager::OnRefreshTokenRemovedForAccount() expects as a first
    parameter a "const std::string&" instead of a "const AccountInfo&",
    so this patch fixes it to prevent build failures when using this API
    because of OnRefreshTokenRemovedForAccount(const AccountInfo&) not
    being a valid override for the virtual method declared.
    
    Bug: 903391
    Change-Id: I46cd6778240a40af6863ca7fd3b8d9a88e735fde
    Reviewed-on: https://chromium-review.googlesource.com/c/1327161
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#606787}

    Changed files

    • services/identity/public/objc/identity_manager_observer_bridge.h
    • services/identity/public/objc/identity_manager_observer_bridge.mm
  81. Reland "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow"

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:35:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision de3b8c8dbf530a94a15e660ecb2b9cd80a7f9843

    Comments

    Reland "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow"
    
    This is a reland of b43c6fca4349b7f2ff53b41926f5d7cb42ee4e0f
    
    The original CL had moved a call to ToString() to within
    DCHECK, because the result is used only by DCHECK. But the
    ToString() has a side effect that must be performed.
    
    Because of the change, this CL breaks if DCHECK is not
    enabled. Unfortunately, no build configs in trybots and
    CQs have DCHECK disabled.
    
    Reverted the change, and added TODO to clean it up.
    
    Original change's description:
    > Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow
    >
    > This patch allows computing NGOffsetMapping for legacy inline
    > formatting context.
    >
    > For an experimental project "Invisible DOM"[1][2] to support
    > the find-in-page feature, it is needed to compute the text
    > content with whitespace collapsing applied, along with the
    > mapping to the DOM offset. This patch adds an API to compute
    > NGOffsetMapping even when the LayoutBlockFlow is not laid out
    > by LayoutNG for that purpose.
    >
    > Note that the project is still in the early phase. We may
    > revisit the design as it moves forward.
    >
    > [1] https://github.com/rakina/searchable-invisible-dom
    > [2] https://www.chromestatus.com/feature/5105291213406208
    >
    > Bug: 636993, 873057
    > Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882
    > Reviewed-on: https://chromium-review.googlesource.com/c/1322184
    > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    > Reviewed-by: Emil A Eklund <eae@chromium.org>
    > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    > Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
    > Commit-Queue: Koji Ishii <kojii@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606292}
    
    TBR=yoshin@chromium.org, eae@chromium.org, xiaochengh@chromium.org, rakina@chromium.org
    
    Bug: 636993, 873057
    Change-Id: I8a29073fb18a1349d758d37033e6b046a54d5beb
    Reviewed-on: https://chromium-review.googlesource.com/c/1327582
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606786}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_offset_mapping_test.cc
  82. Document ContentSettings.Exceptions.media-engagement.

    Changed by Balazs Engedy - engedyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:28:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d8eed38bec9b93351d1e3cd65f981380acf6e3c

    Comments

    Document ContentSettings.Exceptions.media-engagement.
    
    Add the missing histogram suffix `media-engagement` to histograms.xml.
    This is the content setting type with by far the largest number of
    exceptions, yet missing from the dashboards.
    
    Bug: 890129
    Change-Id: Iaca89cf7b28db59a9d3c9baf3f810e765a8308a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1326147
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606785}

    Changed files

    • tools/metrics/histograms/histograms.xml
  83. Roll src/third_party/depot_tools 98c0fdb927c4..6edb632ff8cd (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:25:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1fdb6589087a7a301a61113f8b7fca1fb70bc52

    Comments

    Roll src/third_party/depot_tools 98c0fdb927c4..6edb632ff8cd (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98c0fdb927c4..6edb632ff8cd
    
    
    git log 98c0fdb927c4..6edb632ff8cd --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 vadimsh@chromium.org [cipd] Bump CIPD client and vpython versions.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@6edb632ff8cd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ic57f994925c49696f5f1f3da863df1b317081f7e
    Reviewed-on: https://chromium-review.googlesource.com/c/1328523
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606784}

    Changed files

    • DEPS
  84. Create target in //components/signin for shared code

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:24:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9

    Comments

    Create target in //components/signin for shared code
    
    //components/signin/core/browser contains three different types of code:
    
    1. Code that forms the guts of IdentityManager and will form the guts of
    the Identity Service implementation (e.g., SigninManager).
    
    2. Code that will be clients of IdentityManager (e.g., SigninTracker).
    
    3. Code that will be used on both sides (e.g., AccountInfo).
    
    1 and 2 have already been split via a preceding CL. This CL creates 3.
    To start off with, 3 contains two pieces of code that were already in
    their own standalone targets for similar motivations as the above:
    account_info.* and signin_metrics.*. In the future more code will
    likely move in.
    
    Bug: 901859
    Change-Id: Ibcae3c9f1ecff2dc7ccd013046b74c97b3dd2b7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323114
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606783}

    Changed files

    • components/autofill/core/browser/BUILD.gn
    • components/signin/core/browser/BUILD.gn
    • components/sync/BUILD.gn
    • ios/chrome/browser/ui/authentication/BUILD.gn
    • services/identity/BUILD.gn
    • services/identity/public/cpp/BUILD.gn
    • services/identity/public/cpp/account_info.typemap
  85. Automated Commit: LKGM 11244.0.0 for chromeos.

    Changed by 3su6n15k.default@developer.gserviceaccount.com - 3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:24:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c814268e0605b5134669e52db357d13aadd08fb

    Comments

    Automated Commit: LKGM 11244.0.0 for chromeos.
    
    BUG=762641
    TBR=rkc@chromium.org
    
    Change-Id: Ic280acd363864f15e43d89b7ee466b554fc2e614
    Reviewed-on: https://chromium-review.googlesource.com/c/1328841
    Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606782}

    Changed files

    • chromeos/CHROMEOS_LKGM
  86. Prevent use-after-free in SiteEngagementService.

    Changed by Balazs Engedy - engedyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:12:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70115b4df17a675652ef65521ba6ddf81f59037

    Comments

    Prevent use-after-free in SiteEngagementService.
    
    The profile and its KeyedServices are normally destroyed before the
    TaskScheduler shuts down background threads, so the background task to
    record site engagement metrics needs to avoid using any members of
    SiteEngagementService
    
    Bug: 900022
    Change-Id: Ibdebbd5a64d59fad29b7715be3557eeed411d741
    Reviewed-on: https://chromium-review.googlesource.com/c/1326441
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606781}

    Changed files

    • chrome/browser/engagement/site_engagement_service.cc
  87. Do style propagation to generated content in LayoutObject.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:07:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a944866662c9cd3841c2cc1c8e8335ff6fd838e4

    Comments

    Do style propagation to generated content in LayoutObject.
    
    It belongs with the other anonymous LayoutObject propagation code.
    There are still two loops for pseudo elements where we propagate style
    to anonymous table boxes like before but propagate style from the
    pseudo element to the generated content directly, skipping other
    anonymous boxes, in a separate loop. This is just keeping the same
    functionality for generated content without trying to propagate style
    through others anonymous boxes. Left a TODO for that.
    
    Change-Id: I3c38bc9d831b8a767fd601d47e4db0f81923ba47
    Reviewed-on: https://chromium-review.googlesource.com/c/1328041
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606780}

    Changed files

    • third_party/blink/renderer/core/dom/pseudo_element.cc
    • third_party/blink/renderer/core/dom/pseudo_element.h
    • third_party/blink/renderer/core/layout/layout_object.cc
  88. Revert "Route SSLPrivateKey provider names into NetLog."

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:06:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe2afddb677e9cf62b0f24c9dd2b176156d34a7

    Comments

    Revert "Route SSLPrivateKey provider names into NetLog."
    
    This reverts commit db889e10709b97c8e0c872e167cef871147afcdb.
    
    Reason for revert: Speculative revert: A bunch of SSL related tests failing on Mac: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36146
    
    Original change's description:
    > Route SSLPrivateKey provider names into NetLog.
    > 
    > Improve debugging in the future so we don't have to keep asking "are you
    > using a smartcard? which?".
    > 
    > Bug: none
    > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > Change-Id: Ifbaf6f5aa0aa73dcd19be0ccc0046c2c2c069319
    > Reviewed-on: https://chromium-review.googlesource.com/c/1292509
    > Commit-Queue: David Benjamin <davidben@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606700}
    
    TBR=rsleevi@chromium.org,kinuko@chromium.org,davidben@chromium.org,emaxx@chromium.org
    
    Change-Id: Icb8db36c96ba199e0857296cd21fa9d3e8826c90
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/c/1328882
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606779}

    Changed files

    • chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
    • chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc
    • content/browser/network_service_client.cc
    • net/android/java/src/org/chromium/net/AndroidKeyStore.java
    • net/android/keystore.cc
    • net/android/keystore.h
    • net/log/net_log_event_type_list.h
    • net/socket/ssl_client_socket_impl.cc
    • net/ssl/ssl_client_auth_cache_unittest.cc
    • net/ssl/ssl_platform_key_android.cc
    • net/ssl/ssl_platform_key_mac.cc
    • net/ssl/ssl_platform_key_nss.cc
    • net/ssl/ssl_platform_key_win.cc
    • net/ssl/ssl_private_key.h
    • net/ssl/test_ssl_private_key.cc
    • net/ssl/threaded_ssl_private_key.cc
    • net/ssl/threaded_ssl_private_key.h
    • net/url_request/url_request_unittest.cc
    • services/network/public/mojom/network_service.mojom
    • services/network/url_loader.cc
    • services/network/url_loader.h
    • services/network/url_loader_unittest.cc
  89. Revert "Enable unified garbage collections part two"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:03:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9453dfbffd2000b3eafab2a59169da733d8cf08a

    Comments

    Revert "Enable unified garbage collections part two"
    
    This reverts commit 79ffe683c7cc22ab3478b119adcc9b49584bd9e2.
    
    Reason for revert: Speculative revert: lots of garbage-collection related failures on WebKit Linux Trusty ASAN (see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/17912)
    
    Original change's description:
    > Enable unified garbage collections part two
    > 
    > This flag overrides the default Blink value for content layer.
    > 
    > Sheriffs: This is a dry-run of the feature and will be reverted after
    > cycling through the waterfall and performance bots.
    > 
    > Tbr: jochen@chromium.org, lfg@chromium.org
    > Bug: 843903
    > Change-Id: Ie362301e4874198eb775346d051bf8267837aaf8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1320970
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Reviewed-by: Hannes Payer <hpayer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606446}
    
    TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org,lfg@chromium.org
    
    Change-Id: I189aca41c8f8ba11c358a4c15bc7f56591e38196
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 843903
    Reviewed-on: https://chromium-review.googlesource.com/c/1328902
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606778}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • content/public/common/content_features.cc
    • third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/gc-9-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt
  90. Move context state related methods out of DecoderContext

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:03:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bea0d6b3c467e05183fb88d06a829a6d7e7d136a

    Comments

    Move context state related methods out of DecoderContext
    
    This CL adds a new GLContextVirtualDelegate interface to contain all
    context state related methods from DecoderContext. After this one, I am
    going to implement GLContextVirtualDelegate in RasterDecoderContextState
    and only create one GLContextVirtual for all raster decoder and display
    compositor.
    
    Bug: 900941, 902904
    Change-Id: I10d80bea8531885c449a2e676ce0552e9363b34c
    Reviewed-on: https://chromium-review.googlesource.com/c/1312338
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606777}

    Changed files

    • gpu/command_buffer/service/BUILD.gn
    • gpu/command_buffer/service/decoder_context.h
    • gpu/command_buffer/service/gl_context_virtual.cc
    • gpu/command_buffer/service/gl_context_virtual.h
    • gpu/command_buffer/service/gl_context_virtual_delegate.h
    • gpu/command_buffer/service/gl_state_restorer_impl.cc
    • gpu/command_buffer/service/gl_state_restorer_impl.h
    • gpu/command_buffer/service/raster_decoder.cc
    • gpu/command_buffer/service/raster_decoder_context_state.cc
    • gpu/command_buffer/service/raster_decoder_context_state.h
    • gpu/command_buffer/service/wrapped_sk_image.cc
  91. Add custom search engines list in Search Engine Settings.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:45:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b549d861a796421a3907cb9a62eec272c2a0359

    Comments

    Add custom search engines list in Search Engine Settings.
    
    This CL changes how search engines are displayed in Search Engine Settings.
    
    Previous(1 list):
      1. search engines that are prepopulated or created by policy.
    
    Current(2 lists):
      1. Search engines that are prepopulated or created by policy, and possibly
         one custom search engine at the end if it's selected as default search
         engine;
      2. All remaining search engines.
    
    Unittests are also updated.
    
    Bug: 433824
    Change-Id: Ib70a18f0544101760c331bb349ee9818956ed231
    Reviewed-on: https://chromium-review.googlesource.com/c/1323509
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606776}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm
    • ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller_unittest.mm
  92. Remove ReadableStreamOperations use from BodyStreamBuffer

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:44:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6105631e4f6362a083d8ad05999f21fc7918b67f

    Comments

    Remove ReadableStreamOperations use from BodyStreamBuffer
    
    Replace use of ReadableStreamOperations in BodyStreamBuffer with
    ReadableStream. This CL doesn't change the behavior.
    
    Bug: 894357, 888165, 902633
    
    Change-Id: Icd478dcc59ca86e020d540229d69f0c61fb689c0
    Reviewed-on: https://chromium-review.googlesource.com/c/1319408
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606775}

    Changed files

    • third_party/blink/renderer/core/fetch/body.cc
    • third_party/blink/renderer/core/fetch/body.h
    • third_party/blink/renderer/core/fetch/body_stream_buffer.cc
    • third_party/blink/renderer/core/fetch/body_stream_buffer.h
    • third_party/blink/renderer/core/fetch/request.cc
    • third_party/blink/renderer/core/fetch/response.cc
    • third_party/blink/renderer/core/fetch/response.h
    • third_party/blink/renderer/core/streams/readable_stream.cc
    • third_party/blink/renderer/core/streams/readable_stream.h
    • third_party/blink/renderer/core/streams/readable_stream_operations.cc
    • third_party/blink/renderer/core/streams/readable_stream_operations.h
    • third_party/blink/renderer/core/streams/readable_stream_operations_test.cc
    • third_party/blink/renderer/core/streams/readable_stream_test.cc
  93. Migrate clear_browsing_data_manager_unittest.mm to the Identity service

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 09:43:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b72eeec68ad1991b2f2989eb599e7486fe6a2b04

    Comments

    Migrate clear_browsing_data_manager_unittest.mm to the Identity service
    
    Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually
    creating the browser's state by providing specific factories, and then
    use the APIs from IdentityTestEnvironment, instead of SigninManagerBase.
    
    Bug: 890826
    Change-Id: Id9d422e002d8fd2edc0ef1ad158f29e95c6dce64
    Reviewed-on: https://chromium-review.googlesource.com/c/1318974
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606774}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager_unittest.mm
  94. [ios] add manual fallback credit card and address view controller

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 09:38:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d9f5a2e523469d0570b1b9ae0bc5818523b2528b

    Comments

    [ios] add manual fallback credit card and address view controller
    
    Added base class that should be used in passwords later.
    
    Bug: 845472
    Change-Id: I1c1d2204d920ae141448239cfeb1c1c5a0e93a20
    Reviewed-on: https://chromium-review.googlesource.com/c/1319714
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606773}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
  95. Roll src-internal 27fe62b3b2f9..53aa50a0dced (4 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 09:15:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fd575eafdb7ca5f5800c6b866836f84583ea6baf

    Comments

    Roll src-internal 27fe62b3b2f9..53aa50a0dced (4 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27fe62b3b2f9..53aa50a0dced
    
    
    Created with:
      gclient setdep -r src-internal@53aa50a0dced
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I0ceb97585997b51d4374733c0324a20c8d817333
    Reviewed-on: https://chromium-review.googlesource.com/c/1328724
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606772}

    Changed files

    • DEPS
  96. [Autofill Assistant] Allow FocusAction to restrict access to some elements

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:13:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32d31b5886e3493539864668484205446da536e4

    Comments

    [Autofill Assistant] Allow FocusAction to restrict access to some elements
    
    This change allows a focus action to provide a list of elements that can
    be accessed. On a touch event, the position of the touch is compared
    against the position of the elements before forwarding the event to the
    webpage (or not).
    
    The position of the element is updated periodically or after a scroll
    event.
    
    Currently, touches are just swallowed. A follow-up change will make it
    clear what's going on and offer alternatives.
    
    By default, the new behavior is disabled.
    
    Bug: 806868
    Change-Id: I5bce26d3a4a81a7167253b564ca416364d18b61e
    Reviewed-on: https://chromium-review.googlesource.com/c/1323489
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606771}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/TouchEventFilter.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/BUILD.gn
    • components/autofill_assistant/browser/actions/action_delegate.h
    • components/autofill_assistant/browser/actions/focus_element_action.cc
    • components/autofill_assistant/browser/actions/focus_element_action.h
    • components/autofill_assistant/browser/actions/mock_action_delegate.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/element_area.cc
    • components/autofill_assistant/browser/element_area.h
    • components/autofill_assistant/browser/element_area_unittest.cc
    • components/autofill_assistant/browser/mock_run_once_callback.h
    • components/autofill_assistant/browser/mock_web_controller.h
    • components/autofill_assistant/browser/script_executor.cc
    • components/autofill_assistant/browser/script_executor.h
    • components/autofill_assistant/browser/service.proto
    • components/autofill_assistant/browser/ui_delegate.h
    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
  97. [On-device adaptive brightness] Implement a controller and add to browser.

    Changed by Jia - jiamengohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:03:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b49a0794f0b3f63af3e073891b1385150aa1d449

    Comments

    [On-device adaptive brightness] Implement a controller and add to browser.
    
    Bug: 881215
    Change-Id: I504764bd39f586d07e67eef1443565d4235a6a2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1322256
    Reviewed-by: Dan Erat <derat@chromium.org>
    Commit-Queue: Jia Meng <jiameng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606770}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/chromeos/power/auto_screen_brightness/controller.cc
    • chrome/browser/chromeos/power/auto_screen_brightness/controller.h
  98. Import wpt@a996d2028df7fe48935f1e8303cbd49dfb6a59d7

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 08:35:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f038ea3445a10c7f8116f52afe7add030b77d243

    Comments

    Import wpt@a996d2028df7fe48935f1e8303cbd49dfb6a59d7
    
    Using wpt-import in Chromium 7963defbe26e7bc44b4a127e7745fd14af81a52b.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    mstensho@chromium.org:
      external/wpt/css/css-multicol
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I19c1f1a503fec2ad9086489fb20d598cb03b8a1b
    Reviewed-on: https://chromium-review.googlesource.com/c/1328706
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606769}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-001-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-002-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-003-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-003.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-004-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-004.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-005.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-006.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-007-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-007.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-008-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-008.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-001-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-002-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-003.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-004-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-004.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-005-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-005.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-006.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-001-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-002-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-003-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-003.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-004-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-004.html
  99. Roll AFDO from 72.0.3605.2_rc-r1 to 72.0.3606.0_rc-r1

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 08:20:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c07a8c78aad274d110c41bc9c9fece6047918a

    Comments

    Roll AFDO from 72.0.3605.2_rc-r1 to 72.0.3606.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    Please note that, despite rolling to chrome/android, this profile is
    used for both Linux and Android.
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I203aa13a2da986403ddb642a29a20ed3069e1e09
    Reviewed-on: https://chromium-review.googlesource.com/c/1328725
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606768}

    Changed files

    • chrome/android/profiles/newest.txt
  100. Remove Channel ID from safe browsing code

    Changed by Nick Harper - nharperohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 08:17:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5314e7019baec0418f43d3220daf620ccda8928

    Comments

    Remove Channel ID from safe browsing code
    
    Bug: 875053
    Change-Id: I4687640650ac9120acbacbc82dcfe9b0ccb87451
    Reviewed-on: https://chromium-review.googlesource.com/c/1325567
    Commit-Queue: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606767}

    Changed files

    • components/safe_browsing/browser/safe_browsing_network_context.cc
    • components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc
    • components/safe_browsing/browser/safe_browsing_url_request_context_getter.h
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>