Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 (dbg) Build 4199 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisiond7bfd5bb2031d217d0e0f87240b4ce16705abb3d
Got Revisiond7bfd5bb2031d217d0e0f87240b4ce16705abb3d

Execution:

Steps and Logfiles:

Show:
  1. ( 667 ms ) setup_build
    running recipe: "chromium"
  2. ( 241 ms ) report builders
     
    running tester 'Win10 Tests x64 (dbg)' on master 'chromium.win'
  3. ( 6 secs ) taskkill
  4. ( 1 mins 21 secs ) bot_update
    [52GB/299GB used (17%)]
  5. ( 2 secs ) swarming.py --version
    0.13
  6. ( 19 secs ) gclient runhooks
  7. ( 675 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 496 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 1 secs ) build directory
  10. ( 389 ms ) find isolated tests
  11. ( 30 mins 49 secs ) content_browsertests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:33:30.915647
  12. ( 2 secs ) extensions_browsertests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:24.202573
  13. ( 2 secs ) interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:15:01.556210 (shard #2)
    Min shard duration: 0:11:47.922656 (shard #1)
  14. ( 3 secs ) network_service_interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:15:29.311213 (shard #2)
    Min shard duration: 0:12:33.541742 (shard #1)
  15. ( 2 secs ) webui_polymer2_interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:19.814349
  16. ( 3 secs ) sync_integration_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:19:43.005209
  17. ( 2 secs ) content_shell_crash_test (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:04.057218
    Total tests: n/a
     
  18. ( 2 secs ) performance_test_suite (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:03:12.394510 (shard #0)
    Min shard duration: 0:03:11.050704 (shard #1)
    Total tests: 2
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 1 (1 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  19. ( 3 secs ) telemetry_unittests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:06:55.380225 (shard #2)
    Min shard duration: 0:06:17.056325 (shard #3)
    Total tests: 1141
    * Passed: 1034 (1034 expected, 0 unexpected)
    * Skipped: 107 (107 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  20. ( 1 secs ) wait for tasks
  21. ( 2 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  22. ( 2 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  23. ( 2 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  24. ( 3 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 57s
  25. ( 2 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  26. ( 2 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:19.068306
  27. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:20.879658
  28. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  29. ( 2 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  30. ( 2 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  31. ( 4 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:52.747410
  32. ( 3 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  33. ( 2 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  34. ( 2 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  35. ( 2 secs ) gcp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  36. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:18.606864
  37. ( 2 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  38. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 36s
  39. ( 3 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:02.651216
  40. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:01.534852
  41. ( 3 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  42. ( 2 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  43. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:25.347283
  44. ( 2 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  45. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  46. ( 3 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:22.866174
  47. ( 2 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:40.757919
  48. ( 4 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:49.104462
  49. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  50. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  51. ( 4 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:24.548487
  52. ( 3 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 47s
  53. ( 2 secs ) metrics_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  54. ( 2 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  55. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  56. ( 3 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:37.139170
  57. ( 15 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:21:18.566511
  58. ( 2 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:11.563997
  59. ( 2 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  60. ( 2 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  61. ( 2 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  62. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  63. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  64. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  65. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:05.460329
  66. ( 4 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  67. ( 2 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 47s
  68. ( 9 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:09:29.767612
  69. ( 6 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:22.457602
  70. ( 2 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  71. ( 2 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
  72. ( 2 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  73. ( 2 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  74. ( 2 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  75. ( 2 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  76. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:13.579441
  77. ( 2 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  78. ( 2 secs ) views_perftests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
    Total tests: n/a
     
  79. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 45s
  80. ( 2 secs ) telemetry_gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:09.996759
    Total tests: 38
    * Passed: 38 (38 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  81. ( 2 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  82. ( 2 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  83. ( 2 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  84. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  85. ( 2 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 46s
  86. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  87. ( 2 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  88. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  89. ( 2 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  90. ( 2 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  91. ( 8 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:12:25.224888
  92. ( 2 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  93. ( 3 secs ) webkit_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
    Total tests: 1578
    * Passed: 1562 (1562 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  94. ( 3 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:09.775089
  95. ( 2 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  96. ( 2 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  97. ( 2 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:13.068251
  98. ( 2 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  99. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  100. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  101. ( 8 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:05:02.755374
  102. ( 2 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  103. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 36s
  104. ( 2 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  105. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  106. ( 2 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  107. ( 2 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  108. ( 2 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  109. ( 2 secs ) viz_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:17.284227
  110. ( 2 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 49s
  111. ( 2 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  112. ( 2 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  113. ( 2 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:07.633860
  114. ( 2 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 43s
  115. ( 237 ms ) Tests statistics
     
    Stats
    Total shards: 111
    Total runtime: 4:05:35.364000
     
  116. ( 1 secs ) process_dumps
  117. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-b-cnn9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541782417884201, "id": "8930317675343498032", "project": "chromium", "tags": ["builder:Win10 Tests x64 (dbg)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/d7bfd5bb2031d217d0e0f87240b4ce16705abb3d", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder (dbg)", "parent_buildnumber:77151", "scheduler_invocation_id:9095747737550142544", "scheduler_job_id:chromium/Win10 Tests x64 (dbg)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 Tests x64 (dbg)" setup_build
buildnumber 4199 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder (dbg)" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "d7bfd5bb2031d217d0e0f87240b4ce16705abb3d" setup_build
parent_got_revision_cp "refs/heads/master@{#606865}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.286@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "d7bfd5bb2031d217d0e0f87240b4ce16705abb3d" setup_build
swarm_hashes {"accessibility_unittests": "36e24e70c352efc5505afec8aa757133f116972b", "angle_unittests": "38538adaa2c02781c7cf9c906e9420739fbb1f19", "app_shell_unittests": "25ac3dc95b47df6891970d3dbb736520dfaf18a7", "aura_unittests": "ef97fdc6465eee13062768d9e8105b759f7471e4", "base_unittests": "c3d74aca189feec022054482b13976e2497b52e9", "blink_common_unittests": "03155addbc447049a5f5be10193f0ef99f5886c4", "blink_fuzzer_unittests": "4d0fd4d5cbf2a5d8b2e00ddb8c0b67de1706ad10", "blink_heap_unittests": "6202df5d4f4b40a5058f6b9676d2c83d1b202893", "blink_platform_unittests": "05eb152d1365666f460ff4789cda46f14fe28a7d", "boringssl_crypto_tests": "6b7f8cb4b2213e1b4cb420dc795ad5bc68afc86f", "boringssl_ssl_tests": "df89fed29473c9e0bb4461b255041d4664bbd2ae", "cacheinvalidation_unittests": "88e2d5329fb02e448534d4b252b738b82f34507d", "capture_unittests": "5b38d65c013fabbb730a6768b572bba0897bd9d0", "cast_unittests": "54c15f56502b22f11a37e6a615f03dd321d091bd", "cc_unittests": "5228b8b4e772924bc9b3f48c87d496b0dd9a1f27", "chrome_app_unittests": "2b66fcac3b28d933e494685bdaa88d5c77f3f362", "chrome_cleaner_unittests": "333477b9a4111f276ce3721798f74465c2d0ace1", "chrome_elf_import_unittests": "dcd79b4bcf619ca7b7376fa8b2e59a350f7354f3", "chrome_elf_unittests": "8dba9c3098a214d4311cf8b2dc95a0cae473c12d", "chromedriver_unittests": "049afd38a7a9c42a40cf27884b537d55b6d0890a", "components_browsertests": "d844867abe3b44ef8a0d8c91b0dc256dcdf44cc6", "components_unittests": "662774d1cad38f9fda9c97ad4ec347c35c4a225d", "compositor_unittests": "c5f0cb35ad12704b861c74bdcbf844486e69657d", "content_browsertests": "62379010debcfe13cf2fa292514af1c6519ab4bb", "content_shell_crash_test": "38cc2d3ecb686b2792ebcbd93cfce67ba6c53c94", "content_unittests": "6e5ceae611fafaa0b9dd87e1d3ac06344c9be005", "courgette_unittests": "b4bbb212a3f268369171752739f3d173deb550d0", "crashpad_tests": "66e066dea096de93d31e846310add671c15f84d3", "cronet_tests": "de8e18eefdfe5326900fcab90b3cdda93893f055", "cronet_unittests": "327d48a7749d839eb9ac7bd87617d3639a2bf6bb", "crypto_unittests": "5e435d971b7df93b29da146b25e9a8d2b498e7a6", "device_unittests": "44aa0b4d4053b544677c8f3f0c0462743173f793", "display_unittests": "d7a4eab21fa9a6b356f5e1fdb79efabff2d7ee89", "elevation_service_unittests": "b28607aa93759240ac694a0a9c691cd9d314eb79", "events_unittests": "043ed68c6e7d6683cd6ccfe35a5fd379c2025def", "extensions_browsertests": "bc141e025c9375233d070adad006f8aad518333c", "extensions_unittests": "bf66943498ef76a7de07dbf7bb085de13932da2b", "filesystem_service_unittests": "2c4f3504e4e181ff295e1f81d1d0efcc5e22a0f8", "gcm_unit_tests": "22cdca60da08cfb72cb2190ae0ff4f947337a3c5", "gcp_unittests": "9f4592c5fa7428c15569a274c6ca3316b449d71a", "gfx_unittests": "404a2b41258eabd49e16007365a6d22b8e679ca7", "gin_unittests": "1679b61a14b38ce5a20ce48ee4379ccd15fdcbce", "google_apis_unittests": "f7feed84e41e5beef28a799615252508398e72b9", "gpu_unittests": "d7edc4378ee0e6b12891242a629f0440805cf60d", "headless_browsertests": "c7ac5f78de4f53dccbffaf2038438bd5992ed865", "headless_unittests": "b7f3d99136acc8ded2c0c86cf5f806753750295b", "install_static_unittests": "349cee3c2718166cfba8337f12427fa0c7dfe9a9", "installer_util_unittests": "32f8a1241827f377814dd0422362957b21a3812f", "interactive_ui_tests": "786ed76468d7c878a81cef7b86d0d4f44e3ca3a1", "ipc_tests": "0150f521ce002e08dbced01d8ac6452f889a14d8", "jingle_unittests": "746c1ee1614e65a332b4e3ae1c98d55d448e561c", "latency_unittests": "4d4f6d3d37153c4b3c09787c00bbf17ee1343bf3", "leveldb_service_unittests": "b22279c1faeefc830e647bc16636af7f355a902d", "libjingle_xmpp_unittests": "261db33a97c6805c09257e04a02e1ad95ea93f95", "media_blink_unittests": "ea1c99a06727bfb7ab3be96c5f2ff883147e1bea", "media_service_unittests": "98ed967c68c60f5aafd7ea042a37fcd56f585e64", "media_unittests": "418dcf8a5afc521cacc36b3b25e3d9d77fec58e9", "message_center_unittests": "6af39c6b8e74ec32c2963762998a998c144cf2e3", "metrics_python_tests": "e41a1ac1f1a3b8e8629f3029649e47615cbff1b0", "midi_unittests": "f590fc093f1d0d26af0e85b0300bbac02a0db80e", "mojo_core_unittests": "340587eab0ccf2b77c0967c2acf71566b0047bef", "mojo_unittests": "fbe92037f5a92adae37f37c88b4183a15d1e89c4", "nacl_loader_unittests": "8d90557cd00c6159bed5a151e308112c6706fc31", "native_theme_unittests": "e1a2ddf1fa586b8e1922735fd10134a2ec28658b", "net_unittests": "8449c890ffb3dc7e63668b4cdd47c5d361bcfca4", "notification_helper_unittests": "306fb4915e39989460956c8cb96bea5785ec0363", "pdf_unittests": "733056ec7b81d5f244dc4568777816f3a014352a", "performance_test_suite": "d64dab4defb6982a399132f93eeee791966eb0af", "ppapi_unittests": "16ee2223390bdccead02b6c1663db7d29f874b4c", "printing_unittests": "5f1485125374a0f0af02890d97df846799d30c4d", "remoting_unittests": "ab47ba546755c7e85b6a80117aaf2fce64d10275", "sbox_integration_tests": "dffd4968a3a13b53a060be240477e95e0ebbbb80", "sbox_unittests": "e7899e0dd696e6d473aa4c94f3407ef340ec15f5", "sbox_validation_tests": "2c7aeb674e2563aec2060125478ca60a250cb17d", "service_manager_unittests": "4d8d64886fffe5744332e44af73ecb34699b0d7f", "services_unittests": "043f1a4c62bbf17b72c647ca1888ec0ff093f20f", "setup_unittests": "da9fa53a80d1c1992f4726ab200881df749469a4", "shell_dialogs_unittests": "ab767aacb0eb035a6439b5eb172163deaa4a69b3", "skia_unittests": "b3b03cfff87e2b373952c4ae9b4efe2a5ac7bb39", "snapshot_unittests": "c5702991a156f0317455acc9c81a43cac121df95", "sql_unittests": "fe704ec34a360f973324df903caf4098edc5259e", "storage_unittests": "0000a8ca09f65ef0b57c53bcbef44815812f899e", "sync_integration_tests": "deea639889a01b11f2732a46481db18f24b37501", "telemetry_gpu_unittests": "d25261106f464e20b0e36874b3083ab347633b0d", "telemetry_unittests": "ea0ae20c4de169931df28061c027a249e074ea05", "traffic_annotation_auditor_unittests": "985f542896e0005249c65a2ed74d582e62976d2b", "ui_base_unittests": "932910c2d4d571fc0a25e7a825d169bda4c2e2bd", "ui_touch_selection_unittests": "9355705dc8e2b5234a1e12699d9da34e0ebb4d06", "unit_tests": "d45fd03d1545ae768ecf19175a35363a179cdf04", "url_unittests": "04249b0c2422b25a262c3bf9680a02667476576f", "views_perftests": "e5f747d2d67e979d83a969852e7daff72d2d9bf3", "views_unittests": "f4d54adbf8797d68d5df638a0965a9e63d15afcb", "viz_unittests": "2e58708d06948012888962ae5e76dbe88ab08a01", "vr_common_unittests": "7c55ae21f5ef2b76b17b372a242f2b73f9507626", "vr_pixeltests": "02a407a0583706945eba05dabe21d659b33239f5", "webkit_python_tests": "421887fd90b9f5c680a0f4f4d608021c28c8303a", "webkit_unit_tests": "15f817423b0c24e4361e47bcd241c6ca8565c68e", "wm_unittests": "e055b919762220b14e23fb0669475932332c9946", "wtf_unittests": "854125eaba10220e5b60482f59425b6c52d51b6b", "zucchini_unittests": "4c93153dc3af23a5cd89e87f1d93abb5c899e645"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "d7bfd5bb2031d217d0e0f87240b4ce16705abb3d" bot_update
got_revision_cp "refs/heads/master@{#606865}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. James Hawkins (jhawkinsohnoyoudont@chromium.org)
  2. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  3. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  5. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. Nico Weber (thakisohnoyoudont@chromium.org)
  8. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  9. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  10. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  11. Eugene But (eugenebutohnoyoudont@google.com)
  12. Eugene But (eugenebutohnoyoudont@google.com)
  13. Pavel Shmakov (pshmakovohnoyoudont@google.com)
  14. Tim Volodine (timvolodineohnoyoudont@chromium.org)
  15. Rayan Kanso (rayankansohnoyoudont@google.com)

Timing:

Create Friday, 09-Nov-18 16:53:37 UTC
Start Friday, 09-Nov-18 16:53:45 UTC
End Friday, 09-Nov-18 17:45:09 UTC
Pending 7 secs
Execution 51 mins 23 secs

All Changes:

  1. Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7bfd5bb2031d217d0e0f87240b4ce16705abb3d

    Comments

    Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f
    Reviewed-on: https://chromium-review.googlesource.com/c/1325393
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606865}

    Changed files

    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h
  2. Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 16:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f513b7c0c1803fe4688b8eee2dab06f48dabf081

    Comments

    Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy
    
    ... and remove the later.
    
    This is a follow up of mmenke's request in [1].
    
    [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70
    
    TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
    TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)
    
    BUG=773295
    
    Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1320769
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606864}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc
    • components/safe_browsing/browser/threat_details_cache.cc
    • content/browser/loader/resource_loader.cc
    • services/network/public/cpp/resource_response.cc
    • services/network/public/cpp/resource_response_info.cc
    • services/network/public/cpp/resource_response_info.h
    • services/network/url_loader.cc
  3. Ignore blur events caused by the password generation.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  4. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  5. Save transform context for filters

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  6. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  7. Remove v8_context_snapshot.bin determinism hack.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  8. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  9. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  10. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  11. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  12. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  13. Refactor Trusted Web Activity UI code to MVC

    Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java
  14. [AW NS] Add CTS test filter for Android WebView

    Changed by Tim Volodine - timvolodineohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 15:47:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e57afbcbc0d8a4fff7a9d8df6164bf0f6dcedd75

    Comments

    [AW NS] Add CTS test filter for Android WebView
    
    The idea of this CTS filter is similar to the filter we have for
    instrumentation tests, i.e.
    mojo.fyi.network_webview_instrumentation_test_apk.filter. It contains
    failing tests and their corresponding issues / root causes.
    
    The current filter contains results from a local run for a subset of
    tests (the actual CTS is not running yet). The CTS filter also
    augments the instrumentation test filter for test coverage that is
    missing from instrumentation tests.
    
    BUG=903822,902330,841556
    
    Change-Id: I006744652d8ae0a5755f0084704c9f91542d4f8d
    Reviewed-on: https://chromium-review.googlesource.com/c/1319677
    Commit-Queue: Tim Volodine <timvolodine@chromium.org>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606852}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_webview_CTS_test.filter
  15. [Background Fetch] Report uploadTotal in the registration

    Changed by Rayan Kanso - rayankansohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a2e1006e2f0960cea11264c2cb65c73d0334b90

    Comments

    [Background Fetch] Report uploadTotal in the registration
    
    Also sets up some useful testing helpers for future upload features.
    
    Bug: 774054
    Change-Id: I9aea33086b228357d9a160bd35b0a37ceaa30592
    Reviewed-on: https://chromium-review.googlesource.com/c/1329149
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606851}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.h
    • content/browser/background_fetch/storage/create_metadata_task.cc