Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 (dbg) Build 3694 Microsoft Windows

Results:

Failure headless_browsertests on Windows-10-15063 Failure network_service_interactive_ui_tests (experimental) on Windows-10-15063

Trigger Info:

Projectchromium
Revision9729f6efb4bae858cc91b281091f2df86433da8a
Got Revision9729f6efb4bae858cc91b281091f2df86433da8a

Execution:

Steps and Logfiles:

Show:
  1. ( 568 ms ) setup_build
    running recipe: "chromium"
  2. ( 795 ms ) report builders
     
    running tester 'Win10 Tests x64 (dbg)' on master 'chromium.win'
  3. ( 5 secs ) taskkill
  4. ( 6 mins 1 secs ) bot_update
    [51GB/299GB used (17%)]
  5. ( 1 secs ) swarming.py --version
    0.13
  6. ( 47 secs ) gclient runhooks
  7. ( 685 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 486 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 383 ms ) build directory
  10. ( 437 ms ) find isolated tests
  11. ( 3 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  12. ( 4 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:51.327283
  13. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 53s
  14. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  15. ( 3 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:10.103880
  16. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  17. ( 2 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  18. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 49s
  19. ( 3 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 49s
  20. ( 2 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:00.668634
  21. ( 2 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  22. ( 2 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  23. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  24. ( 2 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  25. ( 3 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:01.968965
  26. ( 2 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:09.746409
  27. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 57s
  28. ( 2 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 52s
  29. ( 2 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  30. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  31. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:47.099473
  32. ( 4 mins 18 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:31.486823
  33. ( 2 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  34. ( 24 mins ) content_browsertests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:32:47.960234
  35. ( 2 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 58s
  36. ( 5 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:27.780611
  37. ( 2 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 46s
  38. ( 3 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  39. ( 2 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  40. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  41. ( 1 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  42. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  43. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  44. ( 2 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  45. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  46. ( 2 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:58.697872
  47. ( 2 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:34.677611
  48. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  49. ( 2 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 36s
  50. ( 4 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 59s
  51. ( 2 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  52. ( 2 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  53. ( 3 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 50s
  54. ( 2 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:44.900962
    failures:
    HeadlessProtocolBrowserTest.VirtualTimeLocalStorage
    HeadlessProtocolCompositorBrowserTest.RendererWindowLocationFragments
    HeadlessProtocolCompositorBrowserTest.RendererRedirect303PutGet
    HeadlessProtocolBrowserTest.VirtualTimePendingScript
    HeadlessProtocolCompositorBrowserTest.RendererRedirectNonAsciiUrl
    HeadlessProtocolCompositorBrowserTest.RendererDelayedCompletion
    HeadlessProtocolCompositorBrowserTest.RendererInCrossOriginObject
    HeadlessBrowserTest.WindowPrint
    HeadlessWebContentsTest.Navigation
    HeadlessProtocolBrowserTest.VirtualTimeAdvance
    HeadlessWebContentsTest.BrowserOpenInTab
    HeadlessProtocolBrowserTest.VirtualTimeNoBlock404
    HeadlessWebContentsScreenshotTests/HeadlessWebContentsScreenshotTest.RunAsyncTest/1
    HeadlessWebContentsScreenshotTests/HeadlessWebContentsScreenshotTest.RunAsyncTest/0
    HeadlessProtocolBrowserTest.VirtualTimeDetachFrame
    HeadlessBrowserTest.AIAFetching
    DevToolsNetworkOfflineEmulationTest.RunAsyncTest
    HeadlessProtocolBrowserTest.VirtualTimeHtmlImport
    HeadlessProtocolBrowserTest.VirtualTimeRedirect
    HeadlessBrowserTest.AllowInsecureLocalhostFlag
    HeadlessBrowserTestWithProxy.SetProxyConfig
    HeadlessProtocolCompositorBrowserTest.RendererRedirect307PutMethod
    HeadlessProtocolCompositorBrowserTest.RendererOverrideTitleJsDisabled
    HeadlessWebContentsTest.FocusOfHeadlessWebContents_IsIndependent
    HeadlessProtocolBrowserTest.VirtualTimeTimerOrder
    HeadlessProtocolCompositorBrowserTest.RendererServerRedirectRelativeChain
    DevToolsAttachAndDetachNotifications.RunAsyncTest
    HeadlessDevToolsClientAttachTest.RunAsyncTest
    DevtoolsInterceptionWithAuthProxyTest.RunAsyncTest
    HeadlessProtocolCompositorBrowserTest.RendererHelloWorld
    ... 73 more (103 total) ...
     
  55. ( 2 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 45s
  56. ( 2 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  57. ( 2 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  58. ( 2 secs ) webui_polymer2_interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:55.638670
  59. ( 2 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 45s
  60. ( 2 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  61. ( 2 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  62. ( 2 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  63. ( 2 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  64. ( 3 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  65. ( 2 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  66. ( 3 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:38.739899
  67. ( 2 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  68. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  69. ( 2 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  70. ( 2 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  71. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 44s
  72. ( 2 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  73. ( 14 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:17:42.161419
  74. ( 2 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
  75. ( 2 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  76. ( 2 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  77. ( 2 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  78. ( 2 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 34s
  79. ( 2 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  80. ( 2 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  81. ( 2 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  82. ( 2 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  83. ( 2 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:22.994507
  84. ( 2 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  85. ( 2 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  86. ( 2 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  87. ( 2 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  88. ( 2 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  89. ( 3 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 34s
  90. ( 2 secs ) sync_integration_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:16:25.930854
  91. ( 2 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 43s
  92. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  93. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 23s
  94. ( 8 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:13:17.548902
  95. ( 2 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  96. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  97. ( 2 secs ) viz_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:01.732983
  98. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 58s
  99. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 42s
  100. ( 7 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:42.087386
  101. ( 2 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  102. ( 2 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 42s
  103. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  104. ( 3 secs ) interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:14:41.715891 (shard #2)
    Min shard duration: 0:10:44.953285 (shard #1)
  105. ( 22 mins 20 secs ) network_service_interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 1:01:20.521128 (shard #1)
    Min shard duration: 1:01:05.851338 (shard #0)
  106. ( 2 secs ) content_shell_crash_test (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
    Total tests: n/a
     
  107. ( 2 secs ) metrics_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  108. ( 3 secs ) performance_test_suite (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:03:57.386424 (shard #0)
    Min shard duration: 0:03:30.246973 (shard #1)
    Total tests: n/a
     
  109. ( 2 secs ) telemetry_gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 46s
    Total tests: 35
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  110. ( 3 secs ) telemetry_unittests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:06:13.436107 (shard #1)
    Min shard duration: 0:05:21.492753 (shard #3)
    Total tests: 1169
    * Passed: 1063 (1063 expected, 0 unexpected)
    * Skipped: 106 (106 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  111. ( 1 secs ) views_perftests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
    Total tests: n/a
     
  112. ( 3 secs ) webkit_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
    Total tests: 1551
    * Passed: 1535 (1535 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  113. ( 204 ms ) Tests statistics
     
    Stats
    Total shards: 110
    Total runtime: 5:59:39.839000
     
  114. ( 548 ms ) process_dumps
  115. ( 3 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-c-dkr8" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539348971577704, "id": "8932869328737500208", "project": "chromium", "tags": ["builder:Win10 Tests x64 (dbg)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/9729f6efb4bae858cc91b281091f2df86433da8a", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder (dbg)", "parent_buildnumber:75182", "scheduler_invocation_id:9098299390838940608", "scheduler_job_id:chromium/Win10 Tests x64 (dbg)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 Tests x64 (dbg)" setup_build
buildnumber 3694 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder (dbg)" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "9729f6efb4bae858cc91b281091f2df86433da8a" setup_build
parent_got_revision_cp "refs/heads/master@{#599183}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25138}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "9729f6efb4bae858cc91b281091f2df86433da8a" setup_build
swarm_hashes {"accessibility_unittests": "8bdb347c6eed861a93d7b326abefda37aece68ff", "angle_unittests": "ccd047a193507733ddf070f38f6b62022e6a598f", "app_shell_unittests": "3b3255e624764d5bb6fdd293e178bdaa0b56f355", "aura_unittests": "26aee3239292ac9b8d17f7d026deba51407743da", "base_unittests": "7a605b6b11bc01b39856c491e6c7ea32de274ccb", "blink_common_unittests": "8dca768f80f48e3f83f3e9e2eb0d1d53ae1485a8", "blink_fuzzer_unittests": "b42be239875b12107840962c5354d78b7c903080", "blink_heap_unittests": "f6dd92f62655195e687a4fd5e5a8e2ebed3f6066", "blink_platform_unittests": "2145d4ce9a3c585af6f04574022b9971998a91b9", "boringssl_crypto_tests": "22936e0e47c0228f66b527b15d21e7d8d43a9322", "boringssl_ssl_tests": "26cbe808f40f0c450ee6d8fd523d9a4c47e784a4", "cacheinvalidation_unittests": "54c0131805d12f68594136037292b705b9391b4c", "capture_unittests": "dd1f60b4a120c39b6102c34c315f20c712be2fd6", "cast_unittests": "8a6a4ec0e7454685db01b1faf92f07aa4c799425", "cc_unittests": "8347492a85343beb47a899211504f14001864507", "chrome_app_unittests": "75707a9744421af04758f88dd3308e74f8071426", "chrome_cleaner_unittests": "73c4c309367e8add92362f6b044d387ae565fc30", "chrome_elf_import_unittests": "13de216753d5ce9047d07d9ae214b6616af2e76e", "chrome_elf_unittests": "941090872022a69a48b3a986ace965143e65c1c3", "chromedriver_unittests": "cce179a7f7dcf08b21b407803d7b7ca92edbcfc1", "components_browsertests": "624fb84ab31080716dacb28e3bfb87d3d74d9bc7", "components_unittests": "1490556b1ee3b2d7ea722e9e1f2dd0ebe2ca0448", "compositor_unittests": "36cdc60763a3efe1834750f9d13dae6ec7f30bb4", "content_browsertests": "0747315498c67ddaa346c55f754e6fb94f777463", "content_shell_crash_test": "42760182438f3f48ff39e6b721e101b0bbe1944f", "content_unittests": "fae69a78fb53c585966a9036c5ebde9c92b89e17", "courgette_unittests": "5dbb6a753c98a725261d8f20facc7ba036e13bf6", "crashpad_tests": "0e8b85221ad1402f0aec2727875747d98915c6db", "cronet_tests": "b3db4665c50be6bc5d97f629b3510c3b9d9852c4", "cronet_unittests": "87e19ebb06df6154e8e315330ae88ab779211b53", "crypto_unittests": "abc8666f4213bc650cf08d0036cce0827ac295ad", "device_unittests": "fccb759a965abe88cb4a6cb8937e2d26b438f6a5", "display_unittests": "adf877a976420e0571bdba2f61f2b590efd3cae3", "elevation_service_unittests": "fde5710331cb5dc16fa283e7f426816702dbd333", "events_unittests": "fb82cef31a8fc2159ae982f5de28b1dc6b22819b", "extensions_browsertests": "2c7b419d08363790efa0d34725d0389fce8df318", "extensions_unittests": "cb05f9c78b4b311affb31f4b080946a3eb4691f7", "filesystem_service_unittests": "ddbce59c72fd8b5b5a1c9e2cbb008abe776ddf91", "gcm_unit_tests": "6b346b19f627f0d50263530ae8bb1dd49faa10a3", "gfx_unittests": "d9550dd7b5a1280fac8c004e42b19441b49b2f96", "gin_unittests": "5b25e21bbc5f72876f5f92c814d868239e3592bd", "google_apis_unittests": "46d398cfbf8048e59aafb63ebfcd3f234c1efd51", "gpu_unittests": "924bc82ad7b7196b1c3e40900c441b6c61d536e7", "headless_browsertests": "b29a3aeff1d61ac7352ce67bd9094d5d8a2a71b6", "headless_unittests": "d64422eb5f467417a164a37cf6d3fddadef46a6c", "install_static_unittests": "8db1d1f45538a5f208c5c402eab1697050652e12", "installer_util_unittests": "91cc0713e37aabeeb84593266d01d717f390d1d3", "interactive_ui_tests": "a6a376189b5ef470705033145f48f1aca4c38642", "ipc_tests": "dd8cf70d21691127bf39ae1aa3dbc2785b19456b", "jingle_unittests": "8e261cf0eb9c41358c9f392763766f51b2d15bde", "latency_unittests": "7136eba0bc56ff240450daa9b0d799e05cb297c6", "leveldb_service_unittests": "894ffd7a73785e2afa0e453017c09abaf8199707", "libjingle_xmpp_unittests": "f20ca15f2e48a81bfeffb1e161751cf5775bc8c9", "media_blink_unittests": "9b128f0c5bde156226fb77bf1f807f6f99f8fdaf", "media_service_unittests": "2d7b1becce73fc0ffbb2e3d78889cdee95efa22b", "media_unittests": "b3417fdcd0ff7a0259aa9093e94bd16cf595d1be", "message_center_unittests": "6fff9f300032379f130fed21b456d2798974509c", "metrics_python_tests": "5b14f5bcf3ca2420b61294308cf5ee3a6d226d56", "midi_unittests": "ec99f8b0f8b57403a2dc48cfd66c69420fc6f4f2", "mojo_core_unittests": "5f583ccf216e668913eab9f666e736c7f1e24ce6", "mojo_unittests": "b6329abc0002d5583a07d0b890b9c4480470d3f6", "nacl_loader_unittests": "8c5e61042f1a6198f02557e46fe9fca05312a526", "native_theme_unittests": "b9fe97bf2b1120af2b8e6108c24fff1cef23e6e1", "net_unittests": "f135df884961a71256deda710f815b11c24dc18f", "notification_helper_unittests": "dfe79e7c9838acf3a11ab58989b6a6e29bff289f", "pdf_unittests": "d1b50b798e8ce14dcd53935bd583ab10188b41e5", "performance_test_suite": "9248cf494dbd79668094ef7d375ddadcb789269c", "ppapi_unittests": "5f78c4c097d42e4e77a9d3bc8e5b585813ad0b2f", "printing_unittests": "f4d462b45f300d6b02e77b0a3bc435a3ff9b59e6", "remoting_unittests": "0216029aaf77f96be40fc4fa6e7dfac130938e93", "sbox_integration_tests": "9d7e77c794922db851bca5868c2a718765d87e52", "sbox_unittests": "983469539a04a0542b012c329a4fc5ff94024297", "sbox_validation_tests": "40855d07ac8fc733b7c3d6a182585c2f8ffcc4e4", "service_manager_unittests": "5852edc345c7cce6b20e8f7d8418c4ff01c40f2c", "services_unittests": "3e11134a5cfcf897c88398d18e88837c8221c0ab", "setup_unittests": "99361def52ae4b81e1f9e531727beded903f4dc3", "shell_dialogs_unittests": "15457634792a82d0cf952d496f9cd835f2a33067", "skia_unittests": "f3edb56a2e223fba4d9b68b3aa6d79ae383edb95", "snapshot_unittests": "dfcff63d8189b569057674988889de92583f9b9e", "sql_unittests": "904095aa60384d6ae0fbb86642f241d16bce8972", "storage_unittests": "f08ca5c900e81bb6cafad6bb5ff5980dfb3edf0f", "sync_integration_tests": "7d1dc1307c51280d67dc51c8ae3039ba53d97b55", "telemetry_gpu_unittests": "0ed901306bcd8906599c875636d0432c094a53b5", "telemetry_unittests": "cacf59dbc78bdf122ac50a0f095f376f86f51973", "traffic_annotation_auditor_unittests": "2512e59ba8a09a5766623c837cef86673db53a47", "ui_base_unittests": "97f7b14db08e6c12c0dcdbb384e6fe3b2c926f69", "ui_touch_selection_unittests": "ab54f65907872a0f2e898d805fe443f9ccb7c741", "unit_tests": "d9a127a0dcd8e511bfca6f1d58dc8c3dac2285e8", "url_unittests": "724cef298cfad7003dba3d13b5164f77b4011e1b", "views_perftests": "4d27046feb832aa3dc175d0968c14ab16bdbc4b9", "views_unittests": "8938bbf4668b4a9047ad110f0962c6a42dc6834a", "viz_unittests": "648eb643f172709591efa6938421b3dfd77f361c", "vr_common_unittests": "695ab5962c62721ec17b8de34e243c7310e02597", "vr_pixeltests": "a90ddf79c2fc1e4964513780a074c2a70fcdac02", "webkit_python_tests": "17c3107f75ad29b240e100af806f8e404c95ade6", "webkit_unit_tests": "c77917af42403ee9a5c0c6114354ceedb2b6b5a9", "wm_unittests": "6e96ad415d9f2ba520930615b9d079d98cc0e8d7", "wtf_unittests": "decce373fa0f0940be08fffd274b8f838d6f320d", "zucchini_unittests": "42a17f9fe242e9fca691b3756a9d58e18c28f7ee"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "9729f6efb4bae858cc91b281091f2df86433da8a" bot_update
got_revision_cp "refs/heads/master@{#599183}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. David Davidović (davidovicohnoyoudont@google.com)
  3. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  4. Florent Castelli (orphisohnoyoudont@chromium.org)
  5. Florent Castelli (orphisohnoyoudont@chromium.org)
  6. Colin Blundell (blundellohnoyoudont@chromium.org)
  7. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  8. Camille Lamy (clamyohnoyoudont@chromium.org)
  9. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  10. Nico Weber (thakisohnoyoudont@chromium.org)
  11. Sergio Villar Senin (svillarohnoyoudont@igalia.com)
  12. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  13. Rune Lillesveen (futharkohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 12:56:11 UTC
Start Friday, 12-Oct-18 12:57:27 UTC
End Friday, 12-Oct-18 14:13:20 UTC
Pending 1 mins 16 secs
Execution 1 hrs 15 mins

All Changes:

  1. Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:35:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9729f6efb4bae858cc91b281091f2df86433da8a

    Comments

    Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a
    
    
    git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
    2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@55d1af14751a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278709
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599183}

    Changed files

    • DEPS
  2. Reland "[sync::test] Add single client integration test for custom passphrase"

    Changed by David Davidović - davidovicohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 12:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1df3c494cc8dc1ef26ec3514b74b27c3047a4db

    Comments

    Reland "[sync::test] Add single client integration test for custom passphrase"
    
    This is a reland of 475bfe9da1df9ab55685e0a9ce1a62d8e50536f1. Fixed test
    failures which happened because some DCHECKs had side effects.
    
    Original change's description:
    > [sync::test] Add single client integration test for custom passphrase
    >
    > Add a Sync integration test which exercises custom passphrase flows, including
    > the handling and proper functioning of the newly added key derivation method
    > (scrypt).
    >
    > Add an integration test helper file for encryption-related tasks and modify
    > FakeServer and LoopbackServer to allow easier modification of persistent
    > entities such as Nigori. Add passphrase-related functionality to
    > ProfileSyncServiceHarness to give tests better control over how and when
    > passphrase-based encryption is enabled.
    >
    > The test uses a gray-box approach, where it tests the client at the
    > ProfileSyncService granularity, but injects and inspects entities on the (fake)
    > server to ensure that encryption is performed properly. This is necessary
    > because, when it comes to encryption, we are not interested merely in that it
    > does not hinder existing functionality (e.g. two clients are syncing data
    > properly in the presence of a custom passphrase), but also that it provides the
    > expected security to the user. For this reason, we use our knowledge of the
    > encryption architecture internals to ensure that the data committed to the
    > server is encrypted in the expected way.
    >
    > Bug: 894148
    > Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274205
    > Commit-Queue: David Davidović <davidovic@google.com>
    > Reviewed-by: vitaliii <vitaliii@chromium.org>
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598912}
    
    Bug: 894148
    Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
    Reviewed-on: https://chromium-review.googlesource.com/c/1278790
    Commit-Queue: David Davidović <davidovic@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599182}

    Changed files

    • chrome/browser/sync/test/integration/bookmarks_helper.cc
    • chrome/browser/sync/test/integration/bookmarks_helper.h
    • chrome/browser/sync/test/integration/encryption_helper.cc
    • chrome/browser/sync/test/integration/encryption_helper.h
    • chrome/browser/sync/test/integration/profile_sync_service_harness.cc
    • chrome/browser/sync/test/integration/profile_sync_service_harness.h
    • chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.h
    • chrome/test/BUILD.gn
    • components/sync/engine_impl/loopback_server/loopback_server.cc
    • components/sync/engine_impl/loopback_server/loopback_server.h
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  3. Don't update style for focusability when render-blocking.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 369b6fca37d5b416775fd7fafdbc6bde78a18bf8

    Comments

    Don't update style for focusability when render-blocking.
    
    WebNode::IsFocusable() updated style and layout tree, without ignoring
    pending stylesheets, which meant generating a display:none placeholder
    style for the root node. Instead, early return from IsFocusable() when
    we are blocking rendering.
    
    Bug: 521692
    
    Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1245787
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599181}

    Changed files

    • third_party/blink/renderer/core/exported/web_node.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
  4. Revert "[blink] Control ScriptStreamer with ScriptResource"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

    Comments

    Revert "[blink] Control ScriptStreamer with ScriptResource"
    
    This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.
    
    Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
    Bug: 894792, 894795
    
    Original change's description:
    > [blink] Control ScriptStreamer with ScriptResource
    > 
    > Move the ScriptStreamer control logic from ClassicPendingScript to
    > ScriptResource. In the future, this will allow us to start streaming
    > a ScriptResource before the ClassicPendingScript is available, e.g on
    > preload.
    > 
    > The ClassicPendingScript now only sends one "finished" callback, from
    > ScriptResource. This callback is either when the streaming completes,
    > or when there is no streaming and the ClassicPendingScript has told
    > the ScriptResource that it doesn't intend to start streaming. In the
    > long run, we want all scripts to go through the streaming interface,
    > and we want ScriptResource to control when streaming starts, so the
    > "no more streaming" call will disappear -- however it is necessary to
    > maintain the current behaviour, and be able to control it with a
    > runtime flag.
    > 
    > Bug: chromium:865098
    > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599148}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098
    Reviewed-on: https://chromium-review.googlesource.com/c/1278758
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599180}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  5. Revert "Make DriveFS opt-out in FilesApp tests."

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:11:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 70d0138d92d063b4d3032ffae54c950cf7c13f41

    Comments

    Revert "Make DriveFS opt-out in FilesApp tests."
    
    This reverts commit e9c79d562d8d3b789cca95b6909aa600a1dd39d2.
    
    Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
    Bug: 894799
    
    Original change's description:
    > Make DriveFS opt-out in FilesApp tests.
    > 
    > Bug: 891197
    > Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    > Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Commit-Queue: Sam McNally <sammc@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599117}
    
    TBR=noel@chromium.org,sammc@chromium.org
    
    Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 891197
    Reviewed-on: https://chromium-review.googlesource.com/c/1278757
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599179}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  6. Enable IdentityTestEnvironment to take in IdentityManager's dependencies

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b64e54c9a221efad82a4a60956cd3b58ac371059

    Comments

    Enable IdentityTestEnvironment to take in IdentityManager's dependencies
    
    Currently, IdentityTestEnvironment internally constructs all the
    dependencies of IdentityManager as well as the IdentityManager object
    itself. This behavior is nice for hiding the fact that IdentityManager
    has these dependencies from consumers, but doesn't allow for
    usage of IdentityTestEnviroment in incremental conversion of tests that
    have broad direct usage of these dependencies. Concretely,
    profile_sync_test_util.h provides one such problematic case: it
    constructs and directly exposes these dependencies, which are then
    broadly used by a set of tests that consume this utility class.
    Converting all these tests in one go is not practical.
    
    This CL adds an alternate IdentityTestEnvironment constructor that
    takes in the dependencies and constructs IdentityManager via those
    passed-in dependencies. To enable this constructor, the CL also
    encapsulates the fact that IdentityTestEnvironment otherwise obtains
    these dependencies from an internal object within the current
    IdentityTestEnvironment constructor.  It also moves ownership of
    IdentityManager from that internal object to IdentityTestEnvironment
    itself so that it can be created/owned independent of that internal
    object.
    
    A followup CL will use this new constructor.
    
    Bug: 886599
    Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
    Reviewed-on: https://chromium-review.googlesource.com/c/1273298
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599178}

    Changed files

    • services/identity/public/cpp/identity_test_environment.cc
    • services/identity/public/cpp/identity_test_environment.h
  7. [css-properties-values-api] Support StylePropertyMap.append.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:05:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84056b7e0dee6cb71b889254c2f33c0b338002fb

    Comments

    [css-properties-values-api] Support StylePropertyMap.append.
    
    This CL makes it possible to append values to list-valued properties.
    
    To do this, we must produce a CSSStyleValueVector which holds the final
    value produced by the append (i.e. the concatenation of the existing
    values and the incoming values). Then (like for StylePropertyMap.set),
    a CSSVariableReferenceValue with equivalent tokens is created from that
    vector.
    
    Bonus: Fix names of some tests to make it easier to read the output.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
    Reviewed-on: https://chromium-review.googlesource.com/c/1270967
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599177}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.h
  8. Create NavigationRequest from LoadURLParams

    Changed by Camille Lamy - clamyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5193caa162249e66ecec99fbf1e94fd38557b672

    Comments

    Create NavigationRequest from LoadURLParams
    
    This CL allows to create the NavigationRequest directly from
    LoadURLParams for new navigations.
    
    Bug: 803859
    Change-Id: Ic0f3f368ade86fe57bb549ae6c1d5711f1b58d0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1097407
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599176}

    Changed files

    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl.h
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request.h
    • content/browser/frame_host/navigator_impl.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
  9. Rename FaviconViewNew to FaviconView.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:48:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0363f71cf67554f24b21b299db6f9fcd11a33bf3

    Comments

    Rename FaviconViewNew to FaviconView.
    
    Since FaviconView name is not used anymore, it makes sense now.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I0549111a1ade2f8cc61664d1de07160c8687b6de
    Reviewed-on: https://chromium-review.googlesource.com/c/1278807
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599175}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.h
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
    • ios/chrome/common/favicon/favicon_view.h
    • ios/chrome/common/favicon/favicon_view.mm
    • ios/chrome/content_widget_extension/most_visited_tile_view.h
    • ios/chrome/content_widget_extension/most_visited_tile_view.mm
  10. win: Update deterministic build whitelist.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:47:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f097036d16ea6c259ef01ddd6967895ca5a28d04

    Comments

    win: Update deterministic build whitelist.
    
    symbol_level=1 builds seem to work now and the bot builds with it, so the
    entries for crashpad_snapshot_test_image_reader and
    crashpad_snapshot_test_image_reader_module.dll are no longer needed.
    
    mini_installer.exe now has a corresponding .pdb that's also non-deterministic
    (since the exe itself isn't, the pdb can't be), so add an entry for that.
    
    TBR=erikchen
    
    Bug: 330260
    Change-Id: Ic1cde1f5a52a953d74285e4bd6a02e74c70e75b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1278306
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599174}

    Changed files

    • tools/determinism/deterministic_build_whitelist.pyl
  11. Convert chrome/browser/signin/signin_global_error.cc to IdentityManager

    Changed by Sergio Villar Senin - svillarohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 11:46:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 557d4cfd2336cc35f91ec95bb9ef4b1290e6d491

    Comments

    Convert chrome/browser/signin/signin_global_error.cc to IdentityManager
    
    It was using SigninManagerBase API to get the primary (authenticated)
    account id. It's now using the IdentityManager API.
    
    Bug: 890792
    Change-Id: Ia8cdd8e491f29256af2c015a9127b0766e81b99e
    Reviewed-on: https://chromium-review.googlesource.com/c/1276965
    Commit-Queue: Sergio Villar <svillar@igalia.com>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599173}

    Changed files

    • chrome/browser/signin/signin_global_error.cc
  12. Add Picture-in-picture specific window resizer.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 11:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c

    Comments

    Add Picture-in-picture specific window resizer.
    
    Currently, this does essentially nothing apart from providing basic
    resizing and moving functionality. In a follow-up CL, we can add
    snap-to-edge, swipe-to-dismiss, and interaction with system ui regions
    like the virtual keyboard.
    
    Bug: 841886
    Bug: b/115291749
    Test: Able to move and resize an Android PIP window.
    Change-Id: Iaecc43154fd38dc5f9d3b83549e97dc44a89d749
    Reviewed-on: https://chromium-review.googlesource.com/c/1219428
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599172}

    Changed files

    • ash/BUILD.gn
    • ash/wm/pip/pip_window_resizer.cc
    • ash/wm/pip/pip_window_resizer.h
    • ash/wm/pip/pip_window_resizer_unittest.cc
    • ash/wm/workspace/workspace_window_resizer.cc
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  13. Run layout to avoid stale layout during SetIsInert()

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:26:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe6fcbb2751d80b3a9c41b734d1d1c16e93d46b

    Comments

    Run layout to avoid stale layout during SetIsInert()
    
    Speculative fix for crbug.com/789094
    
    Bug: 789094
    Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc
    Reviewed-on: https://chromium-review.googlesource.com/c/823582
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599171}

    Changed files

    • third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc