Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 (dbg) Build 3690 Microsoft Windows

Results:

Failure extensions_browsertests on Windows-10-15063 Failure interactive_ui_tests (experimental) on Windows-10-15063 Failure telemetry_unittests (experimental) on Windows-10-15063

Trigger Info:

Projectchromium
Revision836e5cd90af24fa6af71e4e633d1c0fb41ca0765
Got Revision836e5cd90af24fa6af71e4e633d1c0fb41ca0765

Execution:

Steps and Logfiles:

Show:
  1. ( 586 ms ) setup_build
    running recipe: "chromium"
  2. ( 333 ms ) report builders
     
    running tester 'Win10 Tests x64 (dbg)' on master 'chromium.win'
  3. ( 5 secs ) taskkill
  4. ( 1 mins 14 secs ) bot_update
    [51GB/299GB used (17%)]
  5. ( 0 ) ensure_goma
  6. ( 638 ms ) swarming.py --version
    0.13
  7. ( 18 secs ) gclient runhooks
  8. ( 617 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  9. ( 460 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  10. ( 384 ms ) build directory
  11. ( 342 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 1 secs ) test_pre_run.[trigger] angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  14. ( 1 secs ) test_pre_run.[trigger] app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  15. ( 1 secs ) test_pre_run.[trigger] aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  16. ( 1 secs ) test_pre_run.[trigger] base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  17. ( 1 secs ) test_pre_run.[trigger] blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  18. ( 1 secs ) test_pre_run.[trigger] boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  19. ( 1 secs ) test_pre_run.[trigger] capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  20. ( 1 secs ) test_pre_run.[trigger] cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  21. ( 1 secs ) test_pre_run.[trigger] cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  22. ( 1 secs ) test_pre_run.[trigger] chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  23. ( 1 secs ) test_pre_run.[trigger] chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  24. ( 1 secs ) test_pre_run.[trigger] components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  25. ( 1 secs ) test_pre_run.[trigger] compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  26. ( 1 secs ) test_pre_run.[trigger] content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  27. ( 1 secs ) test_pre_run.[trigger] courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  28. ( 1 secs ) test_pre_run.[trigger] crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  29. ( 1 secs ) test_pre_run.[trigger] cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  30. ( 1 secs ) test_pre_run.[trigger] cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  31. ( 1 secs ) test_pre_run.[trigger] crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  32. ( 1 secs ) test_pre_run.[trigger] device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  33. ( 1 secs ) test_pre_run.[trigger] display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  34. ( 1 secs ) test_pre_run.[trigger] events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  35. ( 1 secs ) test_pre_run.[trigger] extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  36. ( 1 secs ) test_pre_run.[trigger] gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  37. ( 1 secs ) test_pre_run.[trigger] gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  38. ( 1 secs ) test_pre_run.[trigger] gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  39. ( 1 secs ) test_pre_run.[trigger] google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  40. ( 1 secs ) test_pre_run.[trigger] gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  41. ( 1 secs ) test_pre_run.[trigger] headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  42. ( 1 secs ) test_pre_run.[trigger] headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  43. ( 1 secs ) test_pre_run.[trigger] ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  44. ( 1 secs ) test_pre_run.[trigger] jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  45. ( 1 secs ) test_pre_run.[trigger] latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  46. ( 1 secs ) test_pre_run.[trigger] media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  47. ( 1 secs ) test_pre_run.[trigger] media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  48. ( 1 secs ) test_pre_run.[trigger] midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  49. ( 1 secs ) test_pre_run.[trigger] mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  50. ( 1 secs ) test_pre_run.[trigger] mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  51. ( 1 secs ) test_pre_run.[trigger] nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  52. ( 1 secs ) test_pre_run.[trigger] net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  53. ( 1 secs ) test_pre_run.[trigger] pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  54. ( 1 secs ) test_pre_run.[trigger] ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  55. ( 1 secs ) test_pre_run.[trigger] printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  56. ( 1 secs ) test_pre_run.[trigger] remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  57. ( 1 secs ) test_pre_run.[trigger] sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  58. ( 1 secs ) test_pre_run.[trigger] sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  59. ( 1 secs ) test_pre_run.[trigger] services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  60. ( 1 secs ) test_pre_run.[trigger] setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  61. ( 1 secs ) test_pre_run.[trigger] skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  62. ( 1 secs ) test_pre_run.[trigger] snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  63. ( 1 secs ) test_pre_run.[trigger] sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  64. ( 1 secs ) test_pre_run.[trigger] storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  65. ( 1 secs ) test_pre_run.[trigger] ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  66. ( 1 secs ) test_pre_run.[trigger] unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  67. ( 1 secs ) test_pre_run.[trigger] url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  68. ( 2 secs ) test_pre_run.[trigger] views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  69. ( 1 secs ) test_pre_run.[trigger] viz_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  70. ( 1 secs ) test_pre_run.[trigger] vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  71. ( 1 secs ) test_pre_run.[trigger] vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  72. ( 1 secs ) test_pre_run.[trigger] webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  73. ( 1 secs ) test_pre_run.[trigger] wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  74. ( 1 secs ) test_pre_run.[trigger] wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  75. ( 1 secs ) test_pre_run.[trigger] zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  76. ( 1 secs ) test_pre_run.[trigger] metrics_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  77. ( 1 secs ) test_pre_run.[trigger] views_perftests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  78. ( 1 secs ) test_pre_run.[trigger] webkit_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
  79. ( 2 secs ) accessibility_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  80. ( 2 mins 6 secs ) angle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:51.327283
  81. ( 2 secs ) app_shell_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  82. ( 2 secs ) aura_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 41s
  83. ( 3 secs ) base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:10.103880
  84. ( 2 secs ) blink_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  85. ( 2 secs ) blink_fuzzer_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 35s
  86. ( 2 secs ) blink_heap_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  87. ( 3 secs ) blink_platform_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 51s
  88. ( 2 secs ) boringssl_crypto_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:00.668634
  89. ( 2 secs ) boringssl_ssl_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  90. ( 2 secs ) cacheinvalidation_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  91. ( 2 secs ) capture_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  92. ( 2 secs ) cast_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 56s
  93. ( 3 secs ) cc_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:15.386417
  94. ( 2 secs ) chrome_app_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 58s
  95. ( 2 secs ) chrome_cleaner_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:19.559792
  96. ( 1 secs ) chrome_elf_import_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 54s
  97. ( 2 secs ) chrome_elf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 12s
  98. ( 2 secs ) chromedriver_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  99. ( 2 secs ) components_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:30.627694
  100. ( 2 mins 17 secs ) components_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:08:23.828691
  101. ( 2 secs ) compositor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  102. ( 21 mins 21 secs ) content_browsertests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:30:09.604141
  103. ( 2 secs ) perfetto_content_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:18.641281
  104. ( 4 secs ) content_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:02:37.568026
  105. ( 2 secs ) courgette_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 46s
  106. ( 3 secs ) crashpad_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 19s
  107. ( 2 secs ) cronet_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  108. ( 2 secs ) cronet_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  109. ( 2 secs ) crypto_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  110. ( 2 secs ) device_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 53s
  111. ( 2 secs ) display_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
  112. ( 2 secs ) elevation_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  113. ( 2 secs ) events_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  114. ( 2 secs ) extensions_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:36.136268
    failures:
    HidApiTest.HidApp
    PrinterProviderApiTest.PrintJobFailed
    HidApiTest.OnDeviceAdded
    PrinterProviderApiTest.GetCapabilitySuccess
    BluetoothSocketApiTest.Listen
    BluetoothSocketApiTest.PermissionDenied
    DisplaySourceApiTest.DisplaySourceExtension
    PrinterProviderApiTest.PrintJobSuccess
    HidApiTest.GetUserSelectedDevices
    PrinterProviderApiTest.NoPrintEventListener
    PrinterProviderApiTest.PrintRequestAppUnloaded
    PrinterProviderApiTest.GetCapabilityAsyncSuccess
    PrinterProviderApiTest.PrintRequestDataNotSet
    DnsApiTest.DnsExtension
    PrinterProviderApiTest.EmptyCapability
    HidApiTest.OnDeviceRemoved
    BluetoothShellApiTest.ApiSanityCheck
    PrinterProviderApiTest.PrintRequestInvalidCallbackParam
    FeedbackPrivateApiTest.Basic
    PrinterProviderApiTest.PrintJobAsyncSuccess
     
  115. ( 2 secs ) extensions_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:33.100318
  116. ( 2 secs ) filesystem_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  117. ( 2 secs ) gcm_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  118. ( 4 secs ) gfx_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 52s
  119. ( 4 secs ) gin_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  120. ( 4 secs ) google_apis_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  121. ( 5 secs ) gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 49s
  122. ( 4 secs ) headless_browsertests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:54.891181
  123. ( 4 secs ) headless_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 37s
  124. ( 3 secs ) install_static_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  125. ( 4 secs ) installer_util_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  126. ( 3 secs ) webui_polymer2_interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:09.861209
  127. ( 3 secs ) ipc_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 45s
  128. ( 3 secs ) jingle_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  129. ( 4 secs ) latency_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  130. ( 4 secs ) leveldb_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 15s
  131. ( 4 secs ) libjingle_xmpp_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  132. ( 5 secs ) media_blink_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 49s
  133. ( 3 secs ) media_service_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 49s
  134. ( 5 secs ) media_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:35.918402
  135. ( 3 secs ) message_center_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 32s
  136. ( 2 secs ) midi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  137. ( 2 secs ) mojo_core_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  138. ( 2 secs ) mojo_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  139. ( 2 secs ) nacl_loader_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 30s
  140. ( 2 secs ) native_theme_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  141. ( 15 secs ) net_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:18:02.455746
  142. ( 4 secs ) notification_helper_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 17s
  143. ( 3 secs ) pdf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 33s
  144. ( 3 secs ) ppapi_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  145. ( 3 secs ) printing_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 29s
  146. ( 3 secs ) remoting_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 52s
  147. ( 3 secs ) sbox_integration_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  148. ( 3 secs ) sbox_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 16s
  149. ( 2 secs ) sbox_validation_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  150. ( 2 secs ) service_manager_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 28s
  151. ( 2 secs ) services_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:09.274569
  152. ( 2 secs ) setup_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  153. ( 2 secs ) shell_dialogs_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 24s
  154. ( 2 secs ) skia_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 18s
  155. ( 2 secs ) snapshot_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 20s
  156. ( 2 secs ) sql_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 40s
  157. ( 2 secs ) storage_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  158. ( 2 secs ) sync_integration_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:17:47.534474
  159. ( 2 secs ) traffic_annotation_auditor_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 43s
  160. ( 2 secs ) ui_base_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 26s
  161. ( 2 secs ) ui_touch_selection_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 27s
  162. ( 7 secs ) unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:13:07.208311
  163. ( 2 secs ) url_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 21s
  164. ( 2 secs ) views_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 38s
  165. ( 2 secs ) viz_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:03:10.439127
  166. ( 2 secs ) vr_common_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:01:23.430118
  167. ( 2 secs ) vr_pixeltests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 57s
  168. ( 7 secs ) webkit_unit_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 0:04:35.372164
  169. ( 2 secs ) wm_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 22s
  170. ( 3 secs ) wtf_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 42s
  171. ( 2 secs ) zucchini_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 14s
  172. ( 24 mins 18 secs ) interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 1:01:23.298250 (shard #0)
    Min shard duration: 0:12:10.805302 (shard #1)
  173. ( 2 secs ) network_service_interactive_ui_tests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:14:12.707094 (shard #2)
    Min shard duration: 0:10:43.939006 (shard #1)
  174. ( 2 secs ) content_shell_crash_test (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 50s
    Total tests: n/a
     
  175. ( 2 secs ) metrics_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 13s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  176. ( 2 secs ) performance_test_suite (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:03:03.297594 (shard #1)
    Min shard duration: 0:02:30.705694 (shard #0)
    Total tests: n/a
     
  177. ( 2 secs ) telemetry_gpu_unittests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 52s
    Total tests: 35
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  178. ( 3 secs ) telemetry_unittests (experimental) on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:34:38.560695 (shard #3)
    Min shard duration: 0:05:21.324791 (shard #2)
    Total tests: 1169
    * Passed: 1025 (1025 expected, 0 unexpected)
    * Skipped: 106 (106 expected, 0 unexpected)
    * Failed: 37 (0 expected, >>>37 unexpected<<<)
    * Flaky: 1 (1 expected, 0 unexpected)
     
    Unexpected Failures:
    * telemetry.core.tracing_controller_unittest.StartupTracingTest.testStopTracingWhileBrowserIsRunning
    * telemetry.internal.actions.action_runner_unittest.ActionRunnerInteractionTest.testIssuingMultipleMeasurementInteractionRecords
    * telemetry.internal.actions.action_runner_unittest.ActionRunnerMeasureMemoryTest.testWithoutTracing
    * telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testNavigateBack
    * telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWait
    * telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWaitForJavaScriptCondition_returnsValue
    * telemetry.internal.actions.key_event_unittest.KeyPressActionTest.testTextEntry
    * telemetry.internal.actions.load_media_unittest.LoadMediaActionTest.testLoadWithSelector
    * telemetry.internal.actions.page_action_unittest.PageActionTest.testEvaluateCallbackWithElement
    * telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEndedTimeout
    * telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWithVideoSelector
    * telemetry.internal.actions.scroll_to_element_unittest.ScrollToElementActionTest.testScrollContainerToElement
    * telemetry.internal.actions.scroll_unittest.ScrollActionTest.testScrollAction
    * telemetry.internal.actions.scroll_unittest.ScrollActionTest.testScrollDistanceSlowWheel
    * telemetry.internal.actions.seek_unittest.SeekActionTest.testSeekWithAllSelector
    * telemetry.internal.backends.chrome_inspector.inspector_memory_unittest.InspectorMemoryTest.testGetDOMStats
    * telemetry.internal.backends.chrome_inspector.inspector_page_unittest.InspectorPageTest.testPageNavigateToNormalUrl
    * telemetry.internal.backends.chrome_inspector.inspector_runtime_unittest.InspectorRuntimeTest.testRuntimeEvaluateSimple
    * telemetry.internal.browser.browser_unittest.BrowserTest.testCloseReferencedTab
    * telemetry.internal.browser.browser_unittest.BrowserTest.testMultipleTabCalls
    * telemetry.internal.browser.browser_unittest.CommandLineBrowserTest.testCommandLineOverriding
    * telemetry.internal.browser.browser_unittest.TestBrowserCreation.testCreateWithBrowserSession
    * telemetry.internal.browser.extension_unittest.ExtensionTest.testWebApp
    * telemetry.internal.browser.extension_unittest.MultipleExtensionTest.testWebApp
    * telemetry.internal.browser.extension_unittest.WebviewInExtensionTest.testWebApp
    * telemetry.internal.browser.tab_unittest.ServiceWorkerTabTest.testIsServiceWorkerActivatedOrNotRegistered
    * telemetry.internal.browser.tab_unittest.TabTest.testHighlight
    * telemetry.internal.browser.tab_unittest.TabTest.testRendererCrash
    * telemetry.internal.browser.tab_unittest.TabTest.testTimeoutExceptionIncludeConsoleMessage
    * telemetry.internal.snap_page_util_unittest.JSONTransmissionTest.testTransmittingLargeObject
    * ... 7 more (37 total) ...
     
  179. ( 2 secs ) views_perftests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 31s
    Total tests: n/a
     
  180. ( 3 secs ) webkit_python_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Shard duration: 25s
    Total tests: 1551
    * Passed: 1535 (1535 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  181. ( 205 ms ) Tests statistics
     
    Stats
    Total shards: 110
    Total runtime: 5:38:49.062000
     
  182. ( 457 ms ) process_dumps
  183. ( 6 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-c-dkr8" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539330385693523, "id": "8932888817449472704", "project": "chromium", "tags": ["builder:Win10 Tests x64 (dbg)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/836e5cd90af24fa6af71e4e633d1c0fb41ca0765", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder (dbg)", "parent_buildnumber:75159", "scheduler_invocation_id:9098318879753728848", "scheduler_job_id:chromium/Win10 Tests x64 (dbg)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 Tests x64 (dbg)" setup_build
buildnumber 3690 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder (dbg)" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "836e5cd90af24fa6af71e4e633d1c0fb41ca0765" setup_build
parent_got_revision_cp "refs/heads/master@{#599128}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25135}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "836e5cd90af24fa6af71e4e633d1c0fb41ca0765" setup_build
swarm_hashes {"accessibility_unittests": "36e2f1ffa56ccbae1e384ddb392d93a9f962127a", "angle_unittests": "ccd047a193507733ddf070f38f6b62022e6a598f", "app_shell_unittests": "150821b38735e05ab390c37ff4945e522cdcaac5", "aura_unittests": "9f7a99ded0eaf82127d1f3660bcb24d8fe87f5f3", "base_unittests": "7a605b6b11bc01b39856c491e6c7ea32de274ccb", "blink_common_unittests": "5992a554035b8f4e833bf9fbf75100aee30a0b9c", "blink_fuzzer_unittests": "51d9f85b528ef747c99de69d8343720ae2785ae5", "blink_heap_unittests": "4f7d374b0e5d217818f9b70927691b8bd41247f9", "blink_platform_unittests": "4029f0e7d212ef12d06f3c43efdea5e3cdb893ed", "boringssl_crypto_tests": "22936e0e47c0228f66b527b15d21e7d8d43a9322", "boringssl_ssl_tests": "26cbe808f40f0c450ee6d8fd523d9a4c47e784a4", "cacheinvalidation_unittests": "54c0131805d12f68594136037292b705b9391b4c", "capture_unittests": "d6c82442966348251a4d15e416767bba9b4cf9ff", "cast_unittests": "6ecdd0d0daf0410fc20521fd802e389a2621f5ba", "cc_unittests": "d3886e7bfb155f901f3b9e0942b5daac1f8545fa", "chrome_app_unittests": "aa49f681d9421d1e88658c9a192cb7fe7de04e20", "chrome_cleaner_unittests": "00067a48ee270ff1269c4c3ca6cf5211b85afffc", "chrome_elf_import_unittests": "c6384abed42f2e4b15dead1b724a726c40729321", "chrome_elf_unittests": "d323e36412562c6ce109c7bfac00e3f50a776a02", "chromedriver_unittests": "cd219ec533ed34ad058b748b413f72efb89b5279", "components_browsertests": "6787369d242120da35dde7c29de2d72da558b913", "components_unittests": "8641e736b9780ffcfd5a1da0b2ef0b21e409700b", "compositor_unittests": "8a52a9eb3a28fab6eb972ef3b5197e9974cdcfab", "content_browsertests": "40612b678aa31a5e523b50b31d09b8dcd3bf1828", "content_shell_crash_test": "ea611c2d17fb6718d2630de75189fa2ad8e00f70", "content_unittests": "b198690ab57f1c98958e1e1d953de841bd09f052", "courgette_unittests": "5dbb6a753c98a725261d8f20facc7ba036e13bf6", "crashpad_tests": "0e8b85221ad1402f0aec2727875747d98915c6db", "cronet_tests": "eb0629307686893e0bdde5c9ff132c3e5fa2f108", "cronet_unittests": "a8e3f7c0a8546872d26b58d80a27bfa7a4b661e5", "crypto_unittests": "abc8666f4213bc650cf08d0036cce0827ac295ad", "device_unittests": "ec15a97c92cff19144df5c195a58b5b425200989", "display_unittests": "a28ad8f9bb97ba386768475e3ac9e598bed37131", "elevation_service_unittests": "5d47808a23e12d61bed10499366a1afe9cefc61a", "events_unittests": "3b3771daaa7806f37f8d307785acedfeaa9140a6", "extensions_browsertests": "81614576c8e1fb9dbf3bad9af66bc5b381a95485", "extensions_unittests": "1e390d569faf2ecebbaabd74a6667e234a9e86a1", "filesystem_service_unittests": "ddbce59c72fd8b5b5a1c9e2cbb008abe776ddf91", "gcm_unit_tests": "b41e67e317c43d86c3cf91c05ecff91e35b281d3", "gfx_unittests": "c9f13e44d6a64a7598204ddd0155396bd489ba53", "gin_unittests": "5d9adcce4b64cd0f657d239ecd769634de4c4421", "google_apis_unittests": "b73bfc4f30a0072d60b3d4d8f821130188fc97a0", "gpu_unittests": "5bf6a0789918076e96601a2e7c2ad88e006a6986", "headless_browsertests": "a6adda5b31d0ad903b1662d217e120ac81406e11", "headless_unittests": "cbc1abd63f7f332450ae90dafdc9abdb25104805", "install_static_unittests": "8db1d1f45538a5f208c5c402eab1697050652e12", "installer_util_unittests": "1e9af6e9ece3beb6e8959b378b1f3bd82badbf25", "interactive_ui_tests": "c38f981e1164d2a31a6a13f3db04ed1e5d94e0b8", "ipc_tests": "dd8cf70d21691127bf39ae1aa3dbc2785b19456b", "jingle_unittests": "cdde767b6539cd7f6fd6323f8af6070ff0469161", "latency_unittests": "7136eba0bc56ff240450daa9b0d799e05cb297c6", "leveldb_service_unittests": "894ffd7a73785e2afa0e453017c09abaf8199707", "libjingle_xmpp_unittests": "efbcf0b9349c690166c5ddfabe801cbfd3e02d78", "media_blink_unittests": "a354d4752db81f1403904d680f62bdcaf71e377c", "media_service_unittests": "f3f52e0214c14421dc35ba10d7f266de6ddb416d", "media_unittests": "65f02524d90d4bcd95dae0e4a84f9886e408da0b", "message_center_unittests": "4a70ec25dae1432c3d1697e9d28da7fe754f6efb", "metrics_python_tests": "5b14f5bcf3ca2420b61294308cf5ee3a6d226d56", "midi_unittests": "ec99f8b0f8b57403a2dc48cfd66c69420fc6f4f2", "mojo_core_unittests": "5f583ccf216e668913eab9f666e736c7f1e24ce6", "mojo_unittests": "b6329abc0002d5583a07d0b890b9c4480470d3f6", "nacl_loader_unittests": "753e8085ef8881b56e665633f2206b98d7587e37", "native_theme_unittests": "da9481ab874bb036dc0c9e3cbff7a14cafb03c95", "net_unittests": "0d2326d68dab92c27205a434bb13e328e23bae98", "notification_helper_unittests": "3c797ba44844c3fa5b657c14fac0982cf761ca9b", "pdf_unittests": "2a3038693d85fa69936849d54f13a9f38d6c871d", "performance_test_suite": "bf2f4b356006c043a96dcc487da588377315017c", "ppapi_unittests": "af7dea723f8afbd827cbd8171945d266140154a3", "printing_unittests": "9807b2a74f5762507686a0ad7e00da3590e5478a", "remoting_unittests": "cda1fdd7931e05b2430b27bf8f8f8a72c91fc24f", "sbox_integration_tests": "9d7e77c794922db851bca5868c2a718765d87e52", "sbox_unittests": "983469539a04a0542b012c329a4fc5ff94024297", "sbox_validation_tests": "40855d07ac8fc733b7c3d6a182585c2f8ffcc4e4", "service_manager_unittests": "7295fed2258ba27c9fc833d98f74a0e25fb38a30", "services_unittests": "e219fbb36512e30be2ea6d1a56eede440f318c50", "setup_unittests": "ef6bc0624456e72bf8bcf8745875b139899fa05b", "shell_dialogs_unittests": "fa3e7203388f7e000028403ba0dc400efec6e208", "skia_unittests": "1e207b94ad8e10f29b0d71bb5b1b7dfb6f3aa687", "snapshot_unittests": "9af43bcd9e68635dea3d8723f24c770deb06aff5", "sql_unittests": "904095aa60384d6ae0fbb86642f241d16bce8972", "storage_unittests": "e4f093d91a7e32c4359b8625093c3c04a696dcff", "sync_integration_tests": "c0ee5268b5fb19524ab9efb558599a38f9851fcc", "telemetry_gpu_unittests": "0ed901306bcd8906599c875636d0432c094a53b5", "telemetry_unittests": "d2e6a3400ce9e22385f3a0f334d7cd78b3aa530c", "traffic_annotation_auditor_unittests": "2512e59ba8a09a5766623c837cef86673db53a47", "ui_base_unittests": "06133950469be739a0ec2a3da4bb6adc8e0e2124", "ui_touch_selection_unittests": "6be7f5176347799f578cf288da819159315d0169", "unit_tests": "0c8c99717d52f50a8712ee06e699828e4674d54d", "url_unittests": "724cef298cfad7003dba3d13b5164f77b4011e1b", "views_perftests": "b092958de86664e4721db00d193426048b3e35e7", "views_unittests": "68d54940569e529137383b3469177510465ef36a", "viz_unittests": "0b5a2d79c2968c00330436756075e74b8cdbaad3", "vr_common_unittests": "49bdc097e046f9c85454c7016f6831b10ae38327", "vr_pixeltests": "5aa3f469a881611c5da54b80eb1011765109141a", "webkit_python_tests": "15de1dc36b3314ca60059f76147d28a7a3408891", "webkit_unit_tests": "5841a88432be1e3d91b7364206688c74ec2d81dd", "wm_unittests": "ec988f028a86f6371f311868839e1fdb8b467943", "wtf_unittests": "decce373fa0f0940be08fffd274b8f838d6f320d", "zucchini_unittests": "42a17f9fe242e9fca691b3756a9d58e18c28f7ee"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "836e5cd90af24fa6af71e4e633d1c0fb41ca0765" bot_update
got_revision_cp "refs/heads/master@{#599128}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  2. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  3. momohatt (momohatt10ohnoyoudont@gmail.com)
  4. Noel Gordon (noelohnoyoudont@chromium.org)
  5. John Z Wu (jzwohnoyoudont@chromium.org)
  6. Henrik Grunell (grunellohnoyoudont@chromium.org)
  7. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  8. yiyix (yiyixohnoyoudont@chromium.org)
  9. Maksim Sisov (msisovohnoyoudont@igalia.com)
  10. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  11. Trent Apted (taptedohnoyoudont@chromium.org)
  12. Sam McNally (sammcohnoyoudont@chromium.org)
  13. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  14. Trent Apted (taptedohnoyoudont@chromium.org)
  15. Yuki Yamada (yukiyohnoyoudont@google.com)
  16. rajendrant (rajendrantohnoyoudont@chromium.org)
  17. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  18. Patti (patricialorohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 07:46:25 UTC
Start Friday, 12-Oct-18 07:46:28 UTC
End Friday, 12-Oct-18 08:54:44 UTC
Pending 3 secs
Execution 1 hrs 8 mins

All Changes:

  1. CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:33:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 836e5cd90af24fa6af71e4e633d1c0fb41ca0765

    Comments

    CrOS FilesApp: Add Manage Linux sharing top menu link to settings page
    
    Shown when crostini and flag crostini-files are enabled.
    Links to chrome://settings/crostini/crostiniShared.
    Record UMA for clicks.
    
    Bug: 878324
    Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
    Reviewed-on: https://chromium-review.googlesource.com/c/1277130
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599128}

    Changed files

    • chrome/app/file_manager_strings.grdp
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
    • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
    • tools/metrics/histograms/enums.xml
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/main.html
    • ui/file_manager/file_manager/test/crostini_share.js
  2. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 07:17:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS
  3. [ServiceWorker] Add WPT tests to check request header for update

    Changed by momohatt - momohatt10ohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 07:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4512662655ea5694ebba6c13055e99c9a0b2d096

    Comments

    [ServiceWorker] Add WPT tests to check request header for update
    
    Spec requires that during the update of service workers, request headers
    for fetching main scripts should include "Service-Worker" field, while
    that for fetching importScripts() resources should not.
    This patch adds WPT tests to validate this behavior.
    
    Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267297
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599126}

    Changed files

    • AUTHORS
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html
  4. Add Quick View audio load test

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae2fcf0ef323eb487edced1ab876a090b3f9ce1e

    Comments

    Add Quick View audio load test
    
    Now we have the QuickView <webview> infra to detect the 'loaded' state
    of the <webview> content, add a <file-safe-media> audio test, and also
    check the <webview> renders its content on a transparent black body.
    
    This test exposed an issue in Blink node code. When the modal <dialog>
    is calling showModal(), its flat tree distribution can be out-of-date,
    causing a DCHECK crash when testing if the Quick View <dialog> element
    contains sibling <iframe id="command-dispatcher"> [1].
    
    Fix that: FlatTreeTraversal::ContainsIncludingPseudoElement() requires
    that its node arguments have up-to-date flat tree distribution. Ensure
    the <dialog>'s flat tree distribution is up-of-date _before_ trying to
    propagate the "inert" bit into sub-frames.
    
    Add crash test: html/dialog/showmodal-shadow-sibling-frame-crash.html
    
    [1] Known crash reports already exist: issue 789094 issue 804047.
    
    test: browser_tests --gtest_filter="QuickView*openQuickViewAudio"
    Bug: 891150, 789094, 804047
    Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961
    Reviewed-on: https://chromium-review.googlesource.com/c/1264138
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599125}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
    • ui/file_manager/integration_tests/file_manager/quick_view.js
  5. Clarify |stopSyncAndClearIdentity| with additional comment.

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3255a4ba5a80b407cc61864a85c469842894f469

    Comments

    Clarify |stopSyncAndClearIdentity| with additional comment.
    
    Namely, it is OK to call it multiple times.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278061
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599124}

    Changed files

    • ios/web_view/public/cwv_sync_controller.h
  6. Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"

    Changed by Henrik Grunell - grunellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bb43df173039894cf46c8b3476913f0f20ae6d1

    Comments

    Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"
    
    This reverts commit dfeab488cdc95233b19b9edeedef3d0b7581b17e.
    
    Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091
    
    Original change's description:
    > [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    > 
    > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    > add checking whether webcam is found or not.
    > Accordingly, exclude such test cases from test suites for devices that have no
    > camera.
    > 
    > Bug: 893494
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
    >       and it failed.
    > Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
    >       and it passed.
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
    >       and it passed.
    > 
    > Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599097}
    
    TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org
    
    Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893494
    Reviewed-on: https://chromium-review.googlesource.com/c/1278272
    Reviewed-by: Henrik Grunell <grunell@chromium.org>
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599123}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  7. Remove the round-robin list for third-party additions

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:51:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS
  8. GPU_Tests: Remove expectations after rebaseline

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py
  9. [ozone/wayland] Fix kiosk mode.

    Changed by Maksim Sisov - msisovohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 06:36:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f154daab631433d3d9706af7f3512aa6b196e52f

    Comments

    [ozone/wayland] Fix kiosk mode.
    
    This CL fixes a fullscreen state changes before the surface is
    activated.
    
    That is, Wayland may ignore fullscreen changes before the surface
    is activated. Thus, store a pending state, and once the surface
    is activated, trigger the change.
    
    Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a
    Bug: 843018
    Reviewed-on: https://chromium-review.googlesource.com/c/1275885
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599120}

    Changed files

    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  10. RemoteMacViews: Make fullscreen mode not crash

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 800a927eb503828f5cf6f489739e1a6efc444429

    Comments

    RemoteMacViews: Make fullscreen mode not crash
    
    Fix a few places where we would dereference a BridgedNativeWidgetImpl
    which is null when out-of-process. This doesn't guarantee correct
    behavior, but avoids a crash.
    
    Make WebContentsNSViewBridge::Show resize the web contents view and
    also all of its children.
    
    Bug: 859152
    Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342
    Reviewed-on: https://chromium-review.googlesource.com/c/1278533
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599119}

    Changed files

    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
    • content/browser/web_contents/web_contents_ns_view_bridge.mm
  11. Migrate base::AtomicFlag to std::atomic

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d64bfc8e330fea105de74137e6e176763dc546a4

    Comments

    Migrate base::AtomicFlag to std::atomic
    
    atomicops.h uses `volatile` which inhibits some compiler optimisations
    without contributing to threading correctness.
    
    Define AtomicFlag::IsSet() in the header, rather than out-of-line.
    Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver
    in base_perftests are up to 70% greater.
    
    Bug: 891536
    Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278425
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599118}

    Changed files

    • base/synchronization/atomic_flag.cc
    • base/synchronization/atomic_flag.h
  12. Make DriveFS opt-out in FilesApp tests.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:33:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9c79d562d8d3b789cca95b6909aa600a1dd39d2

    Comments

    Make DriveFS opt-out in FilesApp tests.
    
    Bug: 891197
    Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599117}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  13. media/gpu/v4l2: use actual number of planes in ioctls

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:30:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cec52397f2ea0fb8ac322378d229f1a454edf972

    Comments

    media/gpu/v4l2: use actual number of planes in ioctls
    
    The Tegra V4L2 library has a bug in its handling of VIDIOC_QUERYBUF that
    makes it fail if the number of planes of the passed v4l2_buffer does not
    exactly match the number of planes of the currently set format. This CL
    implements a workaround by first running a VIDIOC_G_FMT ioctl in
    AllocateBuffers(), and then passing the returned number of planes to the
    buffer constructor so the correct value can be passed to
    VIDIOC_QUERYBUF.
    
    And since we have this value, we also use it in VIDIOC_DQBUF.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on hana (Tegra devices have
    another bug that is fixed in the next CL).
    
    Change-Id: I830334de1cf322302fd476ac5535313ebc65900d
    Reviewed-on: https://chromium-review.googlesource.com/c/1275726
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599116}

    Changed files

    • media/gpu/v4l2/v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.h
  14. Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:29:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4

    Comments

    Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js
    
    These functions are currently in file_manager/file_manager/common/js/unittest_util.js
    which has a lot of files-app specific stuff that media apps shouldn't
    depend on.
    
     - Move MockAPIEvent to the only unittest (in gallery) that uses it.
     - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js
     - Updates the remaining handcrafted foo_unittest.html files in the files app
       * combination sed-script and manual edit.
    
    Bug: 879035
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1
    Reviewed-on: https://chromium-review.googlesource.com/c/1275545
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599115}

    Changed files

    • ui/file_manager/base/js/BUILD.gn
    • ui/file_manager/base/js/test_error_reporting.js
    • ui/file_manager/file_manager/background/js/device_handler_unittest.html
    • ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
    • ui/file_manager/file_manager/background/js/file_operation_manager_unittest.html
    • ui/file_manager/file_manager/background/js/import_history_unittest.html
    • ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
    • ui/file_manager/file_manager/background/js/media_scanner_unittest.html
    • ui/file_manager/file_manager/background/js/task_queue_unittest.html
    • ui/file_manager/file_manager/background/js/volume_manager_unittest.html
    • ui/file_manager/file_manager/common/js/BUILD.gn
    • ui/file_manager/file_manager/common/js/metrics_unittest.html
    • ui/file_manager/file_manager/common/js/unittest_util.js
    • ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.html
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
    • ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
    • ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/spinner_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html
    • ui/file_manager/gallery/js/BUILD.gn
    • ui/file_manager/gallery/js/entry_list_watcher_unittest.js
    • ui/file_manager/gallery/js/image_editor/BUILD.gn
    • ui/file_manager/image_loader/BUILD.gn
  15. Rename scopes and context in JSBasedEventListener::handleEvent()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:29:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7d87839234fceb435e01ca49cf72096ef6691599

    Comments

    Rename scopes and context in JSBasedEventListener::handleEvent()
    
    This CL renames some ambiguous name of scope and context in
    JSBasedEventListener::handleEvent().
    
    Split from another one:
    https://chromium-review.googlesource.com/c/chromium/src/+/1270300
    
    Bug: 872138
    Change-Id: I8e772ecdc283fd1585566cf56a52170b777f4608
    Reviewed-on: https://chromium-review.googlesource.com/c/1277135
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Cr-Commit-Position: refs/heads/master@{#599114}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  16. Remove service name and refactor data use update to metrics service

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:24:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dce70a031f697342a52b900211aa0ba7eceab082

    Comments

    Remove service name and refactor data use update to metrics service
    
    This CL does a bunch of steps to make the servicification easy to do.
    1. Removes the usage of ServiceName in data_use_measurement
    2. Refactors the data use update to metrics service to not take service
    name and instead send if the data use is from metrics component.
    3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(),
    ChromeDataUseMeasurement is introduced that does the posting to UI thread
    (from io_thread.cc). This helps in servicification since there won't be
    thread hop. This also helps when CDUA classes are removed, and
    ChromeDataUseMeasurement can be there without dependency.
    
    Bug: 808498
    Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48
    Reviewed-on: https://chromium-review.googlesource.com/c/1272256
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599113}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.cc
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.h
    • chrome/browser/io_thread.cc
    • chrome/browser/io_thread.h
    • chrome/browser/net/system_network_context_manager.cc
    • chrome/browser/net/system_network_context_manager.h
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/data_use_measurement/core/BUILD.gn
    • components/data_use_measurement/core/DEPS
    • components/data_use_measurement/core/data_use_ascriber.cc
    • components/data_use_measurement/core/data_use_ascriber.h
    • components/data_use_measurement/core/data_use_measurement.cc
    • components/data_use_measurement/core/data_use_measurement.h
    • components/data_use_measurement/core/data_use_measurement_unittest.cc
    • components/data_use_measurement/core/data_use_network_delegate.cc
    • components/data_use_measurement/core/data_use_network_delegate.h
    • components/data_use_measurement/core/data_use_network_delegate_unittest.cc
    • components/data_use_measurement/core/data_use_user_data.cc
    • components/data_use_measurement/core/data_use_user_data.h
    • components/domain_reliability/uploader.cc
    • components/domain_reliability/uploader.h
    • components/metrics/data_use_tracker.cc
    • components/metrics/data_use_tracker.h
    • components/metrics/data_use_tracker_unittest.cc
    • components/metrics/metrics_service.cc
    • components/metrics/metrics_service.h
    • components/metrics/reporting_service.cc
    • components/metrics/reporting_service.h
    • google_apis/gaia/gaia_auth_util.cc
    • google_apis/gaia/gaia_auth_util.h
    • google_apis/gaia/gaia_oauth_client.cc
    • google_apis/gaia/oauth2_api_call_flow.cc
    • tools/metrics/histograms/histograms.xml
  17. Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:12:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 028fceebebe0743ddd7bb16dc8b753ae0f41a3f2

    Comments

    Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc
    
    
    git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error.
    2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS
    2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@e2727ef6f5dc
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453
    Reviewed-on: https://chromium-review.googlesource.com/c/1278301
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599112}

    Changed files

    • DEPS
  18. Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."

    Changed by Patti - patricialorohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:10:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2893ee9102687d16f2f65fa96651d8bd1fdab7

    Comments

    Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."
    
    This reverts commit 86da6573944f302cf9df04d59a7e35bba895d059.
    
    Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1)
      https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29
    
    Findit found culprit 598844 with 75% confidence, so reverting this to try and fix.
    
    Original change's description:
    > [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
    > 
    > * The service shouldn't unregister from the topics, when handler
    > the Handler is unregistering from topic (as stated in the documentation
    > for for UnregisterHandler).
    > * Sync shouldn't unregister on browser shutdown
    > 
    > Bug: 801985, 876274
    > Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76
    > Reviewed-on: https://chromium-review.googlesource.com/c/1196522
    > Commit-Queue: Tatiana Gornak <melandory@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598844}
    
    TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org
    
    Change-Id: I70fa87c3476925814408665644acb23c3c1f1614
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 801985, 876274, 894715
    Reviewed-on: https://chromium-review.googlesource.com/c/1278273
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599111}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/sync/driver/glue/sync_backend_host_impl.cc