Home | Search | chromium - Builders
Login

Builder Win10 Tests x64 (dbg) Build 1861 Microsoft Windows

Results:

Failure network_service_interactive_ui_tests (experimental) on Windows-10-15063

Trigger Info:

Projectchromium
Revision3459a089449cdc6728667a5e4d60bf30ac96ffc4
Got Revision3459a089449cdc6728667a5e4d60bf30ac96ffc4

Execution:

Steps and Logfiles:

Show:
  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Tiger Oakes (tigeroohnoyoudont@google.com)
  2. Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
  3. bsheedy (bsheedyohnoyoudont@chromium.org)
  4. Scott Violet (skyohnoyoudont@chromium.org)
  5. Paul Miller (paulmillerohnoyoudont@google.com)
  6. Matt Menke (mmenkeohnoyoudont@chromium.org)
  7. Yue Li (updowndotaohnoyoudont@chromium.org)
  8. Samuel Huang (huangsohnoyoudont@chromium.org)
  9. Ran Ji (ranjohnoyoudont@chromium.org)
  10. Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
  11. Moe Ahmadi (mahmadiohnoyoudont@chromium.org)
  12. Yiming Zhou (uwyimingohnoyoudont@google.com)
  13. Marc Treib (treibohnoyoudont@chromium.org)
  14. Francois Doray (fdorayohnoyoudont@chromium.org)
  15. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  16. Chris Mumford (cmumfordohnoyoudont@chromium.org)
  17. Emily Hanley (eyaichohnoyoudont@google.com)
  18. Stephen McGruer (smcgruerohnoyoudont@chromium.org)

Timing:

Create Wednesday, 11-Jul-18 20:36:43 UTC
Start Wednesday, 11-Jul-18 20:36:50 UTC
End Wednesday, 11-Jul-18 21:50:27 UTC
Pending 6 secs
Execution 1 hrs 13 mins

All Changes:

  1. Supersize: Adds counter for number of symbols of each type

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3459a089449cdc6728667a5e4d60bf30ac96ffc4

    Comments

    Supersize: Adds counter for number of symbols of each type
    
    The infocard now displays the amount of each type of symbol present in
    a container. This is a 3rd column alongside the existing total byte
    size and percentage columns.
    
    Bug: 847599
    Change-Id: Iab247f1891ee036262956dd585e81864ee8ce12c
    Reviewed-on: https://chromium-review.googlesource.com/1133759
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574301}

    Changed files

    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/infocard-ui.js
    • tools/binary_size/libsupersize/template_tree_view/shared.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  2. Fix uint8 -> uint8_t

    Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:11:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15449df72eb980ce894ee03ac9d8041b204a9df3

    Comments

    Fix uint8 -> uint8_t
    
    It was causing the following compilation error:
    ../../media/gpu/jpeg_encode_accelerator_unittest.cc:415:29: error: unknown type name 'uint8'; did you mean 'uint'?
              static_cast<const uint8*>(hw_out_shm_->memory()), hw_encoded_size,
                                ^~~~~
                                uint
    
    TBR=kcwu@chromium.org
    BUG=None
    TEST=compiles on simple chrome workflow.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If8869b2fe9d1a62e858637fc4b6e412990ad40a9
    Reviewed-on: https://chromium-review.googlesource.com/1133774
    Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574300}

    Changed files

    • media/gpu/jpeg_encode_accelerator_unittest.cc
  3. Fix flaky NPE in VR Dialog tests

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fd7a607f0e9ba82642d92b7a92ecd261da81608

    Comments

    Fix flaky NPE in VR Dialog tests
    
    Fixes a race condition in the code to wait for VR native UI quiescence
    that caused the provided callback to be nulled out prematurely if
    multiple interactions were run in quick succession.
    
    Change-Id: I6d56f8fe6840bd45efc603026b731b0574ad1306
    Reviewed-on: https://chromium-review.googlesource.com/1134038
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574299}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/NativeUiUtils.java
  4. chromeos: disable LoginWebDialogTest.CannotMinimize

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd2556851e3cf048df2cbebfbfa2a2633e89e786

    Comments

    chromeos: disable LoginWebDialogTest.CannotMinimize
    
    for mash_browser_tests as it's flaky.
    
    BUG=855767
    TEST=none
    TBR=msw@chromium.org
    
    Change-Id: Ib0952cdb6aed73556784e9002d2a364d2120fbf7
    Reviewed-on: https://chromium-review.googlesource.com/1134051
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574298}

    Changed files

    • testing/buildbot/filters/mash.browser_tests.filter
  5. Variations: Rename 'win' to 'windows' in testing config

    Changed by Paul Miller - paulmillerohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:07:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad77b789e40639b5d0d70875d7cc0aa4a506473d

    Comments

    Variations: Rename 'win' to 'windows' in testing config
    
    This is to match server-side tools. Since GN uses "win", there must
    still be some boundary where "win" is converted to "windows"; move the
    conversion from fieldtrial_to_struct.py to field_trial_config/BUILD.gn.
    
    Also add "android_webview" to the field trial config presubmit.
    
    BUG=707911
    
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I73c2d2fa98410e32ae77d053098d704ee40378ac
    Reviewed-on: https://chromium-review.googlesource.com/1130348
    Commit-Queue: Paul Miller <paulmiller@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574297}

    Changed files

    • components/variations/field_trial_config/BUILD.gn
    • testing/variations/PRESUBMIT.py
    • testing/variations/README.md
    • testing/variations/fieldtrial_testing_config.json
    • tools/chrome_proxy/webdriver/variations_combinations.py
    • tools/perf/core/perf_benchmark.py
    • tools/variations/fieldtrial_to_struct.py
    • tools/variations/fieldtrial_to_struct_unittest.py
    • tools/variations/fieldtrial_util.py
    • tools/variations/fieldtrial_util_unittest.py
    • tools/variations/unittest_data/test_config.json
  6. Delete the media cache(s) when using a single combined HTTP cache.

    Changed by Matt Menke - mmenkeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:05:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e226149af1b3f003b5d3f59e19ee17bef7419c42

    Comments

    Delete the media cache(s) when using a single combined HTTP cache.
    
    This is so that I can try increasing the media cache size in experiments
    without increasing Chrome's profile size (Except possibly for profiles
    that have never been used to play video).
    
    Bug: 789657
    Change-Id: I45e8f8c6e346a1fa7d05b0bea3e8b001d7dc41e1
    Reviewed-on: https://chromium-review.googlesource.com/1130162
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574296}

    Changed files

    • chrome/browser/profiles/profile_browsertest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
  7. Handle hotword enable/disable in assistant service

    Changed by Yue Li - updowndotaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:02:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a3ec92579dd20374fbbc96ed991f3ba57b09bc

    Comments

    Handle hotword enable/disable in assistant service
    
    - Restart the Assistant when hotword enable state changes
    - Add mojom methods for hotword_enabled pref.
    
    Bug: b/110219351
    Test: Manual test
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: If45adaab50f412d08b43fdc7b6883acecc2441d8
    Reviewed-on: https://chromium-review.googlesource.com/1117849
    Commit-Queue: Yue Li <updowndota@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574295}

    Changed files

    • ash/public/interfaces/voice_interaction_controller.mojom
    • ash/shelf/app_list_button.h
    • ash/system/palette/tools/metalayer_mode.h
    • ash/voice_interaction/voice_interaction_controller.cc
    • ash/voice_interaction/voice_interaction_controller.h
    • ash/voice_interaction/voice_interaction_controller_unittest.cc
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.cc
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.h
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.cc
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.h
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client_unittest.cc
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_browser_proxy.js
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.js
    • chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.cc
    • chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.h
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/service.cc
    • chromeos/services/assistant/service.h
    • chromeos/services/assistant/utils.cc
    • chromeos/services/assistant/utils.h
  8. [Zucchini] DEX parsing: Implement stricter size checks for MapItem.

    Changed by Samuel Huang - huangsohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:02:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f63bf220bcb93560358fbe593ebccc4d64f4baa

    Comments

    [Zucchini] DEX parsing: Implement stricter size checks for MapItem.
    
    This CL fixes a bug discovered by the Fuzzer, where DEX parsing
    triggers CHECK() failure due to an attempt to read a 4-byte value that
    straddles EOF.
    
    Tracing (Zucchini-read) using the Fuzzer-provided DEX show that the
    faulty read attempt is for ClassDefItem::static_values_off, which is
    a field in a fixed-length item.
    
    Our fix is to validate MapItem entries for fixed-length items. Details:
    - Add GetItemBaseSize() to return an item size bound. For fixed-length
      items, this is exactly the item size. Moreover, no 4-byte alignment
      is needed, since the item sizes are already multiples of 4 bytes.
    - In DisassemblerDex::ParseHeader(), verify each MapItem fits in the
      image. For fixed-length items, this check enables safe read for
      items whose index are within bound (and avoid similar bugs). For
      variable-length items, this serves as a sanity check to quickly
      reject obviously bad inputs. Subsequent parsing will perform a more
      refined check. For unhandled items, sizes are assumed to be 1.
    - Not checked: Whether MapItems ranges overlap. May do this in the
      future (more refactoring will be needed).
    
    Bug: 862566
    Change-Id: If8efce122979fa1a36d1d445556d414eb499d273
    Reviewed-on: https://chromium-review.googlesource.com/1133713
    Reviewed-by: Samuel Huang <huangs@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574294}

    Changed files

    • components/zucchini/disassembler_dex.cc
  9. Revert "Move kApplicationLocale pref to ui/base"

    Changed by Ran Ji - ranjohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:00:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5908cff94737bde5356c8305a348f66cae6788c2

    Comments

    Revert "Move kApplicationLocale pref to ui/base"
    
    This reverts commit 6ad1cbd1bd26744de3a8d9be9e6fb824ac5c12b3.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > Move kApplicationLocale pref to ui/base
    > 
    > We need to use the pref in components, so move the pref to ui/base so it
    > can be accessed.
    > 
    > TBR=jam@chromium.org
    > 
    > Bug: 729596
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: Iffc7c5c2f459340c14a74787defeab00c6c5589c
    > Reviewed-on: https://chromium-review.googlesource.com/1125143
    > Commit-Queue: Ran Ji <ranj@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573536}
    
    TBR=sky@chromium.org,jam@chromium.org,asvitkine@chromium.org,ranj@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 729596
    Change-Id: I950b8aa43701741de843172f24dd4a1b9887a5de
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1133618
    Reviewed-by: Ran Ji <ranj@chromium.org>
    Commit-Queue: Ran Ji <ranj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574293}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.cc
    • chrome/browser/chromeos/accessibility/dictation_chromeos.cc
    • chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
    • chrome/browser/chromeos/hats/hats_dialog.cc
    • chrome/browser/chromeos/locale_change_guard.cc
    • chrome/browser/chromeos/login/oobe_localization_browsertest.cc
    • chrome/browser/chromeos/login/screens/welcome_screen.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/ui/login_display_host_webui.cc
    • chrome/browser/extensions/api/settings_private/prefs_util.cc
    • chrome/browser/lifetime/application_lifetime.cc
    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/prefs/chrome_command_line_pref_store.cc
    • chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
    • chrome/browser/profiles/profile.cc
    • chrome/browser/profiles/profile_impl.cc
    • chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
    • chrome/browser/search/one_google_bar/one_google_bar_loader_impl_unittest.cc
    • chrome/browser/ui/app_list/arc/arc_app_utils.cc
    • chrome/browser/ui/search/local_ntp_test_utils.cc
    • chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc
    • chrome/browser/ui/webui/settings/languages_handler.cc
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • chrome/service/service_process.cc
    • ios/chrome/browser/prefs/browser_prefs.mm
    • ui/base/BUILD.gn
    • ui/base/pref_names.cc
    • ui/base/pref_names.h
  10. Autoplay: allow autoplay for kiosk applications.

    Changed by Mounir Lamouri - mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:54:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e20a770c6072f9563c9c12f001876c7ae59469a

    Comments

    Autoplay: allow autoplay for kiosk applications.
    
    The different with other Chrome Apps is that <webview> should also be
    allowed to autoplay if they are inside a Kiosk application.
    
    Bug: 856659
    Change-Id: If51ca43549d3829eeb9fe25309770467c1fc14c2
    Reviewed-on: https://chromium-review.googlesource.com/1115096
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574292}

    Changed files

    • chrome/browser/extensions/chrome_extension_web_contents_observer.cc
    • chrome/test/base/ash_test_environment_chrome.cc
    • chrome/test/base/ash_test_environment_chrome.h
  11. [AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2)

    Changed by Moe Ahmadi - mahmadiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:53:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df5e2cc33a579c47e6242a808195437092b2f344

    Comments

    [AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2)
    
    This CL moves the logic to set the infobar's bottom margin from
    |-layoutSubviews| to |-sizeThatFits:|. The former method doesn't
    always get called after the secondary toolbar disappears in
    landscape mode. The latter does get called more reliably in both
    portrait and landscape modes.
    Also provides comments on why |-setFrame:| is overridden.
    
    Bug: 849433
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I3ce410378d60535178a0c0c9d0f12f11948772ba
    Reviewed-on: https://chromium-review.googlesource.com/1112303
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574291}

    Changed files

    • ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
  12. Removing the client name parameter from autofill server queries.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f799497909efb1abf363546de886bfa71c0025a

    Comments

    Removing the client name parameter from autofill server queries.
    
    When attempting to autofill a form, Chrome queries the autofill server
    for form field predictions. Inside the autofill server query request url is a 'client' parameter. In official Chrome builds, the code sets the parameter value to 'Google+Chrome'. In unofficial Chrome builds, the code sets the parameter value to 'Chromium'.
    
    This discrepany in value between the 'client' parameter causes problems
    for Autofill Captured Sites Interactive UI Tests (Captured Sites Tests). As its name indicates, the Captured Sites Tests uses the InProcessBrowserTest framework to test Chrome Autofill on captured sites. A test author creates a test by capturing a site using Web Page Replay Go (WPR). When running the test, WPR stands up a local server to replay the captured traffic, matching replay requests to captured requests. A test author typically uses an official Chrome build to capture sites, so the capture files would contain autofill server requests with one client parameter value. On the other hand InProcessBrowserTests are unofficial Chrome builds, so test would always query the autofill server with a different parameter value. The WPR cannot match the replay request to the captured request, and return 404. The test would fail.
    
    This autofill server actually does not consume the client parameter. So this fix addresses the above problem by removing the client name parameter from autofill server queries.
    
    Bug: 849778
    Change-Id: Iff9a0d7d4c8052b7f91e940e1a7a2536ec6ac996
    Reviewed-on: https://chromium-review.googlesource.com/1119359
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Cr-Commit-Position: refs/heads/master@{#574290}

    Changed files

    • components/autofill/core/browser/autofill_download_manager.cc
  13. Remove unnecessary thread-affinity in /components/sync*

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:44:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95851f140e1532050909cdef0f5ea4cd128b20fb

    Comments

    Remove unnecessary thread-affinity in /components/sync*
    
    This CL replaces many instances of ThreadTaskRunnerHandle by
    SequencedTaskRunnerHandle, and SingleThreadTaskRunner by
    SequencedTaskRunner, in /components/sync/, /components/sync_bookmarks/,
    and /components/sync_sessions/.
    
    There are still several ThreadCheckers around which should become
    SequenceCheckers. That will follow in another CL soon.
    
    Bug: 846238
    Change-Id: I180185e0e4d380f69246ccf52b6dd9a1b4cfbee8
    Reviewed-on: https://chromium-review.googlesource.com/1131474
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574289}

    Changed files

    • components/sync/driver/backend_migrator.cc
    • components/sync/driver/data_type_controller.h
    • components/sync/driver/data_type_manager_impl.cc
    • components/sync/driver/fake_data_type_controller.cc
    • components/sync/driver/frontend_data_type_controller_unittest.cc
    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_impl_unittest.cc
    • components/sync/driver/model_type_controller_unittest.cc
    • components/sync/driver/shared_change_processor.cc
    • components/sync/driver/shared_change_processor.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_stopped_reporter.cc
    • components/sync/engine/fake_sync_manager.cc
    • components/sync/engine_impl/model_type_connector_proxy.cc
    • components/sync/engine_impl/model_type_registry.cc
    • components/sync/engine_impl/sync_encryption_handler_impl.cc
    • components/sync/engine_impl/sync_encryption_handler_impl.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_scheduler_impl.cc
    • components/sync/engine_impl/sync_scheduler_impl_unittest.cc
    • components/sync/model_impl/client_tag_based_model_type_processor.cc
    • components/sync/model_impl/client_tag_based_model_type_processor_unittest.cc
    • components/sync/model_impl/model_type_store_impl.cc
    • components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_sessions/session_data_type_controller.cc
    • components/sync_sessions/session_sync_bridge.cc
    • components/sync_sessions/sessions_sync_manager.cc
  14. RC: Make UsageClock work on ChromeOS.

    Changed by Francois Doray - fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:40:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ff0122069f9f0ce5c456c9d8eb3ba74142cc7f7

    Comments

    RC: Make UsageClock work on ChromeOS.
    
    Now that DesktopSessionDurationTracker is built on ChromeOS, UsageClock
    can work the same way on all platforms.
    
    Bug: 775644
    Change-Id: Ic90984b2f36a1ffbf19047fae0bb953d56653eee
    Reviewed-on: https://chromium-review.googlesource.com/1133419
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574288}

    Changed files

    • chrome/browser/resource_coordinator/usage_clock.cc
    • chrome/browser/resource_coordinator/usage_clock.h
    • chrome/browser/resource_coordinator/usage_clock_unittest.cc
  15. Update V8 to version 6.9.351.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 19:34:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca4ce3f01347ddb612162ee031443b5dbc29b277

    Comments

    Update V8 to version 6.9.351.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c3ce505d..8dc93fc4
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I9cda5847bd8104c45b418f6c47c784b7352b881c
    Reviewed-on: https://chromium-review.googlesource.com/1133437
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574287}

    Changed files

    • DEPS
  16. Disable portion of navigation preload test failing with network service.

    Changed by Chris Mumford - cmumfordohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:33:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca700a51e4bea95516073239ceb682c0586ba96c

    Comments

    Disable portion of navigation preload test failing with network service.
    
    A recent change (crrev.com/c/1079787) is causing
    a portion of http/tests/serviceworker/navigation_preload/use-counter.html
    to fail when the network service is disabled. Temporarily disabling.
    
    TBR=loonybear@chromium.org,jam@chromium.org
    
    Bug: 862643
    Change-Id: I32848d107bfd7aabdf7de71fc177aebcce386d2a
    Reviewed-on: https://chromium-review.googlesource.com/1133685
    Commit-Queue: Chris Mumford <cmumford@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574286}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  17. Cleaning up perf data generator now that we are on OBBS

    Changed by Emily Hanley - eyaichohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:32:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7dca0885bc6876f53d5285c3ca16c1e48bed7ec

    Comments

    Cleaning up perf data generator now that we are on OBBS
    
    Bug: 757933
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I3268b95bd05eaa9ea86547ccfd8dd7e5d4711c90
    Reviewed-on: https://chromium-review.googlesource.com/1133691
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574285}

    Changed files

    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_data_generator_unittest.py
  18. Remove DCHECK for ScrollTree containment in ScrollTimeline::CurrentTime

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59ec1d863c20d9f5d543901bab5d35c4882f1b0a

    Comments

    Remove DCHECK for ScrollTree containment in ScrollTimeline::CurrentTime
    
    The original assertion that if a ScrollTimeline had a non-null scroller
    id (either pending or active) then said id would be in the ScrollTree
    was actually false. There are cases where the ScrollTimeline can have a
    scroller id, but the scrolling element would not be in the ScrollTree -
    for example a composited overflow: visible element would meet this
    criteria.
    
    As such, this CL converts the DCHECK into an early-exit for this case.
    
    Bug: 853231
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I0ca14a8e8f516357ee9814388514ba2f72fdfd47
    Reviewed-on: https://chromium-review.googlesource.com/1133317
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574284}

    Changed files

    • cc/animation/scroll_timeline.cc
    • third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-non-scrollable-expected.html
    • third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-non-scrollable.html