Home | Search | chromium - Builders
Login

Builder Win10 FYI Release (NVIDIA) Build 1688 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisiond417866204188b709447dfb64ba68740a182b7a5
Got Revisiond417866204188b709447dfb64ba68740a182b7a5

Execution:

Steps and Logfiles:

Show:
  1. ( 0 ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  2. Colin Blundell (blundellohnoyoudont@chromium.org)
  3. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  4. Raphael Kubo da Costa (CET) (raphael.kubo.da.costaohnoyoudont@intel.com)
  5. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  6. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  7. rajendrant (rajendrantohnoyoudont@chromium.org)
  8. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  9. Aleks Totic (atoticohnoyoudont@chromium.org)
  10. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  11. Anita Woodruff (awdfohnoyoudont@chromium.org)
  12. Hitoshi Yoshida (periaohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 09:53:07 UTC
Start Thursday, 12-Jul-18 09:54:29 UTC
End Thursday, 12-Jul-18 12:11:41 UTC
Pending 1 mins 21 secs
Execution 2 hrs 17 mins

All Changes:

  1. Cancel long-press operation if the gesture is scrolling

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:21:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d417866204188b709447dfb64ba68740a182b7a5

    Comments

    Cancel long-press operation if the gesture is scrolling
    
    This CL adds the code to cancel the long-press operation which shows
    inline setting when the user stats the scrollingo
    
    Previously that was done in Android (ag/4340201) but it didn't work
    for vertical scroll since the scroll is handled on Chrome side. With
    this CL, scroll detection is done on Chrome side and the code handles
    correctly with vertical scrolls in addition to horizontal ones.
    
    Bug: b/111100376
    Bug: 858938
    Test: Manual (inline setting does't open during vertical scroll)
    Change-Id: I84407b331dc320e6acd3a776938104ad018d46a3
    Reviewed-on: https://chromium-review.googlesource.com/1124263
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Greg Kerr <kerrnel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574512}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
    • ash/system/message_center/arc/arc_notification_item.h
    • ash/system/message_center/arc/arc_notification_item_impl.cc
    • ash/system/message_center/arc/arc_notification_item_impl.h
    • ash/system/message_center/arc/arc_notification_manager.cc
    • ash/system/message_center/arc/arc_notification_manager.h
    • ash/system/message_center/arc/mock_arc_notification_item.h
    • components/arc/common/notifications.mojom
    • components/arc/test/fake_notifications_instance.cc
    • components/arc/test/fake_notifications_instance.h
  2. OAuth2LoginManager: Handle consecutive refresh token updates

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2f7998c5e85ffebc0c1f7588bcc45a73e1de4dc

    Comments

    OAuth2LoginManager: Handle consecutive refresh token updates
    
    OAuth2LoginManager currently assumes that
    OAuth2TokenService::Observer::OnRefreshTokenAvailable() will never be
    called twice consecutively for the primary account; in particular,
    it calls VerifySessionCookies(), which DCHECKS that
    |oauth2_login_verifier_| is null before instantiating that ivar.
    
    However, this assumption is no longer valid. A simple example:
    - A refresh token is found during startup, resulting in
      OnRefreshTokenAvailable() firing.
    - The user revokes their refresh token remotely.
    - Sync locally enters an error state, prompting the user to reauth
      locally.
    - The user reauths locally, resulting in OnRefreshTokenAvailable()
      firing.
    
    Other examples are possible as well.
    
    This CL extends OAuth2LoginManager to handle this case by stopping
    ongoing actions related to the current refresh token for the primary
    account when OAuth2LoginManager receives the notification that that
    refresh token has been updated.
    
    This CL is concretely necessary to unblock
    https://chromium-review.googlesource.com/c/chromium/src/+/1126861,
    which is firing the "token available" notification as part of startup
    when adding an invalid token for the primary account and triggers the
    DCHECK above on ChromeOS browsertests. Those failures were how I
    discovered this issue.
    
    Change-Id: I55ced6fe49055c6c6c4d1e7ce138a0d080ecda38
    Reviewed-on: https://chromium-review.googlesource.com/1127662
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574511}

    Changed files

    • chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
  3. shared worker: Simplify the default network factory logic.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab39b893750485f84d1f607be642fe1efdc27f7f

    Comments

    shared worker: Simplify the default network factory logic.
    
    When NetworkService is off but S13nSW is on, shared worker jumped
    through hoops to get a factory bundle to the renderer. It was
    giving the renderer a NetworkService default factory and expecting the
    renderer to clear it.
    
    But we can just give a non-NetworkService direct network default factory,
    since that capability was added in r565058.
    
    Bug: 839982
    Change-Id: Ie5c4f182b87526e2f15a7b2a8b62ed03f7e5595f
    Reviewed-on: https://chromium-review.googlesource.com/1134708
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574510}

    Changed files

    • content/browser/shared_worker/shared_worker_host.cc
    • content/renderer/shared_worker/embedded_shared_worker_stub.cc
  4. Revert "licenses.py: Skip another //tools/binary_size subdirectory."

    Changed by Raphael Kubo da Costa (CET) - raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:19:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc3a2b34c667b8e2e0cde7766e9439e80fb72174

    Comments

    Revert "licenses.py: Skip another //tools/binary_size subdirectory."
    
    This reverts commit a6c69c8113a7113cc6b4a4f8de3291095d717e40.
    
    Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1080401 moved gvr-android-sdk into a directory we already skip, so this is no longer needed.
    
    Original change's description:
    > licenses.py: Skip another //tools/binary_size subdirectory.
    > 
    > Commit 6a15a6c4 ("SuperSize: Teach it about thin archives") added a
    > third_party directory to tools/binary_size with a .a file with some dummy
    > contents that we need to skip.
    > 
    > Change-Id: Ia1e129dc67617207ac920106e835d762887e74ac
    > Reviewed-on: https://chromium-review.googlesource.com/1078967
    > Reviewed-by: Scott Graham <scottmg@chromium.org>
    > Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
    > Cr-Commit-Position: refs/heads/master@{#564081}
    
    TBR=raphael.kubo.da.costa@intel.com,scottmg@chromium.org,ichikawa@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I8a85ee225f54a0499ee18e20311dfd5b9dc280fe
    Reviewed-on: https://chromium-review.googlesource.com/1133138
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#574509}

    Changed files

    • tools/licenses.py
  5. Add AudioLogFactory mojo interface.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:19:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee6cfd00b7b35f8bc4ced3eecc801fa2f55a85ae

    Comments

    Add AudioLogFactory mojo interface.
    
    This interface allows a mojo client to create audio logs on
    the browser process.
    This CL also removes content::MojoLogAudioAdapter, which is moved to the
    audio service as audio::LogAdapter in follow-up CL crrev.com/c/1128974
    
    Bug: 812557
    Change-Id: I70504a4878553f1a3c2d58a29c6ab960b6f15b39
    Reviewed-on: https://chromium-review.googlesource.com/1128966
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574508}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/media/audio_log_factory.cc
    • content/browser/media/audio_log_factory.h
    • content/browser/media/media_internals.cc
    • content/browser/media/media_internals.h
    • content/browser/media/mojo_audio_logging_adapter.cc
    • content/browser/media/mojo_audio_logging_adapter.h
    • media/mojo/interfaces/audio_logging.mojom
  6. Add service worker README.md.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

    Comments

    Add service worker README.md.
    
    Bug: 795989
    Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d
    Reviewed-on: https://chromium-review.googlesource.com/1134718
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574507}

    Changed files

    • content/browser/service_worker/README.md
    • content/common/service_worker/README.md
    • third_party/blink/common/service_worker/README.md
    • third_party/blink/public/common/service_worker/README.md
    • third_party/blink/public/mojom/service_worker/README.md
    • third_party/blink/public/platform/modules/service_worker/README.md
    • third_party/blink/public/web/modules/service_worker/README.md
    • third_party/blink/renderer/modules/service_worker/README.md
  7. Use PLM for data saver site-breakdown

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62

    Comments

    Use PLM for data saver site-breakdown
    
    This CL adds PLM observer for site-breakdown that records the data use
    by host. The new codepath is enabled and the old data use asriber observer
    based site-breakdown codepath is disabled, based on a feature.
    
    Bug: 836029
    Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219
    Reviewed-on: https://chromium-review.googlesource.com/1050868
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574506}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • chrome/test/BUILD.gn
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
  8. Add new methods to EntryList and tests

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76bc398de31290a2d97ee6b7ea804a55d1d5451d

    Comments

    Add new methods to EntryList and tests
    
    Change the logic to add entries to My Files to account for volume being
    mounted/unmounted. This fixes some broken tests when running with the
    flag enabled by default, so test to cover this is on
    crrev.com/c/1131025.
    
    Fix test getMetadata function name.
    
    Bug: 857335
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id056b0e0d5c77a07c2561f6566bfc99111864917
    Reviewed-on: https://chromium-review.googlesource.com/1133613
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574505}

    Changed files

    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
  9. [LayoutNG] Fix static position for inline containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f321a196a45bce7d32257d0b93b472dba89e205a

    Comments

    [LayoutNG] Fix static position for inline containing block
    
    Bug: 740993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Iacdfc2694b2522c06a2512000ed1ca7f043b7541
    Reviewed-on: https://chromium-review.googlesource.com/1134386
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574504}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  10. NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:13:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 670a4fd7d5c89c8904f638edda72083e41e5d016

    Comments

    NetS13nServiceWorker: Add more info to traces in SWNavigationLoader
    
    Bug: 806658
    Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17
    Reviewed-on: https://chromium-review.googlesource.com/1134711
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574503}

    Changed files

    • content/browser/service_worker/service_worker_navigation_loader.cc
  11. [Android PageInfo] Refactor PageInfoController to enable testing

    Changed by Anita Woodruff - awdfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:05:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfb08c4ccef342639df17f6a423643df1784b767

    Comments

    [Android PageInfo] Refactor PageInfoController to enable testing
    
    - Extracted PermissionParamsListBuilder from PageInfoController
    to handle all the permission-related logic when displaying
    permissions in page info. This new class requires fewer
    hard-to-unit-test dependencies so its logic can now be tested.
    
    Bug: 691898
    Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4
    Reviewed-on: https://chromium-review.googlesource.com/1103564
    Commit-Queue: Anita Woodruff <awdf@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574502}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
  12. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc