Home | Search | chromium - Builders
Login

Builder Win10 FYI Release (Intel HD 630) Build 1281 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisioncdc1f3d342363df455d02fde8bc04d44f5331e5e
Got Revisioncdc1f3d342363df455d02fde8bc04d44f5331e5e

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Erik Luo (luoeohnoyoudont@chromium.org)
  2. Nate Fischer (ntfschrohnoyoudont@chromium.org)
  3. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  4. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  5. Lei Zhang (thestigohnoyoudont@chromium.org)
  6. Scott Chen (scottchenohnoyoudont@chromium.org)
  7. Pedro Amaral (amaralpohnoyoudont@chromium.org)
  8. Christian Fremerey (chfremerohnoyoudont@chromium.org)
  9. Chris Palmer (palmerohnoyoudont@chromium.org)
  10. Tiger Oakes (tigeroohnoyoudont@google.com)
  11. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  12. Weidong Guo (weidonggohnoyoudont@chromium.org)
  13. Min Qin (qinminohnoyoudont@chromium.org)
  14. Patrick Noland (pnolandohnoyoudont@google.com)
  15. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  16. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  17. Manu Cornet (manucornetohnoyoudont@chromium.org)
  18. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  19. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  20. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  21. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  22. wutao (wutaoohnoyoudont@chromium.org)
  23. Helen Li (xunjieliohnoyoudont@chromium.org)
  24. Juan Antonio Navarro Perez (perezjuohnoyoudont@chromium.org)
  25. John Chen (johnchenohnoyoudont@chromium.org)
  26. Becca Hughes (beccahughesohnoyoudont@chromium.org)
  27. sebsg (sebsgohnoyoudont@chromium.org)
  28. Krishna Govind (govindohnoyoudont@chromium.org)
  29. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  30. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  31. Paul Miller (paulmillerohnoyoudont@google.com)
  32. chcunningham (chcunninghamohnoyoudont@chromium.org)
  33. David Black (dmblackohnoyoudont@google.com)
  34. David Black (dmblackohnoyoudont@google.com)
  35. Jared Saul (jsaulohnoyoudont@google.com)
  36. khmel@google.com (khmelohnoyoudont@google.com)
  37. erikchen (erikchenohnoyoudont@chromium.org)
  38. Mark Pilgrim (pilgrimohnoyoudont@chromium.org)
  39. Takumi Fujimoto (takumifohnoyoudont@chromium.org)
  40. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  41. Ella Ge (eirageohnoyoudont@chromium.org)
  42. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  43. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  44. Carlos IL (carlosilohnoyoudont@chromium.org)
  45. Mark Pilgrim (pilgrimohnoyoudont@chromium.org)
  46. David Black (dmblackohnoyoudont@google.com)
  47. David Black (dmblackohnoyoudont@google.com)
  48. Peter K. Lee (pklohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 19:28:57 UTC
Start Thursday, 12-Jul-18 19:29:01 UTC
End Thursday, 12-Jul-18 21:30:36 UTC
Pending 3 secs
Execution 2 hrs 1 mins

All Changes:

  1. DevTools: clicking clear on input should focus

    Changed by Erik Luo - luoeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc1f3d342363df455d02fde8bc04d44f5331e5e

    Comments

    DevTools: clicking clear on input should focus
    
    The act of clicking the 'x' clear button blurs focus. This CL ensures
    the input focuses afterwards.
    
    Bug: 831059
    Change-Id: I848296c0981873cd878f5aaaead9654809811349
    Reviewed-on: https://chromium-review.googlesource.com/1134577
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574664}

    Changed files

    • third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
  2. AW: trace events for WindowAndroid verification issues

    Changed by Nate Fischer - ntfschrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f50fc4d425345286e65488344fd85981bef36c94

    Comments

    AW: trace events for WindowAndroid verification issues
    
    No change to logic.
    
    This adds trace events inside AwContents to track WindowAndroid-related
    class verification errors. Specifically, this should illustrate the
    following verification errors:
    
     * WindowAndroid verification errors should cause activityFromContext to
       take longer than necessary.
     * ActivityWindowAndroid fails verification (because its superclass
       WindowAndroid fails verification), causing its constructor to take
       longer than necessary.
    
    R=torne@chromium.org
    
    Bug: 855796
    Test: tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google
    Change-Id: I6633496fd672300216dfa6425910d19a7ae9e3da
    Reviewed-on: https://chromium-review.googlesource.com/1132479
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574663}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
  3. Fix VR watchlist

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7bec5b1769172d3b2722182969d5c1ed618bc42

    Comments

    Fix VR watchlist
    
    Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1134091/9/WATCHLISTS.
    
    Change-Id: Id84c46bb2f52d397975e1c3797a182b2becf9c07
    Reviewed-on: https://chromium-review.googlesource.com/1135115
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574662}

    Changed files

    • WATCHLISTS
  4. Restore some checks in FrameLoader::CommitNavigation

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd7f8b8a57712e9a2b2deb2a10282dea99bdb5eb

    Comments

    Restore some checks in FrameLoader::CommitNavigation
    
    These were dropped when separating StartNavigation from
    CommitNavigation. It's reasonable that we cannot be in StopAllLoaders
    or similar unless there is a nested message loop.
    
    See test for an example how print() triggers this stack:
    ...<message loop running here, dispatched CommitNavigation>...
    IPC::SyncChannel::Send()
    content::RenderThreadImpl::Send()
    printing::PrintRenderFrameHelper::RequestPrintPreview()
    content::RenderFrameImpl::ScriptedPrint()
    blink::ChromeClientImpl::PrintDelegate()
    blink::ChromeClient::Print()
    blink::LocalDOMWindow::FinishedLoading()
    blink::FrameLoader::DidFinishNavigation()
    blink::Document::CheckCompleted()
    blink::FrameLoader::DetachProvisionalDocumentLoader()
    blink::DocumentLoader::StopLoading()
    blink::DocumentLoader::DetachFromFrame()
    blink::WebDocumentLoaderImpl::DetachFromFrame()
    blink::FrameLoader::StopAllLoaders()
    blink::LocalFrame::Detach()
    blink::HTMLPlugInElement::DisconnectContentFrame()
    blink::ChildFrameDisconnector::DisconnectCollectedFrameOwners()
    blink::ContainerNode::WillRemoveChild()
    blink::ContainerNode::RemoveChild()
    ...<JavaScript>...
    
    Bug: 860208, 853487, 862088
    Change-Id: Ieb3f0330828f0a031a97d08cdc1ba7de8a3f0edc
    Reviewed-on: https://chromium-review.googlesource.com/1130223
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574661}

    Changed files

    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing-expected.txt
    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing.html
    • third_party/blink/renderer/core/loader/frame_loader.cc
  5. Update PDFExtensionTest test expectation.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be8ff3e12884ec3188e5fb909b31a62b9412d808

    Comments

    Update PDFExtensionTest test expectation.
    
    After https://pdfium-review.googlesource.com/35432 got rolled into
    Chromium in r570889, a previously failing test case now started passing.
    
    BUG=860757
    
    Change-Id: I998a0ea8a91770bb27d92491a12ac0816f535054
    Reviewed-on: https://chromium-review.googlesource.com/1132633
    Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574660}

    Changed files

    • chrome/browser/pdf/pdf_extension_test.cc
  6. Settings: fix cups printer search field logic.

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:05:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc

    Comments

    Settings: fix cups printer search field logic.
    
    An earlier CL (1088163) broke the logic for drop-down search fields in
    CUPS add/edit printer dialog, by setting the searchTerm_ property to the
    wrong value. This CL fixes that issue.
    
    The aforementioned CL also accidentally notifies the parent of the input
    value too often, which is also fixed in this CL.
    
    Tests are added to prevent both regressions in the future.
    
    Bug: 860475
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I3949c01edacc53b5aa0f8b6b25ef57b3acb00577
    Reviewed-on: https://chromium-review.googlesource.com/1132238
    Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574659}

    Changed files

    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
    • chrome/test/data/webui/settings/cups_printer_page_tests.js
  7. Making a menu button component

    Changed by Pedro Amaral - amaralpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:03:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c59b348ffef08cfdca20701f4f54236f9e6e295

    Comments

    Making a menu button component
    
    Pulling the menu button out of the bottom toolbar component into its
    own class.
    
    Bug: 862863
    
    
    Change-Id: Icb2230259d7f1d3ac2f47f3b8ee33e659579ca96
    Reviewed-on: https://chromium-review.googlesource.com/1132423
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574658}

    Changed files

    • chrome/android/java/res/layout/menu_button.xml
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
    • chrome/android/java_sources.gni
  8. [Video Capture] Abstract out V4L2 API calls to an interface

    Changed by Christian Fremerey - chfremerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:59:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbf002c655a394a5235cef285a40059f8d32d678

    Comments

    [Video Capture] Abstract out V4L2 API calls to an interface
    
    This CL abstracts V4L2 API calls made from Chromium's video capture
    implementation on Linux out to an interface. This is to enable testability of
    the code that makes such calls without requiring heavy-weight solutions such
    as attaching actual hardware or kernel-level emulators.
    
    This CL is a pure refactoring and has no intended function change.
    
    This CL is part of a series, see Design Doc at
    https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing
    
    Test: capture_unittests with physical camera attached
    Bug: 768887
    Change-Id: I9208f4a61731c8dc5827c1f5f5ef31d078520270
    Reviewed-on: https://chromium-review.googlesource.com/1120856
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: Christian Fremerey <chfremer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574657}

    Changed files

    • media/capture/BUILD.gn
    • media/capture/video/linux/v4l2_capture_delegate.cc
    • media/capture/video/linux/v4l2_capture_delegate.h
    • media/capture/video/linux/v4l2_capture_delegate_unittest.cc
    • media/capture/video/linux/v4l2_capture_device.h
    • media/capture/video/linux/v4l2_capture_device_impl.cc
    • media/capture/video/linux/v4l2_capture_device_impl.h
    • media/capture/video/linux/video_capture_device_chromeos.cc
    • media/capture/video/linux/video_capture_device_chromeos.h
    • media/capture/video/linux/video_capture_device_factory_linux.cc
    • media/capture/video/linux/video_capture_device_factory_linux.h
    • media/capture/video/linux/video_capture_device_linux.cc
    • media/capture/video/linux/video_capture_device_linux.h
  9. Change DECHECKs to CHECKs in `base::RingBuffer`.

    Changed by Chris Palmer - palmerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:58:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 940e9a3140b1e0b636f185ff65f20226e997d897

    Comments

    Change DECHECKs to CHECKs in `base::RingBuffer`.
    
    Better safe than sorry!
    
    In the process, do some micro-optimization to make the CHECKs as cheap as
    possible.
    
    Bug: 817982
    Change-Id: I2c45d7e773199a12ce4ae34b4a750ac2b66cb7c2
    Reviewed-on: https://chromium-review.googlesource.com/1134486
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574656}

    Changed files

    • base/containers/ring_buffer.h
  10. Groups small symbols at the file level

    Changed by Tiger Oakes - tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:57:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03

    Comments

    Groups small symbols at the file level
    
    Previously, symbols below min_symbol_size were all placed in an
    "(Other)" file entry at the root of the tree. Now, they are placed
    inside their original file entry but grouped together based on type.
    This ensures byte counts are always accurate, even past the root node.
    This is also the only blocker before we can remove the old UI.
    
    Additionally made some changes to improve first-load performance by
    starting tree building as soon as possible.
    
    Bug: 860303
    Change-Id: I02daee8994d9b7b236837b78585ac8a9c3297125
    Reviewed-on: https://chromium-review.googlesource.com/1135193
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574655}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/start-worker.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  11. Convert two crash layout tests to use testharness

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:57:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0279bf752fc5d6e5f0df324190ab72d7bc831010

    Comments

    Convert two crash layout tests to use testharness
    
    The following two layout tests are crash tests and don't need text dump:
    - fast/text/editing-text-crash.html
    - fast/text/text-iterator-crash.html
    
    This patch converts them with testharness for better code health.
    
    Change-Id: I528a681bb6a17e2fb9f6122d6ec42f9722a575df
    Reviewed-on: https://chromium-review.googlesource.com/1134594
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574654}

    Changed files

    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash.html
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash.html
  12. Introduce GetAppShortcutGlobalQueryItems mojo method

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:56:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70dc791c0f421c6ac340019a9721df97af0da8d

    Comments

    Introduce GetAppShortcutGlobalQueryItems mojo method
    
    The original solution passing all available app shortcuts metadata to
    Chrome has large latency because getting icons is expensive. This CL
    proposes a new API that passes query and maxResults to Android, and
    searching & results num throttling is done in Android as well.
    Android side change is in ag/4432308.
    
    Bug: 842947
    Test: manual test, latency is controlled in tens milliseconds
    
    Change-Id: I48c168ffd56826c10a4b6d5befb995a087f4a0b2
    Reviewed-on: https://chromium-review.googlesource.com/1117893
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Reviewed-by: Qiang Xu <warx@google.com>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574653}

    Changed files

    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.cc
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.h
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider_unittest.cc
    • chrome/browser/ui/app_list/search/search_controller_factory.cc
    • components/arc/common/app.mojom
    • components/arc/test/fake_app_instance.cc
    • components/arc/test/fake_app_instance.h
  13. Always prompt user if opening a download thru extensions with debugger permission

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:55:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a4a89a53791a508896b388b0d818644834c0d6d

    Comments

    Always prompt user if opening a download thru extensions with debugger permission
    
    The user gesture can be faked, so we shouldn't trust it
    
    BUG=854455
    
    Change-Id: Ib42911a77d3f519554a5b9a4c1464ec50e79f268
    Reviewed-on: https://chromium-review.googlesource.com/1135525
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574652}

    Changed files

    • chrome/browser/extensions/api/downloads/downloads_api.cc
  14. Check against null frame_ in GetCanonicalUrlForSharing

    Changed by Patrick Noland - pnolandohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:50:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd341220c263993037559e62938d54d5cf091a2c

    Comments

    Check against null frame_ in GetCanonicalUrlForSharing
    
    Bug: 852350
    Change-Id: Ib6c4cc79572d3dad22f663ec61a20bc54f5d7a8f
    Reviewed-on: https://chromium-review.googlesource.com/1117847
    Commit-Queue: Charlie Reis <creis@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574651}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
  15. FrameLoader: move CancelParsing and CheckCompleted earlier

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:50:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae5ca38f28d3e136c7def1fe7444afed1db7ea9a

    Comments

    FrameLoader: move CancelParsing and CheckCompleted earlier
    
    This way we do it before creating new provisional loader, which
    will help in the future when there would be no provisional loader.
    
    Added Document::Abort method which encapsulates CancelParsing
    and CheckCompleted and also does not issue undesired DidFinishNavigation.
    
    Bug: 831155
    Change-Id: Ica5d968508d7aed7bb07125702ceeaeb6f389497
    Reviewed-on: https://chromium-review.googlesource.com/1119262
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574650}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-detach-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-window-stop.html
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/loader/frame_loader.cc
  16. [unified-consent] Add unified-consent logic to sync confirmation dialog

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce72c61e3d03607baa3881262eaf5f9d6a06df67

    Comments

    [unified-consent] Add unified-consent logic to sync confirmation dialog
    
    When unified consent is enabled and the user opts into the new unified
    consent sync dialog, unified-consent is given and all services enabled.
    
    Additional changes:
     - Introduce FakeUnifiedConsentServiceClient
     - Add a builder function that creates a UnifiedConsentService for
     testing, using FakeUnifiedConsentServiceClient
    
    Bug: 862202
    Change-Id: I7c70bc45ebbc561916fd618f0b1850525b2cffe0
    Reviewed-on: https://chromium-review.googlesource.com/1131513
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574649}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.h
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
    • chrome/browser/unified_consent/unified_consent_service_factory.cc
    • chrome/browser/unified_consent/unified_consent_test_util.cc
    • chrome/browser/unified_consent/unified_consent_test_util.h
    • components/unified_consent/unified_consent_service.cc
    • components/unified_consent/unified_consent_service.h
    • components/unified_consent/unified_consent_service_unittest.cc
  17. Shelf new UI: center items on the total shelf size

    Changed by Manu Cornet - manucornetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:46:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e2ccd76952b57016daccdd19fde7a54d1719a7b

    Comments

    Shelf new UI: center items on the total shelf size
    
    Bug: 805612
    Change-Id: I9c6e0c0aab7f39681bec850ee18d890a9410990c
    Reviewed-on: https://chromium-review.googlesource.com/1135298
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574648}

    Changed files

    • ash/shelf/shelf_view.cc
  18. [Unity][Android] Update personalized sign-in promo descriptions

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:43:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1806fde687718fd19118e7a6f09e0d5610239cb5

    Comments

    [Unity][Android] Update personalized sign-in promo descriptions
    
    This CL adds a second set of description strings for personalized
    sign-in promos. This set of strings is shown if UnifiedConsent feature
    is enabled.
    
    Bug: 814728
    Change-Id: I1d90a2ec786397326b6d80011c0de6d31468431b
    Reviewed-on: https://chromium-review.googlesource.com/1131500
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574647}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoController.java
    • chrome/android/java/strings/android_chrome_strings.grd
    • chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
  19. [Background Fetch] Fix dispatched event name on failure.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7523f88574031a353b4ce24fa9cb87dfbcc2b11

    Comments

    [Background Fetch] Fix dispatched event name on failure.
    
    TBR=falken@chromium.org
    
    Change-Id: Iba46fbe0eee3a886a847fc259d45e51ecfa81dd1
    Reviewed-on: https://chromium-review.googlesource.com/1135451
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574646}

    Changed files

    • third_party/blink/renderer/modules/service_worker/service_worker_global_scope_proxy.cc
  20. Fix tabstrip edges not redrawing when entering/leaving single tab mode

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:42:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 901634eeb056e61914c0b70b43adff655d156c2b

    Comments

    Fix tabstrip edges not redrawing when entering/leaving single tab mode
    
    BUG=860859
    R=pkasting
    
    Change-Id: I9766d6c175fa6bdd8906c58448bf94ae85a17141
    Reviewed-on: https://chromium-review.googlesource.com/1135512
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574645}

    Changed files

    • chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
  21. [Fuchsia] Update webrunner to quit when sys::Runner is closed.

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:33:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c40e749cd5d48a9ee9fd02f822c18857d52b813b

    Comments

    [Fuchsia] Update webrunner to quit when sys::Runner is closed.
    
    appmgr process normally creates a single sys::Runner connection for
    each runner process and then closes it when it no longer needs the
    runner. Updagted webrunner implementation to quit after sys::Runned
    is destroyed.
    
    Bug: 856416
    Change-Id: I071b37093917a932a837eebfdf1f1a6e23e837de
    Reviewed-on: https://chromium-review.googlesource.com/1134415
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574644}

    Changed files

    • base/fuchsia/scoped_service_binding.h
    • base/fuchsia/service_directory_unittest.cc
    • webrunner/app/main.cc
  22. Assistant: Fix the notification type

    Changed by wutao - wutaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:33:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94e0357b298de459bbfb9c75942fc8193db16203

    Comments

    Assistant: Fix the notification type
    
    Changed the assistant notification type to SYSTEM_COMPONENT.
    
    Bug: b/79493568
    Test: manual.
    Change-Id: I12bb925f3e430fbd74c518be89aba9bd7d31b871
    Reviewed-on: https://chromium-review.googlesource.com/1135574
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574643}

    Changed files

    • ash/assistant/assistant_notification_controller.cc
  23. Reland "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by Helen Li - xunjieliohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:30:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d24ee7bc5a14573a8a761c45222f68efb4bef3b0

    Comments

    Reland "Make NetworkConnectionTracker survive network service crashes and restarts"
    
    This reverts commit 197e9188dc5be69cb34e1ebd67f86a1146439367.
    
    Reason for revert: There is a racy test expectation that causes the test to timeout.
    This CL fixes the test.
    
    Bug: 862883, 821009
    Change-Id: I1cb4d8db6ea3f5c683f95bcc3187f6c6b4d6fdbd
    Reviewed-on: https://chromium-review.googlesource.com/1135290
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Commit-Queue: Helen Li <xunjieli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574642}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  24. [tools/perf] git-ignore artifacts and html result files

    Changed by Juan Antonio Navarro Perez - perezjuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:26:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab977857ed343bd565c6eb43846b77f7928b5bcd

    Comments

    [tools/perf] git-ignore artifacts and html result files
    
    Also move relevant ignores from the root of the project into tools/perf.
    
    Change-Id: I30e025dcdfea768aa8dbd6f3a8f6dc05eafdb6c8
    Reviewed-on: https://chromium-review.googlesource.com/1135129
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574641}

    Changed files

    • .gitignore
    • tools/perf/.gitignore
  25. [ChromeDriver] Return debugging port in capabilities

    Changed by John Chen - johnchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:24:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 403b2e9ab1b7ebe8d476a38052fc8a242b9f7d1a

    Comments

    [ChromeDriver] Return debugging port in capabilities
    
    Add a new entry chrome.debuggerAddress in the capabilities returned from
    InitSession command. It contains the hostname and port to reach Chrome's
    remote debugging port.
    
    Also removed an unused constructor in struct BrowserInfo.
    
    Bug: chromedriver:2379
    Change-Id: Ic36c08eb7fe42b27fa1ba796ee10c511d76ef804
    Reviewed-on: https://chromium-review.googlesource.com/1133421
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574640}

    Changed files

    • chrome/test/chromedriver/chrome/browser_info.cc
    • chrome/test/chromedriver/chrome/browser_info.h
    • chrome/test/chromedriver/chrome/devtools_http_client.cc
    • chrome/test/chromedriver/session_commands.cc
  26. [Media Controls] Localize CC to S by locale

    Changed by Becca Hughes - beccahughesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:21:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0109bbaa2074acaefbe6fcc72d66499f19137813

    Comments

    [Media Controls] Localize CC to S by locale
    
    Use a "S" icon for the captions button by default
    except for "en", "en-US", "es-419" and "pt-BR" which
    should continue to use the CC icon.
    
    I added some clarification about which locales in the
    bug since there was some regions that were not locales
    supported by Chrome.
    
    BUG=353120
    
    Change-Id: I41e05058a6b1589eddce0605d39272b4dd965248
    Reviewed-on: https://chromium-review.googlesource.com/1134480
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574639}

    Changed files

    • third_party/WebKit/LayoutTests/media/controls/closed-captions-locale.html
    • third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
    • third_party/blink/renderer/modules/media_controls/resources/ic_subtitles.svg
    • third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
  27. [AF] Add fieldtrial_testing_config for AutofillDynamicForms.

    Changed by sebsg - sebsgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:19:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ad13746662b2eb310c8732a69b6ca1357f9fad6

    Comments

    [AF] Add fieldtrial_testing_config for AutofillDynamicForms.
    
    Change-Id: I99d7f3d5a95c34d29c98a00473f8dab11f3b46f6
    Reviewed-on: https://chromium-review.googlesource.com/1132129
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574638}

    Changed files

    • chrome/browser/autofill/autofill_interactive_uitest.cc
    • testing/variations/fieldtrial_testing_config.json
  28. Updating XTBs based on .GRDs from branch master

    Changed by Krishna Govind - govindohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:16:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7edd65b959ed3edbb808bd0bd2c914e5a92cfff

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=cmasso@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I20b9e67c2fb01e36dfb995b00252ca0158ca14ee
    Reviewed-on: https://chromium-review.googlesource.com/1135575
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574637}

    Changed files

    • ash/components/strings/ash_components_strings_de.xtb
    • ash/components/strings/ash_components_strings_es-419.xtb
    • ash/components/strings/ash_components_strings_id.xtb
    • ash/components/strings/ash_components_strings_it.xtb
    • ash/components/strings/ash_components_strings_ko.xtb
    • ash/components/strings/ash_components_strings_ro.xtb
    • ash/components/strings/ash_components_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ro.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_vi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb
    • chrome/app/resources/chromium_strings_am.xtb
    • chrome/app/resources/chromium_strings_bg.xtb
    • chrome/app/resources/chromium_strings_ca.xtb
    • chrome/app/resources/chromium_strings_de.xtb
    • chrome/app/resources/chromium_strings_el.xtb
    • chrome/app/resources/chromium_strings_en-GB.xtb
    • chrome/app/resources/chromium_strings_es.xtb
    • chrome/app/resources/chromium_strings_et.xtb
    • chrome/app/resources/chromium_strings_fil.xtb
    • chrome/app/resources/chromium_strings_fr.xtb
    • chrome/app/resources/chromium_strings_hi.xtb
    • chrome/app/resources/chromium_strings_hr.xtb
    • chrome/app/resources/chromium_strings_hu.xtb
    • chrome/app/resources/chromium_strings_id.xtb
    • chrome/app/resources/chromium_strings_it.xtb
    • chrome/app/resources/chromium_strings_iw.xtb
    • chrome/app/resources/chromium_strings_kn.xtb
    • chrome/app/resources/chromium_strings_lt.xtb
    • chrome/app/resources/chromium_strings_lv.xtb
    • chrome/app/resources/chromium_strings_ml.xtb
    • chrome/app/resources/chromium_strings_ms.xtb
    • chrome/app/resources/chromium_strings_nl.xtb
    • chrome/app/resources/chromium_strings_pl.xtb
    • chrome/app/resources/chromium_strings_ro.xtb
    • chrome/app/resources/chromium_strings_ru.xtb
    • chrome/app/resources/chromium_strings_sk.xtb
    • chrome/app/resources/chromium_strings_sr.xtb
    • chrome/app/resources/chromium_strings_th.xtb
    • chrome/app/resources/chromium_strings_uk.xtb
    • chrome/app/resources/chromium_strings_vi.xtb
    • chrome/app/resources/chromium_strings_zh-TW.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_am.xtb
    • chrome/app/resources/google_chrome_strings_bg.xtb
    • chrome/app/resources/google_chrome_strings_ca.xtb
    • chrome/app/resources/google_chrome_strings_de.xtb
    • chrome/app/resources/google_chrome_strings_el.xtb
    • chrome/app/resources/google_chrome_strings_en-GB.xtb
    • chrome/app/resources/google_chrome_strings_es.xtb
    • chrome/app/resources/google_chrome_strings_et.xtb
    • chrome/app/resources/google_chrome_strings_fil.xtb
    • chrome/app/resources/google_chrome_strings_fr.xtb
    • chrome/app/resources/google_chrome_strings_hi.xtb
    • chrome/app/resources/google_chrome_strings_hr.xtb
    • chrome/app/resources/google_chrome_strings_hu.xtb
    • chrome/app/resources/google_chrome_strings_id.xtb
    • chrome/app/resources/google_chrome_strings_it.xtb
    • chrome/app/resources/google_chrome_strings_iw.xtb
    • chrome/app/resources/google_chrome_strings_kn.xtb
    • chrome/app/resources/google_chrome_strings_lt.xtb
    • chrome/app/resources/google_chrome_strings_lv.xtb
    • chrome/app/resources/google_chrome_strings_ml.xtb
    • chrome/app/resources/google_chrome_strings_ms.xtb
    • chrome/app/resources/google_chrome_strings_nl.xtb
    • chrome/app/resources/google_chrome_strings_pl.xtb
    • chrome/app/resources/google_chrome_strings_ro.xtb
    • chrome/app/resources/google_chrome_strings_ru.xtb
    • chrome/app/resources/google_chrome_strings_sk.xtb
    • chrome/app/resources/google_chrome_strings_sr.xtb
    • chrome/app/resources/google_chrome_strings_th.xtb
    • chrome/app/resources/google_chrome_strings_uk.xtb
    • chrome/app/resources/google_chrome_strings_vi.xtb
    • chrome/app/resources/google_chrome_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bg.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_da.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_es.xtb
    • components/policy/resources/policy_templates_et.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fil.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_gu.xtb
    • components/policy/resources/policy_templates_hi.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_hu.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_iw.xtb
    • components/policy/resources/policy_templates_ja.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ko.xtb
    • components/policy/resources/policy_templates_lt.xtb
    • components/policy/resources/policy_templates_lv.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_mr.xtb
    • components/policy/resources/policy_templates_ms.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_no.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ro.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sl.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/policy/resources/policy_templates_zh-CN.xtb
    • components/policy/resources/policy_templates_zh-TW.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_am.xtb
    • content/app/strings/translations/content_strings_ar.xtb
    • content/app/strings/translations/content_strings_bg.xtb
    • content/app/strings/translations/content_strings_bn.xtb
    • content/app/strings/translations/content_strings_ca.xtb
    • content/app/strings/translations/content_strings_cs.xtb
    • content/app/strings/translations/content_strings_da.xtb
    • content/app/strings/translations/content_strings_de.xtb
    • content/app/strings/translations/content_strings_el.xtb
    • content/app/strings/translations/content_strings_en-GB.xtb
    • content/app/strings/translations/content_strings_es-419.xtb
    • content/app/strings/translations/content_strings_es.xtb
    • content/app/strings/translations/content_strings_et.xtb
    • content/app/strings/translations/content_strings_fa.xtb
    • content/app/strings/translations/content_strings_fi.xtb
    • content/app/strings/translations/content_strings_fil.xtb
    • content/app/strings/translations/content_strings_fr.xtb
    • content/app/strings/translations/content_strings_gu.xtb
    • content/app/strings/translations/content_strings_hi.xtb
    • content/app/strings/translations/content_strings_hr.xtb
    • content/app/strings/translations/content_strings_hu.xtb
    • content/app/strings/translations/content_strings_id.xtb
    • content/app/strings/translations/content_strings_it.xtb
    • content/app/strings/translations/content_strings_iw.xtb
    • content/app/strings/translations/content_strings_ja.xtb
    • content/app/strings/translations/content_strings_kn.xtb
    • content/app/strings/translations/content_strings_ko.xtb
    • content/app/strings/translations/content_strings_lt.xtb
    • content/app/strings/translations/content_strings_lv.xtb
    • content/app/strings/translations/content_strings_ml.xtb
    • content/app/strings/translations/content_strings_mr.xtb
    • content/app/strings/translations/content_strings_ms.xtb
    • content/app/strings/translations/content_strings_nl.xtb
    • content/app/strings/translations/content_strings_no.xtb
    • content/app/strings/translations/content_strings_pl.xtb
    • content/app/strings/translations/content_strings_pt-BR.xtb
    • content/app/strings/translations/content_strings_pt-PT.xtb
    • content/app/strings/translations/content_strings_ro.xtb
    • content/app/strings/translations/content_strings_ru.xtb
    • content/app/strings/translations/content_strings_sk.xtb
    • content/app/strings/translations/content_strings_sl.xtb
    • content/app/strings/translations/content_strings_sr.xtb
    • content/app/strings/translations/content_strings_sv.xtb
    • content/app/strings/translations/content_strings_sw.xtb
    • content/app/strings/translations/content_strings_ta.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • content/app/strings/translations/content_strings_th.xtb
    • content/app/strings/translations/content_strings_tr.xtb
    • content/app/strings/translations/content_strings_uk.xtb
    • content/app/strings/translations/content_strings_vi.xtb
    • content/app/strings/translations/content_strings_zh-CN.xtb
    • content/app/strings/translations/content_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_bg.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_es.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_et.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_iw.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ms.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ro.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_uk.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_bg.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_es.xtb
    • ios/chrome/app/strings/resources/ios_strings_et.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hi.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_iw.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_ms.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_ro.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • ios/chrome/app/strings/resources/ios_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-TW.xtb
    • ui/strings/translations/ui_strings_en-GB.xtb
  29. [ios] Use ActionSheetCoordinator in ClearBrowsingData

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:16:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ba261495b02e475848d7b253a0d1c1c8606c2ff1

    Comments

    [ios] Use ActionSheetCoordinator in ClearBrowsingData
    
    - Uses ActionSheetCoordinator instead of UIAlertController to help handle presenting the popover in non-compact devices.
    - Adds title to avoid seemingly odd double "clear browsing data" button in non-compact devices.
    
    Screenshots:  https://drive.google.com/open?id=1OjP2BL_TNf5W1L1lluI-8Q52x-nnzOAj
    https://drive.google.com/open?id=1_QnxFfKE0r6VqwjNoPFPYnLPfB42nL6W
    
    Change-Id: Iedac56cc0217567206630baed8feb32ea50ae2de
    Reviewed-on: https://chromium-review.googlesource.com/1120850
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574636}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/metrics/ukm_egtest.mm
    • ios/chrome/browser/ui/history/history_ui_egtest.mm
    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager.h
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_table_view_controller.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_ui_constants.h
    • ios/chrome/browser/ui/settings/clear_browsing_data_ui_constants.mm
    • ios/chrome/browser/ui/settings/settings_egtest.mm
    • ios/chrome/test/earl_grey/chrome_matchers.h
    • ios/chrome/test/earl_grey/chrome_matchers.mm
  30. Import wpt@e462f618e3765749ca8b0101987759d37d746d32

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:12:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347fe160e3d49452f2c4c56406230237937b570d

    Comments

    Import wpt@e462f618e3765749ca8b0101987759d37d746d32
    
    Using wpt-import in Chromium 3fb53cf0d187b9537160ad967975f17641d59c1f.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21189
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    meade@chromium.org:
      external/wpt/web-animations
    rouslan@chromium.org, mathp@chromium.org:
      external/wpt/payment-request
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I87288052fdbcab0a3a1b79325c964085695ab2a5
    Reviewed-on: https://chromium-review.googlesource.com/1135205
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574635}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-label-element/label-attributes.sub-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-label-element/label-attributes.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/closing-the-input-stream/document.close-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/003.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/005.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/006.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/007.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/008-1.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/008.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/009.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/010-1.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/010.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/011-1.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/011.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/011.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/012.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/012.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/013.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/013.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/014.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/015.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/016.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/017.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/018.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/019.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/020.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/021.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/022.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/023.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/024.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/025.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/026.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/027.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/028.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/029.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/030.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/031.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/032.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/033.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/034.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/035.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/036.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/037.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/038.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/039.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/040.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/041.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/042.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/043.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/044.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/045.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/046.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/047.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/048.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/049.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/050.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/051.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/contentType.window-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/contentType.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/document.write-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/document.write-02.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/empty.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_003.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_005.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_009.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/iframe_010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/nested-document-write-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/nested-document-write-2.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/nested-document-write-external.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/original-id.json
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_003.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_009.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_011.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_012.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/script_013.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/write-active-document-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-write/write-active-document.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/document.writeln-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/document.writeln-02.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/document.writeln-03.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/document-writeln/original-id.json
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/001-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/001.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/002.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/004-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/004.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/005-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/005.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/006.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/007.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/008-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/008.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/009.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/009.https.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010-2.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/010.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/011-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/011.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/012-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/012.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/013-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/013.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/014-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/014.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/015-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/015-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/015.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/016-1.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/016-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/016.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/aborted-parser.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-01.xhtml
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-02.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-03-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-03-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/document.open-03.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/encoding.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/event-listeners.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/mutation-events.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/aborted-parser-async-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/aborted-parser-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/resources/encoding-frame.html
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/type-argument-plaintext-subframe.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/type-argument-plaintext.window.js
    • third_party/WebKit/LayoutTests/external/wpt/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/type-argument.window.js
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/payment-request.idl
    • third_party/WebKit/LayoutTests/external/wpt/lint.whitelist
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/idlharness.https.window.js
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/timelines/update-and-send-events.html
  31. WebView: Support loading .svgz assets/resources

    Changed by Paul Miller - paulmillerohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:04:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a5feed58d4c2e2e8870d1dbd9e05e61039b9d27

    Comments

    WebView: Support loading .svgz assets/resources
    
    Loading .svgz files from the web works because of a special case in
    URLRequestFileJob::SetUpSourceStream(). Add a special case in
    AndroidProtocolHandler so that e.g.
    WebView.loadUrl("file:///android_asset/foo.svgz") works as well.
    
    BUG=854282
    
    Change-Id: I995f8b602bd6e3b05818ede763f3774465850d82
    Reviewed-on: https://chromium-review.googlesource.com/1134429
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Paul Miller <paulmiller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574634}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AndroidProtocolHandler.java
    • android_webview/javatests/src/org/chromium/android_webview/test/AndroidProtocolHandlerTest.java
    • android_webview/test/BUILD.gn
    • android_webview/test/shell/assets/star.svg
    • android_webview/test/shell/assets/star.svgz
  32. RELAND: InMemory MediaCapabilities DB for Guest/Incognito

    Changed by chcunningham - chcunninghamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:04:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9205ea89ebb4bd23b2f0099726f641a27ed269bb

    Comments

    RELAND: InMemory MediaCapabilities DB for Guest/Incognito
    
    Original CL was reverted:
    https://chromium-review.googlesource.com/c/chromium/src/+/1092156
    
    Reland now possible thanks to:
    https://chromium-review.googlesource.com/c/chromium/src/+/1123396
    
    
    Prior to this change, Guest mode has an empty read-only DB and Incongito
    has a read-only DB. This CL allows both profiles to write to an "in
    memory" database that disapears when the profile is destroyed.
    
    This improves the experience for the user and avoids the possibility
    of using MediaCapabilites to detect incognito/guest profiles.
    
    Bug: 796280, 855631, 855215
    Change-Id: Ideb9dd2eabab2e594a24dd9b514557e473c3afc0
    Reviewed-on: https://chromium-review.googlesource.com/1123687
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574633}

    Changed files

    • chrome/browser/DEPS
    • chrome/browser/profiles/off_the_record_profile_impl.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • media/capabilities/BUILD.gn
    • media/capabilities/in_memory_video_decode_stats_db_impl.cc
    • media/capabilities/in_memory_video_decode_stats_db_impl.h
    • media/capabilities/in_memory_video_decode_stats_db_unittest.cc
    • media/capabilities/video_decode_stats_db.cc
    • media/capabilities/video_decode_stats_db.h
    • media/capabilities/video_decode_stats_db_impl.cc
    • media/capabilities/video_decode_stats_db_impl.h
    • media/capabilities/video_decode_stats_db_provider.cc
    • media/capabilities/video_decode_stats_db_provider.h
    • media/capabilities/video_decode_stats_db_unittest.cc
    • media/mojo/services/video_decode_perf_history.cc
    • media/mojo/services/video_decode_perf_history.h
    • media/mojo/services/video_decode_perf_history_unittest.cc
  33. Adds support for Assistant explore deep link.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:00:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9

    Comments

    Adds support for Assistant explore deep link.
    
    Deep link opens in the Assistant UI container.
    See bug for demo.
    
    Bug: b:111319842
    Change-Id: I1bf3d227beae70471986ff5f169488ec3b44bbcd
    Reviewed-on: https://chromium-review.googlesource.com/1132475
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574632}

    Changed files

    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
  34. Add Constructed/Destroying events to AssistantControllerObserver.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:59:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f58bcc5d430370a17613c0d8ff18d6ded2b16a1

    Comments

    Add Constructed/Destroying events to AssistantControllerObserver.
    
    These events are used to reduce the complexity of the circular
    dependency between AssistantController's sub-controllers.
    
    Bug: b:80542452
    Change-Id: If266ca01f844ec97d7f0b5f6a7216dac0da4e17f
    Reviewed-on: https://chromium-review.googlesource.com/1133587
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574631}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_controller_observer.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/assistant_screen_context_controller.cc
    • ash/assistant/assistant_screen_context_controller.h
    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/assistant_ui_controller.h
  35. [Autofill] Finalize cardholder name tooltip, and only show if textfield is prefilled

    Changed by Jared Saul - jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:58:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82955ec9a3ee0930e91b93cf7b6e50261b175192

    Comments

    [Autofill] Finalize cardholder name tooltip, and only show if textfield is prefilled
    
    Bug: 848955
    Change-Id: I0df815936fa2e9a09a9571760613277f34e2b1c5
    Reviewed-on: https://chromium-review.googlesource.com/1134394
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574630}

    Changed files

    • chrome/browser/ui/views/autofill/dialog_view_ids.h
    • chrome/browser/ui/views/autofill/save_card_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill_strings.grdp
  36. arc: Remove data on child transition fail.

    Changed by khmel@google.com - khmelohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:54:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef49be42c92ed17ab5ae4635843eeb4c35737eb5

    Comments

    arc: Remove data on child transition fail.
    
    This optionally resets ARC++ container in case child transition fails.
    This shows confirmation dialog and in case user accepts removes data and
    restart ARC++.
    
    TEST=Manually
    BUG=841939
    
    Change-Id: I07ecb1153acab7368f17ac15a957803132d6a101
    Reviewed-on: https://chromium-review.googlesource.com/1132529
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Yury Khmel <khmel@google.com>
    Cr-Commit-Position: refs/heads/master@{#574629}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/browser/chromeos/arc/auth/arc_auth_service.cc
    • chrome/browser/chromeos/arc/auth/arc_auth_service.h
    • chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/app_list/arc/arc_data_removal_dialog.h
    • chrome/browser/ui/browser_dialogs.h
    • chrome/browser/ui/views/arc_data_removal_dialog_view.cc
  37. [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:52:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e0fccc527819cb8e09682bc280fb35d4b3fafdd

    Comments

    [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.
    
    The first CL caused test failures because the browser_test was ignoring the
    "shift" key when searching for menu items. The IDC_SELECT_NEXT_TAB and
    IDC_SELECT_PREVIOUS_TAB only differ by the presence of "shift", so it cannot be
    ignored.
    
    > This matches other macOS application like Safari, Terminal, etc. All existing
    > hotkeys will still work.
    >
    > This CL uses the same hotkey for "previous tab" that Safari and Terminal use,
    > which is [ctr + shift + "Horizontal Tab"]. This also causes tests to pass.
    > However, pressing that key combination actually generates [ctr + shift + "End of
    > Medium"], which renderers in the Main Menu as a backwards tab. This CL updates
    > NSMenuItem(ChromeAdditions) to check for this special case.
    >
    > This CL removes two incorrect DCHECKs from render_widget_host_view_cocoa.mm. I
    > regularly hit both of them when running Chromium on a local build. They both
    > rely on the false assumption that keyEquivalents in the main menu must have the
    > command modifier.
    >
    > Bug: 851714
    > Reviewed-on: https://chromium-review.googlesource.com/1106659
    > Commit-Queue: Erik Chen <erikchen@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574211}
    
    Change-Id: Id87f364f5c5b303e8b9668e79f813a1c23376c98
    TBR: avi@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134203
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574628}

    Changed files

    • chrome/app/nibs/MainMenu.xib
    • chrome/browser/global_keyboard_shortcuts_mac.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
    • content/browser/renderer_host/render_widget_host_view_cocoa.mm
    • ui/events/test/cocoa_test_event_utils.mm
  38. Migrate AffiliationFetcher to SimpleURLLoader

    Changed by Mark Pilgrim - pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:48:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 176a3a3154870bc3e0722934c03d6dc3b5dae748

    Comments

    Migrate AffiliationFetcher to SimpleURLLoader
    
    Bug: 844947
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I08b3921d4a6e8ad2489a175cea5a5b883af32bbb
    Reviewed-on: https://chromium-review.googlesource.com/1129322
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574627}

    Changed files

    • chrome/browser/password_manager/password_store_factory.cc
    • components/password_manager/core/browser/BUILD.gn
    • components/password_manager/core/browser/DEPS
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.h
    • components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.h
    • components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/test_affiliation_fetcher_factory.h
    • components/password_manager/core/browser/password_store_factory_util.cc
    • components/password_manager/core/browser/password_store_factory_util.h
    • ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
  39. Fix a crash in MediaRouterDialogControllerViews

    Changed by Takumi Fujimoto - takumifohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:44:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ebcff160836f5c7057cad3694d19e7237475c26

    Comments

    Fix a crash in MediaRouterDialogControllerViews
    
    When trying to show the Views Cast Dialog, abort if a browser instance
    for the initiator WebContents is not found.
    
    Bug: 862671
    Change-Id: I00fd25490f8790624e87d2f77c9bfc8b95f59403
    Reviewed-on: https://chromium-review.googlesource.com/1134043
    Reviewed-by: Derek Cheng <imcheng@chromium.org>
    Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574626}

    Changed files

    • chrome/browser/ui/views/media_router/media_router_dialog_controller_views.cc
  40. [CrOS MultiDevice] Improve logging performance.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f39a6efa39053b51201f6c601a43955a5dd58a5f

    Comments

    [CrOS MultiDevice] Improve logging performance.
    
    Previously std::stringstream::str() was called twice, which generates
    two distinct (but identical) strings. This CL caches the result of the
    call and uses it twice.
    
    Bug: 862725
    Change-Id: I0384981a259b12d6c3ecf1420436f71e1e002fe6
    Reviewed-on: https://chromium-review.googlesource.com/1134218
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574625}

    Changed files

    • chromeos/components/proximity_auth/logging/logging.cc
  41. update hoverable pointerevent wpt

    Changed by Ella Ge - eirageohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:39:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df94a28e9988135e91dc8d0d841864344b7cde7c

    Comments

    update hoverable pointerevent wpt
    
    Update test wpt/pointerevent_attributes_hoverable_pointers
    
    This test was failing occationally on manual test, when we have
    clientX == box.right or clientY == box.bottom.
    update the test assertion so coordinates on border can be consider
    inside box.
    
    Note that on right border can also be outside box for the mouseevents.
    because we truncate the coordinates into interger.
    
    Bug: 863029
    Change-Id: Id20fbe0b6cf8566e6cdee229f427a0c747ed0c0a
    Reviewed-on: https://chromium-review.googlesource.com/1135432
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574624}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_attributes_hoverable_pointers-manual.html
  42. Reland "Fix OOPIF hit testing in layout tests."

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:38:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c09ebfd64bd9d402997f4c1ab5624d95347e2245

    Comments

    Reland "Fix OOPIF hit testing in layout tests."
    
    This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    
    The revert of this CL was determined to be the cause of some flaky tests
    on the chromeos bot. However those tests are disabled on linux and
    have been flaky on chromeos for a long time. See
    https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&builder=chromium.chromiumos%3Alinux-chromeos-rel&sortOrder=forward&sortColumn=test
    
    Original change's description:
    > Fix OOPIF hit testing in layout tests.
    >
    > If we haven't received an activated surface yet ensure that we fallback
    > to querying the renderer for the target of input events.
    >
    > BUG=601584
    >
    > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
    > Reviewed-on: https://chromium-review.googlesource.com/1131219
    > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573789}
    
    TBR=kenrb@chromium.org
    
    Bug: 601584
    Change-Id: Ifdd26f20bf6d44e704c33a7b7c4380a2de8c3696
    Reviewed-on: https://chromium-review.googlesource.com/1135471
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574623}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  43. Merge vr_shell/ Java namespace into vr/ namespace.

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:35:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbe916af89d21e6e4be335879b819bf3efaf8353

    Comments

    Merge vr_shell/ Java namespace into vr/ namespace.
    
    Bug: 862741
    
    NOPRESUBMIT=true
    TBR=yusufo@chromium.org
    
    Change-Id: If26bb6664b6b882db33327d381ccac6594d5ef65
    Reviewed-on: https://chromium-review.googlesource.com/1134091
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574622}

    Changed files

    • WATCHLISTS
    • base/android/jni_generator/jni_exception_list.gni
    • chrome/android/BUILD.gn
    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
    • chrome/android/java/src/org/chromium/chrome/browser/NavigationBarColorController.java
    • chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidUiGestureTarget.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidVSyncHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/EmptySniffingVrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/NoopCanvas.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnDispatchTouchEventCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnExitVrRequestListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VR_JAVA_OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrAlertDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCancelAnimationActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapperImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCompositorSurfaceManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreInfo.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionChecker.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionCheckerImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApi.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApiImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialogManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFeedbackStatus.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrInputConnection.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrMainActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrModalPresenter.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrPopupWindow.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToast.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToastManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrUiWidgetFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrWindowAndroid.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/BuildConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/GvrKeyboardLoaderClient.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/TextEditAction.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/VrInputMethodManagerWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/EmulatedVrController.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrFeedbackInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrInstallUpdateInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellCompositorViewHolderTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellControllerInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellDialogTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNativeUiTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNavigationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellWebInputEditingTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrDeviceTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTabTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockBrowserKeyboardInterface.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrCoreVersionCheckerImpl.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrDaydreamApi.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/AndroidManifest.xml
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/SimNfcActivity.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/HeadTrackingMode.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestriction.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestrictionRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/HeadTrackingUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NativeUiUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NfcSimUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/TransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrInfoBarUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrShellDelegateUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/vr_test_framework.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/browser/android/vr/BUILD.gn
    • chrome/browser/android/vr/vr_core_info.h
    • chrome/browser/android/vr/vr_shell_delegate.h
    • chrome/browser/vr/metrics/session_metrics_helper.h
    • chrome/browser/vr/test/vr_xr_browser_test.h
    • chrome/browser/vr/text_edit_action.h
    • chrome/browser/vr/ui_test_input.h
    • chrome/browser/vr/ui_unsupported_mode.h
    • chrome/browser/vr/webvr_input_browser_test.cc
    • chrome/browser/vr/webvr_tab_browser_test.cc
    • chrome/browser/vr/webvr_transition_browser_test.cc
    • chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeJUnit4ClassRunner.java
    • tools/perf/contrib/vr_benchmarks/vr_browsing_mode_pages.py
  44. Changed committed-interstitials flag from switch to feature.

    Changed by Carlos IL - carlosilohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49040ae795592d3b0c6a5b03533565caeb9ae266

    Comments

    Changed committed-interstitials flag from switch to feature.
    
    Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
    base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
    doing separate rampups for each kind of committed interstitial. Switch was
    changed to Feature so that it can be enabled via variations.
    
    Bug: 755632
    Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
    Reviewed-on: https://chromium-review.googlesource.com/1118975
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574621}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
    • chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
    • chrome/browser/ssl/connection_help_tab_helper.cc
    • chrome/browser/ssl/connection_help_tab_helper_browsertest.cc
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest_util.cc
    • chrome/browser/ssl/ssl_error_controller_client.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
    • chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
    • tools/metrics/histograms/enums.xml
  45. Migrate captive_portal to BindOnce

    Changed by Mark Pilgrim - pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:31:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dc10fe1b9fb22e9c1fb5a412b8440ba873866cf

    Comments

    Migrate captive_portal to BindOnce
    
    Bug: 714018
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia2bf1a8fa963f7540272a0d28961bfc961f14dd0
    Reviewed-on: https://chromium-review.googlesource.com/1131994
    Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574620}

    Changed files

    • chrome/browser/captive_portal/captive_portal_service.cc
    • components/captive_portal/captive_portal_detector.cc
    • components/captive_portal/captive_portal_detector.h
    • components/captive_portal/captive_portal_detector_unittest.cc
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.h
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.mm
  46. Removes Assistant horizontal page.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:30:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3753827af78b5c5e3f458acaf9017c1afd082459

    Comments

    Removes Assistant horizontal page.
    
    No longer needed.
    
    Bug: b:111315529
    Change-Id: Ic16af0891a296a535d67c46d43bc63eb86f6f6f1
    Reviewed-on: https://chromium-review.googlesource.com/1132347
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574619}

    Changed files

    • ash/app_list/BUILD.gn
    • ash/app_list/views/assistant_container_view.cc
    • ash/app_list/views/assistant_container_view.h
    • ash/app_list/views/horizontal_page_container.cc
    • ash/app_list/views/horizontal_page_container.h
  47. Adds caption bar to AssistantWebView UI.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:25:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 633097c22fed7171c82aabd1a3d001aab4510c78

    Comments

    Adds caption bar to AssistantWebView UI.
    
    In addition, this CL:
    - Adds a back button to the caption bar.
    - Adds API to change caption button visibility.
    
    Known issue:
    When navigating back from AssistantWebView UI, the Assistant
    container should not shrink. This is tracked in b/110433519.
    
    See bug for demo.
    
    Bug: b:111009446
    Change-Id: I63b47337d7ffcc8861c36529d04e9139800f4f4b
    Reviewed-on: https://chromium-review.googlesource.com/1132298
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#574618}

    Changed files

    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/ui/assistant_main_view.cc
    • ash/assistant/ui/assistant_web_view.cc
    • ash/assistant/ui/assistant_web_view.h
    • ash/assistant/ui/caption_bar.cc
    • ash/assistant/ui/caption_bar.h
    • ash/assistant/util/deep_link_util.cc
  48. [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895

    Changed by Peter K. Lee - pklohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:23:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f873a34ef2a72ed5d6bfcad35f5317c259d25fc7

    Comments

    [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895
    
    Added MDCShapedView.
    
    Bug: 863001
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ibfdc8430ff9d3f184eac341cd8d6fdf1fe5041d2
    Reviewed-on: https://chromium-review.googlesource.com/1135191
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574617}

    Changed files

    • DEPS
    • ios/third_party/material_components_ios/BUILD.gn