Home | Search | chromium - Builders
Login

Builder Win10 FYI Exp Release (Intel HD 630) Build 677 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisionbbe916af89d21e6e4be335879b819bf3efaf8353
Got Revisionbbe916af89d21e6e4be335879b819bf3efaf8353

Execution:

Steps and Logfiles:

Show:
  1. ( 630 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 435 ms ) remove .cipd
  4. ( 1 mins 7 secs ) bot_update
    [51GB/299GB used (17%)]
  5. ( 0 ) ensure_goma
  6. ( 668 ms ) swarming.py --version
    0.13
  7. ( 1 mins 25 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  9. ( 6 secs ) build directory
  10. ( 1 mins 33 secs ) extract build
  11. ( 437 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 4 mins 35 secs ) angle_end2end_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Pending time: 17s
    Shard duration: 0:04:11.095020
  14. ( 2 mins 35 secs ) angle_gles1_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:22.057180
  15. ( 1 mins 1 secs ) angle_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 56s
  16. ( 28 secs ) angle_white_box_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 22s
  17. ( 1 mins 56 secs ) tab_capture_end2end_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:48.039780
  18. ( 51 secs ) gl_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 45s
  19. ( 40 secs ) gl_tests_passthrough on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 36s
  20. ( 25 secs ) gl_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 21s
  21. ( 1 mins 56 secs ) gles2_conform_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:49.956810
  22. ( 1 mins 54 secs ) gles2_conform_d3d9_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:47.370790
  23. ( 1 mins 34 secs ) gles2_conform_gl_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:28.446580
  24. ( 42 secs ) gpu_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 34s
  25. ( 28 secs ) swiftshader_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 22s
  26. ( 38 secs ) video_decode_accelerator_d3d11_unittest on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 34s
  27. ( 37 secs ) video_decode_accelerator_d3d9_unittest on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 35s
  28. ( 2 mins 47 secs ) context_lost_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:42.055030
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 mins 56 secs ) depth_capture_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:50.503420
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 2 mins 54 secs ) gpu_process_launch_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:49.817900
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 2 mins ) hardware_accelerated_feature_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:57.223140
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 2 mins 10 secs ) info_collection_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:06.924050
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 2 mins 27 secs ) maps_pixel_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:23.531050
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 6 mins 15 secs ) pixel_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:06:09.102730
    Total tests: 48
    * Passed: 48 (48 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 2 mins 47 secs ) screenshot_sync_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:38.511260
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 3 mins 29 secs ) trace_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:26.892800
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 2 mins 59 secs ) viz_screenshot_sync_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:51.345510
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 39 mins 30 secs ) webgl2_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 0:31:49.699040 (shard #19)
    Max shard duration: 0:08:36.795310 (shard #12)
    Min shard duration: 0:07:13.903770 (shard #14)
    Total tests: 2761
    * Passed: 2696 (2696 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 7 mins 9 secs ) webgl_conformance_d3d11_validating_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:06:57.365680 (shard #1)
    Min shard duration: 0:04:09.832860 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 7 mins 26 secs ) webgl_conformance_gl_passthrough_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 18s (shard #1)
    Max shard duration: 0:07:00.374250 (shard #1)
    Min shard duration: 0:04:04.342360 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 7 mins 18 secs ) webgl_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 23s (shard #1)
    Max shard duration: 0:06:49.419720 (shard #1)
    Min shard duration: 0:04:00.870410 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 237 ms ) Tests statistics
     
    Stats
    Total shards: 51
    Total runtime: 2:46:12.308000
     
  43. ( 600 ms ) process_dumps
  44. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm62-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531418375816270, "id": "8941185161118534512", "project": "chromium", "tags": ["builder:Win10 FYI Exp Release (Intel HD 630)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/bbe916af89d21e6e4be335879b819bf3efaf8353", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win Builder", "parent_buildnumber:9003", "scheduler_invocation_id:9106615223461265232", "scheduler_job_id:chromium/Win10 FYI Exp Release (Intel HD 630)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 FYI Exp Release (Intel HD 630)" setup_build
buildnumber 677 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win Builder" setup_build
parent_got_angle_revision "1283ef62b4af8e96aa37b45e569d0e5a96d9a38c" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "bbe916af89d21e6e4be335879b819bf3efaf8353" setup_build
parent_got_revision_cp "refs/heads/master@{#574622}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23952}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "bbe916af89d21e6e4be335879b819bf3efaf8353" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "bbe916af89d21e6e4be335879b819bf3efaf8353" bot_update
got_revision_cp "refs/heads/master@{#574622}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update
swarm_hashes {"angle_end2end_tests": "6fb19aa853ad797ab29ad56a092d49bd89225608", "angle_gles1_conformance_tests": "335a7369db3070c4507f5177e2a7a501ebb8e3e9", "angle_perftests": "674f9ada27c43e306885af12d26b11547a9617f1", "angle_unittests": "f1f78db7620b3dd8d7d803e31f6a8a4d7adef742", "angle_white_box_tests": "ef530e537911d62f612587efd69a97a79e74f2e3", "browser_tests": "81db0f601453722179f993147ac685558126beac", "command_buffer_perftests": "1f029830aa8ce579f115f7f8005d1157bbe765ed", "gl_tests": "84ba25afda953a4a8cc732b1d9c6c2b39034e66d", "gl_unittests": "708f451fec07d7ef0b832db158be8ddd478efe6e", "gles2_conform_test": "045668c27355d7b68f9fc86c30c6362b9f327375", "gpu_unittests": "420c7491d0a23f1daa6467556f1950e291c7e888", "swiftshader_unittests": "91fc3847ec7b7da6f898c1919587c6baf9121d90", "telemetry_gpu_integration_test": "98450823147096f8960ed9242679040737d2423e", "video_decode_accelerator_unittest": "143b7caea39846f0b2c26f94537eebbdfb7cc34b"} find isolated tests

Blamelist:

  1. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  2. Carlos IL (carlosilohnoyoudont@chromium.org)
  3. Mark Pilgrim (pilgrimohnoyoudont@chromium.org)
  4. David Black (dmblackohnoyoudont@google.com)
  5. David Black (dmblackohnoyoudont@google.com)
  6. Peter K. Lee (pklohnoyoudont@chromium.org)
  7. Ian Clelland (iclellandohnoyoudont@chromium.org)
  8. Peter Kvitek (kvitekpohnoyoudont@chromium.org)
  9. Justin Novosad (junovohnoyoudont@chromium.org)
  10. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  11. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  12. Anna Offenwanger (offenwangerohnoyoudont@chromium.org)
  13. Alexandr Ilin (alexilinohnoyoudont@chromium.org)
  14. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  15. David 'Digit' Turner (digitohnoyoudont@google.com)
  16. Peter Wen (wnwenohnoyoudont@chromium.org)
  17. Istiaque Ahmed (lazyboyohnoyoudont@chromium.org)
  18. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  19. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  20. Colin Blundell (blundellohnoyoudont@chromium.org)
  21. Jun Cai (juncaiohnoyoudont@chromium.org)
  22. Etienne Pierre-doray (etiennepohnoyoudont@chromium.org)
  23. Kim Paulhamus (kpaulhamusohnoyoudont@chromium.org)
  24. Eugene But (eugenebutohnoyoudont@google.com)
  25. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  26. Becky Zhou (huayinzohnoyoudont@chromium.org)
  27. Nico Weber (thakisohnoyoudont@chromium.org)
  28. David Grogan (dgroganohnoyoudont@chromium.org)
  29. Nick Burris (nburrisohnoyoudont@google.com)
  30. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  31. Mike Reed (reedohnoyoudont@google.com)
  32. Peter E Conn (peconnohnoyoudont@chromium.org)
  33. Peter Kasting (pkastingohnoyoudont@chromium.org)
  34. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  35. Jay Civelli (jcivelliohnoyoudont@google.com)
  36. Stefan Zager (szagerohnoyoudont@chromium.org)
  37. Bruce Dawson (brucedawsonohnoyoudont@chromium.org)
  38. Peter Kasting (pkastingohnoyoudont@chromium.org)
  39. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  40. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  41. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  42. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  43. Peter Wen (wnwenohnoyoudont@chromium.org)
  44. Xida Chen (xidachenohnoyoudont@chromium.org)
  45. Daniel Bratell (bratellohnoyoudont@opera.com)
  46. Danyao Wang (danyaoohnoyoudont@chromium.org)
  47. Stephen Lanham (slanohnoyoudont@google.com)
  48. Sujie Zhu (sujiezhuohnoyoudont@google.com)
  49. Jeremy Roman (jbromanohnoyoudont@chromium.org)
  50. Majid Valipour (majidvpohnoyoudont@chromium.org)
  51. kylechar (kylecharohnoyoudont@chromium.org)
  52. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  53. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  54. vitaliii (vitaliiiohnoyoudont@chromium.org)
  55. Ken Rockot (rockotohnoyoudont@chromium.org)
  56. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  57. Rayan Kanso (rayankansohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 17:59:35 UTC
Start Thursday, 12-Jul-18 17:59:44 UTC
End Thursday, 12-Jul-18 20:00:51 UTC
Pending 8 secs
Execution 2 hrs 1 mins

All Changes:

  1. Merge vr_shell/ Java namespace into vr/ namespace.

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:35:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbe916af89d21e6e4be335879b819bf3efaf8353

    Comments

    Merge vr_shell/ Java namespace into vr/ namespace.
    
    Bug: 862741
    
    NOPRESUBMIT=true
    TBR=yusufo@chromium.org
    
    Change-Id: If26bb6664b6b882db33327d381ccac6594d5ef65
    Reviewed-on: https://chromium-review.googlesource.com/1134091
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574622}

    Changed files

    • WATCHLISTS
    • base/android/jni_generator/jni_exception_list.gni
    • chrome/android/BUILD.gn
    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
    • chrome/android/java/src/org/chromium/chrome/browser/NavigationBarColorController.java
    • chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidUiGestureTarget.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidVSyncHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/EmptySniffingVrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/NoopCanvas.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnDispatchTouchEventCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnExitVrRequestListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VR_JAVA_OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrAlertDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCancelAnimationActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapperImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCompositorSurfaceManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreInfo.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionChecker.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionCheckerImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApi.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApiImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialogManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFeedbackStatus.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrInputConnection.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrMainActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrModalPresenter.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrPopupWindow.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToast.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToastManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrUiWidgetFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrWindowAndroid.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/BuildConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/GvrKeyboardLoaderClient.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/TextEditAction.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/VrInputMethodManagerWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/EmulatedVrController.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrFeedbackInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrInstallUpdateInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellCompositorViewHolderTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellControllerInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellDialogTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNativeUiTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNavigationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellWebInputEditingTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrDeviceTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTabTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockBrowserKeyboardInterface.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrCoreVersionCheckerImpl.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrDaydreamApi.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/AndroidManifest.xml
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/SimNfcActivity.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/HeadTrackingMode.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestriction.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestrictionRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/HeadTrackingUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NativeUiUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NfcSimUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/TransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrInfoBarUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrShellDelegateUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/vr_test_framework.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/browser/android/vr/BUILD.gn
    • chrome/browser/android/vr/vr_core_info.h
    • chrome/browser/android/vr/vr_shell_delegate.h
    • chrome/browser/vr/metrics/session_metrics_helper.h
    • chrome/browser/vr/test/vr_xr_browser_test.h
    • chrome/browser/vr/text_edit_action.h
    • chrome/browser/vr/ui_test_input.h
    • chrome/browser/vr/ui_unsupported_mode.h
    • chrome/browser/vr/webvr_input_browser_test.cc
    • chrome/browser/vr/webvr_tab_browser_test.cc
    • chrome/browser/vr/webvr_transition_browser_test.cc
    • chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeJUnit4ClassRunner.java
    • tools/perf/contrib/vr_benchmarks/vr_browsing_mode_pages.py
  2. Changed committed-interstitials flag from switch to feature.

    Changed by Carlos IL - carlosilohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49040ae795592d3b0c6a5b03533565caeb9ae266

    Comments

    Changed committed-interstitials flag from switch to feature.
    
    Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
    base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
    doing separate rampups for each kind of committed interstitial. Switch was
    changed to Feature so that it can be enabled via variations.
    
    Bug: 755632
    Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
    Reviewed-on: https://chromium-review.googlesource.com/1118975
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574621}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
    • chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
    • chrome/browser/ssl/connection_help_tab_helper.cc
    • chrome/browser/ssl/connection_help_tab_helper_browsertest.cc
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest_util.cc
    • chrome/browser/ssl/ssl_error_controller_client.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
    • chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
    • tools/metrics/histograms/enums.xml
  3. Migrate captive_portal to BindOnce

    Changed by Mark Pilgrim - pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:31:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dc10fe1b9fb22e9c1fb5a412b8440ba873866cf

    Comments

    Migrate captive_portal to BindOnce
    
    Bug: 714018
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia2bf1a8fa963f7540272a0d28961bfc961f14dd0
    Reviewed-on: https://chromium-review.googlesource.com/1131994
    Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574620}

    Changed files

    • chrome/browser/captive_portal/captive_portal_service.cc
    • components/captive_portal/captive_portal_detector.cc
    • components/captive_portal/captive_portal_detector.h
    • components/captive_portal/captive_portal_detector_unittest.cc
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.h
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.mm
  4. Removes Assistant horizontal page.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:30:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3753827af78b5c5e3f458acaf9017c1afd082459

    Comments

    Removes Assistant horizontal page.
    
    No longer needed.
    
    Bug: b:111315529
    Change-Id: Ic16af0891a296a535d67c46d43bc63eb86f6f6f1
    Reviewed-on: https://chromium-review.googlesource.com/1132347
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574619}

    Changed files

    • ash/app_list/BUILD.gn
    • ash/app_list/views/assistant_container_view.cc
    • ash/app_list/views/assistant_container_view.h
    • ash/app_list/views/horizontal_page_container.cc
    • ash/app_list/views/horizontal_page_container.h
  5. Adds caption bar to AssistantWebView UI.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:25:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 633097c22fed7171c82aabd1a3d001aab4510c78

    Comments

    Adds caption bar to AssistantWebView UI.
    
    In addition, this CL:
    - Adds a back button to the caption bar.
    - Adds API to change caption button visibility.
    
    Known issue:
    When navigating back from AssistantWebView UI, the Assistant
    container should not shrink. This is tracked in b/110433519.
    
    See bug for demo.
    
    Bug: b:111009446
    Change-Id: I63b47337d7ffcc8861c36529d04e9139800f4f4b
    Reviewed-on: https://chromium-review.googlesource.com/1132298
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#574618}

    Changed files

    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/ui/assistant_main_view.cc
    • ash/assistant/ui/assistant_web_view.cc
    • ash/assistant/ui/assistant_web_view.h
    • ash/assistant/ui/caption_bar.cc
    • ash/assistant/ui/caption_bar.h
    • ash/assistant/util/deep_link_util.cc
  6. [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895

    Changed by Peter K. Lee - pklohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:23:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f873a34ef2a72ed5d6bfcad35f5317c259d25fc7

    Comments

    [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895
    
    Added MDCShapedView.
    
    Bug: 863001
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ibfdc8430ff9d3f184eac341cd8d6fdf1fe5041d2
    Reviewed-on: https://chromium-review.googlesource.com/1135191
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574617}

    Changed files

    • DEPS
    • ios/third_party/material_components_ios/BUILD.gn
  7. Finish renaming "whitelist" to "allowlist".

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:17:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a27b817c70dec1ea68f4ea4b8711697ca694fb62

    Comments

    Finish renaming "whitelist" to "allowlist".
    
    Bug: 822317
    Change-Id: I155df06759c529dbd3183530c4722be3c4e0feb1
    Reviewed-on: https://chromium-review.googlesource.com/1133308
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574616}

    Changed files

    • content/browser/frame_host/render_frame_host_feature_policy_unittest.cc
    • third_party/blink/public/mojom/feature_policy/feature_policy.mojom
    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/feature_policy/feature_policy.h
  8. Separated harness and target page base urls.

    Changed by Peter Kvitek - kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2eb30bfc9ba51a4ac3a4f28bf2c728c3252620d

    Comments

    Separated harness and target page base urls.
    
    Change-Id: Ie6b2097fd8c03b486c2cab8ec3357a8c55907e92
    Reviewed-on: https://chromium-review.googlesource.com/1134498
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574615}

    Changed files

    • headless/test/data/protocol/inspector-protocol-test.html
    • headless/test/headless_protocol_browsertest.cc
    • third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
  9. Refactor canvas code to centralize CanvasResourceProvider ownership

    Changed by Justin Novosad - junovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8b8872f2080130c2b5bdf026f32f46aad7598da

    Comments

    Refactor canvas code to centralize CanvasResourceProvider ownership
    
    With this change, CanvasResourceProvider is always owned
    by CanvasResourceHost, except for a a few special case that use
    ephemeral resource providers.  This is a step towards unifying
    canvas and OffscreenCanvas presentation code paths.
    
    BUG=788439
    TBR=fserb@chromium.org, zmo@chromium.org
    NOTRY=true
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Id9bdbb2c3e93b264f67946b887419b47599df65d
    Reviewed-on: https://chromium-review.googlesource.com/1134182
    Commit-Queue: Justin Novosad <junov@chromium.org>
    Reviewed-by: Justin Novosad <junov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574614}

    Changed files

    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.h
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
    • third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
    • third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
    • third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.cc
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.h
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h
  10. Deflake resource loading hints and previews browsertest

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:14:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a875a2ea21d8a321295a11440c80af01bcf7fa86

    Comments

    Deflake resource loading hints and previews browsertest
    
    Attempt to deflake resource loading hints and previews
    browsertest by waiting for hints to be processed.
    
    Currently, the hints are processed on the background thread,
    and so may not be processed immediately.
    
    Log from the failed Linux test bots seem to indicate that
    the hints are not processed in time.
    See http://shortn/_IjBGHDP2Rp
    
    Bug: 789542,831838
    Change-Id: I6b30b1a86dc5d2cdef1cd8274cf5c6088bec8634
    Reviewed-on: https://chromium-review.googlesource.com/1134598
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574613}

    Changed files

    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  11. [NTP] Anchor custom backgrounds to the center of the window

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06072d0984b80b680e26ed0f498911ef35800af2

    Comments

    [NTP] Anchor custom backgrounds to the center of the window
    
    Bug: 862789
    Change-Id: Ia23e75d07d738e02571010aaf9cbd0a1bc486060
    Reviewed-on: https://chromium-review.googlesource.com/1134435
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574612}

    Changed files

    • chrome/renderer/searchbox/searchbox_extension.cc
  12. Modify XRSession so that session geometry is only sent when it changes

    Changed by Anna Offenwanger - offenwangerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a32f749ecae1923fda1485aa423b8e46dafddcf

    Comments

    Modify XRSession so that session geometry is only sent when it changes
    
    Making it so that instead of receiving geometry every frame, ar_core
    only gets geometry (frame size and rotation) when it changes. This saves
    some processing every frame, and allows the GetFrameData interface to be
    made uniform for AR and VR.
    
    Bug: 856259,846521
    Change-Id: I5828f57e1292f932c68148ac1e6b898f966b8d00
    Reviewed-on: https://chromium-review.googlesource.com/1115776
    Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Klaus Weidner <klausw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574611}

    Changed files

    • chrome/browser/android/vr/arcore_device/arcore_device.cc
    • chrome/browser/android/vr/arcore_device/arcore_device.h
    • chrome/browser/android/vr/arcore_device/arcore_gl.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl.h
    • device/vr/vr_device_base.cc
    • device/vr/vr_device_base.h
    • device/vr/vr_display_impl.cc
    • device/vr/vr_display_impl.h
    • third_party/blink/renderer/modules/xr/xr_frame_provider.cc
    • third_party/blink/renderer/modules/xr/xr_frame_provider.h
    • third_party/blink/renderer/modules/xr/xr_session.cc
    • third_party/blink/renderer/modules/xr/xr_session.h
  13. Allow WritableSharedMemoryRegion to Unsafe conversion

    Changed by Alexandr Ilin - alexilinohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:08:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecfbde9b593ca7f497375f56da8d076eb29772fa

    Comments

    Allow WritableSharedMemoryRegion to Unsafe conversion
    
    This CL adds a new ConvertToUnsafe() method to the WritableSharedMemoryRegion
    class. This new method is similar to ConvertToReadOnly() in structure. The
    conversion does not modify an underlying platform handle (except it closes a
    read-only handle on POSIX) but changes region's type.
    
    Bug: 795291
    Change-Id: Ie0a6b4c9850c0e223ee9299655f9bfd6c79c383b
    Reviewed-on: https://chromium-review.googlesource.com/985981
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574610}

    Changed files

    • base/memory/platform_shared_memory_region.h
    • base/memory/platform_shared_memory_region_android.cc
    • base/memory/platform_shared_memory_region_fuchsia.cc
    • base/memory/platform_shared_memory_region_mac.cc
    • base/memory/platform_shared_memory_region_posix.cc
    • base/memory/platform_shared_memory_region_unittest.cc
    • base/memory/platform_shared_memory_region_win.cc
    • base/memory/writable_shared_memory_region.cc
    • base/memory/writable_shared_memory_region.h
  14. [Background Fetch] Deserialize icon from metadata on browser restart.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:07:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0f9d40078cf7c016aeefb8a0aba4c498ed86aba

    Comments

    [Background Fetch] Deserialize icon from metadata on browser restart.
    
    Bug: 855789
    Change-Id: Ida29d5cbf111838c9bf8bc2639dddf7509169199
    Reviewed-on: https://chromium-review.googlesource.com/1128965
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574609}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.h
  15. android: Update bundletool binary to 0.5.0

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:07:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc6d74d7b8c120d3d8d90ab8c68c5285e384a7f8

    Comments

    android: Update bundletool binary to 0.5.0
    
    This release contains a bugfix required to generate Android
    app bundle APKs archives that can be installed on all devices.
    
    For more context, see:
    https://buganizer.corp.google.com/issues/110777526
    
    BUG=846633,820459
    R=agrieve@chromium.org, bensmason@chromium.org, yfriedman@chromium.org
    
    Change-Id: Ic71445f49a4548c8610f5d18598cdd3d3d5692c4
    Reviewed-on: https://chromium-review.googlesource.com/1135127
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: David Turner <digit@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574608}

    Changed files

    • DEPS
    • build/android/gyp/bundletool.py
    • third_party/android_build_tools/bundletool/README.chromium
  16. Android: Fix jinja template deps

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:05:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 001fc64fc2945bb7b18e6ffb20b6048c007ac6b8

    Comments

    Android: Fix jinja template deps
    
    Temporarily add missing deps to the depfile. Will no longer be necessary
    once all downstream targets are fixed.
    
    Bug: 843562
    Change-Id: Id797ea032a6a3818dac6013dcacb6f68baef2b6b
    Reviewed-on: https://chromium-review.googlesource.com/1134884
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574607}

    Changed files

    • build/android/gyp/jinja_template.py
  17. [Extensions] Remove linked_ptr usage from extension_messages.cc

    Changed by Istiaque Ahmed - lazyboyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:59:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision abb887f1fe0523ed4ab633530a3a55fd3e479731

    Comments

    [Extensions] Remove linked_ptr usage from extension_messages.cc
    
    This CL also makes ExtensionMsg_Load_Params non-copyable. There
    shouldn't be any behavior change in this CL.
    
    Bug: 556939
    Change-Id: If7d11919f8fee0442578371d44d6b715d08efe3a
    Reviewed-on: https://chromium-review.googlesource.com/1132572
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574606}

    Changed files

    • extensions/browser/renderer_startup_helper.cc
    • extensions/common/extension_messages.cc
    • extensions/common/extension_messages.h
    • extensions/common/extension_messages_unittest.cc
  18. Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 16:57:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cae26c020606a88289e746e446999dd9c101019d

    Comments

    Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/58c79f66dd3a..798ee75d2365
    
    
    git log 58c79f66dd3a..798ee75d2365 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 kthelgason@webrtc.org Always disable RED when ULPFEC is disabled.
    2018-07-12 hta@webrtc.org Buffer ICE candidates that can't be added immediately.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@798ee75d2365
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ia3faf57f19146a8b08a9a5cbe8915a9750b91210
    Reviewed-on: https://chromium-review.googlesource.com/1135226
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574605}

    Changed files

    • DEPS
  19. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc

    Comments

    [unified-consent] Add unity logic to OneClickSigninSyncStarter
    
    All unified consent services are enabled when the unified
    consent is given through the OneClickSigninSyncStarter.
    
    Bug: 862202
    Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
    Reviewed-on: https://chromium-review.googlesource.com/1135001
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h
  20. Revert "Have Device Service observe MessageLoop destruction"

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"
    
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.
    
    Bug: 856771, 794105
    
    Original change's description:
    > Have Device Service observe MessageLoop destruction
    >
    > The Device Service needs to clean up parts of its internal state as part
    > of browser shutdown. However, it also needs to run on the UI thread,
    > and embedded services that run on the UI thread are not guaranteed to
    > be destroyed as part of browser shutdown (tasks to destroy these
    > services are posted from the IO thread by
    > ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
    > typically shut down before these posted tasks are run).
    >
    > To solve this issue we discussed adding plumbing wherein embedded
    > services could inform //content that they wanted to be notified when
    > shutdown was occurring on the main thread. However, on investigation
    > this plumbing would be painful to implement: it is only
    > EmbeddedInstanceManager that has direct information of these service
    > instances, and that object lives far away from //content's
    > ServiceManagerContext, the object that knows when shutdown is occurring
    > on the main thread.
    >
    > This CL takes an alternative approach of having the Device Service
    > implementation observe the destruction of its MessageLoop. I have
    > verified that the observation is triggered on shutdown of Chrome.
    >
    > Bug: 794105
    > Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
    > Reviewed-on: https://chromium-review.googlesource.com/1099245
    > Commit-Queue: Colin Blundell <blundell@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    
    TBR=rockot@chromium.org,blundell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h
  21. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented
    
    This is a follow-up CL per comments at:
    https://chromium-review.googlesource.com/c/chromium/src/+/1120955
    
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc
  22. [Autofill]: Create a policy flag for AutofillProfileEnabled.

    Changed by Etienne Pierre-doray - etiennepohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:50:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b27097af312f3f4a4ee22bf0ea2c65239de03ff

    Comments

    [Autofill]: Create a policy flag for AutofillProfileEnabled.
    
    AutofillProfileEnabled was added as a preference setting in 1127344.
    This CL creates a policy flag for AutofillProfileEnabled that can
    overwrite the user preference.
    
    Bug: 860526
    Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
    Reviewed-on: https://chromium-review.googlesource.com/1127463
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Reviewed-by: Drew Wilson <atwilson@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574601}

    Changed files

    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/test/data/policy/policy_test_cases.json
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_profile_policy_handler.cc
    • components/autofill/core/browser/autofill_profile_policy_handler.h
    • components/autofill/core/browser/autofill_profile_policy_handler_unittest.cc
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  23. Mark window-focus-self as flaky on Win10

    Changed by Kim Paulhamus - kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:49:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7be9cc2e39f872aeb8e03afb7d0aabf92ffde03

    Comments

    Mark window-focus-self as flaky on Win10
    
    Tbr: tkent@chromium.org
    Bug: 863067
    Change-Id: I9f043eec8363dbb26ccaa8d901321e0d579f1a4f
    Reviewed-on: https://chromium-review.googlesource.com/1135433
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574600}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  24. Add testDownloadWhileBrowsing EG test.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:48:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cce6875386037980e3245c630a9b9bac926f91e

    Comments

    Add testDownloadWhileBrowsing EG test.
    
    After tapping Download this test opens a separate tabs and loads the URL
    there. Then closes the tab and waits for the download completion.
    
    Bug: 854232
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id05c9344d1da80a57b6c7cc663b2b8a835f18e82
    Reviewed-on: https://chromium-review.googlesource.com/1111916
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574599}

    Changed files

    • ios/chrome/browser/ui/download/BUILD.gn
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/test/BUILD.gn
    • ios/chrome/test/scoped_eg_synchronization_disabler.h
  25. [Fuchsia] Address CR comments in sys::Runner implementation

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:39:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c234b0272dff6ce746e9eaac813497986913c3

    Comments

    [Fuchsia] Address CR comments in sys::Runner implementation
    
    When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
    prematurely and landed the change without my changes that addresed
    review comments. Landing them separately.
    
    Bug: 856416
    Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
    Reviewed-on: https://chromium-review.googlesource.com/1133968
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574598}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/app/component_controller_impl.cc
    • webrunner/app/component_controller_impl.h
    • webrunner/app/main.cc
    • webrunner/app/web_content_runner.cc
    • webrunner/app/web_content_runner.h
  26. [Feed] Scroll and focus handling for the FeedNewTabPage

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:36:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54d1975f16b7efae2408a1428fbde7207556a29

    Comments

    [Feed] Scroll and focus handling for the FeedNewTabPage
    
    + Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
    + Refactor snap scroll logic to a new class to make it reusable
    + Add top padding for the FeedNewTabPage to display correctly on tablet
    + Fix a small bug that search box is not enabled after auto snap scroll
    
    Bug: 860028, 860032, 862470
    Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
    Reviewed-on: https://chromium-review.googlesource.com/1133594
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574597}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
  27. Remove most android-specific hard_timeout and shard overrides.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a64d6771d8b24f079f24e41ebaf14f672747084

    Comments

    Remove most android-specific hard_timeout and shard overrides.
    
    These were added during android swarming bring-up.  We shouldn't use
    per-bot exceptions for this.
    
    Also remove a random sharding setting for base_unittests on ToTMac
    that doesn't look necessary.
    
    Bug: 843511
    Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
    Reviewed-on: https://chromium-review.googlesource.com/1134531
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574596}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.swarm.json
    • testing/buildbot/test_suite_exceptions.pyl
  28. [css-tables] Make table's max-content honor captions' min-content

    Changed by David Grogan - dgroganohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dff5931455e0302289a3cc9027fd3f98cfe22fca

    Comments

    [css-tables] Make table's max-content honor captions' min-content
    
    Table's min-content already honored it.
    
    We'd apparently never been bitten before by tables occasionally having
    min-content > max-content. A new DCHECK in LayoutNG exposed it.
    
    Bug: 857185
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
    Reviewed-on: https://chromium-review.googlesource.com/1121251
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574595}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/table/caption-min-greater-than-max-crash.html
    • third_party/WebKit/LayoutTests/fast/table/spans-min-greater-than-max-crash.html
    • third_party/blink/renderer/core/layout/layout_table.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  29. Settings WebUI: Fix extensions url on cleanup result page

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  30. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  31. suppress until skia roll

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  32. 🤝 Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  33. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  34. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py
  35. Simplify FakeGaiaCookieManagerService

    Changed by Jay Civelli - jcivelliohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

    Comments

    Simplify FakeGaiaCookieManagerService
    
    Simplifying the FakeGaiaCookieManagerService API by not requiring to
    call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
    instead a member of the FakeGaiaCookieManagerService.
    
    This API simplification is in preparation for switching GaiaAuthFetcher
    to use the SimpleURLLoader (network service).
    
    Bug: 840396
    Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
    Reviewed-on: https://chromium-review.googlesource.com/1114226
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574588}

    Changed files

    • chrome/browser/extensions/api/identity/identity_apitest.cc
    • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
    • chrome/browser/signin/signin_ui_util_unittest.cc
    • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.h
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/signin_manager_unittest.cc
  36. Get rid of GraphicsLayer::scrollable_area_

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 442f13b7e97747ab09612a101159b1eb26072382

    Comments

    Get rid of GraphicsLayer::scrollable_area_
    
    The only place where it was actually used was in
    GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
    call to the GraphicsLayerClient.
    
    BUG=823365
    R=pdr@chromium.org,skobes@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
    Reviewed-on: https://chromium-review.googlesource.com/1132536
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574587}

    Changed files

    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/frame/visual_viewport.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.h
    • third_party/blink/renderer/platform/graphics/graphics_layer_client.h
  37. Add "latency" to list of ETW-traceable events

    Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5d9a9d75a9a8f7f6fb9d749c9b797eb2550d34e

    Comments

    Add "latency" to list of ETW-traceable events
    
    The "latency" category looks like a perfect event category for ETW
    tracing. In particular, TabSwitching::Latency indicates when Chrome
    thinks that tab switching has started and stopped which allows it to be
    profiled in detail. This has revealed where CPU time is going, and how
    long the delay is from when the keyboard event is generated to when
    Chrome starts officially processing it. This was helpful in
    investigating tab switching latency in bug 858944.
    
    This will require an update to UIforETW to fully enable, which I have
    done locally for testing purposes.
    
    Bug: 858944
    Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
    Reviewed-on: https://chromium-review.googlesource.com/1134516
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574586}

    Changed files

    • base/trace_event/trace_event_etw_export_win.cc
  38. Remove NewTabButton::GetVisibleBounds().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f448a241361b03dd2b6fd21ab052774e1074fdf1

    Comments

    Remove NewTabButton::GetVisibleBounds().
    
    This was a computed by constructing the border path and computing the bounding
    box.  However, it was only used for the ink drop, and ink drops are only used in
    newer material mode, where the border path is a square.
    
    Instead, we can use GetContentsBounds(), as long as those are actually
    positioned correctly.  The new tab button has empty space at the top, which is
    included (by the tabstrip) in its size and accounted for when doing painting and
    hittesting.  By adding an empty top border of this thickness, a lot of this code
    can be simplified.  (Further simplifications are coming in a subsequent CL.)
    
    Bug: none
    Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
    Reviewed-on: https://chromium-review.googlesource.com/1134399
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574585}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
  39. [AF] Use views::Separator in the Autofill dropdown

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff6fb086724fb3cd20409d3e72065bbd4a84abd

    Comments

    [AF] Use views::Separator in the Autofill dropdown
    
    This is a follow-up of crrev.com/c/1131680 and replace a custom view
    to simulate a separator with a views::Separator view.
    
    Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
    Reviewed-on: https://chromium-review.googlesource.com/1133328
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574584}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  40. [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b35e9edf0aed36764ee35db8ed9e66466bb18249

    Comments

    [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests
    
    Remove a redundant URLPatternSet comparison method from
    ScriptingPermissionsModifier unittests, instead leveraging the
    string comparison and gmock utilities. These are slightly less code
    and offer better failure messages.
    
    Bug: None
    
    Change-Id: Ic8b99f0c9294658d6bdd16738f179a2e352eb408
    Reviewed-on: https://chromium-review.googlesource.com/1134496
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574583}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
  41. [ios] Set favicon fallback style for UI Refresh for ReadingList

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:05:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eeff01fbfa506b55fc9f1c0126c618a788015a4

    Comments

    [ios] Set favicon fallback style for UI Refresh for ReadingList
    
    - Sets the fallback monogram and background colors to a constant color.
    
    Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
    Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing
    
    Bug: 851390
    
    Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
    Reviewed-on: https://chromium-review.googlesource.com/1125271
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574582}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
  42. Enable StaleWhileRevalidate in experimental features.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc2f58c6417a00888317b79f40fd904b1f6628b

    Comments

    Enable StaleWhileRevalidate in experimental features.
    
    To gather some stability enable it for experimental features before
    we do the origin trial.
    
    BUG=348877
    
    Change-Id: I7598f35ac87b719305c6efa98c37de2eec8031a4
    Reviewed-on: https://chromium-review.googlesource.com/1134883
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574581}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  43. Android: Default to full instead of fast

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c98d04f201c356e8c4e811f3a43afa5c264750c

    Comments

    Android: Default to full instead of fast
    
    Switch from --full being optional to --fast being optional. Quite a few
    users of generate_gradle.py have found it unintuitive to have red
    underlines by default.
    
    Bug: 620034
    Change-Id: I24a19e16ed21baa19bde97bb2f3077430a73d148
    Reviewed-on: https://chromium-review.googlesource.com/1134882
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574580}

    Changed files

    • build/android/gradle/generate_gradle.py
  44. [Code health] Disable TouchActionBrowserTests on Debug and *San bots

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:02:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da109c8fd1b66a54c514b3012c29ebb232c113e9

    Comments

    [Code health] Disable TouchActionBrowserTests on Debug and *San bots
    
    These tests are flaky on Debug builds and *San bots. These tests sends
    synthetic gesture event and measure scroll offset. It should be fine
    without coverages on Debug and *San builds.
    
    TBR=sahel@chromium.org, tdresser@chromium.org
    
    Bug: 855979, 833015
    Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe
    Reviewed-on: https://chromium-review.googlesource.com/1135195
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574579}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  45. [jumbo] Deduplicate a time constant in autofill code

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Thursday, 12-Jul-18 16:01:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a742e15951f4e95d609b6628fc486a88b4fe0df

    Comments

    [jumbo] Deduplicate a time constant in autofill code
    
    Two different bubbles needed the same time constant and when
    they got copies of the constant that broke certain jumbo
    builds. This merges the constants to a single constant.
    
    It also changes type to base::TimeDelta which is the actual
    type needed and since the addition of constexpr can be used
    in global constants.
    
    Bug: 852904,862397
    Change-Id: I52a63d3301efb1c7aec55541c15427c5d96ba524
    Reviewed-on: https://chromium-review.googlesource.com/1134998
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574578}

    Changed files

    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/popup_constants.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
  46. Revert "[Nav Experiment] Add a wait after restore session."

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:01:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e33b9da8d371a25857c422d277115441c629ce5

    Comments

    Revert "[Nav Experiment] Add a wait after restore session."
    
    This reverts commit bcae87b0c7618e2fc61f78a073cf5589fe9679bd.
    
    Reason for revert: This didn't actually fix the problem and
    I didn't catch it due to a mistake in testing. The real
    problem is that the restore_session request started in 
    WKBasedNavigationManager::Restore() was not run, because
    |_containerView| is not yet initiated in the new CWVWebView.
    
    Original change's description:
    > [Nav Experiment] Add a wait after restore session.
    > 
    > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    > enabled. A better approach would be to turn this test into a
    > programmatic test so both navigation managers implementations are
    > tested, but web::features symbols are not exposed in ios/web_view.
    > 
    > Bug: 862714
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    > Reviewed-on: https://chromium-review.googlesource.com/1134046
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Commit-Queue: Danyao Wang <danyao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574367}
    
    TBR=eugenebut@chromium.org,danyao@chromium.org
    
    Change-Id: Ia9d2d127e18264fbf69786c58b71706e0b34ead5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1135346
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574577}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  47. [Chromecast] Use MobileScoller on Cast Android builds.

    Changed by Stephen Lanham - slanohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef77d4afc3b73eb7fc96dff1908164994b4a82

    Comments

    [Chromecast] Use MobileScoller on Cast Android builds.
    
    This class was renamed from Scroller here: crrev.com/c/1087641. Update the
    conditionals so that Scroller is only used on non-Android Cast builds,
    and MobileScroller is used on Android Cast builds.
    
    Bug: internal b/111287588
    Test: Compiles
    
    Change-Id: I19dc01e1339016e3db2ab3b7d81a95efc5c6a0f3
    Reviewed-on: https://chromium-review.googlesource.com/1133761
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Stephen Lanham <slan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574576}

    Changed files

    • ui/events/gestures/blink/web_gesture_curve_impl.cc
  48. Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type

    Changed by Sujie Zhu - sujiezhuohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 15:56:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdb64db76a187df14e07aa31daccedb1813ffb8e

    Comments

    Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type
    
    For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    
    Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    
    In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    
    The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    
    Bug: 852904
    Change-Id: I01191cb8a9d0a3bf954874e6c8beb62d3b02c1ea
    Reviewed-on: https://chromium-review.googlesource.com/1134388
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#574575}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  49. fuzzer: Don't assume that the out dir is inside the src git repository.

    Changed by Jeremy Roman - jbromanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fb53cf0d187b9537160ad967975f17641d59c1f

    Comments

    fuzzer: Don't assume that the out dir is inside the src git repository.
    
    This might not be the case in general. Not only could a output directory
    exist elsewhere altogether (though this only fixes one issue that breaks
    when you do that), but it could be a symlink or another filesystem; in
    such cases git does not consider it part of the repository.
    
    This can be addressed by explicitly giving the path to src.git when issuing
    git commands.
    
    Change-Id: Ibf62466548e15d6ef57ed1e959d507ff70076352
    Reviewed-on: https://chromium-review.googlesource.com/1131842
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574574}

    Changed files

    • testing/libfuzzer/fuzzer_test.gni
    • testing/libfuzzer/gen_fuzzer_owners.py
  50. [testing] Move context menu ever timestamp test to a separate test

    Changed by Majid Valipour - majidvpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:46:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8696fc59786065ffc8a2e06f2db8f9e9ebc772a1

    Comments

    [testing] Move context menu ever timestamp test to a separate test
    
    ContextMenu interaction with other events is a suspected cause of
    flakiness of the original test. This CL is separating it from the
    rest as a potential fix.
    
    Bug: 846750
    Change-Id: I3d452388be65984ca82238d55a938d7a273fcf3f
    Reviewed-on: https://chromium-review.googlesource.com/1134180
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Commit-Queue: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574573}

    Changed files

    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/context-menu-event.html
    • third_party/WebKit/LayoutTests/fast/events/hr-timestamp/input-events.html
  51. Update viz_content_browsertests filter.

    Changed by kylechar - kylecharohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:43:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e0d4f50a43ad0ec12342ccbd16bf63f571651a7

    Comments

    Update viz_content_browsertests filter.
    
    Undo revert in https://crrev.com/c/1134144 which didn't end up being
    needed. Revert was in response to FindIt and failures in
    SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest but that problem
    had already been addressed.
    
    TBR: jonross@chromium.org
    Bug: 848825, 848348
    Change-Id: Ie00ce45db8b380847dddf4fb099a120ce7ada987
    Reviewed-on: https://chromium-review.googlesource.com/1135146
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574572}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  52. [iOS] New location bar icons and fonts.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57bfd6b0cba9de19f7dd75558447eba072bf84da

    Comments

    [iOS] New location bar icons and fonts.
    
    Updates the logic to switch between larger and smaller fonts, replaces
    security state and voice/share icons.
    
    Bug: 856542
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iecc5da700dd9b3004e8480abaa842dc6e143bdca
    Reviewed-on: https://chromium-review.googlesource.com/1135128
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574571}

    Changed files

    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_dangerous.imageset/location_bar_dangerous@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_insecure.imageset/location_bar_insecure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_offline.imageset/location_bar_offline@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_secure.imageset/location_bar_secure@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_share.imageset/location_bar_share@3x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@2x.png
    • ios/chrome/browser/ui/location_bar/resources/location_bar_voice.imageset/location_bar_voice@3x.png
    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
  53. Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:42:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3b164c24e967409cad5205e6a1ed651615566aa

    Comments

    Import wpt@b7f4f1d1ea5708bfb7578090f19c75dcf21cbef2
    
    Using wpt-import in Chromium d18929b41e24487865c4ed9da46129e6b037beeb.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21188
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    domenic@chromium.org, ricea@chromium.org:
      external/wpt/streams
    jsbell@chromium.org:
      external/wpt/encoding
    kojii@chromium.org:
      external/wpt/css/css-writing-modes
    mlamouri@chromium.org:
      external/wpt/screen-orientation
    
    TBR=foolip
    
    No-Export: true
    Change-Id: Ib04131d32533fd3a6687cc2999f6a0b409f08165
    Reviewed-on: https://chromium-review.googlesource.com/1134875
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574570}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/appmanifest/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-015.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-016.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-022.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vlr-023.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-021.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-024.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/block-flow-direction-vrl-025.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/different-block-flow-dir-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/first-page-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/flexbox_align-items-stretch-writing-modes.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/form-controls-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/inline-replaced-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-htb-001.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-010.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-013.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-014.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-018.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vlr-020.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-009.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-011.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-017.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/line-box-direction-vrl-019.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/page-flow-direction-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/replaced-content-image-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-003.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-005.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vlr-007.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-002.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-004.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-006.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/row-progression-vrl-008.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/writing-mode-vertical-rl-003.htm
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-basics.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-invalid-label.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/api-surrogates-utf8.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/encoding/iso-2022-jp-decoder.html
    • third_party/WebKit/LayoutTests/external/wpt/encoding/replacement-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-byte-order-marks.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-single-byte.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-fatal.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-ignorebom.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-labels.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-streaming.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textdecoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-constructor-non-utf.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/textencoder-utf16-surrogates.any.js
    • third_party/WebKit/LayoutTests/external/wpt/encoding/unsupported-encodings.any.js
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-object-element/object-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-button-element/button-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-fieldset-element/fieldset-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-input-element/input-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-output-element/output-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-select-element/select-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/the-textarea-element/textarea-setcustomvalidity.html
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/appmanifest.idl
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/screen-orientation.idl
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/idlharness.window.js
    • third_party/WebKit/LayoutTests/external/wpt/screen-orientation/interfaces.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.dedicatedworker.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.js
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.serviceworker.https.html
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/then-interception.sharedworker.html
    • third_party/WebKit/LayoutTests/platform/mac-retina/external/wpt/appmanifest/idlharness.window-expected.txt
  54. [Sync::Consent] Split ConsentAuditor interface from implementation.

    Changed by vitaliii - vitaliiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:40:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7782405912e05feca6e0cf3808ab8f3c8ff70f2f

    Comments

    [Sync::Consent] Split ConsentAuditor interface from implementation.
    
    Also rewrite FakeConsentAuditor to implement the interface instead of
    inheriting from the implementation. This unblocks enabling the separate
    datatype feature by default.
    
    Bug: 862186
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I474f74f12278221ef6278c120576f1ff1a224c4a
    Reviewed-on: https://chromium-review.googlesource.com/1131508
    Reviewed-by: Markus Heintz <markusheintz@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574569}

    Changed files

    • chrome/browser/consent_auditor/consent_auditor_factory.cc
    • chrome/browser/consent_auditor/consent_auditor_test_utils.cc
    • components/consent_auditor/BUILD.gn
    • components/consent_auditor/consent_auditor.cc
    • components/consent_auditor/consent_auditor.h
    • components/consent_auditor/consent_auditor_impl.cc
    • components/consent_auditor/consent_auditor_impl.h
    • components/consent_auditor/consent_auditor_impl_unittest.cc
    • components/consent_auditor/fake_consent_auditor.cc
    • components/consent_auditor/fake_consent_auditor.h
    • ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
    • ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm
  55. [content-service] Support basic View embedding

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:36:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c5bc74636041c26d31f3dae12c7fc51032ce27

    Comments

    [content-service] Support basic View embedding
    
    Adds support for embedding a View object within a client application's
    window tree. Currently Chrome OS only.
    
    Enables a new simple_browser test application to be launched via a
    command-line flag in DCHECK-enabled builds only, for manual developer
    testing. This application runs in a sandboxed utility process and embeds
    a View that can be navigated, displaying web contents within the
    application's UI, backed by a concrete WebContents owned by a Content
    Service instance in the browser process.
    
    Bug: 855092
    Change-Id: I95937f987e87ad303689d73b7e57c836ee706d28
    Test: Launch Chrome OS chrome --enable-features=Mash --launch-simple-browser and verify that you can navigate the cute little browser window that pops up.
    Reviewed-on: https://chromium-review.googlesource.com/1125342
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574568}

    Changed files

    • chrome/app/BUILD.gn
    • chrome/browser/BUILD.gn
    • chrome/browser/DEPS
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/common/BUILD.gn
    • chrome/common/features.gni
    • chrome/utility/BUILD.gn
    • chrome/utility/DEPS
    • chrome/utility/chrome_content_utility_client.cc
    • content/browser/browser_context.cc
    • content/browser/content_service_delegate_impl.cc
    • services/content/BUILD.gn
    • services/content/DEPS
    • services/content/public/cpp/BUILD.gn
    • services/content/public/cpp/DEPS
    • services/content/public/cpp/view.cc
    • services/content/public/cpp/view.h
    • services/content/public/features.gni
    • services/content/public/mojom/BUILD.gn
    • services/content/public/mojom/view.mojom
    • services/content/service_unittest.cc
    • services/content/simple_browser/BUILD.gn
    • services/content/simple_browser/DEPS
    • services/content/simple_browser/OWNERS
    • services/content/simple_browser/README.md
    • services/content/simple_browser/manifest.json
    • services/content/simple_browser/public/mojom/BUILD.gn
    • services/content/simple_browser/public/mojom/OWNERS
    • services/content/simple_browser/public/mojom/constants.mojom
    • services/content/simple_browser/simple_browser_service.cc
    • services/content/simple_browser/simple_browser_service.h
    • services/content/simple_browser/window.cc
    • services/content/simple_browser/window.h
    • services/content/view_delegate.h
    • services/content/view_impl.cc
    • services/content/view_impl.h
    • ui/views/mus/remote_view/BUILD.gn
  56. Fix crash with webRequest and network service when duplicate request IDs are seen.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:25:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4072ab48cadcd3f98481be63bdd59e5c623729d

    Comments

    Fix crash with webRequest and network service when duplicate request IDs are seen.
    
    The cause in this case was SimpleURLLoader always using a request ID of 0. These requests don't go through auth anyways (since there's no tab to associate them with). Gracefully handle this in WebRequestProxyingURLLoaderFactory by not crashing.
    
    Bug: 853118
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I856259f76caf67d7d6c0b8e48535cd56419ead1a
    Reviewed-on: https://chromium-review.googlesource.com/1133692
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574567}

    Changed files

    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.h
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
  57. [Background Fetch] Get options and title on initialization.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 15:21:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3925c59dce4a1a882e581e405c82303fbb99bce0

    Comments

    [Background Fetch] Get options and title on initialization.
    
    Bug: 853058
    Change-Id: Ib5ef98ad0cd988a5ac361b96fa55cebb0e09b800
    Reviewed-on: https://chromium-review.googlesource.com/1128863
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574566}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.h