Home | Search | chromium - Builders
Login

Builder Win10 FYI Exp Release (Intel HD 630) Build 673 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision75c9e38bcfe01f3a7c2637050ddcb2f342dd3034
Got Revision75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

Execution:

Steps and Logfiles:

Show:
  1. ( 603 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 387 ms ) remove .cipd
  4. ( 1 mins 5 secs ) bot_update
    [51GB/299GB used (17%)]
  5. ( 0 ) ensure_goma
  6. ( 638 ms ) swarming.py --version
    0.13
  7. ( 1 mins 33 secs ) gclient runhooks
  8. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  9. ( 6 secs ) build directory
  10. ( 1 mins 26 secs ) extract build
  11. ( 421 ms ) find isolated tests
  12. ( 0 ) test_pre_run
  13. ( 4 mins 45 secs ) angle_end2end_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Pending time: 29s
    Shard duration: 0:04:11.433970
  14. ( 2 mins 28 secs ) angle_gles1_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:18.949450
  15. ( 1 mins 3 secs ) angle_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 55s
  16. ( 34 secs ) angle_white_box_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 29s
  17. ( 2 mins 17 secs ) tab_capture_end2end_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:13.833660
  18. ( 53 secs ) gl_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 49s
  19. ( 46 secs ) gl_tests_passthrough on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 44s
  20. ( 31 secs ) gl_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 27s
  21. ( 2 mins 6 secs ) gles2_conform_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:00.185480
  22. ( 1 mins 56 secs ) gles2_conform_d3d9_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:54.936040
  23. ( 1 mins 39 secs ) gles2_conform_gl_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:34.407100
  24. ( 51 secs ) gpu_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 45s
  25. ( 28 secs ) swiftshader_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 26s
  26. ( 43 secs ) video_decode_accelerator_d3d11_unittest on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 39s
  27. ( 45 secs ) video_decode_accelerator_d3d9_unittest on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 43s
  28. ( 3 mins 16 secs ) context_lost_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:09.775310
    Total tests: 8
    * Passed: 8 (8 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 2 mins 23 secs ) depth_capture_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:15.982500
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 3 mins 44 secs ) gpu_process_launch_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:35.072490
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 2 mins 23 secs ) hardware_accelerated_feature_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:19.149400
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 2 mins 24 secs ) info_collection_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:22.726520
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 2 mins 44 secs ) maps_pixel_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:38.619710
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 6 mins 43 secs ) pixel_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:06:34.567690
    Total tests: 48
    * Passed: 48 (48 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 3 mins 4 secs ) screenshot_sync_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:58.168840
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 4 mins 13 secs ) trace_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:04:04.463640
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 3 mins 46 secs ) viz_screenshot_sync_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:38.466830
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 42 mins 56 secs ) webgl2_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 0:34:25.809520 (shard #19)
    Max shard duration: 0:09:13.359630 (shard #14)
    Min shard duration: 0:07:11.058150 (shard #8)
    Total tests: 2761
    * Passed: 2696 (2696 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 8 mins 16 secs ) webgl_conformance_d3d11_validating_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 11s (shard #1)
    Max shard duration: 0:07:54.496610 (shard #1)
    Min shard duration: 0:05:17.983780 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 8 mins 20 secs ) webgl_conformance_gl_passthrough_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 26s (shard #1)
    Max shard duration: 0:07:43.090680 (shard #1)
    Min shard duration: 0:04:27.566600 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 7 mins 17 secs ) webgl_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:07:00.580010 (shard #1)
    Min shard duration: 0:04:13.275250 (shard #0)
    Total tests: 922
    * Passed: 914 (914 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 205 ms ) Tests statistics
     
    Stats
    Total shards: 51
    Total runtime: 2:51:10.225000
     
  43. ( 568 ms ) process_dumps
  44. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm62-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531387649698840, "id": "8941217379789024528", "project": "chromium", "tags": ["builder:Win10 FYI Exp Release (Intel HD 630)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win Builder", "parent_buildnumber:8972", "scheduler_invocation_id:9106647441974880032", "scheduler_job_id:chromium/Win10 FYI Exp Release (Intel HD 630)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 FYI Exp Release (Intel HD 630)" setup_build
buildnumber 673 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win Builder" setup_build
parent_got_angle_revision "c9c259cccb2ece20c516b45f2c3782e31860a528" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" setup_build
parent_got_revision_cp "refs/heads/master@{#574507}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" bot_update
got_revision_cp "refs/heads/master@{#574507}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
swarm_hashes {"angle_end2end_tests": "d6b216145d12c27379ce8dbde868e97c0cc810a6", "angle_gles1_conformance_tests": "99c6135f4acdec505a6926b13d8e245d16a6a3e4", "angle_perftests": "7fdf6276122454cf70c8eed90e94959ef98e5e23", "angle_unittests": "fb11545b3be68472578067ad187c428bffe75c17", "angle_white_box_tests": "1fbd5d7429e047fb44faf9e268f4f902e7984994", "browser_tests": "b26443b55b52cf02ad87cf250b31cbf37acdf175", "command_buffer_perftests": "1a42a50cfe6e02b81c47d81ee9f6e05832e3e707", "gl_tests": "ffb26604b4935f2fe10680e791d23ad6cfe048c7", "gl_unittests": "b941fa8429be10bf10339870e8411dada8ccce6b", "gles2_conform_test": "c004cf8d06ef57e0c2d8072d271951cd69ba54fe", "gpu_unittests": "9c4cb4653820a31366117be183727fe662b62084", "swiftshader_unittests": "3314fc1bd53046883295bc119b5a50059ff8cb72", "telemetry_gpu_integration_test": "0e0384662077fe0bc354f60a800aa489f6d0d93a", "video_decode_accelerator_unittest": "8980a39e0adcc4044beb54dd18f96d83bd941a06"} find isolated tests

Blamelist:

  1. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  2. rajendrant (rajendrantohnoyoudont@chromium.org)
  3. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  4. Aleks Totic (atoticohnoyoudont@chromium.org)
  5. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  6. Anita Woodruff (awdfohnoyoudont@chromium.org)
  7. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  8. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  9. Alan Cutter (alancutterohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 09:27:29 UTC
Start Thursday, 12-Jul-18 09:27:33 UTC
End Thursday, 12-Jul-18 11:39:50 UTC
Pending 3 secs
Execution 2 hrs 12 mins

All Changes:

  1. Add service worker README.md.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

    Comments

    Add service worker README.md.
    
    Bug: 795989
    Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d
    Reviewed-on: https://chromium-review.googlesource.com/1134718
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574507}

    Changed files

    • content/browser/service_worker/README.md
    • content/common/service_worker/README.md
    • third_party/blink/common/service_worker/README.md
    • third_party/blink/public/common/service_worker/README.md
    • third_party/blink/public/mojom/service_worker/README.md
    • third_party/blink/public/platform/modules/service_worker/README.md
    • third_party/blink/public/web/modules/service_worker/README.md
    • third_party/blink/renderer/modules/service_worker/README.md
  2. Use PLM for data saver site-breakdown

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62

    Comments

    Use PLM for data saver site-breakdown
    
    This CL adds PLM observer for site-breakdown that records the data use
    by host. The new codepath is enabled and the old data use asriber observer
    based site-breakdown codepath is disabled, based on a feature.
    
    Bug: 836029
    Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219
    Reviewed-on: https://chromium-review.googlesource.com/1050868
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574506}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • chrome/test/BUILD.gn
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
  3. Add new methods to EntryList and tests

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76bc398de31290a2d97ee6b7ea804a55d1d5451d

    Comments

    Add new methods to EntryList and tests
    
    Change the logic to add entries to My Files to account for volume being
    mounted/unmounted. This fixes some broken tests when running with the
    flag enabled by default, so test to cover this is on
    crrev.com/c/1131025.
    
    Fix test getMetadata function name.
    
    Bug: 857335
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id056b0e0d5c77a07c2561f6566bfc99111864917
    Reviewed-on: https://chromium-review.googlesource.com/1133613
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574505}

    Changed files

    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
  4. [LayoutNG] Fix static position for inline containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f321a196a45bce7d32257d0b93b472dba89e205a

    Comments

    [LayoutNG] Fix static position for inline containing block
    
    Bug: 740993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Iacdfc2694b2522c06a2512000ed1ca7f043b7541
    Reviewed-on: https://chromium-review.googlesource.com/1134386
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574504}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  5. NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:13:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 670a4fd7d5c89c8904f638edda72083e41e5d016

    Comments

    NetS13nServiceWorker: Add more info to traces in SWNavigationLoader
    
    Bug: 806658
    Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17
    Reviewed-on: https://chromium-review.googlesource.com/1134711
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574503}

    Changed files

    • content/browser/service_worker/service_worker_navigation_loader.cc
  6. [Android PageInfo] Refactor PageInfoController to enable testing

    Changed by Anita Woodruff - awdfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:05:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfb08c4ccef342639df17f6a423643df1784b767

    Comments

    [Android PageInfo] Refactor PageInfoController to enable testing
    
    - Extracted PermissionParamsListBuilder from PageInfoController
    to handle all the permission-related logic when displaying
    permissions in page info. This new class requires fewer
    hard-to-unit-test dependencies so its logic can now be tested.
    
    Bug: 691898
    Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4
    Reviewed-on: https://chromium-review.googlesource.com/1103564
    Commit-Queue: Anita Woodruff <awdf@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574502}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
  7. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc
  8. Change test to use full-path-for-testing attribute selector

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
  9. Add find bar icon to hosted app windows

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows
    
    This CL moves the find icon from LocationBarView into PageActionIconContainerView
    enabling the icon to appear in hosted app window title bars.
    
    This change also fixes the find icon getting nudged by
    crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.
    
    Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
    Before CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
    After CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1
    
    Bug: 788051, 814531
    Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
    Reviewed-on: https://chromium-review.googlesource.com/1054908
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h