Home | Search | chromium - Builders
Login

Builder Win10 FYI Exp Release (Intel HD 630) Build 1863 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision7bde1aec4c859fd39a039a59a98da4c8b51f6f4f
Got Revision7bde1aec4c859fd39a039a59a98da4c8b51f6f4f

Execution:

Steps and Logfiles:

Show:
  1. ( 680 ms ) setup_build
    running recipe: "chromium"
  2. ( 251 ms ) report builders
     
    running tester 'Win10 FYI Exp Release (Intel HD 630)' on master 'chromium.gpu.fyi'
  3. ( 6 secs ) taskkill
  4. ( 1 mins 24 secs ) bot_update
    [70GB/299GB used (23%)]
  5. ( 716 ms ) swarming.py --version
    0.13
  6. ( 21 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  8. ( 491 ms ) lookup builder GN args
     
    build_angle_gles1_conform_tests = true
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  9. ( 416 ms ) build directory
  10. ( 374 ms ) find isolated tests
  11. ( 4 secs ) angle_end2end_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:01:45.447234 (shard #1)
    Min shard duration: 0:01:32.562566 (shard #3)
  12. ( 1 secs ) angle_gles1_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:47.228033
  13. ( 4 secs ) angle_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:12.524748
  14. ( 1 secs ) angle_white_box_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 29s
  15. ( 2 mins 32 secs ) tab_capture_end2end_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:25.001246
  16. ( 2 mins 53 secs ) xr_browser_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:48.733844
  17. ( 1 secs ) gl_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 51s
  18. ( 2 secs ) gl_tests_passthrough on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 45s
  19. ( 1 secs ) gl_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 26s
  20. ( 1 secs ) gles2_conform_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:10.844599
  21. ( 1 secs ) gles2_conform_d3d9_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:01.614843
  22. ( 1 secs ) gles2_conform_gl_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:41.267729
  23. ( 3 secs ) gpu_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 47s
  24. ( 1 secs ) swiftshader_unittests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 23s
  25. ( 1 secs ) video_decode_accelerator_d3d11_unittest on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 36s
  26. ( 1 secs ) video_decode_accelerator_d3d9_unittest on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:06.112645
  27. ( 3 mins 32 secs ) context_lost_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:22.571182
    Total tests: 10
    * Passed: 10 (10 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 2 mins 13 secs ) depth_capture_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:10.377596
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 3 mins 8 secs ) gpu_process_launch_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:02.536912
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 2 mins 2 secs ) hardware_accelerated_feature_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:57.722931
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 2 mins 16 secs ) info_collection_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:11.623381
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 2 mins 7 secs ) maps_pixel_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:04.479361
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 7 mins 59 secs ) pixel_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:07:46.236724
    Total tests: 53
    * Passed: 53 (53 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 2 mins 51 secs ) screenshot_sync_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:47.215254
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 4 mins 7 secs ) trace_test on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:04:02.429710
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 10 mins 17 secs ) webgl2_conformance_d3d11_validating_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 18s (shard #19)
    Max shard duration: 0:10:02.481515 (shard #3)
    Min shard duration: 0:07:35.396613 (shard #11)
    Total tests: 2796
    * Passed: 2730 (2730 expected, 0 unexpected)
    * Skipped: 66 (66 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 10 mins 10 secs ) webgl2_conformance_gl_passthrough_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 10s (shard #19)
    Max shard duration: 0:09:51.115836 (shard #12)
    Min shard duration: 0:07:21.977808 (shard #7)
    Total tests: 2796
    * Passed: 2731 (2731 expected, 0 unexpected)
    * Skipped: 65 (65 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 11 mins 50 secs ) webgl2_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 0:03:03.037330 (shard #19)
    Max shard duration: 0:09:50.905307 (shard #11)
    Min shard duration: 0:07:16.890937 (shard #1)
    Total tests: 2796
    * Passed: 2732 (2732 expected, 0 unexpected)
    * Skipped: 64 (64 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 8 mins 35 secs ) webgl_conformance_d3d11_validating_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:08:19.123668 (shard #1)
    Min shard duration: 0:04:15.431091 (shard #0)
    Total tests: 932
    * Passed: 924 (924 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 8 mins 53 secs ) webgl_conformance_d3d9_passthrough_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:08:49.109227 (shard #1)
    Min shard duration: 0:03:52.279243 (shard #0)
    Total tests: 932
    * Passed: 924 (924 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 8 mins 3 secs ) webgl_conformance_d3d9_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:07:54.612776 (shard #1)
    Min shard duration: 0:03:55.294903 (shard #0)
    Total tests: 932
    * Passed: 921 (921 expected, 0 unexpected)
    * Skipped: 11 (11 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 8 mins 21 secs ) webgl_conformance_gl_passthrough_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:08:15.500337 (shard #1)
    Min shard duration: 0:04:06.236552 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  43. ( 7 mins 20 secs ) webgl_conformance_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:07:14.755382 (shard #1)
    Min shard duration: 0:04:34.760851 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  44. ( 21 mins 29 secs ) webgl_conformance_vulkan_passthrough_tests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:21:00.165724 (shard #1)
    Min shard duration: 0:09:01.829910 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  45. ( 219 ms ) Tests statistics
     
    Stats
    Total shards: 100
    Total runtime: 8:09:23.983000
     
  46. ( 629 ms ) process_dumps
  47. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm62-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541770857461701, "id": "8930329797325293136", "project": "chromium", "tags": ["builder:Win10 FYI Exp Release (Intel HD 630)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7bde1aec4c859fd39a039a59a98da4c8b51f6f4f", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win Builder", "parent_buildnumber:20298", "scheduler_invocation_id:9095759859418956752", "scheduler_job_id:chromium/Win10 FYI Exp Release (Intel HD 630)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 FYI Exp Release (Intel HD 630)" setup_build
buildnumber 1863 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "284f33439871e1ae2556d3ada34b5d1b75a4fb20" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "7bde1aec4c859fd39a039a59a98da4c8b51f6f4f" setup_build
parent_got_revision_cp "refs/heads/master@{#606814}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "6130e69e8e0758f2769a6172c79d32c87bc39464" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.284@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "7bde1aec4c859fd39a039a59a98da4c8b51f6f4f" setup_build
swarm_hashes {"angle_end2end_tests": "69f2d75cd58260ae508d97bc17816acc55223e0b", "angle_gles1_conformance_tests": "a936ba2c79b2fa83fbc36a0a431611c7ddee0eaf", "angle_perftests": "fb6566911926147ac0389fef8c95bd822c3229fb", "angle_unittests": "79991548906fc1d0ad2aeda5dbfb35602c0ace13", "angle_white_box_tests": "531c46280a677529179e9812767eeee7fcf0a05c", "browser_tests": "e4eb1bac2ce209ef538763abee1c5aa8f881acb4", "command_buffer_perftests": "96e85995958888c6d8edb2f8fa3905f90ffc6a50", "gl_tests": "55ca2877772976c4a554950d3a9a3cd8895273ec", "gl_unittests": "9e05c22503221d59dea524c52f9477a7ebf6338f", "gles2_conform_test": "5dce5bc9ddd2688391da0e0b1777364211e561c2", "gpu_unittests": "474c44bea6a530e0fcfaea2179620e4e5fb30872", "swiftshader_unittests": "4219fecaccfbe62a48fbecf50bf984bfc2f613d6", "telemetry_gpu_integration_test": "b79ae38e9165dd75184c1ac3f8ca6c2356fbae2f", "video_decode_accelerator_unittest": "5c438155346832e4c3f27f93b711f8f33d98a9e1"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "7bde1aec4c859fd39a039a59a98da4c8b51f6f4f" bot_update
got_revision_cp "refs/heads/master@{#606814}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "6130e69e8e0758f2769a6172c79d32c87bc39464" bot_update
got_v8_revision_cp "refs/heads/7.2.284@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  2. Michael Lippautz (mlippautzohnoyoudont@chromium.org)
  3. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  4. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  5. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  6. Boris Sazonov (bsazonovohnoyoudont@chromium.org)
  7. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  8. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  9. Colin Blundell (blundellohnoyoudont@chromium.org)
  10. Lukasz Suder (lsuderohnoyoudont@google.com)
  11. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  12. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  13. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  14. Clemens Arbesser (arbesserohnoyoudont@google.com)
  15. Benoît Lizé (lizebohnoyoudont@chromium.org)
  16. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  17. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  18. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  19. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)

Timing:

Create Friday, 09-Nov-18 13:40:57 UTC
Start Friday, 09-Nov-18 13:41:01 UTC
End Friday, 09-Nov-18 15:59:29 UTC
Pending 4 secs
Execution 2 hrs 18 mins

All Changes:

  1. Roll src-internal 73158cecda02..c458532c0628 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 13:29:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bde1aec4c859fd39a039a59a98da4c8b51f6f4f

    Comments

    Roll src-internal 73158cecda02..c458532c0628 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73158cecda02..c458532c0628
    
    
    Created with:
      gclient setdep -r src-internal@c458532c0628
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I8311db5f4432ad7184b609969b5a2ecd787fbe9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329041
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606814}

    Changed files

    • DEPS
  2. Revert "Enable unified garbage collections"

    Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c36eb8acab5820a2fcaefb9e856b698e3cc0ce52

    Comments

    Revert "Enable unified garbage collections"
    
    This reverts commit a8228cdc699831699180ecd3b327366305c830d2.
    
    Reason for revert: Reverting as we've cycled through the waterfalls and the other flag change on the content layer already got reverted.
    
    Original change's description:
    > Enable unified garbage collections
    > 
    > Enables unified heap garbage collection across V8 and Blink. The GC
    > computes a single transitive closure across V8's API boundary before
    > starting the separate sweepers.
    > 
    > Sheriffs: This is a dry-run of the feature and will be reverted after
    > cycling through the waterfall and performance bots.
    > 
    > Bug: 843903
    > Change-Id: I0d3e9fc76fa9b116f32d92a234c45afe11120cf9
    > Reviewed-on: https://chromium-review.googlesource.com/c/1290869
    > Reviewed-by: Hannes Payer <hpayer@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#605634}
    
    TBR=ulan@chromium.org,haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 843903
    Change-Id: I1d1f695431919864cb15dffe0d9b1e4ba85fd3c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329021
    Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606813}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  3. [perf] Add browse:media:youtube:2018 system_health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:09:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5ece11759649faaa791f155e7c88cc13c99d497

    Comments

    [perf] Add browse:media:youtube:2018 system_health story
    
    Due to many ads being loaded and certain requests will not work.
        [console:error:js]:       ~30
        [console:error:network]:  ~30
    
    Bug: 878390
    Change-Id: I3e09c9302514b1fb089d77b4671c59fb44afb22f
    Reviewed-on: https://chromium-review.googlesource.com/c/1296172
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606812}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_6b6bdda708.wprgo.sha1
    • tools/perf/page_sets/system_health/browsing_stories.py
  4. Disable AudioOutputDeviceTest.VerifyDataFlow.

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 13:01:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4dc1efff9f39f75768c64004fea6a83b7b38d71

    Comments

    Disable AudioOutputDeviceTest.VerifyDataFlow.
    
    Flakily fails like this:
    ../../media/audio/audio_output_device_unittest.cc:411: Failure
    Actual function call count doesn't match EXPECT_CALL(env.callback,
        Render(kDelay, env.time_stamp, kFramesSkipped, NotNull()))...
             Expected: to be called once
               Actual: never called - unsatisfied and active
    
    See for instance
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/
        Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30025
    
    Tbr: olka@chromium.org
    Bug: 903696
    Change-Id: I621eab844322e47a36cfa55ddf6c09c04d825266
    Reviewed-on: https://chromium-review.googlesource.com/c/1328987
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606811}

    Changed files

    • media/audio/audio_output_device_unittest.cc
  5. Revert "Reenable direct composition without video layers"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:58:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fb9951ce0f87e70b86cb5b12b4cca635341cbad

    Comments

    Revert "Reenable direct composition without video layers"
    
    This reverts commit eec86ff6c03b228b426a4553c89724d04e0a0f56.
    
    Reason for revert: Appears to break cc_unittests on the Linux CFI bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/11190
    
    Original change's description:
    > Reenable direct composition without video layers
    > 
    > Reenable direct composition surface on devices without hardware overlays
    > since it enables other power improvements like flip mode swap chain and
    > disabling DWM redirection surface.
    > 
    > To mitigate the original concerns about direct composition, this change
    > makes DCLayerTree lazy initialize the video context and processor when
    > a video layer is first used.  On devices that don't support hardware
    > overlays, the video context and processor will never be initialized.
    > 
    > Bug: 894675, 900702
    > Change-Id: I8c9d5b78718de2620ca177410d4916390e7cb219
    > Reviewed-on: https://chromium-review.googlesource.com/c/1318808
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606312}
    
    TBR=dcheng@chromium.org,zmo@chromium.org,sunnyps@chromium.org,piman@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 894675, 900702
    Change-Id: I094721159277c50d9061dfded252bbac1084977f
    Reviewed-on: https://chromium-review.googlesource.com/c/1328965
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606810}

    Changed files

    • content/browser/gpu/gpu_internals_ui.cc
    • content/renderer/render_thread_impl.cc
    • gpu/config/gpu_driver_bug_list.json
    • gpu/config/gpu_info.cc
    • gpu/config/gpu_info.h
    • gpu/config/gpu_util.cc
    • gpu/ipc/common/gpu_info.mojom
    • gpu/ipc/common/gpu_info_struct_traits.cc
    • gpu/ipc/common/gpu_info_struct_traits.h
    • gpu/ipc/common/struct_traits_unittest.cc
    • gpu/ipc/service/direct_composition_surface_win.cc
    • gpu/ipc/service/direct_composition_surface_win.h
    • gpu/ipc/service/gpu_init.cc
    • gpu/ipc/service/image_transport_surface_win.cc
    • ui/gl/gl_switches.cc
    • ui/gl/gl_switches.h
  6. [Android] Remove GmsCoreSyncListener

    Changed by Boris Sazonov - bsazonovohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:55:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c5f96267752a38d90b07932c438ca7354e92f3e3

    Comments

    [Android] Remove GmsCoreSyncListener
    
    This CL removes GmsCoreSyncListener class and some harness around it.
    This class was implemented for https://crbug.com/552106, but that
    feature was never finished. This CL also removes
    ProfileSyncService::GetCustomPassphraseKey that became unused.
    
    Bug: 903284
    Change-Id: I096b2ab74915d2ed93b4c4077902a1de9abb4cee
    Reviewed-on: https://chromium-review.googlesource.com/c/1326502
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606809}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/GmsCoreSyncListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/sync/GmsCoreSyncListenerTest.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  7. Revert "Fix a crash when switching to tablet mode in Unified Desktop mode"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:47:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f547d178e2b806007b88aa4c70ffe530de94f78

    Comments

    Revert "Fix a crash when switching to tablet mode in Unified Desktop mode"
    
    This reverts commit dcb55ce2871fe258d30386a85af754d496dfdb62.
    
    Reason for revert: Appears to cause crashes in LoginCursorTest.CursorHidden. See https://chromium-swarm.appspot.com/task?id=410f91874d359810&refresh=10&show_raw=1:
    BrowserTestBase received signal: Segmentation fault. Backtrace:
    #0 0x55c75309100f base::debug::StackTrace::StackTrace()
    #1 0x55c752aa8075 content::(anonymous namespace)::DumpStackTraceSignalHandler()
    #2 0x7f17e8b21cb0 <unknown>
    #3 0x55c751991a1d chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
    #4 0x55c751991c8e chromeos::OobeUIDialogDelegate::~OobeUIDialogDelegate()
    #5 0x55c7553a6063 views::WebDialogView::OnDialogClosed()
    #6 0x55c7553a5d92 views::WebDialogView::WindowClosing()
    #7 0x55c752f81eb0 views::Widget::OnNativeWidgetDestroying()
    #8 0x55c7548080ff views::DesktopWindowTreeHostMus::CloseNow()
    
    Original change's description:
    > Fix a crash when switching to tablet mode in Unified Desktop mode
    > 
    > 1) The Home Launcher used to use the wrong display ID when in
    >    Unified Desktop mode.
    > 2) If (1) is fixed, we hit https://crbug.com/902601. The captive
    >    portal dialog widget used to be leaked and never destroyed.
    > 3) If (2) is fixed, we crash on the first attempt to press the
    >    app list button. The reason is tablet mode triggers a switch
    >    to mirror mode. This switch happens asynchronously after the
    >    Home Launcher had already been created. Switching from Unified
    >    to mirror mode destroys the Unified host and the Home Launcher.
    >    That's why we need to ensure that the Home Launcher is
    >    recreated.
    > 
    > BUG=900956, 902601
    > TEST=Added a test that crashes without the fix.
    > 
    > Change-Id: If6eb9c2255dfa9d442aa115a3274db2d8a4110d7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325389
    > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    > Reviewed-by: Weidong Guo <weidongg@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606687}
    
    TBR=xiyuan@chromium.org,oshima@chromium.org,afakhry@chromium.org,jdufault@chromium.org,weidongg@chromium.org
    
    Change-Id: I2e0cacc2c29bbc44e8e8c9dfcb86fd8106c008ff
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 900956, 902601
    Reviewed-on: https://chromium-review.googlesource.com/c/1329004
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606808}

    Changed files

    • ash/app_list/app_list_controller_impl.cc
    • ash/app_list/app_list_controller_impl.h
    • ash/display/display_configuration_observer.cc
    • ash/display/display_manager_unittest.cc
    • chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
  8. Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget."

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:39:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b39a541429c5031a7a7d12d13ade6fd69a10356

    Comments

    Revert "Don't make a LayerTreeFrameSink for a non-visible RenderWidget."
    
    This reverts commit 68d8dbc019fd37659252e273ade868aac7a9d8ac.
    
    Reason for revert: Looks like it makes PrerenderBrowserTest.PrerenderInfiniteLoop according to FindIt. 
    
    ../../chrome/browser/prerender/prerender_browsertest.cc:1721: Failure
    Expected equality of these values:
      1U
        Which is: 1
      GetLinkPrerenderCount()
        Which is: 2
    
    Original change's description:
    > Don't make a LayerTreeFrameSink for a non-visible RenderWidget.
    > 
    > Importantly, non-visible RenderWidgets include swapped out RenderWidgets
    > which are zombies, without a frame, and which should not be used.
    > 
    > This can happen if the RenderWidget swap out races with the posted task
    > from the compositor to make a LayerTreeFrameSink. When swapping out, the
    > compositor would be marked as not-visible, which would stop it from
    > making such requests, but one could already be in flight.
    > 
    > In the other case, honoring the request for a non-visible compositor is
    > more benign, but we can delay it until the compositor is actually
    > visible again. This means if a context is lost, backgrounded tabs would
    > not all attempt to reconnect to the Gpu process at once.
    > 
    > This is a better followup for the hacky
    > https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which
    > was meant only for merge to a release branch. It reverts that change as
    > part of this one.
    > 
    > R=​piman@chromium.org
    > 
    > Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7
    > Bug: 896836, 419087
    > Reviewed-on: https://chromium-review.googlesource.com/c/1292714
    > Commit-Queue: danakj <danakj@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606655}
    
    TBR=danakj@chromium.org,dcheng@chromium.org,piman@chromium.org
    
    Change-Id: I65238aba0abdb6c9192e9f3cb3691f8dd89b3ea5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 896836, 419087, 903696
    Reviewed-on: https://chromium-review.googlesource.com/c/1329003
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606807}

    Changed files

    • content/renderer/gpu/layer_tree_view.cc
    • content/renderer/gpu/layer_tree_view_delegate.h
    • content/renderer/input/widget_input_handler_impl.cc
    • content/renderer/input/widget_input_handler_manager.cc
    • content/renderer/render_frame_impl.cc
    • content/renderer/render_view_impl.cc
    • content/renderer/render_widget.cc
    • content/renderer/render_widget.h
    • content/test/stub_layer_tree_view_delegate.cc
    • content/test/stub_layer_tree_view_delegate.h
    • third_party/blink/renderer/core/exported/web_view_impl.cc
  9. Change Identity Service impl to depend only on signin internals

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24599fc67d36d611bdde3dc74d2f069491c7b9ca

    Comments

    Change Identity Service impl to depend only on signin internals
    
    Now that a distinct GN target exists just for the code backing
    IdentityManager/Identity Service, change the Identity Service
    implementation to depend only on that target. The change worked right
    out of the box -- good validation of the initial split.
    
    Bug: 901859
    Change-Id: I9b04ef952c34d9e9c0efcf137c55d41c8d616aff
    Reviewed-on: https://chromium-review.googlesource.com/c/1323649
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606806}

    Changed files

    • services/identity/BUILD.gn
  10. [Autofill Assistant] Adds loading animation for details.

    Changed by Lukasz Suder - lsuderohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 12:25:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 26202817850c96ec358bca6e4af023627108b2a7

    Comments

    [Autofill Assistant] Adds loading animation for details.
    
    Bug: 806868
    Change-Id: Ic6cb7c2450e41e6d4555e9950b15866a7167747d
    Reviewed-on: https://chromium-review.googlesource.com/c/1323651
    Commit-Queue: Lukasz Suder <lsuder@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606805}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
  11. Revert "Reland^4 "[blink] Control ScriptStreamer with ScriptResource""

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:20:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43673375d85dfc8257c262cab39b6d62d7a81cfe

    Comments

    Revert "Reland^4 "[blink] Control ScriptStreamer with ScriptResource""
    
    This reverts commit aaeff5e6358a4b69fe1c92d30ffa04a703690879.
    
    Reason for revert: Findit thinks this CL makes delaying_onload_link_preload_after_discovery.html flaky with 70% confidence. Let's give it a shot and see if this fixes the flaking. Sorry, and let's hope the 5th reland goes better!
    
    Original change's description:
    > Reland^4 "[blink] Control ScriptStreamer with ScriptResource"
    > 
    > This is a reland of 31bcf8aa5ab66f390b207bb0a712ccb5cefe8e11
    > which was a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4,
    > which was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7,
    > which was a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
    > 
    > Relanding with no changes, seems that this wasn't the cause of
    > https://crbug.com/902832 after all.
    > 
    > Original change's description:
    > > Reland^3 "[blink] Control ScriptStreamer with ScriptResource"
    > >
    > > This is a reland of 5528336d71c1ec02d5b6e8f3224755a9cfb20de4, which
    > > was a reland of dd9df78ccc1e1ac79a5657966a264562c6d03fb7, which was
    > > a reland of 7bd9163502462762e58d8010577dbf36aeef6c13.
    > >
    > > VR tests have been properly deflaked in https://crrev.com/c/1319715, this
    > > is otherwise unchanged.
    > >
    > > Original change's description:
    > > > Reland "Reland "[blink] Control ScriptStreamer with ScriptResource""
    > > >
    > > > This reverts commit c564235ff692fe0b3d926152748feb7902e8a800.
    > > >
    > > > No changes from the original, VR flakes are caused by issues with
    > > > loadUrl and have been deflaked (see 894796 for details)
    > > >
    > > > Original change's description:
    > > > > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource""
    > > > >
    > > > > This reverts commit dd9df78ccc1e1ac79a5657966a264562c6d03fb7.
    > > > >
    > > > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796)
    > > > >
    > > > > Original change's description:
    > > > > > Reland "[blink] Control ScriptStreamer with ScriptResource"
    > > > > >
    > > > > > This is a reland of 7bd9163502462762e58d8010577dbf36aeef6c13
    > > > > >
    > > > > > No changes from the original, revert reason is fixed with
    > > > > > https://chromium-review.googlesource.com/c/1283037
    > > > > >
    > > > > > Original change's description:
    > > > > > > [blink] Control ScriptStreamer with ScriptResource
    > > > > > >
    > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to
    > > > > > > ScriptResource. In the future, this will allow us to start streaming
    > > > > > > a ScriptResource before the ClassicPendingScript is available, e.g on
    > > > > > > preload.
    > > > > > >
    > > > > > > The ClassicPendingScript now only sends one "finished" callback, from
    > > > > > > ScriptResource. This callback is either when the streaming completes,
    > > > > > > or when there is no streaming and the ClassicPendingScript has told
    > > > > > > the ScriptResource that it doesn't intend to start streaming. In the
    > > > > > > long run, we want all scripts to go through the streaming interface,
    > > > > > > and we want ScriptResource to control when streaming starts, so the
    > > > > > > "no more streaming" call will disappear -- however it is necessary to
    > > > > > > maintain the current behaviour, and be able to control it with a
    > > > > > > runtime flag.
    > > > > > >
    > > > > > > Bug: chromium:865098
    > > > > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    > > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > > > > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > > > > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > > > > > > Cr-Commit-Position: refs/heads/master@{#599148}
    > > > > >
    > > > > > TBR=kouhei@chromium.org,kinuko@chromium.org
    > > > > >
    > > > > > Bug: chromium:865098
    > > > > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c
    > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450
    > > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > > > > > Cr-Commit-Position: refs/heads/master@{#601143}
    > > > >
    > > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    > > > >
    > > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > >
    > > > > Bug: chromium:865098
    > > > > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1297138
    > > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#602310}
    > > >
    > > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    > > >
    > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > >
    > > > Bug: chromium:865098
    > > > Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/1317566
    > > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#605295}
    > >
    > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
    > >
    > > Bug: chromium:865098
    > > Change-Id: I8d6101f51eb33b19ec332a06a310172b371b7fa4
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1318923
    > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#605815}
    > 
    > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org
    > 
    > Bug: chromium:865098
    > Change-Id: I73854c4d524ab0cc8e08ef512c10334f0ab5ead4
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325921
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606448}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: I6d2bbe9085376921d819c015bf37832efe8d2d11
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098, chromium:903732
    Reviewed-on: https://chromium-review.googlesource.com/c/1328966
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606804}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  12. Revert "[autofill] add iOS helpers to get aria-label and aria-description"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 12:12:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62dd51a1163937c255844b681c661a78d387b4b8

    Comments

    Revert "[autofill] add iOS helpers to get aria-label and aria-description"
    
    This reverts commit 95c8ebc6e5b760aa85692b012f448c4fa10d53d6.
    
    Reason for revert: Breaks FillJsTest: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/1004
    
    JavaScript error: TypeError: __gCrWeb.fill.getAriaDescription is not a function.
    
    Original change's description:
    > [autofill] add iOS helpers to get aria-label and aria-description
    > 
    > This CL adds the getAriaLabel() and getAriaDescription() helper
    > functions to the __GCrWeb.fill "namespace". These functions return
    > the ARIA label and description strings associated with an element.
    > 
    > The ARIA Label is the text referenced by one or more containing element
    > ids in the labelled elements aria-labelledby attribute, or the value
    > of the element's aria-label attribute, with preference given to the
    > aria-labelledby attribute. For example:
    > 
    >     <div id='foo-label'>Label for Foo</div>
    >     <input name='foo' aria-labelledby='foo-label'>
    >     <input name='bar' aria-label='Label for Bar'>
    > 
    > The aria-description is similar to aria-labelledby. For example:
    > 
    >     <div id='foo-description'>Long descriptive text for Foo</div>
    >     <input name='foo' aria-describedby='foo-descrition'>
    > 
    > Bug: 896719
    > Change-Id: I300b84298fc20e1b86474f60d08cdd1c9569036b
    > Reviewed-on: https://chromium-review.googlesource.com/c/1325032
    > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    > Commit-Queue: Roger McFarlane <rogerm@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606534}
    
    TBR=rogerm@chromium.org,sebsg@chromium.org,mahmadi@chromium.org
    
    Change-Id: I00eb534e6639c829f6ed5b312406ce51ba2aa429
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 896719
    Reviewed-on: https://chromium-review.googlesource.com/c/1329002
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606803}

    Changed files

    • components/autofill/ios/form_util/fill_js_unittest.mm
    • components/autofill/ios/form_util/resources/fill.js
  13. Roll src-internal 0ee41cbd4bf0..73158cecda02 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 12:01:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b80c161e76af7ca42437617fa5424948d0f207f

    Comments

    Roll src-internal 0ee41cbd4bf0..73158cecda02 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ee41cbd4bf0..73158cecda02
    
    
    Created with:
      gclient setdep -r src-internal@73158cecda02
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ie142f038c6f81038911815c552aa5de603838b62
    Reviewed-on: https://chromium-review.googlesource.com/c/1328730
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606802}

    Changed files

    • DEPS
  14. [Autofill Assistant] All messages to the server now contain the active field trials of the client as part of the ClientContextProto.

    Changed by Clemens Arbesser - arbesserohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 11:58:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 085bbd72774018acd197bab9921b470a42725408

    Comments

    [Autofill Assistant] All messages to the server now contain the active field trials of the client as part of the ClientContextProto.
    
    This will allow the server to log the field trial state, which in turn will allow us to analyze how user behavior changes with respect to the active field trials. Serializing all active field trials makes this easier to maintain at the cost of some additional message overhead and log storage. For each active field trial, the trial name and the name of the randomly selected trial group are sent.
    
    Bug: 806868
    Change-Id: I0417b3d548f36ca8c98c80182ec314e8bb20eba0
    Reviewed-on: https://chromium-review.googlesource.com/c/1326014
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Commit-Queue: Clemens Arbesser <arbesser@google.com>
    Cr-Commit-Position: refs/heads/master@{#606801}

    Changed files

    • components/autofill_assistant/browser/protocol_utils.cc
    • components/autofill_assistant/browser/service.proto
  15. blink/bindings: Record compressed size and savings for ParkableString.

    Changed by Benoît Lizé - lizebohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 11:53:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d0eed3db77a5e6167b5ebbf6ecb3710790272a

    Comments

    blink/bindings: Record compressed size and savings for ParkableString.
    
    Records the total size of parkable strings, the total compressed size, the
    average compression ratio and the total savings from compression. As these
    values are correlated, separate histograms are required.
    
    The recording happens 30s after compression tasks are kicked off, provided that
    the renderer's state (foreground/background) hasn't changed in the meantime, to
    help with the interpretation of results. 30s is chosen as it's long enough for
    compression to be done, and short enough to minimize the risk of the renderer
    getting killed and/or moving back to foreground.
    
    Also remove an outdated comment in parkable_string.cc.
    
    Bug: 877044
    Change-Id: Ic8cf4a410d182387ffd1d37b23d84b5426d227cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1323549
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606800}

    Changed files

    • third_party/blink/renderer/platform/bindings/parkable_string.h
    • third_party/blink/renderer/platform/bindings/parkable_string_manager.cc
    • third_party/blink/renderer/platform/bindings/parkable_string_manager.h
    • third_party/blink/renderer/platform/bindings/parkable_string_test.cc
    • tools/metrics/histograms/histograms.xml
  16. Import wpt@eed621bc2f995bced9481df2cead4c4632c72cdd

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:53:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 80ae982b6309cb7b9a9e8320524ef384deeed972

    Comments

    Import wpt@eed621bc2f995bced9481df2cead4c4632c72cdd
    
    Using wpt-import in Chromium f038ea3445a10c7f8116f52afe7add030b77d243.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    kojii@chromium.org:
      external/wpt/css/css-text/overflow-wrap
    
    NOAUTOREVERT=true
    TBR=foolip
    
    No-Export: true
    Change-Id: I89a829c659b10bbbdfb07c86d8e997b9e9edbc08
    Reviewed-on: https://chromium-review.googlesource.com/c/1328711
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606799}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any.js
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/css/css-text/overflow-wrap/overflow-wrap-min-content-size-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-text/overflow-wrap/overflow-wrap-min-content-size-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-text/overflow-wrap/overflow-wrap-min-content-size-003.html
  17. Update V8 to version 7.2.284.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:52:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5cb8a569d871afd0b4ac8238e3edbe4b81fc6791

    Comments

    Update V8 to version 7.2.284.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c465c5ea..6130e69e
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ic5c1b7a01e1e1fb5cdc8f73ba76ff53f7d97c3bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1328712
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606798}

    Changed files

    • DEPS
  18. Roll src/third_party/perfetto 365e59b9d0c3..486203eeaffd (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:52:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e84fb354691adf1a8d49c2be3c5758718a9f8bb

    Comments

    Roll src/third_party/perfetto 365e59b9d0c3..486203eeaffd (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/365e59b9d0c3..486203eeaffd
    
    
    git log 365e59b9d0c3..486203eeaffd --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 hjd@google.com Merge "perfetto_cmd: Teach perfetto_cmd to parse pbtxt configs"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@486203eeaffd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: If1aa1235b1bf32d44d939c356c4b9b8d8bb590ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1328728
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606797}

    Changed files

    • DEPS
  19. Revert "media/gpu/VEA unittest: Test DMABuf-backed input buffers"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:31:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2ebf50601155e617b5966d1e585734cb4ffaade

    Comments

    Revert "media/gpu/VEA unittest: Test DMABuf-backed input buffers"
    
    This reverts commit c4e9ae1b9abc167c177d659dbcc3d1f794e93064.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 606788 as the
    culprit for failures in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M0ZTlhZTFiOWFiYzE2N2MxNzdkNjU5ZGJjYzNkMWY3OTRlOTMwNjQM
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-rel/5951
    
    Sample Failed Step: compile
    
    Original change's description:
    > media/gpu/VEA unittest: Test DMABuf-backed input buffers
    > 
    > This adds the command line option, --natvie_input, that VEA unittest passes
    > DMABuf-backed video frame to VEA.
    > DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    > Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    > also makes VEA unittest dependent on Ozone.
    > 
    > BUG=chromium:895230
    > TEST=VEA unittest on eve w/wo --native_input
    > 
    > Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc
    > Reviewed-on: https://chromium-review.googlesource.com/c/1295636
    > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    > Reviewed-by: Pawel Osciak <posciak@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606788}
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    BUG=chromium:895230
    
    Change-Id: I75c80e914ec2493c26b34ddb4644e53099ba6bf5
    Reviewed-on: https://chromium-review.googlesource.com/c/1328713
    Cr-Commit-Position: refs/heads/master@{#606796}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc