Home | Search | chromium - Builders
Login

Builder Win10 FYI Debug (NVIDIA) Build 2016 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisiona2ebf50601155e617b5966d1e585734cb4ffaade
Got Revisiona2ebf50601155e617b5966d1e585734cb4ffaade

Execution:

Steps and Logfiles:

Show:
  1. ( 615 ms ) setup_build
    running recipe: "chromium"
  2. ( 261 ms ) report builders
     
    running tester 'Win10 FYI Debug (NVIDIA)' on master 'chromium.gpu.fyi'
  3. ( 5 secs ) taskkill
  4. ( 1 mins 15 secs ) bot_update
    [70GB/299GB used (23%)]
  5. ( 1 secs ) swarming.py --version
    0.13
  6. ( 17 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.gpu.fyi.json
  8. ( 446 ms ) lookup builder GN args
     
    build_angle_gles1_conform_tests = true
    ffmpeg_branding = "Chrome"
    internal_gles2_conform_tests = true
    is_component_build = true
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
  9. ( 932 ms ) build directory
  10. ( 342 ms ) find isolated tests
  11. ( 5 secs ) angle_end2end_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:04:26.520645 (shard #3)
    Min shard duration: 0:02:53.206063 (shard #1)
  12. ( 1 secs ) angle_gles1_conformance_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:31.709074
  13. ( 4 secs ) angle_unittests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:57.923668
  14. ( 1 secs ) angle_white_box_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 32s
  15. ( 3 mins 23 secs ) xr_browser_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:21.094162
  16. ( 2 secs ) gl_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 55s
  17. ( 2 secs ) gl_tests_passthrough on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 50s
  18. ( 1 secs ) gl_unittests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 32s
  19. ( 2 mins 25 secs ) gles2_conform_test on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:21.019910
  20. ( 2 mins 50 secs ) gles2_conform_d3d9_test on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:46.487920
  21. ( 2 mins 32 secs ) gles2_conform_gl_test on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:28.457539
  22. ( 1 mins 7 secs ) gpu_unittests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:01:03.085052
  23. ( 1 secs ) swiftshader_unittests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 26s
  24. ( 1 secs ) video_decode_accelerator_d3d11_unittest on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 36s
  25. ( 37 secs ) video_decode_accelerator_d3d9_unittest on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 34s
  26. ( 43 secs ) video_decode_accelerator_gl_unittest on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 41s
  27. ( 4 mins 46 secs ) context_lost_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:04:39.703673
    Total tests: 10
    * Passed: 9 (9 expected, 0 unexpected)
    * Skipped: 1 (1 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 2 mins 54 secs ) depth_capture_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:53.210702
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 2 mins 56 secs ) gpu_process_launch_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:49.101197
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 2 mins 3 secs ) hardware_accelerated_feature_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:02.660621
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 3 mins 1 secs ) info_collection_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:57.306132
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 3 mins 30 secs ) maps_pixel_test on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:03:25.024389
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 6 mins 20 secs ) pixel_test on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:06:16.902363
    Total tests: 53
    * Passed: 53 (53 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 2 mins 16 secs ) screenshot_sync_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:02:13.609931
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  35. ( 4 mins 24 secs ) trace_test on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Shard duration: 0:04:16.777933
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 25 mins 23 secs ) webgl_conformance_d3d11_validating_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:25:07.476538 (shard #1)
    Min shard duration: 0:08:57.755974 (shard #0)
    Total tests: 932
    * Passed: 924 (924 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 21 mins 24 secs ) webgl_conformance_d3d9_passthrough_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:21:12.829123 (shard #1)
    Min shard duration: 0:08:01.807818 (shard #0)
    Total tests: 932
    * Passed: 924 (924 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  38. ( 22 mins 7 secs ) webgl_conformance_d3d9_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:21:50.886229 (shard #1)
    Min shard duration: 0:07:16.889845 (shard #0)
    Total tests: 932
    * Passed: 921 (921 expected, 0 unexpected)
    * Skipped: 11 (11 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  39. ( 30 mins 57 secs ) webgl_conformance_gl_passthrough_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:30:48.324165 (shard #1)
    Min shard duration: 0:13:02.491860 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  40. ( 21 mins 52 secs ) webgl_conformance_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:21:35.179425 (shard #1)
    Min shard duration: 0:08:21.398516 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  41. ( 44 mins 7 secs ) webgl_conformance_vulkan_passthrough_tests on NVIDIA GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max shard duration: 0:43:47.487995 (shard #1)
    Min shard duration: 0:24:44.186068 (shard #0)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 219 ms ) Tests statistics
     
    Stats
    Total shards: 40
    Total runtime: 4:18:26.826001
     
  43. ( 639 ms ) process_dumps
  44. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm757-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541764199997778, "id": "8930336778182342912", "project": "chromium", "tags": ["builder:Win10 FYI Debug (NVIDIA)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/a2ebf50601155e617b5966d1e585734cb4ffaade", "gitiles_ref:refs/heads/master", "parent_buildername:GPU FYI Win Builder (dbg)", "parent_buildnumber:15781", "scheduler_invocation_id:9095766840546034688", "scheduler_job_id:chromium/Win10 FYI Debug (NVIDIA)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win10 FYI Debug (NVIDIA)" setup_build
buildnumber 2016 setup_build
mastername "chromium.gpu.fyi" setup_build
parent_buildername "GPU FYI Win Builder (dbg)" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "284f33439871e1ae2556d3ada34b5d1b75a4fb20" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "a2ebf50601155e617b5966d1e585734cb4ffaade" setup_build
parent_got_revision_cp "refs/heads/master@{#606796}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "c465c5ea7f6c2b562a1b537adf46673fea7a8b8c" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.283@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "a2ebf50601155e617b5966d1e585734cb4ffaade" setup_build
swarm_hashes {"angle_end2end_tests": "64b6716129b4d92bd77a3731f371982a167c1af7", "angle_gles1_conformance_tests": "3405a9877934d9066276ccafa3b46cea48a7b2e2", "angle_unittests": "d5d29550e91d510ffc02c91cfa712a2e00566bc9", "angle_white_box_tests": "aaf56222219ba4ad07fd4746706341957a5de1ef", "browser_tests": "57e1fec1eb5d60ca5837b05bbdedeccf394648fa", "gl_tests": "c7227e011db1b4599efb8c35debe21072169fc14", "gl_unittests": "4bd42b4b3b911aed01c278b4464f49b66d6022b4", "gles2_conform_test": "b666db9bc277acd2fb9b6f836e191c533b3934b9", "gpu_unittests": "563fb70d39d31a2744774c51f07190b348a3ffb8", "swiftshader_unittests": "8bcd7865776021cb6d9750d3a4a42b213afaeeec", "telemetry_gpu_integration_test": "976ea670dfba1e77177496e6ff701ea80c4d9f30", "video_decode_accelerator_unittest": "a42ed20a1a028788a210bf2a4475fb4fe5d3c179"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "a2ebf50601155e617b5966d1e585734cb4ffaade" bot_update
got_revision_cp "refs/heads/master@{#606796}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "c465c5ea7f6c2b562a1b537adf46673fea7a8b8c" bot_update
got_v8_revision_cp "refs/heads/7.2.283@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  2. Sheng-Hao Tsao (shenghaoohnoyoudont@google.com)
  3. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  4. Yi Su (mrsuyiohnoyoudont@chromium.org)
  5. Arthur Sonzogni (arthursonzogniohnoyoudont@chromium.org)
  6. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  7. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  8. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  9. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  10. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  11. Koji Ishii (kojiiohnoyoudont@chromium.org)
  12. Balazs Engedy (engedyohnoyoudont@chromium.org)
  13. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  14. Colin Blundell (blundellohnoyoudont@chromium.org)
  15. 3su6n15k.default@developer.gserviceaccount.com (3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com)
  16. Balazs Engedy (engedyohnoyoudont@chromium.org)
  17. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  18. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  19. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  20. Peng Huang (penghuangohnoyoudont@chromium.org)
  21. Yi Su (mrsuyiohnoyoudont@chromium.org)
  22. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  23. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  24. David Jean (djeanohnoyoudont@google.com)
  25. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  26. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  27. Jia (jiamengohnoyoudont@chromium.org)
  28. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  29. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  30. Nick Harper (nharperohnoyoudont@chromium.org)
  31. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  32. Jia (jiamengohnoyoudont@chromium.org)
  33. Rakina Zata Amni (rakinaohnoyoudont@chromium.org)
  34. Marcin Wiacek (marcinohnoyoudont@mwiacek.com)

Timing:

Create Friday, 09-Nov-18 11:49:59 UTC
Start Friday, 09-Nov-18 11:50:04 UTC
End Friday, 09-Nov-18 15:28:09 UTC
Pending 4 secs
Execution 3 hrs 38 mins

All Changes:

  1. Revert "media/gpu/VEA unittest: Test DMABuf-backed input buffers"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 09-Nov-18 11:31:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2ebf50601155e617b5966d1e585734cb4ffaade

    Comments

    Revert "media/gpu/VEA unittest: Test DMABuf-backed input buffers"
    
    This reverts commit c4e9ae1b9abc167c177d659dbcc3d1f794e93064.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 606788 as the
    culprit for failures in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M0ZTlhZTFiOWFiYzE2N2MxNzdkNjU5ZGJjYzNkMWY3OTRlOTMwNjQM
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win32-rel/5951
    
    Sample Failed Step: compile
    
    Original change's description:
    > media/gpu/VEA unittest: Test DMABuf-backed input buffers
    > 
    > This adds the command line option, --natvie_input, that VEA unittest passes
    > DMABuf-backed video frame to VEA.
    > DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    > Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    > also makes VEA unittest dependent on Ozone.
    > 
    > BUG=chromium:895230
    > TEST=VEA unittest on eve w/wo --native_input
    > 
    > Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc
    > Reviewed-on: https://chromium-review.googlesource.com/c/1295636
    > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    > Reviewed-by: Pawel Osciak <posciak@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606788}
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    BUG=chromium:895230
    
    Change-Id: I75c80e914ec2493c26b34ddb4644e53099ba6bf5
    Reviewed-on: https://chromium-review.googlesource.com/c/1328713
    Cr-Commit-Position: refs/heads/master@{#606796}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  2. Only open GCA if ARC is P or above

    Changed by Sheng-Hao Tsao - shenghaoohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 10:59:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c028d7085fdc469ffdf4efec3f9ae8d22d1e3640

    Comments

    Only open GCA if ARC is P or above
    
    This CL changes the consolidated camera app icon logic so that it
    launches GCA/GCA migration app only if ARC is P or above. This is to
    address 2 problems:
    
    1. Android N and below do not support external cameras. We would like
    users to use CCA so that they can still utilize external cameras.
    2. Managed users in Android N still have the problem where GCA could be
    stripped out.
    
    Bug: b:118860552,chromium:896140
    Test: Used N devices (caroline) with google.com account and verified
    that CCA is opened.
    
    Change-Id: I7836d2b4256856028901e5e542f460e7107fc8db
    Reviewed-on: https://chromium-review.googlesource.com/c/1316982
    Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606795}

    Changed files

    • chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
  3. [Autofill Assistant] Checkbox for terms acceptance.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 652ddcf5b36955638fa64b013c88c0dd2f939fd8

    Comments

    [Autofill Assistant] Checkbox for terms acceptance.
    
    This patch introduces a checkbox in the Autofill Assistant payment request UI.
    The state of which is communicated in the processed action results to
    the backend.
    
    This logic only exists on the Java side and is opaquely passed through
    the c++ layer.
    
    Issue: b/117920169
    Screenshot: https://screenshot.googleplex.com/iiHvY18nLqn.png
    
    Bug: 806868
    Change-Id: Ica17176c4cac695c126d1d5695a8b7e5a31020e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1316770
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606794}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
    • components/autofill_assistant/browser/payment_information.h
    • components/autofill_assistant/browser/service.proto
    • components/autofill_assistant_strings.grdp
  4. Change feature flag of Custom Search Engine to be enabled by default.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:53:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fbf09d888ad3453558caf7ba438acf381860d8a

    Comments

    Change feature flag of Custom Search Engine to be enabled by default.
    
    The feature of Custom Search Engine is nearly finished and ready to be
    tested. Chnage the feature flag to be enabled by default.
    
    Bug: 433824
    Change-Id: Ied1d61b1df73bd8ceee89a2088e3e53418cbf856
    Reviewed-on: https://chromium-review.googlesource.com/c/1326002
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606793}

    Changed files

    • ios/chrome/browser/search_engines/feature_flags.cc
  5. WebRequestProxyingURLLoader: Close the current loader before internal redirect.

    Changed by Arthur Sonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4d3cf41c0598cf64570d293b73399c0f82ba7ccd

    Comments

    WebRequestProxyingURLLoader: Close the current loader before internal redirect.
    
    Please see the explanation here:
    https://bugs.chromium.org/p/chromium/issues/detail?id=882661#c72
    
    Generating a fake internal redirect causes conflicts with what the
    current URLLoader is doing. The latter doesn't know anything about the
    redirect. To work properly, the current URLLoader must be destroyed
    first. The current code automatically handles creating a new
    URLLoader after FollowRedirect().
    
    Bug: 882661
    Change-Id: Ib17dc2f29a2c63da735794b4792ef7805e7dbc58
    Reviewed-on: https://chromium-review.googlesource.com/c/1326481
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606792}

    Changed files

    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
  6. Support ::placeholder after ::slotted().

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:48:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cd41aa340d600b3c1f1725d94c2e06e11635531

    Comments

    Support ::placeholder after ::slotted().
    
    Tree-abiding pseudo elements are allowed after ::slotted() according to
    css-scoping-1. According to css-pseudo-4 they are ::before, ::after,
    ::marker, and ::placeholder. We already allowed ::before and ::after. We
    do not support ::marker. This CL allows ::placeholder.
    
    TEST=external/wpt/css/css-scoping/slotted-parsing.html
    TEST=external/wpt/css/css-scoping/slotted-placeholder.html
    
    Bug: 902518
    Change-Id: I963fa93e68c8fbd33fc8090e930be9a00f3c9bd4
    Reviewed-on: https://chromium-review.googlesource.com/c/1323049
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Fergal Daly <fergal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606791}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/css/css-scoping/slotted-parsing-expected.txt
    • third_party/blink/renderer/core/css/css_selector.cc
    • third_party/blink/renderer/core/css/css_selector.h
    • third_party/blink/renderer/core/css/parser/css_parser_selector.h
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
  7. Roll src/third_party/skia 22b0ec4f83aa..88e15bdaf539 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:47:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f21161ed54556a4f278ed78747e7f96f4ad924d3

    Comments

    Roll src/third_party/skia 22b0ec4f83aa..88e15bdaf539 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/22b0ec4f83aa..88e15bdaf539
    
    
    git log 22b0ec4f83aa..88e15bdaf539 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
    2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d856ca48f425..5d2dfa46c05c (2 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@88e15bdaf539
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I669e2dcceb60198f833772e058db4e4ffd2de923
    Reviewed-on: https://chromium-review.googlesource.com/c/1328723
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606790}

    Changed files

    • DEPS
  8. Roll src-internal 53aa50a0dced..0ee41cbd4bf0 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:45:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8de008a2a6f8d8eaec1b095550660cb5322551e9

    Comments

    Roll src-internal 53aa50a0dced..0ee41cbd4bf0 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53aa50a0dced..0ee41cbd4bf0
    
    
    Created with:
      gclient setdep -r src-internal@0ee41cbd4bf0
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I97a39edb26a9fcecef541f317a1788d833f9fa14
    Reviewed-on: https://chromium-review.googlesource.com/c/1328727
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606789}

    Changed files

    • DEPS
  9. media/gpu/VEA unittest: Test DMABuf-backed input buffers

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:41:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c4e9ae1b9abc167c177d659dbcc3d1f794e93064

    Comments

    media/gpu/VEA unittest: Test DMABuf-backed input buffers
    
    This adds the command line option, --natvie_input, that VEA unittest passes
    DMABuf-backed video frame to VEA.
    DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    also makes VEA unittest dependent on Ozone.
    
    BUG=chromium:895230
    TEST=VEA unittest on eve w/wo --native_input
    
    Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1295636
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606788}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  10. Fix declaration of override method in IdentityManagerObserverBridge

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 10:36:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6586665e93e9211f934364c00eee32433027df9

    Comments

    Fix declaration of override method in IdentityManagerObserverBridge
    
    IdentityManager::OnRefreshTokenRemovedForAccount() expects as a first
    parameter a "const std::string&" instead of a "const AccountInfo&",
    so this patch fixes it to prevent build failures when using this API
    because of OnRefreshTokenRemovedForAccount(const AccountInfo&) not
    being a valid override for the virtual method declared.
    
    Bug: 903391
    Change-Id: I46cd6778240a40af6863ca7fd3b8d9a88e735fde
    Reviewed-on: https://chromium-review.googlesource.com/c/1327161
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#606787}

    Changed files

    • services/identity/public/objc/identity_manager_observer_bridge.h
    • services/identity/public/objc/identity_manager_observer_bridge.mm
  11. Reland "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow"

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:35:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision de3b8c8dbf530a94a15e660ecb2b9cd80a7f9843

    Comments

    Reland "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow"
    
    This is a reland of b43c6fca4349b7f2ff53b41926f5d7cb42ee4e0f
    
    The original CL had moved a call to ToString() to within
    DCHECK, because the result is used only by DCHECK. But the
    ToString() has a side effect that must be performed.
    
    Because of the change, this CL breaks if DCHECK is not
    enabled. Unfortunately, no build configs in trybots and
    CQs have DCHECK disabled.
    
    Reverted the change, and added TODO to clean it up.
    
    Original change's description:
    > Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow
    >
    > This patch allows computing NGOffsetMapping for legacy inline
    > formatting context.
    >
    > For an experimental project "Invisible DOM"[1][2] to support
    > the find-in-page feature, it is needed to compute the text
    > content with whitespace collapsing applied, along with the
    > mapping to the DOM offset. This patch adds an API to compute
    > NGOffsetMapping even when the LayoutBlockFlow is not laid out
    > by LayoutNG for that purpose.
    >
    > Note that the project is still in the early phase. We may
    > revisit the design as it moves forward.
    >
    > [1] https://github.com/rakina/searchable-invisible-dom
    > [2] https://www.chromestatus.com/feature/5105291213406208
    >
    > Bug: 636993, 873057
    > Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882
    > Reviewed-on: https://chromium-review.googlesource.com/c/1322184
    > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    > Reviewed-by: Emil A Eklund <eae@chromium.org>
    > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    > Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
    > Commit-Queue: Koji Ishii <kojii@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606292}
    
    TBR=yoshin@chromium.org, eae@chromium.org, xiaochengh@chromium.org, rakina@chromium.org
    
    Bug: 636993, 873057
    Change-Id: I8a29073fb18a1349d758d37033e6b046a54d5beb
    Reviewed-on: https://chromium-review.googlesource.com/c/1327582
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606786}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_offset_mapping_test.cc
  12. Document ContentSettings.Exceptions.media-engagement.

    Changed by Balazs Engedy - engedyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:28:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d8eed38bec9b93351d1e3cd65f981380acf6e3c

    Comments

    Document ContentSettings.Exceptions.media-engagement.
    
    Add the missing histogram suffix `media-engagement` to histograms.xml.
    This is the content setting type with by far the largest number of
    exceptions, yet missing from the dashboards.
    
    Bug: 890129
    Change-Id: Iaca89cf7b28db59a9d3c9baf3f810e765a8308a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1326147
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606785}

    Changed files

    • tools/metrics/histograms/histograms.xml
  13. Roll src/third_party/depot_tools 98c0fdb927c4..6edb632ff8cd (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:25:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1fdb6589087a7a301a61113f8b7fca1fb70bc52

    Comments

    Roll src/third_party/depot_tools 98c0fdb927c4..6edb632ff8cd (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98c0fdb927c4..6edb632ff8cd
    
    
    git log 98c0fdb927c4..6edb632ff8cd --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 vadimsh@chromium.org [cipd] Bump CIPD client and vpython versions.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@6edb632ff8cd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ic57f994925c49696f5f1f3da863df1b317081f7e
    Reviewed-on: https://chromium-review.googlesource.com/c/1328523
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606784}

    Changed files

    • DEPS
  14. Create target in //components/signin for shared code

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:24:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9

    Comments

    Create target in //components/signin for shared code
    
    //components/signin/core/browser contains three different types of code:
    
    1. Code that forms the guts of IdentityManager and will form the guts of
    the Identity Service implementation (e.g., SigninManager).
    
    2. Code that will be clients of IdentityManager (e.g., SigninTracker).
    
    3. Code that will be used on both sides (e.g., AccountInfo).
    
    1 and 2 have already been split via a preceding CL. This CL creates 3.
    To start off with, 3 contains two pieces of code that were already in
    their own standalone targets for similar motivations as the above:
    account_info.* and signin_metrics.*. In the future more code will
    likely move in.
    
    Bug: 901859
    Change-Id: Ibcae3c9f1ecff2dc7ccd013046b74c97b3dd2b7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323114
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606783}

    Changed files

    • components/autofill/core/browser/BUILD.gn
    • components/signin/core/browser/BUILD.gn
    • components/sync/BUILD.gn
    • ios/chrome/browser/ui/authentication/BUILD.gn
    • services/identity/BUILD.gn
    • services/identity/public/cpp/BUILD.gn
    • services/identity/public/cpp/account_info.typemap
  15. Automated Commit: LKGM 11244.0.0 for chromeos.

    Changed by 3su6n15k.default@developer.gserviceaccount.com - 3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:24:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c814268e0605b5134669e52db357d13aadd08fb

    Comments

    Automated Commit: LKGM 11244.0.0 for chromeos.
    
    BUG=762641
    TBR=rkc@chromium.org
    
    Change-Id: Ic280acd363864f15e43d89b7ee466b554fc2e614
    Reviewed-on: https://chromium-review.googlesource.com/c/1328841
    Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606782}

    Changed files

    • chromeos/CHROMEOS_LKGM
  16. Prevent use-after-free in SiteEngagementService.

    Changed by Balazs Engedy - engedyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:12:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70115b4df17a675652ef65521ba6ddf81f59037

    Comments

    Prevent use-after-free in SiteEngagementService.
    
    The profile and its KeyedServices are normally destroyed before the
    TaskScheduler shuts down background threads, so the background task to
    record site engagement metrics needs to avoid using any members of
    SiteEngagementService
    
    Bug: 900022
    Change-Id: Ibdebbd5a64d59fad29b7715be3557eeed411d741
    Reviewed-on: https://chromium-review.googlesource.com/c/1326441
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606781}

    Changed files

    • chrome/browser/engagement/site_engagement_service.cc
  17. Do style propagation to generated content in LayoutObject.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:07:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a944866662c9cd3841c2cc1c8e8335ff6fd838e4

    Comments

    Do style propagation to generated content in LayoutObject.
    
    It belongs with the other anonymous LayoutObject propagation code.
    There are still two loops for pseudo elements where we propagate style
    to anonymous table boxes like before but propagate style from the
    pseudo element to the generated content directly, skipping other
    anonymous boxes, in a separate loop. This is just keeping the same
    functionality for generated content without trying to propagate style
    through others anonymous boxes. Left a TODO for that.
    
    Change-Id: I3c38bc9d831b8a767fd601d47e4db0f81923ba47
    Reviewed-on: https://chromium-review.googlesource.com/c/1328041
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606780}

    Changed files

    • third_party/blink/renderer/core/dom/pseudo_element.cc
    • third_party/blink/renderer/core/dom/pseudo_element.h
    • third_party/blink/renderer/core/layout/layout_object.cc
  18. Revert "Route SSLPrivateKey provider names into NetLog."

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:06:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe2afddb677e9cf62b0f24c9dd2b176156d34a7

    Comments

    Revert "Route SSLPrivateKey provider names into NetLog."
    
    This reverts commit db889e10709b97c8e0c872e167cef871147afcdb.
    
    Reason for revert: Speculative revert: A bunch of SSL related tests failing on Mac: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36146
    
    Original change's description:
    > Route SSLPrivateKey provider names into NetLog.
    > 
    > Improve debugging in the future so we don't have to keep asking "are you
    > using a smartcard? which?".
    > 
    > Bug: none
    > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > Change-Id: Ifbaf6f5aa0aa73dcd19be0ccc0046c2c2c069319
    > Reviewed-on: https://chromium-review.googlesource.com/c/1292509
    > Commit-Queue: David Benjamin <davidben@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606700}
    
    TBR=rsleevi@chromium.org,kinuko@chromium.org,davidben@chromium.org,emaxx@chromium.org
    
    Change-Id: Icb8db36c96ba199e0857296cd21fa9d3e8826c90
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/c/1328882
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606779}

    Changed files

    • chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
    • chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc
    • content/browser/network_service_client.cc
    • net/android/java/src/org/chromium/net/AndroidKeyStore.java
    • net/android/keystore.cc
    • net/android/keystore.h
    • net/log/net_log_event_type_list.h
    • net/socket/ssl_client_socket_impl.cc
    • net/ssl/ssl_client_auth_cache_unittest.cc
    • net/ssl/ssl_platform_key_android.cc
    • net/ssl/ssl_platform_key_mac.cc
    • net/ssl/ssl_platform_key_nss.cc
    • net/ssl/ssl_platform_key_win.cc
    • net/ssl/ssl_private_key.h
    • net/ssl/test_ssl_private_key.cc
    • net/ssl/threaded_ssl_private_key.cc
    • net/ssl/threaded_ssl_private_key.h
    • net/url_request/url_request_unittest.cc
    • services/network/public/mojom/network_service.mojom
    • services/network/url_loader.cc
    • services/network/url_loader.h
    • services/network/url_loader_unittest.cc
  19. Revert "Enable unified garbage collections part two"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:03:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9453dfbffd2000b3eafab2a59169da733d8cf08a

    Comments

    Revert "Enable unified garbage collections part two"
    
    This reverts commit 79ffe683c7cc22ab3478b119adcc9b49584bd9e2.
    
    Reason for revert: Speculative revert: lots of garbage-collection related failures on WebKit Linux Trusty ASAN (see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/17912)
    
    Original change's description:
    > Enable unified garbage collections part two
    > 
    > This flag overrides the default Blink value for content layer.
    > 
    > Sheriffs: This is a dry-run of the feature and will be reverted after
    > cycling through the waterfall and performance bots.
    > 
    > Tbr: jochen@chromium.org, lfg@chromium.org
    > Bug: 843903
    > Change-Id: Ie362301e4874198eb775346d051bf8267837aaf8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1320970
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Reviewed-by: Hannes Payer <hpayer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606446}
    
    TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org,lfg@chromium.org
    
    Change-Id: I189aca41c8f8ba11c358a4c15bc7f56591e38196
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 843903
    Reviewed-on: https://chromium-review.googlesource.com/c/1328902
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606778}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • content/public/common/content_features.cc
    • third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/gc-9-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt
  20. Move context state related methods out of DecoderContext

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:03:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bea0d6b3c467e05183fb88d06a829a6d7e7d136a

    Comments

    Move context state related methods out of DecoderContext
    
    This CL adds a new GLContextVirtualDelegate interface to contain all
    context state related methods from DecoderContext. After this one, I am
    going to implement GLContextVirtualDelegate in RasterDecoderContextState
    and only create one GLContextVirtual for all raster decoder and display
    compositor.
    
    Bug: 900941, 902904
    Change-Id: I10d80bea8531885c449a2e676ce0552e9363b34c
    Reviewed-on: https://chromium-review.googlesource.com/c/1312338
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606777}

    Changed files

    • gpu/command_buffer/service/BUILD.gn
    • gpu/command_buffer/service/decoder_context.h
    • gpu/command_buffer/service/gl_context_virtual.cc
    • gpu/command_buffer/service/gl_context_virtual.h
    • gpu/command_buffer/service/gl_context_virtual_delegate.h
    • gpu/command_buffer/service/gl_state_restorer_impl.cc
    • gpu/command_buffer/service/gl_state_restorer_impl.h
    • gpu/command_buffer/service/raster_decoder.cc
    • gpu/command_buffer/service/raster_decoder_context_state.cc
    • gpu/command_buffer/service/raster_decoder_context_state.h
    • gpu/command_buffer/service/wrapped_sk_image.cc
  21. Add custom search engines list in Search Engine Settings.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:45:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b549d861a796421a3907cb9a62eec272c2a0359

    Comments

    Add custom search engines list in Search Engine Settings.
    
    This CL changes how search engines are displayed in Search Engine Settings.
    
    Previous(1 list):
      1. search engines that are prepopulated or created by policy.
    
    Current(2 lists):
      1. Search engines that are prepopulated or created by policy, and possibly
         one custom search engine at the end if it's selected as default search
         engine;
      2. All remaining search engines.
    
    Unittests are also updated.
    
    Bug: 433824
    Change-Id: Ib70a18f0544101760c331bb349ee9818956ed231
    Reviewed-on: https://chromium-review.googlesource.com/c/1323509
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606776}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller.mm
    • ios/chrome/browser/ui/settings/search_engine_settings_collection_view_controller_unittest.mm
  22. Remove ReadableStreamOperations use from BodyStreamBuffer

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:44:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6105631e4f6362a083d8ad05999f21fc7918b67f

    Comments

    Remove ReadableStreamOperations use from BodyStreamBuffer
    
    Replace use of ReadableStreamOperations in BodyStreamBuffer with
    ReadableStream. This CL doesn't change the behavior.
    
    Bug: 894357, 888165, 902633
    
    Change-Id: Icd478dcc59ca86e020d540229d69f0c61fb689c0
    Reviewed-on: https://chromium-review.googlesource.com/c/1319408
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606775}

    Changed files

    • third_party/blink/renderer/core/fetch/body.cc
    • third_party/blink/renderer/core/fetch/body.h
    • third_party/blink/renderer/core/fetch/body_stream_buffer.cc
    • third_party/blink/renderer/core/fetch/body_stream_buffer.h
    • third_party/blink/renderer/core/fetch/request.cc
    • third_party/blink/renderer/core/fetch/response.cc
    • third_party/blink/renderer/core/fetch/response.h
    • third_party/blink/renderer/core/streams/readable_stream.cc
    • third_party/blink/renderer/core/streams/readable_stream.h
    • third_party/blink/renderer/core/streams/readable_stream_operations.cc
    • third_party/blink/renderer/core/streams/readable_stream_operations.h
    • third_party/blink/renderer/core/streams/readable_stream_operations_test.cc
    • third_party/blink/renderer/core/streams/readable_stream_test.cc
  23. Migrate clear_browsing_data_manager_unittest.mm to the Identity service

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 09:43:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b72eeec68ad1991b2f2989eb599e7486fe6a2b04

    Comments

    Migrate clear_browsing_data_manager_unittest.mm to the Identity service
    
    Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually
    creating the browser's state by providing specific factories, and then
    use the APIs from IdentityTestEnvironment, instead of SigninManagerBase.
    
    Bug: 890826
    Change-Id: Id9d422e002d8fd2edc0ef1ad158f29e95c6dce64
    Reviewed-on: https://chromium-review.googlesource.com/c/1318974
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606774}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager_unittest.mm
  24. [ios] add manual fallback credit card and address view controller

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 09:38:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d9f5a2e523469d0570b1b9ae0bc5818523b2528b

    Comments

    [ios] add manual fallback credit card and address view controller
    
    Added base class that should be used in passwords later.
    
    Bug: 845472
    Change-Id: I1c1d2204d920ae141448239cfeb1c1c5a0e93a20
    Reviewed-on: https://chromium-review.googlesource.com/c/1319714
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606773}

    Changed files

    • ios/chrome/browser/ui/autofill/manual_fill/BUILD.gn
    • ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/address_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/card_view_controller.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_view_controller.mm
  25. Roll src-internal 27fe62b3b2f9..53aa50a0dced (4 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 09:15:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fd575eafdb7ca5f5800c6b866836f84583ea6baf

    Comments

    Roll src-internal 27fe62b3b2f9..53aa50a0dced (4 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27fe62b3b2f9..53aa50a0dced
    
    
    Created with:
      gclient setdep -r src-internal@53aa50a0dced
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I0ceb97585997b51d4374733c0324a20c8d817333
    Reviewed-on: https://chromium-review.googlesource.com/c/1328724
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606772}

    Changed files

    • DEPS
  26. [Autofill Assistant] Allow FocusAction to restrict access to some elements

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:13:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32d31b5886e3493539864668484205446da536e4

    Comments

    [Autofill Assistant] Allow FocusAction to restrict access to some elements
    
    This change allows a focus action to provide a list of elements that can
    be accessed. On a touch event, the position of the touch is compared
    against the position of the elements before forwarding the event to the
    webpage (or not).
    
    The position of the element is updated periodically or after a scroll
    event.
    
    Currently, touches are just swallowed. A follow-up change will make it
    clear what's going on and offer alternatives.
    
    By default, the new behavior is disabled.
    
    Bug: 806868
    Change-Id: I5bce26d3a4a81a7167253b564ca416364d18b61e
    Reviewed-on: https://chromium-review.googlesource.com/c/1323489
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606771}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/TouchEventFilter.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/BUILD.gn
    • components/autofill_assistant/browser/actions/action_delegate.h
    • components/autofill_assistant/browser/actions/focus_element_action.cc
    • components/autofill_assistant/browser/actions/focus_element_action.h
    • components/autofill_assistant/browser/actions/mock_action_delegate.h
    • components/autofill_assistant/browser/controller.cc
    • components/autofill_assistant/browser/controller.h
    • components/autofill_assistant/browser/element_area.cc
    • components/autofill_assistant/browser/element_area.h
    • components/autofill_assistant/browser/element_area_unittest.cc
    • components/autofill_assistant/browser/mock_run_once_callback.h
    • components/autofill_assistant/browser/mock_web_controller.h
    • components/autofill_assistant/browser/script_executor.cc
    • components/autofill_assistant/browser/script_executor.h
    • components/autofill_assistant/browser/service.proto
    • components/autofill_assistant/browser/ui_delegate.h
    • components/autofill_assistant/browser/web_controller.cc
    • components/autofill_assistant/browser/web_controller.h
  27. [On-device adaptive brightness] Implement a controller and add to browser.

    Changed by Jia - jiamengohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 09:03:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b49a0794f0b3f63af3e073891b1385150aa1d449

    Comments

    [On-device adaptive brightness] Implement a controller and add to browser.
    
    Bug: 881215
    Change-Id: I504764bd39f586d07e67eef1443565d4235a6a2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1322256
    Reviewed-by: Dan Erat <derat@chromium.org>
    Commit-Queue: Jia Meng <jiameng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606770}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/chromeos/power/auto_screen_brightness/controller.cc
    • chrome/browser/chromeos/power/auto_screen_brightness/controller.h
  28. Import wpt@a996d2028df7fe48935f1e8303cbd49dfb6a59d7

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 08:35:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f038ea3445a10c7f8116f52afe7add030b77d243

    Comments

    Import wpt@a996d2028df7fe48935f1e8303cbd49dfb6a59d7
    
    Using wpt-import in Chromium 7963defbe26e7bc44b4a127e7745fd14af81a52b.
    With Chromium commits locally applied on WPT:
    270d4abddc "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content."
    
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    mstensho@chromium.org:
      external/wpt/css/css-multicol
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I19c1f1a503fec2ad9086489fb20d598cb03b8a1b
    Reviewed-on: https://chromium-review.googlesource.com/c/1328706
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606769}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-001-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-002-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-003-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-003.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-004-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-004.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-005.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-006.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-007-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-007.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-008-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-add-008.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-001-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-002-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-003.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-004-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-004.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-005-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-005.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-dynamic-remove-006.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-001-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-002-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-003-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-003.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-004-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-span-all-restyle-004.html
  29. Roll AFDO from 72.0.3605.2_rc-r1 to 72.0.3606.0_rc-r1

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 08:20:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99c07a8c78aad274d110c41bc9c9fece6047918a

    Comments

    Roll AFDO from 72.0.3605.2_rc-r1 to 72.0.3606.0_rc-r1
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    Please note that, despite rolling to chrome/android, this profile is
    used for both Linux and Android.
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I203aa13a2da986403ddb642a29a20ed3069e1e09
    Reviewed-on: https://chromium-review.googlesource.com/c/1328725
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606768}

    Changed files

    • chrome/android/profiles/newest.txt
  30. Remove Channel ID from safe browsing code

    Changed by Nick Harper - nharperohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 08:17:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5314e7019baec0418f43d3220daf620ccda8928

    Comments

    Remove Channel ID from safe browsing code
    
    Bug: 875053
    Change-Id: I4687640650ac9120acbacbc82dcfe9b0ccb87451
    Reviewed-on: https://chromium-review.googlesource.com/c/1325567
    Commit-Queue: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606767}

    Changed files

    • components/safe_browsing/browser/safe_browsing_network_context.cc
    • components/safe_browsing/browser/safe_browsing_url_request_context_getter.cc
    • components/safe_browsing/browser/safe_browsing_url_request_context_getter.h
  31. [Sync::USS] Introducing PasswordSyncBridge

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 08:07:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 194abb348b6be616fd50fc1a91f6026e7c6e8932

    Comments

    [Sync::USS] Introducing PasswordSyncBridge
    
    This CL adds the skeleton of the PasswordSyncBridge and plumps it into
    PasswordStore.
    In addition it also include the feature toggle for Passwords USS
    migration.
    
    Bug: 902349
    Change-Id: I343f2bb83ecf2c993bacab9e299e7d0deea868b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1323653
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606766}

    Changed files

    • components/password_manager/core/browser/BUILD.gn
    • components/password_manager/core/browser/DEPS
    • components/password_manager/core/browser/password_store.cc
    • components/password_manager/core/browser/password_store.h
    • components/password_manager/core/browser/sync/password_sync_bridge.cc
    • components/password_manager/core/browser/sync/password_sync_bridge.h
    • components/sync/driver/sync_driver_switches.cc
    • components/sync/driver/sync_driver_switches.h
  32. [On-device adaptive brightness] Remove trailing whitespace.

    Changed by Jia - jiamengohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 08:00:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 71f11a590fd82ecf181b26ff3d74fa019f2e04b8

    Comments

    [On-device adaptive brightness] Remove trailing whitespace.
    
    This cl removes white space when we read ALS path and spec from command line.
    
    Bug: 881215
    Change-Id: I8a7373439793d0d3cd697c41ae882bbb10e7b455
    Reviewed-on: https://chromium-review.googlesource.com/c/1328543
    Commit-Queue: Jia Meng <jiameng@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606765}

    Changed files

    • chrome/browser/chromeos/power/auto_screen_brightness/als_reader_impl.cc
  33. Add assigned_nodes_index_ map for slot's assigned child

    Changed by Rakina Zata Amni - rakinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 07:56:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eaddcb2899f1120b8a8d4d30d3c2a2911e65d049

    Comments

    Add assigned_nodes_index_ map for slot's assigned child
    
    Currently when traversing to the next/prev sibling of a slot's assigned
    child, we find the current node's position by looping through a list
    of the slot's assigned child, taking O(N) time where N is the number of
    assigned children in that slot. This means traversing through a slot's
    children will take a total of O(N^2) time. This CL adds a node->index
    map for slot's children so that we will instead take O(1) time to find
    a node's position in the list.
    
    The downside of this is in cases where there are only a small number
    of children assigned to a slot, the performance will be slightly worse
    because of the hashmap lookup.
    
    Benchmarked with https://jsbin.com/ravolid/edit?html,output, comparing
    shadow dom v0 vs v1, where v0 already uses maps.
    
    For N = 500 (release build), v0 takes ~20ms, v1 without map takes ~200ms, so v0 is 10x
    faster than v1.
    For N = 500 (local build), v0 takes ~54ms, v1 with map takes ~90ms, so v0 is 1.8x
    faster than v1.
    
    
    Bug: 901063
    Change-Id: Iec006fcafca1e368ab97f40d909362dbcf74a08e
    Reviewed-on: https://chromium-review.googlesource.com/c/1328622
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606764}

    Changed files

    • third_party/blink/renderer/core/html/html_slot_element.cc
    • third_party/blink/renderer/core/html/html_slot_element.h
  34. Fix Jumbo builds with UNINITIALIZED values

    Changed by Marcin Wiacek - marcinohnoyoudont@mwiacek.com
    Changed at Friday, 09-Nov-18 07:54:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d630de0987d6548a684ad742dad51ff8fb06fa55

    Comments

    Fix Jumbo builds with UNINITIALIZED values
    
    Error:
    
    ../../content/browser/service_worker/service_worker_database.h:398:5: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow]
        UNINITIALIZED,
        ^
    ../../content/browser/service_worker/service_worker_storage.h:566:5: error: declaration shadows a variable in namespace 'content::(anonymous)' [-Werror,-Wshadow]
        UNINITIALIZED,
        ^
    
    ./../../content/browser/browser_thread_impl.cc:36:3: note: previous declaration is here
      UNINITIALIZED = 0,
      ^
    
    Example compilation settings:
    
    target_os="android"
    target_cpu="arm"
    enable_nacl=false
    symbol_level=0
    remove_webcore_debug_symbols=true
    is_debug=false
    dcheck_always_on=false
    is_component_build=false
    use_jumbo_build=true
    
    BUG=903460
    
    Change-Id: Ie8c6ef88ac299e02724bcbbeb1db69e67515f62b
    Reviewed-on: https://chromium-review.googlesource.com/c/1327213
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
    Cr-Commit-Position: refs/heads/master@{#606763}

    Changed files

    • content/browser/service_worker/service_worker_database.cc
    • content/browser/service_worker/service_worker_database.h
    • content/browser/service_worker/service_worker_database_unittest.cc
    • content/browser/service_worker/service_worker_storage.cc
    • content/browser/service_worker/service_worker_storage.h