Home | Search | chromium - Builders
Login

Builder Win x64 Build 25461 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision840dc0a7c0eacb82070efe833ef3aacc7b2e89cb
Got Revision840dc0a7c0eacb82070efe833ef3aacc7b2e89cb

Execution:

Steps and Logfiles:

Show:
  1. ( 568 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 384 ms ) remove .cipd
  4. ( 58 secs ) bot_update
    [85GB/299GB used (28%)]
  5. ( 0 ) ensure_goma
  6. ( 638 ms ) swarming.py --version
    0.13
  7. ( 26 secs ) clobber
  8. ( 1 mins 20 secs ) gclient runhooks
  9. ( 225 ms ) read test spec (chromium.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.json
  10. ( 20 secs ) generate_build_files
  11. ( 11 mins 58 secs ) compile
  12. ( 12 secs ) compile confirm no-op
  13. ( 33 secs ) archive_build
  14. ( 0 ) test_pre_run
  15. ( 1 secs ) checkbins
  16. ( 498 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm777-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531428959608620, "id": "8941174063208787904", "project": "chromium", "tags": ["builder:Win x64", "buildset:commit/git/840dc0a7c0eacb82070efe833ef3aacc7b2e89cb", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/840dc0a7c0eacb82070efe833ef3aacc7b2e89cb", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106604125318807888", "scheduler_job_id:chromium/Win x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win x64" setup_build
buildnumber 25461 setup_build
mastername "chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "840dc0a7c0eacb82070efe833ef3aacc7b2e89cb" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "840dc0a7c0eacb82070efe833ef3aacc7b2e89cb" bot_update
got_revision_cp "refs/heads/master@{#574712}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23955}" bot_update

Blamelist:

  1. Francois Doray (fdorayohnoyoudont@chromium.org)
  2. Nicolas Pena (npmohnoyoudont@chromium.org)
  3. Karan Bhatia (karandeepbohnoyoudont@chromium.org)
  4. Jared Saul (jsaulohnoyoudont@google.com)

Timing:

Create Thursday, 12-Jul-18 20:55:59 UTC
Start Thursday, 12-Jul-18 20:56:03 UTC
End Thursday, 12-Jul-18 21:14:48 UTC
Pending 4 secs
Execution 18 mins 44 secs

All Changes:

  1. RC: Record Chrome usage time when a LifecycleUnit is hidden.

    Changed by Francois Doray - fdorayohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:54:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 840dc0a7c0eacb82070efe833ef3aacc7b2e89cb

    Comments

    RC: Record Chrome usage time when a LifecycleUnit is hidden.
    
    With this CL, the total Chrome usage time measured by UsageClock is
    recorded in a LifecycleUnit when it is hidden. In an upcoming CL, this
    will be used to discard a LifecycleUnit after a given amount of Chrome
    usage time has elapsed since it was hidden.
    
    We also record the wall time when a LifecycleUnit is hidden, because
    freezing occurs when a LifeycleUnit has been hidden for a given amount
    of wall clock time, not Chrome usage time.
    
    Bug: 775644
    Change-Id: I76d504e9bbf3eb86ded1203e4e117086faf93277
    Reviewed-on: https://chromium-review.googlesource.com/1133593
    Commit-Queue: François Doray <fdoray@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574712}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/browser_process_impl.h
    • chrome/browser/resource_coordinator/lifecycle_unit.h
    • chrome/browser/resource_coordinator/lifecycle_unit_base.cc
    • chrome/browser/resource_coordinator/lifecycle_unit_base.h
    • chrome/browser/resource_coordinator/lifecycle_unit_base_unittest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
    • chrome/browser/resource_coordinator/tab_manager_stats_collector.cc
    • chrome/browser/resource_coordinator/test_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/test_lifecycle_unit.h
    • chrome/test/base/testing_browser_process.cc
    • chrome/test/base/testing_browser_process.h
  2. Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds

    Changed by Nicolas Pena - npmohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:49:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e44f3be427bb7222e8e20640e261d620478e8bc

    Comments

    Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds
    
    This CL changes Blink code from using Count(delta.InMilliseconds()) to:
    * UMA_HISTOGRAM_TIMES where possible.
    * Otherwise, UMA_HISTOGRAM_CUSTOM_COUNTS if possible.
    * Otherwise, saturated_cast.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4f6e2ae0fb318b906ec75c546bea519cd130b09e
    Reviewed-on: https://chromium-review.googlesource.com/1134083
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574711}

    Changed files

    • third_party/blink/renderer/core/editing/spellcheck/spell_check_requester.cc
    • third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
    • third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_metrics.cc
    • third_party/blink/renderer/modules/notifications/notification_image_loader.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.cc
    • third_party/blink/renderer/platform/heap/heap_stats_collector.h
    • third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc
    • third_party/blink/renderer/platform/heap/thread_state.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
  3. Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.

    Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:47:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b96ae12ef5fa70c2389e5b23da5a924eb4dff359

    Comments

    Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.
    
    This CL changes RulesMonitorService::HasRegisteredRuleset to take an
    extension_id instead of an extension pointer.
    
    BUG=None
    
    Change-Id: If6d220b7bcaf9be473ff819961f5ed9fe67f681f
    Reviewed-on: https://chromium-review.googlesource.com/1134519
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574710}

    Changed files

    • extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.h
  4. [Autofill] Log metric for whether card upload cardholder name was edited

    Changed by Jared Saul - jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:40:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1447fae2e377e748f4ddb532a99f6c5ba7319c98

    Comments

    [Autofill] Log metric for whether card upload cardholder name was edited
    
    Bug: 848955
    Change-Id: I8febd9c3471b58b962d3706eede4be506b092044
    Reviewed-on: https://chromium-review.googlesource.com/1134089
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574709}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • tools/metrics/histograms/histograms.xml