Home | Search | chromium - Builders
Login

Builder Win x64 Build 25449 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision967fc76c423a5e86fc2e04b4655aa463d2ae7c12
Got Revision967fc76c423a5e86fc2e04b4655aa463d2ae7c12

Execution:

Steps and Logfiles:

Show:
  1. ( 537 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 359 ms ) remove .cipd
  4. ( 55 secs ) bot_update
    [85GB/299GB used (28%)]
  5. ( 0 ) ensure_goma
  6. ( 624 ms ) swarming.py --version
    0.13
  7. ( 21 secs ) clobber
  8. ( 1 mins 23 secs ) gclient runhooks
  9. ( 210 ms ) read test spec (chromium.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.json
  10. ( 20 secs ) generate_build_files
  11. ( 15 mins 9 secs ) compile
  12. ( 11 secs ) compile confirm no-op
  13. ( 33 secs ) archive_build
  14. ( 0 ) test_pre_run
  15. ( 1 secs ) checkbins
  16. ( 512 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm777-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531413033581930, "id": "8941190762858362976", "project": "chromium", "tags": ["builder:Win x64", "buildset:commit/git/967fc76c423a5e86fc2e04b4655aa463d2ae7c12", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/967fc76c423a5e86fc2e04b4655aa463d2ae7c12", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106620824950338688", "scheduler_job_id:chromium/Win x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win x64" setup_build
buildnumber 25449 setup_build
mastername "chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "967fc76c423a5e86fc2e04b4655aa463d2ae7c12" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "967fc76c423a5e86fc2e04b4655aa463d2ae7c12" bot_update
got_revision_cp "refs/heads/master@{#574591}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update

Blamelist:

  1. Peter E Conn (peconnohnoyoudont@chromium.org)
  2. Peter Kasting (pkastingohnoyoudont@chromium.org)
  3. Takuto Ikuta (tikutaohnoyoudont@chromium.org)
  4. Jay Civelli (jcivelliohnoyoudont@google.com)
  5. Stefan Zager (szagerohnoyoudont@chromium.org)
  6. Bruce Dawson (brucedawsonohnoyoudont@chromium.org)
  7. Peter Kasting (pkastingohnoyoudont@chromium.org)
  8. Fabio Tirelo (ftireloohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:30:33 UTC
Start Thursday, 12-Jul-18 16:30:35 UTC
End Thursday, 12-Jul-18 16:52:18 UTC
Pending 1 secs
Execution 21 mins 43 secs

All Changes:

  1. 🤝 Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  2. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  3. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py
  4. Simplify FakeGaiaCookieManagerService

    Changed by Jay Civelli - jcivelliohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8dcbf6aaf6203343107cd5289b45dc64f2a5e8

    Comments

    Simplify FakeGaiaCookieManagerService
    
    Simplifying the FakeGaiaCookieManagerService API by not requiring to
    call Init() with a FakeURLFetcherFactory. The FakeURLFetcherFactory is
    instead a member of the FakeGaiaCookieManagerService.
    
    This API simplification is in preparation for switching GaiaAuthFetcher
    to use the SimpleURLLoader (network service).
    
    Bug: 840396
    Change-Id: I917e4236a53bf251c3a8e82c868d5e4d99655aca
    Reviewed-on: https://chromium-review.googlesource.com/1114226
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574588}

    Changed files

    • chrome/browser/extensions/api/identity/identity_apitest.cc
    • chrome/browser/search/one_google_bar/one_google_bar_service_unittest.cc
    • chrome/browser/signin/dice_response_handler_unittest.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.cc
    • chrome/browser/signin/fake_gaia_cookie_manager_service_builder.h
    • chrome/browser/signin/signin_ui_util_unittest.cc
    • chrome/browser/supervised_user/child_accounts/child_account_service_unittest.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.cc
    • chrome/browser/ui/views/frame/test_with_browser_view.h
    • components/search_provider_logos/logo_service_impl_unittest.cc
    • components/signin/core/browser/account_investigator_unittest.cc
    • components/signin/core/browser/account_reconcilor_unittest.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.cc
    • components/signin/core/browser/fake_gaia_cookie_manager_service.h
    • components/signin/core/browser/signin_manager_unittest.cc
  5. Get rid of GraphicsLayer::scrollable_area_

    Changed by Stefan Zager - szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:18:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 442f13b7e97747ab09612a101159b1eb26072382

    Comments

    Get rid of GraphicsLayer::scrollable_area_
    
    The only place where it was actually used was in
    GraphicsLayer::SetScrollbarsHiddenIfOverlay, so just forward that
    call to the GraphicsLayerClient.
    
    BUG=823365
    R=pdr@chromium.org,skobes@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I3cdd24ceb1ab51563dbc3b6d9ce50ce9edc77bf8
    Reviewed-on: https://chromium-review.googlesource.com/1132536
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574587}

    Changed files

    • third_party/blink/renderer/core/frame/visual_viewport.cc
    • third_party/blink/renderer/core/frame/visual_viewport.h
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_as_text.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer.h
    • third_party/blink/renderer/platform/graphics/graphics_layer_client.h
  6. Add "latency" to list of ETW-traceable events

    Changed by Bruce Dawson - brucedawsonohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5d9a9d75a9a8f7f6fb9d749c9b797eb2550d34e

    Comments

    Add "latency" to list of ETW-traceable events
    
    The "latency" category looks like a perfect event category for ETW
    tracing. In particular, TabSwitching::Latency indicates when Chrome
    thinks that tab switching has started and stopped which allows it to be
    profiled in detail. This has revealed where CPU time is going, and how
    long the delay is from when the keyboard event is generated to when
    Chrome starts officially processing it. This was helpful in
    investigating tab switching latency in bug 858944.
    
    This will require an update to UIforETW to fully enable, which I have
    done locally for testing purposes.
    
    Bug: 858944
    Change-Id: I4797b804ea6d35458aa3b4e876a78172a29d5131
    Reviewed-on: https://chromium-review.googlesource.com/1134516
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574586}

    Changed files

    • base/trace_event/trace_event_etw_export_win.cc
  7. Remove NewTabButton::GetVisibleBounds().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f448a241361b03dd2b6fd21ab052774e1074fdf1

    Comments

    Remove NewTabButton::GetVisibleBounds().
    
    This was a computed by constructing the border path and computing the bounding
    box.  However, it was only used for the ink drop, and ink drops are only used in
    newer material mode, where the border path is a square.
    
    Instead, we can use GetContentsBounds(), as long as those are actually
    positioned correctly.  The new tab button has empty space at the top, which is
    included (by the tabstrip) in its size and accounted for when doing painting and
    hittesting.  By adding an empty top border of this thickness, a lot of this code
    can be simplified.  (Further simplifications are coming in a subsequent CL.)
    
    Bug: none
    Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
    Reviewed-on: https://chromium-review.googlesource.com/1134399
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574585}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
  8. [AF] Use views::Separator in the Autofill dropdown

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff6fb086724fb3cd20409d3e72065bbd4a84abd

    Comments

    [AF] Use views::Separator in the Autofill dropdown
    
    This is a follow-up of crrev.com/c/1131680 and replace a custom view
    to simulate a separator with a views::Separator view.
    
    Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
    Reviewed-on: https://chromium-review.googlesource.com/1133328
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574584}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc