Home | Search | chromium - Builders
Login

Builder Win x64 Build 25438 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision4432c3f9d16a93276eeb9c60a860190223888d96
Got Revision4432c3f9d16a93276eeb9c60a860190223888d96

Execution:

Steps and Logfiles:

Show:
  1. ( 557 ms ) setup_build
    running recipe: "chromium"
  2. ( 5 secs ) taskkill
  3. ( 369 ms ) remove .cipd
  4. ( 58 secs ) bot_update
    [85GB/299GB used (28%)]
  5. ( 0 ) ensure_goma
  6. ( 670 ms ) swarming.py --version
    0.13
  7. ( 23 secs ) clobber
  8. ( 1 mins 18 secs ) gclient runhooks
  9. ( 241 ms ) read test spec (chromium.json)
    path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.json
  10. ( 20 secs ) generate_build_files
  11. ( 19 mins 21 secs ) compile
  12. ( 12 secs ) compile confirm no-op
  13. ( 33 secs ) archive_build
  14. ( 0 ) test_pre_run
  15. ( 2 secs ) checkbins
  16. ( 513 ms ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm777-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531399981745590, "id": "8941204448700127344", "project": "chromium", "tags": ["builder:Win x64", "buildset:commit/git/4432c3f9d16a93276eeb9c60a860190223888d96", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/4432c3f9d16a93276eeb9c60a860190223888d96", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106634510908952336", "scheduler_job_id:chromium/Win x64", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win x64" setup_build
buildnumber 25438 setup_build
mastername "chromium" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "4432c3f9d16a93276eeb9c60a860190223888d96" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "4432c3f9d16a93276eeb9c60a860190223888d96" bot_update
got_revision_cp "refs/heads/master@{#574541}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update

Blamelist:

  1. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  2. Yoshisato Yanagisawa (yyanagisawaohnoyoudont@chromium.org)
  3. Mike West (mkwstohnoyoudont@chromium.org)
  4. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  5. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  6. Kent Tamura (tkentohnoyoudont@chromium.org)
  7. Ivan Sandrk (isandrkohnoyoudont@google.com)
  8. Mike West (mkwstohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 12:53:01 UTC
Start Thursday, 12-Jul-18 12:53:06 UTC
End Thursday, 12-Jul-18 13:19:11 UTC
Pending 4 secs
Execution 26 mins 5 secs

All Changes:

  1. [unified-consent] USER_EVENT has its own sync pref group

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:50:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4432c3f9d16a93276eeb9c60a860190223888d96

    Comments

    [unified-consent] USER_EVENT has its own sync pref group
    
    This CL passes the information that unified consent is enabled to
    the sync service. It then uses it to move USER_EVENTS data type in
    a separate pref group (instead of having it tied to TYPED_URLS as
    before).
    
    The goal is not to un-link USER_EVENTS from HISTORY, but to have a
    separate toggle for USER_EVENTS (which will be linked to HISTORY toggle
    in the toggle UI).
    
    Unit tests have been updated accordingly.
    
    Bug: 860515
    
    Change-Id: Ic5461470114c0b05ec770817890c9123b81f3d77
    Reviewed-on: https://chromium-review.googlesource.com/1128876
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574541}

    Changed files

    • chrome/browser/android/contextualsearch/contextual_search_delegate.cc
    • chrome/browser/sync/profile_sync_service_factory.cc
    • chrome/browser/sync/test/integration/enable_disable_test.cc
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/sync/base/sync_prefs.cc
    • components/sync/base/sync_prefs.h
    • components/sync/base/sync_prefs_unittest.cc
  2. compare_build_artifacts: make ninja path command line option.

    Changed by Yoshisato Yanagisawa - yyanagisawaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:49:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3f55b21a7a48593a9ce1622346dad112a8b2e2f

    Comments

    compare_build_artifacts: make ninja path command line option.
    
    ninja seems not be in PATH when compare_build_artifacts.py is executed.
    Then compare_build_artifacts cannot compare object files difference,
    and just fails with exception.
    To fix that, let me make ninja path given with command line option.
    
    Bug: 862917
    Change-Id: Ieb7d7bd1db30217222f5cd5006e120244da28fd5
    Reviewed-on: https://chromium-review.googlesource.com/1134710
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574540}

    Changed files

    • tools/determinism/compare_build_artifacts.py
  3. Mark several layout tests as flaky.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:44:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704b3f013b80c7a5f93296e3d146758d5c0b0ccc

    Comments

    Mark several layout tests as flaky.
    
    - css3/filters/effect-brightness-clamping-hw.html
    - virtual/gpu/fast/canvas/canvas-blending-image-over-image.html
    - css3/filters/effect-drop-shadow-hw.html
    - external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862716, 862729, 862806, 862826
    Change-Id: I08126b22afdc0a7a4ef776dde8cc1120643acdcc
    Reviewed-on: https://chromium-review.googlesource.com/1134990
    Commit-Queue: Mike West <mkwst@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574539}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  4. macviews: switch back to Cocoa menus for Views context menus

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus
    
    This change:
    1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
       the Cocoa menu runner code;
    2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
    3) Fixes a latent bug in Textfield that could cause it to delete its context
       menu while handling a context menu activation - this is fine with Views menus
       but forbidden with Cocoa menus.
    
    Bug: 860673
    Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
    Reviewed-on: https://chromium-review.googlesource.com/1131564
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc
  5. Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:32:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78a0a24222fde0f77a45d4f78b1f4502496c434e

    Comments

    Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c228d491eb86..3973c26575e2
    
    
    git log c228d491eb86..3973c26575e2 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 dhanyaganesh@chromium.org CreateTarball: Add debug code with lsof
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@3973c26575e2
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Iabf74616719c8b90e6b34c6576772eeb313a7183
    Reviewed-on: https://chromium-review.googlesource.com/1134906
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574537}

    Changed files

    • DEPS
  6. Oilpan: Do not include wtf/functional.h

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

    Comments

    Oilpan: Do not include wtf/functional.h
    
    No one in platform/heap/ needs wtf/functional.h, though persistent.h
    needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.
    
    This CL reduces the pre-processed size of handle.h by 31KB.
    
    Bug: 242216
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
    Reviewed-on: https://chromium-review.googlesource.com/1134809
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574536}

    Changed files

    • third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
    • third_party/blink/renderer/modules/budget/budget_service.cc
    • third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
    • third_party/blink/renderer/modules/filesystem/directory_reader.cc
    • third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
    • third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
    • third_party/blink/renderer/modules/locks/lock.cc
    • third_party/blink/renderer/modules/mediastream/media_devices_test.cc
    • third_party/blink/renderer/modules/payments/payment_manager.cc
    • third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
    • third_party/blink/renderer/modules/webusb/usb_device.cc
    • third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/skia_texture_holder.h
    • third_party/blink/renderer/platform/heap/persistent.h
    • third_party/blink/renderer/platform/heap/thread_state.h
    • third_party/blink/renderer/platform/testing/empty_web_media_player.h
    • third_party/blink/renderer/platform/testing/unit_test_helpers.cc
  7. Add UMA for locked-fullscreen state

    Changed by Ivan Sandrk - isandrkohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fe933a784678f6aa62203b7d57a638051c15f2a

    Comments

    Add UMA for locked-fullscreen state
    
    Locked-fullscreen state will be used for giving student quizzes on managed
    Chrome OS devices in schools. Add a UMA to track feature adoption.
    
    Change-Id: I59f809e2aecd67a4e9f10ee21a28658796c03b15
    Reviewed-on: https://chromium-review.googlesource.com/1126241
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ivan Ĺ andrk <isandrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574535}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  8. Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84356c12447981846eda650f06085913fa831126

    Comments

    Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862907
    Change-Id: If6ce15cb1633ae74177e385774a1cef7010e67c0
    Reviewed-on: https://chromium-review.googlesource.com/1134989
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574534}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations