Home | Search | chromium - Builders
Login

Builder Win x64 Builder Build 51308 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisionf7c234b0272dff6ce746e9eaac813497986913c3
Got Revisionf7c234b0272dff6ce746e9eaac813497986913c3

Execution:

Steps and Logfiles:

Show:
  1. ( 435 ms ) setup_build
    running recipe: "chromium"
  2. ( 2 secs ) taskkill
  3. ( 337 ms ) remove .cipd
  4. ( 46 secs ) bot_update
    [214GB/2047GB used (10%)]
  5. ( 0 ) ensure_goma
  6. ( 554 ms ) swarming.py --version
    0.13
  7. ( 1 mins 5 secs ) gclient runhooks
  8. ( 460 ms ) read test spec (chromium.win.json)
    path: c:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  9. ( 26 secs ) generate_build_files
  10. ( 6 mins 28 secs ) compile
  11. ( 2 mins 27 secs ) isolate tests
  12. ( 4 mins 37 secs ) package build
  13. ( 325 ms ) trigger

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "c:\\b\\s\\w\\ir\\cache", "temp_dir": "c:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build448-m1" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531413665692580, "id": "8941190100041929712", "project": "chromium", "tags": ["builder:Win x64 Builder", "buildset:commit/git/f7c234b0272dff6ce746e9eaac813497986913c3", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f7c234b0272dff6ce746e9eaac813497986913c3", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106620162356443120", "scheduler_job_id:chromium/Win x64 Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win x64 Builder" setup_build
buildnumber 51308 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "f7c234b0272dff6ce746e9eaac813497986913c3" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "f7c234b0272dff6ce746e9eaac813497986913c3" bot_update
got_revision_cp "refs/heads/master@{#574598}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes_refs/heads/master(at){#574598}_without_patch {"accessibility_unittests": "fa7a834692e1ca29621f81aef9ab3eca862ce64d", "angle_unittests": "fe3602ad7aa5f7d0a3f0df709740fbe195f24320", "app_shell_unittests": "641bef600e9858e78fadd526e91ec9ef90ad6985", "aura_unittests": "976dea89b085eaabb868b7507022c4ec4d469886", "base_unittests": "13c52566f9e6b6ace8bd2c3c0ddbd93acc38b69b", "battor_agent_unittests": "b712413a0a27bf0aea360eb9d08747797eb94ae9", "blink_common_unittests": "1621cdac59d0f835c9883dcb957a76dbf0dc14af", "blink_fuzzer_unittests": "9927b1fa9f4435dfaad1f883efd83742798a7fb7", "blink_heap_unittests": "e3ce18a9fc933742298f6fdeb46f5f6455bbc6cb", "blink_platform_unittests": "43520a1566d5a6e7547ee5deec81f5f2c1f4f4a8", "boringssl_crypto_tests": "1bbaef8d0f9f84a92c184b8afcddc424c5570c32", "boringssl_ssl_tests": "09aef5c3db39fe5288630d066245138f53db7759", "browser_tests": "b787ab5321b306603cfc92ca8c4b855d2ddfbe4d", "cacheinvalidation_unittests": "ae010690ef0dbc475eb6964d6562c4b87bf9a3ce", "capture_unittests": "b65316a2a03c0d2ce44d1a14b49efc9a8341a512", "cast_unittests": "bb5bb30a7d364080360e20aaa2c5b12174436c95", "cc_unittests": "f100eea7221ca7fc4df874cb38b77fe59199fdef", "chrome_app_unittests": "33ecec0cf83e454330f28ab40e4d4ae74137e20e", "chrome_cleaner_unittests": "e5dd90d3a8d4e3c0e04a704f7a6feadd5f874970", "chrome_elf_import_unittests": "18d948173e2ea69a780d0928354e91a079a26d41", "chrome_elf_unittests": "accec0dd881e1e92e4d28ec1a1e8ed6c98c73b76", "chromedriver_py_tests": "e89edd3a2746517ab1b46fe19f0ff3698052e45b", "chromedriver_unittests": "01893ca97d20a26f8830d4e4bb21bf3ee5ee7e35", "components_browsertests": "07a239efb74d479ac731d0f21710f8c379641a72", "components_perftests": "3991c9808350e95f02d70bccd0a0dc03dca0c73c", "components_unittests": "3a3db77df86a9254cef0502477f3753d25fc5c10", "compositor_unittests": "5637f7c5f946dd8fa716755b6f670989a0f725fb", "content_browsertests": "0a454b1b17f0e2d46edfd00de1c771956e426c70", "content_shell_crash_test": "b71a289de260fd34c15a8f989de9846071144f5f", "content_unittests": "c4a213d4326bbf6d7f0a17ade27dfbf005a83ef8", "courgette_unittests": "76b5c78efee72b14e590b7867f251cf6fefa4043", "crashpad_tests": "c0861767fa4bf807eda12008a1bc8202cce15ab4", "cronet_tests": "f57dd2ce778b2fe44c0d87c89e823721795e47d6", "cronet_unittests": "f08e4447715eb97e5de49cb65e25c9839ae579ab", "crypto_unittests": "ec6c6b8f0339a7a8cf44789a2b028bd7c937b78a", "device_unittests": "720f5fba8797183daa22756c5efa542815a92357", "display_unittests": "888f3c4c634cf14853f2b153960d613922c20331", "elevation_service_unittests": "38e8620dcd46491d4e19f3d29a92ae2ad721d075", "events_unittests": "d73e365e4b1de17cbe654020d68c619adf9121b0", "extensions_browsertests": "3f7734813f7cb7ea19fc335bf998d8994d9d9947", "extensions_unittests": "c1c25dee3ede524bfa4d24959f2007a933e058c1", "filesystem_service_unittests": "5216c688ee5adeb5ac4e0e94230824a98a95def8", "gcm_unit_tests": "0105b885cd19b778a25a6c9f06896bebb250113e", "gfx_unittests": "c67e6c658a029ae7a68b69dbf9cf17e03df94725", "gin_unittests": "ad4cea50c82cf52ff0b1436de4155cc2436f56c7", "google_apis_unittests": "e4ae5b56a389c1ee083891a9da21113ef9d2df70", "gpu_unittests": "3fbdeb5f34ae4d45611d642e2e248ce1ce8ba6d4", "headless_browsertests": "ba390e0c6d55063d29f87b97e0c59b1c4c951dd2", "headless_unittests": "44c533ce9f1acf1738d0ca8da32921ed2c43966a", "install_static_unittests": "ff523669a05cde9ea6fb9a90655ef4818bc8c157", "installer_util_unittests": "14ddd4d65e9c589028437d54a7be0de562074c6b", "interactive_ui_tests": "6302c2b57f07960abeac5d23eb5737a7c97d296d", "ipc_tests": "daf042e9808c44ca05b7dca138a0b53bc55ce4d1", "jingle_unittests": "60610ba74254a32bac8c2cc265eb4be8d40b587e", "latency_unittests": "27035fd8ae7bd33f6aff371cb6c5d8ab658dd326", "leveldb_service_unittests": "dc818220caedf1ca0162bc29e08b48700fd8966d", "libjingle_xmpp_unittests": "e8b98071ab6dd6ad45491e22a0f28aa600c14676", "media_blink_unittests": "599bd6c3bbdf60e2c7feced0069a9b5792e5518e", "media_service_unittests": "34abf7914a1095453224c89b2e8868d8a55ea415", "media_unittests": "53c7da36098b604138a7eb72dabddb4672f50294", "message_center_unittests": "fb11bab2510e4fa9cc164246bff028c2bb767281", "metrics_python_tests": "1b6218d6884d380de359d98f55ae93edb615da9f", "midi_unittests": "f4391a848c1742de252a71896774af19d9c1684e", "mini_installer_tests": "5c45c54be74c11419d36700066ff2b5653d38be5", "mojo_core_unittests": "bcfdfe4a3cc72e930864b90c8be5756115758fd1", "mojo_unittests": "7ee2b2338f15843004423baf8ec9fea5762a9572", "nacl_loader_unittests": "fee13e484ac1a511bb05250972f56dbe214fdda0", "native_theme_unittests": "6eb5beca9ae6b41e22e5e2313779142af3103e40", "net_unittests": "76dd44d43c9930a9094d9bf6029ad4daf6111dce", "notification_helper_unittests": "54d525ac51f7a664845566b98eca23c3c4a5b535", "pdf_unittests": "35eeed0a4f596956018ca9764f2af570c14f7edd", "ppapi_unittests": "a686cac4368b130ba642b5f61d6d2620964685f9", "printing_unittests": "11dc1a23b6cd4a36a4cb275c593c73a363a453c9", "remoting_unittests": "b5309f0d5efa5ede5d2cbc82a5f52d673b17449f", "sbox_integration_tests": "e270c99a12944bca67959616f00b4dd809a010a6", "sbox_unittests": "09bc5a30c86781eed776c6764b2138085d73429f", "sbox_validation_tests": "7c9fce7a78eb05f021f0fe2cc14fd06026c2813c", "service_manager_unittests": "ab2bbc3ff241055794ef699106eb41ee2854201a", "services_unittests": "5fdca8e41ca982ac243401edcbd0d1c9f9b3d625", "setup_unittests": "243e829841b83a46be7676c461044ef465e619e7", "shell_dialogs_unittests": "1c2221748e9384a7f7b20b5bc4a511c0739049bc", "skia_unittests": "b596d10120a591c8c42d29c7f63af2cd30fc4dee", "snapshot_unittests": "ae9f92fb13e308b458f08f6b06c3c166cbe96e2b", "sql_unittests": "2fa29ceec099b676aea50d643cc859358ebc185c", "storage_unittests": "8b4ee7293f50c1a3d4f0fb076c1a0eb07f6c7cb4", "sync_integration_tests": "c8a718a9bf314f16ceb81ba55d0667d9b7cfff99", "telemetry_gpu_unittests": "9e6a97efd055da6f02991257e90f4b5f7163844e", "telemetry_perf_unittests": "da45c887e43234c749173fcbed35427a0545a723", "telemetry_unittests": "5ac606ba3dba6d3bfcb7b169324dba17b36fe16e", "ui_base_unittests": "5a0a842b27687abab18e93257d1307ddabc0868c", "ui_touch_selection_unittests": "1406ecdb32df508c7d48fa18db084f30afbf39c9", "unit_tests": "3b24980e9632c21fdf35854e0422926b695ce10b", "url_unittests": "6a53382f3aa8f759d02c740f33e94a1d0dd86be2", "views_perftests": "d577d75e2afcd43acc5c9496a6ecb865477a6ba8", "views_unittests": "3c8cdc41cb29c028c1f085d258b121a5c8e8bcbc", "viz_unittests": "3d602b553d73a8189f027aab5925a00a937b72c0", "webkit_python_tests": "f456abfcda2c2ec79f715874d21b902251435c0a", "webkit_unit_tests": "64c8eded1aafdf01c8bb98f6da092bc582389473", "wm_unittests": "95d32a00348be412973051470007bb667a0fb334", "wtf_unittests": "b61a6c81598247005a771dced62701597d488776", "zucchini_unittests": "fde600b0972ba94b8c41fb603584692869860810"} isolate tests
build_archive_url "gs://chromium-win-archive/chromium.win/Win x64 Builder/full-build-win32_f7c234b0272dff6ce746e9eaac813497986913c3.zip" package build

Blamelist:

  1. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  2. Becky Zhou (huayinzohnoyoudont@chromium.org)
  3. Nico Weber (thakisohnoyoudont@chromium.org)
  4. David Grogan (dgroganohnoyoudont@chromium.org)
  5. Nick Burris (nburrisohnoyoudont@google.com)
  6. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  7. Mike Reed (reedohnoyoudont@google.com)
  8. Peter E Conn (peconnohnoyoudont@chromium.org)
  9. Peter Kasting (pkastingohnoyoudont@chromium.org)
  10. Takuto Ikuta (tikutaohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:41:05 UTC
Start Thursday, 12-Jul-18 16:41:11 UTC
End Thursday, 12-Jul-18 16:59:12 UTC
Pending 5 secs
Execution 18 mins

All Changes:

  1. [Fuchsia] Address CR comments in sys::Runner implementation

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:39:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c234b0272dff6ce746e9eaac813497986913c3

    Comments

    [Fuchsia] Address CR comments in sys::Runner implementation
    
    When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
    prematurely and landed the change without my changes that addresed
    review comments. Landing them separately.
    
    Bug: 856416
    Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
    Reviewed-on: https://chromium-review.googlesource.com/1133968
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574598}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/app/component_controller_impl.cc
    • webrunner/app/component_controller_impl.h
    • webrunner/app/main.cc
    • webrunner/app/web_content_runner.cc
    • webrunner/app/web_content_runner.h
  2. [Feed] Scroll and focus handling for the FeedNewTabPage

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:36:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54d1975f16b7efae2408a1428fbde7207556a29

    Comments

    [Feed] Scroll and focus handling for the FeedNewTabPage
    
    + Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
    + Refactor snap scroll logic to a new class to make it reusable
    + Add top padding for the FeedNewTabPage to display correctly on tablet
    + Fix a small bug that search box is not enabled after auto snap scroll
    
    Bug: 860028, 860032, 862470
    Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
    Reviewed-on: https://chromium-review.googlesource.com/1133594
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574597}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
  3. Remove most android-specific hard_timeout and shard overrides.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a64d6771d8b24f079f24e41ebaf14f672747084

    Comments

    Remove most android-specific hard_timeout and shard overrides.
    
    These were added during android swarming bring-up.  We shouldn't use
    per-bot exceptions for this.
    
    Also remove a random sharding setting for base_unittests on ToTMac
    that doesn't look necessary.
    
    Bug: 843511
    Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
    Reviewed-on: https://chromium-review.googlesource.com/1134531
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574596}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.swarm.json
    • testing/buildbot/test_suite_exceptions.pyl
  4. [css-tables] Make table's max-content honor captions' min-content

    Changed by David Grogan - dgroganohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dff5931455e0302289a3cc9027fd3f98cfe22fca

    Comments

    [css-tables] Make table's max-content honor captions' min-content
    
    Table's min-content already honored it.
    
    We'd apparently never been bitten before by tables occasionally having
    min-content > max-content. A new DCHECK in LayoutNG exposed it.
    
    Bug: 857185
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
    Reviewed-on: https://chromium-review.googlesource.com/1121251
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574595}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/table/caption-min-greater-than-max-crash.html
    • third_party/WebKit/LayoutTests/fast/table/spans-min-greater-than-max-crash.html
    • third_party/blink/renderer/core/layout/layout_table.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  5. Settings WebUI: Fix extensions url on cleanup result page

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  6. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  7. suppress until skia roll

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  8. 🤝 Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  9. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  10. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py