Builder Win x64 Builder (dbg) Build 83514

Results:

Success

Trigger Info:

Project	chromium
Revision	99ba5a60e6357f95d4a15465b7b4f44dbc88aa86
Got Revision	99ba5a60e6357f95d4a15465b7b4f44dbc88aa86

Execution:

• Source: Task 42f82996fc580510
• Bot: swarm375-c4
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 695 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 305 ms ) report builders

    

   running builder 'Win x64 Builder (dbg)' on master 'chromium.win'
   • stdout
   • bots.json
3. ( 5 secs ) taskkill
   • stdout
4. ( 1 mins 6 secs ) bot_update

   [100GB/299GB used (33%)]
   • stdout
   • json.output
5. ( 83 ms ) ensure_goma
   • - no logs -
   1. ( 83 ms ) ensure_installed
      • stdout
      • json.output
6. ( 655 ms ) swarming.py --version

   0.14
   • stdout
7. ( 22 secs ) gclient runhooks
   • stdout
8. ( 2 secs ) get compile targets for scripts
   • stdout
   • json.output
9. ( 664 ms ) read test spec (chromium.win.json)

   path: C:\b\swarming\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
   • stdout
   • json.output
10. ( 455 ms ) clean isolated files
    • stdout
11. ( 467 ms ) lookup GN args

     

    ffmpeg_branding = "Chrome"

    is_component_build = true

    is_debug = true

    proprietary_codecs = true

    strip_absolute_paths_from_debug_symbols = true

    symbol_level = 1

    use_goma = true

    goma_dir = "C:\\b\\swarming\\w\\ir\\cache\\goma\\client"
    • stdout
12. ( 28 secs ) generate_build_files
    • stdout
    • swarming-targets-file.txt
13. ( 14 secs ) preprocess_for_goma
    • - no logs -
    1. ( 400 ms ) goma cache directory
       • stdout
    2. ( 12 secs ) start_goma
       • stdout
       • cloudtail
    3. ( 1 secs ) start cloudtail
       • stdout
14. ( 4 mins 31 secs ) compile
    • stdout
15. ( 11 secs ) compile confirm no-op
    • stdout
16. ( 25 secs ) postprocess_for_goma
    • - no logs -
    1. ( 585 ms ) goma_jsonstatus
       • stdout
       • json.output
    2. ( 575 ms ) goma_stat
       • stdout
    3. ( 562 ms ) stop_goma
       • stdout
    4. ( 13 secs ) upload_log
       • stdout
       • json.output
       • compiler_proxy_log
       • ninja_log
    5. ( 10 secs ) stop cloudtail
       • stdout
17. ( 3 mins 44 secs ) isolate tests
    • stdout
    • json.output
18. ( 260 ms ) trigger
    • stdout
19. ( 0 ) recipe result
    • result

Build Properties:

Name	Value	Source
$recipe_engine/buildbucket	{"build": {"builder": {"bucket": "ci", "builder": "Win x64 Builder (dbg)", "project": "chromium"}, "createTime": "2019-02-12T01:35:15.861591Z", "createdBy": "user:luci-scheduler@appspot.gserviceaccount.com", "id": "8921768742193466688", "infra": {"buildbucket": {"serviceConfigRevision": "2acf9ddf085124300131f0a719a64564504c97a6"}, "recipe": {"cipdPackage": "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build", "name": "chromium"}, "swarming": {"hostname": "chromium-swarm.appspot.com"}}, "input": {"gitilesCommit": {"host": "chromium.googlesource.com", "id": "99ba5a60e6357f95d4a15465b7b4f44dbc88aa86", "project": "chromium/src", "ref": "refs/heads/master"}}, "number": 83514, "tags": [{"key": "builder", "value": "Win x64 Builder (dbg)"}, {"key": "buildset", "value": "commit/git/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"}, {"key": "buildset", "value": "commit/gitiles/chromium.googlesource.com/chromium/src/+/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"}, {"key": "scheduler_invocation_id", "value": "9087198804455149584"}, {"key": "scheduler_job_id", "value": "chromium/Win x64 Builder (dbg)"}, {"key": "user_agent", "value": "luci-scheduler"}]}}	setup_build
$recipe_engine/path	{"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"swarm375-c4"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1549935315861591, "id": "8921768742193466688", "project": "chromium", "tags": ["build_address:luci.chromium.ci/Win x64 Builder (dbg)/83514", "builder:Win x64 Builder (dbg)", "buildset:commit/git/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/99ba5a60e6357f95d4a15465b7b4f44dbc88aa86", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9087198804455149584", "scheduler_job_id:chromium/Win x64 Builder (dbg)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"Win x64 Builder (dbg)"	setup_build
buildnumber	83514	setup_build
mastername	"chromium.win"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"	setup_build
got_angle_revision	"6b695c3ffb27ad1df71f4f1682dc7a1d8adc9f31"	bot_update
got_dawn_revision	"62e83971caa1099bdbc334817efa035047c90ddf"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"99ba5a60e6357f95d4a15465b7b4f44dbc88aa86"	bot_update
got_revision_cp	"refs/heads/master@{#631030}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"872455b5fe0cf1f09eb5550fb1e0bdd259523e8b"	bot_update
got_v8_revision_cp	"refs/heads/7.4.138@{#1}"	bot_update
got_webrtc_revision	"f13c2cd9ee41f4ca572232a4e397b05449474632"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26626}"	bot_update
isolate_server	"https://isolateserver.appspot.com"	isolate tests
swarm_hashes_refs/heads/master(at){#631030}_without_patch	{"accessibility_unittests": "b0a7f4c9e3d8101cf415ff29a28836ee43d59ece", "angle_unittests": "c5225194066af19d0aa874ea920a4e3ed8704e4a", "app_shell_unittests": "dfba95eeaf4c479048ccb70989e8dfbd203ebe85", "aura_unittests": "e5969e5a9f4b0576704dd6eab6ddfce22111dee4", "base_unittests": "aa3308e86595a35632a8f7c23ccf6bbfa4c5a6e4", "blink_common_unittests": "3a8bd0d5022d2809c8e80e815ff18e80bfd0af84", "blink_fuzzer_unittests": "d8210ffcb25cdbd1115ddd8a1ee418b6d409ac98", "blink_heap_unittests": "e1573a8780074d2524cc7851b47590cb092c4063", "blink_platform_unittests": "4a3e1b610eb02a01e1653d56b6f804338af74099", "boringssl_crypto_tests": "6ca55fb35b3a9624b2b90f0e49303611f24f5c73", "boringssl_ssl_tests": "f7092be183055d989d056878152c2f0b63f71d03", "cacheinvalidation_unittests": "178d951d3ee1885874f7f25bfb28f41b1f348f92", "capture_unittests": "1fc3241b1dc16ad031667ed23160f065993185b9", "cast_unittests": "5a3122805c97013b870aa2636aeeb0dd771d7041", "cc_unittests": "af0a2417ef2b2fbfef5dfbe1ad6fde87fdff0f6b", "chrome_app_unittests": "f72c749697cc50858397f78df4fa89eec6ef2e90", "chrome_cleaner_unittests": "7d2a206f349ab12f8fbe3df7e7d47a7d69d5c57f", "chrome_elf_import_unittests": "1b4fc1aab4af11b3f0f09900b1df21b1878afc5e", "chrome_elf_unittests": "f7d4d32f2730530f245bf6afb1f57ac3844592ac", "chromedriver_unittests": "0749f8d5c932394663866e2447389a39514663cb", "components_browsertests": "53511a86bb0b86d16d0fcdd6ac73bc7d37399ee3", "components_unittests": "77f50724e8e4b8e367559d04131847c80e72251a", "compositor_unittests": "d9aa32363c163dd287a87875071b08387f15fa9e", "content_browsertests": "0cf819210766c4ba9d277f5232a4373b3776ce9c", "content_shell_crash_test": "afccf2d2a81cb5009d8767cbb124ce020d690948", "content_unittests": "f9a896cf8a3107761135c9808024f478aa901ec3", "courgette_unittests": "f1e791dc17bb29aa4454b0398607172c46d0cc3d", "crashpad_tests": "184d316354ebb9fdfe9be44809cea6a2001399e0", "cronet_tests": "3e3607ecb54baa721da3e5f839014b065e4f7670", "cronet_unittests": "46308ef982424dd6fcd95fa94e9d119abf32b312", "crypto_unittests": "56b7692343d0826563bc0c28eadd8d3da260236b", "device_unittests": "953f15dc47456d0e0cfaff46eb4762534021c3ea", "display_unittests": "16d35e4ee1bf4967132fdd6506d59da324e4826a", "elevation_service_unittests": "ba23337f3845896cd67488b8dd84ad01fbab5bd6", "events_unittests": "3784a66e772f1067606bb3f680c026fee55dfee6", "extensions_browsertests": "1be2fcf96a98e8c7ee7c0e91e765afacc6d0b8a5", "extensions_unittests": "4da07af061f138367cdca60f938ca19cd2920282", "filesystem_service_unittests": "7180fe2d90525ab792c7cf94e003907da85e3fd9", "gcm_unit_tests": "bf7422cdefe11fa644d10748ccac8cccff1d0a6d", "gcp_unittests": "499073f5b014bb6e53954f0af98c499679902e28", "gfx_unittests": "78e2b22fbdc178bb87f893ef84984e8153f72007", "gin_unittests": "70f71d6f4108944aabde0709f73dad1457cee281", "google_apis_unittests": "bf2a73d3c77532a178f89e15bc5218be37c20ddd", "gpu_unittests": "f185f686cbe9092fc672cd816b46c764b4236856", "headless_browsertests": "288d953ad276d97ab3c70fa9413f98203ea1af35", "headless_unittests": "5d04e9c89a57206d80d93a43bb3fb0a73266cf63", "install_static_unittests": "ade250ed604df9ab9a2afa6fd3a7da6c78b27136", "installer_util_unittests": "53446b2f072b7f76ff27da3ea33b16f6247e784b", "interactive_ui_tests": "385c2ba7635410f5986945fa953dde8f4335eadf", "ipc_tests": "df73a17195c5f2ec223a69f450dcd1abe9b7c0da", "jingle_unittests": "471102679749cbcaaced906fcd1908e4a95ef851", "latency_unittests": "b525e75076da5807fbf38a251c618ca69bc43fbb", "leveldb_service_unittests": "4da31f7fdae6078ab99542cdbe39714ef0b84f2d", "libjingle_xmpp_unittests": "80565e752f023f4c28a802a73b1487024675ea62", "media_blink_unittests": "f18a31430b68f908077c87b555090e10516210dd", "media_service_unittests": "91d9dae4a17e5a945c16ebfa536acafd8f93b84c", "media_unittests": "157d0430403c063c8f144f064d577509aabf674c", "message_center_unittests": "8443027c73cc0eeee6fc9de7cbd1aad923bfaae6", "metrics_python_tests": "2d38ddf6260bdf0d780318560b56ca5f276a0944", "midi_unittests": "6afc3c600173edd672a256260e664be93d96efff", "mojo_core_unittests": "f7b1fb98d705a3554084926d92784408179f5153", "mojo_unittests": "0a0ae88d4e940ffc49a4fed95bbafcc412d809ad", "nacl_loader_unittests": "760b29565a5767d316da1c176e99b32b5adb7c57", "native_theme_unittests": "81fd2f207273332062c2b367b21c5e61f3639dff", "net_unittests": "72ca65496847ef1d2c9bad6e57ab3fd18f4845cf", "notification_helper_unittests": "34d0e93db77cd483229e341816fcd7fa019bb24d", "pdf_unittests": "8eb21d52db9c50c15868293abf668ddab1f2387c", "performance_test_suite": "60e327ae0f0d6755de09046094076573a8937077", "ppapi_unittests": "67f82f78e4b9a47678760af40ebd256bc3dc445e", "printing_unittests": "286ba364d1df9fc8f6bcec7c63507f41d0302b8d", "remoting_unittests": "5db6676153364f181d8868e66ed5b21619fb4d69", "sbox_integration_tests": "0700f04441bb6f0093b86d73ee36739f1adf8de0", "sbox_unittests": "1545c80360605396a63b1aab19de61388debfca6", "sbox_validation_tests": "72182cabc7538b9b75f603a57bec0f4772208ef1", "service_manager_unittests": "04c791cbd2adb48c81a53a39e82500fa7d23c066", "services_unittests": "e02c8f4ec1f5f79a2fad38d5d97d11e8e58adf4c", "setup_unittests": "5a74e7bbce53c6b2b9b4e43e569e3ebe8c0e6664", "shell_dialogs_unittests": "9db5226d56174406aa92c05eb4b7136ce95240bb", "skia_unittests": "c8b5474ded6487478833f9ad1742565a68c3463b", "snapshot_unittests": "57e1f79a31df14080f8a23a92c7b6ad4d9f5b691", "sql_unittests": "5f8b9e064b84a0d6da86a797e99e4e4f8941556f", "storage_unittests": "c842f0f19f3ad54dac8a41011f526a1de03dfb53", "sync_integration_tests": "c8c7ac7a4181c3b6c762f8bc3673713806cce0de", "telemetry_gpu_unittests": "0c4ac53c3b52f768bb78bcd5dd7c7811c38e7c75", "telemetry_unittests": "06088734ed42dd5c4be7ad90cfe971f2b10c20a4", "traffic_annotation_auditor_unittests": "948144a58cfa4a019186ad18c9a3b17e466b938a", "ui_base_unittests": "4dfdae56d8346129badfb31381905e0a7f747749", "ui_touch_selection_unittests": "8eeff11b44c6514b35e1029173357e51914181b8", "unit_tests": "6062117fe04c31fc71a8602ea2079029eea9c9d6", "url_unittests": "0c78707f113fbbec3c1b1afdcaad7bd6ae28f6e4", "views_perftests": "790fcdbb3860ce2158d16f6df809d4a7b8578296", "views_unittests": "221d667ed1316292060e2288d49bfa0ade9cb873", "viz_unittests": "fd15be6f018aabb9cc713156e87263870b6f34b8", "vr_common_unittests": "278e22be10c9af8f57e2a92d83b093579d7689fd", "vr_pixeltests": "590678f1948a760f07a958591a8c77e8ad2a563a", "webkit_python_tests": "3fada8352ef1d9a842ba81ebd6169c9bc85d236b", "webkit_unit_tests": "7341895ff8b15402f3c2efd1f3134d0d63c93730", "wm_unittests": "1a58a5419e887af387633dd0461b62790c890d00", "wtf_unittests": "1025b576e41f44da8690aff54ec27960466530f7", "zucchini_unittests": "d59cfce1f0be014bfb6c17a28edf01ae79004eea"}	isolate tests

Blamelist:

1. Mounir Lamouri (mlamouriohnoyoudont@chromium.org)
2. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
3. Pavel Feldman (pfeldmanohnoyoudont@chromium.org)
4. Robert Ogden (robertogdenohnoyoudont@chromium.org)
5. Nico Weber (thakisohnoyoudont@chromium.org)

Timing:

Create	Tuesday, 12-Feb-19 01:35:15 UTC
Start	Tuesday, 12-Feb-19 01:35:18 UTC
End	Tuesday, 12-Feb-19 01:49:51 UTC
Pending	3 secs
Execution	14 mins 33 secs

All Changes:

1. Reland "Picture-in-Picture: move key methods into a service."

   Changed by	Mounir Lamouri - mlamouriohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:27:47 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	99ba5a60e6357f95d4a15465b7b4f44dbc88aa86

   Comments

   Reland "Picture-in-Picture: move key methods into a service."
   
   This reverts commit 9a3eafe448d45259b15e2c8bfa4916da2b39ee75.
   
   Reason for revert: the flake source was found and the test will be disabled until then.
   
   Original change's description:
   > Revert "Picture-in-Picture: move key methods into a service."
   >
   > This reverts commit 45675d0dfab5de54253d40cb2bd52ef034c3a200.
   >
   > Reason for revert: Speculative revert for crbug.com/930338
   >
   > Original change's description:
   > > Picture-in-Picture: move key methods into a service.
   > >
   > > This is moving most of the Picture-in-Picture feature into a service.
   > > Follow-up CLs will move the remaining methods and some Android auto-pip
   > > code. It will also include further cleanups.
   > >
   > > This CL was meant to be the smallest CL that could move the core feature
   > > set without breaking compilation or tests. It's larger than expected.
   > >
   > > Bug: 919860, 908400
   > > Change-Id: I72c5faad9a14de6645a7cd1565b29d6a353e24a3
   > > Binary-Size: cause unknown, landing approved by agrieve@
   > > Reviewed-on: https://chromium-review.googlesource.com/c/1379049
   > > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
   > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
   > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
   > > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
   > > Cr-Commit-Position: refs/heads/master@{#630361}
   >
   > TBR=dcheng@chromium.org,dalecurtis@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,agrieve@chromium.org,jochen@chromium.org
   >
   > Change-Id: I88efa31a23ab1c55b256e5813fa20fd2d8776a21
   > No-Presubmit: true
   > No-Tree-Checks: true
   > No-Try: true
   > Bug: 919860, 908400, 930338
   > Reviewed-on: https://chromium-review.googlesource.com/c/1461546
   > Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
   > Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
   > Cr-Commit-Position: refs/heads/master@{#630550}
   
   TBR=dcheng@chromium.org,dalecurtis@chromium.org,beaufort.francois@gmail.com,mlamouri@chromium.org,agrieve@chromium.org,karandeepb@chromium.org,jochen@chromium.org
   
   # Not skipping CQ checks because original CL landed > 1 day ago.
   
   Bug: 919860, 908400, 930338
   Change-Id: I1bd2ab7ade56569a83951ec942685d9f77dc4af5
   Binary-Size: cause unknown, landing approved by agrieve@
   No-Presubmit: true
   Reviewed-on: https://chromium-review.googlesource.com/c/1465063
   Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
   Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
   Reviewed-by: Kentaro Hara <haraken@chromium.org>
   Reviewed-by: Daniel Cheng <dcheng@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631030}

   Changed files

   • chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
   • content/browser/BUILD.gn
   • content/browser/frame_host/render_frame_host_impl.cc
   • content/browser/media/media_web_contents_observer.cc
   • content/browser/media/media_web_contents_observer.h
   • content/browser/picture_in_picture/picture_in_picture_service_impl.cc
   • content/browser/picture_in_picture/picture_in_picture_service_impl.h
   • content/browser/picture_in_picture/picture_in_picture_service_impl_unittest.cc
   • content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
   • content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
   • content/browser/web_contents/web_contents_impl_unittest.cc
   • content/common/media/media_player_delegate_messages.h
   • content/public/app/content_browser_manifest.cc
   • content/renderer/media/renderer_webmediaplayer_delegate.cc
   • content/renderer/media/renderer_webmediaplayer_delegate.h
   • content/renderer/media/stream/webmediaplayer_ms.cc
   • content/renderer/media/stream/webmediaplayer_ms.h
   • content/renderer/media/stream/webmediaplayer_ms_unittest.cc
   • content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
   • content/test/BUILD.gn
   • media/blink/webmediaplayer_delegate.h
   • media/blink/webmediaplayer_impl.cc
   • media/blink/webmediaplayer_impl.h
   • media/blink/webmediaplayer_impl_unittest.cc
   • third_party/blink/public/mojom/BUILD.gn
   • third_party/blink/public/mojom/picture_in_picture/OWNERS
   • third_party/blink/public/mojom/picture_in_picture/picture_in_picture.mojom
   • third_party/blink/public/platform/web_media_player.h
   • third_party/blink/public/platform/web_media_player_client.h
   • third_party/blink/renderer/core/frame/picture_in_picture_controller.h
   • third_party/blink/renderer/core/html/media/html_audio_element.h
   • third_party/blink/renderer/core/html/media/html_media_element.h
   • third_party/blink/renderer/core/html/media/html_video_element.cc
   • third_party/blink/renderer/core/html/media/html_video_element.h
   • third_party/blink/renderer/core/html/media/video_wake_lock_test.cc
   • third_party/blink/renderer/modules/BUILD.gn
   • third_party/blink/renderer/modules/picture_in_picture/DEPS
   • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
   • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.h
   • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_test.cc
   • third_party/blink/renderer/platform/testing/empty_web_media_player.h

2. [ChromeDriver] Remove tests from _NEGATIVE_FILTER

   Changed by	Tatiana Buldina - buldinaohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:19:49 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	8d1bd234344ea13172b7a25375584bcb9d96a44b

   Comments

   [ChromeDriver] Remove tests from _NEGATIVE_FILTER
   
   - testReturningAFunctionInJavascript absent in test list
   - others tests pass locally
   
   Change-Id: I52d24f97aebfb10b1344c3b6927d5ceec3391db7
   Reviewed-on: https://chromium-review.googlesource.com/c/1465073
   Commit-Queue: John Chen <johnchen@chromium.org>
   Commit-Queue: Tatiana Buldina <buldina@chromium.org>
   Reviewed-by: John Chen <johnchen@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631029}

   Changed files

   • chrome/test/chromedriver/test/run_py_tests.py

3. DevTools: manage String and ProtocolMessage types independently.

   Changed by	Pavel Feldman - pfeldmanohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:19:30 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	62194c03a62e64d22fd965f92e15a8ad65f72c08

   Comments

   DevTools: manage String and ProtocolMessage types independently.
   
   Bug: 929862
   Change-Id: I907b342e2503b85fea6e2fbfd3cbbfed1a11db67
   Reviewed-on: https://chromium-review.googlesource.com/c/1464426
   Reviewed-by: Johannes Henkel <johannes@chromium.org>
   Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631028}

   Changed files

   • content/browser/devtools/devtools_session.h
   • third_party/blink/renderer/core/inspector/devtools_session.cc
   • third_party/blink/renderer/core/inspector/devtools_session.h
   • third_party/blink/renderer/core/inspector/inspector_dom_debugger_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_emulation_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_network_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc
   • third_party/blink/renderer/core/inspector/inspector_session_state.cc
   • third_party/blink/renderer/core/inspector/protocol_parser_test.cc
   • third_party/blink/renderer/core/inspector/v8_inspector_string.cc
   • third_party/blink/renderer/core/inspector/v8_inspector_string.h
   • third_party/blink/renderer/platform/cross_thread_copier.h
   • third_party/inspector_protocol/README.chromium
   • third_party/inspector_protocol/code_generator.py
   • third_party/inspector_protocol/encoding/cbor.cc
   • third_party/inspector_protocol/encoding/cbor.h
   • third_party/inspector_protocol/encoding/cbor_test.cc
   • third_party/inspector_protocol/encoding/json_parser.cc
   • third_party/inspector_protocol/encoding/json_parser_test.cc
   • third_party/inspector_protocol/encoding/json_std_string_writer.cc
   • third_party/inspector_protocol/encoding/status.h
   • third_party/inspector_protocol/encoding/str_util.cc
   • third_party/inspector_protocol/lib/CBOR_cpp.template
   • third_party/inspector_protocol/lib/CBOR_h.template
   • third_party/inspector_protocol/lib/DispatcherBase_cpp.template
   • third_party/inspector_protocol/lib/DispatcherBase_h.template
   • third_party/inspector_protocol/lib/FrontendChannel_h.template
   • third_party/inspector_protocol/lib/Values_cpp.template
   • third_party/inspector_protocol/lib/Values_h.template
   • third_party/inspector_protocol/lib/base_string_adapter_cc.template
   • third_party/inspector_protocol/lib/base_string_adapter_h.template
   • third_party/inspector_protocol/templates/Imported_h.template
   • third_party/inspector_protocol/templates/TypeBuilder_cpp.template
   • third_party/inspector_protocol/templates/TypeBuilder_h.template

4. Disable highlight for Previews IPH

   Changed by	Robert Ogden - robertogdenohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:18:43 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	9b58eaed9d581d271d15449aed9b855bcd7cb410

   Comments

   Disable highlight for Previews IPH
   
   I added a helper method for this to allow for easier changes like this
   down the road, if wanted for other features.
   
   Bug: 930877
   Change-Id: Iad809f2e94e85db57e661f610ce63be9619a2dff
   Reviewed-on: https://chromium-review.googlesource.com/c/1465062
   Reviewed-by: Theresa <twellington@chromium.org>
   Commit-Queue: Robert Ogden <robertogden@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631027}

   Changed files

   • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java

5. Remove a few unnecessary semicolons.

   Changed by	Nico Weber - thakisohnoyoudont@chromium.org
   Changed at	Tuesday, 12-Feb-19 01:18:23 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	18e1008abc72e6d9df76ecc2e7538c9a309dbc80

   Comments

   Remove a few unnecessary semicolons.
   
   This CL was uploaded by git cl split.
   
   R=vmiura@chromium.org
   
   Bug: 926235
   Change-Id: I32fb6abf6e06114f42263729b507aeb3a70498cc
   Reviewed-on: https://chromium-review.googlesource.com/c/1464159
   Reviewed-by: Victor Miura <vmiura@chromium.org>
   Commit-Queue: Victor Miura <vmiura@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#631026}

   Changed files

   • gpu/ipc/client/gpu_context_tests.h
   • gpu/ipc/host/shader_disk_cache_unittest.cc