Home | Search | chromium - Builders
Login

Builder Win x64 Builder (dbg) Build 69050 Microsoft Windows

Results:

Internal Failure

Trigger Info:

Projectchromium
Revisionf550a61d86c912dabe13cc71ea1e81762b951ae4

Execution:

Build Properties:

NameValueSource

Blamelist:

  1. tzik (tzikohnoyoudont@chromium.org)
  2. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
  4. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  5. Scott Violet (skyohnoyoudont@chromium.org)
  6. sawtelle (sawtelleohnoyoudont@google.com)
  7. Tetsui Ohkubo (tetsuiohnoyoudont@chromium.org)
  8. Kenneth Russell (kbrohnoyoudont@chromium.org)
  9. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)
  10. Karan Bhatia (karandeepbohnoyoudont@chromium.org)
  11. Daniel Park (danielparkohnoyoudont@chromium.org)
  12. Xiangjun Zhang (xjzohnoyoudont@chromium.org)
  13. angle-chromium-autoroll (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  14. Scott Haseley (shaseleyohnoyoudont@google.com)
  15. Xiaocheng Hu (xiaochenghohnoyoudont@chromium.org)
  16. Darren Shen (shendohnoyoudont@chromium.org)
  17. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  18. Scott Wu (scottwuohnoyoudont@chromium.org)
  19. Ken Rockot (rockotohnoyoudont@chromium.org)
  20. Alexey Baskakov (loysoohnoyoudont@chromium.org)
  21. Michael Giuffrida (michaelpgohnoyoudont@chromium.org)
  22. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  23. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  24. Darren Shen (shendohnoyoudont@chromium.org)
  25. Wez (wezohnoyoudont@chromium.org)
  26. Ramya Nagarajan (ramyanohnoyoudont@chromium.org)
  27. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  28. Scott Violet (skyohnoyoudont@chromium.org)
  29. Ken Rockot (rockotohnoyoudont@chromium.org)
  30. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  31. Min Qin (qinminohnoyoudont@chromium.org)
  32. Bailey Forrest (bcfohnoyoudont@chromium.org)
  33. Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
  34. kylechar (kylecharohnoyoudont@chromium.org)
  35. James Cook (jamescookohnoyoudont@chromium.org)
  36. Peter Kasting (pkastingohnoyoudont@chromium.org)
  37. Nico Weber (thakisohnoyoudont@chromium.org)
  38. Scott Chen (scottchenohnoyoudont@chromium.org)
  39. Daniel Park (danielparkohnoyoudont@chromium.org)
  40. depot-tools-chromium-autoroll (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  41. Scott Violet (skyohnoyoudont@chromium.org)
  42. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  43. Tien-Ren Chen (trchenohnoyoudont@chromium.org)
  44. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  45. proberge (probergeohnoyoudont@chromium.org)
  46. John Rummell (jrummellohnoyoudont@chromium.org)
  47. rajendrant (rajendrantohnoyoudont@chromium.org)
  48. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  49. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  50. Ken Rockot (rockotohnoyoudont@chromium.org)
  51. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  52. Avi Drissman (aviohnoyoudont@chromium.org)
  53. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  54. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  55. Darren Shen (shendohnoyoudont@chromium.org)
  56. Sonny Sasaka (sonnysasakaohnoyoudont@chromium.org)
  57. Yuki Awano (yawanoohnoyoudont@chromium.org)
  58. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  59. Fady Samuel (fsamuelohnoyoudont@chromium.org)
  60. Mike Wasserman (mswohnoyoudont@chromium.org)
  61. Dominik Röttsches (drottohnoyoudont@chromium.org)
  62. kristipark (kristiparkohnoyoudont@chromium.org)
  63. James Cook (jamescookohnoyoudont@chromium.org)
  64. nacl-chromium-autoroll (nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  65. Hongchan Choi (hongchanohnoyoudont@chromium.org)
  66. Min Qin (qinminohnoyoudont@chromium.org)
  67. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  68. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  69. Marcin Wiacek (marcinohnoyoudont@mwiacek.com)
  70. Chris Hamilton (chrishaohnoyoudont@chromium.org)
  71. Nick Burris (nburrisohnoyoudont@google.com)
  72. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  73. Pedro Amaral (amaralpohnoyoudont@chromium.org)
  74. Caitlin Sadowski (supertriohnoyoudont@chromium.org)
  75. Ryan Sturm (ryansturmohnoyoudont@chromium.org)
  76. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  77. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  78. Danyao Wang (danyaoohnoyoudont@chromium.org)
  79. Koji Ishii (kojiiohnoyoudont@chromium.org)
  80. David Dorwin (ddorwinohnoyoudont@chromium.org)
  81. catapult-chromium-autoroll (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  82. Gang Wu (gangwuohnoyoudont@chromium.org)
  83. Yiming Zhou (uwyimingohnoyoudont@google.com)
  84. Taylor Bergquist (tbergquistohnoyoudont@chromium.org)
  85. James Cook (jamescookohnoyoudont@chromium.org)
  86. Marcin Wiacek (marcinohnoyoudont@mwiacek.com)
  87. Christopher Thompson (cthompohnoyoudont@chromium.org)
  88. Jeremy Elson (jelsonohnoyoudont@chromium.org)
  89. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  90. siyua (siyuaohnoyoudont@chromium.org)
  91. Jonathan Ross (jonrossohnoyoudont@chromium.org)
  92. Qingsi Wang (qingsiohnoyoudont@google.com)
  93. Lily Houghton (lilyhoughtonohnoyoudont@chromium.org)
  94. dpapad (dpapadohnoyoudont@chromium.org)
  95. Jiawei Li (lijiaweiohnoyoudont@chromium.org)
  96. Danyao Wang (danyaoohnoyoudont@chromium.org)
  97. Scott Violet (skyohnoyoudont@chromium.org)
  98. Ryan Sleevi (rsleeviohnoyoudont@chromium.org)
  99. Brian Salomon (bsalomonohnoyoudont@google.com)
  100. Joshua Pawlicki (wafflesohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Thursday, 12-Jul-18 02:36:05 UTC
Start N/A
End Thursday, 12-Jul-18 08:37:06 UTC
Pending 6 hrs 1 mins
Execution N/A

All Changes:

  1. Add base::OneShotTimer::FireNow() as a replacement of user_task()

    Changed by tzik - tzikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:25:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f550a61d86c912dabe13cc71ea1e81762b951ae4

    Comments

    Add base::OneShotTimer::FireNow() as a replacement of user_task()
    
    This CL adds base::OneShotTimer::FireNow(), and replaces all user_task()
    call on base::OneShotTimer with FireNow(), as a preparation of
    OnceCallback support of OneShotTimer.
    
    After OneShotTimer starts supporting OnceCallback, user_task() needs to
    change the type of its return value to `const OnceClosure&`, which is
    unusable to run the callback. Assuming all users of user_task() of
    OneShotTimer run the resulting callback immediately and stop the timer,
    FireNow should work as the replacement.
    
    Bug: 850247
    Change-Id: I52617fecfaf75aee19d681838af0e8a6b6f736a1
    Reviewed-on: https://chromium-review.googlesource.com/1128684
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574467}

    Changed files

    • ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
    • ash/policy/policy_recommendation_restorer_unittest.cc
    • ash/system/night_light/night_light_controller.h
    • ash/system/night_light/night_light_controller_unittest.cc
    • ash/system/power/power_button_controller_test_api.cc
    • ash/system/power/power_button_screenshot_controller_test_api.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • base/timer/timer.cc
    • base/timer/timer.h
    • chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.cc
    • chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
    • components/arc/power/arc_power_bridge.cc
    • components/sync/driver/data_type_manager_impl_unittest.cc
    • components/sync/driver/model_association_manager_unittest.cc
    • components/variations/variations_request_scheduler_mobile_unittest.cc
    • content/browser/indexed_db/indexed_db_backing_store.cc
    • content/browser/indexed_db/indexed_db_factory_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_phase_handler.cc
    • media/remoting/renderer_controller_unittest.cc
    • net/disk_cache/simple/simple_index_unittest.cc
    • ui/display/manager/display_configurator.cc
  2. Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 02:20:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00714da94e9a0e147844f4d5625b433cb57cddd6

    Comments

    Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d64781e17af7..32e3d1e37cd6
    
    
    git log d64781e17af7..32e3d1e37cd6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 ehmaldonado@chromium.org Add a library for monitoring.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@32e3d1e37cd6
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ie6794e65ad8cfec457900a56f6808509b810267c
    Reviewed-on: https://chromium-review.googlesource.com/1134450
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574466}

    Changed files

    • DEPS
  3. Expose Arc input method feature to chrome://flags.

    Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:18:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0b63f06694d4bea2639fc3921d69fe2972cd699d

    Comments

    Expose Arc input method feature to chrome://flags.
    
    Bug: 845079
    Change-Id: I9f674c68d3cc442c042dde834a5f3123f15170cf
    Reviewed-on: https://chromium-review.googlesource.com/1131048
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574465}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • tools/metrics/histograms/enums.xml
  4. Settings: fix find in page shortcut handling

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:14:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 123398402602d1d9259cc9e3b71f50eae20c2415

    Comments

    Settings: fix find in page shortcut handling
    
    Bug: 862701
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I10c6f5888d53e0faf055adf9a45216bd83a71767
    Reviewed-on: https://chromium-review.googlesource.com/1133969
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574464}

    Changed files

    • chrome/browser/resources/settings/settings.html
    • chrome/browser/resources/settings/settings_ui/settings_ui.html
  5. chromeos: adds more comments about child modal/transients

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:12:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 20a46d01a72532d0375df58d797487cad764eede

    Comments

    chromeos: adds more comments about child modal/transients
    
    And a DCHECK that we're not attempting to use a DesktopNativeWidgetAura for
    CHILD_MODAL windows.
    
    BUG=none
    TEST=none
    
    Change-Id: I9138c7d5fb83078e6ee5cfe04d8fbf8a12e1cc85
    Reviewed-on: https://chromium-review.googlesource.com/1134048
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574463}

    Changed files

    • ui/views/mus/desktop_window_tree_host_mus.cc
  6. [Picture in Picture] Create PictureInPictureControlEvent

    Changed by sawtelle - sawtelleohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 02:08:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 281b1ee604a3095d93c5bed1eb05e84f57db6966

    Comments

    [Picture in Picture] Create PictureInPictureControlEvent
    
    This change creates a subclass of Event called
    PictureInPictureControlEvent that can be called when
    a custom control is clicked on the Picture in Picture Window
     - the reason for this event specifically is that it also
    contains a String 'id', which is useful for a developer
    to see which control was clicked.
    
    Manual testing was done by initiating the call in
    overlay_window_views.cc by calling controller_->ControlClick() and
    confirming that the Event was triggered. An example can be seen at:
    https://stevensawtelle.github.io/pictureinpicture
        /picture_in_picture_example.html
    
    Note: There is still no built in way of assigning the string based on
    the id of the control that was clicked - that will come in a future CL.
    This CL is just to create the custom event.
    
    Bug: 854271
    Change-Id: Idf8c290c7f7745af8f492d3b3169ba4cadb2386a
    Reviewed-on: https://chromium-review.googlesource.com/1106615
    Commit-Queue: Steven Sawtelle <sawtelle@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: apacible <apacible@chromium.org>
    Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#574462}

    Changed files

    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/core_idl_files.gni
    • third_party/blink/renderer/core/events/BUILD.gn
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.cc
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.h
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.idl
    • third_party/blink/renderer/core/events/picture_in_picture_control_event_init.idl
    • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
  7. Unified: Get default focus on detailed view.

    Changed by Tetsui Ohkubo - tetsuiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:06:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704db340a765dc9972c0018b74fbb2908cb04d0c

    Comments

    Unified: Get default focus on detailed view.
    
    In UnifiedSystemTray, detailed view did not get focus when it is
    transitioned by keyboard.
    
    TEST=manual
    BUG=862504
    
    Change-Id: I9f39359d3fa72be4bff5d42e5a9f98144b1a1bad
    Reviewed-on: https://chromium-review.googlesource.com/1132899
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574461}

    Changed files

    • ash/system/tray/tray_detailed_view.cc
    • ash/system/tray/tray_detailed_view.h
    • ash/system/unified/unified_system_tray_controller.cc
    • ash/system/unified/unified_system_tray_view.cc
  8. Remove fetch_telemetry_dependencies DEPS hook.

    Changed by Kenneth Russell - kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:04:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bec21faa451d3fc5c62018430ec212d46db17707

    Comments

    Remove fetch_telemetry_dependencies DEPS hook.
    
    The recipes are using the new checkout_telemetry_binary_dependencies
    hook instead and the bots no longer set this gyp variable.
    
    Bug: 862640
    Change-Id: I53c136898a21f18d246b431c5b2a6b08bfb6a0d5
    Reviewed-on: https://chromium-review.googlesource.com/1134189
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574460}

    Changed files

    • DEPS
  9. Add chromeosInfoPrivate stylusStatus API (part 1)

    Changed by Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:02:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6279eb8c5898875d456fc753c8e28ca8cea08e80

    Comments

    Add chromeosInfoPrivate stylusStatus API (part 1)
    
    Adds the "stylusStatus" property to chromeosInfoPrivate.get(). Will be:
    - "unsupported" if the device doesn't support stylus input.
    - "supported" if the device supports it.
    
    Part 2 will add:
    - "seen" if supported and stylus has been used at least once or the
      device comes with an internal stylus.
    
    Test: try && manually using supported and unsupported devices
    Bug: 632814
    Change-Id: I343908bcada0d149410875b885416bdc17f907da
    Reviewed-on: https://chromium-review.googlesource.com/1123320
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Reviewed-by: Toni Barzic <tbarzic@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574459}

    Changed files

    • chrome/browser/chromeos/extensions/info_private_api.cc
    • chrome/browser/chromeos/extensions/info_private_apitest.cc
    • chrome/common/extensions/api/chromeos_info_private.json
    • chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
  10. Declarative Net Request: Handle flatbuffer indexed ruleset corruption.

    Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:59:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b7bb4be8c040188b1ad9e36ee9262dd6fcdf8f8

    Comments

    Declarative Net Request: Handle flatbuffer indexed ruleset corruption.
    
    The JSON rulesets provided by an extension for the Declarative Net Request API
    are indexed to a flatbuffer (indexed) format during extension installation. This
    indexed ruleset is excluded from content verification and it is possible that it
    may get corrupted, making the extension ruleset useless.
    
    This CL handles ruleset corruption by re-indexing the JSON ruleset if the
    indexed ruleset fails to load.
    
    BUG=852058
    
    Change-Id: Ief43cd8f2bc030ad634a92e1fcf7656d03abd4c0
    Reviewed-on: https://chromium-review.googlesource.com/1107479
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574458}

    Changed files

    • chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.h
    • extensions/browser/api/declarative_net_request/utils.cc
    • extensions/browser/api/declarative_net_request/utils.h
    • extensions/browser/sandboxed_unpacker.cc
    • tools/metrics/histograms/histograms.xml
  11. [Modern] Modernizes settings action bar

    Changed by Daniel Park - danielparkohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:51:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8b1c7455e423788c982bc899cd32cd635a2d2c

    Comments

    [Modern] Modernizes settings action bar
    
    > Changes action bar color to white
    > Adds shadow on scroll
    > Per Hannah's request, this change also affects ManageStorage
        - White action bar carries over to ManageStorage
    
    Bug: 834600
    Change-Id: Ib09e63bafbf03237ac07ff323743f689a73205fe
    Reviewed-on: https://chromium-review.googlesource.com/1098375
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Daniel Park <danielpark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574457}

    Changed files

    • chrome/android/java/res/drawable-hdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-mdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/layout/add_languages_main.xml
    • chrome/android/java/res/layout/autofill_editor_base.xml
    • chrome/android/java/res/layout/bookmark_add_edit_folder_activity.xml
    • chrome/android/java/res/layout/bookmark_edit.xml
    • chrome/android/java/res/layout/bookmark_folder_select_activity.xml
    • chrome/android/java/res/layout/clear_browsing_data_tabs.xml
    • chrome/android/java/res/layout/homepage_editor.xml
    • chrome/android/java/res/layout/password_entry_editor_interactive.xml
    • chrome/android/java/res/layout/password_entry_exception.xml
    • chrome/android/java/res/layout/payment_request_editor.xml
    • chrome/android/java/res/layout/preferences_action_bar_shadow.xml
    • chrome/android/java/res/menu/prefeditor_editor_menu.xml
    • chrome/android/java/res/values-v17/styles.xml
    • chrome/android/java/res/values-v21/styles.xml
    • chrome/android/java/res/values/colors.xml
    • chrome/android/java/res/values/dimens.xml
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/HomepageEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferenceUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/AddLanguageFragment.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java
    • ui/android/java/res/values-v17/styles.xml
    • ui/android/java/res/values/colors.xml
  12. Mirroring Service: Supports switching between mirroring and remoting.

    Changed by Xiangjun Zhang - xjzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1eb8fa9af662dd108d6033c5d8813db78b8489ee

    Comments

    Mirroring Service: Supports switching between mirroring and remoting.
    
    Add the implementation to support the switching between mirroring and
    remoting. Also changed to only monitor the WiFi status when receiver
    indicates that it supports the get status message.
    
    Bug: 734672
    Change-Id: I72eefbcadc6f790c2573a81976cd9d0e2dbe3ae7
    Reviewed-on: https://chromium-review.googlesource.com/1104966
    Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Yuri Wiitala <miu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574456}

    Changed files

    • components/mirroring/service/BUILD.gn
    • components/mirroring/service/interface.h
    • components/mirroring/service/message_dispatcher.cc
    • components/mirroring/service/message_dispatcher.h
    • components/mirroring/service/message_dispatcher_unittest.cc
    • components/mirroring/service/session.cc
    • components/mirroring/service/session.h
    • components/mirroring/service/session_monitor.cc
    • components/mirroring/service/session_monitor.h
    • components/mirroring/service/session_monitor_unittest.cc
    • components/mirroring/service/session_unittest.cc
  13. Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)

    Changed by angle-chromium-autoroll - angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:48:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a77159361b8dbc319ff208be3a0a38970c79d2c5

    Comments

    Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/89ef177f9475..5598148b7613
    
    
    git log 89ef177f9475..5598148b7613 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 jmadill@chromium.org Vulkan: Don't use gl::ErrorOrResult.
    2018-07-11 jmadill@chromium.org Vulkan: Clean up Error usage.
    2018-07-11 jmadill@chromium.org Vulkan: Move Feature init before device creation.
    2018-07-11 jmadill@chromium.org Generalize Context scratch buffer errors.
    2018-07-11 jmadill@chromium.org Refactor internal format pixel math methods.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@5598148b7613
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: Ib007468f11fc8153eca19ee8925a7558fea89d47
    Reviewed-on: https://chromium-review.googlesource.com/1133872
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574455}

    Changed files

    • DEPS
  14. [scheduler] Refactor QueueCreationParams, separating out QueueTraits

    Changed by Scott Haseley - shaseleyohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 01:47:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 520720d455489da4f863ee202944c7dc0171ceaf

    Comments

    [scheduler] Refactor QueueCreationParams, separating out QueueTraits
    
    QueueTraits is the (deferrable, throttleable, pausable, freezable)
    4-tuple. We will be associating each non-loading TaskType with a
    QueueTraits to map it to a unique task queue.
    
    This CL also forward declares FrameSchedulerImpl in
    main_thread_task_queue.h and cleans up the necessary frame_scheduler_impl.h
    includes in files that were relying on the indirect include.
    
    Bug: 859963
    Change-Id: I84f883379d718d85e5baf806f199181d7e7bf753
    Reviewed-on: https://chromium-review.googlesource.com/1125033
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Commit-Queue: Scott Haseley <shaseley@google.com>
    Cr-Commit-Position: refs/heads/master@{#574454}

    Changed files

    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
    • third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
    • third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
  15. [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition

    Changed by Xiaocheng Hu - xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:45:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bce39b0838948fbed6bcea5f4e88d4890d7edd2

    Comments

    [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition
    
    Since there is no caret position allowed at the sides of a generated or
    pseudo inline box, ComputeNGCaretPosition should skip such box
    fragments.
    
    Existing code only checks GetNode() of the box fragment, which misses
    the case where GetNode() returns a pseudo node, and is fixed in this
    patch.
    
    Bug: 861669
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4e46f25ea07b66fa9b4821a8944db3f854c839ae
    Reviewed-on: https://chromium-review.googlesource.com/1134396
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574453}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position_test.cc
  16. [VK] Tidy up KeyboardController::PopulateKeyboardContent.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:42:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cb32b12d33d62e3e56c9b8c9922aa9d5ca2b68f

    Comments

    [VK] Tidy up KeyboardController::PopulateKeyboardContent.
    
    Just moved some code around. Looks more consistent IMO when every switch
    case early returns.
    
    Bug: 845780
    Change-Id: If828b05cb088395d1e44d83ec038b57e8bffe9bd
    Reviewed-on: https://chromium-review.googlesource.com/1132908
    Reviewed-by: Blake O'Hare <blakeo@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574452}

    Changed files

    • ui/keyboard/keyboard_controller.cc
  17. Luci configs for Oreo Phone Tester on chromium.android

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:40:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c73e96e974871abb7258d040f9bbbdc85c9807e9

    Comments

    Luci configs for Oreo Phone Tester on chromium.android
    
    And move its testing spec to chromium.android
    
    Bug: 862645
    Change-Id: I2a45d509faeba8b75ef8d7ed1b1d8e95e347dddd
    Reviewed-on: https://chromium-review.googlesource.com/1134420
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574451}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
  18. Add icon getter for CWVAutofillSuggestion.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision de45c8fcb6f97db5346bc6a52dc4edba0b7d1f3e

    Comments

    Add icon getter for CWVAutofillSuggestion.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic1c360a24dfdb35581a13cf0532173d66c9f953c
    Reviewed-on: https://chromium-review.googlesource.com/1131050
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: John Wu <jzw@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574450}

    Changed files

    • ios/web_view/internal/autofill/cwv_autofill_suggestion.mm
    • ios/web_view/public/cwv_autofill_suggestion.h
  19. Reland "Use BigBuffer for legacy IPC messages"

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:37:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c5bd80e5a7b379c0539ef33c5722fb1ee974cda

    Comments

    Reland "Use BigBuffer for legacy IPC messages"
    
    This is a reland of 3e126191c1a7a022260c1072b1b9288f09bb2dce,
    unchanged.
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1134079
    fixes the root cause of the failure which caused this to be
    reverted. This CL can land once that one does.
    
    Original change's description:
    > Use BigBuffer for legacy IPC messages
    >
    > This replaces use of ReadOnlyBuffer with a new mojom Message type
    > specific to //ipc. This type maps to another new C++ MessageView type
    > which in turn wraps a BigBufferView.
    >
    > This allows us to transparently fall back onto shared memory for large
    > IPC messages without increasing the number of copies during send or
    > receive in any (small- or large-message) cases.
    >
    > In order to avoid introducing more mojo-base targets, this also removes
    > the remaining [Native] structs from mojo_base mojom (LOGFONT and
    > FileInfo) and replaces them with real mojom structures + StructTraits,
    > thus allowing //ipc to depend on mojo/public/*/base in its entirety.
    >
    > Also fixes random missing public_deps entries for a
    > chrome/services/file_util typemap, because it decided to start breaking
    > all of my local builds. :3
    >
    > Bug: 784069
    > Change-Id: I359b964ffc1fe44ffd6aa704405ea63156f4fbc9
    > Reviewed-on: https://chromium-review.googlesource.com/1131685
    > Commit-Queue: Ken Rockot <rockot@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573956}
    
    TBR=dcheng@chromium.org
    
    Bug: 784069
    Change-Id: I1224367e9db026cb06b0099ee5dfdada89804f23
    Reviewed-on: https://chromium-review.googlesource.com/1134100
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574449}

    Changed files

    • chrome/services/file_util/public/mojom/safe_archive_analyzer.typemap
    • ipc/BUILD.gn
    • ipc/OWNERS
    • ipc/ipc.mojom
    • ipc/ipc_message_pipe_reader.cc
    • ipc/ipc_message_pipe_reader.h
    • ipc/ipc_message_utils.cc
    • ipc/ipc_message_utils.h
    • ipc/ipc_mojo_bootstrap_unittest.cc
    • ipc/message.typemap
    • ipc/message_mojom_traits.cc
    • ipc/message_mojom_traits.h
    • ipc/message_view.cc
    • ipc/message_view.h
    • ipc/typemaps.gni
    • mojo/public/cpp/base/BUILD.gn
    • mojo/public/cpp/base/file_info.typemap
    • mojo/public/cpp/base/file_info_mojom_traits.cc
    • mojo/public/cpp/base/file_info_mojom_traits.h
    • mojo/public/cpp/base/logfont_win.typemap
    • mojo/public/cpp/base/logfont_win_mojom_traits.cc
    • mojo/public/cpp/base/logfont_win_mojom_traits.h
    • mojo/public/cpp/base/time.typemap
    • mojo/public/cpp/base/time_mojom_traits.h
    • mojo/public/mojom/base/file_info.mojom
    • mojo/public/mojom/base/logfont_win.mojom
    • mojo/public/tools/bindings/chromium_bindings_configuration.gni
  20. WebApp: Extract web_applications source sets in GN.

    Changed by Alexey Baskakov - loysoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:36:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d538ba3e10d2498292aa429cef90d8b6c18473cd

    Comments

    WebApp: Extract web_applications source sets in GN.
    
    This CL reflects the existing dependencies and dependency
    cycles we have.
    
    Also, we want to establish the following folders in web_applications/:
    1) components/
    Any independent components which are shared between extensions/
    and web_applications/
    
    2) extensions/
    A code which is thematically part of chrome/browser/extensions/
    E.g. an upcoming BookmarkAppInstaller will be used by extensions.
    
    3) bookmark_apps/
    Any extension-based high-level helpers which are used by chrome/browser/
    
    Note that web_applications/policy content will be moved to
    web_applications/bookmark_apps/policy/
    
    Bug: 860581
    Change-Id: Ib89f0e327759cfab050caceae5818c8e72f40f08
    Reviewed-on: https://chromium-review.googlesource.com/1128665
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574448}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/extensions/BUILD.gn
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/web_applications/BUILD.gn
    • chrome/browser/web_applications/bookmark_apps/BUILD.gn
    • chrome/browser/web_applications/components/BUILD.gn
    • chrome/browser/web_applications/extensions/BUILD.gn
    • chrome/browser/web_applications/policy/BUILD.gn
    • chrome/test/BUILD.gn
  21. Add isDemoSession to chrome.app.runtime LaunchData

    Changed by Michael Giuffrida - michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:33:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 456e84e95d9f7060c117953d251e121bc052b158

    Comments

    Add isDemoSession to chrome.app.runtime LaunchData
    
    Adds the |isDemoSession| boolean property to launch data for the
    chrome.app.runtime.onLaunched event.
    
    Built-in platform apps on Chrome OS will check this to enable special
    Chrome OS Demo Mode behavior.
    
    This CL adds the property as |false|; a follow-up CL will correctly set
    it to |true| when the device is actually in Demo Mode.
    
    Bug: 835024
    Change-Id: Ie77f50f1551c3dfb00fff27e7779775ceca1f44d
    Reviewed-on: https://chromium-review.googlesource.com/1121113
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574447}

    Changed files

    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/test/data/extensions/platform_apps/launch_file/test.js
    • chrome/test/data/extensions/platform_apps/launch_whitelisted_ext_with_file/test.js
    • chromecast/browser/extensions/cast_extensions_browser_client.cc
    • chromecast/browser/extensions/cast_extensions_browser_client.h
    • extensions/browser/api/app_runtime/app_runtime_api.cc
    • extensions/browser/extensions_browser_client.h
    • extensions/browser/test_extensions_browser_client.cc
    • extensions/browser/test_extensions_browser_client.h
    • extensions/common/api/app_runtime.idl
    • extensions/renderer/resources/app_runtime_custom_bindings.js
    • extensions/shell/browser/shell_extensions_browser_client.cc
    • extensions/shell/browser/shell_extensions_browser_client.h
  22. Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:32:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b787d55ee623265f615215231a0fe6bc860b1

    Comments

    Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/b165ffb64e59..d8882193737a
    
    
    git log b165ffb64e59..d8882193737a --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 hnakashima@chromium.org Inline GetMarkParamPairAtIndex into FPDFPageObjMark_GetParamKey.
    2018-07-11 thestig@chromium.org Roll third_party/yasm/source/patched-yasm/ b98114e18..720b70524 (1 commit)
    2018-07-11 hnakashima@chromium.org Rename content mark parameter value getters.
    2018-07-11 hnakashima@chromium.org Remove clunky mark property value getters by index.
    2018-07-11 hnakashima@chromium.org Write marked content operators when generating a stream.
    2018-07-11 hnakashima@chromium.org Store property name for marked content with an indirect dict.
    2018-07-11 hnakashima@chromium.org Cleanup CPDF_ContentMark.
    2018-07-11 hnakashima@chromium.org Split CPDF_ContentMark::AddMark() into three versions.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@d8882193737a
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I7acff8886402b7c92a599963707f72dacaa02ffa
    Reviewed-on: https://chromium-review.googlesource.com/1133877
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574446}

    Changed files

    • DEPS
  23. [Fuchsia] Add Context, Frame stubs; implement service glue.

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e26716b5bc2bfab8f7ae74d7418e0ac14749223f

    Comments

    [Fuchsia] Add Context, Frame stubs; implement service glue.
    
    * Add ContextImpl service.
    * Add FrameImpl service.
    * Add support for exiting after final disconnect to ContextProvider.
    * Add Context process startup logic to main.cc.
    * Rename webrunner_main.cc to web_context_service_main.cc.
    
    Bug: 852145
    Change-Id: I87228259472cc0ef1044ea3e00f94de9a0f61990
    Reviewed-on: https://chromium-review.googlesource.com/1114321
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574445}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/service/common.h
    • webrunner/service/context_impl.cc
    • webrunner/service/context_impl.h
    • webrunner/service/context_provider_impl.cc
    • webrunner/service/context_provider_impl.h
    • webrunner/service/context_provider_impl_unittest.cc
    • webrunner/service/frame_impl.cc
    • webrunner/service/frame_impl.h
  24. [VK] Swap top/left in parsing SetDraggableArea arguments.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:22:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5f10ba6b2e7f231a2ec6fb549f1b470da3f17a2

    Comments

    [VK] Swap top/left in parsing SetDraggableArea arguments.
    
    'x' was mistakenly matched with 'top' and 'y' with 'left'. Should be
    the other way around. The old UI worked because x and y were the same
    (0, 0), but that's no longer true with the new UI.
    
    TBR=blakeo@chromium.org
    
    Bug: 859405, 856475
    Test: Manual
    Change-Id: I3ac31c4386abb7f86d850fea25ffb543419cf287
    Reviewed-on: https://chromium-review.googlesource.com/1133601
    Reviewed-by: Darren Shen <shend@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574444}

    Changed files

    • chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
  25. Migrate //ipc test off of QuitCurrent*Deprecated().

    Changed by Wez - wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:21:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fdb9848c74490ec3cfe0faddb95e3a26d08f51de

    Comments

    Migrate //ipc test off of QuitCurrent*Deprecated().
    
    Bug: 844016
    Change-Id: If763ff6c6dc73de39e48710c3ecb7e1014a97d0f
    Reviewed-on: https://chromium-review.googlesource.com/1132473
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574443}

    Changed files

    • ipc/ipc_channel_mojo_unittest.cc
  26. [NTP] Adds service integration to request photos.

    Changed by Ramya Nagarajan - ramyanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:20:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a29136f7c12d930aa75521113d85fca0378bb564

    Comments

    [NTP] Adds service integration to request photos.
    
    Adds a service request and callback to get Google Photos from an album.
    An access token for the signed-in user with requisite scope is
    obtained and used in the request.
    
    Bug: 839152
    Change-Id: I3b012b8cdba247d94052c774dd0b1ae1be070d14
    Reviewed-on: https://chromium-review.googlesource.com/1114231
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574442}

    Changed files

    • chrome/browser/search/background/ntp_background.proto
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/background/ntp_background_service.h
    • chrome/browser/search/background/ntp_background_service_factory.cc
    • chrome/browser/search/background/ntp_background_service_observer.h
    • chrome/browser/search/background/ntp_background_service_unittest.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/search/local_ntp_source.h
    • tools/metrics/histograms/histograms.xml
    • tools/traffic_annotation/summary/annotations.xml
  27. Roll src/third_party/catapult 1af68170e543..39de3d225856 (1 commits)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:14:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d4bb6ed80fc74f40da5499723417d45ab616119

    Comments

    Roll src/third_party/catapult 1af68170e543..39de3d225856 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/1af68170e543..39de3d225856
    
    
    git log 1af68170e543..39de3d225856 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Remove unnecessary histogram lookups.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@39de3d225856
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:862666
    TBR=sullivan@chromium.org
    
    Change-Id: I748004dfd1269077f1c4648897b9d698baadb301
    Reviewed-on: https://chromium-review.googlesource.com/1133876
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574441}

    Changed files

    • DEPS
  28. chromeos: fixs bugs where top-levels were never deleted

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2534b278418c9e9e6b1c701a182b36a5723d436

    Comments

    chromeos: fixs bugs where top-levels were never deleted
    
    Requests from a client to delete a top-level where not actually
    deleting the aura::Window.
    
    This also makes printing the window hierarchy include the remote id of the
    window, which is useful for debugging.
    
    BUG=none
    TEST=covered by tests
    
    Change-Id: Icd3eae0839558d6db277bfeaf5fd3b7dd2fde377
    Reviewed-on: https://chromium-review.googlesource.com/1134510
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574440}

    Changed files

    • ash/accelerators/debug_commands.cc
    • ash/shell.h
    • services/ui/ws2/server_window.cc
    • services/ui/ws2/server_window.h
    • services/ui/ws2/window_service.cc
    • services/ui/ws2/window_service.h
    • services/ui/ws2/window_tree.cc
    • services/ui/ws2/window_tree.h
    • services/ui/ws2/window_tree_test_helper.cc
    • services/ui/ws2/window_tree_test_helper.h
    • services/ui/ws2/window_tree_unittest.cc
  29. Mojo: Clean up MojoArmTrap API

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:11:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7831a95dc47fbf2e72acba0de69703380076e333

    Comments

    Mojo: Clean up MojoArmTrap API
    
    Modifies MojoArmTrap() to place its outputs in a single buffer of
    MojoTrapEvent structures, rather than inlining all the event fields as
    output parameters. This means that traps which fail to arm can
    provide the caller with information in the same form that an actual
    event handler would receive it.
    
    Also finally cleans up trap unittests, taking advantage of capturing
    lambdas, removing the hacked in adaptations to old watcher APIs,
    
    TBR=kinuko@chromium.org
    
    Bug: 819046
    Change-Id: Ib2917df06611cbbe8406a65bcdcac71011f52e88
    Reviewed-on: https://chromium-review.googlesource.com/1133962
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574439}

    Changed files

    • mojo/core/core.cc
    • mojo/core/core.h
    • mojo/core/dispatcher.cc
    • mojo/core/dispatcher.h
    • mojo/core/entrypoints.cc
    • mojo/core/trap_unittest.cc
    • mojo/core/watcher_dispatcher.cc
    • mojo/core/watcher_dispatcher.h
    • mojo/public/c/system/README.md
    • mojo/public/c/system/thunks.cc
    • mojo/public/c/system/thunks.h
    • mojo/public/c/system/trap.h
    • mojo/public/cpp/system/simple_watcher.cc
    • mojo/public/cpp/system/wait.cc
    • mojo/public/cpp/system/wait_set.cc
    • third_party/blink/renderer/core/mojo/mojo_watcher.cc
  30. Update translation expectation.pyl

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:09:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975

    Comments

    Update translation expectation.pyl
    
    https://crrev.com/c/1118926 had a typo in the script.
    This CL fixes it.
    
    TBR=brucedawson@chromium.org
    
    Bug: 862827
    Change-Id: I2238ca092e7f77a24ac52e379a9a9089df549c4d
    Reviewed-on: https://chromium-review.googlesource.com/1133602
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574438}

    Changed files

    • tools/gritsettings/translation_expectations.pyl
  31. Don't reset TabDownloadState on history back/forward

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:57:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01a6365651e0b1e9896b251411a18a4ab5a4306d

    Comments

    Don't reset TabDownloadState on history back/forward
    
    Currently performing forward/backward on a tab will reset the TabDownloadState.
    Which allows javascript code to do trigger multiple downloads.
    This CL disables that behavior by not resetting the TabDownloadState on
    forward/back.
    It is still possible to reset the TabDownloadState through user gesture
    or using browser initiated download.
    
    BUG=848535
    
    Change-Id: I7f9bf6e8fb759b4dcddf5ac0c214e8c6c9f48863
    Reviewed-on: https://chromium-review.googlesource.com/1108959
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574437}

    Changed files

    • chrome/browser/download/download_request_limiter.cc
    • chrome/browser/download/download_request_limiter.h
    • chrome/browser/download/download_request_limiter_unittest.cc
  32. [chromecast] BLE: Silently ignore unrecognized disconnenect events

    Changed by Bailey Forrest - bcfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a3aa0471bc5652b265991619cde6b1486018b6b6

    Comments

    [chromecast] BLE: Silently ignore unrecognized disconnenect events
    
    - There may be other processes in the system which are
      connecting/disconnecting BLE devices.
    - We may receive extra disconnect events
    
    Bug: b/110965632
    Test: Does not log if called with unrecognized device.
    Change-Id: I3059435ea5df6919e12a87852c27e716a0f106b5
    Reviewed-on: https://chromium-review.googlesource.com/1119657
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Bailey Forrest <bcf@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574436}

    Changed files

    • chromecast/device/bluetooth/le/gatt_client_manager_impl.cc
  33. [LayoutNG] Force legacy for SVG foreignObject

    Changed by Morten Stenshorne - mstenshoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:50:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c1a46035e2a6626e5948f97687055c8102ac38bc

    Comments

    [LayoutNG] Force legacy for SVG foreignObject
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I12c7d4dd4af0392c2dd2d75c884dc36bff3624ab
    Reviewed-on: https://chromium-review.googlesource.com/1133164
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574435}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/svg/extensibility/foreignObject/foreign-object-margin-collapsing.html
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/custom/dominant-baseline-hanging-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/custom/foreign-object-skew-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/foreignObject/svg-document-in-html-document-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/foreignObject/svg-document-in-html-document-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/zoom/page/zoom-foreignObject-expected.txt
    • third_party/blink/renderer/core/svg/svg_foreign_object_element.h
  34. Revert "Updating Viz Content BrowserTests Filter"

    Changed by kylechar - kylecharohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1aa80280d36b8411d252286601369145224f684

    Comments

    Revert "Updating Viz Content BrowserTests Filter"
    
    This reverts commit a57a12587f7ace3b15480262c181ced968346ea4.
    
    Reason for revert: SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest is failing.
    
    Original change's description:
    > Updating Viz Content BrowserTests Filter
    > 
    > A few tests have been fixed. This updates the filter accordingly to re-enable them.
    > 
    > TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    > SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF
    > Bug: 848825, 848348
    > 
    > Change-Id: If05696e57dfee18cc6ae06c21f7d968982c31219
    > Reviewed-on: https://chromium-review.googlesource.com/1133863
    > Reviewed-by: Jonathan Ross <jonross@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574302}
    
    TBR=jonross@chromium.org,kylechar@chromium.org
    
    Change-Id: Ic6de880ae04a3535c00bfab1cf39e61a335fe43e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 848825, 848348
    Reviewed-on: https://chromium-review.googlesource.com/1134144
    Reviewed-by: kylechar <kylechar@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574434}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  35. Clean up MASH_DEPRECATED in shelf auto-hide code

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:45:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3bccf529dd2431e9fba3265b4cc678704182d272

    Comments

    Clean up MASH_DEPRECATED in shelf auto-hide code
    
    I verified that autohide works properly under mash with mouse gestures,
    touch gestures, and bezel gestures.
    
    Bug: 636647, 631216
    Test: ash_unittests, manual on device
    Change-Id: I368a72a96dbac9791eb67ede9adc739e1d9079fb
    Reviewed-on: https://chromium-review.googlesource.com/1134405
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574433}

    Changed files

    • ash/shelf/shelf.cc
    • ash/shelf/shelf.h
  36. Update Mac frame positioning code to be more coherent.

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:45:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc5161c7ebd754433b509f7633c27661fe579233

    Comments

    Update Mac frame positioning code to be more coherent.
    
    This makes a couple of minor changes:
    * Consistently position the tabstrip with a 4 DIP gap to any following buttons,
      which in turn have a GetAvatarIconPadding()-size gap after them.  In turn this
      hardcoded 4 value will change to a function call in my next patch, so I'm not
      worried about having a great constant name/comment for it.
    * Make the conditions for how we reserve space be in the same order as for how
      we actually position the buttons.
    * Slight naming and similar changes to try and be more consistent.
    
    Bug: none
    Change-Id: I6116c74ac866886c1910ce824934fcf3c75e5fb0
    Reviewed-on: https://chromium-review.googlesource.com/1132604
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574432}

    Changed files

    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
  37. Make blink's {CORE,PLATFORM,MODULES}_TEMPLATE_CLASS_EXPORT macros no-ops.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:36:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59aea43550238d1866c865e032633e101e7f1fa4

    Comments

    Make blink's {CORE,PLATFORM,MODULES}_TEMPLATE_CLASS_EXPORT macros no-ops.
    
    On Windows, the macro already had no effect.
    
    Export on template classes doesn't make a lot of sense: The template itself
    doesn't exist, only its instantiations do. The export is inherited by the
    instantiations, so if the template had an instantiation in
    core/platform/modules then that instantiation would be visible outside the
    respective .so, but without an explicit instantation declaration, clients
    outside those sos still get their own instantation and that doesn't really do
    anything.
    
    (The bindings generator also uses this macro on explicit template
    specializations which _are_ instantiations, so the macro does have
    a useful effect there -- but it looks like the effect there isn't needed
    since everything builds fine with this patch applied.)
    
    While here, also remove a warning suppression pragma for a warning that's
    been disabled globally since #492411.
    
    Bug: 859989
    Change-Id: Ib22993d06f3ad62c79e2b53b010614ae6577d227
    Reviewed-on: https://chromium-review.googlesource.com/1133329
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574431}

    Changed files

    • third_party/blink/renderer/core/core_export.h
    • third_party/blink/renderer/modules/modules_export.h
    • third_party/blink/renderer/platform/platform_export.h
  38. Reland "Extensions: remove dependency on iron-icons"

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:33:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9235ca8bfe3062c2397a3cb5ef107396adc6a01a

    Comments

    Reland "Extensions: remove dependency on iron-icons"
    
    Some files were depending on iron-icons/iron-icons.html to pull in
    iron-icon/iron-icon.html. Needed to add direct dependency to
    iron-icon.html, once iron-iconS.html was no longer imported.
    
    Bug: 855205
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Icd95f6b178a40d7169611721deef38b04e291257
    Reviewed-on: https://chromium-review.googlesource.com/1133588
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574430}

    Changed files

    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/drop_overlay.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/icons.html
    • chrome/browser/resources/md_extensions/item.html
    • chrome/browser/resources/md_extensions/item.js
    • chrome/browser/resources/settings/about_page/about_page.html
    • chrome/browser/resources/settings/about_page/about_page.js
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/browser/resources/settings/icons.html
    • chrome/browser/resources/settings/languages_page/languages_page.html
    • chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
    • chrome/test/data/webui/extensions/extension_error_page_test.js
    • chrome/test/data/webui/extensions/extension_item_test.js
    • chrome/test/data/webui/settings/about_page_tests.js
    • ui/webui/resources/cr_elements/icons.html
  39. [Modern] Updates help icon to match new specs

    Changed by Daniel Park - danielparkohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:30:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdcc3926f1af7e14fce9dd7337a0127dde9a10ef

    Comments

    [Modern] Updates help icon to match new specs
    
    > Creates xml file of new help icon
    > Removes pngs of the old help_and_feedback icon
    
    Bug: 834600
    Change-Id: Ieadda6e2771c8a57d1995d047aa418381618aef6
    Reviewed-on: https://chromium-review.googlesource.com/1044490
    Commit-Queue: Daniel Park <danielpark@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574429}

    Changed files

    • chrome/android/java/res/drawable-hdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-mdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-xhdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-xxhdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable-xxxhdpi/ic_help_and_feedback.png
    • chrome/android/java/res/drawable/ic_help_and_feedback.xml
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ChosenObjectPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/TranslatePreferences.java
  40. Roll src/third_party/depot_tools c3975e55e146..d64781e17af7 (1 commits)

    Changed by depot-tools-chromium-autoroll - depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 00:29:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3789a4a02293b9ded7d922cfc47462e25d7bc20d

    Comments

    Roll src/third_party/depot_tools c3975e55e146..d64781e17af7 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c3975e55e146..d64781e17af7
    
    
    git log c3975e55e146..d64781e17af7 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 ehmaldonado@chromium.org gclient_scm: Fetch refs/changes/* when syncing.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@d64781e17af7
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:858894
    TBR=agable@chromium.org
    
    Change-Id: If022f0d17cbb6ad978d73fb45f85215dfca5033e
    Reviewed-on: https://chromium-review.googlesource.com/1134447
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574428}

    Changed files

    • DEPS
  41. chromeos: test case for fixing infinite loop in cursor lookup

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:26:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f340807ff46e1662b09c0cf4f73e788a0cbf946b

    Comments

    chromeos: test case for fixing infinite loop in cursor lookup
    
    BUG=862715
    TEST=none
    
    Change-Id: Ic5ac2f60ad310a0b9bb88e0f9430bbdbcc17397c
    Reviewed-on: https://chromium-review.googlesource.com/1134467
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574427}

    Changed files

    • services/ui/ws2/BUILD.gn
    • services/ui/ws2/window_delegate_impl_unittest.cc
  42. Update V8 to version 6.9.352.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 00:25:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 754dce44f60812b309710cc9bbf51da2eaf4e1e2

    Comments

    Update V8 to version 6.9.352.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/8dc93fc4..8b17db68
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ic70862dc831eeb3ae86a02d13d9929c0a05dca45
    Reviewed-on: https://chromium-review.googlesource.com/1134196
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574426}

    Changed files

    • DEPS
  43. [Blink] Invalidate clip path cache if mask layer is mutated

    Changed by Tien-Ren Chen - trchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:20:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c0ef7a52f1d5507732239edfebd81d090d1e027

    Comments

    [Blink] Invalidate clip path cache if mask layer is mutated
    
    This is a speculative fix for https://crbug.com/856818 .
    
    It is speculated that the clip path of an element become valid without
    invalidating its cache, resulting in the associated clip nodes not
    being created, and the newly created mask layer having bad layer state.
    
    BUG=856818
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Iab7acc4eb8007d03b259e6dab4f036e2b11bd900
    Reviewed-on: https://chromium-review.googlesource.com/1130596
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574425}

    Changed files

    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
  44. Roll src/third_party/skia 80247e594d1f..fcc10da18eb5 (1 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 00:14:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06af0aaf8329e8b4f861dd4ed9d89eebf4adfdb2

    Comments

    Roll src/third_party/skia 80247e594d1f..fcc10da18eb5 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/80247e594d1f..fcc10da18eb5
    
    
    git log 80247e594d1f..fcc10da18eb5 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 mtklein@chromium.org fix color management in sprite blitter
    
    
    Created with:
      gclient setdep -r src/third_party/skia@fcc10da18eb5
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I5c8bd079d92f8d8598f032067eb6d0c26f20ca2c
    Reviewed-on: https://chromium-review.googlesource.com/1134446
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574424}

    Changed files

    • DEPS
  45. Chrome Settings: minor fix to settings_toggle_button padding

    Changed by proberge - probergeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:11:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b307437f07306488f4a72f45bec3e1217f0a99b

    Comments

    Chrome Settings: minor fix to settings_toggle_button padding
    
    When using a settings-toggle-button with a sub-label whose contents can
    fit into one or two lines depending on screen resolution, there was no
    way to get consistent vertical padding.
    
    This change explicitly sets padding inside of the settings_toggle_button's
    outerRow element in order to guarantee padding for the item.
    
    This has the negative side-effect of causing the
    settings-toggle-button to expand vertically if the window is resized such that
    the sub-label text overflows to a new line.
    
    Bug: 803683
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iff644e6efb4aa293f4ae41e9035a961578d576f0
    Reviewed-on: https://chromium-review.googlesource.com/1133300
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574423}

    Changed files

    • chrome/browser/resources/settings/controls/settings_toggle_button.html
    • chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
  46. Improve FrameBuffer allocation time

    Changed by John Rummell - jrummellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:09:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 803005b59bef10b2d804a5827d626dcc9d10d906

    Comments

    Improve FrameBuffer allocation time
    
    When allocating a large buffer (via the fuzzer tests), calling resize() on
    std::vector<uint8_t> took a long time. This changes the code to use a
    std::unique_ptr<uint8_t[]> so that allocating a large buffer is much cheaper.
    
    BUG=817341
    TEST=fuzzer test now runs in 535ms instead of timing out after 25 seconds
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If3a57a325dfab4f15d43a71b935e18c2ce759715
    Reviewed-on: https://chromium-review.googlesource.com/1133586
    Commit-Queue: John Rummell <jrummell@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574422}

    Changed files

    • media/filters/frame_buffer_pool.cc
  47. Report data use from renderer to browser page load metrics

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:04:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db2671aa51b5f771f494b2911620711dbdddd115

    Comments

    Report data use from renderer to browser page load metrics
    
    Report the continuous data use to page load metrics in browser process
    via the existing renderer -> browser PageLoadMetrics mojo.
    
    Bug: 836029
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I1c7b47eb41e13f9b72d087e3ca2c0a7096c11b29
    Reviewed-on: https://chromium-review.googlesource.com/1042877
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574421}

    Changed files

    • chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
    • chrome/browser/page_load_metrics/metrics_web_contents_observer.h
    • chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
    • chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
    • chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • chrome/browser/page_load_metrics/page_load_tracker.h
    • chrome/common/page_load_metrics/page_load_metrics.mojom
    • chrome/renderer/BUILD.gn
    • chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
    • chrome/renderer/page_load_metrics/fake_page_timing_sender.h
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
    • chrome/renderer/page_load_metrics/page_resource_data_use.cc
    • chrome/renderer/page_load_metrics/page_resource_data_use.h
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc
    • chrome/renderer/page_load_metrics/page_timing_sender.h
    • components/data_reduction_proxy/DEPS
    • components/data_reduction_proxy/core/common/BUILD.gn
    • components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
  48. [Extensions Click-to-Script] Remove granted hosts when changing access

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:03:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 23cd214fba4ed7ccfad450e53f6683dd428e58cc

    Comments

    [Extensions Click-to-Script] Remove granted hosts when changing access
    
    When transitioning from "on specific sites" to "on click", Chromium
    should remove specific granted sites from the extension. Do so, and
    add unittests for the same.
    
    Bug: 844128
    
    Change-Id: Icfa6c1f6449e94e30560a10cf43163f2fcedd996
    Reviewed-on: https://chromium-review.googlesource.com/1133775
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574420}

    Changed files

    • chrome/browser/extensions/api/developer_private/developer_private_api.cc
    • chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
  49. Reland of: Add mojom call to send resource loading hints from browser to renderer.

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc97029f96fedad41b8600011d6c155810e50fe6

    Comments

    Reland of: Add mojom call to send resource loading hints from browser to renderer.
    
    The mojom call is send only when resource loading hints feature is
    enabled and the connection is slow.
    
    This is a reland of the CL that got reverted due to flaky
    browsertest. This reland is quite similar to the reverted CL,
    except for some changes in the browsertest.
    
    PS#1 is the original CL that got reverted.
    
    The fix is to retry fetching of histograms from the renderers.
    Note that previews_browsertest are currently enabled only on Android.
    So, it's possible that the same flakiness bug is affecting the
    browser tests on Linux in this CL.
    
    Bug: 854666
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I753e488bef7318e43530a5594a94b24bd09295bb
    TBR: rkaplow@chromium.org, dcheng@chromium.org, pkasting@chromium.org, kinuko@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1131918
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574419}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/chrome_content_renderer_manifest_overlay.json
    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.h
    • chrome/browser/ui/tab_helpers.cc
    • chrome/test/BUILD.gn
    • chrome/test/data/previews/resource_loading_hints.html
    • chrome/test/data/previews/resource_loading_hints_with_no_transform_header.html
    • chrome/test/data/previews/resource_loading_hints_with_no_transform_header.html.mock-http-headers
    • components/optimization_guide/proto/hints.proto
    • components/optimization_guide/test_component_creator.cc
    • components/optimization_guide/test_component_creator.h
    • components/previews/content/previews_content_util.cc
    • components/previews/content/previews_decider_impl.cc
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/loader/previews_resource_loading_hints.mojom
    • third_party/blink/renderer/controller/blink_initializer.cc
    • third_party/blink/renderer/core/frame/local_frame.cc
    • third_party/blink/renderer/core/frame/local_frame.h
    • third_party/blink/renderer/core/loader/BUILD.gn
    • third_party/blink/renderer/core/loader/base_fetch_context.cc
    • third_party/blink/renderer/core/loader/previews_resource_loading_hints_receiver_impl.cc
    • third_party/blink/renderer/core/loader/previews_resource_loading_hints_receiver_impl.h
    • tools/metrics/histograms/histograms.xml
  50. Mojo: Fix Mac Mach port brokering race

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:01:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e5b3af2899e6c4888da7ad662ca1d2928e01ce8

    Comments

    Mojo: Fix Mac Mach port brokering race
    
    https://crrev.com/0e45f8023 somehow lost this logic before
    landing, probably during extensive debugging churn. :{
    
    Without this, it's possible for Mach port transfer to fail
    when sending to a new process. Seems to have gone undetected
    in production so far, but https://crrev.com/3e126191 managed
    to trip over it consistently in ipc_tests.
    
    Bug: 753541
    Change-Id: I835dc5f26326718af678acd6199c285d709b9040
    Reviewed-on: https://chromium-review.googlesource.com/1134079
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574418}

    Changed files

    • mojo/core/channel_posix.cc
  51. [CrOS MultiDevice] Delete HostVerifierOperation.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:58:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe23b8a92e64607bd4ceb6a7a8ec9ec4f677a19

    Comments

    [CrOS MultiDevice] Delete HostVerifierOperation.
    
    After today's discussions, Bluetooth verification is no longer a step of
    the MultiDevice setup flow.
    
    Bug: 824568
    Change-Id: I155ec838c74f427cde820fbbbedcdf3a2a43b85b
    Reviewed-on: https://chromium-review.googlesource.com/1134474
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574417}

    Changed files

    • chromeos/services/multidevice_setup/BUILD.gn
    • chromeos/services/multidevice_setup/fake_host_verifier_operation.cc
    • chromeos/services/multidevice_setup/fake_host_verifier_operation.h
    • chromeos/services/multidevice_setup/host_verifier_operation.cc
    • chromeos/services/multidevice_setup/host_verifier_operation.h
    • chromeos/services/multidevice_setup/host_verifier_operation_impl.cc
    • chromeos/services/multidevice_setup/host_verifier_operation_impl.h
    • chromeos/services/multidevice_setup/host_verifier_operation_impl_unittest.cc
  52. Fix the mouse pointer for the omnibox.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:54:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31de41a5cd7078ec8bc0b8bbb2dc82543a59f217

    Comments

    Fix the mouse pointer for the omnibox.
    
    While the results pane is showing, forward cursor requests to the
    underlying omnibox.
    
    Note that this won't actually show any changes until 851834 is fixed.
    
    BUG=836829,851834
    
    Change-Id: I9928fe8f690cc27f1844dbe1c0b3dae08082706d
    Reviewed-on: https://chromium-review.googlesource.com/1130167
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Sidney San Martín <sdy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574416}

    Changed files

    • chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
  53. Update watchlist for breve-team

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:53:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c48822897f1344928af004051305c19b4269d470

    Comments

    Update watchlist for breve-team
    
    Change-Id: Ic12456b72ab2730e5ab1dc79ea44386deb90873d
    Reviewed-on: https://chromium-review.googlesource.com/1134349
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574415}

    Changed files

    • WATCHLISTS
  54. Revert "Update Chrome callsites that use MainThreadFrameObserver"

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:53:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bc3c11ce575df33970f5b0f89160f38878ae9ce

    Comments

    Revert "Update Chrome callsites that use MainThreadFrameObserver"
    
    This reverts commit cb82e2e48313e755713f169fa151199fec459a02.
    
    Reason for revert: Test is failing on multiple builders, e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20Tests%20%28sandboxed%29/48812
    
    Original change's description:
    > Update Chrome callsites that use MainThreadFrameObserver
    > 
    > MainThreadFrameObserver does not guarantee that a compositor frame was actually
    > submitted. It however does synchronize the Renderer's main thread, which allows
    > for syncing Javascript execution in tests.
    > 
    > This updates two tests in chrome/browser to use RenderFrameSubmissionObserver
    > for synchronizing on compositor frame submission. As well as InputEventAckWaiter
    > for synchronizing on input event processing.
    > 
    > TEST=WebViewTest.InterstitialPageFocusedWidget,
    > WebViewBrowserPluginSpecificInteractiveTest.EnsureFocusSynced
    > 
    > Bug: 862683
    > Change-Id: Iae40b92dedf656898b9e77c6529ef118d89e0a6e
    > Reviewed-on: https://chromium-review.googlesource.com/1133960
    > Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    > Commit-Queue: Jonathan Ross <jonross@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574335}
    
    TBR=jonross@chromium.org,fsamuel@chromium.org
    
    Change-Id: Ica0e795ebad4dd81248a8e89b6f02c53e972a203
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862683
    Reviewed-on: https://chromium-review.googlesource.com/1133779
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574414}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  55. [VK] Remove OnWindowHierarchyChanged event handler.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:52:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c597e35ea365cc192bfad7ef1effc618e427004

    Comments

    [VK] Remove OnWindowHierarchyChanged event handler.
    
    In https://crrev.com/14200002, we handled OnWindowHierarchyChanged in
    KeyboardController, which calls OnTextInputStateChanged. Originally,
    the author of the CL wanted to call OnTextInputStateChanged when the
    keyboard is enabled (so that if there's a focused textfield, we would
    show the keyboard [*]). However, OnTextInputChanged requires that the
    keyboard window is attached to a parent, which does not happen until
    later in the code. Hence, the author moved the OnTextInputStateChanged
    call to OnWindowHierarchyChanged, where we know for sure that the
    keyboard window has been attached.
    
    However, with recent changes to KeyboardController, we explicitly
    attach in ActivateKeyboardInContainer, so we can just move the code
    there without issues.
    
    [*] This behaviour is no longer true. OnTextInputChanged can't show
    the keyboard anymore under those circumstances. It may be possible
    to remove the OnTextInputChanged call completely.
    
    Bug: 845780
    Change-Id: I8fb028f3b03435e43c902b40e8ffe48844be1ea3
    Reviewed-on: https://chromium-review.googlesource.com/1132259
    Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574413}

    Changed files

    • ui/keyboard/keyboard_controller.cc
    • ui/keyboard/keyboard_controller.h
  56. device/bluetooth: Add a flag to show all unfiltered devices.

    Changed by Sonny Sasaka - sonnysasakaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:47:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7fecfeda3c0d0e1d1e8c79b141a858cd669335fa

    Comments

    device/bluetooth: Add a flag to show all unfiltered devices.
    
    Newblue development needs to see all the discovered devices unfiltered,
    so this flag is useful for Newblue development and can be removed once
    Newblue is stable.
    
    Bug: 840517
    Change-Id: I65c95c567ebfb8dbb6d831bfb1e1219b153346c0
    Reviewed-on: https://chromium-review.googlesource.com/1130655
    Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
    Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574412}

    Changed files

    • ash/BUILD.gn
    • ash/DEPS
    • ash/system/bluetooth/tray_bluetooth_helper_unittest.cc
    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • device/base/features.cc
    • device/base/features.h
    • device/bluetooth/chromeos/bluetooth_utils.cc
    • device/bluetooth/dbus/bluez_dbus_manager.cc
    • tools/metrics/histograms/enums.xml
  57. Use three way flag for ChromeVox arc support

    Changed by Yuki Awano - yawanoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b51d325c2a6fdc8f7be04d394645da611dd8ccad

    Comments

    Use three way flag for ChromeVox arc support
    
    - Use three way flag for ChromeVox arc support. This allows developers
      to easily switch between TalkBack on arc and ChromeVox arc support.
    - This CL also changes default to disabled (TalkBack on arc).
    
    Bug: 855310
    Test: None
    Change-Id: I301657798247da20eaf9ad734987b8d40790af1d
    Reviewed-on: https://chromium-review.googlesource.com/1130963
    Commit-Queue: Yuki Awano <yawano@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574411}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chromeos/chromeos_features.cc
    • chromeos/chromeos_features.h
    • chromeos/chromeos_switches.cc
    • chromeos/chromeos_switches.h
    • tools/metrics/histograms/enums.xml
  58. No removed or inserted text events on static text nodes

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d103e4761986c5f14e7b904ddf0b143fb1b6799

    Comments

    No removed or inserted text events on static text nodes
    
    Fire only 1 set of text removed/inserted events,
    only on the parent hypertext (not on the static text).
    This helps avoid redundant live region change announcements.
    
    Bug: 778478
    Change-Id: Ic68aab54d46c98576169ecb2146cd6414413e6ac
    Reviewed-on: https://chromium-review.googlesource.com/1134199
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574410}

    Changed files

    • content/test/data/accessibility/event/live-region-change-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
  59. Surface Synchronization: Make Submission Flow Trace Less Noisy

    Changed by Fady Samuel - fsamuelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:38:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 852c66f84007b6c5ee4eb6150ec2534d5797b5b4

    Comments

    Surface Synchronization: Make Submission Flow Trace Less Noisy
    
    Only log an event if the LocalSurfaceId has changed instead of on
    every submit and receipt of CompositorFrames.
    
    Bug: 672962
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I4814ec0aaa9c204864d5c5df0c4a359d4ef3bb28
    Reviewed-on: https://chromium-review.googlesource.com/1134027
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574409}

    Changed files

    • cc/mojo_embedder/async_layer_tree_frame_sink.cc
    • cc/trees/layer_tree_host.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/surfaces/surface.cc
  60. Remove extra spaces in WindowTree logs

    Changed by Mike Wasserman - mswohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59774f864d141afa5605ddba9ad153899c4dc295

    Comments

    Remove extra spaces in WindowTree logs
    
    Makes the debug logging output more consistent
    
    Bug: None
    Test: None
    Change-Id: Ib6ca05df6e06c7bbb31ffca7c027707af7d67966
    Reviewed-on: https://chromium-review.googlesource.com/1134428
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574408}

    Changed files

    • services/ui/ws2/window_tree.cc
  61. Roll HarfBuzz to 1.8.3

    Changed by Dominik Röttsches - drottohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5684ce09c352eb8ca64390c1fdb5f3de5e6bf60

    Comments

    Roll HarfBuzz to 1.8.3
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/058708a665cdd9e796581dbcf60a5778d3f5e240..2b76767bf572364d3d647cdd139f2044a7ad06b2
    
    And disable HB_VECTOR_SIZE define now that HarfBuzz has temporarily
    completed disabled compiler-assisted vectorisation.
    
    Bug: 860250, 862607
    Change-Id: If00101a279b23f5807a85973718183b33647195d
    Reviewed-on: https://chromium-review.googlesource.com/1133384
    Reviewed-by: Ben Wagner <bungeman@chromium.org>
    Commit-Queue: Dominik Röttsches <drott@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574407}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/BUILD.gn
    • third_party/harfbuzz-ng/README.chromium
  62. [NTP] Remove transition duration for MV tile hover states

    Changed by kristipark - kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c37fbfabcaaeabb50bbbf52dfa75c6fa7491e298

    Comments

    [NTP] Remove transition duration for MV tile hover states
    
    Bug: 851656
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I4fc218b0dba1b0dd569088a1665792b933c86ada
    Reviewed-on: https://chromium-review.googlesource.com/1133686
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574406}

    Changed files

    • chrome/browser/resources/local_ntp/most_visited_single.css
  63. Clean up MASH_DEPRECATED in FlagWarningTray and test

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0795efc4ba54976c1ea978ec4c1fafe49e3ed77a

    Comments

    Clean up MASH_DEPRECATED in FlagWarningTray and test
    
    We don't run ash_unittests with --enable-features=Mash anymore, so
    manually turn on the flag to test the feature.
    
    Bug: 840391
    Test: ash_unittests
    Change-Id: Idb61128d9a65cbc6e93095683247c3e8cd714a9d
    Reviewed-on: https://chromium-review.googlesource.com/1134418
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574405}

    Changed files

    • ash/system/flag_warning/flag_warning_tray.cc
    • ash/system/flag_warning/flag_warning_tray_unittest.cc
  64. Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)

    Changed by nacl-chromium-autoroll - nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 23:32:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 382c1d7689514b2bb3449f2ca14209ad5e75c472

    Comments

    Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/0ba35b21089a..e6ce828ef60c
    
    
    git log 0ba35b21089a..e6ce828ef60c --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 thomasanderson@chromium.org Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    
    
    Created with:
      gclient setdep -r src/native_client@e6ce828ef60c
    
    The AutoRoll server is located here: https://nacl-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:None
    TBR=mseaborn@chromium.org
    
    Change-Id: I96d892a8a5520b5394bf8929daf655f2ab9f95e9
    Reviewed-on: https://chromium-review.googlesource.com/1133873
    Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574404}

    Changed files

    • DEPS
  65. Reorg DefaultAudioDestinationNode

    Changed by Hongchan Choi - hongchanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:30:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4247ad3b2fda13e8f4d57b68b639bea7d78df02

    Comments

    Reorg DefaultAudioDestinationNode
    
    No renaming or functional change. Just moving and grouping things
    around. Plus, some clarification/simplification of comments.
    
    Bug: 854229
    Change-Id: I1a4fd3cdaf7fd41fd6c30fc199f281b46b061dc2
    Reviewed-on: https://chromium-review.googlesource.com/1133715
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Reviewed-by: Raymond Toy <rtoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574403}

    Changed files

    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
  66. Don't remove ref-count on download IO TaskRunner

    Changed by Min Qin - qinminohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:30:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 871b0dbb66c85679e88df8f62fd4ec0e3f471594

    Comments

    Don't remove ref-count on download IO TaskRunner
    
    There is no need to remove the IO TaskRunner reference.
    The global io thread task_runner is never deleted.
    If io TaskRunner is set, just ignore future calls.
    
    BUG=842245
    
    Change-Id: Ifefad6442d8efde238379218e9f11a9f3d99a75a
    Reviewed-on: https://chromium-review.googlesource.com/1134197
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574402}

    Changed files

    • components/download/internal/common/download_task_runner.cc
    • content/browser/download/download_manager_impl.cc
  67. Android: consolidate support components for embedders

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:23:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 351a925fcc3c0a950711126c9f4dab65cbee1ed9

    Comments

    Android: consolidate support components for embedders
    
    Moves web_contents_delegate_android under embedder_support to
    consolidate all the support components for embedders. The package path
    is org.chromium.embedder_support.delegate. Now the component
    has 4 main targets for embedders:
     - media
     - view
     - content_view
     - web_contents_delegate
    
    Note:
    
    - The choice of 'delegate' in the package name of WebContentsDelegateAndroid
      is just to avoid having WCDA repeated in the path. (import org.chromium
      .embedder_support.web_contents_delegate_android.WebContentsDelegateAndroid
       looked odd to me).
    - Got rid of 'android' wherever it is repeated in the path, and the deletion
      won't cause confusion.
      e.g. web_contents_delegate_android_java -> web_contents_delegate_java
    - Needs changes in the internal repo as well
      https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/646448
    
    
    Change-Id: I44c25435c32330439ffa765d80df45b02d0694b1
    Reviewed-on: https://chromium-review.googlesource.com/1118926
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Reviewed-by: Cait Phillips <caitkp@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574401}

    Changed files

    • android_webview/BUILD.gn
    • android_webview/browser/DEPS
    • android_webview/browser/aw_web_contents_delegate.h
    • android_webview/java/DEPS
    • android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java
    • android_webview/test/BUILD.gn
    • build/android/lint/suppressions.xml
    • chrome/android/BUILD.gn
    • chrome/android/java/DEPS
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
    • chrome/browser/BUILD.gn
    • chrome/browser/android/DEPS
    • chrome/browser/android/bottombar/overlay_panel_content.cc
    • chrome/browser/android/document/document_web_contents_delegate.cc
    • chrome/browser/android/document/document_web_contents_delegate.h
    • chrome/browser/android/tab_web_contents_delegate_android.h
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/android/color_chooser_dialog_android.cc
    • chrome/test/android/BUILD.gn
    • components/OWNERS
    • components/embedder_support/android/BUILD.gn
    • components/embedder_support/android/delegate/DEPS
    • components/embedder_support/android/delegate/OWNERS
    • components/embedder_support/android/delegate/color_chooser_android.cc
    • components/embedder_support/android/delegate/color_chooser_android.h
    • components/embedder_support/android/delegate/web_contents_delegate_android.cc
    • components/embedder_support/android/delegate/web_contents_delegate_android.h
    • components/embedder_support/android/java/res/drawable-hdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable-mdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable-xhdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable/color_button_background.xml
    • components/embedder_support/android/java/res/drawable/color_picker_border.xml
    • components/embedder_support/android/java/res/layout/color_picker_advanced_component.xml
    • components/embedder_support/android/java/res/layout/color_picker_dialog_content.xml
    • components/embedder_support/android/java/res/layout/color_picker_dialog_title.xml
    • components/embedder_support/android/java/res/values/colors.xml
    • components/embedder_support/android/java/res/values/dimens.xml
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorChooserAndroid.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerAdvanced.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerAdvancedComponent.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerDialog.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerMoreButton.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerSimple.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorSuggestion.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorSuggestionListAdapter.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/DEPS
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/OWNERS
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/OnColorChangedListener.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_am.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ar.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_bg.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ca.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_cs.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_da.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_de.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_el.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_en-GB.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_es-419.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_es.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fa.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fil.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hu.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_id.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_it.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_iw.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ja.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ko.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_lt.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_lv.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_nl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_no.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pt-BR.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pt-PT.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ro.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ru.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sk.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sv.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sw.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_th.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_tr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_uk.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_vi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_zh-CN.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_zh-TW.xtb
    • components/embedder_support/android/java/strings/web_contents_delegate_android_strings.grd
    • components/web_contents_delegate_android/BUILD.gn
    • docs/chromoting_android_hacking.md
    • tools/android/eclipse/.classpath
    • tools/gritsettings/resource_ids
    • tools/gritsettings/translation_expectations.pyl
  68. Import wpt@828cbf6461e1b36ff5ff02310cb7d6749125b57c

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:22:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a94a2187dbcbeca3eab3361df5877f3af0345dd1

    Comments

    Import wpt@828cbf6461e1b36ff5ff02310cb7d6749125b57c
    
    Using wpt-import in Chromium 4df7c6c40ebef72484655dc54db5c40e9f8c2bc2.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21178
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    domenic@chromium.org, ricea@chromium.org:
      external/wpt/streams
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I084c2429c7bc00f6d54eb830a34bcccb62e45c3b
    Reviewed-on: https://chromium-review.googlesource.com/1134081
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574400}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.dedicatedworker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.js
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.serviceworker.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.sharedworker-expected.txt
  69. @IntDef cleanup in chrome/java/externalauth

    Changed by Marcin Wiacek - marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 23:14:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d82ee0010741390a1a6a63bbcc68d95e4b5341b2

    Comments

    @IntDef cleanup in chrome/java/externalauth
    
    @IntDef/@StringDef annotation are preferred way for declaring
    set of String/int values:
    
    1. they need less space in APK than enum, see
    https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
    2. they give more control over allowed values than "static final" values
    
    Main goal of patch is writing "static final" values, enum
    and some classes in one common @IntDef/@StringDef form:
    
    1. with @IntDef/@StringDef first, @Retention second
       and related @interface third
    2. with values inside @interface
    3. with NUM_ENTRIES declaring number of entries if necessary
    4. with comment about numbering from 0 without gaps when necessary
    5. with @Retention(RetentionPolicy.SOURCE)
    6. without "static final" in the @interface
    
    Additionally there are done some other trivial cleanups.
    
    Change-Id: I8285733bbecf695b133a3865310f9a3cf0c515d6
    Reviewed-on: https://chromium-review.googlesource.com/1133983
    Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574399}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/VerifiedHandler.java
  70. Make URLDataSource backend reference a WeakPtr.

    Changed by Chris Hamilton - chrishaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bed9bc8ab47755b9be2032dc398af2060bc94ede

    Comments

    Make URLDataSource backend reference a WeakPtr.
    
    This allows URLDataSources that have been detached from a backend to
    still refer to the backend if it still exists, allowing any pending
    queries that were issued to that backend and routed to the data source
    to resolve back to the backend when they are finished.
    
    BUG=859193
    
    Change-Id: I55eda45be1f24716ad31c7d98ee748a737baca51
    Reviewed-on: https://chromium-review.googlesource.com/1131537
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Chris Hamilton <chrisha@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574398}

    Changed files

    • content/browser/webui/url_data_manager_backend.cc
    • content/browser/webui/url_data_manager_backend.h
    • content/browser/webui/url_data_source_impl.h
  71. Chrome Cleaner UI: Update list of items to be removed to list extensions

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:13:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ff991fb5cf3ff872e2096ac735376369aaed5d87

    Comments

    Chrome Cleaner UI: Update list of items to be removed to list extensions
    
    - Also add tests for displaying extensions, refactoring tests to a loop
    instead of writing all possible combinations like before.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I5a02771b339751e44df4ceb1bb6f58a7796968b4
    Reviewed-on: https://chromium-review.googlesource.com/1127180
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574397}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  72. [CrOS MultiDevice] Tweak an EasyUnlock string description.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:09:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d93874c2172b2c280b99e15fad1269c658a25fa

    Comments

    [CrOS MultiDevice] Tweak an EasyUnlock string description.
    
    This fix was suggested by our UX writer jonann@ in b/111006044.
    
    Bug: 824568
    Change-Id: If888000ed030b0dd90436729c77cb861a59305f9
    Reviewed-on: https://chromium-review.googlesource.com/1133710
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574396}

    Changed files

    • chrome/app/settings_strings.grdp
  73. Call generic isShowingAppMenuUpdateBadge

    Changed by Pedro Amaral - amaralpohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:08:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ffcab75a3f1d5700c92c854ca48465fa08420cbc

    Comments

    Call generic isShowingAppMenuUpdateBadge
    
    ChromeActivity should call ToolbarManager's isShowingAppMenuUpdateBadge
    so that bottom toolbar has a chance to handle it.
    
    Change-Id: I3ffdd69896ef4e3180328c33d5a5a69d21c5fdc4
    Reviewed-on: https://chromium-review.googlesource.com/1132601
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574395}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
  74. Fix broken link in Histograms documentation.

    Changed by Caitlin Sadowski - supertriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38d84f451bba258746bb4ac1ee10a3cfa441997a

    Comments

    Fix broken link in Histograms documentation.
    
    Change-Id: Ie1fb9b26d0c4b5e4d767033cf50143e3b4612a3f
    Reviewed-on: https://chromium-review.googlesource.com/1134422
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Caitlin Sadowski <supertri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574394}

    Changed files

    • tools/metrics/histograms/README.md
  75. Moving Offline Previews triggering to be pre-computed

    Changed by Ryan Sturm - ryansturmohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:02:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3154b813745fb84c61dabf48dc7e75cf5d1973f9

    Comments

    Moving Offline Previews triggering to be pre-computed
    
    As part of moving previews to an earlier decision point, this CL moves
    the triggering of offline previews to be consistent with other preview
    types.
    
    Follow-up Cls will move this decision point earlier on the UI thread so
    the new offline page implementation will also be able to use it. The
    temporary dependency on PreviewsUserData will also not be needed once
    the offline tab helper is accessible (the impl is on the UI thread).
    
    Bug: 842233
    Change-Id: If2969a109434270659dcf723b39a7627bb8c8ecd
    Reviewed-on: https://chromium-review.googlesource.com/1128332
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Jian Li <jianli@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574393}

    Changed files

    • chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.h
    • chrome/browser/offline_pages/offline_page_request_job.cc
    • chrome/browser/offline_pages/offline_page_request_job.h
    • chrome/browser/previews/previews_infobar_tab_helper.cc
    • chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/previews/content/previews_content_util.cc
    • components/previews/content/previews_content_util_unittest.cc
    • components/previews/core/previews_user_data.h
    • content/public/common/previews_state.h
    • third_party/blink/public/platform/web_url_request.h
  76. Revert "Reland "Fix OOPIF hit testing in layout tests.""

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 08abdaa4ff32eca88a28ab84f7da1075819c311b

    Comments

    Revert "Reland "Fix OOPIF hit testing in layout tests.""
    
    This reverts commit 3dcee047ec982d521d9ad5301e00ac1bba134f01.
    
    Reason for revert: Suspect this is causing more flaky failures, see e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/10567 and build 10568
    
    Original change's description:
    > Reland "Fix OOPIF hit testing in layout tests."
    > 
    > This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    > 
    > Original change's description:
    > > Fix OOPIF hit testing in layout tests.
    > >
    > > If we haven't received an activated surface yet ensure that we fallback
    > > to querying the renderer for the target of input events.
    > >
    > > BUG=601584
    > >
    > > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
    > > Reviewed-on: https://chromium-review.googlesource.com/1131219
    > > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#573789}
    > 
    > TBR=kenrb@chromium.org
    > 
    > Bug: 601584
    > Change-Id: I8a2d207db79cc237e1d5e22e5e9bfffb218486c4
    > Reviewed-on: https://chromium-review.googlesource.com/1133718
    > Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574304}
    
    TBR=kenrb@chromium.org,dtapuska@chromium.org
    
    Change-Id: I9fec8992b35943f8dd2d8ce6bafe8ac9feb49411
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 601584
    Reviewed-on: https://chromium-review.googlesource.com/1134143
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574392}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  77. Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896be1d3c7326aed2e680ed495a82e5997e5de13

    Comments

    Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)
    
    https://skia.googlesource.com/skia.git/+log/4ec72f7cc745..80247e594d1f
    
    
    git log 4ec72f7cc745..80247e594d1f --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 caryclark@skia.org Publish docs for rrect, picture, blendmode
    2018-07-11 bungeman@google.com Make CR and trailing whitespace errors.
    2018-07-11 bsalomon@google.com Reland "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
    2018-07-11 bungeman@google.com Remove interal use of SkRefCnt_SafeAssign.
    2018-07-11 mtklein@chromium.org collapse parametric_{r,g,b} into parametric, remove _a and gamma_dst
    2018-07-11 herb@google.com Revert "Use new SkGlyphIDSet - v2"
    2018-07-11 bsalomon@google.com Add gltestpersistentcache config that tests GrContextOption's cache.
    2018-07-11 herb@google.com Revert "Use simple buffers instead of vectors"
    2018-07-11 bsalomon@google.com Revert "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
    2018-07-11 bsalomon@google.com Make GPU cache invalidation SkMessageBus messages go to one GrContext.
    2018-07-11 herb@google.com Use simple buffers instead of vectors
    2018-07-11 halcanary@google.com Whitespace Fixup
    2018-07-11 mtklein@chromium.org also rm Perf-Debian9-GCC-GCE-CPU-AVX2-x86_64-Release-All
    2018-07-11 brianosman@google.com Only generate valid premul test data in SRGBReadWritePixels test
    2018-07-11 jvanverth@google.com Add more tests for PolyUtils
    2018-07-11 mtklein@chromium.org might as well use SkRasterPipeline::gamma too
    2018-07-11 ethannicholas@google.com fix for persistent shader cache
    2018-07-11 egdaniel@google.com Reland "Reland "Move Vulkan DebugCallback code into tools.""
    2018-07-11 timliang@google.com implemented uploading intial texture data for metal gpu backend
    2018-07-11 mtklein@chromium.org rm Perf-Win2016-MSVC-GCE-CPU-AVX2-x86_64-Release-All
    2018-07-11 robertphillips@google.com Revert "SkDEBUGF: use __VA_ARGS__"
    2018-07-11 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a6a7842fdbf5..5c8113d3c20f (1 commits)
    2018-07-11 timliang@google.com refactored where texture descriptors are made for metal gpu backend
    2018-07-11 herb@google.com Use new SkGlyphIDSet - v2
    2018-07-11 mtklein@chromium.org use from/to_srgb
    2018-07-11 halcanary@google.com SkDEBUGF: use __VA_ARGS__
    2018-07-11 kjlubick@google.com Adventures with Skia, WASM and a JS API for Pathkit
    2018-07-11 caryclark@skia.org propogate simple angles in pathops
    2018-07-11 mtklein@google.com Reland "transform paint color to dst colorspace"
    2018-07-11 brianosman@google.com Remove clamping of kPlus with F16 configs
    2018-07-11 brianosman@google.com Remove old lazy image decoding heuristic logic
    2018-07-11 egdaniel@google.com Reland "Reland "Make GrVkBackendContext no longer derive from SkRefCnt.""
    2018-07-11 brianosman@google.com Remove unused GrPixelConfig functions
    
    
    Created with:
      gclient setdep -r src/third_party/skia@80247e594d1f
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ief888bfc0922b84d752987ea5ec56c4369912b14
    Reviewed-on: https://chromium-review.googlesource.com/1133871
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574391}

    Changed files

    • DEPS
  78. [Nav Experiment] Parameterize crw_web_controller_unittest.mm.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:53:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a9497984526d151d178bfe8ec9dd1b1c84597c

    Comments

    [Nav Experiment] Parameterize crw_web_controller_unittest.mm.
    
    This is so that both LegacyNavigationManagerImpl and
    WKBasedNavigationManagerImpl can be tested on trybots.
    
    Also fixed broken test setup for
    ScriptExecutionTest.UserScriptOnAppSpecificPage and
    CRWWebControllerTest.AbortNativeUrlNavigation.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic343aafa9d1db545086fbeb001c5c9dd6253eb52
    Reviewed-on: https://chromium-review.googlesource.com/1134406
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574390}

    Changed files

    • ios/web/web_state/ui/crw_web_controller_unittest.mm
  79. [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65d0489cb43a7d17f1668f9178506e7a446b9a3d

    Comments

    [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart
    
    The naming turned out to be confusing.
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I16fb06f080caac6ef9356edb187fe8032ef8f9ef
    Reviewed-on: https://chromium-review.googlesource.com/1133098
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574389}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.h
  80. Update XR (VR & AR) OWNERS files

    Changed by David Dorwin - ddorwinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:49:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcd11ade1174730bcc35ee5f8d71960c5a6a4794

    Comments

    Update XR (VR & AR) OWNERS files
    
    Switch COMPONENT to new structure, update and alphabetize owners, and
    add missing fields.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:closure_compilation;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5141932b33a41d3aeaad1cc053623f12422e277e
    Reviewed-on: https://chromium-review.googlesource.com/1121097
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Reviewed-by: Brandon Jones <bajones@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: David Dorwin <ddorwin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574388}

    Changed files

    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VR_JAVA_OWNERS
    • chrome/browser/android/vr/OWNERS
    • chrome/browser/android/vr/arcore_device/OWNERS
    • chrome/browser/resources/vr/OWNERS
    • chrome/browser/vr/OWNERS
    • chrome/browser/vr/service/OWNERS
    • chrome/browser/vr/vector_icons/OWNERS
    • chrome/test/data/vr/OWNERS
    • chrome/test/vr/OWNERS
    • device/vr/OWNERS
    • device/vr/oculus/OWNERS
    • device/vr/openvr/OWNERS
    • device/vr/public/mojom/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webvr/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webxr/OWNERS
    • third_party/arcore-android-sdk/OWNERS
    • third_party/blink/renderer/modules/vr/OWNERS
    • third_party/blink/renderer/modules/xr/OWNERS
    • third_party/gvr-android-keyboard/OWNERS
    • third_party/gvr-android-keyboard/com/google/vr/keyboard/OWNERS
    • third_party/gvr-android-sdk/OWNERS
    • third_party/libovr/OWNERS
    • third_party/openvr/OWNERS
    • tools/perf/contrib/vr_benchmarks/OWNERS
  81. Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)

    Changed by catapult-chromium-autoroll - catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:44:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 720dadbc215c229ce100bc408edb3aee03b0697e

    Comments

    Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5c0d851abe6e..1af68170e543
    
    
    git log 5c0d851abe6e..1af68170e543 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Use oauth scopes for /add_histograms
    2018-07-11 simonhatch@chromium.org Dashboard - Add some timing around /add_histograms
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@1af68170e543
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:862730,chromium:862666
    TBR=sullivan@chromium.org
    
    Change-Id: If4b4e810ef8ae28ad68c15848c6aebe5ccc3fb56
    Reviewed-on: https://chromium-review.googlesource.com/1133869
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574387}

    Changed files

    • DEPS
  82. [Feed] Feed Storage Initialization

    Changed by Gang Wu - gangwuohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:44:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74b454af56f3e14b18880854866b9b0d0b1f2a13

    Comments

    [Feed] Feed Storage Initialization
    
    Implement feed storage initialization in C++.
    
    Bug:828938
    
    Change-Id: I33a5a9e2e7dd20c36ec945feab6ea9932e9d94a2
    Reviewed-on: https://chromium-review.googlesource.com/1121834
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Commit-Queue: Gang Wu <gangwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574386}

    Changed files

    • chrome/browser/android/feed/feed_host_service_factory.cc
    • components/feed/core/feed_host_service.cc
    • components/feed/core/feed_host_service.h
    • components/feed/core/feed_storage_database.cc
    • components/feed/core/feed_storage_database.h
  83. Introducing improvements for the Action Recorder Extension.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:41:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 856e676d5e063bce97d01d06311b517f6b9e108c

    Comments

    Introducing improvements for the Action Recorder Extension.
    
    1. Improved the xpath generator. The generator will produce even more concise xpaths. This improvement helps to make test recipes readable to humans.
    2. Changed the way the extension queries for an iframe's context. Prior to this change, the extension would construct a path from the iframe to the top level frame by making a query at each ancestor frame node. However, InProcessBrowserTest does not need a path to go from the top level frame to a descendant iframe. Therefore, in this change the extension only makes one query at the parent frame node.
    3. Moved the frame context query action to the front of the start recording workflow. This move cuts one message roundtrip from the extension's background script to the extension's content script.
    4. Made the extension jot down a target element's visibility state when recording an action. Prior to this change, the extension assumes that every target element is visible, enabled and on the top of the page. However, the extension's complex action recording logic sometimes catches actions on invisible or partially obscured elements.
    5. Added refined logic to the extension to distinguish between a user typing action and a Chrome autofill action. Prior to this change the extension simply assumes that Chrome always autofills every autofill-able field. If a user types inside an autofillable field, the extension will mistakenly record an autofill action. With this change the extension uses keyboard events to detect when a user types inside a field, eliminating the false positive.
    6. Began implementing new features to capture Chrome Password Manager actions.
    
    Bug: 855284
    Change-Id: Ic7ff3af95cdc9f308c3ad061a3506fced150b4f8
    Reviewed-on: https://chromium-review.googlesource.com/1132540
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574385}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/background/background.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/constants.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
  84. Bandaid detached tabs at 150% scale

    Changed by Taylor Bergquist - tbergquistohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c18d19908d8817f4057df5e50afc966d92a25701

    Comments

    Bandaid detached tabs at 150% scale
    
    At some dpi scales (150% for example), the tabs are drawn detached from
    the toolbar, with a stark one-pixel gap between the tabs and the
    toolbar.
    
    This CL draws one extra dip's worth of tab below the bottom of the tab,
    which is occluded by the toolbar at integral scales and fills the gap
    on non-integral scales.
    
    
    Bug: 848106
    Change-Id: Ib465e8886c49613916bf3f3faff5fc43f36dfb18
    Reviewed-on: https://chromium-review.googlesource.com/1121386
    Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574384}

    Changed files

    • chrome/browser/ui/layout_constants.cc
    • chrome/browser/ui/layout_constants.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/browser_view_unittest.cc
    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/tab.cc
  85. Fix crash in shortcut viewer with ChromeVox enabled

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:38:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f74145f76fd3c4d8c1b4d024f34cf24189350d2

    Comments

    Fix crash in shortcut viewer with ChromeVox enabled
    
    Views can trigger accessibility events during Widget construction
    before the AXRemoteHost starts monitoring the widget. This happens
    with the material design focus ring on text fields.
    
    Bug: 862759
    Test: added to views_mus_unittests
    Change-Id: Ib7de6aa1d09b17fb65ad350abd362ad26b0454ae
    Reviewed-on: https://chromium-review.googlesource.com/1134353
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574383}

    Changed files

    • ui/views/mus/ax_remote_host.cc
    • ui/views/mus/ax_remote_host_unittest.cc
  86. @IntDef cleanup in browser/java/appmenu

    Changed by Marcin Wiacek - marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 22:34:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d0c1419ced881ae3321b7c6e3f23bbcacde473a

    Comments

    @IntDef cleanup in browser/java/appmenu
    
    @IntDef/@StringDef annotation are preferred way for declaring
    set of String/int values:
    
    1. they need less space in APK than enum, see
    https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
    2. they give more control over allowed values than "static final" values
    
    Main goal of patch is writing "static final" values, enum
    and some classes in one common @IntDef/@StringDef form:
    
    1. with @IntDef/@StringDef first, @Retention second
       and related @interface third
    2. with values inside @interface
    3. with NUM_ENTRIES declaring number of entries if necessary
    4. with comment about numbering from 0 without gaps when necessary
    5. with @Retention(RetentionPolicy.SOURCE)
    6. without "static final" in the @interface
    
    Additionally there are done some other trivial cleanups.
    
    Change-Id: Ie6b59c0f1a8ec6fe50d3177619f0768798f97508
    Reviewed-on: https://chromium-review.googlesource.com/1128092
    Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574382}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
  87. Add metrics tracking how long Page Info is open

    Changed by Christopher Thompson - cthompohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:29:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c4e06c2d21cc9a69f0a2a871a873b30c12b8fee

    Comments

    Add metrics tracking how long Page Info is open
    
    Per a suggestion of martinshelton@, this adds a new set of histograms to
    track how long users have the Page Info bubble open. This will help us
    better understand users who open Page Info but take no actions in it
    (e.g., are these opens likely to be more accidental or incidental).
    
    This metric is split by the security level of the page to allow us to
    see differences between different security indicators. Two sub-histograms
    ("Action" and "NoAction") further split up the metric by whether the user
    performed an action in the Page Info bubble before closing it (including
    actions that cause the bubble to close).
    
    Bug: 859116
    Change-Id: I630a1f37ecff13bc7ee44b3e8e5a5c34337c9267
    Reviewed-on: https://chromium-review.googlesource.com/1096336
    Commit-Queue: Christopher Thompson <cthomp@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574381}

    Changed files

    • chrome/browser/ui/page_info/page_info.cc
    • chrome/browser/ui/page_info/page_info.h
    • chrome/browser/ui/page_info/page_info_unittest.cc
    • tools/metrics/histograms/histograms.xml
  88. Allow optimization hints to be marked as experimental.

    Changed by Jeremy Elson - jelsonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:28:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8940b1c9de6fb2951013a8d2bb78770e62598b7

    Comments

    Allow optimization hints to be marked as experimental.
    
    Experimental hints are tagged (in the Optimization proto) with an
    experiment name. Experimental hints are not enabled unless an
    experiment with a matching name is enabled. Experiments are enabled by
    turning on the new base::Feature called kOptimizationHintsExperiments,
    with the name of the experiment in a parameter called experiment_name.
    
    Bug: 831817
    Change-Id: I6141c70f8f3a8f9adb2c9772b747ee2a0c59b227
    Reviewed-on: https://chromium-review.googlesource.com/1132491
    Commit-Queue: Jeremy Elson <jelson@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574380}

    Changed files

    • components/optimization_guide/proto/hints.proto
    • components/previews/content/previews_hints.cc
    • components/previews/content/previews_optimization_guide_unittest.cc
    • components/previews/core/previews_features.cc
    • components/previews/core/previews_features.h
  89. Reland "[sampling heap profiler] Support stack collection on Android"

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:26:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a3c0496180f1a183b3ca8061440d3888ff0722a

    Comments

    Reland "[sampling heap profiler] Support stack collection on Android"
    
    This reverts commit db0cac4eafdcc6cbd13e19eacc3eba15c15bfa2c.
    
    Reason for revert: The revert didn't affect anything, so re-landing.
    
    Original change's description:
    > Revert "[sampling heap profiler] Support stack collection on Android"
    > 
    > This reverts commit 52601a565375e7e60fdee70568f5e85242b76441.
    > 
    > Reason for revert: Speculatively reverting to see if this is confusing crashpad on the Mac somehow. See crbug.com/862466.
    > 
    > Original change's description:
    > > [sampling heap profiler] Support stack collection on Android
    > > 
    > > BUG=803276
    > > 
    > > Change-Id: I60d7925104b8614aa68c135d52f6089a76675d22
    > > Reviewed-on: https://chromium-review.googlesource.com/1128630
    > > Reviewed-by: Siddhartha S <ssid@chromium.org>
    > > Commit-Queue: Alexei Filippov <alph@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#573880}
    > 
    > TBR=alph@chromium.org,ssid@chromium.org
    > 
    > Change-Id: Ie7b4f8b20cd5526420ef836d3a21dda27d4090bb
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 803276
    > Reviewed-on: https://chromium-review.googlesource.com/1132357
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574032}
    
    TBR=dpranke@chromium.org,alph@chromium.org,ssid@chromium.org
    
    Change-Id: I41392b0836e75c25ae6b0b9aa243daeef95b6ee7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 803276
    Reviewed-on: https://chromium-review.googlesource.com/1134142
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574379}

    Changed files

    • base/sampling_heap_profiler/sampling_heap_profiler.cc
    • base/sampling_heap_profiler/sampling_heap_profiler.h
  90. Add intermediate bubble UI for local card migration flow.

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:25:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59f08db6b91e0572161cf98df942b70c3becc285

    Comments

    Add intermediate bubble UI for local card migration flow.
    
    This is the 1st CL adding new views. There will be three following CLs
    on Autofill Client change, unit-test and metrics, and cocoa implementation.
    
    For details, please refer to design doc go/ib-paradise.
    
    This project is to offer users an option to upload chrome local credit
    cards to Google Pay server. This bubble UI is the entry point of the entire
    flow. It should be anchored to a credit card icon in the location bar and
    be shown from it.
    
    Bug: 852904
    Change-Id: Iadc4667598fc0a90a81c23658185045a5aecda8a
    Reviewed-on: https://chromium-review.googlesource.com/1128569
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574378}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/app/generated_resources.grd
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_bubble.h
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h
    • chrome/browser/ui/browser_window.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.mm
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/view_ids.h
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.h
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/test/base/test_browser_window.cc
    • chrome/test/base/test_browser_window.h
    • components/autofill/core/browser/ui/local_card_migration_bubble_controller.h
    • components/autofill_strings.grdp
  91. Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz

    Changed by Jonathan Ross - jonrossohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:24:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99b62af5a66207b0fe84080bdd23492471a9ba94

    Comments

    Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz
    
    Apparently this test can still fail on Windows. So re-disabling it until it can be investigated further.
    
    TBR=fsamuel@chromium.org
    TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    
    Bug: 848825
    Change-Id: I00828a10cfd5c8c111b30f61eb5d8acbf57da2ea
    Reviewed-on: https://chromium-review.googlesource.com/1133875
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574377}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  92. Add the target for overrides of metrics utilities in jingle_unittests.

    Changed by Qingsi Wang - qingsiohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50c4d834c41b8f1ae60ae80bc47d67a51dcb23bd

    Comments

    Add the target for overrides of metrics utilities in jingle_unittests.
    
    The target rtc_p2p from WebRTC, transitively depended on by
    jingle_unittests via the target webrtc_overrides, will soon depend on
    the implementation of RTC_HISTOGRAM_* macros in WebRTC.
    
    Bug: webrtc:9409
    Change-Id: I1f2bf0776d2f7c18c9585fb15d7251f8128ce175
    Reviewed-on: https://chromium-review.googlesource.com/1134183
    Commit-Queue: Qingsi Wang <qingsi@google.com>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574376}

    Changed files

    • jingle/BUILD.gn
  93. Remove NetworkContextTest.PreconnectLessThanZero

    Changed by Lily Houghton - lilyhoughtonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:23:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe8c7d594e193f0dbdf6e3b7c970e44bee9c5c5c

    Comments

    Remove NetworkContextTest.PreconnectLessThanZero
    
    This test is flaky on android bots, and given that its testing something that
    should be explicitly unsupported (passing a negative number to a uint parameter),
    I think it's worth removing for now.
    
    Bug: 862647
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I316cb2cc5979aefb7335f715bd1fd2655db097b3
    Reviewed-on: https://chromium-review.googlesource.com/1134206
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574375}

    Changed files

    • services/network/network_context_unittest.cc
  94. Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.

    Changed by dpapad - dpapadohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:22:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ab1508513baf70561ebe2289ca48030f3fca81a

    Comments

    Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.
    
    At r573968 the logic was modified to only look for the noSearch property for
    subpage wrappers. It should also look for the CSS attribute for the case where
    no-search is not part of a binding.
    
    Bug: 862517
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id3f5dbcd86f931cce71f2e3c8a784780f5b34be6
    Reviewed-on: https://chromium-review.googlesource.com/1133683
    Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574374}

    Changed files

    • chrome/browser/resources/settings/search_settings.js
    • chrome/test/data/webui/settings/search_settings_test.js
  95. [Chromecast] Chromecast support for tap down gestures

    Changed by Jiawei Li - lijiaweiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:20:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06e3ca5865cd84108599d13d143b5f230cef145f

    Comments

    [Chromecast] Chromecast support for tap down gestures
    
    - TAP_DOWN is added to CastContentWindow::GestureType
    - The gesture detection is attached to the root window and handles
      tap down events. A new JS binding API: onTapDownHandler will be hosted on
      platform
    - HandleTapGesture: finger is released after pressed within tap timeout window
      HandleTapDownGesture: finger is pressed
    
    Bug: internal b/75979846
    Test: build manually and test whether both tap and tap down handler callback works
    Change-Id: Iaefa6df9c7a5284ba27964083fc056bf36cf480a
    Reviewed-on: https://chromium-review.googlesource.com/1115418
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Jiawei Li <lijiawei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574373}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_content_window_aura.cc
    • chromecast/browser/cast_content_window_aura.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/graphics/cast_gesture_handler.h
    • chromecast/graphics/cast_system_gesture_event_handler.cc
  96. [Nav Experiment] Make WebStateImplTest parameterized.

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00ee7c4ed5ad09f68465f8e73c89639217adfacf

    Comments

    [Nav Experiment] Make WebStateImplTest parameterized.
    
    This way both legacy and WK based navigation manager implementations are
    tested on trybots.
    
    Fixed incorrect test setup in ShowAndClearInterstitialWithNoCommittedItems.
    Disabled ShowAndClearInterstitialWithCommittedItem and
    ShowAndClearInterstitialWithoutChangingSslStatus because they require
    mocking out navigation state, which is not possible now.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id72d1c2837aba7c1ed53f4fd8623e8c286a4a0a2
    Reviewed-on: https://chromium-review.googlesource.com/1134086
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574372}

    Changed files

    • ios/web/web_state/web_state_impl_unittest.mm
  97. chromeos: fix infinite loop in cursor lookup

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d9f316a0ba47bb4be158db0de5edc596272dabe

    Comments

    chromeos: fix infinite loop in cursor lookup
    
    And remove a NOTREACHED that we're hitting. I will supply a test for this
    separate, as well as investgating removal of NOREACHED.
    
    BUG=855767
    TEST=none
    
    Change-Id: Idf59b80388fefa06317a70055d18db995187c9a0
    Reviewed-on: https://chromium-review.googlesource.com/1134352
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574371}

    Changed files

    • services/ui/ws2/window_delegate_impl.cc
    • services/ui/ws2/window_delegate_impl.h
  98. Support disabling the remainder of the Symantec Legacy PKI

    Changed by Ryan Sleevi - rsleeviohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:16:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c671bf913c328f7788df5046dd7b81bee3e17a04

    Comments

    Support disabling the remainder of the Symantec Legacy PKI
    
    Introduce a base::Feature flag that controls how the
    remainder of the Symantec Legacy PKI - that is, certs
    issued on/after 2016-06-01 but before 2017-12-01 - are
    handled.
    
    Bug: 796230
    Change-Id: Iebe9976ace0dfcdfd02f844fdaf497cf67dde704
    Reviewed-on: https://chromium-review.googlesource.com/1134037
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574370}

    Changed files

    • net/cert/cert_verify_proc.cc
    • net/cert/cert_verify_proc.h
    • net/cert/cert_verify_proc_unittest.cc
  99. Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."

    Changed by Brian Salomon - bsalomonohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 23370775c415c21f4de1c7d97dd5645fe2b7e818

    Comments

    Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    
    This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    
    The updated change uses window.devicePixelRatio to determine the inset.
    It also accounts for the absolute position used by the "WithDivs"
    variations of this test. One additional device pixel of offset is used
    to make this pass on mac_chromium_rel_ng. This is probably necessary
    because either window.devicePixelRatio reports 1 incorrectly or the
    edge antialiasing covers slightly more than one pixel. This wasn't
    investigated.
    
    Original change's description:
    > Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.
    >
    > Skia currently has a driver workaround that performans antialiased
    > rectangle edge equation evalution in the fragment shader rather than
    > vertex shader on Adreno 3xx GPUs. This was done because the interpolation
    > of values computed in the vertex shader lacks enough precision to pass
    > these tests. However, doing so has a negative performance impact. Skia
    > tests run with the workaround removed show that in practice the visual
    > difference is insignificant. Moreover, cc::GLRenderer also incurs these
    > same errors as it uses the same antialiasing approach without the
    > workaround and has shipped on Adreno 3xx devices for years with no known
    > complaints about antialiasing quality/accuracy. We're better off
    > reclaiming the performance and accepting a small hit to antialiasing
    > accuracy.
    >
    > Bug: 847984
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > Change-Id: If1e62e0780a752179a75ddd57ccc7b24128c68ac
    > Reviewed-on: https://chromium-review.googlesource.com/1129041
    > Reviewed-by: Kenneth Russell <kbr@chromium.org>
    > Commit-Queue: Brian Salomon <bsalomon@google.com>
    > Cr-Commit-Position: refs/heads/master@{#573695}
    
    Bug: 847984
    Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1132574
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574369}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  100. Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."

    Changed by Joshua Pawlicki - wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:15:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76e9e78757733e56983b4b6c9ac5b13fdc21db8b

    Comments

    Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    
    This reverts commit 560191224bcaf8390e0745a16bdf8975a1add6bf.
    
    Reason for revert: Patch still applies cleanly without prior change.
    
    Original change's description:
    > Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    >
    > This reverts commit da5ab5f6853c93ea08fe428db7dd22abe62db7d7.
    >
    > Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    >
    > Original change's description:
    > > Add method "ConfirmSaveAutofillProfile" to AutofillClient.
    > >
    > > This method will allow clients to decide if they want to
    > > save autofill profiles. //ios/web_view may choose to not
    > > save autofill profiles under some conditions.
    > > For all other autofill_clients, save like usual.
    > >
    > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > > Change-Id: I33764384ba931c5eb0bb4f3de3810be2f64c70bf
    > > Reviewed-on: https://chromium-review.googlesource.com/1074269
    > > Commit-Queue: John Wu <jzw@chromium.org>
    > > Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    > > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    > > Reviewed-by: Bo <boliu@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#574310}
    >
    > TBR=boliu@chromium.org,mathp@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    >
    > Change-Id: I570967926d1f38e675aa9980a9a5181e6270bb2d
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Reviewed-on: https://chromium-review.googlesource.com/1134139
    > Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    > Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574326}
    
    TBR=boliu@chromium.org,mathp@chromium.org,waffles@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    
    Change-Id: I6ed0526b444574a5e8419ea83a37e348dc97cd11
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1134141
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574368}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>