Home | Search | chromium - Builders
Login

Builder Win Builder Build 62655 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revisionc028d7085fdc469ffdf4efec3f9ae8d22d1e3640
Got Revisionc028d7085fdc469ffdf4efec3f9ae8d22d1e3640

Execution:

Steps and Logfiles:

Show:
  1. ( 517 ms ) setup_build
    running recipe: "chromium"
  2. ( 433 ms ) report builders
     
    running builder 'Win Builder' on master 'chromium.win'
  3. ( 18 secs ) taskkill
  4. ( 10 mins 36 secs ) bot_update
    [228GB/2047GB used (11%)]
  5. ( 34 secs ) swarming.py --version
    0.13
  6. ( 16 mins 30 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.win.json)
    path: c:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 1 secs ) lookup GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "c:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 1 mins 18 secs ) generate_build_files
  10. ( 12 mins 27 secs ) compile
  11. ( 4 mins 29 secs ) isolate tests
  12. ( 10 mins 38 secs ) package build
  13. ( 502 ms ) trigger
  14. ( 0 ) test_pre_run
  15. ( 1 secs ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "c:\\b\\s\\w\\ir\\cache", "temp_dir": "c:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build449-m1" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541762049742487, "id": "8930339032887849568", "project": "chromium", "tags": ["builder:Win Builder", "buildset:commit/git/c028d7085fdc469ffdf4efec3f9ae8d22d1e3640", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c028d7085fdc469ffdf4efec3f9ae8d22d1e3640", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095769095045169776", "scheduler_job_id:chromium/Win Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win Builder" setup_build
buildnumber 62655 setup_build
mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "c028d7085fdc469ffdf4efec3f9ae8d22d1e3640" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "c028d7085fdc469ffdf4efec3f9ae8d22d1e3640" bot_update
got_revision_cp "refs/heads/master@{#606795}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "c465c5ea7f6c2b562a1b537adf46673fea7a8b8c" bot_update
got_v8_revision_cp "refs/heads/7.2.283@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes_refs/heads/master(at){#606795}_without_patch {"accessibility_unittests": "c13f83cbda62873c024b9a5b474f380ecf685c18", "angle_unittests": "c8f1cc01ea7576b4051b6244eb6fb60814628c5b", "app_shell_unittests": "d116a555d62f3b7296c5abaa0ada9e8c2adfec0e", "aura_unittests": "731372d190f9af180af2f9788ab0147afe614133", "base_unittests": "f3c30a37b98db274e574df86bdc99d3da727206a", "blink_common_unittests": "89244a5ae13ff37fa8db5ce4c510069f76261f05", "blink_fuzzer_unittests": "e2d52bb5235ba71a8ad9727f989f6ffe51381052", "blink_heap_unittests": "d2d36f560dd4e3a6c51729262e469ab84a77e7a2", "blink_platform_unittests": "69bc8a043dfbd1bee5457f5f05a1cfb9987f6940", "boringssl_crypto_tests": "5cbd122125c88e172444851004cf7c6356eb2e14", "boringssl_ssl_tests": "3c6319eec61ca6770015702bd678ccae8f5be2b8", "browser_tests": "b292659ab061dd0919e41e1885e7c5c7a349d3d8", "cacheinvalidation_unittests": "f98670c0a0110b115b39a5d78fcad0a1ba84c36d", "capture_unittests": "88b12b579a265158e438e126d16882d7959abbb9", "cast_unittests": "d684681a630f0bf77e36450b7ac9321737e022e9", "cc_unittests": "18c0ba29f999e04379a69c17594b53f3cf4a0e99", "chrome_app_unittests": "853c2f7df1e5d2d74d9cf2f4f753fdc628384272", "chrome_cleaner_unittests": "98cb8d0dd8605455330ed6ea5bce2a38f6075c74", "chrome_elf_import_unittests": "6b8989b93351bc32e62f28260bf93ff68b02c9a8", "chrome_elf_unittests": "d2e56a1669964187d9ed4172770adf67374cb24e", "chromedriver_py_tests": "189b3ced501f388563aff84a66ee0d3e679424ef", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "aed23aad66de154df7d8833f499fdf60ea65ea6c", "components_browsertests": "004c233b09983d11f2dc36d4717356738fc3f3b5", "components_perftests": "c7a8815772fd4d55d6ee55ec404c99f7c6192112", "components_unittests": "0207243c7d9daf2204adb50a5cb7eed080127d8e", "compositor_unittests": "2c8e2bad5169c34d0b411c353e656e2a2e30d751", "content_browsertests": "b5606cac415c81f1f36590c4ae16ec0cd230f0ed", "content_shell_crash_test": "80494d6a79539f0123a81ee457ff7ef69b919ad0", "content_unittests": "f8d09c7370574fd7f62bd87e620bed83f16450fb", "courgette_unittests": "a01003ca56c2c2dccee3b9220267a706cdd8a795", "crashpad_tests": "cd5637b4922a2670c2718131b3f39d803d908518", "cronet_tests": "1fb38a3166a751800311503bd4c1ce907c3ad3c7", "cronet_unittests": "2add57ca40e2e9bdfeeb9964d3d75285b7d05cb8", "crypto_unittests": "0efe4377be673869cb6407eb719bb46457a234f9", "device_unittests": "4953f166e3e44f1f02ad5f58a4064b9e7ceb7a88", "display_unittests": "595f2dd4814277b03814a2ea2f77c10a5204a36c", "elevation_service_unittests": "c1f7dab2b95735be58394b189e2fc530aa1a6120", "events_unittests": "f0733c91c93ff9c3c8509d37c6017736efba1e23", "extensions_browsertests": "3dcbb0db844d2da4cba1511f7ab74ea8dfe27703", "extensions_unittests": "5c9aa072eb0b09c2ab4ca01a89edda5e558308a9", "filesystem_service_unittests": "a9ef789d8dd37cfbd8411ba809532ff8ee7e191d", "gcm_unit_tests": "418002c5bebacc29332bdaf77ac7978652b0f936", "gcp_unittests": "e2a2a8757a5e3e6221dab1239a6ae2bd5507d5c3", "gfx_unittests": "06a1c3ffd54815c5c0a088ed618b4ce144a397db", "gin_unittests": "898e35d4c3dc7771dbc46ce0879ed0824e9f4d87", "google_apis_unittests": "9cf32726cc4bf1f3e0240316cd8389055c5c21fb", "gpu_unittests": "cdae791be8dd04549bb7f84ad38aeb938e0d7e09", "headless_browsertests": "cfdbfcc8cbf7cca374d34f940e5b239384624606", "headless_unittests": "a669b661ea94b49669e32879c680046027c180a8", "install_static_unittests": "d96edf4c3f8321f3efcd67ddf28e659532827ac5", "installer_util_unittests": "7150967fa7a5a63ff9c5ffa58438f3769be28ff9", "interactive_ui_tests": "c069a3ae587e6f1309dd265c70ab729b295abfb4", "ipc_tests": "4dd01f5afcea188d73ce43b5e30e604724842a19", "jingle_unittests": "7de5530abadb237472e1bb2445c93ef56f881e07", "latency_unittests": "88e2d01291fe808291ec75591e7503baf76461b8", "leveldb_service_unittests": "188f17df2521056ceda98505af127c4e056d2d09", "libjingle_xmpp_unittests": "e09b154e1e83e29d07d87d5ecfb1ef9ffe14edde", "media_blink_unittests": "4f4c53fe1f32dbb603548826fbbc0736eee2d5d4", "media_service_unittests": "886248d7c2629f7c76fc2e64519649660becdb5c", "media_unittests": "cfc6595c48232464c42fb804425d52a3d8cf3f83", "message_center_unittests": "7fd9efd586955bbc518377537b74fd54e779cf33", "metrics_python_tests": "e752064845c425b315bbbf6f4006b9307b4aa2dc", "midi_unittests": "9355e93471872e6f23a1bde284c12c563ffea72e", "mojo_core_unittests": "426abd4e8e20868b3965cc8bc139123d03b91ad2", "mojo_unittests": "3dbd7cb9fea5c48b9af14ab99b1b658507317948", "nacl_loader_unittests": "d08cf7a8af42324b51337bc5c7fea9fbae363394", "native_theme_unittests": "d6fc9158d93b45d5a2bed199827cd9fb39849d7a", "net_unittests": "dd1b98f60816cf5325648438bfefe472074e2074", "pdf_unittests": "623e75bfe2a3d5fac1c8e74755771c7044a86db0", "ppapi_unittests": "fa48aa22f92ce3b7266a05c9b80832acb85d1e8f", "printing_unittests": "e7ffcddabdd898d3687108f73490509a0f24a59f", "remoting_unittests": "3324bb6e816136424b989c210e0a6d02ab611bc2", "sbox_integration_tests": "8a858ddcdaaeab162c56a0426148696f2e9f0167", "sbox_unittests": "c06fbc37f678a84009cfe1fbe9f8cd6cbe2bb179", "sbox_validation_tests": "ea31b6d560afdf4b9f1751ab966087cee3406105", "service_manager_unittests": "0faa028d840e32580e668a07bd864528bcb8f568", "services_unittests": "e02474c83902af5e62805b760d24e3acc424d4ad", "setup_unittests": "7c7a1713cff233bdfbe27ee9a8ddc7de1214cd2f", "shell_dialogs_unittests": "015c80f1b41ea6debc353fae84944456fa883990", "skia_unittests": "27526d717a2636fbbeb1d6d7feebb6fb00d9bf9e", "snapshot_unittests": "ecc5c48c493c7b946c504434d01225465013f020", "sql_unittests": "be8e0c11c00c114c39f1954655e3704253055f12", "storage_unittests": "65ab77107192f19321a8af004ec7198b3d648d96", "sync_integration_tests": "f70da88ffde10365c23645766c518c24c69d0bd7", "telemetry_gpu_unittests": "5ff733d11786f3664a45d00d28cf29bd90398e8e", "telemetry_perf_unittests": "5b8aa70b77f9d5d4eafb7082a00394a7770cb5ac", "telemetry_unittests": "cba5aaf8909869eee667fa70d8aa63a28dd6e2d4", "traffic_annotation_auditor_unittests": "914a914981426006377fc5df0d8c0b32618d8db5", "ui_base_unittests": "121927a6afaeda469cf8e89ea955474529db68e3", "ui_touch_selection_unittests": "424a6429d188a7e1cedea04fb3b3b8db0bf29c9f", "unit_tests": "abbeda33cb1eea59e8e954eaab2b0cebe1ea293d", "url_unittests": "e6f2b40a948505ecd681dca9d4dc6ec9118c0ac1", "views_perftests": "0594b5b3b687dfe4084baea7c2a1f87bc56de2ec", "views_unittests": "4bd1902d579e55dfcf20e1ca4f847603c88be5e2", "viz_unittests": "2ebce5d577d4324bd79474a7c38aee37ff6036bc", "vr_common_unittests": "e28003ee83509a889d184fc93cb800c9ec7da840", "vr_pixeltests": "1a4c935ead85de8cb93e7fc1aa74df96c191924e", "webkit_layout_tests_exparchive": "54837a8bc138ce8340fe9573ca2e9e5af916037d", "webkit_python_tests": "e8ad8c8f5aadbac5ab9976f68851b1f76afa6ebe", "webkit_unit_tests": "76024b8678bd69f8dadb2d11c32bdfd75af5c6bb", "wm_unittests": "f67522465da25ad838eb385bbb5001d10d30890c", "wtf_unittests": "bb221aad035f2901fa6a9038eb8f42586d2e9a0c", "zucchini_unittests": "6d2b45bf6840f9c3e8bd920f8c34edc3ba25ab10"} isolate tests
build_archive_url "gs://chromium-win-archive/chromium.win/Win Builder/full-build-win32_c028d7085fdc469ffdf4efec3f9ae8d22d1e3640.zip" package build

Blamelist:

  1. Sheng-Hao Tsao (shenghaoohnoyoudont@google.com)
  2. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  3. Yi Su (mrsuyiohnoyoudont@chromium.org)
  4. Arthur Sonzogni (arthursonzogniohnoyoudont@chromium.org)
  5. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  6. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  8. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  9. Mario Sanchez Prada (marioohnoyoudont@igalia.com)
  10. Koji Ishii (kojiiohnoyoudont@chromium.org)
  11. Balazs Engedy (engedyohnoyoudont@chromium.org)
  12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  13. Colin Blundell (blundellohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 11:14:09 UTC
Start Friday, 09-Nov-18 16:59:33 UTC
End Friday, 09-Nov-18 18:02:11 UTC
Pending 5 hrs 45 mins
Execution 1 hrs 2 mins

All Changes:

  1. Only open GCA if ARC is P or above

    Changed by Sheng-Hao Tsao - shenghaoohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 10:59:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c028d7085fdc469ffdf4efec3f9ae8d22d1e3640

    Comments

    Only open GCA if ARC is P or above
    
    This CL changes the consolidated camera app icon logic so that it
    launches GCA/GCA migration app only if ARC is P or above. This is to
    address 2 problems:
    
    1. Android N and below do not support external cameras. We would like
    users to use CCA so that they can still utilize external cameras.
    2. Managed users in Android N still have the problem where GCA could be
    stripped out.
    
    Bug: b:118860552,chromium:896140
    Test: Used N devices (caroline) with google.com account and verified
    that CCA is opened.
    
    Change-Id: I7836d2b4256856028901e5e542f460e7107fc8db
    Reviewed-on: https://chromium-review.googlesource.com/c/1316982
    Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606795}

    Changed files

    • chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
  2. [Autofill Assistant] Checkbox for terms acceptance.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 652ddcf5b36955638fa64b013c88c0dd2f939fd8

    Comments

    [Autofill Assistant] Checkbox for terms acceptance.
    
    This patch introduces a checkbox in the Autofill Assistant payment request UI.
    The state of which is communicated in the processed action results to
    the backend.
    
    This logic only exists on the Java side and is opaquely passed through
    the c++ layer.
    
    Issue: b/117920169
    Screenshot: https://screenshot.googleplex.com/iiHvY18nLqn.png
    
    Bug: 806868
    Change-Id: Ica17176c4cac695c126d1d5695a8b7e5a31020e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1316770
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606794}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/browser/android/autofill_assistant/ui_controller_android.cc
    • chrome/browser/android/autofill_assistant/ui_controller_android.h
    • components/autofill_assistant/browser/actions/get_payment_information_action.cc
    • components/autofill_assistant/browser/payment_information.h
    • components/autofill_assistant/browser/service.proto
    • components/autofill_assistant_strings.grdp
  3. Change feature flag of Custom Search Engine to be enabled by default.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:53:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fbf09d888ad3453558caf7ba438acf381860d8a

    Comments

    Change feature flag of Custom Search Engine to be enabled by default.
    
    The feature of Custom Search Engine is nearly finished and ready to be
    tested. Chnage the feature flag to be enabled by default.
    
    Bug: 433824
    Change-Id: Ied1d61b1df73bd8ceee89a2088e3e53418cbf856
    Reviewed-on: https://chromium-review.googlesource.com/c/1326002
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606793}

    Changed files

    • ios/chrome/browser/search_engines/feature_flags.cc
  4. WebRequestProxyingURLLoader: Close the current loader before internal redirect.

    Changed by Arthur Sonzogni - arthursonzogniohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4d3cf41c0598cf64570d293b73399c0f82ba7ccd

    Comments

    WebRequestProxyingURLLoader: Close the current loader before internal redirect.
    
    Please see the explanation here:
    https://bugs.chromium.org/p/chromium/issues/detail?id=882661#c72
    
    Generating a fake internal redirect causes conflicts with what the
    current URLLoader is doing. The latter doesn't know anything about the
    redirect. To work properly, the current URLLoader must be destroyed
    first. The current code automatically handles creating a new
    URLLoader after FollowRedirect().
    
    Bug: 882661
    Change-Id: Ib17dc2f29a2c63da735794b4792ef7805e7dbc58
    Reviewed-on: https://chromium-review.googlesource.com/c/1326481
    Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606792}

    Changed files

    • extensions/browser/api/web_request/web_request_proxying_url_loader_factory.cc
  5. Support ::placeholder after ::slotted().

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:48:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cd41aa340d600b3c1f1725d94c2e06e11635531

    Comments

    Support ::placeholder after ::slotted().
    
    Tree-abiding pseudo elements are allowed after ::slotted() according to
    css-scoping-1. According to css-pseudo-4 they are ::before, ::after,
    ::marker, and ::placeholder. We already allowed ::before and ::after. We
    do not support ::marker. This CL allows ::placeholder.
    
    TEST=external/wpt/css/css-scoping/slotted-parsing.html
    TEST=external/wpt/css/css-scoping/slotted-placeholder.html
    
    Bug: 902518
    Change-Id: I963fa93e68c8fbd33fc8090e930be9a00f3c9bd4
    Reviewed-on: https://chromium-review.googlesource.com/c/1323049
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Fergal Daly <fergal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606791}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/css/css-scoping/slotted-parsing-expected.txt
    • third_party/blink/renderer/core/css/css_selector.cc
    • third_party/blink/renderer/core/css/css_selector.h
    • third_party/blink/renderer/core/css/parser/css_parser_selector.h
    • third_party/blink/renderer/core/css/parser/css_selector_parser.cc
    • third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
    • third_party/blink/renderer/core/css/resolver/style_resolver.cc
  6. Roll src/third_party/skia 22b0ec4f83aa..88e15bdaf539 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:47:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f21161ed54556a4f278ed78747e7f96f4ad924d3

    Comments

    Roll src/third_party/skia 22b0ec4f83aa..88e15bdaf539 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/22b0ec4f83aa..88e15bdaf539
    
    
    git log 22b0ec4f83aa..88e15bdaf539 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
    2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d856ca48f425..5d2dfa46c05c (2 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@88e15bdaf539
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I669e2dcceb60198f833772e058db4e4ffd2de923
    Reviewed-on: https://chromium-review.googlesource.com/c/1328723
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606790}

    Changed files

    • DEPS
  7. Roll src-internal 53aa50a0dced..0ee41cbd4bf0 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:45:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8de008a2a6f8d8eaec1b095550660cb5322551e9

    Comments

    Roll src-internal 53aa50a0dced..0ee41cbd4bf0 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/53aa50a0dced..0ee41cbd4bf0
    
    
    Created with:
      gclient setdep -r src-internal@0ee41cbd4bf0
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I97a39edb26a9fcecef541f317a1788d833f9fa14
    Reviewed-on: https://chromium-review.googlesource.com/c/1328727
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606789}

    Changed files

    • DEPS
  8. media/gpu/VEA unittest: Test DMABuf-backed input buffers

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:41:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c4e9ae1b9abc167c177d659dbcc3d1f794e93064

    Comments

    media/gpu/VEA unittest: Test DMABuf-backed input buffers
    
    This adds the command line option, --natvie_input, that VEA unittest passes
    DMABuf-backed video frame to VEA.
    DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    also makes VEA unittest dependent on Ozone.
    
    BUG=chromium:895230
    TEST=VEA unittest on eve w/wo --native_input
    
    Change-Id: I67526a1b6b6cf1ae74a96000ec2af14995dbd4fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1295636
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606788}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  9. Fix declaration of override method in IdentityManagerObserverBridge

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 10:36:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6586665e93e9211f934364c00eee32433027df9

    Comments

    Fix declaration of override method in IdentityManagerObserverBridge
    
    IdentityManager::OnRefreshTokenRemovedForAccount() expects as a first
    parameter a "const std::string&" instead of a "const AccountInfo&",
    so this patch fixes it to prevent build failures when using this API
    because of OnRefreshTokenRemovedForAccount(const AccountInfo&) not
    being a valid override for the virtual method declared.
    
    Bug: 903391
    Change-Id: I46cd6778240a40af6863ca7fd3b8d9a88e735fde
    Reviewed-on: https://chromium-review.googlesource.com/c/1327161
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#606787}

    Changed files

    • services/identity/public/objc/identity_manager_observer_bridge.h
    • services/identity/public/objc/identity_manager_observer_bridge.mm
  10. Reland "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow"

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:35:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision de3b8c8dbf530a94a15e660ecb2b9cd80a7f9843

    Comments

    Reland "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow"
    
    This is a reland of b43c6fca4349b7f2ff53b41926f5d7cb42ee4e0f
    
    The original CL had moved a call to ToString() to within
    DCHECK, because the result is used only by DCHECK. But the
    ToString() has a side effect that must be performed.
    
    Because of the change, this CL breaks if DCHECK is not
    enabled. Unfortunately, no build configs in trybots and
    CQs have DCHECK disabled.
    
    Reverted the change, and added TODO to clean it up.
    
    Original change's description:
    > Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow
    >
    > This patch allows computing NGOffsetMapping for legacy inline
    > formatting context.
    >
    > For an experimental project "Invisible DOM"[1][2] to support
    > the find-in-page feature, it is needed to compute the text
    > content with whitespace collapsing applied, along with the
    > mapping to the DOM offset. This patch adds an API to compute
    > NGOffsetMapping even when the LayoutBlockFlow is not laid out
    > by LayoutNG for that purpose.
    >
    > Note that the project is still in the early phase. We may
    > revisit the design as it moves forward.
    >
    > [1] https://github.com/rakina/searchable-invisible-dom
    > [2] https://www.chromestatus.com/feature/5105291213406208
    >
    > Bug: 636993, 873057
    > Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882
    > Reviewed-on: https://chromium-review.googlesource.com/c/1322184
    > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    > Reviewed-by: Emil A Eklund <eae@chromium.org>
    > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    > Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
    > Commit-Queue: Koji Ishii <kojii@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606292}
    
    TBR=yoshin@chromium.org, eae@chromium.org, xiaochengh@chromium.org, rakina@chromium.org
    
    Bug: 636993, 873057
    Change-Id: I8a29073fb18a1349d758d37033e6b046a54d5beb
    Reviewed-on: https://chromium-review.googlesource.com/c/1327582
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606786}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_offset_mapping_test.cc
  11. Document ContentSettings.Exceptions.media-engagement.

    Changed by Balazs Engedy - engedyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:28:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d8eed38bec9b93351d1e3cd65f981380acf6e3c

    Comments

    Document ContentSettings.Exceptions.media-engagement.
    
    Add the missing histogram suffix `media-engagement` to histograms.xml.
    This is the content setting type with by far the largest number of
    exceptions, yet missing from the dashboards.
    
    Bug: 890129
    Change-Id: Iaca89cf7b28db59a9d3c9baf3f810e765a8308a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1326147
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606785}

    Changed files

    • tools/metrics/histograms/histograms.xml
  12. Roll src/third_party/depot_tools 98c0fdb927c4..6edb632ff8cd (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:25:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1fdb6589087a7a301a61113f8b7fca1fb70bc52

    Comments

    Roll src/third_party/depot_tools 98c0fdb927c4..6edb632ff8cd (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98c0fdb927c4..6edb632ff8cd
    
    
    git log 98c0fdb927c4..6edb632ff8cd --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 vadimsh@chromium.org [cipd] Bump CIPD client and vpython versions.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@6edb632ff8cd
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ic57f994925c49696f5f1f3da863df1b317081f7e
    Reviewed-on: https://chromium-review.googlesource.com/c/1328523
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606784}

    Changed files

    • DEPS
  13. Create target in //components/signin for shared code

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:24:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9bef2ebf0c9a8c06070e9de14cd17f5a5cf1b4d9

    Comments

    Create target in //components/signin for shared code
    
    //components/signin/core/browser contains three different types of code:
    
    1. Code that forms the guts of IdentityManager and will form the guts of
    the Identity Service implementation (e.g., SigninManager).
    
    2. Code that will be clients of IdentityManager (e.g., SigninTracker).
    
    3. Code that will be used on both sides (e.g., AccountInfo).
    
    1 and 2 have already been split via a preceding CL. This CL creates 3.
    To start off with, 3 contains two pieces of code that were already in
    their own standalone targets for similar motivations as the above:
    account_info.* and signin_metrics.*. In the future more code will
    likely move in.
    
    Bug: 901859
    Change-Id: Ibcae3c9f1ecff2dc7ccd013046b74c97b3dd2b7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1323114
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606783}

    Changed files

    • components/autofill/core/browser/BUILD.gn
    • components/signin/core/browser/BUILD.gn
    • components/sync/BUILD.gn
    • ios/chrome/browser/ui/authentication/BUILD.gn
    • services/identity/BUILD.gn
    • services/identity/public/cpp/BUILD.gn
    • services/identity/public/cpp/account_info.typemap