Home | Search | chromium - Builders
Login

Builder Win Builder (dbg) Build 54294 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision03b4fcd98e2647b8560c90b7f650a7f57cff96da
Got Revision03b4fcd98e2647b8560c90b7f650a7f57cff96da

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
  2. Sergey Kuznetsov (kuznetsovsohnoyoudont@yandex-team.ru)
  3. Mihai Sardarescu (msardaohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 14:35:21 UTC
Start Friday, 12-Oct-18 14:35:23 UTC
End Friday, 12-Oct-18 14:48:37 UTC
Pending 2 secs
Execution 13 mins 13 secs

All Changes:

  1. Apply 'lazyload' feature policy for images

    Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:32:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03b4fcd98e2647b8560c90b7f650a7f57cff96da

    Comments

    Apply 'lazyload' feature policy for images
    
    In CL 1171374 'lazyload' feature policy was introduced as a new
    policy-controlled feature which would modify (restrict) the usage of the
    lazyload attribute. The implementation only applied the feature to frame
    owner elements. This CL extends the policy's coverage to images as well.
    
    Bug: 869492
    Change-Id: I9a2bd309ac366b75308b657d3ea129a7717ad23f
    Reviewed-on: https://chromium-review.googlesource.com/c/1251024
    Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
    Reviewed-by: Fredrik Söderquist <fs@opera.com>
    Reviewed-by: rajendrant <rajendrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599204}

    Changed files

    • third_party/WebKit/LayoutTests/NeverFixTests
    • third_party/WebKit/LayoutTests/VirtualTestSuites
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-image-tentative.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-disabled-image-tentative.sub.html.headers
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-enabled-image-tentative.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/lazyload/lazyload-image-attribute-on-sanity-check-tentative.sub.html
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/common.js
    • third_party/WebKit/LayoutTests/external/wpt/feature-policy/experimental-features/resources/lazyload.png
    • third_party/blink/renderer/core/html/html_image_element.cc
    • third_party/blink/renderer/core/html/parser/html_preload_scanner.cc
    • third_party/blink/renderer/core/html/parser/html_preload_scanner.h
    • third_party/blink/renderer/core/loader/image_loader.cc
  2. Fix possible crash when |change_dispatcher_| gone.

    Changed by Sergey Kuznetsov - kuznetsovsohnoyoudont@yandex-team.ru
    Changed at Friday, 12-Oct-18 14:29:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0edf161ea086a970d14c9946ded919743e693731

    Comments

    Fix possible crash when |change_dispatcher_| gone.
    
    Nothing prevents CookieMonsterChangeDispatcher::Subscription to
    outlive CookieMonsterChangeDispatcher.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ifa2cd0c8def9ae1c63a0a3d37bd469bbbc78e5ca
    Reviewed-on: https://chromium-review.googlesource.com/c/1242460
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599203}

    Changed files

    • ios/net/cookies/cookie_store_ios.h
    • ios/net/cookies/cookie_store_ios.mm
    • net/cookies/cookie_monster_change_dispatcher.cc
    • net/cookies/cookie_store_change_unittest.h
    • net/cookies/cookie_store_unittest.h
  3. Rename method in token service diagnostic observer for clarity

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 14:27:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 466b727ac3cd8f967fed05a86562c01616824627

    Comments

    Rename method in token service diagnostic observer for clarity
    
    Bug: NONE
    Change-Id: I18d05d59ba0be38d7598396fab2cef8b44647fcf
    Reviewed-on: https://chromium-review.googlesource.com/c/1278754
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599202}

    Changed files

    • components/signin/core/browser/about_signin_internals.cc
    • components/signin/core/browser/about_signin_internals.h
    • google_apis/gaia/oauth2_token_service.cc
    • google_apis/gaia/oauth2_token_service.h