Home | Search | chromium - Builders
Login

Builder Win 7 Tests x64 (1) Build 44195 Microsoft Windows

Results:

Success

Trigger Info:

Projectchromium
Revision703e2b8a5b805ecd4fba4bffb76095125330cec4
Got Revision703e2b8a5b805ecd4fba4bffb76095125330cec4

Execution:

Steps and Logfiles:

Show:
  1. ( 518 ms ) setup_build
    running recipe: "chromium"
  2. ( 230 ms ) report builders
     
    running tester 'Win 7 Tests x64 (1)' on master 'chromium.win'
  3. ( 2 secs ) taskkill
  4. ( 2 mins 20 secs ) bot_update
    [54GB/349GB used (15%)]
  5. ( 640 ms ) swarming.py --version
    0.13
  6. ( 20 secs ) gclient runhooks
  7. ( 663 ms ) read test spec (chromium.win.json)
    path: e:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 458 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "e:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 2 secs ) build directory
  10. ( 2 mins 7 secs ) extract build
  11. ( 931 ms ) find isolated tests
  12. ( 2 secs ) accessibility_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  13. ( 4 secs ) angle_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 56s
  14. ( 2 secs ) app_shell_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  15. ( 2 secs ) aura_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  16. ( 3 secs ) base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 31s
  17. ( 2 secs ) blink_common_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  18. ( 2 secs ) blink_fuzzer_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  19. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 24s
  20. ( 3 secs ) blink_platform_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:00.809621
  21. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  22. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  23. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  24. ( 2 secs ) capture_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  25. ( 2 secs ) cast_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  26. ( 4 secs ) cc_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:29.077623
  27. ( 2 secs ) chrome_app_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  28. ( 2 secs ) chrome_cleaner_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:04.449286
  29. ( 2 secs ) chrome_elf_import_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  30. ( 2 secs ) chrome_elf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  31. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 19s
  32. ( 2 secs ) components_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  33. ( 2 secs ) network_service_components_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 39s
  34. ( 8 secs ) components_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:17.331505
  35. ( 2 secs ) compositor_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  36. ( 1 mins 53 secs ) content_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:07:42.604650
  37. ( 2 secs ) perfetto_content_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 32s
  38. ( 4 secs ) content_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 51s
  39. ( 2 secs ) courgette_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  40. ( 2 secs ) crashpad_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  41. ( 2 secs ) cronet_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 24s
  42. ( 2 secs ) cronet_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 25s
  43. ( 2 secs ) crypto_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  44. ( 2 secs ) device_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  45. ( 2 secs ) display_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  46. ( 2 secs ) elevation_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  47. ( 2 secs ) events_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 26s
  48. ( 2 secs ) extensions_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 36s
  49. ( 2 secs ) network_service_extensions_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 38s
  50. ( 2 secs ) extensions_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 30s
  51. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  52. ( 2 secs ) gcm_unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  53. ( 4 secs ) gfx_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  54. ( 2 secs ) gin_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  55. ( 2 secs ) google_apis_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  56. ( 3 secs ) gpu_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  57. ( 2 secs ) headless_browsertests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 37s
  58. ( 2 secs ) headless_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  59. ( 2 secs ) install_static_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  60. ( 2 secs ) installer_util_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  61. ( 2 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:26.340142
  62. ( 2 secs ) ipc_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  63. ( 2 secs ) jingle_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 24s
  64. ( 2 secs ) latency_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  65. ( 2 secs ) leveldb_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  66. ( 2 secs ) libjingle_xmpp_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  67. ( 3 secs ) media_blink_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  68. ( 2 secs ) media_service_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  69. ( 4 secs ) media_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 35s
  70. ( 2 secs ) message_center_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 12s
  71. ( 2 secs ) midi_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  72. ( 3 secs ) mojo_core_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  73. ( 2 secs ) mojo_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  74. ( 2 secs ) nacl_loader_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  75. ( 2 secs ) native_theme_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  76. ( 14 secs ) net_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:02:25.231786
  77. ( 2 secs ) pdf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  78. ( 2 secs ) ppapi_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  79. ( 2 secs ) printing_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  80. ( 2 secs ) remoting_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  81. ( 2 secs ) sbox_integration_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 15s
  82. ( 2 secs ) sbox_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 47s
  83. ( 2 secs ) sbox_validation_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  84. ( 2 secs ) service_manager_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  85. ( 3 secs ) services_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 44s
  86. ( 2 secs ) setup_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 16s
  87. ( 2 secs ) shell_dialogs_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  88. ( 2 secs ) skia_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 17s
  89. ( 2 secs ) snapshot_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 25s
  90. ( 2 secs ) sql_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  91. ( 2 secs ) storage_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 14s
  92. ( 2 secs ) sync_integration_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:04:27.519400
  93. ( 2 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:07.995604
  94. ( 2 secs ) ui_base_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
  95. ( 3 secs ) ui_touch_selection_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 22s
  96. ( 7 secs ) unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:59.167575
  97. ( 2 secs ) url_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 10s
  98. ( 2 secs ) views_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
  99. ( 3 secs ) viz_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:22.606148
  100. ( 2 secs ) vr_common_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  101. ( 2 secs ) vr_pixeltests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  102. ( 5 secs ) webkit_unit_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 49s
  103. ( 2 secs ) wm_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 21s
  104. ( 2 secs ) wtf_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
  105. ( 2 secs ) zucchini_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 18s
  106. ( 3 secs ) network_service_content_browsertests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:05:57.437285 (shard #0)
    Min shard duration: 0:04:29.783752 (shard #1)
  107. ( 3 secs ) interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:07:04.682937 (shard #2)
    Min shard duration: 0:04:13.074954 (shard #1)
  108. ( 2 secs ) network_service_interactive_ui_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:09:23.169911 (shard #0)
    Min shard duration: 0:05:23.525678 (shard #1)
  109. ( 3 secs ) webui_polymer2_browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:05:49.108385 (shard #3)
    Min shard duration: 0:03:12.892988 (shard #2)
  110. ( 51 secs ) browser_tests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:14:26.603986 (shard #2)
    Min shard duration: 0:06:08.030345 (shard #7)
  111. ( 10 secs ) network_service_browser_tests
    Run on OS: 'Windows-7-SP1'
    Max pending time: 12s (shard #14)
    Max shard duration: 0:09:21.587603 (shard #14)
    Min shard duration: 0:04:12.680545 (shard #10)
  112. ( 2 secs ) chromedriver_py_tests
    Run on OS: 'Windows-7-SP1'
    Pending time: 11s
    Shard duration: 0:04:46.552245
    Total tests: 144
    * Passed: 144 (144 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  113. ( 2 secs ) chromedriver_replay_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 11s
    Total tests: 33
    * Passed: 33 (33 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  114. ( 2 secs ) components_perftests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:22.112267
    Total tests: n/a
     
  115. ( 2 secs ) content_shell_crash_test
    Run on OS: 'Windows-7-SP1'
    Shard duration: 23s
    Total tests: n/a
     
  116. ( 2 secs ) metrics_python_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  117. ( 2 secs ) telemetry_gpu_unittests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 0:01:10.245375
    Total tests: 35
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  118. ( 3 secs ) telemetry_perf_unittests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:07:12.997800 (shard #10)
    Min shard duration: 0:01:58.898016 (shard #7)
    Total tests: 285
    * Passed: 245 (245 expected, 0 unexpected)
    * Skipped: 39 (39 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 1 (1 expected, 0 unexpected)
     
  119. ( 3 secs ) telemetry_unittests
    Run on OS: 'Windows-7-SP1'
    Max shard duration: 0:04:29.435082 (shard #3)
    Min shard duration: 0:03:31.887193 (shard #0)
    Total tests: 1169
    * Passed: 1062 (1062 expected, 0 unexpected)
    * Skipped: 106 (106 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 1 (1 expected, 0 unexpected)
     
  120. ( 2 secs ) views_perftests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 13s
    Total tests: n/a
     
  121. ( 6 secs ) webkit_python_tests
    Run on OS: 'Windows-7-SP1'
    Shard duration: 34s
    Total tests: 1551
    * Passed: 1535 (1535 expected, 0 unexpected)
    * Skipped: 16 (16 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  122. ( 1 mins 22 secs ) test_installer
  123. ( 313 ms ) Tests statistics
     
    Stats
    Total shards: 155
    Total runtime: 5:27:25.175999
     
  124. ( 1 secs ) process_dumps

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "e:\\b\\s\\w\\ir\\cache", "temp_dir": "e:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm361-m1" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539352751803343, "id": "8932865364883535936", "project": "chromium", "tags": ["builder:Win 7 Tests x64 (1)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/703e2b8a5b805ecd4fba4bffb76095125330cec4", "gitiles_ref:refs/heads/master", "parent_buildername:Win x64 Builder", "parent_buildnumber:57077", "scheduler_invocation_id:9098295427104013264", "scheduler_job_id:chromium/Win 7 Tests x64 (1)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Win 7 Tests x64 (1)" setup_build
buildnumber 44195 setup_build
mastername "chromium.win" setup_build
parent_buildername "Win x64 Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" setup_build
parent_got_revision_cp "refs/heads/master@{#599196}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25138}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" setup_build
swarm_hashes {"accessibility_unittests": "31ecc31860334be53728cae571267b4884dc0e18", "angle_unittests": "1fe6b1d8f01935f32eee260b6d36b1decb9df3b9", "app_shell_unittests": "bb2323cbdda103f9328a12806971e8763daf69b6", "aura_unittests": "c2ca001a83ecb5aa12515bbb03390f75f2f44624", "base_unittests": "4fabfb94f6d0d9ade5c7c3f9553adecd7c257171", "blink_common_unittests": "c5d37adb8374d6b8380763baee03f6b7fcddeecf", "blink_fuzzer_unittests": "e5d8967b3dd64ecb2e683dafed46db2cdc94a224", "blink_heap_unittests": "943fdb7a96af0a56101477d0b979d810c85bd58d", "blink_platform_unittests": "4a36dcc493d1279b0b9a5cb0dc4f912c467f7c80", "boringssl_crypto_tests": "378012e8e9b3565795307d64787fc7ecc44f2f86", "boringssl_ssl_tests": "5d30be45c4ef967f869ebb8f2f575d37a17af7ef", "browser_tests": "1e3a0fced2a627a12ac15a84ab48ed5a628ac5fa", "cacheinvalidation_unittests": "65d8a7fc46a61adadc454b653c400b91fa639779", "capture_unittests": "862a15eec389849ecba0ed10b76efbbfa1370bd3", "cast_unittests": "f6a71d345218fc1ccadcd7f3fa60a257de277586", "cc_unittests": "ece80a0f56fe4831172f92f1be076e3daf9ccb16", "chrome_app_unittests": "34fdafea49be4ec124b8b414e530a04a49e5bda1", "chrome_cleaner_unittests": "4c72867ce93281670fdddc4c073a144667155e0b", "chrome_elf_import_unittests": "817a0bddcf8000032c21ff28915c801c01d5e3d1", "chrome_elf_unittests": "e077cd31d010ec3ab28fa649f6237badf1c18f60", "chromedriver_py_tests": "26e73d2cc55f6b0f722438bd9c8ccddc01753cbb", "chromedriver_replay_unittests": "15853affd58deafbf63b9f93c3281a9bd1674c44", "chromedriver_unittests": "ba3c381d5d9901a84678568e5534662ebd1ce781", "components_browsertests": "c99c29d3fcad699ec4b7bcca7637d51a88a31d34", "components_perftests": "2b20ccd7855f44e50fff84a01675056bac419790", "components_unittests": "b84bdd50ca189d5063385ff0bca2020587ef74ce", "compositor_unittests": "e4618349f0149f2218013eba5724ae226e6c7abc", "content_browsertests": "e9974f6ff61b74225df1d0d121cc65b08cb5ed77", "content_shell_crash_test": "bdd6edb2e6c329c122f12be21925471f9e48bbb4", "content_unittests": "83769d4d67ae86607c5b289166282141a1d079d0", "courgette_unittests": "3e0132636d4e0c00f691a7732580fd22b806f0b0", "crashpad_tests": "b6f65e055ad6da864bf4258987b3eda11d27d5b9", "cronet_tests": "64a3bc8604104a66c41cf64b225cd67abe6cf07c", "cronet_unittests": "23045b2c844182e20ba4340ab819e6c6cfab166c", "crypto_unittests": "531b6a22b36aecd1ebfd32ba856426817927a111", "device_unittests": "ce5cf6d9e9e668b74cd605c231dea73fbc26ad57", "display_unittests": "a9b5b9a0d511b03bbbb042522396858edb2c57d3", "elevation_service_unittests": "bf3c899836c8f9bc90fb3d7e6a2f9fee4412fe41", "events_unittests": "6bdef1599f6cb3fa6005903d8476fb512908a29b", "extensions_browsertests": "ee5d23f10ee97bce0d00a2565b7e2393577f37eb", "extensions_unittests": "f954b4063e57c5d2411631705527b4268bc61fde", "filesystem_service_unittests": "fc8bc8c2896cf41af589c4982ee351671d99f2cf", "gcm_unit_tests": "284c1a87864c0568fbb12f90d6060cee250a57e8", "gfx_unittests": "af4fab501320687140981b2c89e55d49f931e61f", "gin_unittests": "908cf0347f48173fb6604a4074432482342b3afb", "google_apis_unittests": "9d168718876dfbdd941072d828e6f1e7a4fbf8ef", "gpu_unittests": "701414f84643e3c8907329e38337c42ffe36da54", "headless_browsertests": "f4260bd341ffebabbf15cf85d4203efe1a69a5d9", "headless_unittests": "eddec83837e604566d9cca69391f539a9d8606f8", "install_static_unittests": "e34bbc006a5c0a05cdc82fbcff68e23d76a2b413", "installer_util_unittests": "1d818a9aa18207fc8c6f023959fc55dc81aac7a9", "interactive_ui_tests": "30d8a47b5eeb93f1b92635f016cbf4ba7a12ad08", "ipc_tests": "f01ef9aa68abeac61ffd2e4aca8f3f311aac8fa4", "jingle_unittests": "7d06fa0e965d44d78f11495b598d49310487ccc6", "latency_unittests": "3828aa0cdc85ce9a8d3e247fd54553a9c0a2966b", "leveldb_service_unittests": "4004d364d81ea438a9584b0e60c953af48fade2f", "libjingle_xmpp_unittests": "f63a0ea3a7070de1dd115c00801ff5bd9692f29c", "media_blink_unittests": "45d08988885be51cdf099ca44c854cf83a3f5a24", "media_service_unittests": "4445b7c3c8f2d8e7a55683cfb429378420bb9123", "media_unittests": "a929b77830ff696431dbc0acd4cc9a8af2f4a33d", "message_center_unittests": "2879333923fa5046f9a82a0096fad8130041e777", "metrics_python_tests": "5c75b456c34f84fa2db0aa21c014f9607cbf9cfc", "midi_unittests": "2b1198aace3cbd3f9604843207aff4c784cfba1c", "mini_installer_tests": "c7df8fe9cac7c26efb1d69699011d1ad63f1dd30", "mojo_core_unittests": "239659e3087699d2b74ee7581d71929bfd377151", "mojo_unittests": "450f203df1310697d87794373d98111064b51acb", "nacl_loader_unittests": "d2e987f02d210ff478f35a3b4c6bb88abc0bcfcd", "native_theme_unittests": "18a966190be545f82467a1138ca65846e63fa58e", "net_unittests": "c40ad6f8e364a1eb993b3f61cbde4f8bd126f69d", "notification_helper_unittests": "6b4120b54b76d0db3d51cae8b81b91325ebb4464", "pdf_unittests": "f5e430dd6e85cf338674af308e5cf8ff58b9d995", "ppapi_unittests": "682caef1071536983ec74bf398863fcb4a56746f", "printing_unittests": "dc1361de21f9f1a38ceb4d35c046deeb766f403e", "remoting_unittests": "fb89c52630a94181c44a124fc27044f0f233084c", "sbox_integration_tests": "1c540072390d8cad694e558e83b5187f893c28f6", "sbox_unittests": "045e40b9c3be979fbad285197d1fec6ff8a870af", "sbox_validation_tests": "9e6c9aef8d07b692e7155aeb9206764ab6bf4ce4", "service_manager_unittests": "3ec975923d49136c3c5687f8278b8f9786b16218", "services_unittests": "d7362a177c4145995787f1e0dc2bea528ea2c7e5", "setup_unittests": "4026b8af4c81cd6e6e4d3078c93bdf56f5ac7aca", "shell_dialogs_unittests": "7b97efb528812337b1e3671ea57b3292de530355", "skia_unittests": "a7b9f1d5e8cd393c03034db5316d4dfc4bce4a5f", "snapshot_unittests": "baea9c9f349f1aff8c046a74ea43afcb33005fe6", "sql_unittests": "3f26ddf46d4c0390c9ffa8539a29f630cf9a386f", "storage_unittests": "1e1a58897282187ac2d48b8808870a501bbb799e", "sync_integration_tests": "39a1bd6dacaccf7e8d9e62dd55a9d7b35b250d75", "telemetry_gpu_unittests": "72946986e859c6fcd41aa9f50261a0513cdf1545", "telemetry_perf_unittests": "5b545fe977eb593f21a2f753077b54540b56b890", "telemetry_unittests": "eb5000922d712779a3df413b645e256a7bdca8bd", "traffic_annotation_auditor_unittests": "adb337dfe321988481ef14614e24baa021b037dd", "ui_base_unittests": "2d7700700cd166d85b1bfc11eb4eb7729e038b0e", "ui_touch_selection_unittests": "e28ef58abd06a4e56a30cf927cdf8ec3438654b8", "unit_tests": "4f87dc3a1b747e744e33ac9bd72d695dbffefc8b", "url_unittests": "8f4340f985db2bae1ae49770d4cde8758acbd5b4", "views_perftests": "649684158136e14593875c0374bd6a6ad7737e9a", "views_unittests": "64c0af2911469c4a36d803f2e7e8921537a750f2", "viz_unittests": "22375fc9f70e8324cb5f3b9d6735cce6841fd24d", "vr_common_unittests": "b2edee4562b7175edb918fb83cece542e743f4c4", "vr_pixeltests": "b6fb1bd5ce2c2d3a7dbfc59393c23fdfa2abfa0f", "webkit_python_tests": "515245050563599ed527d31581bbd0291f2d7c30", "webkit_unit_tests": "3b4e5718ec630fa4bf6d17a001372790bbed9739", "wm_unittests": "d06b2ffce930ac1731eeed0c0cba841252e9cbf0", "wtf_unittests": "31653aa079bc414dfe06a0fd678a4886ee2f4eaf", "zucchini_unittests": "8546fb15af531e4d43d8e42f231a5a14c07383ef"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "703e2b8a5b805ecd4fba4bffb76095125330cec4" bot_update
got_revision_cp "refs/heads/master@{#599196}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25138}" bot_update
swarm_hashes {"accessibility_unittests": "31ecc31860334be53728cae571267b4884dc0e18", "angle_unittests": "1fe6b1d8f01935f32eee260b6d36b1decb9df3b9", "app_shell_unittests": "bb2323cbdda103f9328a12806971e8763daf69b6", "aura_unittests": "c2ca001a83ecb5aa12515bbb03390f75f2f44624", "base_unittests": "4fabfb94f6d0d9ade5c7c3f9553adecd7c257171", "blink_common_unittests": "c5d37adb8374d6b8380763baee03f6b7fcddeecf", "blink_fuzzer_unittests": "e5d8967b3dd64ecb2e683dafed46db2cdc94a224", "blink_heap_unittests": "943fdb7a96af0a56101477d0b979d810c85bd58d", "blink_platform_unittests": "4a36dcc493d1279b0b9a5cb0dc4f912c467f7c80", "boringssl_crypto_tests": "378012e8e9b3565795307d64787fc7ecc44f2f86", "boringssl_ssl_tests": "5d30be45c4ef967f869ebb8f2f575d37a17af7ef", "browser_tests": "1e3a0fced2a627a12ac15a84ab48ed5a628ac5fa", "cacheinvalidation_unittests": "65d8a7fc46a61adadc454b653c400b91fa639779", "capture_unittests": "862a15eec389849ecba0ed10b76efbbfa1370bd3", "cast_unittests": "f6a71d345218fc1ccadcd7f3fa60a257de277586", "cc_unittests": "ece80a0f56fe4831172f92f1be076e3daf9ccb16", "chrome_app_unittests": "34fdafea49be4ec124b8b414e530a04a49e5bda1", "chrome_cleaner_unittests": "4c72867ce93281670fdddc4c073a144667155e0b", "chrome_elf_import_unittests": "817a0bddcf8000032c21ff28915c801c01d5e3d1", "chrome_elf_unittests": "e077cd31d010ec3ab28fa649f6237badf1c18f60", "chromedriver_py_tests": "26e73d2cc55f6b0f722438bd9c8ccddc01753cbb", "chromedriver_replay_unittests": "15853affd58deafbf63b9f93c3281a9bd1674c44", "chromedriver_unittests": "ba3c381d5d9901a84678568e5534662ebd1ce781", "components_browsertests": "c99c29d3fcad699ec4b7bcca7637d51a88a31d34", "components_perftests": "2b20ccd7855f44e50fff84a01675056bac419790", "components_unittests": "b84bdd50ca189d5063385ff0bca2020587ef74ce", "compositor_unittests": "e4618349f0149f2218013eba5724ae226e6c7abc", "content_browsertests": "e9974f6ff61b74225df1d0d121cc65b08cb5ed77", "content_shell_crash_test": "bdd6edb2e6c329c122f12be21925471f9e48bbb4", "content_unittests": "83769d4d67ae86607c5b289166282141a1d079d0", "courgette_unittests": "3e0132636d4e0c00f691a7732580fd22b806f0b0", "crashpad_tests": "b6f65e055ad6da864bf4258987b3eda11d27d5b9", "cronet_tests": "64a3bc8604104a66c41cf64b225cd67abe6cf07c", "cronet_unittests": "23045b2c844182e20ba4340ab819e6c6cfab166c", "crypto_unittests": "531b6a22b36aecd1ebfd32ba856426817927a111", "device_unittests": "ce5cf6d9e9e668b74cd605c231dea73fbc26ad57", "display_unittests": "a9b5b9a0d511b03bbbb042522396858edb2c57d3", "elevation_service_unittests": "bf3c899836c8f9bc90fb3d7e6a2f9fee4412fe41", "events_unittests": "6bdef1599f6cb3fa6005903d8476fb512908a29b", "extensions_browsertests": "ee5d23f10ee97bce0d00a2565b7e2393577f37eb", "extensions_unittests": "f954b4063e57c5d2411631705527b4268bc61fde", "filesystem_service_unittests": "fc8bc8c2896cf41af589c4982ee351671d99f2cf", "gcm_unit_tests": "284c1a87864c0568fbb12f90d6060cee250a57e8", "gfx_unittests": "af4fab501320687140981b2c89e55d49f931e61f", "gin_unittests": "908cf0347f48173fb6604a4074432482342b3afb", "google_apis_unittests": "9d168718876dfbdd941072d828e6f1e7a4fbf8ef", "gpu_unittests": "701414f84643e3c8907329e38337c42ffe36da54", "headless_browsertests": "f4260bd341ffebabbf15cf85d4203efe1a69a5d9", "headless_unittests": "eddec83837e604566d9cca69391f539a9d8606f8", "install_static_unittests": "e34bbc006a5c0a05cdc82fbcff68e23d76a2b413", "installer_util_unittests": "1d818a9aa18207fc8c6f023959fc55dc81aac7a9", "interactive_ui_tests": "30d8a47b5eeb93f1b92635f016cbf4ba7a12ad08", "ipc_tests": "f01ef9aa68abeac61ffd2e4aca8f3f311aac8fa4", "jingle_unittests": "7d06fa0e965d44d78f11495b598d49310487ccc6", "latency_unittests": "3828aa0cdc85ce9a8d3e247fd54553a9c0a2966b", "leveldb_service_unittests": "4004d364d81ea438a9584b0e60c953af48fade2f", "libjingle_xmpp_unittests": "f63a0ea3a7070de1dd115c00801ff5bd9692f29c", "media_blink_unittests": "45d08988885be51cdf099ca44c854cf83a3f5a24", "media_service_unittests": "4445b7c3c8f2d8e7a55683cfb429378420bb9123", "media_unittests": "a929b77830ff696431dbc0acd4cc9a8af2f4a33d", "message_center_unittests": "2879333923fa5046f9a82a0096fad8130041e777", "metrics_python_tests": "5c75b456c34f84fa2db0aa21c014f9607cbf9cfc", "midi_unittests": "2b1198aace3cbd3f9604843207aff4c784cfba1c", "mini_installer_tests": "c7df8fe9cac7c26efb1d69699011d1ad63f1dd30", "mojo_core_unittests": "239659e3087699d2b74ee7581d71929bfd377151", "mojo_unittests": "450f203df1310697d87794373d98111064b51acb", "nacl_loader_unittests": "d2e987f02d210ff478f35a3b4c6bb88abc0bcfcd", "native_theme_unittests": "18a966190be545f82467a1138ca65846e63fa58e", "net_unittests": "c40ad6f8e364a1eb993b3f61cbde4f8bd126f69d", "notification_helper_unittests": "6b4120b54b76d0db3d51cae8b81b91325ebb4464", "pdf_unittests": "f5e430dd6e85cf338674af308e5cf8ff58b9d995", "ppapi_unittests": "682caef1071536983ec74bf398863fcb4a56746f", "printing_unittests": "dc1361de21f9f1a38ceb4d35c046deeb766f403e", "remoting_unittests": "fb89c52630a94181c44a124fc27044f0f233084c", "sbox_integration_tests": "1c540072390d8cad694e558e83b5187f893c28f6", "sbox_unittests": "045e40b9c3be979fbad285197d1fec6ff8a870af", "sbox_validation_tests": "9e6c9aef8d07b692e7155aeb9206764ab6bf4ce4", "service_manager_unittests": "3ec975923d49136c3c5687f8278b8f9786b16218", "services_unittests": "d7362a177c4145995787f1e0dc2bea528ea2c7e5", "setup_unittests": "4026b8af4c81cd6e6e4d3078c93bdf56f5ac7aca", "shell_dialogs_unittests": "7b97efb528812337b1e3671ea57b3292de530355", "skia_unittests": "a7b9f1d5e8cd393c03034db5316d4dfc4bce4a5f", "snapshot_unittests": "baea9c9f349f1aff8c046a74ea43afcb33005fe6", "sql_unittests": "3f26ddf46d4c0390c9ffa8539a29f630cf9a386f", "storage_unittests": "1e1a58897282187ac2d48b8808870a501bbb799e", "sync_integration_tests": "39a1bd6dacaccf7e8d9e62dd55a9d7b35b250d75", "telemetry_gpu_unittests": "72946986e859c6fcd41aa9f50261a0513cdf1545", "telemetry_perf_unittests": "5b545fe977eb593f21a2f753077b54540b56b890", "telemetry_unittests": "eb5000922d712779a3df413b645e256a7bdca8bd", "traffic_annotation_auditor_unittests": "adb337dfe321988481ef14614e24baa021b037dd", "ui_base_unittests": "2d7700700cd166d85b1bfc11eb4eb7729e038b0e", "ui_touch_selection_unittests": "e28ef58abd06a4e56a30cf927cdf8ec3438654b8", "unit_tests": "4f87dc3a1b747e744e33ac9bd72d695dbffefc8b", "url_unittests": "8f4340f985db2bae1ae49770d4cde8758acbd5b4", "views_perftests": "649684158136e14593875c0374bd6a6ad7737e9a", "views_unittests": "64c0af2911469c4a36d803f2e7e8921537a750f2", "viz_unittests": "22375fc9f70e8324cb5f3b9d6735cce6841fd24d", "vr_common_unittests": "b2edee4562b7175edb918fb83cece542e743f4c4", "vr_pixeltests": "b6fb1bd5ce2c2d3a7dbfc59393c23fdfa2abfa0f", "webkit_python_tests": "515245050563599ed527d31581bbd0291f2d7c30", "webkit_unit_tests": "3b4e5718ec630fa4bf6d17a001372790bbed9739", "wm_unittests": "d06b2ffce930ac1731eeed0c0cba841252e9cbf0", "wtf_unittests": "31653aa079bc414dfe06a0fd678a4886ee2f4eaf", "zucchini_unittests": "8546fb15af531e4d43d8e42f231a5a14c07383ef"} find isolated tests

Blamelist:

  1. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  2. Marc Treib (treibohnoyoudont@chromium.org)
  3. Stephane Zermatten (szermattohnoyoudont@chromium.org)
  4. Peng Huang (penghuangohnoyoudont@chromium.org)
  5. Ben Kelly (wanderviewohnoyoudont@chromium.org)
  6. Shu Chen (shuchenohnoyoudont@google.com)
  7. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  8. Colin Blundell (blundellohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 13:59:11 UTC
Start Friday, 12-Oct-18 13:59:16 UTC
End Friday, 12-Oct-18 14:28:26 UTC
Pending 4 secs
Execution 29 mins 9 secs

All Changes:

  1. Restore FrameLoadRequest::HrefTranslate

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 703e2b8a5b805ecd4fba4bffb76095125330cec4

    Comments

    Restore FrameLoadRequest::HrefTranslate
    
    This was accidentaly removed as part of FrameLoadRequest cleanup.
    
    Bug: none
    Change-Id: I58bf324729d397a2f0340831fd116ab749f7a213
    Reviewed-on: https://chromium-review.googlesource.com/c/1278290
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599196}

    Changed files

    • third_party/blink/renderer/core/html/html_anchor_element.cc
    • third_party/blink/renderer/core/loader/frame_load_request.h
  2. ProfileSyncService cleanup: Remove platform_sync_allowed_provider_

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0d63432c51741e6dc0bf48f0b84e4afb63f887f

    Comments

    ProfileSyncService cleanup: Remove platform_sync_allowed_provider_
    
    ProfileSyncService::platform_sync_allowed_provider_ was a callback that
    returned whether Android's "Master Sync" toggle is enabled, and so Sync
    shouldn't start up. However, PSS didn't know when the value changed, so
    the callback was kinda useless, and PSS could easily get into an
    inconsistent state (where there is a disable reason, but Sync is still
    running). Things were working out in practice only because the Android
    UI code also called RequestStart/Stop as necessary.
    So, since PSS needs change notifications anyway, let's make that
    explicit: This CL replaces the callback by a bool, which can be set
    explicitly.
    
    Bug: 867901
    Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90
    Reviewed-on: https://chromium-review.googlesource.com/c/1269870
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599195}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  3. [Autofill Assistant] Add Mathias and I as owners

    Changed by Stephane Zermatten - szermattohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b71114eba7ab4e982eaf03186b12503c8ca49c4

    Comments

    [Autofill Assistant] Add Mathias and I as owners
    
    Change-Id: I71ed01f39d1c81c62828d8e4900091e7941e7ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278399
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Commit-Queue: Ganggui Tang <gogerald@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599194}

    Changed files

    • components/autofill_assistant/OWNERS
  4. Hook up skia makeYUVAPromiseTexture API

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:39:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33ca177f048a1d593c5486b46f09ac9ea91071a9

    Comments

    Hook up skia makeYUVAPromiseTexture API
    
    Know issues:
     * Skia only draws Y plane.
     * makeYUVAPromiseTexture() will release context, even if it failed.
     * Skia doesn't accept GL_RGBA8 format for a yuva plane
    
    Bug: 824382
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Ic8da2b3de574ef2a0d527c79f34d383a676a3bc0
    Reviewed-on: https://chromium-review.googlesource.com/c/1262421
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599193}

    Changed files

    • components/viz/service/display/skia_output_surface.h
    • components/viz/service/display/skia_renderer.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.cc
    • components/viz/service/display_embedder/skia_output_surface_impl.h
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc
    • components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
  5. Make DataPipeBytesConsumer support ReadableStream loading better.

    Changed by Ben Kelly - wanderviewohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:36:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c43eba9311573672d0773beed07f117d08eed09f

    Comments

    Make DataPipeBytesConsumer support ReadableStream loading better.
    
    This CL fixes some edge condition interactions when being loaded as
    a ReadableStream.  In particular, it:
    
    1. Properly distinguishes between the end of the DataPipe and a closed
       DataPipe with bytes left to be read.  A ReadableStream that is not
       actively draining the pipe could get closed too early.
    2. Responses must support explicit completion in order to handle error
       conditions properly.  This CL makes DataPipeBytesConsumer wait
       for an explicit signal before closing.
    3. Service worker navigation preload is updated to provide the explicit
       completion signals.
    
    Bug: 894815
    Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1272715
    Commit-Queue: Ben Kelly <wanderview@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599192}

    Changed files

    • content/browser/service_worker/service_worker_browsertest.cc
    • third_party/blink/renderer/core/fetch/bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.cc
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer.h
    • third_party/blink/renderer/core/fetch/data_pipe_bytes_consumer_test.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.cc
    • third_party/blink/renderer/core/fetch/fetch_data_loader.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc
  6. Avoid using gypi_to_gn.py.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 13:25:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b85f543af1e343404dde1a2c51067b2ed5ac08cb

    Comments

    Avoid using gypi_to_gn.py.
    
    Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1267596
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599191}

    Changed files

    • third_party/google_input_tools/README.chromium
    • third_party/google_input_tools/builder.py
    • third_party/google_input_tools/closure.gni
    • third_party/google_input_tools/inputview.gni
    • third_party/google_input_tools/inputview.gypi
    • third_party/google_input_tools/update.py
    • ui/keyboard/BUILD.gn
  7. Revert "Files app: Select My files when there are no volumes"

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 13:17:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 402571f89e1aff1627ccf491110764c74029e3de

    Comments

    Revert "Files app: Select My files when there are no volumes"
    
    This reverts commit 5cd8c123e452c0b76fbbcaf53e82d86ca7d54930.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016
    
    Sample Failed Step: viz_browser_tests
    
    Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs
    
    Original change's description:
    > Files app: Select My files when there are no volumes
    > 
    > Make Files app select "My files" when there are no available volumes,
    > this to allow Files app to behave properly when volumes subsequently
    > become available.
    > 
    > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
    > non-null |displayRoot| before trying to change to |displayRoot|. This
    > fixes the error "Cannot read property 'getParent' of null" when Drive
    > volume becomes available before Downloads volume, which is the default
    > volume/root.
    > 
    > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
    > DriveFsTestVolume can re-mount itself.
    > 
    > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
    > Bug: 893161, 884967
    > Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
    > Reviewed-on: https://chromium-review.googlesource.com/c/1272418
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599026}
    
    Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893161, 884967, 889703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278063
    Cr-Commit-Position: refs/heads/master@{#599190}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
    • chromeos/components/drivefs/fake_drivefs.cc
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/integration_tests/file_manager/file_display.js
  8. Start using IdentityTestEnvironment in ProfileSyncServiceBundle

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:10:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 863a437d0fdbbba19ad5446420b72d2f91748a72

    Comments

    Start using IdentityTestEnvironment in ProfileSyncServiceBundle
    
    ProfileSyncServiceBundle owns and exposes signin-related objects for
    use by sync tests. These signin-related objects include ones that are
    deprecated by IdentityManager and no longer used directly in the
    production code being tested; however, up until now it has not been
    feasible to convert this test utility to using IdentityTestEnvironment,
    as doing so would have required converting the widespread usage of this
    utility in one go.
    
    We recently introduced an IdentityTestEnvironment usage mode wherein
    it can be supplied with IdentityManager's dependencies from the
    external client, precisely to enable incremental conversion in use cases
    like this. This CL exploits this usage mode to introduce
    IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
    example of its usage to eliminate a direct usage of the deprecated
    classes. Once the conversion is complete, ProfileSyncServiceBundle can
    then be changed to *only* hold an IdentityTestEnvironment object.
    
    Bug: 886600, 886599
    Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
    Reviewed-on: https://chromium-review.googlesource.com/c/1273065
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599189}

    Changed files

    • components/browser_sync/BUILD.gn
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h