Home | Search | chromium - Builders
Login

Builder WebKit Win10 Build 43217 Microsoft Windows

Results:

Failure webkit_layout_tests on Windows-10-15063

Trigger Info:

Projectchromium
Revision8c814268e0605b5134669e52db357d13aadd08fb
Got Revision8c814268e0605b5134669e52db357d13aadd08fb

Execution:

Steps and Logfiles:

Show:
  1. ( 595 ms ) setup_build
    running recipe: "chromium"
  2. ( 496 ms ) report builders
     
    running tester 'WebKit Win10' on master 'chromium.win'
  3. ( 5 secs ) taskkill
  4. ( 6 mins 43 secs ) bot_update
    [51GB/299GB used (17%)]
  5. ( 3 secs ) swarming.py --version
    0.13
  6. ( 46 secs ) gclient runhooks
  7. ( 638 ms ) read test spec (chromium.win.json)
    path: C:\b\s\w\ir\cache\builder\src\testing\buildbot\chromium.win.json
  8. ( 550 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\s\\w\\ir\\cache\\goma\\client"
  9. ( 1 secs ) build directory
  10. ( 548 ms ) find isolated tests
  11. ( 14 mins 42 secs ) webkit_layout_tests on Windows-10-15063
    Run on OS: 'Windows-10-15063'
    Max shard duration: 0:12:28.920161 (shard #5)
    Min shard duration: 0:09:23.115036 (shard #2)
    Total tests: 88199
    * Passed: 75131 (75069 expected, 62 unexpected)
    * Skipped: 10558 (10558 expected, 0 unexpected)
    * Failed: 2446 (2445 expected, >>>1 unexpected<<<)
    * Flaky: 64 (64 expected, 0 unexpected)
     
    Unexpected Failures:
    * http/tests/priorities/resource-load-priorities-service-worker.https.html
     
  12. ( 182 ms ) Tests statistics
     
    Stats
    Total shards: 12
    Total runtime: 1:17:59.357000
     
  13. ( 418 ms ) process_dumps
  14. ( 25 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "win10-727f49a0-us-west1-c-5zc5" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541760977779391, "id": "8930340156922347376", "project": "chromium", "tags": ["builder:WebKit Win10", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/8c814268e0605b5134669e52db357d13aadd08fb", "gitiles_ref:refs/heads/master", "parent_buildername:Win Builder", "parent_buildnumber:62653", "scheduler_invocation_id:9095770219155566096", "scheduler_job_id:chromium/WebKit Win10", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "WebKit Win10" setup_build
buildnumber 43217 setup_build
luci_migration_master_name "chromium.webkit" setup_build
mastername "chromium.win" setup_build
parent_buildername "Win Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "8c814268e0605b5134669e52db357d13aadd08fb" setup_build
parent_got_revision_cp "refs/heads/master@{#606782}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "c465c5ea7f6c2b562a1b537adf46673fea7a8b8c" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.283@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.win" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "8c814268e0605b5134669e52db357d13aadd08fb" setup_build
swarm_hashes {"accessibility_unittests": "c13f83cbda62873c024b9a5b474f380ecf685c18", "angle_unittests": "c8f1cc01ea7576b4051b6244eb6fb60814628c5b", "app_shell_unittests": "4600b6a1ae110db02876ca2d15e00339ada8a9e0", "aura_unittests": "731372d190f9af180af2f9788ab0147afe614133", "base_unittests": "f3c30a37b98db274e574df86bdc99d3da727206a", "blink_common_unittests": "89244a5ae13ff37fa8db5ce4c510069f76261f05", "blink_fuzzer_unittests": "e2d52bb5235ba71a8ad9727f989f6ffe51381052", "blink_heap_unittests": "ed437426318e472e91b90838ce1a5b6811d9c356", "blink_platform_unittests": "69bc8a043dfbd1bee5457f5f05a1cfb9987f6940", "boringssl_crypto_tests": "5cbd122125c88e172444851004cf7c6356eb2e14", "boringssl_ssl_tests": "3c6319eec61ca6770015702bd678ccae8f5be2b8", "browser_tests": "4246e9267942ac7332ea63769e8b5db8b8ba3627", "cacheinvalidation_unittests": "f98670c0a0110b115b39a5d78fcad0a1ba84c36d", "capture_unittests": "88b12b579a265158e438e126d16882d7959abbb9", "cast_unittests": "d684681a630f0bf77e36450b7ac9321737e022e9", "cc_unittests": "18c0ba29f999e04379a69c17594b53f3cf4a0e99", "chrome_app_unittests": "1f7f614f2fbfbb3f757465d0eaf8b4011e17ba2c", "chrome_cleaner_unittests": "467ebb08cf19d21ec2ff0d6a44d81dcec1037245", "chrome_elf_import_unittests": "a01e2b76d18650b9f306222e2e2f0d25ce6d7359", "chrome_elf_unittests": "7abf3446fe14dd69397f5c1e6080d314131d50b8", "chromedriver_py_tests": "8d35cc716668cfe627ecf033bef3a9153d19c1a2", "chromedriver_replay_unittests": "4bd1faf821fce24d79157820b7b7cd3ac2473ff6", "chromedriver_unittests": "0874f186a1b8115592e2b1030bad919057884760", "components_browsertests": "35f7b0492062fc1c6360eab1f8b66d20d7f78e9a", "components_perftests": "c4a11d63b13ba4cab03fa2f784acfde38b78e40b", "components_unittests": "2c42c03a312c2912d5d5e437218ca3add211bb73", "compositor_unittests": "2c8e2bad5169c34d0b411c353e656e2a2e30d751", "content_browsertests": "91f3c74045bb02f4e4edd510509561b2e637e6f6", "content_shell_crash_test": "131e73d3806e07948d64b2cc612b39760c2008d5", "content_unittests": "7a7df0e733b4dbcee4a49dbebc49d2a7b88cfe2a", "courgette_unittests": "a01003ca56c2c2dccee3b9220267a706cdd8a795", "crashpad_tests": "cd5637b4922a2670c2718131b3f39d803d908518", "cronet_tests": "1fb38a3166a751800311503bd4c1ce907c3ad3c7", "cronet_unittests": "2add57ca40e2e9bdfeeb9964d3d75285b7d05cb8", "crypto_unittests": "0efe4377be673869cb6407eb719bb46457a234f9", "device_unittests": "4953f166e3e44f1f02ad5f58a4064b9e7ceb7a88", "display_unittests": "595f2dd4814277b03814a2ea2f77c10a5204a36c", "elevation_service_unittests": "4a9dc3cfe88263a044fb5846e01ebb15c6e077e9", "events_unittests": "f0733c91c93ff9c3c8509d37c6017736efba1e23", "extensions_browsertests": "d7183c92594e97090784599966761c6b0f58a306", "extensions_unittests": "08f18bda00685369f14ef10c09c4ba17a50ff49e", "filesystem_service_unittests": "a9ef789d8dd37cfbd8411ba809532ff8ee7e191d", "gcm_unit_tests": "418002c5bebacc29332bdaf77ac7978652b0f936", "gcp_unittests": "35a2a2a1eeb7a5f8897fb3fdcd974c3e035252ff", "gfx_unittests": "06a1c3ffd54815c5c0a088ed618b4ce144a397db", "gin_unittests": "898e35d4c3dc7771dbc46ce0879ed0824e9f4d87", "google_apis_unittests": "c55bbb5c98f581d6009e45415d71495a5fe27302", "gpu_unittests": "cdae791be8dd04549bb7f84ad38aeb938e0d7e09", "headless_browsertests": "25f70da1279f9eeac282c895f544ab2c6d93df54", "headless_unittests": "a669b661ea94b49669e32879c680046027c180a8", "install_static_unittests": "d96edf4c3f8321f3efcd67ddf28e659532827ac5", "installer_util_unittests": "61a1feb5c0fe40004f47faa9c15b01a5220ff12d", "interactive_ui_tests": "0ac5714d83aec93a8868d91cb9e79a88ce12f95c", "ipc_tests": "4dd01f5afcea188d73ce43b5e30e604724842a19", "jingle_unittests": "7de5530abadb237472e1bb2445c93ef56f881e07", "latency_unittests": "88e2d01291fe808291ec75591e7503baf76461b8", "leveldb_service_unittests": "188f17df2521056ceda98505af127c4e056d2d09", "libjingle_xmpp_unittests": "e09b154e1e83e29d07d87d5ecfb1ef9ffe14edde", "media_blink_unittests": "cab7aa7d04af3acba52e965d76657f15fd273fb5", "media_service_unittests": "886248d7c2629f7c76fc2e64519649660becdb5c", "media_unittests": "cfc6595c48232464c42fb804425d52a3d8cf3f83", "message_center_unittests": "7fd9efd586955bbc518377537b74fd54e779cf33", "metrics_python_tests": "e752064845c425b315bbbf6f4006b9307b4aa2dc", "midi_unittests": "9355e93471872e6f23a1bde284c12c563ffea72e", "mojo_core_unittests": "426abd4e8e20868b3965cc8bc139123d03b91ad2", "mojo_unittests": "3dbd7cb9fea5c48b9af14ab99b1b658507317948", "nacl_loader_unittests": "d08cf7a8af42324b51337bc5c7fea9fbae363394", "native_theme_unittests": "d6fc9158d93b45d5a2bed199827cd9fb39849d7a", "net_unittests": "dd1b98f60816cf5325648438bfefe472074e2074", "pdf_unittests": "623e75bfe2a3d5fac1c8e74755771c7044a86db0", "ppapi_unittests": "fa48aa22f92ce3b7266a05c9b80832acb85d1e8f", "printing_unittests": "e7ffcddabdd898d3687108f73490509a0f24a59f", "remoting_unittests": "c0cae4aacc89bb58e8ac4b4b458976478279e571", "sbox_integration_tests": "8a858ddcdaaeab162c56a0426148696f2e9f0167", "sbox_unittests": "c06fbc37f678a84009cfe1fbe9f8cd6cbe2bb179", "sbox_validation_tests": "ea31b6d560afdf4b9f1751ab966087cee3406105", "service_manager_unittests": "0faa028d840e32580e668a07bd864528bcb8f568", "services_unittests": "db24108f8b1039d5c9810da66027a0e61e630e08", "setup_unittests": "7c7a1713cff233bdfbe27ee9a8ddc7de1214cd2f", "shell_dialogs_unittests": "015c80f1b41ea6debc353fae84944456fa883990", "skia_unittests": "27526d717a2636fbbeb1d6d7feebb6fb00d9bf9e", "snapshot_unittests": "ecc5c48c493c7b946c504434d01225465013f020", "sql_unittests": "be8e0c11c00c114c39f1954655e3704253055f12", "storage_unittests": "65ab77107192f19321a8af004ec7198b3d648d96", "sync_integration_tests": "78c88a530cdfffc051acb106e49fe87de9d07344", "telemetry_gpu_unittests": "5ff733d11786f3664a45d00d28cf29bd90398e8e", "telemetry_perf_unittests": "da6aeac2e6c67b9945849bed927dbed0f5ba3466", "telemetry_unittests": "50be350cbb033df25a13f677937c0515428b974f", "traffic_annotation_auditor_unittests": "914a914981426006377fc5df0d8c0b32618d8db5", "ui_base_unittests": "121927a6afaeda469cf8e89ea955474529db68e3", "ui_touch_selection_unittests": "424a6429d188a7e1cedea04fb3b3b8db0bf29c9f", "unit_tests": "dfb30edb60a1ef6b56d637592c64f591dee3dc95", "url_unittests": "e6f2b40a948505ecd681dca9d4dc6ec9118c0ac1", "views_perftests": "0594b5b3b687dfe4084baea7c2a1f87bc56de2ec", "views_unittests": "4bd1902d579e55dfcf20e1ca4f847603c88be5e2", "viz_unittests": "2ebce5d577d4324bd79474a7c38aee37ff6036bc", "vr_common_unittests": "d553c7b03fb616a10758338e60368e6d04320d5f", "vr_pixeltests": "98c7d94a2d3dc75f57e93a3b39c77877af996f0e", "webkit_layout_tests_exparchive": "e2261cd15b10a06f1cb3389e543e539304f38cc3", "webkit_python_tests": "19aead4340e1f30b1966dcc76ca15e666b69487c", "webkit_unit_tests": "1a9e08eb762118d14af31153b552687f5ce8fb7f", "wm_unittests": "f67522465da25ad838eb385bbb5001d10d30890c", "wtf_unittests": "bb221aad035f2901fa6a9038eb8f42586d2e9a0c", "zucchini_unittests": "6d2b45bf6840f9c3e8bd920f8c34edc3ba25ab10"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "8c814268e0605b5134669e52db357d13aadd08fb" bot_update
got_revision_cp "refs/heads/master@{#606782}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "c465c5ea7f6c2b562a1b537adf46673fea7a8b8c" bot_update
got_v8_revision_cp "refs/heads/7.2.283@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. 3su6n15k.default@developer.gserviceaccount.com (3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com)
  2. Balazs Engedy (engedyohnoyoudont@chromium.org)
  3. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  4. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  5. Patrik Höglund (phoglundohnoyoudont@chromium.org)
  6. Peng Huang (penghuangohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 10:56:17 UTC
Start Friday, 09-Nov-18 10:57:59 UTC
End Friday, 09-Nov-18 11:25:51 UTC
Pending 1 mins 41 secs
Execution 27 mins 52 secs

All Changes:

  1. Automated Commit: LKGM 11244.0.0 for chromeos.

    Changed by 3su6n15k.default@developer.gserviceaccount.com - 3su6n15k.defaultohnoyoudont@developer.gserviceaccount.com
    Changed at Friday, 09-Nov-18 10:24:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c814268e0605b5134669e52db357d13aadd08fb

    Comments

    Automated Commit: LKGM 11244.0.0 for chromeos.
    
    BUG=762641
    TBR=rkc@chromium.org
    
    Change-Id: Ic280acd363864f15e43d89b7ee466b554fc2e614
    Reviewed-on: https://chromium-review.googlesource.com/c/1328841
    Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606782}

    Changed files

    • chromeos/CHROMEOS_LKGM
  2. Prevent use-after-free in SiteEngagementService.

    Changed by Balazs Engedy - engedyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:12:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70115b4df17a675652ef65521ba6ddf81f59037

    Comments

    Prevent use-after-free in SiteEngagementService.
    
    The profile and its KeyedServices are normally destroyed before the
    TaskScheduler shuts down background threads, so the background task to
    record site engagement metrics needs to avoid using any members of
    SiteEngagementService
    
    Bug: 900022
    Change-Id: Ibdebbd5a64d59fad29b7715be3557eeed411d741
    Reviewed-on: https://chromium-review.googlesource.com/c/1326441
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606781}

    Changed files

    • chrome/browser/engagement/site_engagement_service.cc
  3. Do style propagation to generated content in LayoutObject.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:07:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a944866662c9cd3841c2cc1c8e8335ff6fd838e4

    Comments

    Do style propagation to generated content in LayoutObject.
    
    It belongs with the other anonymous LayoutObject propagation code.
    There are still two loops for pseudo elements where we propagate style
    to anonymous table boxes like before but propagate style from the
    pseudo element to the generated content directly, skipping other
    anonymous boxes, in a separate loop. This is just keeping the same
    functionality for generated content without trying to propagate style
    through others anonymous boxes. Left a TODO for that.
    
    Change-Id: I3c38bc9d831b8a767fd601d47e4db0f81923ba47
    Reviewed-on: https://chromium-review.googlesource.com/c/1328041
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606780}

    Changed files

    • third_party/blink/renderer/core/dom/pseudo_element.cc
    • third_party/blink/renderer/core/dom/pseudo_element.h
    • third_party/blink/renderer/core/layout/layout_object.cc
  4. Revert "Route SSLPrivateKey provider names into NetLog."

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:06:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe2afddb677e9cf62b0f24c9dd2b176156d34a7

    Comments

    Revert "Route SSLPrivateKey provider names into NetLog."
    
    This reverts commit db889e10709b97c8e0c872e167cef871147afcdb.
    
    Reason for revert: Speculative revert: A bunch of SSL related tests failing on Mac: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36146
    
    Original change's description:
    > Route SSLPrivateKey provider names into NetLog.
    > 
    > Improve debugging in the future so we don't have to keep asking "are you
    > using a smartcard? which?".
    > 
    > Bug: none
    > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > Change-Id: Ifbaf6f5aa0aa73dcd19be0ccc0046c2c2c069319
    > Reviewed-on: https://chromium-review.googlesource.com/c/1292509
    > Commit-Queue: David Benjamin <davidben@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606700}
    
    TBR=rsleevi@chromium.org,kinuko@chromium.org,davidben@chromium.org,emaxx@chromium.org
    
    Change-Id: Icb8db36c96ba199e0857296cd21fa9d3e8826c90
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/c/1328882
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606779}

    Changed files

    • chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
    • chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc
    • content/browser/network_service_client.cc
    • net/android/java/src/org/chromium/net/AndroidKeyStore.java
    • net/android/keystore.cc
    • net/android/keystore.h
    • net/log/net_log_event_type_list.h
    • net/socket/ssl_client_socket_impl.cc
    • net/ssl/ssl_client_auth_cache_unittest.cc
    • net/ssl/ssl_platform_key_android.cc
    • net/ssl/ssl_platform_key_mac.cc
    • net/ssl/ssl_platform_key_nss.cc
    • net/ssl/ssl_platform_key_win.cc
    • net/ssl/ssl_private_key.h
    • net/ssl/test_ssl_private_key.cc
    • net/ssl/threaded_ssl_private_key.cc
    • net/ssl/threaded_ssl_private_key.h
    • net/url_request/url_request_unittest.cc
    • services/network/public/mojom/network_service.mojom
    • services/network/url_loader.cc
    • services/network/url_loader.h
    • services/network/url_loader_unittest.cc
  5. Revert "Enable unified garbage collections part two"

    Changed by Patrik Höglund - phoglundohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:03:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9453dfbffd2000b3eafab2a59169da733d8cf08a

    Comments

    Revert "Enable unified garbage collections part two"
    
    This reverts commit 79ffe683c7cc22ab3478b119adcc9b49584bd9e2.
    
    Reason for revert: Speculative revert: lots of garbage-collection related failures on WebKit Linux Trusty ASAN (see https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/17912)
    
    Original change's description:
    > Enable unified garbage collections part two
    > 
    > This flag overrides the default Blink value for content layer.
    > 
    > Sheriffs: This is a dry-run of the feature and will be reverted after
    > cycling through the waterfall and performance bots.
    > 
    > Tbr: jochen@chromium.org, lfg@chromium.org
    > Bug: 843903
    > Change-Id: Ie362301e4874198eb775346d051bf8267837aaf8
    > Reviewed-on: https://chromium-review.googlesource.com/c/1320970
    > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Reviewed-by: Hannes Payer <hpayer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#606446}
    
    TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,jochen@chromium.org,lfg@chromium.org
    
    Change-Id: I189aca41c8f8ba11c358a4c15bc7f56591e38196
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 843903
    Reviewed-on: https://chromium-review.googlesource.com/c/1328902
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Commit-Queue: Patrik Höglund <phoglund@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606778}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • content/public/common/content_features.cc
    • third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-rule-children-wrappers-expected.txt
    • third_party/WebKit/LayoutTests/fast/dom/gc-9-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-iterator-result-should-mark-its-nodeset-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-other-nodeset-result-should-mark-its-nodeset-expected.txt
    • third_party/WebKit/LayoutTests/fast/xpath/xpath-snapshot-result-should-mark-its-nodeset-expected.txt
  6. Move context state related methods out of DecoderContext

    Changed by Peng Huang - penghuangohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 10:03:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bea0d6b3c467e05183fb88d06a829a6d7e7d136a

    Comments

    Move context state related methods out of DecoderContext
    
    This CL adds a new GLContextVirtualDelegate interface to contain all
    context state related methods from DecoderContext. After this one, I am
    going to implement GLContextVirtualDelegate in RasterDecoderContextState
    and only create one GLContextVirtual for all raster decoder and display
    compositor.
    
    Bug: 900941, 902904
    Change-Id: I10d80bea8531885c449a2e676ce0552e9363b34c
    Reviewed-on: https://chromium-review.googlesource.com/c/1312338
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Peng Huang <penghuang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606777}

    Changed files

    • gpu/command_buffer/service/BUILD.gn
    • gpu/command_buffer/service/decoder_context.h
    • gpu/command_buffer/service/gl_context_virtual.cc
    • gpu/command_buffer/service/gl_context_virtual.h
    • gpu/command_buffer/service/gl_context_virtual_delegate.h
    • gpu/command_buffer/service/gl_state_restorer_impl.cc
    • gpu/command_buffer/service/gl_state_restorer_impl.h
    • gpu/command_buffer/service/raster_decoder.cc
    • gpu/command_buffer/service/raster_decoder_context_state.cc
    • gpu/command_buffer/service/raster_decoder_context_state.h
    • gpu/command_buffer/service/wrapped_sk_image.cc