Builder WebKit Linux Trusty MSAN Build 12194

Overview

Results:

Success

Trigger Info:

Project	chromium
Revision	f1639a837a7242ab03ff36399277bd47ccaf1d4a
Got Revision	f1639a837a7242ab03ff36399277bd47ccaf1d4a

Execution:

Source: Task 426f769ebf0ffa10
Bot: gce-trusty-e833d7b0-us-west1-c-wv35
Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

( 315 ms ) setup_build
running recipe: "chromium"
- stdout
- run_recipe
( 223 ms ) report builders

running builder/tester 'WebKit Linux Trusty MSAN' on master 'chromium.memory'
- stdout
- bots.json
( 50 secs ) bot_update
[230GB/295GB used (77%)]
- stdout
- json.output
( 152 ms ) ensure_goma
- - no logs -
1. ( 152 ms ) ensure_installed
  - stdout
  - json.output
( 560 ms ) swarming.py --version
0.14
- stdout
( 10 secs ) gclient runhooks
- stdout
( 2 secs ) get compile targets for scripts
- stdout
- json.output
( 921 ms ) read test spec (chromium.memory.json)
path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
- stdout
- json.output
( 401 ms ) clean isolated files
- stdout
( 479 ms ) lookup GN args

is_component_build = false
is_debug = false
is_msan = true
msan_track_origins = 2
strip_absolute_paths_from_debug_symbols = true
use_goma = true
use_prebuilt_instrumented_libraries = true
goma_dir = "/b/s/w/ir/cache/goma/client"
- stdout
( 11 secs ) generate_build_files
- stdout
- swarming-targets-file.txt
( 573 ms ) clang_revision
- stdout
- json.output
( 8 secs ) preprocess_for_goma
- - no logs -
1. ( 435 ms ) goma cache directory
  - stdout
2. ( 6 secs ) start_goma
  - stdout
  - cloudtail
3. ( 1 secs ) start cloudtail
  - stdout
( 36 secs ) compile
- stdout
( 3 secs ) compile confirm no-op
- stdout
( 13 secs ) postprocess_for_goma
- - no logs -
1. ( 490 ms ) goma_jsonstatus
  - stdout
  - json.output
2. ( 480 ms ) goma_stat
  - stdout
3. ( 485 ms ) stop_goma
  - stdout
4. ( 10 secs ) upload_log
5. ( 1 secs ) stop cloudtail
  - stdout
( 32 secs ) isolate webkit_layout_tests_exparchive
- stdout
- json.output
( 435 ms ) find isolated tests
- stdout
- json.output
( 13 secs ) test_pre_run
- - no logs -
1. ( 13 secs ) [trigger] webkit_layout_tests
  Run on OS: 'Ubuntu-14.04'
  - stdout
  - json.output
  - shard #0
  - shard #1
  - shard #2
  - shard #3
  - shard #4
  - shard #5
  - shard #6
  - shard #7
  - shard #8
  - shard #9
  - shard #10
  - shard #11
  - shard #12
  - shard #13
  - shard #14
  - shard #15
  - shard #16
  - shard #17
  - shard #18
  - shard #19
( 128 ms ) ensure swarming
- - no logs -
1. ( 128 ms ) ensure_installed
  - stdout
  - json.output
( 48 mins 50 secs ) webkit_layout_tests
Run on OS: 'Ubuntu-14.04'
Max shard duration: 0:47:35.340764 (shard #4)
Min shard duration: 0:32:36.338386 (shard #3)
Total tests: 91331
* Passed: 83429 (83383 expected, 46 unexpected)
* Skipped: 7590 (7590 expected, 0 unexpected)
* Failed: 258 (258 expected, 0 unexpected)
* Flaky: 54 (54 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (2175.4 sec)
- shard #1 isolated out
- shard #1 (2597.7 sec)
- shard #2 isolated out
- shard #2 (2285.0 sec)
- shard #3 isolated out
- shard #3 (1878.3 sec)
- shard #4 isolated out
- shard #4 (2768.5 sec)
- shard #5 isolated out
- shard #5 (2646.5 sec)
- shard #6 isolated out
- shard #6 (2430.7 sec)
- shard #7 isolated out
- shard #7 (2169.4 sec)
- shard #8 isolated out
- shard #8 (2274.2 sec)
- shard #9 isolated out
- shard #9 (2796.0 sec)
- shard #10 isolated out
- shard #10 (2104.7 sec)
- shard #11 isolated out
- shard #11 (2377.5 sec)
- shard #12 isolated out
- shard #12 (2573.2 sec)
- shard #13 isolated out
- shard #13 (2713.2 sec)
- shard #14 isolated out
- shard #14 (2273.5 sec)
- shard #15 isolated out
- shard #15 (2209.5 sec)
- shard #16 isolated out
- shard #16 (2404.9 sec)
- shard #17 isolated out
- shard #17 (2546.0 sec)
- shard #18 isolated out
- shard #18 (2214.0 sec)
- shard #19 isolated out
- shard #19 (2671.3 sec)
( 3 mins 31 secs ) Upload to test-results [webkit_layout_tests]
- stdout
( 8 secs ) archive results for webkit_layout_tests
- stdout
- layout_test_results
- (zip)
( 529 ms ) Tests statistics

Stats
Total shards: 20
Total runtime: 13:21:49.506533
- stdout
- detailed stats
( 0 ) recipe result
- result

Build Properties:

Name	Value	Source
$build/goma	{"jobs": 500}	setup_build
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": false, "is_luci": true}	setup_build
bot_id	"gce-trusty-e833d7b0-us-west1-c-wv35"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547641885843872, "id": "8924173577868546672", "project": "chromium", "tags": ["builder:WebKit Linux Trusty MSAN", "buildset:commit/git/f1639a837a7242ab03ff36399277bd47ccaf1d4a", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f1639a837a7242ab03ff36399277bd47ccaf1d4a", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089603640043288560", "scheduler_job_id:chromium/WebKit Linux Trusty MSAN", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"WebKit Linux Trusty MSAN"	setup_build
buildnumber	12194	setup_build
mastername	"chromium.memory"	setup_build
path_config	"generic"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"f1639a837a7242ab03ff36399277bd47ccaf1d4a"	setup_build
got_angle_revision	"ab2bfa814ceefdcbe24483b3a12ba525345d486c"	bot_update
got_buildtools_revision	"40194ab03962d8183b2796fa58a39ec8a9e83a41"	bot_update
got_dawn_revision	"acd8b7d937cc4dcc81856377863f2d56af7037b5"	bot_update
got_nacl_revision	"1ea07c56ac9b57c30eb784ab2af582af0cdd4b08"	bot_update
got_revision	"f1639a837a7242ab03ff36399277bd47ccaf1d4a"	bot_update
got_revision_cp	"refs/heads/master@{#623205}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"871f913bad24b4ead79468f431a1ae8326d9d27b"	bot_update
got_v8_revision_cp	"refs/heads/7.3.412@{#1}"	bot_update
got_webrtc_revision	"ccc1b57e32bd99e4f220a3db0e540713f4349ad9"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26266}"	bot_update
got_clang_revision	"350768-2"	clang_revision
isolate_server	"https://isolateserver.appspot.com"	isolate webkit_layout_tests_exparchive
swarm_hashes_refs/heads/master(at){#623205}_without_patch	{"webkit_layout_tests_exparchive": "8a3c8f288b10686ebd4304286680ae2a7aac0259"}	isolate webkit_layout_tests_exparchive
swarm_hashes	{"webkit_layout_tests_exparchive": "8a3c8f288b10686ebd4304286680ae2a7aac0259"}	find isolated tests

Blamelist:

Mike Reed (reedohnoyoudont@google.com)
Roman Aleksandrov (raleksandrovohnoyoudont@google.com)
Morten Stenshorne (mstenshoohnoyoudont@chromium.org)
David Jean (djeanohnoyoudont@google.com)
Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
Dominik Röttsches (drottohnoyoudont@chromium.org)
Fergal Daly (fergalohnoyoudont@chromium.org)
dstockwell (dstockwellohnoyoudont@google.com)

Timing:

Create	Wednesday, 16-Jan-19 12:31:25 UTC
Start	Wednesday, 16-Jan-19 12:31:28 UTC
End	Wednesday, 16-Jan-19 13:27:24 UTC
Pending	2 secs
Execution	55 mins 55 secs

All Changes:

drawText is deprecated, use drawSimpleText or drawTextBlob

Changed by	Mike Reed - reedohnoyoudont@google.com
Changed at	Wednesday, 16-Jan-19 12:19:27 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	f1639a837a7242ab03ff36399277bd47ccaf1d4a

Comments

drawText is deprecated, use drawSimpleText or drawTextBlob

Bug: skia:2664
Change-Id: Iaf60f02455f530031fecfefc1d022b448643302a
Reviewed-on: https://chromium-review.googlesource.com/c/1413635
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623205}

Changed files

media/capture/video/fake_video_capture_device.cc

Fix sleeping lag in Chrome/ChromeOS relaunch-to-update timer

Changed by	Roman Aleksandrov - raleksandrovohnoyoudont@google.com
Changed at	Wednesday, 16-Jan-19 12:15:32 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	7ed8e104acef9a74047e20fccbc0c53602e7958e

Comments

Fix sleeping lag in Chrome/ChromeOS relaunch-to-update timer

Migrate RelaunchNotificationController from using OneShotTimer to WallClockTimer
which based on real time. Refactor all surroundings to use base::Time instead of
base::TimeTicks as well.

Bug: 906689
Change-Id: If65cd37ac8d7e1848a2a6c0dfa1f7a50b6aeca0f
Reviewed-on: https://chromium-review.googlesource.com/c/1397633
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623204}

Changed files

chrome/browser/ui/toolbar/app_menu_icon_controller_unittest.cc
chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.cc
chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller.h
chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_chromeos.cc
chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_chromeos.h
chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_desktop.cc
chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_platform_impl_desktop.h
chrome/browser/ui/views/relaunch_notification/relaunch_notification_controller_unittest.cc
chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.cc
chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view.h
chrome/browser/ui/views/relaunch_notification/relaunch_recommended_bubble_view_browsertest.cc
chrome/browser/ui/views/relaunch_notification/relaunch_recommended_timer.cc
chrome/browser/ui/views/relaunch_notification/relaunch_recommended_timer.h
chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.cc
chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view.h
chrome/browser/ui/views/relaunch_notification/relaunch_required_dialog_view_browsertest.cc
chrome/browser/ui/views/relaunch_notification/relaunch_required_timer.cc
chrome/browser/ui/views/relaunch_notification/relaunch_required_timer.h
chrome/browser/ui/views/relaunch_notification/wall_clock_timer.cc
chrome/browser/ui/views/relaunch_notification/wall_clock_timer.h
chrome/browser/ui/views/relaunch_notification/wall_clock_timer_unittest.cc
chrome/browser/upgrade_detector/upgrade_detector.cc
chrome/browser/upgrade_detector/upgrade_detector.h
chrome/browser/upgrade_detector/upgrade_detector_chromeos.cc
chrome/browser/upgrade_detector/upgrade_detector_chromeos.h
chrome/browser/upgrade_detector/upgrade_detector_impl.cc
chrome/browser/upgrade_detector/upgrade_detector_impl.h
chrome/browser/upgrade_detector/upgrade_detector_impl_unittest.cc

Perf tests changing available size for fit-content child.

Changed by	Morten Stenshorne - mstenshoohnoyoudont@chromium.org
Changed at	Wednesday, 16-Jan-19 12:14:08 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	b658d76d4bb05bc93cba0281c3607393177f0f4e

Comments

Perf tests changing available size for fit-content child.

Change-Id: I7098bd765b0b1ea6e272c4472b0598d1da95dbe2
Reviewed-on: https://chromium-review.googlesource.com/c/1411599
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623203}

Changed files

third_party/blink/perf_tests/layout/fit-content-change-available-size-blocks.html
third_party/blink/perf_tests/layout/fit-content-change-available-size-text.html

[ios] Add js injection for password generation

Changed by	David Jean - djeanohnoyoudont@google.com
Changed at	Wednesday, 16-Jan-19 12:10:50 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	9e0c5379d6809b2caf0a08e71834ff589bd7d295

Comments

[ios] Add js injection for password generation

Bug: 886583

Change-Id: I557d7204102f4a28cfb1f6d91a37df50e117e3bd
Reviewed-on: https://chromium-review.googlesource.com/c/1379898
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623202}

Changed files

components/autofill/core/common/password_form_generation_data.h
components/password_manager/core/browser/new_password_form_manager.cc
components/password_manager/core/browser/new_password_form_manager_unittest.cc
components/password_manager/ios/js_password_manager.h
components/password_manager/ios/js_password_manager.mm
components/password_manager/ios/password_form_helper.h
components/password_manager/ios/password_form_helper.mm
components/password_manager/ios/resources/password_controller.js
ios/chrome/browser/passwords/password_controller.h
ios/chrome/browser/passwords/password_controller.mm
ios/chrome/browser/passwords/password_controller_js_unittest.mm
ios/chrome/browser/passwords/password_tab_helper.h
ios/chrome/browser/passwords/password_tab_helper.mm
ios/chrome/browser/ui/autofill/manual_fill/manual_fill_injection_handler.mm

Import wpt@344e01763afe4e707286188ce6c1b4584cb1b864

Changed by	Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
Changed at	Wednesday, 16-Jan-19 11:41:41 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	8fac1ece71d743450a3543092a24c156e2d9d414

Comments

Import wpt@344e01763afe4e707286188ce6c1b4584cb1b864

Using wpt-import in Chromium 893c068d35a42afd462e3caebc35ef3814af99f8.
With Chromium commits locally applied on WPT:
1c633d483b "Snap the snapped_dest_rect for backgrounds"
1061788dd2 "Reland "Add quota usage details tests for all other storage backends.""
bcd3934d05 "Add a test for ServiceWorker and AppCache interaction with claim()"
4836c563b1 "Change web platform test with mouse inputs under "pinterevents/""
33a49f0de5 "[WebLocks]: Modifying weblocks algos to be O(1)"
66a94294e7 "Verify getContributingSources() does not return any CSRCs."
8e4e5d7297 "Fix preload tests failing on wpt.fyi dashboard"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: I4f69c20aac42b9131c9886f8f2bef1e7f93b0536
Reviewed-on: https://chromium-review.googlesource.com/c/1414870
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623201}

Changed files

third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
third_party/blink/web_tests/external/wpt/css/css-device-adapt/documentElement-clientWidth-on-minimum-scale-size.tentative.html

Roll src-internal f2c8fe4e24b3..8b326e1c2f3d (1 commits)

Changed by	chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
Changed at	Wednesday, 16-Jan-19 11:37:49 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	d38340b89f86c31c52b26924675466e717d7e1ed

Comments

Roll src-internal f2c8fe4e24b3..8b326e1c2f3d (1 commits)

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2c8fe4e24b3..8b326e1c2f3d


Created with:
  gclient setdep -r src-internal@8b326e1c2f3d

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ie1cf5ccd165b57597acebc1db00091fffbc07d52
Reviewed-on: https://chromium-review.googlesource.com/c/1414699
Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623200}

Changed files

DEPS

Reland "Enable unique font matching matching by default"

Changed by	Dominik Röttsches - drottohnoyoudont@chromium.org
Changed at	Wednesday, 16-Jan-19 11:36:33 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	1d366d59cf85b3013d0e3f4a9ee9edb98b99a49f

Comments

Reland "Enable unique font matching matching by default"

This reverts commit f6c717eb8b60f311b6357b3ddace4c79b1a2e64e.

Reason for revert: Crash has been addressed in 
https://chromium-review.googlesource.com/c/chromium/src/+/1414852

Original change's description:
> Revert "Enable unique font matching matching by default"
> 
> This reverts commit 2e8e7c130cbb432732e973fd8c266a0608727b5f.
> 
> Reason for revert: Crashes observed in Windows Canary
> 
> Bug: 922183
> 
> Original change's description:
> > Enable unique font matching matching by default
> > 
> > Now that all implementations for Android, Windows, Linux/CrOS and Mac
> > are in place, enable the feature globally. Chrome will match fonts
> > references in @font-face { src: local(<font-name>) } correctly by
> > postscript name or full font name. This addresses a long standing,
> > highly starred font matching issue in Chrome.
> > 
> > Bug: 828317, 627143, 921029
> > Change-Id: I348855fdca817a4cd279f4d938e6d5ffe91ee004
> > Reviewed-on: https://chromium-review.googlesource.com/c/1400695
> > Commit-Queue: Dominik Röttsches <drott@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Reviewed-by: Emil A Eklund <eae@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622456}
> 
> TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 828317, 627143, 921029
> Change-Id: I6a89f36923abb7d87de712c9ac0852da06a66d37
> Reviewed-on: https://chromium-review.googlesource.com/c/1412824
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622898}

TBR=avi@chromium.org,eae@chromium.org,drott@chromium.org

Change-Id: I915e1bb20ee51325befa5ef7eab07f78eaa8c974
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 922183, 828317, 627143, 921029, 922183
Reviewed-on: https://chromium-review.googlesource.com/c/1413603
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623199}

Changed files

content/public/common/content_features.cc
third_party/blink/web_tests/NeverFixTests
third_party/blink/web_tests/fast/css/font-face-character-fallback.html
third_party/blink/web_tests/fast/css/font-face-descending-unicode-range.html
third_party/blink/web_tests/fast/css/font-face-download-error.html
third_party/blink/web_tests/fast/css/font-face-in-media-rule.html
third_party/blink/web_tests/fast/css/font-face-multiple-ranges-for-unicode-range.html
third_party/blink/web_tests/fast/css/font-face-unicode-range-monospace.html
third_party/blink/web_tests/fast/css/fontfaceset-add-remove.html
third_party/blink/web_tests/fast/css/fontfaceset-download-error.html
third_party/blink/web_tests/fast/css/fontfaceset-multiple-faces.html
third_party/blink/web_tests/fast/forms/select-popup/popup-menu-font-face.html
third_party/blink/web_tests/fast/inline/vertical-align-with-fallback-fonts.html
third_party/blink/web_tests/fast/text/capitalize-boundaries.html
third_party/blink/web_tests/fast/text/unique-vs-family-match.html
third_party/blink/web_tests/inspector-protocol/layout-fonts/unicode-range-order.js
third_party/blink/web_tests/platform/mac-mac10.10/fast/text/unique-vs-family-match-expected.png
third_party/blink/web_tests/platform/mac-mac10.12/fast/text/unique-vs-family-match-expected.png
third_party/blink/web_tests/platform/mac/fast/text/unique-vs-family-match-expected.png

[CSS] Support ::part with ::before/::after

Changed by	Fergal Daly - fergalohnoyoudont@chromium.org
Changed at	Wednesday, 16-Jan-19 11:32:36 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	58c317ab643531e1bfff4d58007310cb9faba0cf

Comments

[CSS] Support ::part with ::before/::after

This enables it for ::before, ::after and ::placeholder and adds a
test for all 3 but for reasons I haven't dug into yet, ::placeholder
doesn't work with ::part, so this includes a failing expectation.

Bug: 921908
Change-Id: I60a859ede98f8284cb3a1e44c81a33230b490239
Reviewed-on: https://chromium-review.googlesource.com/c/1414536
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623198}

Changed files

third_party/blink/renderer/core/css/parser/css_selector_parser.cc
third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding-expected.txt
third_party/blink/web_tests/external/wpt/css/css-shadow-parts/interaction-with-tree-abiding.html

pdf: Use chrome.fileSystem.chooseFile when saving PDF from extension

Changed by	dstockwell - dstockwellohnoyoudont@google.com
Changed at	Wednesday, 16-Jan-19 11:31:19 UTC
Repository	https://chromium.googlesource.com/chromium/src
Branch
Revision	dc03dd49f4a78c65985e75796edaafc7719a506d

Comments

pdf: Use chrome.fileSystem.chooseFile when saving PDF from extension

This matches the save behavior of the plugin, where a file picker
is opened rather than the file being immediately downloaded.

Bug: 61248
Change-Id: I2481ffcb8fe1ba346acadb8106d786ee09fc8a94
Reviewed-on: https://chromium-review.googlesource.com/c/1356161
Commit-Queue: dstockwell <dstockwell@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623197}

Changed files

chrome/browser/resources/pdf/manifest.json
chrome/browser/resources/pdf/pdf_viewer.js
extensions/common/api/_permission_features.json