Builder ToTMac
Build 15324
Results:
Experimental Failure gclient runhooks
Trigger Info:
Project | chromium |
Revision | 067c12ee95a594db2c65b24c21f26231c4356ef4 |
Got Revision | 067c12ee95a594db2c65b24c21f26231c4356ef4 |
Execution:
- Source: Task 42865531fc28d810
- Bot: build285-m9
- Recipe: chromium
Steps and Logfiles:
Show:Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": true, "is_luci": true} | setup_build |
bot_id | "build285-m9" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1548025571114529, "id": "8923771254702124896", "project": "chromium", "tags": ["builder:ToTMac", "buildset:commit/git/067c12ee95a594db2c65b24c21f26231c4356ef4", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/067c12ee95a594db2c65b24c21f26231c4356ef4", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089201317012014000", "scheduler_job_id:chromium/ToTMac", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "ToTMac" | setup_build |
buildnumber | 15324 | setup_build |
mastername | "chromium.clang" | setup_build |
path_config | "generic" | setup_build |
perf_dashboard_machine_group | "ChromiumClang" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "067c12ee95a594db2c65b24c21f26231c4356ef4" | setup_build |
got_angle_revision | "7403dd2cd3764fe96660fe09892e764e9ae1dbca" | bot_update |
got_buildtools_revision | "2f02e1f363b1af2715536f38e239853f04ec1497" | bot_update |
got_dawn_revision | "850c0d9aec6bd3f63cb58ff1838380efc112279a" | bot_update |
got_nacl_revision | "ff15c51d20785fa51c0ef03ccb480b87299acbeb" | bot_update |
got_revision | "067c12ee95a594db2c65b24c21f26231c4356ef4" | bot_update |
got_revision_cp | "refs/heads/master@{#624496}" | bot_update |
got_swarming_client_revision | "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" | bot_update |
got_v8_revision | "49d3755f33eb8f2e44b2da7ba21556429d6b2493" | bot_update |
got_v8_revision_cp | "refs/heads/7.3.451@{#1}" | bot_update |
got_webrtc_revision | "74ba99062c48b278675cfe52643719202296fddc" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#26298}" | bot_update |
Blamelist:
- David Bokan (bokanohnoyoudont@chromium.org)
Timing:
Create | Sunday, 20-Jan-19 23:06:11 UTC |
Start | Sunday, 20-Jan-19 23:06:42 UTC |
End | Sunday, 20-Jan-19 23:11:38 UTC |
Pending | 31 secs |
Execution | 4 mins 55 secs |
All Changes:
-
[Reland] Synthetic gestures wait on renderer ACK.
Changed by David Bokan - bokanohnoyoudont@chromium.org Changed at Sunday, 20-Jan-19 23:05:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 067c12ee95a594db2c65b24c21f26231c4356ef4 Comments
[Reland] Synthetic gestures wait on renderer ACK. Currently, synthetic gestures invoke the "completed callback" as soon as the final gesture has been dispatched. This causes issues in client code, typically tests, that want to wait until the effects of a gesture are complete before sending further input or checking page state. This CL is the first step in a series of CLs to make this completion callback reliable. We add a new API in the renderer that resolves the completion callback once the input has been fully processed by the renderer. For now, this method just ACKs immediately but its implementation will be further fleshed out in a followup CL. Reland Node: This was reverted in https://crrev.com/d3d4d7c7480b4424a8d009194dd14405654843a4 due to causing failures on the LeakDetector bot. The leaks were a result of tests finishing before the synthetic gesture had completed. I've modified these tests (in wpt/pointerevents) to wait until the guesture is completed before finishing the test. TBR=dtapuska@chromium.org,rsesek@chromium.org,avi@chromium.org Bug: 902446 Change-Id: I6a6a517a719616b2536538686fa4d7b980f0b485 Reviewed-on: https://chromium-review.googlesource.com/c/1424219 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#624496}
Changed files
- content/browser/renderer_host/input/input_router.h
- content/browser/renderer_host/input/input_router_impl.cc
- content/browser/renderer_host/input/input_router_impl.h
- content/browser/renderer_host/input/synthetic_gesture.cc
- content/browser/renderer_host/input/synthetic_gesture.h
- content/browser/renderer_host/input/synthetic_gesture_controller.cc
- content/browser/renderer_host/input/synthetic_gesture_controller.h
- content/browser/renderer_host/input/synthetic_gesture_controller_unittest.cc
- content/browser/renderer_host/input/synthetic_gesture_target.h
- content/browser/renderer_host/input/synthetic_gesture_target_base.cc
- content/browser/renderer_host/input/synthetic_gesture_target_base.h
- content/browser/renderer_host/input/synthetic_input_browsertest.cc
- content/browser/renderer_host/input/synthetic_pinch_gesture.cc
- content/browser/renderer_host/input/synthetic_pinch_gesture.h
- content/browser/renderer_host/input/synthetic_pointer_action.cc
- content/browser/renderer_host/input/synthetic_pointer_action.h
- content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc
- content/browser/renderer_host/input/synthetic_smooth_drag_gesture.cc
- content/browser/renderer_host/input/synthetic_smooth_drag_gesture.h
- content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc
- content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h
- content/browser/renderer_host/input/synthetic_tap_gesture.cc
- content/browser/renderer_host/input/synthetic_tap_gesture.h
- content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.cc
- content/browser/renderer_host/input/synthetic_touchpad_pinch_gesture.h
- content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.cc
- content/browser/renderer_host/input/synthetic_touchscreen_pinch_gesture.h
- content/browser/renderer_host/input/touch_action_browsertest.cc
- content/browser/renderer_host/render_widget_host_impl.cc
- content/browser/renderer_host/render_widget_host_impl.h
- content/browser/renderer_host/render_widget_host_unittest.cc
- content/common/input/input_handler.mojom
- content/renderer/input/widget_input_handler_impl.cc
- content/renderer/input/widget_input_handler_impl.h
- content/renderer/render_widget_unittest.cc
- content/test/BUILD.gn
- content/test/mock_widget_input_handler.cc
- content/test/mock_widget_input_handler.h
- third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html
- third_party/blink/web_tests/external/wpt/pointerevents/pointerevent_setpointercapture_relatedtarget.html