Home | Search | chromium - Builders
Login

Builder ToTLinuxThinLTO Build 1136 Canonical Ubuntu

Results:

Experimental

Trigger Info:

Projectchromium
Revisionf213164d219da210c4c0383d4878c02633599965
Got Revisionf213164d219da210c4c0383d4878c02633599965

Execution:

Steps and Logfiles:

Show:
  1. ( 304 ms ) setup_build
    running recipe: "chromium"
  2. ( 214 ms ) report builders
     
    running builder/tester 'ToTLinuxThinLTO' on master 'chromium.clang'
  3. ( 1 mins 9 secs ) bot_update
    [67GB/590GB used (11%)]
  4. ( 687 ms ) swarming.py --version
    0.14
  5. ( 28 mins 23 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.clang.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.clang.json
  7. ( 472 ms ) lookup GN args
     
    clang_use_chrome_plugins = false
    is_clang = true
    is_component_build = false
    is_debug = false
    llvm_force_head_revision = true
    symbol_level = 1
    use_thin_lto = true
  8. ( 16 secs ) generate_build_files
  9. ( 572 ms ) clang_revision
  10. ( 3 hrs 19 mins ) compile
  11. ( 4 secs ) upload_ninja_log
  12. ( 1 mins 23 secs ) isolate tests
  13. ( 455 ms ) find isolated tests
  14. ( 7 secs ) sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  15. ( 999 ms ) wait for tasks
  16. ( 2 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  17. ( 1 secs ) network_service_extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 33s
  18. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  19. ( 1 secs ) vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  20. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  21. ( 1 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  22. ( 2 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  23. ( 1 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  24. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  25. ( 3 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  26. ( 1 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  27. ( 2 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  28. ( 1 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  29. ( 1 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  30. ( 2 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  31. ( 3 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  32. ( 1 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  33. ( 1 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  34. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  35. ( 1 secs ) headless_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  36. ( 2 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  37. ( 1 secs ) headless_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 49s
  38. ( 2 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  39. ( 2 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  40. ( 1 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  41. ( 1 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  42. ( 2 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  43. ( 2 secs ) network_service_components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  44. ( 2 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  45. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  46. ( 3 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  47. ( 1 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  48. ( 2 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  49. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  50. ( 2 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  51. ( 1 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  52. ( 1 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  53. ( 2 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  54. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  55. ( 2 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  56. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  57. ( 2 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  58. ( 3 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 37s
  59. ( 2 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  60. ( 1 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  61. ( 2 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  62. ( 1 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  63. ( 2 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  64. ( 1 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  65. ( 3 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  66. ( 2 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  67. ( 3 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 53s
  68. ( 2 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  69. ( 2 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  70. ( 8 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:20.821016
  71. ( 2 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  72. ( 3 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 34s
  73. ( 2 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  74. ( 3 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  75. ( 1 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  76. ( 2 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  77. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  78. ( 2 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  79. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  80. ( 2 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  81. ( 1 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  82. ( 1 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  83. ( 1 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 11s
  84. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 5s
  85. ( 1 secs ) gin_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  86. ( 4 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 35s
  87. ( 2 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  88. ( 1 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  89. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  90. ( 2 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  91. ( 2 secs ) vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  92. ( 2 secs ) wait for tasks (2)
  93. ( 2 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:08.966592
  94. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:02:54.389467 (shard #0)
    Min shard duration: 0:02:08.375716 (shard #1)
  95. ( 15 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:03:19.103677
  96. ( 6 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:06:35.373022 (shard #2)
    Min shard duration: 0:05:18.701665 (shard #7)
  97. ( 2 secs ) network_service_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:03:07.076733 (shard #0)
    Min shard duration: 0:02:03.427654 (shard #1)
  98. ( 4 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:02:22.899434 (shard #0)
    Min shard duration: 0:02:06.165280 (shard #1)
  99. ( 6 secs ) network_service_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:04:44.101754 (shard #11)
    Min shard duration: 0:03:52.280759 (shard #4)
  100. ( 2 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:51.215759
  101. ( 5 secs ) network_service_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:04:31.449179 (shard #0)
    Min shard duration: 0:04:16.439140 (shard #1)
  102. ( 2 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 56s
  103. ( 5 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 42s
  104. ( 7 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:13.348595
  105. ( 3 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:06:53.228046
  106. ( 2 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:07:37.359937
  107. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 121
    Total runtime: 2:57:10.070337
     
  108. ( 4 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": true, "is_luci": true} setup_build
bot_id "gce-trusty-32-0258d129-us-west1-c-32j6" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544142781684092, "id": "8927842654511170704", "project": "chromium", "tags": ["builder:ToTLinuxThinLTO", "buildset:commit/git/f213164d219da210c4c0383d4878c02633599965", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f213164d219da210c4c0383d4878c02633599965", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093272716730921792", "scheduler_job_id:chromium/ToTLinuxThinLTO", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ToTLinuxThinLTO" setup_build
buildnumber 1136 setup_build
mastername "chromium.clang" setup_build
path_config "generic" setup_build
perf_dashboard_machine_group "ChromiumClang" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "f213164d219da210c4c0383d4878c02633599965" setup_build
got_angle_revision "9092bdc7a76f8f79d7fba775880fecbd3e729ea4" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "f213164d219da210c4c0383d4878c02633599965" bot_update
got_revision_cp "refs/heads/master@{#614502}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "c5bfa5d3b1a5b015ac01228595f8a3e5643f4868" bot_update
got_v8_revision_cp "refs/heads/7.3.52@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
got_clang_revision "348558" clang_revision
swarm_hashes_refs/heads/master(at){#614502}_without_patch {"accessibility_unittests": "1083bef1a6965c67308d9de07a4ffc9fee598c3b", "angle_unittests": "ef689a0fe2ad64bd8324b7f0f31c3eb9af405dd1", "app_shell_unittests": "92bc71b351fb17e8703c2151f1f1a99cde074d07", "aura_unittests": "43876cc8c500f19e793d5fa1d48701a2da5a831e", "base_unittests": "b05e073f4c9c269011057430813adccd3bf82388", "blink_common_unittests": "65dfbeece72d156b35fa8f80a0ef7d50d6946322", "blink_fuzzer_unittests": "213d965f8e02d99fe88dd68f0f606bc6e119d282", "blink_heap_unittests": "d8797fc1e176097c5529442708ab8677557477e9", "blink_platform_unittests": "f786c2fec90e9fbfe593808ae59157985eb8b532", "boringssl_crypto_tests": "fdc752208df4f7bebb7e8fc8c02031efeade2b6a", "boringssl_ssl_tests": "3251cd07b3a0e0a2ba1d6e362db6de9f054e9d05", "browser_tests": "0d9b3cb5529da5a8162fbdfd2869eb837a06b468", "cacheinvalidation_unittests": "7b2b5ec60b62b50c0d6436f30d21ad46567dd1c9", "capture_unittests": "54a1f9167e05d6914205d8ba868e988c17b05efb", "cast_unittests": "a63aef7c4d8670e1b61ac528304ddddecd04bb0b", "cc_unittests": "e9c9f3557e3da0d077c4ecc5707b755bb5546cab", "chrome_app_unittests": "8697f74c17a0f273b5d2e51c3c1dd315ee39968f", "chromedriver_unittests": "8a585bd9b320948203007db5d465f916d9969d82", "components_browsertests": "829c37ac97f88ff51257496210c96583acff7b01", "components_unittests": "222fd1fd318f4e2ed2a8dc7b7670b3878df4d64a", "compositor_unittests": "02572da3b8ce0653d28adb1c63a47e2faf30eab8", "content_browsertests": "00cf7ab1e5598199f765f28076238eb656301775", "content_unittests": "38f0b509f63df47c9ed7e02172709e5f11154143", "cronet_tests": "5dae1fe485625c200395445e60f1d5c70933cc0b", "cronet_unittests": "448e2f10397b2a70e5b4fcf1ea19e515de147c71", "crypto_unittests": "9e85535a9f8791c496e8443e4db2aed7e50ae431", "dbus_unittests": "0de39172b771df589a166a963498dab2cec9ee66", "device_unittests": "9f3bb2330a5d2c75bfa177b805d298c03ef4eb8f", "display_unittests": "a4d8a6f1414178dbd38959adc807465a104836a7", "events_unittests": "f80e1ae187348a2f8eb1e87f6744941f7e9cfdf0", "extensions_browsertests": "d980903ba9ce7b33da9eaf35c0df87e63f9f2cd4", "extensions_unittests": "89b745827c9b702fcc6b2d989d37513c5996ccf1", "filesystem_service_unittests": "f02a2cc630decf4165da1b67ac01df78b13063a1", "gcm_unit_tests": "8f6f8927a55a853345b18c73f258782d8cad6d96", "gfx_unittests": "3673fd3ade71e0dd537872a7992781f934a13b44", "gin_unittests": "97f01da9bbca0096f67ffb194156274272395c35", "google_apis_unittests": "0631fea3299ca654b7b1ed5f1d18a842b216ddd0", "gpu_unittests": "a7eabb1303732f69949985e7755040154fb66a65", "headless_browsertests": "9cfc63c7fd8c2ed902f747976bea4e0ed0d4cadc", "headless_unittests": "d82f66d349eccba66b8878935567540209f61cd2", "interactive_ui_tests": "dc6e3f4775e2083b4787422932849197f1bacdcd", "ipc_tests": "43330bcddf5a9e21f69615ff027f696570df185b", "jingle_unittests": "8abadea7bc4fd07b81e226b2e6ffa94d2ce853e9", "latency_unittests": "529e499bc0a45660b1a8b8d1c906ece0c0f1f550", "leveldb_service_unittests": "3a570716efa73f10a4ca4d5b5b46c92a6556d5ed", "libjingle_xmpp_unittests": "52367257d4c7e4bac347e83474e507ec62825d9b", "media_blink_unittests": "df7f2063ef20cff22be6f3f3da19badd5a4944e4", "media_service_unittests": "f770e79df49f8a7e536f161bfd64744310e71d28", "media_unittests": "de4779216df5db4c64893ce70fc095903731670d", "message_center_unittests": "66921fe30acaa991043bf58db1f9ccebc9ed4e74", "midi_unittests": "7569c5085d640d27aadf3c2fe03c00a886beb530", "mojo_core_unittests": "0bbed706a804c27155d05084c29b1940186afaa9", "mojo_unittests": "d23a4447eb985c009b1b18f41811490b864ccd8f", "nacl_helper_nonsfi_unittests": "344cf7aa1a0ef1b2537ba1f3a371a22bef6a3580", "nacl_loader_unittests": "c5d70b0822444729fba83bd76dab4e6df3ae1671", "native_theme_unittests": "9e7a468272a7de5330711825baac18fac0c890ef", "net_unittests": "e6a9603355c4cf7c9c15f803280ab53e0dfc66dc", "pdf_unittests": "2e879e317c0edf71013e1b5d1d962e2108a56e9b", "ppapi_unittests": "1e64fc172cf9c809760fe9dbcea5a2a7c661e1eb", "printing_unittests": "a3f37144a67cb8988aa7c391b05a40c1c6eb9896", "remoting_unittests": "b9ff030a990bafcea21ed8bc0169ee05ae858f1f", "sandbox_linux_unittests": "17a449a90fd2e06f26a2ce0142b0bbe2840d9e7b", "service_manager_unittests": "8b7447ea6832762edaddc8152c453537517d32e8", "services_unittests": "39af697ba549740f77f40596f306b0586bdaa9a4", "shell_dialogs_unittests": "c301e38bb9d21bef26236edb69c112fbb3af42c5", "skia_unittests": "5a7bd4a111b61f9c2a640cbcb8da104b387df31e", "snapshot_unittests": "472174ef9d58b5d4fbcc6700a393ae93ec81f9d0", "sql_unittests": "f3b0d30b479b271f7e0923f4e15e151ea9892deb", "storage_unittests": "816edccd9fba4eafb4685d3e2649aa55d80727ef", "sync_integration_tests": "7ee27778534266c51c490e178f7e3051fd3f039b", "traffic_annotation_auditor_unittests": "e1298aa0ed12c739145d2784d1764f1e4e3798ea", "ui_base_unittests": "2ff8f1cb7c13318e45230012e2d88c78ae31073e", "ui_touch_selection_unittests": "423708f2853de6e7dcde7f669ca600b693048a33", "unit_tests": "37a07012b6113c05e699c25a4691b8a032fd403d", "url_unittests": "3bfb7538421b9bd6b09a162486a8f8d349471afb", "views_unittests": "1633cc58795133a6d196dd56c983f141bf4c15ee", "viz_unittests": "6400a46b5efe031cb67e579498a0e778b1d00250", "vr_common_unittests": "964c73d2655134b43c78192b7762276a5c9a9357", "vr_pixeltests": "a91fac2347c03f9d67335d7c0770acdbee135fa0", "webkit_unit_tests": "e449d27c3ebb0bdee3ff61c4a6f244f28b48de1a", "wm_unittests": "4586c8800dbbd02a2ec95589210c2cdf64fe8994", "wtf_unittests": "ce22be9cfc441283310880007a5ba6501a297b2c"} isolate tests
swarm_hashes {"accessibility_unittests": "1083bef1a6965c67308d9de07a4ffc9fee598c3b", "angle_unittests": "ef689a0fe2ad64bd8324b7f0f31c3eb9af405dd1", "app_shell_unittests": "92bc71b351fb17e8703c2151f1f1a99cde074d07", "aura_unittests": "43876cc8c500f19e793d5fa1d48701a2da5a831e", "base_unittests": "b05e073f4c9c269011057430813adccd3bf82388", "blink_common_unittests": "65dfbeece72d156b35fa8f80a0ef7d50d6946322", "blink_fuzzer_unittests": "213d965f8e02d99fe88dd68f0f606bc6e119d282", "blink_heap_unittests": "d8797fc1e176097c5529442708ab8677557477e9", "blink_platform_unittests": "f786c2fec90e9fbfe593808ae59157985eb8b532", "boringssl_crypto_tests": "fdc752208df4f7bebb7e8fc8c02031efeade2b6a", "boringssl_ssl_tests": "3251cd07b3a0e0a2ba1d6e362db6de9f054e9d05", "browser_tests": "0d9b3cb5529da5a8162fbdfd2869eb837a06b468", "cacheinvalidation_unittests": "7b2b5ec60b62b50c0d6436f30d21ad46567dd1c9", "capture_unittests": "54a1f9167e05d6914205d8ba868e988c17b05efb", "cast_unittests": "a63aef7c4d8670e1b61ac528304ddddecd04bb0b", "cc_unittests": "e9c9f3557e3da0d077c4ecc5707b755bb5546cab", "chrome_app_unittests": "8697f74c17a0f273b5d2e51c3c1dd315ee39968f", "chromedriver_unittests": "8a585bd9b320948203007db5d465f916d9969d82", "components_browsertests": "829c37ac97f88ff51257496210c96583acff7b01", "components_unittests": "222fd1fd318f4e2ed2a8dc7b7670b3878df4d64a", "compositor_unittests": "02572da3b8ce0653d28adb1c63a47e2faf30eab8", "content_browsertests": "00cf7ab1e5598199f765f28076238eb656301775", "content_unittests": "38f0b509f63df47c9ed7e02172709e5f11154143", "cronet_tests": "5dae1fe485625c200395445e60f1d5c70933cc0b", "cronet_unittests": "448e2f10397b2a70e5b4fcf1ea19e515de147c71", "crypto_unittests": "9e85535a9f8791c496e8443e4db2aed7e50ae431", "dbus_unittests": "0de39172b771df589a166a963498dab2cec9ee66", "device_unittests": "9f3bb2330a5d2c75bfa177b805d298c03ef4eb8f", "display_unittests": "a4d8a6f1414178dbd38959adc807465a104836a7", "events_unittests": "f80e1ae187348a2f8eb1e87f6744941f7e9cfdf0", "extensions_browsertests": "d980903ba9ce7b33da9eaf35c0df87e63f9f2cd4", "extensions_unittests": "89b745827c9b702fcc6b2d989d37513c5996ccf1", "filesystem_service_unittests": "f02a2cc630decf4165da1b67ac01df78b13063a1", "gcm_unit_tests": "8f6f8927a55a853345b18c73f258782d8cad6d96", "gfx_unittests": "3673fd3ade71e0dd537872a7992781f934a13b44", "gin_unittests": "97f01da9bbca0096f67ffb194156274272395c35", "google_apis_unittests": "0631fea3299ca654b7b1ed5f1d18a842b216ddd0", "gpu_unittests": "a7eabb1303732f69949985e7755040154fb66a65", "headless_browsertests": "9cfc63c7fd8c2ed902f747976bea4e0ed0d4cadc", "headless_unittests": "d82f66d349eccba66b8878935567540209f61cd2", "interactive_ui_tests": "dc6e3f4775e2083b4787422932849197f1bacdcd", "ipc_tests": "43330bcddf5a9e21f69615ff027f696570df185b", "jingle_unittests": "8abadea7bc4fd07b81e226b2e6ffa94d2ce853e9", "latency_unittests": "529e499bc0a45660b1a8b8d1c906ece0c0f1f550", "leveldb_service_unittests": "3a570716efa73f10a4ca4d5b5b46c92a6556d5ed", "libjingle_xmpp_unittests": "52367257d4c7e4bac347e83474e507ec62825d9b", "media_blink_unittests": "df7f2063ef20cff22be6f3f3da19badd5a4944e4", "media_service_unittests": "f770e79df49f8a7e536f161bfd64744310e71d28", "media_unittests": "de4779216df5db4c64893ce70fc095903731670d", "message_center_unittests": "66921fe30acaa991043bf58db1f9ccebc9ed4e74", "midi_unittests": "7569c5085d640d27aadf3c2fe03c00a886beb530", "mojo_core_unittests": "0bbed706a804c27155d05084c29b1940186afaa9", "mojo_unittests": "d23a4447eb985c009b1b18f41811490b864ccd8f", "nacl_helper_nonsfi_unittests": "344cf7aa1a0ef1b2537ba1f3a371a22bef6a3580", "nacl_loader_unittests": "c5d70b0822444729fba83bd76dab4e6df3ae1671", "native_theme_unittests": "9e7a468272a7de5330711825baac18fac0c890ef", "net_unittests": "e6a9603355c4cf7c9c15f803280ab53e0dfc66dc", "pdf_unittests": "2e879e317c0edf71013e1b5d1d962e2108a56e9b", "ppapi_unittests": "1e64fc172cf9c809760fe9dbcea5a2a7c661e1eb", "printing_unittests": "a3f37144a67cb8988aa7c391b05a40c1c6eb9896", "remoting_unittests": "b9ff030a990bafcea21ed8bc0169ee05ae858f1f", "sandbox_linux_unittests": "17a449a90fd2e06f26a2ce0142b0bbe2840d9e7b", "service_manager_unittests": "8b7447ea6832762edaddc8152c453537517d32e8", "services_unittests": "39af697ba549740f77f40596f306b0586bdaa9a4", "shell_dialogs_unittests": "c301e38bb9d21bef26236edb69c112fbb3af42c5", "skia_unittests": "5a7bd4a111b61f9c2a640cbcb8da104b387df31e", "snapshot_unittests": "472174ef9d58b5d4fbcc6700a393ae93ec81f9d0", "sql_unittests": "f3b0d30b479b271f7e0923f4e15e151ea9892deb", "storage_unittests": "816edccd9fba4eafb4685d3e2649aa55d80727ef", "sync_integration_tests": "7ee27778534266c51c490e178f7e3051fd3f039b", "traffic_annotation_auditor_unittests": "e1298aa0ed12c739145d2784d1764f1e4e3798ea", "ui_base_unittests": "2ff8f1cb7c13318e45230012e2d88c78ae31073e", "ui_touch_selection_unittests": "423708f2853de6e7dcde7f669ca600b693048a33", "unit_tests": "37a07012b6113c05e699c25a4691b8a032fd403d", "url_unittests": "3bfb7538421b9bd6b09a162486a8f8d349471afb", "views_unittests": "1633cc58795133a6d196dd56c983f141bf4c15ee", "viz_unittests": "6400a46b5efe031cb67e579498a0e778b1d00250", "vr_common_unittests": "964c73d2655134b43c78192b7762276a5c9a9357", "vr_pixeltests": "a91fac2347c03f9d67335d7c0770acdbee135fa0", "webkit_unit_tests": "e449d27c3ebb0bdee3ff61c4a6f244f28b48de1a", "wm_unittests": "4586c8800dbbd02a2ec95589210c2cdf64fe8994", "wtf_unittests": "ce22be9cfc441283310880007a5ba6501a297b2c"} find isolated tests

Blamelist:

  1. Nico Weber (thakisohnoyoudont@chromium.org)
  2. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  3. Cary Clark (caryclarkohnoyoudont@google.com)
  4. Eugene But (eugenebutohnoyoudont@google.com)
  5. Robert Ogden (robertogdenohnoyoudont@chromium.org)
  6. Ayu Ishii (ayuiohnoyoudont@chromium.org)
  7. Jeffrey Yasskin (jyasskinohnoyoudont@chromium.org)
  8. Eric Roman (eromanohnoyoudont@chromium.org)
  9. Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
  10. John Budorick (jbudorickohnoyoudont@chromium.org)
  11. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  12. Yue Cen (rsgingerrsohnoyoudont@chromium.org)
  13. Bence Béky (bncohnoyoudont@chromium.org)
  14. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  15. Clark DuVall (cduvallohnoyoudont@chromium.org)
  16. Nick Harper (nharperohnoyoudont@chromium.org)
  17. Daniel Rubery (druberyohnoyoudont@chromium.org)
  18. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  19. Jun Cai (juncaiohnoyoudont@chromium.org)
  20. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  21. Chris Lu (thegreenfrogohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 00:33:01 UTC
Start Friday, 07-Dec-18 00:43:18 UTC
End Friday, 07-Dec-18 04:47:06 UTC
Pending 10 mins 16 secs
Execution 4 hrs 3 mins

All Changes:

  1. Explicitly list all $root_out_dir/resources/inspector files in the isolate.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:20:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f213164d219da210c4c0383d4878c02633599965

    Comments

    Explicitly list all $root_out_dir/resources/inspector files in the isolate.
    
    Listing a generated directory in the isolate means that incremental
    builders (and devs doing incremental builds) can have stale files in
    their generated isolated files.
    
    Bug: 911761
    Change-Id: I8652b272b44b031771e4458d43d5091abb093428
    Reviewed-on: https://chromium-review.googlesource.com/c/1366443
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614502}

    Changed files

    • BUILD.gn
    • third_party/blink/renderer/devtools/BUILD.gn
  2. Revert "Reland "Android: Factor InProductHelp UI out of Tab""

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 22:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277

    Comments

    Revert "Reland "Android: Factor InProductHelp UI out of Tab""
    
    This reverts commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd.
    
    Reason for revert:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/2097 
    
    https://crbug.com/907602 doesn't seem to be addressed.
    
    Original change's description:
    > Reland "Android: Factor InProductHelp UI out of Tab"
    > 
    > 
    > https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple
    > of bugs in |ToolbarButtonInProductHelpController|:
    > 
    > 1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and
    >    always used Profile.getLastUsedProfile()
    > 2) |OnDismissListener| was instantiated (and menu got highlight for
    >    the text bubble) every time |setupAndMaybeShowIPHForFeature| is called,
    >    even when the method doesn't meet the condition for IPH text bubble
    >    and has to early out.
    > 
    > The CL got reverted due to numerous regressions . This CL fixes them and
    > relands it.
    > 
    > This reverts commit d436a7a2e33ee105a1d85370970fde3c88255302.
    > 
    > Bug: 889682, 907502, 907503, 907770, 907505, 907602
    > Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4
    > Reviewed-on: https://chromium-review.googlesource.com/c/1349142
    > Reviewed-by: Theresa <twellington@chromium.org>
    > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614161}
    
    TBR=twellington@chromium.org,jinsukkim@chromium.org
    
    Change-Id: Id92d47e6ac65a0b1a50f4ad4cb1c0b9a11189993
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 889682, 907502, 907503, 907770, 907505, 907602
    Reviewed-on: https://chromium-review.googlesource.com/c/1366456
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614501}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java
  3. remove skia legacy define

    Changed by Cary Clark - caryclarkohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 21:40:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6

    Comments

    remove skia legacy define
    
    Skia change has landed.
    Looks like a handful of tests have minor changes.
    
    R=fmalita@chromium.org
    
    Bug: 843966
    Change-Id: I5809a7a317e33a20c738a1b3ce4156a886b4d174
    Reviewed-on: https://chromium-review.googlesource.com/c/1363213
    Commit-Queue: Cary Clark <caryclark@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614500}

    Changed files

    • skia/config/SkUserConfig.h
    • third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/text-text-08-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/text/text-selection-deco-01-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-08-b-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.10/fast/text/stroking-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.12/fast/text/stroking-expected.png
    • third_party/blink/web_tests/platform/mac/fast/text/stroking-expected.png
  4. Do not leak WK internal URL from pending item.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 21:37:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112172d28d486c5d9776c794b89413bf6f314cd7

    Comments

    Do not leak WK internal URL from pending item.
    
    Extend WebStateTest.RestoreLargeSession test to verify that during
    session restoration GetPendingItemIndex() returns -1 and
    GetPendingItem() returns null.
    
    Pending Item will appear after first post-restore navigation is
    started, which happens before session restoration is considered
    complete. Session restoration is complete after first post-restore
    navigation is finished.
    
    Bug: 877671
    Change-Id: Iec922bc71a0101e14a7d12cca6c53a039d71674e
    Reviewed-on: https://chromium-review.googlesource.com/c/1363958
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614499}

    Changed files

    • ios/web/navigation/legacy_navigation_manager_impl.h
    • ios/web/navigation/legacy_navigation_manager_impl.mm
    • ios/web/navigation/navigation_manager_impl.h
    • ios/web/navigation/navigation_manager_impl.mm
    • ios/web/navigation/navigation_manager_impl_unittest.mm
    • ios/web/navigation/navigation_manager_util.mm
    • ios/web/navigation/wk_based_navigation_manager_impl.h
    • ios/web/navigation/wk_based_navigation_manager_impl.mm
    • ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm
    • ios/web/web_state/ui/crw_web_controller.mm
    • ios/web/web_state/web_state_unittest.mm
  5. Increase spacing to 4dp between "Lite" and verticial separator on CCT

    Changed by Robert Ogden - robertogdenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:36:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d46232aa20ed1d0374be90517e41d9d3009bc479

    Comments

    Increase spacing to 4dp between "Lite" and verticial separator on CCT
    
    Looks like this should have been 4dp all along.
    
    Bug: 912308
    Change-Id: I4781124f174fe60cff1dcfeab4a18f6e1758fe6b
    Reviewed-on: https://chromium-review.googlesource.com/c/1366363
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Robert Ogden <robertogden@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614498}

    Changed files

    • chrome/android/java/res/values/dimens.xml
  6. Fix #endif comment

    Changed by Ayu Ishii - ayuiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:35:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c286ce55b1135cc731048a7a4bd869b9d9f2b1f

    Comments

    Fix #endif comment
    
    Bug: None
    Change-Id: Ie12298fd5bc4dc52cd2d25a180d36f5ace4ec90f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365895
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Ayu Ishii <ayui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614497}

    Changed files

    • third_party/blink/renderer/modules/bluetooth/bluetooth_characteristic_properties.h
  7. Disable flaky ChromeVox tests.

    Changed by Jeffrey Yasskin - jyasskinohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:35:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6af09c65d9c1cc347f08573eda20c25e49765bd6

    Comments

    Disable flaky ChromeVox tests.
    
    These started flaking with https://crrev.com/613661 which changed timing
    in the renderer process.
    
    Bug: 912390
    Change-Id: Ia41f0dc73210d83b2562f9ff55e9a7407d102448
    Tbr: dmazzoni@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1366360
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614496}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs
  8. Crash if ProxyList::Get() is called on an empty list.

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:34:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7d0cd07fb1d38548b7d7f539f6bd07a2c960d3f

    Comments

    Crash if ProxyList::Get() is called on an empty list.
    
    Bug: 912217
    Change-Id: Id9f31535bfb9378ed1d7ea8cc6ca917726a127cc
    Reviewed-on: https://chromium-review.googlesource.com/c/1366298
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614495}

    Changed files

    • net/proxy_resolution/proxy_list.cc
  9. [Fuchsia] Enable the http_service_tests suite on CQ.

    Changed by Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:31:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe231e0f716579f6c858e0fd97566ae15feff72

    Comments

    [Fuchsia] Enable the http_service_tests suite on CQ.
    
    Following various fixes, the test suite is now stable on FYI
    bots. This test suite is quite small so the overhead should be
    minimal.
    
    Bug: 896884
    Change-Id: I44821e78b8807b6593d107c0d903f1130c1a3aed
    Reviewed-on: https://chromium-review.googlesource.com/c/1366261
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614494}

    Changed files

    • testing/buildbot/chromium.linux.json
    • testing/buildbot/test_suite_exceptions.pyl
  10. Add initial configuration for chromium.fyi:mac-hermetic-upgrade-rel.

    Changed by John Budorick - jbudorickohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:29:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29d6599ae563a6ee8bae0e8e8468254ec88cfc6d

    Comments

    Add initial configuration for chromium.fyi:mac-hermetic-upgrade-rel.
    
    Bug: 907173
    Change-Id: I53c971e1f8d429acee7cfa00fdf9d04c7c02b3eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1361667
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614493}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  11. Roll src/third_party/perfetto 2d82f1496ad6..82c3965be4fb (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 21:24:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d05f31593e8b94d0c1addc51761cffbf94d88e6

    Comments

    Roll src/third_party/perfetto 2d82f1496ad6..82c3965be4fb (3 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/2d82f1496ad6..82c3965be4fb
    
    
    git log 2d82f1496ad6..82c3965be4fb --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com Add Dockerfile for continuous fuzzer.
    2018-12-06 fmayer@google.com Merge "profiling: switch to using swap for assignment operators."
    2018-12-06 hjd@google.com perfetto-ui: Avoid bug with NULL refs when adding counter tracks
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@82c3965be4fb
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:69150303
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ia009b8a8794cc5bf713b1ec153f8773ed9ca9fd5
    Reviewed-on: https://chromium-review.googlesource.com/c/1366475
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614492}

    Changed files

    • DEPS
  12. Password manager: Style changes in the website column

    Changed by Yue Cen - rsgingerrsohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:20:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b974f8e7a514acf61ed018d55565731ff5d02e5

    Comments

    Password manager: Style changes in the website column
    
    - Increase the padding between the icon and the domain like in
      chrome://history.
    - Make the URLS for the domain black (but still clickable).
    
    Bug: 890118
    Change-Id: If63006dced601b2891e9b0864b788808acc1faa8
    Reviewed-on: https://chromium-review.googlesource.com/c/1332258
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614491}

    Changed files

    • chrome/browser/resources/settings/autofill_page/passwords_shared_css.html
  13. Change SpdyHeaderBlockNetLogCallback() dict value type.

    Changed by Bence Béky - bncohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:11:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66871e3ef3779595d6294e09e95cf4c59e2c7342

    Comments

    Change SpdyHeaderBlockNetLogCallback() dict value type.
    
    SpdyHeaderBlockNetLogCallback() returns a base::DictionaryValue with a
    single entry with key "headers".  This CL changes the value of that
    entry from a base::DictionaryValue to a base::ListValue.  The motivation
    is that this way duplicate code with ElideSpdyHeaderBlockForNetLog() can
    be eliminated, so it will be enough to fix https://crbug.com/800282 in
    one function.
    
    Also make sure that unittests only use base::Value methods that are not
    marked as deprecated.
    
    Bug: 800282
    Change-Id: Ie9396f7299acb84ad21892894ae5607ee8af7f34
    Reviewed-on: https://chromium-review.googlesource.com/c/1362086
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Commit-Queue: Bence Béky <bnc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614490}

    Changed files

    • net/spdy/spdy_log_util.cc
    • net/spdy/spdy_log_util_unittest.cc
    • net/spdy/spdy_network_transaction_unittest.cc
  14. [NTP] Display promos on the local NTP

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:10:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f966bb5956e85d829d23ed59cf2370ac36d6f10

    Comments

    [NTP] Display promos on the local NTP
    
    If promo data is available display it on the local NTP.
    
    Bug: 906278
    Change-Id: Ibd9e60e180bc9d37a2c99a1bf86dca7fc5fa8516
    Reviewed-on: https://chromium-review.googlesource.com/c/1353988
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614489}

    Changed files

    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/local_ntp.js
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/search/local_ntp_source.h
    • chrome/browser/search/promos/promo_service.h
    • chrome/browser/ui/search/local_ntp_promos_browsertest.cc
    • chrome/test/BUILD.gn
    • tools/metrics/histograms/histograms.xml
  15. Run network service tests in-process on FYI bots

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:06:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a89d2f882b65865b5a53241d197691e7f6f4ea3d

    Comments

    Run network service tests in-process on FYI bots
    
    This runs all Android tests in-process on the Mojo Android bot, and runs
    browser_tests in-process on Windows/Linux.
    
    Bug: 908993
    Change-Id: I86a683885c0c3081533623d5771ffb4f24561a70
    Reviewed-on: https://chromium-review.googlesource.com/c/1361921
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614488}

    Changed files

    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  16. Add some BBC domains to the HSTS preload list

    Changed by Nick Harper - nharperohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:59:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b41d1d9efacade5fe7e3cfc9fa59fc001ab64d92

    Comments

    Add some BBC domains to the HSTS preload list
    
    Change-Id: If98e0cbe08d98b77b0652364b036fc4f720f19c0
    Reviewed-on: https://chromium-review.googlesource.com/c/1363901
    Reviewed-by: Bence Béky <bnc@chromium.org>
    Commit-Queue: Nick Harper <nharper@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614487}

    Changed files

    • net/http/transport_security_state_static.json
  17. Reland: Add util method to update ArchiveAnalyzerResults for a single file

    Changed by Daniel Rubery - druberyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:57:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c065bb11d7a6e0227c0d32e043e458e1ef76091

    Comments

    Reland: Add util method to update ArchiveAnalyzerResults for a single file
    
    This CL breaks out the code that inspects an individual file within a
    ZIP archive. This will be shared between the ZIP and RAR inspection,
    when RAR files begin doing content inspection.
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1354103
    The OOB read has been fixed between patchsets 1 and 2.
    
    Bug: 909778
    Change-Id: I707364516217136ee95174bbae930b5df0cf54ed
    TBR: jcivelli@
    Reviewed-on: https://chromium-review.googlesource.com/c/1359037
    Commit-Queue: Daniel Rubery <drubery@chromium.org>
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614486}

    Changed files

    • chrome/common/safe_browsing/BUILD.gn
    • chrome/common/safe_browsing/archive_analyzer_results.cc
    • chrome/common/safe_browsing/archive_analyzer_results.h
    • chrome/common/safe_browsing/zip_analyzer.cc
    • chrome/services/file_util/public/cpp/sandboxed_zip_analyzer_unittest.cc
    • chrome/utility/safe_browsing/mac/BUILD.gn
    • tools/metrics/histograms/histograms.xml
  18. Roll src/third_party/catapult 285509d0e41e..d18d6c7c7183 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 20:56:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2610d29728707cc0f9959c1f6a610d4baa478a62

    Comments

    Roll src/third_party/catapult 285509d0e41e..d18d6c7c7183 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/285509d0e41e..d18d6c7c7183
    
    
    git log 285509d0e41e..d18d6c7c7183 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 oysteine@google.com Remove precision check from the EQT metric calculation
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@d18d6c7c7183
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: I3020fbca08d04e3b2f88c7ad1298a32f966adcad
    Reviewed-on: https://chromium-review.googlesource.com/c/1366476
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614485}

    Changed files

    • DEPS
  19. Network Service: Add DCHECK() for |callback_| in SiteDataClearer destructor

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:55:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5dfaf338a6b7f5c283e093059fc9e8dbfcc7c1d1

    Comments

    Network Service: Add DCHECK() for |callback_| in SiteDataClearer destructor
    
    This CL adds a DCHECK() in the SiteDataClearer destructor to make sure the
    |callback_| is already null when the destructor is called.
    
    Bug: 909826
    Change-Id: I0cb3b039e23e16d3c827e9c877ea413619542158
    Reviewed-on: https://chromium-review.googlesource.com/c/1359295
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614484}

    Changed files

    • content/browser/browsing_data/clear_site_data_utils.cc
  20. Roll src/third_party/SPIRV-Tools/src aa270e568a3f..cf37ab7213d2 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 20:50:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e519987067ebabb7f08680c97681d5107e2414b

    Comments

    Roll src/third_party/SPIRV-Tools/src aa270e568a3f..cf37ab7213d2 (1 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/aa270e568a3f..cf37ab7213d2
    
    
    git log aa270e568a3f..cf37ab7213d2 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 zoddicus@users.noreply.github.com Merge two implementations of ValidateMemorySemantics (#2175)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@cf37ab7213d2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I0e60385ff1e52620d37b9424fe2d27538ff3bf0a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366364
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614483}

    Changed files

    • DEPS
  21. [ios] feature flag for find in page iframe

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:46:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77905ac0652a3187769ee51328a1308d23510f6a

    Comments

    [ios] feature flag for find in page iframe
    
    Bug: 896867
    Change-Id: Ia83521278052848fe57f3a99f91e1ad9dd51deac
    Reviewed-on: https://chromium-review.googlesource.com/c/1364334
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614482}

    Changed files

    • ios/chrome/browser/BUILD.gn
    • ios/chrome/browser/about_flags.mm
    • ios/chrome/browser/find_in_page/BUILD.gn
    • ios/chrome/browser/find_in_page/features.h
    • ios/chrome/browser/find_in_page/features.mm
    • ios/chrome/browser/ios_chrome_flag_descriptions.cc
    • ios/chrome/browser/ios_chrome_flag_descriptions.h