Home | Search | chromium - Builders
Login

Builder ToTLinuxASan Build 4332 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionf5dfc4fc873896dc668f7060914800c4e48a0b0f
Got Revisionf5dfc4fc873896dc668f7060914800c4e48a0b0f

Execution:

Steps and Logfiles:

Show:
  1. ( 308 ms ) setup_build
    running recipe: "chromium"
  2. ( 886 ms ) report builders
     
    running builder/tester 'ToTLinuxASan' on master 'chromium.clang'
  3. ( 4 mins 33 secs ) bot_update
    [200GB/590GB used (33%)]
  4. ( 2 secs ) swarming.py --version
    0.14
  5. ( 21 mins 12 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.clang.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.clang.json
  7. ( 545 ms ) lookup GN args
     
    clang_use_chrome_plugins = false
    is_asan = true
    is_clang = true
    is_component_build = false
    is_debug = false
    is_lsan = true
    llvm_force_head_revision = true
  8. ( 32 secs ) generate_build_files
  9. ( 699 ms ) clang_revision
  10. ( 3 hrs 36 mins ) compile
  11. ( 24 secs ) compile confirm no-op
  12. ( 10 secs ) upload_ninja_log
  13. ( 7 mins 45 secs ) isolate tests
  14. ( 452 ms ) find isolated tests
  15. ( 16 secs ) sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  16. ( 1 secs ) wait for tasks
  17. ( 2 secs ) perfetto_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 36s
  18. ( 1 secs ) accessibility_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  19. ( 3 secs ) gpu_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 37s
  20. ( 2 secs ) filesystem_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  21. ( 1 secs ) cronet_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  22. ( 2 secs ) ui_touch_selection_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  23. ( 2 secs ) chromedriver_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  24. ( 2 secs ) wm_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  25. ( 1 secs ) crypto_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  26. ( 1 secs ) media_blink_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 23s
  27. ( 1 secs ) native_theme_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  28. ( 1 secs ) nacl_loader_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  29. ( 4 secs ) angle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:11.286707
  30. ( 2 secs ) boringssl_ssl_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  31. ( 2 secs ) mojo_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  32. ( 2 secs ) aura_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  33. ( 1 secs ) sandbox_linux_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  34. ( 2 secs ) blink_heap_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  35. ( 1 secs ) vr_pixeltests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 18s
  36. ( 2 secs ) capture_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  37. ( 2 secs ) boringssl_crypto_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  38. ( 3 secs ) blink_platform_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 29s
  39. ( 2 secs ) display_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  40. ( 1 secs ) leveldb_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  41. ( 3 secs ) media_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 52s
  42. ( 2 secs ) events_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  43. ( 2 secs ) network_service_components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 48s
  44. ( 1 secs ) storage_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  45. ( 2 secs ) ui_base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  46. ( 2 secs ) remoting_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 19s
  47. ( 1 secs ) service_manager_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 22s
  48. ( 1 secs ) vr_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  49. ( 2 secs ) snapshot_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 20s
  50. ( 1 secs ) mojo_core_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  51. ( 2 secs ) traffic_annotation_auditor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  52. ( 1 secs ) pdf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  53. ( 1 secs ) midi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  54. ( 1 secs ) cronet_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  55. ( 2 secs ) printing_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 9s
  56. ( 1 secs ) latency_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 7s
  57. ( 1 secs ) shell_dialogs_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  58. ( 4 secs ) content_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:40.701723
  59. ( 2 secs ) gcm_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  60. ( 1 secs ) ppapi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  61. ( 1 secs ) webui_polymer2_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 27s
  62. ( 1 secs ) libjingle_xmpp_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 16s
  63. ( 2 secs ) blink_common_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  64. ( 1 secs ) sql_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  65. ( 2 secs ) extensions_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 59s
  66. ( 1 secs ) url_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  67. ( 2 secs ) cast_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  68. ( 1 secs ) jingle_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 8s
  69. ( 1 secs ) blink_fuzzer_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 17s
  70. ( 2 secs ) chrome_app_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 30s
  71. ( 2 secs ) cacheinvalidation_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  72. ( 1 secs ) app_shell_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 26s
  73. ( 2 secs ) media_service_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  74. ( 3 secs ) base_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 45s
  75. ( 2 secs ) webui_polymer2_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:01:08.824576 (shard #3)
    Min shard duration: 45s (shard #1)
  76. ( 2 secs ) components_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 51s
  77. ( 2 secs ) dbus_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  78. ( 2 secs ) ipc_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 15s
  79. ( 2 secs ) nacl_helper_nonsfi_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 13s
  80. ( 3 secs ) google_apis_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  81. ( 1 secs ) wtf_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 6s
  82. ( 2 secs ) device_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 21s
  83. ( 2 secs ) gfx_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 25s
  84. ( 2 secs ) message_center_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 10s
  85. ( 2 secs ) skia_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 12s
  86. ( 1 secs ) compositor_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 14s
  87. ( 1 secs ) wait for tasks (2)
  88. ( 3 secs ) cc_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:15.797795
  89. ( 8 secs ) components_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:04:58.297473
  90. ( 6 secs ) webkit_unit_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:53.875422
  91. ( 2 secs ) network_service_extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:57.780378
  92. ( 2 secs ) extensions_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:53.318337
  93. ( 6 secs ) unit_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:02:13.868150 (shard #1)
    Min shard duration: 0:02:11.273662 (shard #0)
  94. ( 2 secs ) viz_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:02:20.339871
  95. ( 3 secs ) services_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:01:05.431369
  96. ( 957 ms ) wait for tasks (3)
  97. ( 2 secs ) network_service_interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:07:38.781440 (shard #2)
    Min shard duration: 0:05:04.637872 (shard #1)
  98. ( 2 secs ) interactive_ui_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:07:10.033920 (shard #0)
    Min shard duration: 0:05:54.393341 (shard #1)
  99. ( 2 mins 9 secs ) wait for tasks (4)
  100. ( 3 secs ) sync_integration_tests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:09:54.536428
  101. ( 2 mins 1 secs ) wait for tasks (5)
  102. ( 26 secs ) network_service_browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:12:26.530313 (shard #11)
    Min shard duration: 0:08:05.866047 (shard #0)
  103. ( 2 mins 1 secs ) wait for tasks (6)
  104. ( 6 secs ) network_service_content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:16:22.164070 (shard #0)
    Min shard duration: 0:12:42.910055 (shard #1)
  105. ( 24 secs ) browser_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:15:24.779686 (shard #6)
    Min shard duration: 0:12:17.411855 (shard #5)
  106. ( 22 secs ) net_unittests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:15:21.150550 (shard #5)
    Min shard duration: 56s (shard #14)
  107. ( 1 secs ) wait for tasks (7)
  108. ( 2 secs ) views_unittests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:15:12.882227
  109. ( 45 secs ) content_browsertests
    Run on OS: 'Ubuntu-14.04'
    Shard duration: 0:20:25.159961
  110. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 134
    Total runtime: 7:31:35.203735
     
  111. ( 3 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "gce-trusty-32-0258d129-us-west1-c-0pfl" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544145011217376, "id": "8927840316676350560", "project": "chromium", "tags": ["builder:ToTLinuxASan", "buildset:commit/git/f5dfc4fc873896dc668f7060914800c4e48a0b0f", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f5dfc4fc873896dc668f7060914800c4e48a0b0f", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093270378862262048", "scheduler_job_id:chromium/ToTLinuxASan", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ToTLinuxASan" setup_build
buildnumber 4332 setup_build
mastername "chromium.clang" setup_build
path_config "generic" setup_build
perf_dashboard_machine_group "ChromiumClang" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "f5dfc4fc873896dc668f7060914800c4e48a0b0f" setup_build
got_angle_revision "9092bdc7a76f8f79d7fba775880fecbd3e729ea4" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "5aacd29d5e7ed44d3cb0d1c690fbd0fc5152978f" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "f5dfc4fc873896dc668f7060914800c4e48a0b0f" bot_update
got_revision_cp "refs/heads/master@{#614526}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "c5bfa5d3b1a5b015ac01228595f8a3e5643f4868" bot_update
got_v8_revision_cp "refs/heads/7.3.52@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
got_clang_revision "348558" clang_revision
swarm_hashes_refs/heads/master(at){#614526}_without_patch {"accessibility_unittests": "f4020c7ac5be170ddd8353972c0467086855618d", "angle_unittests": "fe8f013140653149f24e0edab1dfa2fd8245b453", "app_shell_unittests": "2133b30b145e861ba4e0e697736ff3b9e8375663", "aura_unittests": "71879240800b1473fb2796bcf487781e5036eff3", "base_unittests": "278fd59784082d13f6490e068299ef9a1088ead0", "blink_common_unittests": "b338091a1e9b78eb7a5b679ca5e3298049896b34", "blink_fuzzer_unittests": "15720b5dfcc6a0bfbeb41639c53f2ebe8275423c", "blink_heap_unittests": "12151af7ae67af95b5f5d4176f4f52c8eb4c5d6e", "blink_platform_unittests": "9acaf38564dfaa03e936519ba35cb170b45b49b1", "boringssl_crypto_tests": "0da8ca27c544610986ef4980cdc37e195f9e71f6", "boringssl_ssl_tests": "ea499648b33b26ad696d385e90961604edfaf88f", "browser_tests": "2403f0f93c5c84359f28d3c5241bd30c5e9569fd", "cacheinvalidation_unittests": "ab66bf22572146845fd8e24330310c28ba63387e", "capture_unittests": "e87876767711c82fdca0ad7aad447e0f5af64309", "cast_unittests": "1092b2c4bc416bdab2a30c4360bc8db17c2a0f18", "cc_unittests": "e0ed72d89261fe487bbd328f31e6a604f62a78a1", "chrome_app_unittests": "cc7cab11c0373a0e80512f3a232b65153922a634", "chromedriver_unittests": "c91ff4f8f79774aaa2465967a30fc8fc98ae2f4b", "components_browsertests": "d977e0721e44858579d6b6a9292bef58ed00d364", "components_unittests": "700d9d1a2c6032787d8f543da266e8f980ccc33a", "compositor_unittests": "a97d5a09715de11077b888840241f29a53b2a21f", "content_browsertests": "caea4e7aa26e3bfd8c439957232fb39374dbf615", "content_unittests": "0defa77f7301a26207be6e72cb625a14db015361", "cronet_tests": "273f39373502ae047a70e6a8e1f11500b2658b70", "cronet_unittests": "ff51fdb6acd845ce88d0c2e13d9df07d5117b087", "crypto_unittests": "f08e6fc9340cb567926ea490ae400f37a95be986", "dbus_unittests": "97dbcbb3da921d3b3f580e2fa8e5b846a55597af", "device_unittests": "36bff976f9dcb720883c9225c032079002bbb8a1", "display_unittests": "2a02b357dfaa4c69cbbac62905e720163f3089af", "events_unittests": "5f33d06a93feb2b2719b187c08daf6df80dde537", "extensions_browsertests": "4bd96dbfd32321704698a8f2d9d5258cb6680c3a", "extensions_unittests": "401f0809f1ac54b6d5d64af4c40768547f550fa2", "filesystem_service_unittests": "aa7e25e73b16b6cc1a5e2b1c8ecf21746a682e4c", "gcm_unit_tests": "1bb5a5e5bf88ad72699c61d9456d6b05209876e0", "gfx_unittests": "2ba6deb73960ed1d97d9c2cb01ccb48435db8453", "google_apis_unittests": "459d533f06f1088fe3fd91393499da13caba1a11", "gpu_unittests": "4645230ec2f64cd81f02b8b0c17cfd33aa94a573", "interactive_ui_tests": "ddf484880ecb0a96d87714f6953a47ccefa6c739", "ipc_tests": "779249a514c5c211cbb59fe6eba1547a9c52fa15", "jingle_unittests": "64203e3f119838a395232147a9403fc0de80a432", "latency_unittests": "82d91c1c3ca68c0fbf727e34f610613fc00eb4c0", "leveldb_service_unittests": "304c18f40d2ae34a36a11491fbcb848a5c2891e9", "libjingle_xmpp_unittests": "da0c378be2aaf7c0a09e9e8d11f87968e699f656", "media_blink_unittests": "572cff7b166e01d0db011d8900218579ef1faa7e", "media_service_unittests": "82c565a285f90cd97cff50614c84da2962409bf3", "media_unittests": "205a3298b6b3b5463b4f35d3fb0b9cfd6d3451d8", "message_center_unittests": "05084bd5fc37efb9b15f157d38faf4672fb88e9d", "midi_unittests": "fc78a64fd3f229c62508a9373b11ca13cbaf8aad", "mojo_core_unittests": "1af0266ce9136a030aabe6279a18a8b2c079887c", "mojo_unittests": "857f28b9a1422528ebc3060a3e1ab3dc01007c38", "nacl_helper_nonsfi_unittests": "58b6e4cf2da550a9fcad05d4dde16dcb56652021", "nacl_loader_unittests": "394f52ec79119f7982aad37bc4d9b650cf6ba524", "native_theme_unittests": "0c4661bf8df476a35e7bdb265612e3f89e4e210f", "net_unittests": "d8ad98b3e9d60a942ec509dc4f924a101fc74c57", "pdf_unittests": "417cdde7b02cf25e92369f0f578e158687bdd99c", "ppapi_unittests": "24b63281940cc52c188a89d311393e854d39add9", "printing_unittests": "2b50bbbf0f6a4103357a5e1401c9dd458195cd54", "remoting_unittests": "4e846a7fe1a793778e566346d3dc02a90aaa518e", "sandbox_linux_unittests": "ab13529d055bfbf1017c3cc4c490381e19791d1b", "service_manager_unittests": "4e3dfff8a480b11bcd012fcd2a35a614b5423290", "services_unittests": "8c96745acf44a8fa16d81fb18a07a60215f941c3", "shell_dialogs_unittests": "41ec1763b8eb94b77eee47e3690868d8f060ebed", "skia_unittests": "85ffd49eb15aaae637e31ffb20e7215a458d4cbc", "snapshot_unittests": "a3a75ffca4856fe287d0ee9bbaf7eaca5368f54b", "sql_unittests": "53b27a8f97ad86cfce4f77e52fe5daef5a47f836", "storage_unittests": "1329dd41e80c40d510f027521867e2ff0bd91b37", "sync_integration_tests": "91ed0ba619d2701d7c7702d100e932d86b044218", "traffic_annotation_auditor_unittests": "fcb7a715b7b4b2b6980b39f4d4dc97fd2e9e5a5f", "ui_base_unittests": "43153e0dde4f2dd222454e0f74d00376826169a0", "ui_touch_selection_unittests": "c61f49c52e20e39d298427e301071094e8b19e94", "unit_tests": "c941f39fb401e022a3c0491286c137f80d427bf7", "url_unittests": "955d2a003d0dd4de77df25a2d0974e13e507dc22", "views_unittests": "acb134905cac867026bb21355918166914fc9f8c", "viz_unittests": "1aef5b4f4b117a97324ec580065001a3572c9e59", "vr_common_unittests": "eb05fb104ef28b6ef582a067e3d6923b58055e83", "vr_pixeltests": "41c404af304b79900cef39eeff218f8a7e4b9c22", "webkit_unit_tests": "686bc154f900b40c793b4b7028206e1d335631b3", "wm_unittests": "f9cf5d0d93b54691aaa67549f947a4d0aaa180f3", "wtf_unittests": "cd4cad075f388ee265928a747e7c2a99b7193b55"} isolate tests
swarm_hashes {"accessibility_unittests": "f4020c7ac5be170ddd8353972c0467086855618d", "angle_unittests": "fe8f013140653149f24e0edab1dfa2fd8245b453", "app_shell_unittests": "2133b30b145e861ba4e0e697736ff3b9e8375663", "aura_unittests": "71879240800b1473fb2796bcf487781e5036eff3", "base_unittests": "278fd59784082d13f6490e068299ef9a1088ead0", "blink_common_unittests": "b338091a1e9b78eb7a5b679ca5e3298049896b34", "blink_fuzzer_unittests": "15720b5dfcc6a0bfbeb41639c53f2ebe8275423c", "blink_heap_unittests": "12151af7ae67af95b5f5d4176f4f52c8eb4c5d6e", "blink_platform_unittests": "9acaf38564dfaa03e936519ba35cb170b45b49b1", "boringssl_crypto_tests": "0da8ca27c544610986ef4980cdc37e195f9e71f6", "boringssl_ssl_tests": "ea499648b33b26ad696d385e90961604edfaf88f", "browser_tests": "2403f0f93c5c84359f28d3c5241bd30c5e9569fd", "cacheinvalidation_unittests": "ab66bf22572146845fd8e24330310c28ba63387e", "capture_unittests": "e87876767711c82fdca0ad7aad447e0f5af64309", "cast_unittests": "1092b2c4bc416bdab2a30c4360bc8db17c2a0f18", "cc_unittests": "e0ed72d89261fe487bbd328f31e6a604f62a78a1", "chrome_app_unittests": "cc7cab11c0373a0e80512f3a232b65153922a634", "chromedriver_unittests": "c91ff4f8f79774aaa2465967a30fc8fc98ae2f4b", "components_browsertests": "d977e0721e44858579d6b6a9292bef58ed00d364", "components_unittests": "700d9d1a2c6032787d8f543da266e8f980ccc33a", "compositor_unittests": "a97d5a09715de11077b888840241f29a53b2a21f", "content_browsertests": "caea4e7aa26e3bfd8c439957232fb39374dbf615", "content_unittests": "0defa77f7301a26207be6e72cb625a14db015361", "cronet_tests": "273f39373502ae047a70e6a8e1f11500b2658b70", "cronet_unittests": "ff51fdb6acd845ce88d0c2e13d9df07d5117b087", "crypto_unittests": "f08e6fc9340cb567926ea490ae400f37a95be986", "dbus_unittests": "97dbcbb3da921d3b3f580e2fa8e5b846a55597af", "device_unittests": "36bff976f9dcb720883c9225c032079002bbb8a1", "display_unittests": "2a02b357dfaa4c69cbbac62905e720163f3089af", "events_unittests": "5f33d06a93feb2b2719b187c08daf6df80dde537", "extensions_browsertests": "4bd96dbfd32321704698a8f2d9d5258cb6680c3a", "extensions_unittests": "401f0809f1ac54b6d5d64af4c40768547f550fa2", "filesystem_service_unittests": "aa7e25e73b16b6cc1a5e2b1c8ecf21746a682e4c", "gcm_unit_tests": "1bb5a5e5bf88ad72699c61d9456d6b05209876e0", "gfx_unittests": "2ba6deb73960ed1d97d9c2cb01ccb48435db8453", "google_apis_unittests": "459d533f06f1088fe3fd91393499da13caba1a11", "gpu_unittests": "4645230ec2f64cd81f02b8b0c17cfd33aa94a573", "interactive_ui_tests": "ddf484880ecb0a96d87714f6953a47ccefa6c739", "ipc_tests": "779249a514c5c211cbb59fe6eba1547a9c52fa15", "jingle_unittests": "64203e3f119838a395232147a9403fc0de80a432", "latency_unittests": "82d91c1c3ca68c0fbf727e34f610613fc00eb4c0", "leveldb_service_unittests": "304c18f40d2ae34a36a11491fbcb848a5c2891e9", "libjingle_xmpp_unittests": "da0c378be2aaf7c0a09e9e8d11f87968e699f656", "media_blink_unittests": "572cff7b166e01d0db011d8900218579ef1faa7e", "media_service_unittests": "82c565a285f90cd97cff50614c84da2962409bf3", "media_unittests": "205a3298b6b3b5463b4f35d3fb0b9cfd6d3451d8", "message_center_unittests": "05084bd5fc37efb9b15f157d38faf4672fb88e9d", "midi_unittests": "fc78a64fd3f229c62508a9373b11ca13cbaf8aad", "mojo_core_unittests": "1af0266ce9136a030aabe6279a18a8b2c079887c", "mojo_unittests": "857f28b9a1422528ebc3060a3e1ab3dc01007c38", "nacl_helper_nonsfi_unittests": "58b6e4cf2da550a9fcad05d4dde16dcb56652021", "nacl_loader_unittests": "394f52ec79119f7982aad37bc4d9b650cf6ba524", "native_theme_unittests": "0c4661bf8df476a35e7bdb265612e3f89e4e210f", "net_unittests": "d8ad98b3e9d60a942ec509dc4f924a101fc74c57", "pdf_unittests": "417cdde7b02cf25e92369f0f578e158687bdd99c", "ppapi_unittests": "24b63281940cc52c188a89d311393e854d39add9", "printing_unittests": "2b50bbbf0f6a4103357a5e1401c9dd458195cd54", "remoting_unittests": "4e846a7fe1a793778e566346d3dc02a90aaa518e", "sandbox_linux_unittests": "ab13529d055bfbf1017c3cc4c490381e19791d1b", "service_manager_unittests": "4e3dfff8a480b11bcd012fcd2a35a614b5423290", "services_unittests": "8c96745acf44a8fa16d81fb18a07a60215f941c3", "shell_dialogs_unittests": "41ec1763b8eb94b77eee47e3690868d8f060ebed", "skia_unittests": "85ffd49eb15aaae637e31ffb20e7215a458d4cbc", "snapshot_unittests": "a3a75ffca4856fe287d0ee9bbaf7eaca5368f54b", "sql_unittests": "53b27a8f97ad86cfce4f77e52fe5daef5a47f836", "storage_unittests": "1329dd41e80c40d510f027521867e2ff0bd91b37", "sync_integration_tests": "91ed0ba619d2701d7c7702d100e932d86b044218", "traffic_annotation_auditor_unittests": "fcb7a715b7b4b2b6980b39f4d4dc97fd2e9e5a5f", "ui_base_unittests": "43153e0dde4f2dd222454e0f74d00376826169a0", "ui_touch_selection_unittests": "c61f49c52e20e39d298427e301071094e8b19e94", "unit_tests": "c941f39fb401e022a3c0491286c137f80d427bf7", "url_unittests": "955d2a003d0dd4de77df25a2d0974e13e507dc22", "views_unittests": "acb134905cac867026bb21355918166914fc9f8c", "viz_unittests": "1aef5b4f4b117a97324ec580065001a3572c9e59", "vr_common_unittests": "eb05fb104ef28b6ef582a067e3d6923b58055e83", "vr_pixeltests": "41c404af304b79900cef39eeff218f8a7e4b9c22", "webkit_unit_tests": "686bc154f900b40c793b4b7028206e1d335631b3", "wm_unittests": "f9cf5d0d93b54691aaa67549f947a4d0aaa180f3", "wtf_unittests": "cd4cad075f388ee265928a747e7c2a99b7193b55"} find isolated tests

Blamelist:

  1. Ned Nguyen (nednguyenohnoyoudont@google.com)
  2. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  3. chcunningham (chcunninghamohnoyoudont@chromium.org)
  4. danakj (danakjohnoyoudont@chromium.org)
  5. Philip Rogers (pdrohnoyoudont@chromium.org)
  6. bsheedy (bsheedyohnoyoudont@chromium.org)
  7. Josh Karlin (jkarlinohnoyoudont@chromium.org)
  8. Erik Jensen (rkjnsnohnoyoudont@chromium.org)
  9. Vikas Soni (vikassoniohnoyoudont@chromium.org)
  10. sebsg (sebsgohnoyoudont@chromium.org)
  11. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  12. James Cook (jamescookohnoyoudont@chromium.org)
  13. Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
  14. CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
  15. Daniel Murphy (dmurphohnoyoudont@chromium.org)
  16. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  17. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  18. Clark DuVall (cduvallohnoyoudont@chromium.org)
  19. Sam Maier (smaierohnoyoudont@chromium.org)
  20. Jason Guo (jiahuiguoohnoyoudont@chromium.org)
  21. Lukasz Anforowicz (lukaszaohnoyoudont@chromium.org)
  22. David Lu (davidluphdohnoyoudont@google.com)
  23. Alex Newcomer (newcomerohnoyoudont@chromium.org)
  24. Scott Chen (scottchenohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 01:10:11 UTC
Start Friday, 07-Dec-18 01:10:53 UTC
End Friday, 07-Dec-18 05:44:22 UTC
Pending 42 secs
Execution 4 hrs 33 mins

All Changes:

  1. Simplify json source side of performance_test_suite of linux-perf-fyi bot

    Changed by Ned Nguyen - nednguyenohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:08:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5dfc4fc873896dc668f7060914800c4e48a0b0f

    Comments

    Simplify json source side of performance_test_suite of linux-perf-fyi bot
    
    The *_layout_ng tests are currently not running (see https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/417), so cleaning them up to prepare
    for further refactoring
    
    Bug: 902089
    Change-Id: Iadd871b8975793fdfcd848be06de690f40cf2058
    Reviewed-on: https://chromium-review.googlesource.com/c/1361929
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614526}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
  2. Remove IsNestedWorker()

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:08:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b47801ae2af0092ff6f701c8b21de5cc744ad93

    Comments

    Remove IsNestedWorker()
    
    No longer used after
    https://chromium-review.googlesource.com/1351929.
    
    Bug: 880027
    Change-Id: Ic8e633dca12f60431530f803730286b02927cd3f
    Reviewed-on: https://chromium-review.googlesource.com/c/1350902
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614525}

    Changed files

    • third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h
    • third_party/blink/renderer/core/workers/dedicated_worker_thread.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_thread.h
    • third_party/blink/renderer/core/workers/worker_global_scope.h
  3. Refactor decoder support query utils

    Changed by chcunningham - chcunninghamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:07:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78534522cdb0c3881263661a2aba2606f246bf76

    Comments

    Refactor decoder support query utils
    
    Until now, media/ decoder capabilities were described by
    media/base/decode_capabilities.*. Embedders could override those
    abilities via MediaClient. This meant 2 steps to query for
    what configs were supported
    1) if MediaClient exists, ask it
    2) fallback to functions in decode_capabilites
    
    We have two places where these steps should be followed:
    MimeUtilInternal and WebMediaCapabilitiesClientImpl. Until now,
    only MimeUtilInternal did both.
    
    We anticipate a third caller (when creating FFmpegDemuxerStreams), so
    the time is right to put these two steps into a utility function:
    	bool IsSupported{Audio|Video}Type(...);
    
    This is defined in a new file: media/base/supported_types.h. media/'s
    default capabilities are also described in that file, via
    	bool IsDefaultSupported*Type(...);
    
    This change also renames the struct inputs to these APIs from
    *Config to *Type. *Config was too close to *DecoderConfig and
    *Type is a closer match to the web APIs we're trying to serve
    (IsTypeSupported and CanPlayType).
    
    Change-Id: I5c49d28f3d7ad9e824388cb346369795c3a621f9
    Bug: 911823
    Reviewed-on: https://chromium-review.googlesource.com/c/1361938
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614524}

    Changed files

    • chromecast/renderer/cast_content_renderer_client.cc
    • chromecast/renderer/cast_content_renderer_client.h
    • content/public/renderer/content_renderer_client.cc
    • content/public/renderer/content_renderer_client.h
    • content/renderer/media/render_media_client.cc
    • content/renderer/media/render_media_client.h
    • media/base/BUILD.gn
    • media/base/decode_capabilities.h
    • media/base/key_systems_unittest.cc
    • media/base/media_client.h
    • media/base/media_types.h
    • media/base/mime_util_internal.cc
    • media/base/supported_types.cc
    • media/base/supported_types.h
    • media/base/supported_types_unittest.cc
    • media/blink/webmediacapabilitiesclient_impl.cc
    • media/renderers/audio_renderer_impl_unittest.cc
  4. Update TODO about hiding the main frame RenderWidget when swapping out

    Changed by danakj - danakjohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:07:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc8b1e563f106abfcd3e153bcaf03f3c6a272d81

    Comments

    Update TODO about hiding the main frame RenderWidget when swapping out
    
    Combine 2 TODOs into one explanation about why this is done for main
    frames only (subframes don't need it since we drop the RenderWidget
    when the frame is detached during SwapOut).
    
    R=creis@chromium.org
    
    Change-Id: Ib10c51401994f9a3a6d8270b45eb1006297ecb50
    Bug: 908582
    Reviewed-on: https://chromium-review.googlesource.com/c/1362104
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614523}

    Changed files

    • content/browser/frame_host/render_frame_host_manager.cc
  5. Rename the last vestiges of "SlimmingPaintV2" to "CompositeAfterPaint"

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:06:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10022953931784acabd9033bba08839e8aaa46c6

    Comments

    Rename the last vestiges of "SlimmingPaintV2" to "CompositeAfterPaint"
    
    This patch cleans up a few remaining instances of Slimming Paint V2
    since it has been renamed Composite After Paint.
    
    Bug: 909899
    Change-Id: Ibb09cb7c603b10359ce6e5e954f2c67bd395a906
    Reviewed-on: https://chromium-review.googlesource.com/c/1366257
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614522}

    Changed files

    • cc/layers/layer.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/property_tree.h
    • third_party/blink/web_tests/virtual/composite-after-paint/compositing/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/block/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/borders/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/clip/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/css/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/overflow/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/repaint/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/paint/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/paint/subpixel/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/svg/README.txt
    • tools/metrics/histograms/histograms.xml
  6. Disable standard instrumentation tests on O

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:05:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0183346307f959af42efec29b8ee773c15a8b00c

    Comments

    Disable standard instrumentation tests on O
    
    chrome_public_test_apk and webview_instrumentation_test_apk have always
    failed on O and end up burning a lot of device time with no one actively
    monitoring them or trying to fix them. This combined with the few number
    of devices that have Oreo means that the other tests that run on Oreo
    that are monitored can end up not running due to capacity issues. So,
    disable these tests on Oreo until they're either fixed or more capacity
    is added.
    
    Bug: 884413
    Change-Id: Ica3a501ed078075dfb462f9cbcd7b3f26cb8dcad
    Reviewed-on: https://chromium-review.googlesource.com/c/1366255
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614521}

    Changed files

    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
  7. Plumb the top frame origin of resource requests to the net stack

    Changed by Josh Karlin - jkarlinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:05:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be37f9105bb8760e009c71e61770b514449fe398

    Comments

    Plumb the top frame origin of resource requests to the net stack
    
    In order to experiment with splitting the disk cache by top frame
    origin, we'll need to plumb the top frame origin up to the network stack
    for each resource request.
    
    We're focused on just document subresource requests and navigation
    requests for now because that's the majority of request types and this
    is meant to support an early experiment. We will need to include other
    types of requests (e.g., from workers, or signed exchange redirects)
    later.
    
    Subresources requests (and subframe navigations) don't change the top
    frame origin on redirect. Top frame navigations do however.
    
    Bug: 898855
    Change-Id: I86a1c5a61986d15c445991c4e50482209f051cca
    Reviewed-on: https://chromium-review.googlesource.com/c/1335869
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Josh Karlin <jkarlin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614520}

    Changed files

    • content/browser/devtools/devtools_url_loader_interceptor.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request_info.cc
    • content/browser/frame_host/navigation_request_info.h
    • content/browser/frame_host/navigator_impl_unittest.cc
    • content/browser/loader/navigation_url_loader_impl.cc
    • content/browser/loader/navigation_url_loader_impl_unittest.cc
    • content/browser/loader/navigation_url_loader_unittest.cc
    • content/browser/loader/resource_dispatcher_host_impl.cc
    • content/browser/loader/resource_dispatcher_host_unittest.cc
    • content/browser/navigation_browsertest.cc
    • content/common/service_worker/service_worker_loader_helpers.cc
    • content/common/throttling_url_loader.cc
    • content/renderer/loader/web_url_loader_impl.cc
    • content/renderer/loader/web_url_loader_impl_unittest.cc
    • content/test/data/page_with_iframe_and_image.html
    • headless/test/test_network_interceptor.cc
    • net/url_request/redirect_info.cc
    • net/url_request/redirect_info.h
    • net/url_request/redirect_info_unittest.cc
    • net/url_request/url_request.cc
    • net/url_request/url_request.h
    • net/url_request/url_request_job.cc
    • net/url_request/url_request_unittest.cc
    • services/network/public/cpp/net_ipc_param_traits.h
    • services/network/public/cpp/network_ipc_param_traits.h
    • services/network/public/cpp/resource_request.h
    • services/network/url_loader.cc
    • third_party/blink/public/platform/web_url_loader_client.h
    • third_party/blink/public/platform/web_url_request.h
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/exported/web_document_test.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.h
    • third_party/blink/renderer/platform/exported/web_url_request.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.h
    • third_party/blink/renderer/platform/loader/fetch/resource_request.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_request.h
    • third_party/blink/renderer/platform/loader/fetch/resource_request_test.cc
    • third_party/blink/renderer/platform/testing/weburl_loader_mock.cc
  8. Add BufferedFileWriter class.

    Changed by Erik Jensen - rkjnsnohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:04:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad6a38199aa947ed053a75a19b89172f4a4ee0ba

    Comments

    Add BufferedFileWriter class.
    
    FileOperations::Writer only allows one operation to be pending at a
    time, while chunks from the network will be delivered to
    FileTransferMessageHandler as soon as they arrive. BufferedFileWriter
    will sit between the two and maintain a queue of chunks to be written,
    passing them to the Writer in sequence.
    
    Bug: 679313
    Change-Id: Id10c8d3f34c4811feb373e6cb60f470d2a2a59d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1362455
    Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614519}

    Changed files

    • remoting/host/file_transfer/BUILD.gn
    • remoting/host/file_transfer/buffered_file_writer.cc
    • remoting/host/file_transfer/buffered_file_writer.h
    • remoting/host/file_transfer/buffered_file_writer_unittest.cc
    • remoting/host/file_transfer/fake_file_operations.cc
    • remoting/host/file_transfer/fake_file_operations.h
  9. Import AHardwareBuffer into a Vulkan Image.

    Changed by Vikas Soni - vikassoniohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:04:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8e53d0f70e2e8bc9736e55cacd1bf939efc18da

    Comments

    Import AHardwareBuffer into a Vulkan Image.
    
    Added a utility function to create a vulkan image and import AHardwareBuffer
    created outside of vulkan device into a vulkan image.
    
    Bug: 891060
    Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b
    Reviewed-on: https://chromium-review.googlesource.com/c/1357658
    Commit-Queue: vikas soni <vikassoni@chromium.org>
    Reviewed-by: Eric Karl <ericrk@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614518}

    Changed files

    • components/viz/common/BUILD.gn
    • gpu/vulkan/BUILD.gn
    • gpu/vulkan/android/vulkan_android_unittests.cc
    • gpu/vulkan/android/vulkan_implementation_android.cc
    • gpu/vulkan/android/vulkan_implementation_android.h
    • gpu/vulkan/generate_bindings.py
    • gpu/vulkan/vulkan_function_pointers.cc
    • gpu/vulkan/vulkan_function_pointers.h
    • gpu/vulkan/vulkan_implementation.h
  10. [AF] Add SyncState suffix to some key autofill metrics.

    Changed by sebsg - sebsgohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 119a2fe85a3ae98d60d9e5a5b0837c20cb21bfb3

    Comments

    [AF] Add SyncState suffix to some key autofill metrics.
    
    The suffixes describing the sync state are:
    SignedOut
    SignedIn
    kSignedInAndWalletSyncTransportEnabled
    SignedInAndSyncFeature
    
    The metrics that will have those suffixes are
    Autofill.FormEvents
    Autofill.IsEnabled.PageLoad
    Autofill.SaveCreditCardPrompt
    
    The previous histograms will continue to be logged. This is only
    additional logging.
    
    Bug: 903290
    Change-Id: Ibc96a1db12408f13d40fe75ed9aec96af80eac96
    Reviewed-on: https://chromium-review.googlesource.com/c/1326602
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614517}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_external_delegate_unittest.cc
    • components/autofill/core/browser/autofill_manager.cc
    • components/autofill/core/browser/autofill_manager.h
    • components/autofill/core/browser/autofill_manager_unittest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • components/autofill/core/browser/autofill_metrics_unittest.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
    • components/autofill/core/browser/personal_data_manager_unittest.cc
    • components/autofill/core/browser/sync_utils.h
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • tools/metrics/histograms/histograms.xml
  11. Fuchsia: Use SandboxPolicyFuchsia for context process.

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:03:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60

    Comments

    Fuchsia: Use SandboxPolicyFuchsia for context process.
    
    1. Updated SandboxPolicyFuchsia to support sandbox policy for context
       process.
    2. Updated ContextProviderImpl to use SandboxPolicyFuchsia.
    3. SandboxPolicyFuchsia now provides Vulkan access to Context process.
    
    Bug: 861853
    Change-Id: If0e72e424bbadc0199a1c06e7c27e5df4245c7c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1354563
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614516}

    Changed files

    • services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.cc
    • services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.h
    • services/service_manager/sandbox/sandbox_type.h
    • webrunner/BUILD.gn
    • webrunner/service/context_provider_impl.cc
  12. Fix double-parenting in AXWindowObjWrapper under mash

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:02:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a15d7535017f58556cb996cb75328512d91efe5d

    Comments

    Fix double-parenting in AXWindowObjWrapper under mash
    
    Under mus/mash both the WindowTreeHost's root aura::Window and the content
    aura::Window will return the same Widget for GetWidgetForNativeView(). Only
    return the Widget for the content window, not the root, since otherwise
    we'll end up with two children in the AX node tree that have the same
    parent.
    
    This allows AXAuraWindowUtilsTest to run under views_mus_unittests and
    unblocks some future tests.
    
    Bug: 911945, 911776
    Test: views_unittests, views_mus_unittests
    Change-Id: I554c77e0dca90f1901a42d3331bca0a05e7bbd88
    Reviewed-on: https://chromium-review.googlesource.com/c/1365986
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614515}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/accessibility/ax_window_obj_wrapper.cc
  13. [Fuchsia] Remove the batch limit for net_unittests

    Changed by Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:01:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9de2c414af3dcffebb07593f33da6d4a0815301a

    Comments

    [Fuchsia] Remove the batch limit for net_unittests
    
    Bug: 844416, 847915
    Change-Id: Id9b4d2a330978e81863557665ba0aa66889cc4bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1364079
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614514}

    Changed files

    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/test_suites.pyl
  14. Gives Media Element focus upon mouse iteration.

    Changed by CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:01:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c0284d5fa813c6b993da4ac57a54db665c2b523

    Comments

    Gives Media Element focus upon mouse iteration.
    
    This change makes it such that when a user interacts with the media element
    or its controls,the media element will be given focus. This allows one to use
    the keyboard controls to control the video.
    
    Bug: 827565
    Change-Id: I21a6d5ab2b75aeb3bf646c694eeac62f787c89aa
    Reviewed-on: https://chromium-review.googlesource.com/c/1292814
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614513}

    Changed files

    • third_party/blink/renderer/core/html/media/html_media_element.cc
    • third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
    • third_party/blink/web_tests/fullscreen/full-screen-test.js
    • third_party/blink/web_tests/fullscreen/video-controls-timeline.html
    • third_party/blink/web_tests/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html
    • third_party/blink/web_tests/media/video-controls-mouse-events-captured.html
    • third_party/blink/web_tests/media/video-mouse-focus.html
  15. [IndexedDB] Testing ordering and error handling for transaction.commit

    Changed by Daniel Murphy - dmurphohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:00:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0bd6d5bc0487315bdc89ba96df55b318cadc7b6

    Comments

    [IndexedDB] Testing ordering and error handling for transaction.commit
    
    * Tests that transaction ordering is consistent, even if a transaction
      calls commit().
    * Tests that request errors cause a commit()-ed transaction to abort.
    
    The second case seems to be broken in our implementation.
    
    R=andreasbutler@google.com, cmp@chromium.org
    
    Bug: 911877
    Change-Id: I47da6ce9d350f6c47afcd02cf808d4fefb5f013f
    Reviewed-on: https://chromium-review.googlesource.com/c/1362477
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614512}

    Changed files

    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any-expected.txt
    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.js
    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.worker-expected.txt
  16. Android: Don't create .srcjar for generated version_info file

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:00:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 09e78caaf8a95c230efdd010b1c11a828d7a421d

    Comments

    Android: Don't create .srcjar for generated version_info file
    
    Bug: 908479
    Change-Id: Ibb6192e9c77342b67e0342e724de18c87a021b1f
    Reviewed-on: https://chromium-review.googlesource.com/c/1364611
    Reviewed-by: Paul Miller <paulmiller@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614511}

    Changed files

    • components/version_info/android/BUILD.gn
  17. [ScrollTimeline] Upstream based currentTime tests to WPT

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:59:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 42baeb7ae71e916dc19433ce698de5c02d5fa169

    Comments

    [ScrollTimeline] Upstream based currentTime tests to WPT
    
    This CL starts to upstream the currentTime tests to WPT. To split this
    up, we start with just the 'basic' tests - basic functionality,
    adjusting for time range, and start/end scroll offsets. The writing mode
    and NaN tests will follow in later patches.
    
    There are a few mostly non-behavioral changes to the tests in this CL:
    
      * Some comments were edited for clarity.
      * For tests with more than one assert_equals(), descriptions were
        added to the asserts. This is to help locate failing assert_equal
        lines, as jsharness does not print out the line number of a failure.
      * In a few places we had more than one assert_equals for the same
        scenario (e.g. multiple cases where scroll was after the
        startScrollOffset point). These have been deduplicated.
    
    Bug: 911254
    Change-Id: I783fcf7f43cda876defa9c36db9a0e7dff4e82c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1366297
    Reviewed-by: Yi Gu <yigu@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614510}

    Changed files

    • third_party/blink/web_tests/external/wpt/scroll-animations/current-time.html
    • third_party/blink/web_tests/external/wpt/scroll-animations/resources/scrolltimeline-utils.js
    • third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-currenttime.html
  18. Support using gtest_filter and test-launcher-filter-file together on Android

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:59:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10692b98cca291e29f79fe8df9aae71b1ac452ff

    Comments

    Support using gtest_filter and test-launcher-filter-file together on Android
    
    These args used to be mutually exclusive, which would cause errors when
    retrying the Android network service tests (which use
    --test-launcher-filter-file). This combines the filters specified in the
    filter file with the gtest_filter argument.
    
    See here for an example of a failure:
    https://chromium-swarm.appspot.com/task?id=41984d0ac388e010
    
    Bug: 880915
    Change-Id: I2fee107d13c44bd90cd9532bcabda4bb12f7e111
    Reviewed-on: https://chromium-review.googlesource.com/c/1364071
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614509}

    Changed files

    • build/android/pylib/utils/test_filter.py
    • build/android/pylib/utils/test_filter_test.py
  19. Android: cleaning up some Proguard flags

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:58:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a48fa4727e3291b992bd9e7f30e69f6112392493

    Comments

    Android: cleaning up some Proguard flags
    
    Making these keep rules more explicit.
    
    Bug: 887942
    Change-Id: I70038c8c58025892a7003fad5bb3ff83384f13f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1366262
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614508}

    Changed files

    • chrome/android/java/proguard.flags
  20. [M72] Add tooltip on Save card prompt to explain saving the card to

    Changed by Jason Guo - jiahuiguoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:58:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a4e41ee265aa46f1c650cd1c8bdaf84b166c32b

    Comments

    [M72] Add tooltip on Save card prompt to explain saving the card to
    Google Account in Butter mode.
    
    
    BUG: 905393
    Change-Id: I71eca987c5e2d865efbd6bc00b6212b160f5ea3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1357634
    Reviewed-by: Evan Stade <estade@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Jason Guo <jiahuiguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614507}

    Changed files

    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
    • components/autofill_strings.grdp
  21. Also considering about:srcdoc in url::Origin::Resolve.

    Changed by Lukasz Anforowicz - lukaszaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:57:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b309508508f232e7a91aa34891f652313afa7840

    Comments

    Also considering about:srcdoc in url::Origin::Resolve.
    
    about:srcdoc inherits the origin of its parent frame (similarly to
    about:blank).  Therefore url::Origin::Resolve should also consider
    about:srcdoc.
    
    Bug: 911683
    Change-Id: I114cdd21ff5b317c38cd50e648a16fb0879ceed9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361284
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614506}

    Changed files

    • url/origin.cc
    • url/origin_unittest.cc
  22. Add doodle sharing to local NTP. Sharing consists of a sharing button and a sharing dialog box. Also includes browser tests.

    Changed by David Lu - davidluphdohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 00:57:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c81cefa5985be68912e54cfbd5a3d8467b25f2ce

    Comments

    Add doodle sharing to local NTP. Sharing consists of a sharing button and a sharing dialog box. Also includes browser tests.
    
    Bug:896461
    
    -Enable using the Google local NTP -> Enabled
    -Enable doodles on the local NTP -> Enabled
    -?force-doodle=0 (for simple) or ?force-doodle=1 (for animated)
    
    Test: Set the following flags in chrome://flags:
    Change-Id: If900a18e2cada746132d894aa104f273f914bd90
    Reviewed-on: https://chromium-review.googlesource.com/c/1330356
    Reviewed-by: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: David Lu <davidluphd@google.com>
    Cr-Commit-Position: refs/heads/master@{#614505}

    Changed files

    • chrome/browser/resources/local_ntp/icons/close.svg
    • chrome/browser/resources/local_ntp/icons/copy.svg
    • chrome/browser/resources/local_ntp/icons/facebook.svg
    • chrome/browser/resources/local_ntp/icons/mail.svg
    • chrome/browser/resources/local_ntp/icons/twitter.svg
    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/resources/local_ntp/local_ntp.js
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
    • components/search_provider_logos/google_logo_api.cc
    • components/search_provider_logos/logo_cache.cc
    • components/search_provider_logos/logo_common.h
  23. cros: Remove the touchable app context menu flag.

    Changed by Alex Newcomer - newcomerohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0cb7753a7379fe8910ea1dda4d70915f45f4e5e

    Comments

    cros: Remove the touchable app context menu flag.
    
    The feature has been enabled by default, so remove the flag.
    
    Bug: 906684
    Change-Id: I0ea6f282ef1054c1098fbb8b9fd4b537088db74b
    Reviewed-on: https://chromium-review.googlesource.com/c/1351752
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614504}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  24. Navi Onboarding: fix double-recording Welcome.SigninPrompt

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:56:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9dfaf94c590c701314cb691deb74eb194468930c

    Comments

    Navi Onboarding: fix double-recording Welcome.SigninPrompt
    
    Welcome.SigninPrompt was doubly recorded because during onboarding we
    sometimes redirect users back to the welcome page. This CL fixes the issue
    by detecting if the welcome page instance is a redirected impression, and
    skip recording SigninPrompt if so.
    
    Bug: 905785
    Change-Id: Iff60b8813ee8a1f6c1f2eb3887b32356a5e3e00e
    Reviewed-on: https://chromium-review.googlesource.com/c/1362199
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614503}

    Changed files

    • chrome/browser/ui/webui/welcome/welcome_handler.cc
    • chrome/browser/ui/webui/welcome/welcome_handler.h