Builder ToTAndroidASan Build 1836

Results:

Experimental Failure provision_devices Failure Uncaught Exception

Trigger Info:

Project	chromium
Revision	326963de5e146bec1030263c5fdff221866120fd
Got Revision	326963de5e146bec1030263c5fdff221866120fd

Execution:

• Source: Task 4284b9f39d1fab10
• Bot: gce-trusty-32-0258d129-us-west1-c-mcd3
• Recipe: chromium

Steps and Logfiles:

Show: Expanded Default Non-Green

1. ( 384 ms ) setup_build

   running recipe: "chromium"
   • stdout
   • run_recipe
2. ( 842 ms ) report builders

    

   running builder/tester 'ToTAndroidASan' on master 'chromium.clang'
   • stdout
   • bots.json
3. ( 4 mins 21 secs ) bot_update

   [133GB/590GB used (22%)]
   • stdout
   • json.output
4. ( 1 secs ) swarming.py --version

   0.14
   • stdout
5. ( 19 mins 10 secs ) gclient runhooks
   • stdout
6. ( 2 secs ) get compile targets for scripts
   • stdout
   • json.output
7. ( 1 secs ) read test spec (chromium.clang.json)

   path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.clang.json
   • stdout
   • json.output
8. ( 2 mins 8 secs ) clean local files
   • stdout
   • python.inline
9. ( 97 ms ) tree truth steps
   • stdout
10. ( 585 ms ) lookup GN args

     

    clang_use_chrome_plugins = false

    is_asan = true

    is_clang = true

    is_component_build = true

    is_debug = true

    llvm_force_head_revision = true

    strip_debug_info = true

    symbol_level = 1

    target_os = "android"
    • stdout
11. ( 28 secs ) generate_build_files
    • stdout
12. ( 1 secs ) clang_revision
    • stdout
    • json.output
13. ( 2 hrs 23 mins ) compile
    • stdout
14. ( 4 secs ) compile confirm no-op
    • stdout
15. ( 9 secs ) upload_ninja_log
    • stdout
16. ( 455 ms ) create adb symlink
    • stdout
17. ( 497 ms ) spawn_logcat_monitor
    • stdout
18. ( 500 ms ) spawn_device_monitor
    • stdout
19. ( 3 secs ) authorize_adb_devices
    • stdout
20. ( 3 secs ) device_recovery
    • stdout
21. ( 616 ms ) provision_devices
    • stdout
22. ( 1 ms ) Uncaught Exception

    Infra Failure: Step('provision_devices') returned 87
    • exception
23. ( 0 ) Failure reason
    • reason

Build Properties:

Name	Value	Source
$recipe_engine/path	{"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"}	setup_build
$recipe_engine/runtime	{"is_experimental": true, "is_luci": true}	setup_build
bot_id	"gce-trusty-32-0258d129-us-west1-c-mcd3"	setup_build
branch	"refs/heads/master"	setup_build
buildbucket	{"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1547998619604350, "id": "8923799515408517600", "project": "chromium", "tags": ["builder:ToTAndroidASan", "buildset:commit/git/326963de5e146bec1030263c5fdff221866120fd", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/326963de5e146bec1030263c5fdff221866120fd", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9089229577525052880", "scheduler_job_id:chromium/ToTAndroidASan", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"}	setup_build
buildername	"ToTAndroidASan"	setup_build
buildnumber	1836	setup_build
mastername	"chromium.clang"	setup_build
path_config	"generic"	setup_build
perf_dashboard_machine_group	"ChromiumClang"	setup_build
recipe	"chromium"	setup_build
repository	"https://chromium.googlesource.com/chromium/src.git"	setup_build
revision	"326963de5e146bec1030263c5fdff221866120fd"	setup_build
got_angle_revision	"7403dd2cd3764fe96660fe09892e764e9ae1dbca"	bot_update
got_buildtools_revision	"2f02e1f363b1af2715536f38e239853f04ec1497"	bot_update
got_dawn_revision	"850c0d9aec6bd3f63cb58ff1838380efc112279a"	bot_update
got_nacl_revision	"ff15c51d20785fa51c0ef03ccb480b87299acbeb"	bot_update
got_revision	"326963de5e146bec1030263c5fdff221866120fd"	bot_update
got_revision_cp	"refs/heads/master@{#624490}"	bot_update
got_swarming_client_revision	"0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54"	bot_update
got_v8_revision	"49d3755f33eb8f2e44b2da7ba21556429d6b2493"	bot_update
got_v8_revision_cp	"refs/heads/7.3.451@{#1}"	bot_update
got_webrtc_revision	"74ba99062c48b278675cfe52643719202296fddc"	bot_update
got_webrtc_revision_cp	"refs/heads/master@{#26298}"	bot_update
got_clang_revision	"351686"	clang_revision

Blamelist:

1. Tetsui Ohkubo (tetsuiohnoyoudont@chromium.org)
2. Pavel Shmakov (pshmakovohnoyoudont@google.com)
3. Leon Han (leon.hanohnoyoudont@intel.com)
4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
5. Andrey Lushnikov (lushnikovohnoyoudont@chromium.org)
6. Prashant Malani (pmalaniohnoyoudont@chromium.org)
7. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
8. Mike Reed (reedohnoyoudont@google.com)
9. Paul Miller (paulmillerohnoyoudont@google.com)
10. Avi Drissman (aviohnoyoudont@chromium.org)
11. Xing Liu (xingliuohnoyoudont@chromium.org)
12. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
13. Christopher Cameron (ccameronohnoyoudont@chromium.org)
14. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
15. edchin (edchinohnoyoudont@chromium.org)
16. Wez (wezohnoyoudont@chromium.org)

Timing:

Create	Sunday, 20-Jan-19 15:36:59 UTC
Start	Sunday, 20-Jan-19 15:37:41 UTC
End	Sunday, 20-Jan-19 18:28:37 UTC
Pending	41 secs
Execution	2 hrs 50 mins

All Changes:

1. StaticKCM: Add layout_change to Wayland extension

   Changed by	Tetsui Ohkubo - tetsuiohnoyoudont@chromium.org
   Changed at	Sunday, 20-Jan-19 14:31:43 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	326963de5e146bec1030263c5fdff221866120fd

   Comments

   StaticKCM: Add layout_change to Wayland extension
   
   This CL adds layout_change event to keyboard_device_configuration
   non-standard Wayland interface.
   
   Currently XKB text configuration is dynamically sent through standard
   wl_keyboard interface and it's converted to Android's KCM at runtime.
   StaticKCM changes this to use statically generated KCM files.
   
   Design doc: go/arc-static-kcm-converter
   
   a WIP CL that sends a layout name using this definition is here:
   https://crrev.com/c/1411098
   
   TEST=manual
   BUG=b:122704772
   
   Change-Id: I69e78cc773d7b8a6262d715854bc19bd2612c384
   Reviewed-on: https://chromium-review.googlesource.com/c/1411353
   Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
   Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
   Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624490}

   Changed files

   • third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml

2. Force show controls when transitioning to reader mode

   Changed by	Pavel Shmakov - pshmakovohnoyoudont@google.com
   Changed at	Sunday, 20-Jan-19 13:41:00 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	74f3079e4f3a6c9360bf8b336e0b0b456b24254d

   Comments

   Force show controls when transitioning to reader mode
   
   Reader mode used to rely on (incorrect) skipping of initial offset
   update coming from RenderWidgetHostViewAndroid. This skipping was
   causing bugs elsewhere, so it was removed, reintroducing the problem
   with the reader mode. The full story can be traced back in
   https://crbug.com/825765, https://crbug.com/853686,
   https://crbug.com/861618.
   
   Here I propose a workaround that targets the reader mode specifically,
   without risking to break things elsewhere.
   
   Bug: 922388
   Change-Id: Ia60a87f79c03992914594a06f3e688ae37788f70
   Reviewed-on: https://chromium-review.googlesource.com/c/1413607
   Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
   Reviewed-by: Matthew Jones <mdjones@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624489}

   Changed files

   • chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java

3. [OnionSoup] Replace WebConsoleMessage::Level with mojom::ConsoleMessageLevel

   Changed by	Leon Han - leon.hanohnoyoudont@intel.com
   Changed at	Sunday, 20-Jan-19 12:43:18 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	797b2134e2eddbd219df5c20346d4ca2db8b81f9

   Comments

   [OnionSoup] Replace WebConsoleMessage::Level with mojom::ConsoleMessageLevel
   
   This CL
     - removes the nested enum definition WebConsoleMessage::Level, uses
       the mojom one mojom::ConsoleMessageLevel instead everywhere.
     - moves blink/public/web/console_message.mojom into
       blink/public/mojom/devtools/, makes it be able to be used from
       blink/public/mojom/ in the future.
   
   BUG=789854
   
   Change-Id: I94b2b4909b45d83b78c0e03918554813bc97767b
   Reviewed-on: https://chromium-review.googlesource.com/c/1420299
   Commit-Queue: Leon Han <leon.han@intel.com>
   Reviewed-by: Lei Zhang <thestig@chromium.org>
   Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
   Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
   Reviewed-by: Evan Stade <estade@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624488}

   Changed files

   • chrome/common/browser_controls_state_param_traits.h
   • chrome/renderer/chrome_content_renderer_client.cc
   • chrome/renderer/chrome_render_frame_observer.cc
   • chrome/renderer/extensions/resource_request_policy.cc
   • components/autofill/content/renderer/form_cache.cc
   • components/autofill/content/renderer/page_form_analyser_logger.h
   • components/printing/renderer/print_render_frame_helper.cc
   • content/browser/service_worker/embedded_worker_instance.cc
   • content/browser/service_worker/embedded_worker_instance.h
   • content/browser/service_worker/embedded_worker_instance_unittest.cc
   • content/browser/service_worker/embedded_worker_test_helper.cc
   • content/browser/service_worker/embedded_worker_test_helper.h
   • content/browser/service_worker/service_worker_new_script_loader.cc
   • content/browser/service_worker/service_worker_version.cc
   • content/browser/service_worker/service_worker_write_to_cache_job.cc
   • content/common/service_worker/embedded_worker.mojom
   • content/renderer/appcache/appcache_frontend_impl.cc
   • content/renderer/manifest/manifest_manager.cc
   • content/renderer/pepper/host_globals.cc
   • content/renderer/pepper/ppb_graphics_3d_impl.cc
   • content/renderer/render_frame_impl.cc
   • content/renderer/renderer_webapplicationcachehost_impl.cc
   • content/renderer/service_worker/embedded_worker_instance_client_impl.cc
   • content/renderer/service_worker/embedded_worker_instance_client_impl.h
   • content/shell/test_runner/web_frame_test_client.cc
   • third_party/blink/public/BUILD.gn
   • third_party/blink/public/mojom/BUILD.gn
   • third_party/blink/public/mojom/devtools/console_message.mojom
   • third_party/blink/public/public_typemaps.gni
   • third_party/blink/public/web/console_message.mojom
   • third_party/blink/public/web/console_message.typemap
   • third_party/blink/public/web/console_message_struct_traits.cc
   • third_party/blink/public/web/console_message_struct_traits.h
   • third_party/blink/public/web/web_console_message.h
   • third_party/blink/renderer/core/frame/web_local_frame_impl.cc
   • third_party/blink/renderer/core/inspector/console_message.cc
   • third_party/blink/renderer/core/page/chrome_client_impl.cc
   • third_party/blink/renderer/core/page/viewport_test.cc
   • third_party/blink/renderer/modules/exported/web_embedded_worker_impl.cc

4. Roll src/third_party/skia 66e184425565..7d81f6fd6f9b (1 commits)

   Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
   Changed at	Sunday, 20-Jan-19 07:10:57 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	c3afd9db0cadc4cdd185fa7afef5d16f1d2eb6d9

   Comments

   Roll src/third_party/skia 66e184425565..7d81f6fd6f9b (1 commits)
   
   https://skia.googlesource.com/skia.git/+log/66e184425565..7d81f6fd6f9b
   
   
   git log 66e184425565..7d81f6fd6f9b --date=short --no-merges --format='%ad %ae %s'
   2019-01-20 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset
   
   
   Created with:
     gclient setdep -r src/third_party/skia@7d81f6fd6f9b
   
   The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
   
   If the roll is causing failures, please contact the current sheriff, who should
   be CC'd on the roll, and stop the roller if necessary.
   
   CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
   TBR=djsollen@chromium.org
   
   Change-Id: I8d7ab77229bc95889f4c4fe7365b88c030264dba
   Reviewed-on: https://chromium-review.googlesource.com/c/1424258
   Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
   Cr-Commit-Position: refs/heads/master@{#624487}

   Changed files

   • DEPS

5. DevTools: addScriptToEvaluateOnNewDocument should work with disabled javascript

   Changed by	Andrey Lushnikov - lushnikovohnoyoudont@chromium.org
   Changed at	Sunday, 20-Jan-19 07:07:17 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	e0e2d7091d2fdb276e13c3e1180d1eff83f810d1

   Comments

   DevTools: addScriptToEvaluateOnNewDocument should work with disabled javascript
   
   R=dgozman
   BUG=923670
   
   Change-Id: Ic6d3a575dad005c52e9a734322cdb0e49aaf6b5a
   Reviewed-on: https://chromium-review.googlesource.com/c/1423747
   Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
   Auto-Submit: Andrey Lushnikov <lushnikov@chromium.org>
   Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624486}

   Changed files

   • third_party/blink/renderer/core/inspector/inspector_page_agent.cc
   • third_party/blink/renderer/core/loader/frame_loader.cc
   • third_party/blink/web_tests/inspector-protocol/page/add-script-to-evaluate-on-load-disabled-js-expected.txt
   • third_party/blink/web_tests/inspector-protocol/page/add-script-to-evaluate-on-load-disabled-js.js

6. Add histograms for Smart Dim ML service calls

   Changed by	Prashant Malani - pmalaniohnoyoudont@chromium.org
   Changed at	Sunday, 20-Jan-19 06:57:26 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	42d3bd6995b12e00320f7bdc404816d324c01a66

   Comments

   Add histograms for Smart Dim ML service calls
   
   Bug: 893425
   Test: Builds successfully.
   
   Change-Id: I774f1e52f2111fffa13fb2a5d64427ecedc9591f
   Reviewed-on: https://chromium-review.googlesource.com/c/1419266
   Auto-Submit: Prashant Malani <pmalani@chromium.org>
   Reviewed-by: Jesse Doherty <jwd@chromium.org>
   Reviewed-by: Andrew Moylan <amoylan@chromium.org>
   Reviewed-by: Jia Meng <jiameng@chromium.org>
   Commit-Queue: Prashant Malani <pmalani@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624485}

   Changed files

   • tools/metrics/histograms/histograms.xml

7. Updating trunk VERSION from 3678.0 to 3679.0

   Changed by	chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
   Changed at	Sunday, 20-Jan-19 04:10:27 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	ac7eccb32027d854536717a0eb589f3784037428

   Comments

   Updating trunk VERSION from 3678.0 to 3679.0
   
   # This is an automated release commit.
   # Do not revert without consulting chrome-pmo@google.com.
   NOAUTOREVERT=true
   TBR=govind@chromium.org
   
   Change-Id: Ibb7e15ab616701cb8ae8632b164552ef8eac4ae7
   Reviewed-on: https://chromium-review.googlesource.com/c/1422963
   Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624484}

   Changed files

   • chrome/VERSION

8. fix typo from prev refactor -- hinting is on font

   Changed by	Mike Reed - reedohnoyoudont@google.com
   Changed at	Sunday, 20-Jan-19 02:35:41 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	08bdd0605e5e93030faacefaf4d7a7f4bab17d14

   Comments

   fix typo from prev refactor -- hinting is on font
   
   ... and IWYU
   Preparation for https://skia-review.googlesource.com/c/skia/+/185460
   
   TBR=
   
   Bug: skia:2664
   Change-Id: I9379ad69c3e7baabf736dd2e7d2c285eb81d43b4
   Reviewed-on: https://chromium-review.googlesource.com/c/1423627
   Reviewed-by: Florin Malita <fmalita@chromium.org>
   Commit-Queue: Mike Reed <reed@google.com>
   Cr-Commit-Position: refs/heads/master@{#624483}

   Changed files

   • chrome/renderer/pepper/pepper_flash_renderer_host.cc
   • third_party/blink/public/platform/web_font_render_style.h
   • third_party/blink/renderer/platform/fonts/font_metrics.cc
   • third_party/blink/renderer/platform/fonts/simple_font_data.cc
   • ui/gfx/render_text_harfbuzz.cc

9. WebView: Activate AndroidWebViewSessionConsistencyTest

   Changed by	Paul Miller - paulmillerohnoyoudont@google.com
   Changed at	Sunday, 20-Jan-19 02:35:38 UTC
   Repository	https://chromium.googlesource.com/chromium/src
   Branch
   Revision	7ceb27aaaf6fe73e7902c88ce2bd032edc78ec49

   Comments

   WebView: Activate AndroidWebViewSessionConsistencyTest
   
   This study doesn't do anything except exercise session-consistency.
   Query it once to "activate" it, so it shows up in the logs when
   WebViewLogVerbosifier.apk is installed, so QA can verify
   permanent-consistency.
   
   BUG=866722
   
   Change-Id: I435b6ed5c93e105ebb49705078f4362eb46e109b
   Reviewed-on: https://chromium-review.googlesource.com/c/1423837
   Commit-Queue: Changwan Ryu <changwan@chromium.org>
   Reviewed-by: Changwan Ryu <changwan@chromium.org>
   Cr-Commit-Position: refs/heads/master@{#624482}

   Changed files

   • android_webview/browser/aw_feature_list_creator.cc

10. Alphabetize the flag.json file.

    Changed by	Avi Drissman - aviohnoyoudont@chromium.org
    Changed at	Sunday, 20-Jan-19 02:34:34 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7303b44ce364ca00c805bedbcf6a6843688a934a

    Comments

    Alphabetize the flag.json file.
    
    I accidentally allowed an entry at the end and didn't notice it being
    commented out. Fixing.
    
    BUG=none
    TBR=ellyjones@chromium.org
    
    Change-Id: I320d7515a94612bc69003adf5617abf2adafcbb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1423600
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624481}

    Changed files

    • chrome/browser/flag-metadata.json

11. Adds a feature flag for foreground notification manager.

    Changed by	Xing Liu - xingliuohnoyoudont@chromium.org
    Changed at	Sunday, 20-Jan-19 02:34:18 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	7d57dd38a90a426d78e9f2303fb5544c2a8ec00f

    Comments

    Adds a feature flag for foreground notification manager.
    
    This CL adds a feature flag for the new foreground notification manager
    system.
    
    Bug: 916659
    Change-Id: I9e0fc128a9b094ec438e3c0efcd9da50baa9e15a
    Reviewed-on: https://chromium-review.googlesource.com/c/1389440
    Commit-Queue: Xing Liu <xingliu@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624480}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/android/chrome_feature_list.cc
    • chrome/browser/android/chrome_feature_list.h
    • chrome/browser/flag-metadata.json
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • tools/metrics/histograms/enums.xml

12. DocumentLoader: make srcdoc navigations async (attempt #2)

    Changed by	Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at	Sunday, 20-Jan-19 02:33:15 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6899796671705603bab3ee6eefd21ac385ca9bc8

    Comments

    DocumentLoader: make srcdoc navigations async (attempt #2)
    
    about:srcdoc is not actually an empty document, so there is no real need
    to load it synchronously.
    
    data-saver.html is split in two, because it relied on specific order
    between calling internals.setSaveDataEnabled and committing navigation
    for two separate srcdoc iframes.
    
    Includes the following fixes comparing to attempt #1:
    
    1. When script removes iframe's srcdoc attribute after the navigation
    has been scheduled, but before we retrieve the srcdoc content from
    the attribute, we could try to load about:srcdoc from the network.
    Instead, we should just load an empty document.
    
    2. Iframe with src="about:srcdoc" should just load blank instead
    of issuing a network request for about:srcdoc.
    
    3. Simplify how we pass "is srcdoc" to the document
    itself, now using DocumentInit instead of calling a method on
    FrameLoader. This avoids a similar race between starting the main
    resource load and creating a document.
    
    Bug: 919839, 855189
    Change-Id: Ie5a9cbcf66ab93b9deea09ee8e756d10e48c741b
    Reviewed-on: https://chromium-review.googlesource.com/c/1409809
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624479}

    Changed files

    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document_init.cc
    • third_party/blink/renderer/core/dom/document_init.h
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/document_loader.h
    • third_party/blink/renderer/core/loader/frame_loader.cc
    • third_party/blink/renderer/core/loader/frame_loader.h
    • third_party/blink/web_tests/http/tests/fetch/chromium/data-saver-enabled.html
    • third_party/blink/web_tests/http/tests/fetch/chromium/data-saver.html
    • third_party/blink/web_tests/http/tests/navigation/srcdoc-as-src-expected.txt
    • third_party/blink/web_tests/http/tests/navigation/srcdoc-as-src.html
    • third_party/blink/web_tests/http/tests/navigation/srcdoc-attribute-reset-expected.txt
    • third_party/blink/web_tests/http/tests/navigation/srcdoc-attribute-reset.html

13. Disable app shim signature check

    Changed by	Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at	Sunday, 20-Jan-19 02:33:11 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	add2f7a11d13cf857b95ccb575afcd5d66690532

    Comments

    Disable app shim signature check
    
    App shims aren't starting on 73.0.3677.0.
    
    TBR=sdy
    
    Bug: 624228
    Change-Id: Ied8fdac4986b61db99333527b118f319d808d5c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1424159
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624478}

    Changed files

    • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

14. Roll src/third_party/skia 60bff2366ee7..66e184425565 (1 commits)

    Changed by	chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at	Sunday, 20-Jan-19 02:32:10 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	1d3dead200d2b2297247fed3c16e2a56209d7b84

    Comments

    Roll src/third_party/skia 60bff2366ee7..66e184425565 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/60bff2366ee7..66e184425565
    
    
    git log 60bff2366ee7..66e184425565 --date=short --no-merges --format='%ad %ae %s'
    2019-01-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3ff6f8afb698..b1e66fcbbc89 (287 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/skia@66e184425565
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=halcanary@chromium.org
    
    Change-Id: I732a1cef02d06d64fb0486ff89c64bc25512851f
    Reviewed-on: https://chromium-review.googlesource.com/c/1424002
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#624477}

    Changed files

    • DEPS

15. [ios] Refactor tab printing

    Changed by	edchin - edchinohnoyoudont@chromium.org
    Changed at	Sunday, 20-Jan-19 02:32:06 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	be8d2b21137bfcfb5a4e376447a5568c74f1e554

    Comments

    [ios] Refactor tab printing
    
    This CL does the following:
    
    1) Removes printing code from BVC because it is not necessary there.
    This is accomplished by directly connecting the PrintTabHelper to the
    PrintController, which presents the system print dialog. Previously,
    it was going through the BVC as an intermediary.
    
    2) PrintTabHelper creation is moved to AttachTabHelpers() where it belongs.
    This splits setting the printer delegate from the tab helper creation. This
    is the preferred structure.
    
    This CL moves the print code in the right direction. In the future,
    PrintController should be renamed and refactored as a coordinator.
    
    Bug: 910017
    Change-Id: Ifd21f9959d2926c9b8f661f71f22eb0b73f96dd4
    Reviewed-on: https://chromium-review.googlesource.com/c/1419538
    Commit-Queue: edchin <edchin@chromium.org>
    Auto-Submit: edchin <edchin@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624476}

    Changed files

    • ios/chrome/browser/tabs/tab_helper_util.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/main/BUILD.gn
    • ios/chrome/browser/ui/main/browser_coordinator.mm
    • ios/chrome/browser/ui/print/BUILD.gn
    • ios/chrome/browser/ui/print/print_controller.h
    • ios/chrome/browser/ui/print/print_controller.mm
    • ios/chrome/browser/web/print_tab_helper.h
    • ios/chrome/browser/web/print_tab_helper.mm

16. Revert "Roll src-internal 9eb5076ed0c1..187f3372e0fd (1 commits)"

    Changed by	Wez - wezohnoyoudont@chromium.org
    Changed at	Sunday, 20-Jan-19 02:06:07 UTC
    Repository	https://chromium.googlesource.com/chromium/src
    Branch
    Revision	6c49fd1e649efd1a0f5c721cdbcf998160b68748

    Comments

    Revert "Roll src-internal 9eb5076ed0c1..187f3372e0fd (1 commits)"
    
    This reverts commit b1e66fcbbc8966733e6ecd02debcf9807625e1d7.
    
    Reason for revert: Appeared to break win32-rel compilation (see https://crbug.com/923692).
    
    Original change's description:
    > Roll src-internal 9eb5076ed0c1..187f3372e0fd (1 commits)
    > 
    > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9eb5076ed0c1..187f3372e0fd
    > 
    > 
    > Created with:
    >   gclient setdep -r src-internal@187f3372e0fd
    > 
    > The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    > 
    > Documentation for the AutoRoller is here:
    > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    > 
    > If the roll is causing failures, please contact the current sheriff, who should
    > be CC'd on the roll, and stop the roller if necessary.
    > 
    > 
    > TBR=mmoss@chromium.org
    > 
    > Change-Id: I23aa116ccecf7b13eb6bf793a42475cd68555de0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1424000
    > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    > Cr-Commit-Position: refs/heads/master@{#624474}
    
    TBR=mmoss@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com
    
    Change-Id: Ib583d254068b247438f05f0e5bbde478416eea76
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1423923
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#624475}

    Changed files

    • DEPS