Home | Search | chromium - Builders
Login

Builder ToTAndroidASan Build 1197 Canonical Ubuntu

Results:

Experimental

Trigger Info:

Projectchromium
Revision0edcdf14a29397ba43d8e303bcf01f04705ed95e

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    coordinator: no such stream

Build Properties:

NameValueSource

Blamelist:

  1. Alan Cutter (alancutterohnoyoudont@chromium.org)
  2. Christopher Cameron (ccameronohnoyoudont@chromium.org)
  3. Peter Kotwicz (pkotwiczohnoyoudont@chromium.org)
  4. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  5. Shu Chen (shuchenohnoyoudont@google.com)
  6. Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  7. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  8. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. maxmorin (maxmorinohnoyoudont@chromium.org)
  10. Charles Zhao (charleszhaoohnoyoudont@chromium.org)
  11. Alan Cutter (alancutterohnoyoudont@chromium.org)
  12. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  13. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
  14. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  15. Li Lin (llinohnoyoudont@chromium.org)
  16. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  17. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  18. Sam McNally (sammcohnoyoudont@chromium.org)
  19. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  20. Adam Rice (riceaohnoyoudont@chromium.org)
  21. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  22. Madeleine Barowsky (mbarowskyohnoyoudont@chromium.org)
  23. Aleks Totic (atoticohnoyoudont@chromium.org)
  24. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  25. Justin DeWitt (dewittjohnoyoudont@chromium.org)
  26. Eugene But (eugenebutohnoyoudont@google.com)
  27. rbpotter (rbpotterohnoyoudont@chromium.org)
  28. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  29. Scott Chen (scottchenohnoyoudont@chromium.org)
  30. Darren Shen (shendohnoyoudont@chromium.org)
  31. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  32. Reilly Grant (reillygohnoyoudont@google.com)
  33. Clark DuVall (cduvallohnoyoudont@chromium.org)
  34. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  35. Kyle Horimoto (khorimotoohnoyoudont@chromium.org)
  36. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  37. Victor Vasiliev (vasilvvohnoyoudont@chromium.org)
  38. Leon Han (leon.hanohnoyoudont@intel.com)
  39. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  40. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  41. Eric Willigers (ericwilligersohnoyoudont@chromium.org)
  42. John Budorick (jbudorickohnoyoudont@chromium.org)
  43. liberato@chromium.org (liberatoohnoyoudont@chromium.org)
  44. Ryan Hansberry (hansberryohnoyoudont@chromium.org)
  45. Mohsen Izadi (mohsenohnoyoudont@chromium.org)
  46. Matthew Mourgos (mmourgosohnoyoudont@chromium.org)
  47. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  48. Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
  49. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  50. Nigel Tao (nigeltaoohnoyoudont@chromium.org)
  51. Kent Tamura (tkentohnoyoudont@chromium.org)
  52. Dan Beam (dbeamohnoyoudont@chromium.org)
  53. chrome-release-bot (chrome-release-botohnoyoudont@chromium.org)
  54. Takashi Sakamoto (tasakohnoyoudont@google.com)
  55. Takashi Sakamoto (tasakohnoyoudont@google.com)
  56. Dan Beam (dbeamohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 07:17:45 UTC
Start Friday, 07-Dec-18 07:18:30 UTC
End Friday, 07-Dec-18 07:30:00 UTC
Pending 44 secs
Execution 11 mins 29 secs

All Changes:

  1. Revert "Add chrome_proxy.exe target on Windows"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0edcdf14a29397ba43d8e303bcf01f04705ed95e

    Comments

    Revert "Add chrome_proxy.exe target on Windows"
    
    This reverts commit 86e7ed69a96f03ffcbb6af63d632f7951bf34b28.
    
    Reason for revert: Broke Chrome Canary update while the browser is open.
    Bug: 912716
    
    Original change's description:
    > Add chrome_proxy.exe target on Windows
    >
    > This change adds a new executable to Windows called chrome_proxy.exe which
    > opens chrome.exe with all arguments forwarded.
    >
    > In a future patch bookmark app shortcuts will be updated to point to
    > chrome_proxy.exe instead of chrome.exe so they don't pick up the
    > chrome.VisualElementsManifest.xml file when pinned to the Windows 10
    > start menu. This fixes a bug where pinned bookmark app shortcuts all
    > use the Chrome logo instead of their own.
    >
    > Bug: 732357
    > Change-Id: I551093f6f111041b424d30ec3f829fa6a06a265c
    > Reviewed-on: https://chromium-review.googlesource.com/c/1362695
    > Reviewed-by: Greg Thompson <grt@chromium.org>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Commit-Queue: Alan Cutter <alancutter@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614177}
    
    TBR=thestig@chromium.org,alancutter@chromium.org,mgiuca@chromium.org,grt@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    NOPRESUBMIT=TRUE # TBR doesn't apply because this revert touches an OWNERS file.
    
    Bug: 732357
    Change-Id: I73cddef3173e3abc22f8c8c4720d84f9a9069ab1
    Reviewed-on: https://chromium-review.googlesource.com/c/1366471
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614632}

    Changed files

    • chrome/BUILD.gn
    • chrome/chrome_proxy/BUILD.gn
    • chrome/chrome_proxy/OWNERS
    • chrome/chrome_proxy/chrome_proxy.ver
    • chrome/chrome_proxy/chrome_proxy_main_win.cc
    • chrome/installer/mini_installer/BUILD.gn
    • chrome/installer/mini_installer/chrome.release
    • chrome/installer/setup/install_worker.cc
    • chrome/installer/setup/install_worker.h
    • chrome/installer/setup/setup_main.cc
    • chrome/installer/util/util_constants.cc
    • chrome/installer/util/util_constants.h
    • chrome/test/mini_installer/config/chrome_beta_installed.prop
    • chrome/test/mini_installer/config/chrome_canary_installed.prop
    • chrome/test/mini_installer/config/chrome_dev_installed.prop
    • chrome/test/mini_installer/config/chrome_multi_system_installed.prop
    • chrome/test/mini_installer/config/chrome_multi_user_installed.prop
    • chrome/test/mini_installer/config/chrome_system_installed.prop
    • chrome/test/mini_installer/config/chrome_user_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_canary_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_system_installed.prop
    • chrome/test/mini_installer/config/previous_chrome_user_installed.prop
    • chrome/tools/build/win/FILES.cfg
  2. RemoteMacViews: Wire up menu items and shortcut keys

    Changed by Christopher Cameron - ccameronohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 07:00:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c1992d02fa89792498f5e3533772bd65d93973d

    Comments

    RemoteMacViews: Wire up menu items and shortcut keys
    
    For menu items and shortcut keys to work, PWA windows need to have the
    ChromeCommandDispatcherDelegate and BrowserWindowCommandHandler
    structures set on them.
    
    This cannot be done by a method on views_bridge_mac::mojom::
    BridgedNativeWidget, because the structures to be created exist in
    Chrome, which would be a layering violation.
    
    Introduce a method to chrome::mojom::AppShim which takes a widget id,
    creates the ChromeCommandDispatcherDelegate and
    BrowserWindowCommandHandler, and assigns them to the corresponding
    BridgedNativeWidgetImpl.
    
    Bug: 895169
    Change-Id: Ie1d333bec235d7b6101d5b19aa89a74136d54a7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1364210
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614631}

    Changed files

    • chrome/app_shim/app_shim_controller.h
    • chrome/app_shim/app_shim_controller.mm
    • chrome/browser/apps/app_shim/app_shim_host_mac.cc
    • chrome/browser/apps/app_shim/app_shim_host_mac.h
    • chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
    • chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
    • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc
    • chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h
    • chrome/browser/ui/views/frame/browser_frame_mac.mm
    • chrome/common/mac/app_shim.mojom
    • ui/views/cocoa/bridged_native_widget_unittest.mm
    • ui/views/widget/native_widget_mac.h
  3. [Android Tests] Fix several FirstRunIntegrationTests

    Changed by Peter Kotwicz - pkotwiczohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:57:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ca54644ff73878027d7903ab3bd6288561e68a8

    Comments

    [Android Tests] Fix several FirstRunIntegrationTests
    
    This CL converts several FirstRunIntegrationTests to JUnit tests and
    re-enables them.
    
    BUG=911316
    
    Change-Id: I7aada68234fe9a5cb25ee3bef29538cec537d49a
    Reviewed-on: https://chromium-review.googlesource.com/c/1362812
    Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
    Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614630}

    Changed files

    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationUnitTest.java
  4. Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:49:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8112997ce464e3fa4ae5ca8e166c7adc1de03e35

    Comments

    Roll src/third_party/skia 309f1deddf8e..f3babcd0afb3 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/309f1deddf8e..f3babcd0afb3
    
    
    git log 309f1deddf8e..f3babcd0afb3 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 sergeyu@chromium.org Reland "Add SkFontMgr implementation for Fuchsia"
    2018-12-07 reed@google.com Revert "Add SkFontMgr implementation for Fuchsia"
    
    
    Created with:
      gclient setdep -r src/third_party/skia@f3babcd0afb3
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: Ieefefb070c45ba63a5efa3872a75e1d4140b5e41
    Reviewed-on: https://chromium-review.googlesource.com/c/1367116
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614629}

    Changed files

    • DEPS
  5. Updates the order of key mappings to match the same as layout rendering in VK.

    Changed by Shu Chen - shuchenohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 06:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65054bfdd84984501e8054b2f96edacc1bab93a9

    Comments

    Updates the order of key mappings to match the same as layout rendering in VK.
    
    The modifier importance priority is: Altgr > Shift > Capslock.
    So if user presses a key with Shift + Altgr + Capslock and the key mapping is not defined for the input method.
    It will fallback to other key mappings in this order:
     - Shift + Altgr
     - Altgr + Capslock
     - Shift + Capslock
     - Altgr
     - Shift
     - Capslock
     - Normal
    
    Bug: 910049
    Change-Id: I3a274ba02671977a075ee27441acf429cf4569cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1356735
    Reviewed-by: Leo Zhang <googleo@chromium.org>
    Commit-Queue: Leo Zhang <googleo@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614628}

    Changed files

    • chromeos/services/ime/public/cpp/rulebased/def/fa.cc
    • chromeos/services/ime/public/cpp/rulebased/def/lo.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_inscript.cc
    • chromeos/services/ime/public/cpp/rulebased/def/ta_phone.cc
    • chromeos/services/ime/public/cpp/rulebased/def/th.cc
  6. Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720

    Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:36:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b38c320095ae37996d50a735f7d2690c9e0eed10

    Comments

    Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720
    
    Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356.
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hbos@chromium.org, hta@chromium.org:
      external/wpt/webrtc
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef
    Reviewed-on: https://chromium-review.googlesource.com/c/1367132
    Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614627}

    Changed files

    • third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
    • third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
    • third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html
  7. Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:31:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b9acb3dea58c30c4a4cd8d251938f66a47c1e

    Comments

    Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs
    
    <meta name="timeout"> is prefereable for WPTs:
    https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout
    
    Bug: 912240
    Change-Id: I3c4a9acb1fb070c34d10f59ff9d3fd3d2bd11afb
    Reviewed-on: https://chromium-review.googlesource.com/c/1366469
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614626}

    Changed files

    • third_party/blink/web_tests/SlowTests
    • third_party/blink/web_tests/external/wpt/worklets/animation-worklet-csp.https.html
    • third_party/blink/web_tests/external/wpt/worklets/audio-worklet-csp.https.html
  8. Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 06:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61e410e3beb88a04880f973dbde7c0099dbdff6

    Comments

    Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5d7bcad36ff4..62ba44ace70c
    
    
    git log 5d7bcad36ff4..62ba44ace70c --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 rmhasan@google.com Adds another verification to the Test expectation parser
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@62ba44ace70c
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:905426
    TBR=sullivan@chromium.org
    
    Change-Id: Ibda0e80cd77c7ecd1434701f064e2f99db1b8307
    Reviewed-on: https://chromium-review.googlesource.com/c/1367099
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614625}

    Changed files

    • DEPS
  9. Activate audio thread hang monitoring when OOP

    Changed by maxmorin - maxmorinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573

    Comments

    Activate audio thread hang monitoring when OOP
    
    Also includes cleaning up the hang monitor:
     * Actually a class!
     * Actually possible to stop the hang monitor!
     * Tests!
     * When OOP, uploads dumps (without crashing). A kill switch is added for this.
     * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA
       histogram.
     * Switch from "tail posting" the periodic task to using RepeatingTimer.
     * Runs on the task scheduler rather than on the browser IO thread.
     * Some suspend/resume code was simplified.
    
    The hang monitor is now owned by the AudioThread implementation.
    
    Extra functionality (such a nuking the audio process in case of a hang)
    is coming later.
    
    Bug: 866442, 905681
    Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518
    Reviewed-on: https://chromium-review.googlesource.com/c/1340264
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Max Morin <maxmorin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614624}

    Changed files

    • content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • media/audio/BUILD.gn
    • media/audio/audio_features.cc
    • media/audio/audio_features.h
    • media/audio/audio_manager.cc
    • media/audio/audio_manager.h
    • media/audio/audio_thread.h
    • media/audio/audio_thread_hang_monitor.cc
    • media/audio/audio_thread_hang_monitor.h
    • media/audio/audio_thread_hang_monitor_unittest.cc
    • media/audio/audio_thread_impl.cc
    • media/audio/audio_thread_impl.h
    • media/audio/test_audio_thread.cc
    • media/audio/test_audio_thread.h
    • services/audio/owning_audio_manager_accessor.cc
  10. TabRanker: Fix Query time logging.

    Changed by Charles Zhao - charleszhaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:26:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6378752b810e6122744cefac544c8d84278dcc71

    Comments

    TabRanker: Fix Query time logging.
    
    
    TabRanker query time logging was landed in this cl:
    https://chromium-review.googlesource.com/c/chromium/src/+/1350445
    
    TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to
    TabManager::GetSortedLifecycleUnits()
    
    But this was wrong on two aspects:
    
    (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(),
        so ChromeOS discards are all skipped.
    
    (2) TabManagerDelegate::Candidate is calling
        lifecycle_unit_->GetSortKey() for inferring sorting,
        Which means TabRanker model won't work for ChromeOS discards.
    
    
    The fix:
    (1) Change TabManager, TabLifecycleUnit back to their previous code,
        which were sorting LifecycleUnits by TabRanker when it's enabled.
    
    (2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in
        TabManager::DiscardTab for query time logging.
    
    Bug: 911474
    
    Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1360471
    Reviewed-by: Christopher Morin <cmtm@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Commit-Queue: Charles . <charleszhao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614623}

    Changed files

    • chrome/browser/resource_coordinator/tab_activity_watcher.cc
    • chrome/browser/resource_coordinator/tab_activity_watcher.h
    • chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
  11. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  12. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline
    
    Currently, if the device is offline, PreviewsEligibilityReason
    records the reason for not showing previews as network quality
    unavailable.
    
    This CL changes it to record the reason as device offline.
    Network quality unavailable reason is now used for only the cases where
    NQE (network quality estimator) reports ECT as Unknown.
    
    Bug: 912725
    Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366835
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml
  13. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused
    
    This field was added before to keep the copy of the bundle around in
    RFHI but not really used any more.
    
    Bug: N/A
    Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365052
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
  14. Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e595fa693a4ef17b348340dbb64cf039c765e9c7

    Comments

    Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10e8db47197f..3e90e0805dd5
    
    
    Created with:
      gclient setdep -r src-internal@3e90e0805dd5
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia59b4d7347cb4c123f7e30d889f30af08e8b39f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1367115
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614619}

    Changed files

    • DEPS
  15. Timer notification UI improvement:

    Changed by Li Lin - llinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:41:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d710a7b3ef59302c00c2e3fe1b00c788310801c6

    Comments

    Timer notification UI improvement:
    
    * Add timer deeplinks for:
      - Stop timer
      - Add time to timer
    * Add "add 1 min to timer" button to timer notification.
    
    Using a feature flag to guard the usage of the deeplink as
    AlarmTimerManager is not fully available yet.
    
    Bug: b:119116816
    Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    Commit-Queue: Li Lin <llin@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614618}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  16. Crostini: migrate persisted paths from Downloads to MyFiles

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:38:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa7bc76e086df2f9428a2d583546f84f81c59d16

    Comments

    Crostini: migrate persisted paths from Downloads to MyFiles
    
    When MyFiles is enabled, check persisted paths in prefs
    and convert paths as needed.
    
    Bug: 911946
    Change-Id: I3931d196f89f31fa2ae95f7e02f9241b25d23524
    Reviewed-on: https://chromium-review.googlesource.com/c/1366458
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614617}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_share_path.cc
    • chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util.h
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc
  17. Update V8 to version 7.3.56.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:30:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61841709892ab7b5fc112c935f62851a2d3831e

    Comments

    Update V8 to version 7.3.56.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/2192eb7f..fd3bdfda
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I21cf598a516538376f34825912d8dd575a2ce058
    Reviewed-on: https://chromium-review.googlesource.com/c/1367111
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614616}

    Changed files

    • DEPS
  18. Add support for returning URLs from SelectFileDialogs.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:21:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 53fe68888c1b3e844195142b6ddba163bab85cd9

    Comments

    Add support for returning URLs from SelectFileDialogs.
    
    On ChromeOS, filesystem provider-provided files should be accessed via
    an externalfile URL. Further, hosted gdocs should be redirected to their
    URLs. Currently, this is handled within Browser.
    
    Add a |url| field to SelectedFileInfo to allow communicating these
    values from the dialog to Browser to avoid needing to leak this into
    Browser. Migrate this special-casing into the existing handling of
    SelectFileDialog results on ChromeOS, populating the |url| there.
    
    Bug: 843881
    Change-Id: I9808cdbf38fb4da26b99c8a45f8bda4fd0bee9a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1360812
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614615}

    Changed files

    • chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.h
    • chrome/browser/ui/browser.cc
    • ui/file_manager/integration_tests/file_manager/file_dialog.js
    • ui/shell_dialogs/BUILD.gn
    • ui/shell_dialogs/selected_file_info.cc
    • ui/shell_dialogs/selected_file_info.h
  19. Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:10:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b87d9e9516460c683b698bb569d85ed8a9fd7348

    Comments

    Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/17af1e818981..8e13fe5e8564
    
    
    git log 17af1e818981..8e13fe5e8564 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jchinlee@chromium.org Surface lxml for use via vpython.
    
    
    Created with:
      gclient setdep -r src/native_client@8e13fe5e8564
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:912379
    TBR=mseaborn@chromium.org
    
    Change-Id: I53ddc48b5935ca8ea3f5bd8a44d39a43341edb2a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366881
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614614}

    Changed files

    • DEPS
  20. Remove EncodingStreams runtime flag

    Changed by Adam Rice - riceaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:10:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fbb267e716151d87e9bb0a394935f6944515700

    Comments

    Remove EncodingStreams runtime flag
    
    TextEncoderStream and TextDecoderStream have shipped. The flag is no
    longer needed. Remove it.
    
    BUG=898158
    
    Change-Id: Ie08d787509f075715b084c7d5e55ad7b2a0e2fb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364934
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614613}

    Changed files

    • third_party/blink/renderer/modules/encoding/text_decoder_stream.idl
    • third_party/blink/renderer/modules/encoding/text_encoder_stream.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  21. Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:06:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c653611523cbca009b53d250a568e95aacf9c29

    Comments

    Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/132d15c217e0..c3e3731cd3b2
    
    
    git log 132d15c217e0..c3e3731cd3b2 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jmadill@chromium.org Give every validation error a constant.
    2018-12-06 syoussefi@chromium.org Vulkan: Add dynamic vertex buffers to graph
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c3e3731cd3b2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: Iaed9b0cae0e3386ca9836bc3caaf112c87dd8d17
    Reviewed-on: https://chromium-review.googlesource.com/c/1367169
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614612}

    Changed files

    • DEPS
  22. Define libwebp max allocation limit in GN fuzzer targets

    Changed by Madeleine Barowsky - mbarowskyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:49:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d639093c7a8572cdcbec81cc6b28dfb860ce815

    Comments

    Define libwebp max allocation limit in GN fuzzer targets
    
    This upper bound of 800MiB is previously enforced in the oss-fuzz
    targets [1], so we are adding it here too for consistency.
    
    [1]: github.com/google/oss-fuzz/blob/master/projects/libwebp/build.sh#L19
    
    Bug: 901042
    Change-Id: I5d1f3a970340c0c60c39e52ab2f959e0253ff63c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365655
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: James Zern <jzern@google.com>
    Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614611}

    Changed files

    • third_party/libwebp/BUILD.gn
  23. [LayoutNG] DCHECK that inline container is containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 249af433d7f20d80d1d9cc225333ead0ef67d47f

    Comments

    [LayoutNG] DCHECK that inline container is containing block
    
    Bug: 740993
    Change-Id: Ie8abce134861f5a5a7cf694225da7073c48ae773
    Reviewed-on: https://chromium-review.googlesource.com/c/1321167
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614610}

    Changed files

    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  24. [DevTools] Do not report worker console messages twice

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:46:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e41224229e7a61deb59a2a5d7bf5175cc56bf14c

    Comments

    [DevTools] Do not report worker console messages twice
    
    When the worker is still alive while DevTools is being opened,
    there is a race between console messages coming from page and
    worker target creation.
    
    Bug: 908863
    Change-Id: I9495d4becada0e4f2bd208c0922b2a2a3ea98af9
    Reviewed-on: https://chromium-review.googlesource.com/c/1359039
    Reviewed-by: Joel Einbinder <einbinder@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614609}

    Changed files

    • third_party/blink/renderer/devtools/front_end/browser_sdk/LogManager.js
    • third_party/blink/renderer/devtools/front_end/sdk/ConsoleModel.js
  25. [EoS] Enable re-scrolling on back button.

    Changed by Justin DeWitt - dewittjohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2a94ae3b82c0e840d2eff0a21edb3cc591700f3c

    Comments

    [EoS] Enable re-scrolling on back button.
    
    This utilizes LinearLayoutManager#onSaveInstanceState to provide a
    parcelable.  This is stashed on the NavigationEntry (which is OK since it
    is not persisted in any way.)
    
    Change-Id: I903ef6440d1ef8e3d65d2e3764c2da35201b8b18
    Reviewed-on: https://chromium-review.googlesource.com/c/1362198
    Commit-Queue: Justin DeWitt <dewittj@chromium.org>
    Reviewed-by: Cathy Li <chili@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614608}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPage.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageTest.java
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.initial_layout.Nexus_5-19.png
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.recycler_layout.Nexus_5-19.png
    • chrome/test/data/android/render_tests/ExploreSitesPageTest.recycler_layout_back.Nexus_5-19.png
  26. Create OWNERS file for ios/web_view/internal/passwords.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 04:45:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8cdaa50cfb8075f774149c3b525b37301fc9f62a

    Comments

    Create OWNERS file for ios/web_view/internal/passwords.
    
    jzw@ wrote large portion of this code and ichikawa@ reviewed most of the
    changes. This CL effectively removes eugenebut@, michaeldo@ or rohitrao@
    from ios/web_view/internal/passwords OWNERS, because these engineers are
    not very familiar with the code.
    
    Bug: None
    Change-Id: I9343624316a7fee7376e13f6b942439d22baa8c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366258
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614607}

    Changed files

    • ios/web_view/internal/passwords/OWNERS
  27. MD History: Make history item use FocusRowBehavior

    Changed by rbpotter - rbpotterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:44:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d890486deef4f4822344fa734cafcc2be778805

    Comments

    MD History: Make history item use FocusRowBehavior
    
    history-item shared a large amount of logic with the settings
    FocusRowBehavior. This CL moves FocusRowBehavior to cr/ui (with
    FocusRow), and makes history item implement it instead of using custom
    logic.
    
    Bug: None
    Change-Id: Id326142bf25a231ef9cbc338c7fe2a3f9551d3f6
    Reviewed-on: https://chromium-review.googlesource.com/c/1345414
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614606}

    Changed files

    • chrome/browser/resources/md_history/BUILD.gn
    • chrome/browser/resources/md_history/history_item.html
    • chrome/browser/resources/md_history/history_item.js
    • chrome/browser/resources/settings/BUILD.gn
    • chrome/browser/resources/settings/autofill_page/BUILD.gn
    • chrome/browser/resources/settings/autofill_page/password_list_item.html
    • chrome/browser/resources/settings/autofill_page/password_list_item.js
    • chrome/browser/resources/settings/focus_row_behavior.html
    • chrome/browser/resources/settings/focus_row_behavior.js
    • chrome/browser/resources/settings/on_startup_page/BUILD.gn
    • chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
    • chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
    • chrome/browser/resources/settings/search_engines_page/BUILD.gn
    • chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
    • chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
    • chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
    • chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
    • chrome/browser/resources/settings/settings_resources.grd
    • chrome/browser/resources/settings/site_settings/BUILD.gn
    • chrome/browser/resources/settings/site_settings/site_data_entry.html
    • chrome/browser/resources/settings/site_settings/site_data_entry.js
    • chrome/browser/resources/settings/site_settings/site_list_entry.html
    • chrome/browser/resources/settings/site_settings/site_list_entry.js
    • chrome/test/data/webui/BUILD.gn
    • chrome/test/data/webui/cr_focus_row_behavior_interactive_test.js
    • chrome/test/data/webui/cr_focus_row_behavior_test.js
    • chrome/test/data/webui/settings/cr_settings_interactive_ui_tests.js
    • ui/webui/resources/html/cr/ui/focus_row_behavior.html
    • ui/webui/resources/js/cr/ui/BUILD.gn
    • ui/webui/resources/js/cr/ui/focus_grid.js
    • ui/webui/resources/js/cr/ui/focus_row.js
    • ui/webui/resources/js/cr/ui/focus_row_behavior.js
    • ui/webui/resources/webui_resources.grd
  28. Roll src/third_party/perfetto f4a214430436..f1a2558c421d (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:44:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab2a18af11b07f338b2b59d493c767d8f1dbdefa

    Comments

    Roll src/third_party/perfetto f4a214430436..f1a2558c421d (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f4a214430436..f1a2558c421d
    
    
    git log f4a214430436..f1a2558c421d --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 primiano@google.com Cache new git deps in Travis
    2018-12-07 primiano@google.com Merge "TraceProcessor: add parsing of oom_score_adj"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f1a2558c421d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I31a16930ff43c4e094d9992352b94c71633957d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1367097
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614605}

    Changed files

    • DEPS
  29. Nux Onboarding: fix race-condition crashes

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6223083496b5fed8d8bb69c38b20d7819ca3be9

    Comments

    Nux Onboarding: fix race-condition crashes
    
    There are a couple race-conditions happening in the code that
    in combination causes 'undefined' to be passed to the C++ handler,
    which crashes on a CHECK in BookmarkHandler:
    - in some places toggleBookmarkBar() depends on isBookmarkBarShown()
       result, without taking into account that isBookmarkBarShown is async.
    - multiple toggleBookmarkBar() async calls fire consecutively, overriding
       each other's effects.
    
    The above two issues are fixed together by locally cached bookmark visibility
    state that can be updated and retrieved synchronously (inside of the wrapper
    BookmarkBarManager). There doesn't seem to be a way for toggling bookmark
    visibility to fail in the backend. Even if that's possible, the best we can
    do is to keep using the local cache value until the visibility state becomes
    eventually consistent, so simply updating this local cache should suffice.
    
    After the above fix, another timing issue is exposed:
    - the navigation behavior's onRouteChange is always called in the order
    that elements are created. This is problematic since sometimes module's
    clean-up code run after another module's init code and causing conflicting
    effects.
    
    The above issue is fixed in this CL by adding additional enter and exit
    hooks to each route, and navigation behavior will trigger them in the
    expected order.
    
    Bug: 908544
    Change-Id: If462d2ec955ece0d8b17fc342fc7d1ce0225e72c
    Reviewed-on: https://chromium-review.googlesource.com/c/1357523
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614604}

    Changed files

    • chrome/browser/resources/welcome/onboarding_welcome/BUILD.gn
    • chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
    • chrome/browser/resources/welcome/onboarding_welcome/email/nux_email.js
    • chrome/browser/resources/welcome/onboarding_welcome/google_apps/apps_chooser.js
    • chrome/browser/resources/welcome/onboarding_welcome/google_apps/nux_google_apps.js
    • chrome/browser/resources/welcome/onboarding_welcome/navigation_behavior.js
    • chrome/browser/resources/welcome/onboarding_welcome/shared/bookmark_proxy.js
    • chrome/browser/resources/welcome/onboarding_welcome/welcome_app.html
    • chrome/browser/resources/welcome/onboarding_welcome/welcome_app.js
    • chrome/test/data/webui/welcome/email_chooser_test.js
    • chrome/test/data/webui/welcome/navigation_behavior_test.js
    • chrome/test/data/webui/welcome/onboarding_welcome_browsertest.js
  30. [VK] Fix keyboard shortcut documentation.

    Changed by Darren Shen - shendohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:43:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 54c3aef61f7f6568ff4c4f1526107d9894003c94

    Comments

    [VK] Fix keyboard shortcut documentation.
    
    This patch fixes the ambiguous description in the keyboard shortcut
    viewer for Ctrl-Space and Ctrl-Shift-Space. Namely, Ctrl-Space
    toggles between the current input method and the last used, whereas
    Ctrl-Shift-Space cycles through all of them. The naming is confusing
    because "previous" here means "last used" and not the opposite of
    "next". The two shortcuts are -not- inverses of each other. We rename
    the implementation as well for clarity.
    
    TBR=shuchen@chromium.org
    
    Bug: 909863
    Change-Id: I7ca8d70d5d571ce3065814cb789e79a1488b875d
    Reviewed-on: https://chromium-review.googlesource.com/c/1358195
    Commit-Queue: Darren Shen <shend@chromium.org>
    Reviewed-by: Oliver Chang <ochang@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614603}

    Changed files

    • ash/accelerators/accelerator_controller.cc
    • ash/accelerators/accelerator_controller_unittest.cc
    • ash/accelerators/accelerator_table.cc
    • ash/accelerators/accelerator_table_unittest.cc
    • ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc
    • ash/components/shortcut_viewer_strings.grdp
    • ash/ime/ime_controller.cc
    • ash/ime/ime_controller.h
    • ash/ime/ime_controller_unittest.cc
    • ash/ime/test_ime_controller_client.cc
    • ash/ime/test_ime_controller_client.h
    • ash/public/cpp/accelerators.cc
    • ash/public/cpp/accelerators.h
    • ash/public/interfaces/ime_controller.mojom
    • chrome/browser/chromeos/input_method/input_method_manager_impl.cc
    • chrome/browser/chromeos/input_method/input_method_manager_impl.h
    • chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
    • chrome/browser/ui/ash/ime_controller_client.cc
    • chrome/browser/ui/ash/ime_controller_client.h
    • chrome/browser/ui/ash/ime_controller_client_unittest.cc
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_metadata_unittest.cc
    • ui/base/ime/chromeos/input_method_manager.h
    • ui/base/ime/chromeos/mock_input_method_manager.cc
    • ui/base/ime/chromeos/mock_input_method_manager.h
  31. [Platform Apps] Include uncompiled app sources in API registration]

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:42:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0836cf405ec25c63308dbddb72c046f651286e1

    Comments

    [Platform Apps] Include uncompiled app sources in API registration]
    
    Include un-compiled API sources in the list of APIs to register for
    Chrome API functions.
    
    Bug: 902116
    
    Change-Id: Ie10134207e4a0d8c4ecb1eb6a0b8d3b2e9d4b61d
    Reviewed-on: https://chromium-review.googlesource.com/c/1367114
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614602}

    Changed files

    • chrome/browser/apps/platform_apps/api/BUILD.gn
  32. Clean up sequence checking in //services/device/hid

    Changed by Reilly Grant - reillygohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 04:42:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbc72ccaf4f7bbe5f0e34529ea83ba5e4502324e

    Comments

    Clean up sequence checking in //services/device/hid
    
    This change replaces the remaining thread checkers in this code with
    sequence checkers. In the Linux backend specifically an unnecessary
    thread hop during connection open has been removed.
    
    Change-Id: I7fa4da7d02702a9249d3e45b93f271a691301d56
    Reviewed-on: https://chromium-review.googlesource.com/c/1351418
    Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614601}

    Changed files

    • services/device/hid/hid_connection.cc
    • services/device/hid/hid_connection.h
    • services/device/hid/hid_connection_linux.cc
    • services/device/hid/hid_connection_linux.h
    • services/device/hid/hid_service.cc
    • services/device/hid/hid_service.h
    • services/device/hid/hid_service_linux.cc
    • services/device/hid/hid_service_linux.h
    • services/device/hid/hid_service_mac.cc
    • services/device/hid/hid_service_win.cc
  33. Fix crash when accessing invalid cookie settings

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:41:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0fa376aa1cbba121926489eafab6b4a95fb14d4

    Comments

    Fix crash when accessing invalid cookie settings
    
    This crash happens when ResourceContext is destroyed, but
    RenderFrameMessageFilter is still alive, and tries to use the old
    ResourceContext pointer. This change explicitly nulls out
    ResourceContext and checks before using it.
    
    Bug: 911714
    Change-Id: I7c71297d8b70607ce245db06f3ea35765476857f
    Reviewed-on: https://chromium-review.googlesource.com/c/1366356
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614600}

    Changed files

    • content/browser/frame_host/render_frame_message_filter.cc
    • content/browser/frame_host/render_frame_message_filter.h
    • content/browser/frame_host/render_frame_message_filter_browsertest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
  34. OobeInteractiveUITest: move local code to anonymous namespace.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:41:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2dc4db19196b7edca464d0536cb4d0e244ce66ee

    Comments

    OobeInteractiveUITest: move local code to anonymous namespace.
    
    This Cl moves test-local code to anonymous namespace to prevent link erros.
    
    Bug: 891277
    Change-Id: I47c5f41b2c9d77300b389d06bcabf38c981548a2
    Reviewed-on: https://chromium-review.googlesource.com/c/1367110
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614599}

    Changed files

    • chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
  35. [CrOS MultiDevice] Convert to multidevice::SoftwareFeature/BeaconSeed.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:39:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c984f40f3f825924c8ded4f29daf16148281269f

    Comments

    [CrOS MultiDevice] Convert to multidevice::SoftwareFeature/BeaconSeed.
    
    Before this CL, RemoteDevice and related classes directly used CryptAuth
    proto enums/messages for SoftwareFeature and BeaconSeed fields. This was
    problematic because:
      (1) RemoteDevice has been moved to a common/shared location and is now
          meant to be independent of any one service. Thus, it no longer
          makes sense for it to contain fields that are implementation
          details of the DeviceSync service.
      (2) The CryptAuth SoftwareFeature enum included an UNKNOWN_FEATURE
          enum value, but this value was only meant to be used as a sentinel
          value while communicating with the CryptAuth server. Since we
          previously referenced the cryptauth::SoftwareFeature enum
          directly, it was possible for RemoteDevice objects to have a state
          for UNKNOWN_FEATURE, which does not make sense in this context.
      (3) The CryptAuth SoftwareFeature enum referred to feature names using
          outdated and/or incorrect names.
      (4) CryptAuth protos do not define an operator<<() function, so it was
          possible to log a cryptauth::SoftwareFeature as a number instead
          of as a user-readable description. This led to issues such as
          https://crbug.com/906836.
    
    A follow-up CL will move the RemoteDevice Mojo definition from
    device_sync.mojom (i.e., the DeviceSync-specific Mojo file) to a new
    multidevice.mojom file meant to be referenced by other Mojo definitions.
    
    Change-Id: Iccf4997cb5a1c6f4c34e7962c7c993f74f8aa8f0
    Bug: 912743
    Reviewed-on: https://chromium-review.googlesource.com/c/1362214
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614598}

    Changed files

    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
    • chrome/browser/chromeos/tether/tether_service_unittest.cc
    • chromeos/components/multidevice/BUILD.gn
    • chromeos/components/multidevice/beacon_seed.cc
    • chromeos/components/multidevice/beacon_seed.h
    • chromeos/components/multidevice/remote_device.cc
    • chromeos/components/multidevice/remote_device.h
    • chromeos/components/multidevice/remote_device_ref.cc
    • chromeos/components/multidevice/remote_device_ref.h
    • chromeos/components/multidevice/remote_device_ref_unittest.cc
    • chromeos/components/multidevice/remote_device_test_util.cc
    • chromeos/components/multidevice/remote_device_test_util.h
    • chromeos/components/multidevice/software_feature.cc
    • chromeos/components/multidevice/software_feature.h
    • chromeos/components/multidevice/software_feature_state.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/tether/tether_host_fetcher_impl.cc
    • chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
    • chromeos/services/device_sync/device_sync_impl.cc
    • chromeos/services/device_sync/device_sync_impl.h
    • chromeos/services/device_sync/device_sync_service_unittest.cc
    • chromeos/services/device_sync/fake_device_sync.cc
    • chromeos/services/device_sync/fake_device_sync.h
    • chromeos/services/device_sync/public/cpp/device_sync_client.h
    • chromeos/services/device_sync/public/cpp/device_sync_client_impl.cc
    • chromeos/services/device_sync/public/cpp/device_sync_client_impl.h
    • chromeos/services/device_sync/public/cpp/device_sync_client_impl_unittest.cc
    • chromeos/services/device_sync/public/cpp/fake_device_sync_client.cc
    • chromeos/services/device_sync/public/cpp/fake_device_sync_client.h
    • chromeos/services/device_sync/public/mojom/device_sync.mojom
    • chromeos/services/device_sync/public/mojom/device_sync.typemap
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.cc
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.h
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits_unittest.cc
    • chromeos/services/multidevice_setup/device_reenroller.cc
    • chromeos/services/multidevice_setup/device_reenroller_unittest.cc
    • chromeos/services/multidevice_setup/eligible_host_devices_provider_impl.cc
    • chromeos/services/multidevice_setup/eligible_host_devices_provider_impl_unittest.cc
    • chromeos/services/multidevice_setup/feature_state_manager_impl.cc
    • chromeos/services/multidevice_setup/feature_state_manager_impl_unittest.cc
    • chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler.cc
    • chromeos/services/multidevice_setup/grandfathered_easy_unlock_host_disabler_unittest.cc
    • chromeos/services/multidevice_setup/host_backend_delegate_impl.cc
    • chromeos/services/multidevice_setup/host_backend_delegate_impl_unittest.cc
    • chromeos/services/multidevice_setup/host_verifier_impl.cc
    • chromeos/services/multidevice_setup/host_verifier_impl_unittest.cc
    • chromeos/services/secure_channel/ble_service_data_helper_impl.cc
    • chromeos/services/secure_channel/ble_service_data_helper_impl_unittest.cc
    • components/cryptauth/background_eid_generator.cc
    • components/cryptauth/background_eid_generator_unittest.cc
    • components/cryptauth/ble/ble_advertisement_generator.cc
    • components/cryptauth/ble/ble_advertisement_generator_unittest.cc
    • components/cryptauth/fake_software_feature_manager.cc
    • components/cryptauth/fake_software_feature_manager.h
    • components/cryptauth/remote_device_loader.cc
    • components/cryptauth/remote_device_loader_unittest.cc
    • components/cryptauth/software_feature_manager.h
    • components/cryptauth/software_feature_manager_impl.cc
    • components/cryptauth/software_feature_manager_impl.h
    • components/cryptauth/software_feature_manager_impl_unittest.cc
  36. Roll src/third_party/pdfium f1038808a9c8..994719731644 (6 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:39:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9dbfb69b67406cdee217e9970fafea98e8c70c40

    Comments

    Roll src/third_party/pdfium f1038808a9c8..994719731644 (6 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/f1038808a9c8..994719731644
    
    
    git log f1038808a9c8..994719731644 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 tsepez@chromium.org Move element/parent relationship data to .inc file
    2018-12-06 tsepez@chromium.org Use symbols to represent parents in script hierarchy
    2018-12-06 tsepez@chromium.org XFA: generate element tables via C preprocessor
    2018-12-06 tsepez@chromium.org XFA: generate value tables with C preprocessor.
    2018-12-06 tsepez@chromium.org XFA: generate attribute tables via C Preprocessor.
    2018-12-06 thestig@chromium.org Limit pdf_codec_fax_fuzzer input size.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@994719731644
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:910505
    TBR=dsinclair@chromium.org
    
    Change-Id: I666c94ba76957f9159579f9c9932e9769bbc8915
    Reviewed-on: https://chromium-review.googlesource.com/c/1367102
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614597}

    Changed files

    • DEPS
  37. Move HTTP/2 fuzzers outside of shared codebase.

    Changed by Victor Vasiliev - vasilvvohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:38:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 747e0c3c3d0570ca782f66da2c541f32be6f40bd

    Comments

    Move HTTP/2 fuzzers outside of shared codebase.
    
    They were never present in google3, so they shouldn't be in
    net/third_party/http2.
    
    R=rch@chromium.org
    
    Change-Id: If6a7e2ff4d21ddf0cdf7f929ca45766c0610c2e9
    Reviewed-on: https://chromium-review.googlesource.com/c/1366919
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Commit-Queue: Ryan Hamilton <rch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614596}

    Changed files

    • net/BUILD.gn
    • net/spdy/fuzzing/hpack_decoder_fuzzer.cc
    • net/spdy/fuzzing/http2_frame_decoder_fuzzer.cc
  38. [ServiceWorker] A cleanup in service_worker_context_client.cc.

    Changed by Leon Han - leon.hanohnoyoudont@intel.com
    Changed at Friday, 07-Dec-18 04:38:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a115b526e20b66a78426ab092bc43600f9a27a4

    Comments

    [ServiceWorker] A cleanup in service_worker_context_client.cc.
    
    The ToWebServiceWorkerRequest() is used only for dispatching fetch event
    to service workers, and is not supposed to be used for other purposes
    even in the future.
    
    BUG=911930
    
    Change-Id: Ie57f1b65c927ad3aed675b744135ed48f37df9b8
    Reviewed-on: https://chromium-review.googlesource.com/c/1365074
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Leon Han <leon.han@intel.com>
    Cr-Commit-Position: refs/heads/master@{#614595}

    Changed files

    • content/renderer/service_worker/service_worker_context_client.cc
  39. Fix length calculation in imagesizes when <meta> viewport is present

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:37:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7692e1f3e7a07d088557a8c765d9218775daaf7

    Comments

    Fix length calculation in imagesizes when <meta> viewport is present
    
    This fixes a bug where "vw" length calculation of imagesizes attribute
    coming from Link rel=preload header did not reflect the content
    width from <meta name=viewport>.
    
    MediaValuesDynamic::ComputeLength() did not use overridden viewport
    dimensions.
    
    Bug: 813452
    Change-Id: Icbc8f124e552b681bfffa80f407543078f851ed3
    Reviewed-on: https://chromium-review.googlesource.com/c/1365051
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614594}

    Changed files

    • third_party/blink/renderer/core/css/media_values_dynamic.cc
    • third_party/blink/web_tests/http/tests/preload/meta-viewport-link-headers-imagesrcset.html
    • third_party/blink/web_tests/http/tests/preload/resources/media-link-headers-imagesrcset.php
  40. Roll src/third_party/skia 055539a9c2d9..309f1deddf8e (8 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:37:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ac0bbde1c1bbf2aa38f2c61ab77208b04556d4a

    Comments

    Roll src/third_party/skia 055539a9c2d9..309f1deddf8e (8 commits)
    
    https://skia.googlesource.com/skia.git/+log/055539a9c2d9..309f1deddf8e
    
    
    git log 055539a9c2d9..309f1deddf8e --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 sergeyu@chromium.org Add SkFontMgr implementation for Fuchsia
    2018-12-06 reed@google.com Revert "remove SkPaint breakText, use SkFont instead (or don't call it)"
    2018-12-06 reed@google.com Move all glyphsToUnichars to a single impl (rely on typeface)
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d300548fcc28..ec06305b8216 (3 commits)
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c0f92f2308d1..f8374cf0e75c (3 commits)
    2018-12-06 reed@google.com Abandon onDrawText and its variants, turn everything into textblobs
    2018-12-06 bsalomon@google.com Revert "Revert "Use unnormalized coords all the way through with GL_TEXTURE_RECTANGLE textures.""
    2018-12-06 jvanverth@google.com Add use of RG textures in wacky_yuv_formats
    
    
    Created with:
      gclient setdep -r src/third_party/skia@309f1deddf8e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: If73538629fb7a90866aae2eb1f8b561287088552
    Reviewed-on: https://chromium-review.googlesource.com/c/1366789
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614593}

    Changed files

    • DEPS
  41. [CSS Animations] !important fails to override

    Changed by Eric Willigers - ericwilligersohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:36:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 155df253bc1fbbff79ae6e72b6b9eba95adb972d

    Comments

    [CSS Animations] !important fails to override
    
    Blink currently fails the css-cascade/important-prop.html WPT
    
    BUG=552085
    
    Change-Id: Ida8839e7aa81b7dd6fd05a32248406e7fa6126c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1366459
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614592}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  42. Pass --disable-breakpad to the layout tests on android.

    Changed by John Budorick - jbudorickohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:36:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b18336198ea30e225e2a2352c1338779c1cde940

    Comments

    Pass --disable-breakpad to the layout tests on android.
    
    crrev.com/c/1357941 switched Android from breakpad to crashpad.
    Also adds standalone configuration for android_blink_rel.
    
    Bug: 912120
    Change-Id: I7330d4dc707036a8a01f9d8ddbe918259dddb378
    Reviewed-on: https://chromium-review.googlesource.com/c/1367106
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614591}

    Changed files

    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.android.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/tryserver.chromium.android.json
    • testing/buildbot/waterfalls.pyl
  43. Average unknown feature value predictions in RandomTree.

    Changed by liberato@chromium.org - liberatoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:35:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02aa8a1cafd38518bb3eaa1562d64041e76ccb88

    Comments

    Average unknown feature value predictions in RandomTree.
    
    Previously, RandomTree would return an empty distribution if it
    encountered an unknown feature value while traversing the tree.
    
    However, if we used one-hot encoding for nominal values, then it
    would take the "zero" branch of the split instead.  The tree
    structure would dictate which non-one-hot value that corresponds to.
    
    To do something similar, RandomTree now traverses all branches from
    the split, and sums the distributions if the new LearningTask flag
    rt_unknown_value_handling is set to kUseAllSplits.
    
    Alternatively, if it's set to kEmptyDistribution, then it keeps the
    old behavior.
    
    Change-Id: Iccff895a2463a892babc353862a940e9dcd75d4a
    Reviewed-on: https://chromium-review.googlesource.com/c/1365976
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614590}

    Changed files

    • media/learning/common/learning_task.h
    • media/learning/impl/learning_task_controller_impl.cc
    • media/learning/impl/random_tree_trainer.cc
    • media/learning/impl/random_tree_trainer.h
    • media/learning/impl/random_tree_trainer_unittest.cc
  44. Smart Lock: Only add observer to ProximityMonitor once.

    Changed by Ryan Hansberry - hansberryohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:35:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2418c9546e5e7d0f2fabbb135c467e0df700f14e

    Comments

    Smart Lock: Only add observer to ProximityMonitor once.
    
    ProximityMonitor::AddObserver was previously being called
    multiple times. Its mirror RemoveObserver call was also
    never called; this CL adds that call. Finally, the
    proximity_monitor_ object was being created multiple times
    for no reason; now it is created once.
    
    Bug: 910769
    Change-Id: If1ab0216d364831cad2bf0d39516af31aa34cbd4
    Reviewed-on: https://chromium-review.googlesource.com/c/1367084
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614589}

    Changed files

    • chromeos/components/proximity_auth/unlock_manager_impl.cc
  45. Pass GpuPreferences to Viz process in Mash

    Changed by Mohsen Izadi - mohsenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:34:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a6476b7e75b45046297564825d5464f61c759cc

    Comments

    Pass GpuPreferences to Viz process in Mash
    
    This CL passes GpuPreferences as command line arguments to the Viz
    process when it is launched.
    
    BUG=906171
    
    Change-Id: Iaa4be301dc20f2c2055de4736e70288d21b32554
    Reviewed-on: https://chromium-review.googlesource.com/c/1343525
    Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614588}

    Changed files

    • chrome/browser/DEPS
    • chrome/browser/chrome_content_browser_client.cc
    • content/browser/gpu/gpu_data_manager_impl.cc
    • content/browser/gpu/gpu_data_manager_impl.h
    • content/public/browser/gpu_data_manager.h
  46. Shows the label "Unnamed" in the app list as the default name for a folder in place of "Unnamed Folder"

    Changed by Matthew Mourgos - mmourgosohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:34:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b4236f76fdc3abf7c036659fe8d1299f93bf0ca7

    Comments

    Shows the label "Unnamed" in the app list as the default name for a folder in place of "Unnamed Folder"
    
    Bug: 755547
    Change-Id: Ieb549f14a278f409aec7632da284d39de564a1c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363978
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614587}

    Changed files

    • ui/strings/ui_strings.grd
  47. Roll src-internal fb4f6083a23a..10e8db47197f (11 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 04:33:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 873bec09ca14a9a1aeae4682a417ebd4518e1b9e

    Comments

    Roll src-internal fb4f6083a23a..10e8db47197f (11 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb4f6083a23a..10e8db47197f
    
    
    Created with:
      gclient setdep -r src-internal@10e8db47197f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I44a5dde14e3683af5d7d39bd5ae32f0f6bd148be
    Reviewed-on: https://chromium-review.googlesource.com/c/1367098
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614586}

    Changed files

    • DEPS
  48. Worklet: Mark CSP web tests for audio and animation worklets with slow

    Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:33:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 93bc539ac1ed13143e53bbe14dab93c6b0430782

    Comments

    Worklet: Mark CSP web tests for audio and animation worklets with slow
    
    Bug: 912240
    Change-Id: I823d1b825c4f31138953eb83c65a374540dc0a85
    Tbr: nhiroki@chromium.org
    Notry: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1366463
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614585}

    Changed files

    • third_party/blink/web_tests/SlowTests
  49. Deflake DirectoryTreeContextMenu tests

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:32:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3272f73f06312a50d6601bda8dbf737cbbae3874

    Comments

    Deflake DirectoryTreeContextMenu tests
    
    Change flake tests to use expandTreeItemInDirectoryTree and fix it to
    wait for the tree-item being expanded to have "has-children" attribute,
    so the click to expand actually works.
    
    Change expandTreeItemInDirectoryTree to use |waitAndClickElement| and
    to do so, move it from RemoteCallGallery to the RemoteCall base class.
    Change its callbacks from anonymous function to arrow function.
    
    Enable dirRenameWithoutChangingCurrent to run with MyFilesVolume flag
    enabled.
    
    Bug: 911609
    Change-Id: I10387aef5f213ac2c39f253bf041a5003a2cde17
    Reviewed-on: https://chromium-review.googlesource.com/c/1364932
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614584}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
    • ui/file_manager/integration_tests/remote_call.js
  50. First draft of an App Service search provider

    Changed by Nigel Tao - nigeltaoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:32:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f4cd59a01351d213e782174c933a6da6160723c2

    Comments

    First draft of an App Service search provider
    
    Lots of TODOs, but there's enough implemented so that running "chrome
    --enable-features=AppService" will populate the app list search box with
    apps' names and icons, and clicking on the icon will launch the app.
    
    BUG=826982
    
    Change-Id: I564bbd9142061e95a91c1a0b63a70980c970d56d
    Reviewed-on: https://chromium-review.googlesource.com/c/1362597
    Commit-Queue: Nigel Tao <nigeltao@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614583}

    Changed files

    • chrome/browser/apps/app_service/built_in_chromeos_apps.cc
    • chrome/browser/apps/app_service/extension_apps.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/app_list/app_service_app_item.cc
    • chrome/browser/ui/app_list/search/app_search_provider.cc
    • chrome/browser/ui/app_list/search/app_service_app_result.cc
    • chrome/browser/ui/app_list/search/app_service_app_result.h
    • chrome/services/app_service/public/cpp/app_registry_cache.cc
    • chrome/services/app_service/public/cpp/app_registry_cache.h
    • chrome/services/app_service/public/cpp/app_update.cc
    • chrome/services/app_service/public/cpp/app_update.h
    • chrome/services/app_service/public/cpp/app_update_unittest.cc
    • chrome/services/app_service/public/mojom/types.mojom
  51. Renaming remaining files of which names contain "layouttest" in content/

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:31:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2eab5b13ff0998313a8373c1f95eac04b9e6151f

    Comments

    Renaming remaining files of which names contain "layouttest" in content/
    
    - layouttest_support.* => web_test_support.*
    - layout_test_dependencies.* => web_test_dependencies.*
    - layout_test_runtime_flags.* => web_test_runtime_flags.*
    
    Also, this CL renames symbols related to these files.
    
    TBR=caitkp@chromium.org
    
    Bug: 843412
    Change-Id: Ief1431a8d74e75cf1907737d958964184ea973c8
    Reviewed-on: https://chromium-review.googlesource.com/c/1362594
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614582}

    Changed files

    • components/BUILD.gn
    • content/public/test/web_test_support.h
    • content/renderer/BUILD.gn
    • content/renderer/media/media_factory.cc
    • content/renderer/render_thread_impl.cc
    • content/renderer/render_thread_impl.h
    • content/renderer/render_view_impl.cc
    • content/renderer/renderer_webapplicationcachehost_impl.cc
    • content/renderer/resizing_mode_selector.cc
    • content/renderer/web_test_dependencies.cc
    • content/renderer/web_test_dependencies.h
    • content/shell/BUILD.gn
    • content/shell/app/shell_main_delegate.cc
    • content/shell/browser/web_test/blink_test_controller.cc
    • content/shell/browser/web_test/fake_bluetooth_chooser.cc
    • content/shell/browser/web_test/web_test_bluetooth_fake_adapter_setter_impl.cc
    • content/shell/browser/web_test/web_test_message_filter.cc
    • content/shell/renderer/web_test/blink_test_runner.cc
    • content/shell/renderer/web_test/web_test_content_renderer_client.cc
    • content/shell/renderer/web_test/web_test_render_thread_observer.cc
    • content/shell/test_runner/BUILD.gn
    • content/shell/test_runner/layout_dump.cc
    • content/shell/test_runner/layout_dump.h
    • content/shell/test_runner/mock_content_settings_client.cc
    • content/shell/test_runner/mock_content_settings_client.h
    • content/shell/test_runner/pixel_dump.cc
    • content/shell/test_runner/test_runner.cc
    • content/shell/test_runner/test_runner.h
    • content/shell/test_runner/web_test_runtime_flags.cc
    • content/shell/test_runner/web_test_runtime_flags.h
    • content/test/BUILD.gn
    • content/test/DEPS
    • content/test/web_test_support.cc
  52. Downloads: detect failed file icons and show default thumbnail

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:31:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ec126531ceaebdd0b9ee340ec4d750507290fd7

    Comments

    Downloads: detect failed file icons and show default thumbnail
    
    On the downloads page, we consult the system for a themed image for the
    type of file downloads. Ex: zip files -> archive icon.
    
    When a system doesn't know why type of icon to show for a specific file
    type, it can either return a default or nothing. Right now, Linux
    returns nothing, so we show nothing.  chrome://fileicon tries to warn
    us by giving a network error (which has been ignored until now).
    
    So, when a chrome://fileicon fails to load, show a default filetype
    icon in respond.
    
    Before & after screenshots: https://imgur.com/a/txRbfIG
    
    R=dpapad@chromium.org
    BUG=855259
    
    Change-Id: I370fd8ea119b194ad8e1ba7e0dfad32c6cea1bbe
    Reviewed-on: https://chromium-review.googlesource.com/c/1132560
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614581}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/resources/md_downloads/BUILD.gn
    • chrome/browser/resources/md_downloads/icon_loader.html
    • chrome/browser/resources/md_downloads/icon_loader.js
    • chrome/browser/resources/md_downloads/item.html
    • chrome/browser/resources/md_downloads/item.js
    • chrome/browser/resources/print_preview/data/destination.js
    • chrome/browser/resources/print_preview/icons.html
    • chrome/browser/resources/print_preview/new/app.html
    • chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
    • chrome/test/data/webui/icon_test.html
    • chrome/test/data/webui/md_downloads/downloads_browsertest.js
    • chrome/test/data/webui/md_downloads/item_tests.js
    • chrome/test/data/webui/md_downloads/test_support.js
    • ui/webui/resources/cr_elements/icons.html
    • ui/webui/resources/js/icon.js
  53. Updating trunk VERSION from 3633.0 to 3634.0

    Changed by chrome-release-bot - chrome-release-botohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 04:11:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e324812251510778815829c1b07043b6d53f8414

    Comments

    Updating trunk VERSION from 3633.0 to 3634.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=mmoss@chromium.org
    
    Change-Id: I042e2caf928b9a12422f14eccec3e8f33ead12d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1366874
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614580}

    Changed files

    • chrome/VERSION
  54. Revert "cros: Move most event/widget handling logic out of LoginBubble"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb9ca465cac1a3ec4d0670844865b40efb003c11

    Comments

    Revert "cros: Move most event/widget handling logic out of LoginBubble"
    
    This reverts commit a61287973e8f4522ed673ac1a77de0dc56eb1bc8.
    
    Reason for revert: Suspect Failure single_process_mash_ash_unittests Failure ash_unittests:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/16943
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927839167159249024/+/steps/single_process_mash_ash_unittests/0/logs/LoginExpandedPublicAccountViewTest.ChangeMenuSelection/0
    ---
    [ RUN      ] LoginExpandedPublicAccountViewTest.ChangeMenuSelection
    Received signal 11 SEGV_MAPERR ffffe03f000008fe
    #0 0x5631a3caedbf base::debug::StackTrace::StackTrace()
    #1 0x5631a3cae941 base::debug::(anonymous namespace)::StackDumpSignalHandler()
    #2 0x7faa9920f330 <unknown>
    #3 0x5631a3aafbbf ash::LoginBubble::~LoginBubble()
    #4 0x5631a3ab806c ash::RightPaneView::~RightPaneView()
    #5 0x5631a3ab810e ash::RightPaneView::~RightPaneView()
    #6 0x5631a40385d4 views::View::~View()
    #7 0x5631a3ab6df9 ash::LoginExpandedPublicAccountView::~LoginExpandedPublicAccountView()
    #8 0x5631a40385d4 views::View::~View()
    #9 0x5631a300afce ash::(anonymous namespace)::DragTestView::~DragTestView()
    #10 0x5631a4039b42 views::View::DoRemoveChildView()
    #11 0x5631a403a175 views::View::RemoveAllChildViews()
    #12 0x5631a4043b81 views::internal::RootView::~RootView()
    #13 0x5631a400ef0e views::MenuHostRootView::~MenuHostRootView()
    #14 0x5631a404615f views::Widget::~Widget()
    #15 0x5631a34d645e exo::(anonymous namespace)::ShellSurfaceWidget::~ShellSurfaceWidget()
    #16 0x5631a30c36f0 ash::LoginTestBase::TearDown()
    
    Original change's description:
    > cros: Move most event/widget handling logic out of LoginBubble
    > 
    > Changes made:
    > - Move the (keyboard/click/tap) event handling logic into a
    >   LoginBubbleHandler class.
    > - Move the widget handling into LoginBaseBubbleView itself
    > 
    > Bug: 912658
    > Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366516
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614544}
    
    TBR=jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Ia9b9059f24f6aa6a8551c5c6bc5c76caafe592df
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 912658
    Reviewed-on: https://chromium-review.googlesource.com/c/1367070
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614579}

    Changed files

    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble.h
  55. Revert "Updating XTBs based on .GRDs from branch master"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df02e792b693ed5007b5c8c4866203219bedfd20

    Comments

    Revert "Updating XTBs based on .GRDs from branch master"
    
    This reverts commit c7424053a784c4d07dcd4617d68a1f2ac7f9657b.
    
    Reason for revert: suspect Android compile failure:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927834375124899248/+/steps/compile/0/stdout
    ---
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:364 Inconsistent number of arguments in formatting string `data_reduction_benefits_description`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_benefits_description">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:389 Inconsistent number of arguments in formatting string `data_reduction_promo_summary`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_promo_summary">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins. La technologie cloud de Google optimise les pages que vous consultez."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Original change's description:
    > Updating XTBs based on .GRDs from branch master
    > 
    > R=​abdulsyed@chromium.org
    > 
    > Change-Id: Ibc94ee5be9db75306313d34881e4026a681eec1d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366870
    > Reviewed-by: Krishna Govind <govind@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614569}
    
    TBR=govind@chromium.org,abdulsyed@chromium.org
    
    Change-Id: I4dfd803c9c148e5d6e3335d11e06fd61728fe548
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1366465
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614578}

    Changed files

    • ash/components/strings/ash_components_strings_te.xtb
    • ash/strings/ash_strings_am.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_ca.xtb
    • ash/strings/ash_strings_cs.xtb
    • ash/strings/ash_strings_de.xtb
    • ash/strings/ash_strings_el.xtb
    • ash/strings/ash_strings_en-GB.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fr.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hr.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_id.xtb
    • ash/strings/ash_strings_it.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_lv.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_nl.xtb
    • ash/strings/ash_strings_pl.xtb
    • ash/strings/ash_strings_pt-BR.xtb
    • ash/strings/ash_strings_pt-PT.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_sk.xtb
    • ash/strings/ash_strings_sl.xtb
    • ash/strings/ash_strings_sr.xtb
    • ash/strings/ash_strings_sv.xtb
    • ash/strings/ash_strings_sw.xtb
    • ash/strings/ash_strings_te.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_te.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/app/resources/chromium_strings_te.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_te.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_am.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bg.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_cs.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_da.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_el.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_id.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_it.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ms.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_nl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_no.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-BR.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_uk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • extensions/strings/extensions_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • remoting/resources/remoting_strings_am.xtb
    • remoting/resources/remoting_strings_ar.xtb
    • remoting/resources/remoting_strings_bn.xtb
    • remoting/resources/remoting_strings_es.xtb
    • remoting/resources/remoting_strings_gu.xtb
    • remoting/resources/remoting_strings_hu.xtb
    • remoting/resources/remoting_strings_id.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_lt.xtb
    • remoting/resources/remoting_strings_lv.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_ru.xtb
    • remoting/resources/remoting_strings_sl.xtb
    • remoting/resources/remoting_strings_sr.xtb
    • remoting/resources/remoting_strings_te.xtb
    • remoting/resources/remoting_strings_th.xtb
    • remoting/resources/remoting_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
    • ui/chromeos/translations/ui_chromeos_strings_te.xtb
  56. Revert "Enable warmer welcome during Assistant launch."

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 02:41:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c71812f1007dae45bce45b451c384bf9c0dbd356

    Comments

    Revert "Enable warmer welcome during Assistant launch."
    
    This reverts commit 29dca9fe6ae866266c976809adc33c09a2ca1088.
    
    Reason for revert:
      ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found
      #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h"
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 error generated.
    
    https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/59389/+/recipes/steps/compile/0/stdout
    
    Original change's description:
    > Enable warmer welcome during Assistant launch.
    > 
    > 1. It is guarded by a finch flag AssistantWarmerWelcome.
    > 2. WW only shows 3 times.
    > 
    > Bug: b:112495005
    > Test: Manual
    > 
    > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3
    > Reviewed-on: https://chromium-review.googlesource.com/c/1355174
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Commit-Queue: Yilei Li <yileili@google.com>
    > Cr-Commit-Position: refs/heads/master@{#614553}
    
    TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wfh@chromium.org,dmblack@google.com,wutao@chromium.org,yileili@google.com
    
    Change-Id: Ib5749ef1c003be49d4923c364d8499b43a2abcf5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:112495005
    Reviewed-on: https://chromium-review.googlesource.com/c/1366873
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614577}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h