Home | Search | chromium - Builders
Login

Builder TSAN Debug Build 60524 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionc7586428da170b5323c25305dd3e213c38c6aa41
Got Revisionc7586428da170b5323c25305dd3e213c38c6aa41

Execution:

Steps and Logfiles:

Show:
  1. ( 307 ms ) setup_build
    running recipe: "chromium"
  2. ( 221 ms ) report builders
     
    running builder 'TSAN Debug' on master 'chromium.lkgr'
  3. ( 44 secs ) bot_update
    [100GB/295GB used (33%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 3 secs ) clobber
  6. ( 9 secs ) gclient runhooks
  7. ( 473 ms ) lookup GN args
     
    enable_nacl = false
    is_component_build = true
    is_debug = true
    is_tsan = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 564 ms ) clang_revision
  9. ( 5 mins 56 secs ) compile
  10. ( 456 ms ) create staging_dir
  11. ( 466 ms ) Copy sancov
  12. ( 690 ms ) filter build_dir
  13. ( 1 mins 29 secs ) zipping
  14. ( 16 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1951-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541786339695433, "id": "8930313563025712336", "project": "chromium", "tags": ["builder:TSAN Debug", "buildset:commit/git/c7586428da170b5323c25305dd3e213c38c6aa41", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/c7586428da170b5323c25305dd3e213c38c6aa41", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095743625302973776", "scheduler_job_id:chromium/TSAN Debug", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "TSAN Debug" setup_build
buildnumber 60524 setup_build
mastername "chromium.lkgr" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "c7586428da170b5323c25305dd3e213c38c6aa41" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "c7586428da170b5323c25305dd3e213c38c6aa41" bot_update
got_revision_cp "refs/heads/master@{#606894}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
got_clang_revision "346388-1" clang_revision

Blamelist:

  1. Mario Sanchez Prada (marioohnoyoudont@igalia.com)

Timing:

Create Friday, 09-Nov-18 17:58:59 UTC
Start Friday, 09-Nov-18 17:59:01 UTC
End Friday, 09-Nov-18 18:08:48 UTC
Pending 1 secs
Execution 9 mins 46 secs

All Changes:

  1. Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager

    Changed by Mario Sanchez Prada - marioohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 17:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7586428da170b5323c25305dd3e213c38c6aa41

    Comments

    Migrate clear_browsing_data_collection_view_controller_unittest.mm to IdentityManager
    
    Use IdentityTestEnvironmentChromeBrowserStateAdaptor instead of manually
    creating the browser's state by providing specific factories, and then
    use the APIs from IdentityTestEnvironment, instead of SigninManagerBase.
    
    Also remove an unnecessary DCHECK in clear_browsing_data_manager_unittest.mm,
    as pointed out post-review when fixing crbug.com/890826 (CL 1318974).
    
    Bug: 903703
    Change-Id: I9d4dd625441005a36c962628fe3fe1f15ab56bb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1328985
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#606894}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller_unittest.mm
    • ios/chrome/browser/ui/settings/clear_browsing_data_manager_unittest.mm