Home | Search | chromium - Builders
Login

Builder TSAN Debug Build 39400 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision90520e430b08a292bd878117370d0a7e68eb38bc
Got Revision90520e430b08a292bd878117370d0a7e68eb38bc

Execution:

Steps and Logfiles:

Show:
  1. ( 261 ms ) setup_build
    running recipe: "chromium"
  2. ( 430 ms ) remove .cipd
  3. ( 33 secs ) bot_update
    [59GB/295GB used (20%)]
  4. ( 0 ) ensure_goma
  5. ( 538 ms ) swarming.py --version
    0.13
  6. ( 4 secs ) clobber
  7. ( 12 secs ) gclient runhooks
  8. ( 556 ms ) clang_revision
  9. ( 6 mins 18 secs ) compile
  10. ( 421 ms ) create staging_dir
  11. ( 455 ms ) Copy sancov
  12. ( 592 ms ) filter build_dir
  13. ( 1 mins 12 secs ) zipping
  14. ( 12 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1951-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531414677602070, "id": "8941189038977225232", "project": "chromium", "tags": ["builder:TSAN Debug", "buildset:commit/git/90520e430b08a292bd878117370d0a7e68eb38bc", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/90520e430b08a292bd878117370d0a7e68eb38bc", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106619101157219104", "scheduler_job_id:chromium/TSAN Debug", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "TSAN Debug" setup_build
buildnumber 39400 setup_build
mastername "chromium.lkgr" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "90520e430b08a292bd878117370d0a7e68eb38bc" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "90520e430b08a292bd878117370d0a7e68eb38bc" bot_update
got_revision_cp "refs/heads/master@{#574604}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
got_clang_revision "336424-1" clang_revision

Blamelist:

  1. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  2. Colin Blundell (blundellohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:57:57 UTC
Start Thursday, 12-Jul-18 16:58:00 UTC
End Thursday, 12-Jul-18 17:07:41 UTC
Pending 2 secs
Execution 9 mins 41 secs

All Changes:

  1. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc

    Comments

    [unified-consent] Add unity logic to OneClickSigninSyncStarter
    
    All unified consent services are enabled when the unified
    consent is given through the OneClickSigninSyncStarter.
    
    Bug: 862202
    Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
    Reviewed-on: https://chromium-review.googlesource.com/1135001
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h
  2. Revert "Have Device Service observe MessageLoop destruction"

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"
    
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.
    
    Bug: 856771, 794105
    
    Original change's description:
    > Have Device Service observe MessageLoop destruction
    >
    > The Device Service needs to clean up parts of its internal state as part
    > of browser shutdown. However, it also needs to run on the UI thread,
    > and embedded services that run on the UI thread are not guaranteed to
    > be destroyed as part of browser shutdown (tasks to destroy these
    > services are posted from the IO thread by
    > ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
    > typically shut down before these posted tasks are run).
    >
    > To solve this issue we discussed adding plumbing wherein embedded
    > services could inform //content that they wanted to be notified when
    > shutdown was occurring on the main thread. However, on investigation
    > this plumbing would be painful to implement: it is only
    > EmbeddedInstanceManager that has direct information of these service
    > instances, and that object lives far away from //content's
    > ServiceManagerContext, the object that knows when shutdown is occurring
    > on the main thread.
    >
    > This CL takes an alternative approach of having the Device Service
    > implementation observe the destruction of its MessageLoop. I have
    > verified that the observation is triggered on shutdown of Chrome.
    >
    > Bug: 794105
    > Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
    > Reviewed-on: https://chromium-review.googlesource.com/1099245
    > Commit-Queue: Colin Blundell <blundell@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    
    TBR=rockot@chromium.org,blundell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h