Home | Search | chromium - Builders
Login

Builder Nougat Phone Tester Build 8109 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisiondf02e792b693ed5007b5c8c4866203219bedfd20
Got Revisiondf02e792b693ed5007b5c8c4866203219bedfd20

Execution:

Steps and Logfiles:

Show:
  1. ( 351 ms ) setup_build
    running recipe: "chromium"
  2. ( 677 ms ) report builders
     
    running tester 'Nougat Phone Tester' on master 'chromium.android'
  3. ( 5 mins 15 secs ) bot_update
    [61GB/295GB used (20%)]
  4. ( 1 secs ) swarming.py --version
    0.14
  5. ( 47 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 519 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 16 secs ) clean local files
  9. ( 13 secs ) tree truth steps
  10. ( 470 ms ) build directory
  11. ( 990 ms ) find isolated tests
  12. ( 8 mins 10 secs ) wait for tasks
  13. ( 5 secs ) chrome_public_test_vr_apk-ddready-dynamicsettings on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 43s
    Shard duration: 0:05:56.833543
  14. ( 8 mins 2 secs ) wait for tasks (2)
  15. ( 3 secs ) chrome_public_test_vr_apk-ddready-cardboard on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 14s
    Shard duration: 0:15:53.622275
  16. ( 19 mins 11 secs ) chrome_public_test_vr_apk-ddready-ddview on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 36s
    Shard duration: 0:34:50.758490
  17. ( 228 ms ) Tests statistics
     
    Stats
    Total shards: 3
    Total runtime: 0:55:10.760770
     
  18. ( 251 ms ) test_report

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm376-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544158295954278, "id": "8927826386619864960", "project": "chromium", "tags": ["builder:Nougat Phone Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/df02e792b693ed5007b5c8c4866203219bedfd20", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm64 Builder (dbg)", "parent_buildnumber:34443", "scheduler_invocation_id:9093256448759571552", "scheduler_job_id:chromium/Nougat Phone Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Nougat Phone Tester" setup_build
buildnumber 8109 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm64 Builder (dbg)" setup_build
parent_got_angle_revision "132d15c217e0363626a5d789861b75122f718b5d" setup_build
parent_got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" setup_build
parent_got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" setup_build
parent_got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" setup_build
parent_got_revision "df02e792b693ed5007b5c8c4866203219bedfd20" setup_build
parent_got_revision_cp "refs/heads/master@{#614578}" setup_build
parent_got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" setup_build
parent_got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" setup_build
parent_got_v8_revision_cp "refs/heads/7.3.55@{#1}" setup_build
parent_got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25919}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "df02e792b693ed5007b5c8c4866203219bedfd20" setup_build
swarm_hashes {"android_webview_unittests": "265fcc14dc5ceb65d8a09a56a32bdcd09a3b9ed1", "angle_unittests": "0477d5556ee3c736b5fcc186ef08350ebf55bf2d", "base_unittests": "37549c25155a64fa320ddf5b121a8623087af618", "blink_common_unittests": "acf8b638bdfa68334d1819de00f69c39b9b372a9", "blink_heap_unittests": "b91678bf939c6db4127838f881ad42bfe77e0c36", "blink_platform_unittests": "b62f25b611e0b41a5a55e3abcbc82aacd0493e9e", "boringssl_crypto_tests": "2cacbf668613d43636077f9041cc29668a4b8ec8", "boringssl_ssl_tests": "f971a6eced170e7992b84dbc466ed6d45dda3fde", "breakpad_unittests": "0b2793b9218551e4007692d0963e7064e9e3d92f", "cacheinvalidation_unittests": "2d123bdc69bc3d4002db0d7d686ce843ee3e3c23", "capture_unittests": "0dadc7c122e9b510d9545135cc963cf6067bf4db", "cast_unittests": "e77fef23c0d4b90ac50947f067933c7a720c4a07", "cc_unittests": "abd6b2b91b9d1ce2360eab97a614a3acf1829164", "chrome_public_test_apk": "bf973d4841cc44d6ad9f1af5b5f20d1a8b1df65b", "chrome_public_test_vr_apk": "bacdf158cc2d967e843ac2dc6353f6596cd48751", "components_browsertests": "0a85efb270c7d97239c875c2850f395dd52142f3", "components_unittests": "c80fa6fa2a3d2f97a8f881bc7620ba3c846f6586", "content_browsertests": "920f87580b0de4d2dd6c2015b03df372dc7623eb", "content_shell_test_apk": "e95cfd3a035a04a74ee9a415a0d5bafe055b0e76", "content_unittests": "488e3f8072a01f737e816b806d3271f00c919faf", "crypto_unittests": "6c5835d4b3a529dd0e0a247405391f2735588bc3", "device_unittests": "e30c7672720a9dac09ebe0dce7dd3f7bdb56cb83", "display_unittests": "8b2e0c76b78ef3a4f233198dffecffb79b93bcbb", "events_unittests": "dcb1cf3d8f6e1838fe6d638c94c2b8eb5d682352", "gcm_unit_tests": "cfd5b029bfa851a0ea76404ee574b4d7acdbaeb2", "gfx_unittests": "5b78435fbf4fe7c23ac5454bd78ce8af71a699f1", "gin_unittests": "21f0cc6fa38d36489178d1b0cf08532c512b3983", "gl_tests": "57e86b22f13d7e222d2104745ea699c5c0eafbe4", "gl_unittests": "fe60d9629001b3c6673be9143e152c4f6fd03ffd", "google_apis_unittests": "e27ea625a297c9a4dbebc0ed21b4bc33b7075ec9", "gpu_unittests": "2d68718ab73191c29fdde83e1e709a44b651a9da", "ipc_tests": "44ed8763c4f1498840c37848deb22c6db6f233ba", "jingle_unittests": "60cdb035fed98af1ed8dac9f822c0517d0598bfe", "latency_unittests": "4d7548725fccd850689de74588e4e38f82e953b6", "libjingle_xmpp_unittests": "df4d355d80d241500c9d8d7d71a3aae21ebcd8bb", "media_blink_unittests": "32f85c6ee0f1f42793e7d4244264a5a283e0fa95", "media_service_unittests": "a6fbce5203212637ecd2062fe15d27bcde19c686", "media_unittests": "e6f2388f20063949ba448639688c7196b33a67a7", "midi_unittests": "d2a20724caca1a77ce3cd8cb8c6b90a3d87101ac", "mojo_test_apk": "27b9625ed39070277b1d98640ac7eaf949622795", "mojo_unittests": "f2b34d2a7800c64d5d9ff0cbf414ea117a5ae738", "monochrome_public_test_ar_apk": "41e2cf6d5425081d260ec2b6f6eab9f3c70da275", "net_unittests": "c6c45e98bddec4c051b691f56c9cefe80f10f4ca", "sandbox_linux_unittests": "3e7be3f298bd0b250a7d0fbe09bf6694c36cd3e0", "services_unittests": "5f83d3d29d11d308f19af5e72fa65dc73a82cef7", "shell_dialogs_unittests": "d39697c43df9505527fb33dfa16070f31f676fdf", "skia_unittests": "83a633600346d7767507ca79689156e2add6fe92", "sql_unittests": "ba8575f360cb793864b6353a4248fbc91fd7287c", "storage_unittests": "26e68aa133d0f06cdeb5097a289a77ea4db06a75", "ui_android_unittests": "6cc756fd7e845c267c06540c8e50ec496b23b0d8", "ui_base_unittests": "2ad824c703009ce3279e1c698834ec7a856ed1cd", "ui_touch_selection_unittests": "f6a9a854b92d552bc43656e9747d59308a2f3ca4", "unit_tests": "402883c8b4e73fa4ab15a48028e94ab86662e716", "url_unittests": "b1b1741b0259662f34ea5edeaaec1f9f0c42382b", "viz_unittests": "5b0b306bc55a4dfd5782c7f3fd14ce34fec0fefb", "vr_android_unittests": "147e26fc7948bce6e33facb06a109a72808b505d", "vr_common_unittests": "69cfb746d8a2f2f327b3116fe3b3a115cd26950e", "vr_pixeltests": "7cc3ae88e5d35c122f1372fb4748a19a357b57a4", "webkit_unit_tests": "7e0a94721d0d9aa89716507e162cae52e7b39eab", "webview_cts_tests": "54d32ece11989d5d820111dcb31f9fb7350c3a95", "webview_instrumentation_test_apk": "d35d62735fe16d9c016a51cc5330aa94fdca2057", "wtf_unittests": "196c5889cd077eae1832a8e259ce7cdbde690d71"} setup_build
got_angle_revision "132d15c217e0363626a5d789861b75122f718b5d" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "17af1e818981ebf2c492a678d4d31c9e1ee37fc7" bot_update
got_revision "df02e792b693ed5007b5c8c4866203219bedfd20" bot_update
got_revision_cp "refs/heads/master@{#614578}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "2192eb7f7ea45e3a7ee625cf3156f1469abed8b8" bot_update
got_v8_revision_cp "refs/heads/7.3.55@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Takashi Sakamoto (tasakohnoyoudont@google.com)
  2. Dan Beam (dbeamohnoyoudont@chromium.org)
  3. Reka Norman (rekanormanohnoyoudont@google.com)
  4. Paul Irish (paulirishohnoyoudont@chromium.org)
  5. Daniel Ng (danielngohnoyoudont@google.com)
  6. Jeffrey Yasskin (jyasskinohnoyoudont@chromium.org)
  7. Piotr Bialecki (bialpioohnoyoudont@chromium.org)
  8. Max Moroz (mmorozohnoyoudont@chromium.org)
  9. Dan Beam (dbeamohnoyoudont@chromium.org)
  10. Krishna Govind (govindohnoyoudont@chromium.org)
  11. Carlos IL (carlosilohnoyoudont@chromium.org)
  12. Xing Liu (xingliuohnoyoudont@chromium.org)
  13. Caleb Rouleau (crouleauohnoyoudont@chromium.org)
  14. Kenichi Ishibashi (bashiohnoyoudont@chromium.org)
  15. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  16. Aiden Benner (abennerohnoyoudont@google.com)
  17. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  18. Dan Beam (dbeamohnoyoudont@chromium.org)
  19. Min Chen (minchohnoyoudont@google.com)
  20. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  21. Zhongyi Shi (zhongyiohnoyoudont@chromium.org)
  22. Evan Stade (estadeohnoyoudont@chromium.org)
  23. Sam McNally (sammcohnoyoudont@chromium.org)
  24. Jazz Xu (jazzhsuohnoyoudont@chromium.org)
  25. siyua (siyuaohnoyoudont@chromium.org)
  26. yileili (yileiliohnoyoudont@google.com)
  27. Tom Anderson (thomasandersonohnoyoudont@chromium.org)
  28. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  29. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  30. Mark (mtlieuuohnoyoudont@chromium.org)
  31. David Black (dmblackohnoyoudont@google.com)
  32. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  33. Noel Gordon (noelohnoyoudont@chromium.org)
  34. Jeffrey Yasskin (jyasskinohnoyoudont@chromium.org)
  35. Quan Nguyen (qnnguyenohnoyoudont@chromium.org)
  36. Matt Giuca (mgiucaohnoyoudont@chromium.org)
  37. Yusuke Sato (yusukesohnoyoudont@chromium.org)
  38. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  39. Oystein Eftevaag (oysteineohnoyoudont@google.com)
  40. Aga Wronska (agawronskaohnoyoudont@chromium.org)
  41. Reilly Grant (reillygohnoyoudont@chromium.org)
  42. Xi Han (hanxiohnoyoudont@google.com)
  43. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  44. Lukasz Anforowicz (lukaszaohnoyoudont@chromium.org)
  45. Max Moroz (mmorozohnoyoudont@chromium.org)
  46. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  47. Robert Sesek (rsesekohnoyoudont@chromium.org)
  48. Dan Beam (dbeamohnoyoudont@chromium.org)
  49. Esmael El-Moslimany (aeeohnoyoudont@chromium.org)
  50. Reilly Grant (reillygohnoyoudont@chromium.org)
  51. Jeffrey Yasskin (jyasskinohnoyoudont@chromium.org)
  52. Zhiqiang Zhang (zqzhangohnoyoudont@google.com)
  53. Ned Nguyen (nednguyenohnoyoudont@google.com)
  54. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  55. chcunningham (chcunninghamohnoyoudont@chromium.org)
  56. danakj (danakjohnoyoudont@chromium.org)
  57. Philip Rogers (pdrohnoyoudont@chromium.org)
  58. bsheedy (bsheedyohnoyoudont@chromium.org)
  59. Josh Karlin (jkarlinohnoyoudont@chromium.org)
  60. Erik Jensen (rkjnsnohnoyoudont@chromium.org)
  61. Vikas Soni (vikassoniohnoyoudont@chromium.org)
  62. sebsg (sebsgohnoyoudont@chromium.org)
  63. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  64. James Cook (jamescookohnoyoudont@chromium.org)
  65. Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
  66. CJ DiMeglio (lethalantidoteohnoyoudont@chromium.org)
  67. Daniel Murphy (dmurphohnoyoudont@chromium.org)
  68. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  69. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  70. Clark DuVall (cduvallohnoyoudont@chromium.org)
  71. Sam Maier (smaierohnoyoudont@chromium.org)
  72. Jason Guo (jiahuiguoohnoyoudont@chromium.org)
  73. Lukasz Anforowicz (lukaszaohnoyoudont@chromium.org)
  74. David Lu (davidluphdohnoyoudont@google.com)
  75. Alex Newcomer (newcomerohnoyoudont@chromium.org)
  76. Scott Chen (scottchenohnoyoudont@chromium.org)
  77. Nico Weber (thakisohnoyoudont@chromium.org)
  78. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  79. Cary Clark (caryclarkohnoyoudont@google.com)
  80. Eugene But (eugenebutohnoyoudont@google.com)
  81. Robert Ogden (robertogdenohnoyoudont@chromium.org)
  82. Ayu Ishii (ayuiohnoyoudont@chromium.org)
  83. Jeffrey Yasskin (jyasskinohnoyoudont@chromium.org)
  84. Eric Roman (eromanohnoyoudont@chromium.org)
  85. Fabrice de Gans-Riberi (fdegansohnoyoudont@chromium.org)
  86. John Budorick (jbudorickohnoyoudont@chromium.org)
  87. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  88. Yue Cen (rsgingerrsohnoyoudont@chromium.org)
  89. Bence Béky (bncohnoyoudont@chromium.org)
  90. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  91. Clark DuVall (cduvallohnoyoudont@chromium.org)
  92. Nick Harper (nharperohnoyoudont@chromium.org)
  93. Daniel Rubery (druberyohnoyoudont@chromium.org)
  94. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  95. Jun Cai (juncaiohnoyoudont@chromium.org)
  96. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  97. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  98. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  99. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  100. danakj (danakjohnoyoudont@chromium.org)
  101. <blame list capped at 100 commits> ()

Timing:

Create Friday, 07-Dec-18 04:51:35 UTC
Start Friday, 07-Dec-18 04:52:27 UTC
End Friday, 07-Dec-18 05:35:46 UTC
Pending 51 secs
Execution 43 mins 18 secs

All Changes:

  1. Revert "Updating XTBs based on .GRDs from branch master"

    Changed by Takashi Sakamoto - tasakohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 03:43:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df02e792b693ed5007b5c8c4866203219bedfd20

    Comments

    Revert "Updating XTBs based on .GRDs from branch master"
    
    This reverts commit c7424053a784c4d07dcd4617d68a1f2ac7f9657b.
    
    Reason for revert: suspect Android compile failure:
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-rel
    https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927834375124899248/+/steps/compile/0/stdout
    ---
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:364 Inconsistent number of arguments in formatting string `data_reduction_benefits_description`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_benefits_description">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../resource_zips/chrome/android/chrome_strings_grd.resources.zip/values-fr/android_chrome_strings.xml:389 Inconsistent number of arguments in formatting string `data_reduction_promo_summary`; found both 0 and 1: StringFormatCount [warning]
    <string name="data_reduction_promo_summary">"En mode simplifié, Chrome charge les pages plus rapidement et consomme jusqu\'à 60 % de données en moins. La technologie cloud de Google optimise les pages que vous consultez."</string>
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Original change's description:
    > Updating XTBs based on .GRDs from branch master
    > 
    > R=​abdulsyed@chromium.org
    > 
    > Change-Id: Ibc94ee5be9db75306313d34881e4026a681eec1d
    > Reviewed-on: https://chromium-review.googlesource.com/c/1366870
    > Reviewed-by: Krishna Govind <govind@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614569}
    
    TBR=govind@chromium.org,abdulsyed@chromium.org
    
    Change-Id: I4dfd803c9c148e5d6e3335d11e06fd61728fe548
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1366465
    Reviewed-by: Takashi Sakamoto <tasak@google.com>
    Commit-Queue: Takashi Sakamoto <tasak@google.com>
    Cr-Commit-Position: refs/heads/master@{#614578}

    Changed files

    • ash/components/strings/ash_components_strings_te.xtb
    • ash/strings/ash_strings_am.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_ca.xtb
    • ash/strings/ash_strings_cs.xtb
    • ash/strings/ash_strings_de.xtb
    • ash/strings/ash_strings_el.xtb
    • ash/strings/ash_strings_en-GB.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fr.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hr.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_id.xtb
    • ash/strings/ash_strings_it.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_lv.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_nl.xtb
    • ash/strings/ash_strings_pl.xtb
    • ash/strings/ash_strings_pt-BR.xtb
    • ash/strings/ash_strings_pt-PT.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_sk.xtb
    • ash/strings/ash_strings_sl.xtb
    • ash/strings/ash_strings_sr.xtb
    • ash/strings/ash_strings_sv.xtb
    • ash/strings/ash_strings_sw.xtb
    • ash/strings/ash_strings_te.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_te.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/app/resources/chromium_strings_te.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_te.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_am.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bg.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_cs.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_da.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_el.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_id.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_it.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ms.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_nl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_no.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-BR.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_uk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • extensions/strings/extensions_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • remoting/resources/remoting_strings_am.xtb
    • remoting/resources/remoting_strings_ar.xtb
    • remoting/resources/remoting_strings_bn.xtb
    • remoting/resources/remoting_strings_es.xtb
    • remoting/resources/remoting_strings_gu.xtb
    • remoting/resources/remoting_strings_hu.xtb
    • remoting/resources/remoting_strings_id.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_lt.xtb
    • remoting/resources/remoting_strings_lv.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_ru.xtb
    • remoting/resources/remoting_strings_sl.xtb
    • remoting/resources/remoting_strings_sr.xtb
    • remoting/resources/remoting_strings_te.xtb
    • remoting/resources/remoting_strings_th.xtb
    • remoting/resources/remoting_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
    • ui/chromeos/translations/ui_chromeos_strings_te.xtb
  2. Revert "Enable warmer welcome during Assistant launch."

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 02:41:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c71812f1007dae45bce45b451c384bf9c0dbd356

    Comments

    Revert "Enable warmer welcome during Assistant launch."
    
    This reverts commit 29dca9fe6ae866266c976809adc33c09a2ca1088.
    
    Reason for revert:
      ../../chromeos/services/assistant/assistant_manager_service_impl.cc:27:10: fatal error: 'chromeos/services/assistant/assistant_warmer_welcome_log.pb.h' file not found
      #include "chromeos/services/assistant/assistant_warmer_welcome_log.pb.h"
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      1 error generated.
    
    https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/59389/+/recipes/steps/compile/0/stdout
    
    Original change's description:
    > Enable warmer welcome during Assistant launch.
    > 
    > 1. It is guarded by a finch flag AssistantWarmerWelcome.
    > 2. WW only shows 3 times.
    > 
    > Bug: b:112495005
    > Test: Manual
    > 
    > Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3
    > Reviewed-on: https://chromium-review.googlesource.com/c/1355174
    > Reviewed-by: Will Harris <wfh@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Commit-Queue: Yilei Li <yileili@google.com>
    > Cr-Commit-Position: refs/heads/master@{#614553}
    
    TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wfh@chromium.org,dmblack@google.com,wutao@chromium.org,yileili@google.com
    
    Change-Id: Ib5749ef1c003be49d4923c364d8499b43a2abcf5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:112495005
    Reviewed-on: https://chromium-review.googlesource.com/c/1366873
    Reviewed-by: Dan Beam <dbeam@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614577}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  3. [App Management] Add app list

    Changed by Reka Norman - rekanormanohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 02:00:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be2a6c46ff867eec74b7f338a849ef67a86fc546

    Comments

    [App Management] Add app list
    
    This CL adds a list of apps to the main view of the app management page.
    
    Bug: 906508
    
    Change-Id: If6d22ad1d9851d3ce5387027da585005a7987c63
    Reviewed-on: https://chromium-review.googlesource.com/c/1360199
    Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Reka Norman <rekanorman@google.com>
    Cr-Commit-Position: refs/heads/master@{#614576}

    Changed files

    • chrome/browser/resources/app_management/fake_page_handler.js
    • chrome/browser/resources/app_management/main_view.html
    • chrome/browser/resources/app_management/main_view.js
  4. Build hash for PerformanceMeasureEntry trace event with start/end times

    Changed by Paul Irish - paulirishohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:59:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e4f35ef10df237ec8c34460552a6366058b763b

    Comments

    Build hash for PerformanceMeasureEntry trace event with start/end times
    
    Bug: 912363
    Change-Id: I33dfc873765de17ca6f30db850093337f89da5bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1359865
    Commit-Queue: Paul Irish <paulirish@chromium.org>
    Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
    Reviewed-by: Alexei Filippov <alph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614575}

    Changed files

    • third_party/blink/renderer/core/timing/performance_user_timing.cc
    • third_party/blink/renderer/devtools/front_end/performance_test_runner/TimelineTestRunner.js
    • third_party/blink/web_tests/http/tests/devtools/tracing/user-timing-expected.txt
    • third_party/blink/web_tests/http/tests/devtools/tracing/user-timing.js
  5. Roll src/third_party/cros_system_api/ 93d4079d4..8a40e4d49 (4 commits)

    Changed by Daniel Ng - danielngohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:57:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29c1a19896cfa7429ea3bf0628581b08b5710537

    Comments

    Roll src/third_party/cros_system_api/ 93d4079d4..8a40e4d49 (4 commits)
    
    https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/93d4079d4050..8a40e4d4933a
    
    $ git log 93d4079d4..8a40e4d49 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 danielng system_api: Adjusted keywords field to be consistent
    2018-12-05 aoldemeier login: Extend ClearCheckEnrollmentVpd DBus call to also set block_devmode=0.
    2018-12-04 danielng system_api: Added keywords field to apps.proto to improve Crostini app search
    2018-11-27 dtor system_api: add vm_plugin service constants
    
    Created with:
      roll-dep src/third_party/cros_system_api
    
    Change-Id: I13d197a4506648a979b398171ceec69e5d4f23e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1367064
    Reviewed-by: Timothy Loh <timloh@chromium.org>
    Commit-Queue: Timothy Loh <timloh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614574}

    Changed files

    • DEPS
  6. Disable several flaky layout tests.

    Changed by Jeffrey Yasskin - jyasskinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:57:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 63eeea392719b0286deaff68c3cf2970ae41fe40

    Comments

    Disable several flaky layout tests.
    
    virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html can time out.
    http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js can fail.
    virtual/android/fullscreen/full-screen-iframe-allowed-video.html can fail.
    virtual/threaded/fast/scroll-behavior/smooth-scroll/mousewheel-scroll.html can crash.
    rtual/threaded/fast/scroll-behavior/smooth-scroll/scroll-during-selection.html can crash.
    
    Bug: 912793, 874931, 905694
    Change-Id: I06dff11457e545edb7d40c5797096086c066e793
    Tbr: rakina@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1367096
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614573}

    Changed files

    • third_party/blink/web_tests/TestExpectations
  7. Enable vr android unittest

    Changed by Piotr Bialecki - bialpioohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:55:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46627f0be79549d2fcf68f44ad2add435b1081b2

    Comments

    Enable vr android unittest
    
    Bug: 837834
    Change-Id: Id60061bc4ebd4a690796f3b6c36c99957d8f9520
    Reviewed-on: https://chromium-review.googlesource.com/c/1362469
    Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614572}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/test_suites.pyl
  8. Switch libFuzzer Linux UBSan and Mac ASan builds back to non component build.

    Changed by Max Moroz - mmorozohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:52:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d48afa2cac78c959fb3f3fdbd61f0716916d972b

    Comments

    Switch libFuzzer Linux UBSan and Mac ASan builds back to non component build.
    
    Bug: 701825, 911856
    
    Change-Id: Ifd0dc249546f05e81233917a19d0c37f329f7fed
    Reviewed-on: https://chromium-review.googlesource.com/c/1366323
    Commit-Queue: Abhishek Arya <inferno@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Reviewed-by: Abhishek Arya <inferno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614571}

    Changed files

    • tools/mb/mb_config.pyl
  9. Downloads: separate BrowserProxy from Mojo classes for clarity

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:41:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af08a78177b3a33571ff54a367494cd83003aecd

    Comments

    Downloads: separate BrowserProxy from Mojo classes for clarity
    
    R=calamity@chromium.org,dpapad@chromium.org
    BUG=855259
    
    Change-Id: I8e3ea89831ce9c39ac05afa0d4f18c1c51c3a8cb
    Reviewed-on: https://chromium-review.googlesource.com/c/1364233
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614570}

    Changed files

    • chrome/browser/resources/md_downloads/item.js
    • chrome/browser/resources/md_downloads/manager.js
    • chrome/browser/resources/md_downloads/search_service.js
    • chrome/browser/resources/md_downloads/toolbar.js
    • chrome/test/data/webui/md_downloads/downloads_browsertest.js
    • chrome/test/data/webui/md_downloads/manager_tests.js
    • chrome/test/data/webui/md_downloads/test_support.js
  10. Updating XTBs based on .GRDs from branch master

    Changed by Krishna Govind - govindohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:35:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7424053a784c4d07dcd4617d68a1f2ac7f9657b

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=abdulsyed@chromium.org
    
    Change-Id: Ibc94ee5be9db75306313d34881e4026a681eec1d
    Reviewed-on: https://chromium-review.googlesource.com/c/1366870
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614569}

    Changed files

    • ash/components/strings/ash_components_strings_te.xtb
    • ash/strings/ash_strings_am.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_ca.xtb
    • ash/strings/ash_strings_cs.xtb
    • ash/strings/ash_strings_de.xtb
    • ash/strings/ash_strings_el.xtb
    • ash/strings/ash_strings_en-GB.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fr.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hr.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_id.xtb
    • ash/strings/ash_strings_it.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_lv.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_nl.xtb
    • ash/strings/ash_strings_pl.xtb
    • ash/strings/ash_strings_pt-BR.xtb
    • ash/strings/ash_strings_pt-PT.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_sk.xtb
    • ash/strings/ash_strings_sl.xtb
    • ash/strings/ash_strings_sr.xtb
    • ash/strings/ash_strings_sv.xtb
    • ash/strings/ash_strings_sw.xtb
    • ash/strings/ash_strings_te.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_am.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ar.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bg.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_bn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ca.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_cs.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_da.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_de.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_el.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fa.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_gu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_id.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_it.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_iw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_kn.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ml.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_nl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-BR.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_pt-PT.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sv.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ta.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_te.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_uk.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/app/resources/chromium_strings_te.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_te.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_am.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_bg.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ca.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_cs.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_da.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_el.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fa.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_id.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_it.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ms.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_nl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_no.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pl.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-BR.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_pt-PT.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ro.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sv.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_sw.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_uk.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_te.xtb
    • extensions/strings/extensions_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • remoting/resources/remoting_strings_am.xtb
    • remoting/resources/remoting_strings_ar.xtb
    • remoting/resources/remoting_strings_bn.xtb
    • remoting/resources/remoting_strings_es.xtb
    • remoting/resources/remoting_strings_gu.xtb
    • remoting/resources/remoting_strings_hu.xtb
    • remoting/resources/remoting_strings_id.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_lt.xtb
    • remoting/resources/remoting_strings_lv.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_ru.xtb
    • remoting/resources/remoting_strings_sl.xtb
    • remoting/resources/remoting_strings_sr.xtb
    • remoting/resources/remoting_strings_te.xtb
    • remoting/resources/remoting_strings_th.xtb
    • remoting/resources/remoting_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_am.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ar.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bg.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_bn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ca.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_cs.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_da.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_de.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_el.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_en-GB.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es-419.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_es.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_et.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fa.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fil.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_fr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_gu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_hu.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_it.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_iw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ja.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_kn.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ko.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lt.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_lv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ml.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_mr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ms.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_nl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_no.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-BR.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_pt-PT.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ru.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sl.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sv.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_sw.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_ta.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_th.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_tr.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_uk.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_vi.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-CN.xtb
    • third_party/libaddressinput/chromium/resources/address_input_strings_zh-TW.xtb
    • ui/chromeos/translations/ui_chromeos_strings_te.xtb
  11. Disable following redirects when fetching variations seed

    Changed by Carlos IL - carlosilohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:34:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f41f5c44a8d1c9cabf4c630d9d1c27fd05b46c6e

    Comments

    Disable following redirects when fetching variations seed
    
    Bug: 902727
    Change-Id: I0f69b49819b8bf6182ea09bea5fa543689e2e5fd
    Reviewed-on: https://chromium-review.googlesource.com/c/1330691
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614568}

    Changed files

    • components/variations/service/variations_service.cc
    • components/variations/service/variations_service.h
    • components/variations/service/variations_service_unittest.cc
  12. Download home: downloads on SD card will still show after removing SD card.

    Changed by Xing Liu - xingliuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:33:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aacfc18fb9196187ac79f625e20e199bb1a6edfd

    Comments

    Download home: downloads on SD card will still show after removing SD card.
    
    In legacy download home UI, we still show downloads on SD card after
    removing the SD card. New download home should also check that.
    
    Bug: 907678
    Change-Id: Ia62db72d42d320fd150d73c29c4686956f65bb17
    Reviewed-on: https://chromium-review.googlesource.com/c/1366281
    Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
    Commit-Queue: Xing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614567}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/InvalidStateOfflineItemFilter.java
  13. Disable system_health.common_desktop/multitab on Win 10

    Changed by Caleb Rouleau - crouleauohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:32:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a14fdf87276e7460ccd4d18a5eba301514bd3ad

    Comments

    Disable system_health.common_desktop/multitab on Win 10
    
    NOTRY=true
    
    Bug: 911214
    Change-Id: Ia853c50260f4a46835818ef4b364b4ee97091244
    Reviewed-on: https://chromium-review.googlesource.com/c/1367109
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614566}

    Changed files

    • tools/perf/expectations.config
  14. service worker: Fix inconsistencies in fetch timing histograms

    Changed by Kenichi Ishibashi - bashiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:31:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 076901524c18ebf5b9736c86a8dd6bdf5c976222

    Comments

    service worker: Fix inconsistencies in fetch timing histograms
    
    In https://crrev.com/c/1350433 I updated some histograms for fetch
    resource timing. The intention was to change the upper limit of these
    histogram from 10 secs to 3 mins but I wrongly updated histograms.xml.
    Specifically I should have updated histograms.xml like:
    - MainResource.ForwardServiceWorkerToWorkerReady
      -> MainResource.ForwardServiceWorkerToWorkerReady2
    - Subresource.ResponseReceivedToCompleted
      -> Subresource.ResponseReceivedToCompleted2
    
    But what I did was:
    - MainResource.ResponseReceivedToCompleted
      -> MainResource.ResponseReceivedToCompleted2
    - Subresource.ForwardServiceWorkerToWorkerReady
      -> Subresource.ForwardServiceWorkerToWorkerReady2
    
    This CL fixes the inconsistencies. As for ResponseReceivedToCompleted,
    it would be better to use 3 mins upper limit so I added it for main
    resource.
    
    Bug: 877972
    Change-Id: Ic28b5c523de7f4c150ca9cd79bf183ff37e2667d
    Reviewed-on: https://chromium-review.googlesource.com/c/1364931
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614565}

    Changed files

    • content/browser/service_worker/service_worker_navigation_loader.cc
    • content/browser/service_worker/service_worker_navigation_loader_unittest.cc
    • tools/metrics/histograms/histograms.xml
  15. Update V8 to version 7.3.55.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:29:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82c8cc4343c538607b27ce24f40f4d5b36ccbdd7

    Comments

    Update V8 to version 7.3.55.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c5bfa5d3..2192eb7f
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ic315808cf6ce5ace0442754b2f32d7ab9742d77b
    Reviewed-on: https://chromium-review.googlesource.com/c/1366781
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614564}

    Changed files

    • DEPS
  16. JNI: Add test rule and sample test for mockable natives

    Changed by Aiden Benner - abennerohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:29:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46aec5fe972e09c1807a161c5ad8a70fd4a7428e

    Comments

    JNI: Add test rule and sample test for mockable natives
    
    Bug: 898261
    Change-Id: Ie1e5c545bdf23adc232bee0c34abde3413c4f943
    Reviewed-on: https://chromium-review.googlesource.com/c/1348632
    Commit-Queue: Aiden Benner <abenner@google.com>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614563}

    Changed files

    • base/BUILD.gn
    • base/android/jni_generator/jni_generator.py
    • base/android/junit/src/org/chromium/base/AnimationFrameTimeHistogramTest.java
    • base/test/android/javatests/src/org/chromium/base/test/util/JniMocker.java
    • build/config/android/rules.gni
  17. Roll src/third_party/pdfium 1498ab8bdf21..f1038808a9c8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:28:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac55ce5ef6e5ec7dbd47ea9a60fc85e0634124ea

    Comments

    Roll src/third_party/pdfium 1498ab8bdf21..f1038808a9c8 (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/1498ab8bdf21..f1038808a9c8
    
    
    git log 1498ab8bdf21..f1038808a9c8 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 bungeman@google.com Roll third_party/freetype/src/ 3dd4e76b1..d01e28f41 (4 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@f1038808a9c8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I750bdd3dbd9dec216c4d44bd90709a0d2ff66c7d
    Reviewed-on: https://chromium-review.googlesource.com/c/1366477
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614562}

    Changed files

    • DEPS
  18. WebUI: Add PromiseResolver#isFulfilled to avoid double resolution/rejection

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:28:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6eba080dcab3baea32ab38db4ced27c82eba927e

    Comments

    WebUI: Add PromiseResolver#isFulfilled to avoid double resolution/rejection
    
    R=dpapad@chromium.org
    BUG=855259
    
    Change-Id: I42160189ba60c849bcb9cd9578f5e27c47c02791
    Reviewed-on: https://chromium-review.googlesource.com/c/1364693
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614561}

    Changed files

    • chrome/test/data/webui/promise_resolver_test.html
    • ui/webui/resources/js/promise_resolver.js
  19. Make splitview drag indicators always have no overlap with shelf.

    Changed by Min Chen - minchohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:27:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10d413c5cc8a8b471a303e0168d947732f6a1369

    Comments

    Make splitview drag indicators always have no overlap with shelf.
    
    See recorded video:
    https://drive.google.com/file/d/0B5I0jFeLxqIiR3dNb1M4andpb3FnZUtCMVR1VkFSa1NhaURz/view?usp=sharing
    
    Bug: 908686
    Change-Id: Id9ef51dfa6e399638a328bed6511036335a2c0c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1364470
    Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Min Chen <minch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614560}

    Changed files

    • ash/wm/splitview/split_view_drag_indicators.cc
    • ash/wm/splitview/split_view_drag_indicators.h
  20. Roll src/third_party/dawn 5aacd29d5e7e..0f50114b3c68 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:27:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ee29e59b62c13d2be986507b62c06a936e2b9b6

    Comments

    Roll src/third_party/dawn 5aacd29d5e7e..0f50114b3c68 (1 commits)
    
    https://dawn.googlesource.com/dawn.git/+log/5aacd29d5e7e..0f50114b3c68
    
    
    git log 5aacd29d5e7e..0f50114b3c68 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 senorblanco@chromium.org Disable/avoid some warnings.
    
    
    Created with:
      gclient setdep -r src/third_party/dawn@0f50114b3c68
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: I5dc6589546fa91ddec2342c9fb1f910d748fb8da
    Reviewed-on: https://chromium-review.googlesource.com/c/1366368
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614559}

    Changed files

    • DEPS
  21. Fix the OnPathResponseFame early return to set should_last_packet_instigate_acks_.

    Changed by Zhongyi Shi - zhongyiohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:26:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a7323b7ffe142f00c131456fe59a7ca22d5d299

    Comments

    Fix the OnPathResponseFame early return to set should_last_packet_instigate_acks_.
    
    This change also reenables QuicStreamFactoryTest.MigrateToProbingSocket
    test.
    
    Bug: 906383
    
    Change-Id: I0166b1fa53cd42d010901ed938030bb730129f60
    Reviewed-on: https://chromium-review.googlesource.com/c/1366765
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614558}

    Changed files

    • net/quic/quic_stream_factory_test.cc
    • net/third_party/quic/core/quic_connection.cc
  22. Disable more single process mash unit_tests on FYI bot.

    Changed by Evan Stade - estadeohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:26:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef2d1ddd17fc707765239e77a78648f9d877ff60

    Comments

    Disable more single process mash unit_tests on FYI bot.
    
    Bug: 905430
    Change-Id: Id99d29f22c625c33679675042ce5f7c8527f0a74
    Reviewed-on: https://chromium-review.googlesource.com/c/1366715
    Reviewed-by: James Cook <jamescook@chromium.org>
    Commit-Queue: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614557}

    Changed files

    • testing/buildbot/filters/chromeos.single_process_mash.fyi.unit_tests.filter
  23. Add ui::SelectFileDialog::FileTypeInfo::ANY_PATH_OR_URL.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:25:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3429b21df57fb03c658e5b63ae81a42f4316a978

    Comments

    Add ui::SelectFileDialog::FileTypeInfo::ANY_PATH_OR_URL.
    
    For most file select dialogs, hosted docs that can only be accessed via
    their URLs are not useful to select. Only browser file-open dialogs can
    meaningfully interact with these virtual files, translating their paths
    into URLs. Other dialogs return unusable file paths that cannot be
    opened as regular files, causing unnecessary and confusing failures.
    
    Add a FileTypeInfo enumerator, ANY_PATH_OR_URL, for clients to opt into
    accepting such virtual files, used by Browser. In dialogs not opting
    into this mode, disallow selecting hosted docs.
    
    Bug: 843881
    Change-Id: I8abc6408e94d60d6e8b3889b0899038c90789119
    Reviewed-on: https://chromium-review.googlesource.com/c/1360451
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614556}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/url_util.cc
    • chrome/browser/ui/browser.cc
    • ui/file_manager/base/js/filtered_volume_manager.js
    • ui/file_manager/base/js/volume_manager_types.js
    • ui/file_manager/file_manager/foreground/css/file_manager.css
    • ui/file_manager/file_manager/foreground/js/constants.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_selection.js
    • ui/file_manager/file_manager/foreground/js/launch_param.js
    • ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
    • ui/file_manager/file_manager/foreground/js/ui/file_table.js
    • ui/file_manager/file_manager/foreground/js/ui/file_table_list.js
    • ui/file_manager/integration_tests/file_manager/file_dialog.js
    • ui/shell_dialogs/select_file_dialog.h
  24. [Media Controls] Fix controls flicker in small size

    Changed by Jazz Xu - jazzhsuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:25:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fd190dee907661320a5bfc5963d615406fffd35

    Comments

    [Media Controls] Fix controls flicker in small size
    
    This CL fixed control layout in small video size by
    adding an estimated width of time display element which
    was default to 0 when its hidden.
    
    Bug: 911062
    Change-Id: I747e465e87fd27eec1ac5ad4720fa79525443f04
    Reviewed-on: https://chromium-review.googlesource.com/c/1358647
    Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
    Reviewed-by: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614555}

    Changed files

    • third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.h
    • third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
    • third_party/blink/web_tests/media/controls/controls-layout-in-different-size.html
  25. [AF Paradise] Change the timing of showing credit card icon in the omnibox

    Changed by siyua - siyuaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1519a34eff922497f280e53a035e019e8f10b436

    Comments

    [AF Paradise] Change the timing of showing credit card icon in the omnibox
    
    Previously when migration dialog was shown, the credit card icon was not
    visible. In this change, we change it to: Credit card icon will always
    be visible when migration dialog is shown.
    
    1) Add more step in LocalCardMigrationFlowStep. The
    MIGRATION_RESULT_PENDING will be used for the animation in the next CL.
    
    2) Use the observer pattern for dialog controller to pass correct state
    to manage_migration_ui_controller when user clicks okay/cancel button.
    
    3) Change the new link navigation to pop-ups since the dialog is
    blocking the browser now.
    
    Bug: 897998
    Change-Id: I32acf9136d1d0298f23cc79ede99f223a01566c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1356260
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614554}

    Changed files

    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/local_card_migration_controller_observer.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
    • chrome/browser/ui/autofill/manage_migration_ui_controller.cc
    • chrome/browser/ui/autofill/manage_migration_ui_controller.h
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.h
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc
    • components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
  26. Enable warmer welcome during Assistant launch.

    Changed by yileili - yileiliohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:24:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29dca9fe6ae866266c976809adc33c09a2ca1088

    Comments

    Enable warmer welcome during Assistant launch.
    
    1. It is guarded by a finch flag AssistantWarmerWelcome.
    2. WW only shows 3 times.
    
    Bug: b:112495005
    Test: Manual
    
    Change-Id: I80cbcfd4104c17172939d36b986be65077bf0bb3
    Reviewed-on: https://chromium-review.googlesource.com/c/1355174
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Yilei Li <yileili@google.com>
    Cr-Commit-Position: refs/heads/master@{#614553}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  27. Add thomasanderson as an OWNER of build

    Changed by Tom Anderson - thomasandersonohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:23:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6948a3c3a89b032ff74eb3a5c9fe78c94e85e670

    Comments

    Add thomasanderson as an OWNER of build
    
    R=dpranke
    
    Change-Id: Ia66eac1ecb07e462699d1d6c9e6b39f60c2bbd05
    Reviewed-on: https://chromium-review.googlesource.com/c/1366493
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614552}

    Changed files

    • build/OWNERS
  28. Roll src/third_party/angle 9092bdc7a76f..132d15c217e0 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:22:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 72f167fc8b19da36c14852436d8723204806f878

    Comments

    Roll src/third_party/angle 9092bdc7a76f..132d15c217e0 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/9092bdc7a76f..132d15c217e0
    
    
    git log 9092bdc7a76f..132d15c217e0 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 jmadill@chromium.org Clear uncleared textures as a dirty object.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@132d15c217e0
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I9029c6290fcfb525efa9e7706c45f24048d1edf4
    Reviewed-on: https://chromium-review.googlesource.com/c/1366479
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614551}

    Changed files

    • DEPS
  29. Roll src/third_party/catapult d18d6c7c7183..5d7bcad36ff4 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:22:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac8ebb246231cdea5872c01e6d596a00462678a3

    Comments

    Roll src/third_party/catapult d18d6c7c7183..5d7bcad36ff4 (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/d18d6c7c7183..5d7bcad36ff4
    
    
    git log d18d6c7c7183..5d7bcad36ff4 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 sky@chromium.org chromeos: close all tabs before running the next test
    2018-12-06 benjhayden@chromium.org Fetch list of sheriffs in v2spa
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@5d7bcad36ff4
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:911777
    TBR=sullivan@chromium.org
    
    Change-Id: If23adcbc8ff79755fd29de43bbc2f838fc7f6da2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366783
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614550}

    Changed files

    • DEPS
  30. Consolidate calls to clock sources to OfflineClock #3

    Changed by Mark - mtlieuuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:21:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 297ccb8018a6c2da5df6cd4e860e6cfc4b395e40

    Comments

    Consolidate calls to clock sources to OfflineClock #3
    
    This change further changes direct calls to Time::Now or the default
    base::Clock instance to an OfflineClock module within classes which
    need a Clock pointer to be passed into the class. This eliminates the
    need for testing-only functions and further allows ease of testing.
    This change is specific to production files and their related tests in:
    
    components/offline_pages/core/
    
    Bug: 906903
    Change-Id: I579d9b8e9c785e0c004ecc3d25e05f7aa031fe4c
    Reviewed-on: https://chromium-review.googlesource.com/c/1359487
    Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
    Commit-Queue: Mark Lieu <mtlieuu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614549}

    Changed files

    • components/offline_pages/core/offline_event_logger.cc
    • components/offline_pages/core/offline_page_metadata_store.cc
    • components/offline_pages/core/offline_page_metadata_store_unittest.cc
    • components/offline_pages/core/prefetch/prefetch_downloader_impl.cc
    • components/offline_pages/core/prefetch/prefetch_downloader_impl.h
    • components/offline_pages/core/prefetch/prefetch_downloader_impl_unittest.cc
  31. Don't sync speaker id enrollment status when flag is disabled.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:21:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c33e07c15885a19bea8dfccaf773209165b992a

    Comments

    Don't sync speaker id enrollment status when flag is disabled.
    
    This sync was causing a bit to be set that caused personal queries to
    fail due to lack of voice match. Unfortunately, this will not fix users
    who already went down this code path so we'll have to do a follow up
    to clear the culprit bit.
    
    Removing user and re-adding with the fix CL will fix functionality for
    a user who got into the bad state, and the fix CL will prevent others
    from getting into this state.
    
    Bug: b:120625879
    Change-Id: Id002bf47f49409cf2d08ec1f7d4ee7061369339b
    Reviewed-on: https://chromium-review.googlesource.com/c/1366491
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#614548}

    Changed files

    • chromeos/services/assistant/assistant_manager_service_impl.cc
  32. Remove usage of URLRequestContextGetter in Cast code.

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:20:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b79dd6ba6c392016444abfc5b26d42ed8774bb57

    Comments

    Remove usage of URLRequestContextGetter in Cast code.
    
    It just needed the NetLog code. Eventually this dependency will go away as well (https://crbug.com/806817).
    
    Bug: 837753
    Change-Id: Ic17ada4a10492986f052453ab49111f8732bc7b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1363976
    Reviewed-by: Yuri Wiitala <miu@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614547}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/media/cast_transport_host_filter.cc
    • chrome/browser/media/cast_transport_host_filter.h
    • chrome/browser/media/cast_transport_host_filter_unittest.cc
    • content/browser/storage_partition_impl.cc
    • content/public/browser/storage_partition.h
  33. task_contoller_unittest: move setupFileManagerPrivate() to Setup()

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:19:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96e0fd8bd99e572dca38519ae68140414636a21f

    Comments

    task_contoller_unittest: move setupFileManagerPrivate() to Setup()
    
    After CL:1364270 all test cases begin with a setupFileManagerPrivate()
    call: move that into Setup().
    
    No change in test behavior, no new tests.
    
    Bug: 912410
    Change-Id: I36e2180012918ec00d552397395c8bb61048382c
    Reviewed-on: https://chromium-review.googlesource.com/c/1364996
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614546}

    Changed files

    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
  34. Revert "Change interleaving of delayed and immediate tasks to match MessageLoop"

    Changed by Jeffrey Yasskin - jyasskinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 957b034333640c832f432f6d9cdb2f3ef260fd5b

    Comments

    Revert "Change interleaving of delayed and immediate tasks to match MessageLoop"
    
    This reverts commit dda57a2c6aa319675172f8558ce8c24d9333f894.
    
    Reason for revert: Made http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js flaky, according to https://crbug.com/912614.
    
    Original change's description:
    > Change interleaving of delayed and immediate tasks to match MessageLoop
    > 
    > Previously the TaskQueueSelector would allow up to 3 delayed tasks to
    > run for every immediate task if both where ready to run.  This patch
    > changes it to a 1:1 ratio like the MessageLoop.  NB neither the
    > SequenceManager nor the MessageLoop allow delayed tasks to skip ahead
    > of immediate tasks.
    > 
    > In addition I've removed the PrioritizingSelector inner class which makes
    > the code a bit more readable.  In addition based on review comments I
    > changed the style of functions to return a pointer to the WorkQueue or
    > null rather than a bool. This in general improves readability.
    > 
    > Bug: 863341, 891670
    > Change-Id: I61d4f118880f109c01ad4a2d5301acc9103b0b35
    > Reviewed-on: https://chromium-review.googlesource.com/c/1361103
    > Commit-Queue: Alex Clarke <alexclarke@chromium.org>
    > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > Reviewed-by: Alexander Timin <altimin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614329}
    
    TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org
    
    Change-Id: I2b92bee12bfdd05fac12955655106253cab0d1e6
    No-Presubmit: true
    Bug: 863341, 891670, 912614
    Reviewed-on: https://chromium-review.googlesource.com/c/1366223
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614545}

    Changed files

    • base/task/sequence_manager/sequence_manager_impl.cc
    • base/task/sequence_manager/sequence_manager_impl.h
    • base/task/sequence_manager/sequence_manager_impl_unittest.cc
    • base/task/sequence_manager/task_queue_selector.cc
    • base/task/sequence_manager/task_queue_selector.h
    • base/task/sequence_manager/task_queue_selector_unittest.cc
    • base/task/sequence_manager/work_queue_sets.cc
    • base/task/sequence_manager/work_queue_sets.h
    • base/task/sequence_manager/work_queue_sets_unittest.cc
    • base/task/sequence_manager/work_queue_unittest.cc
    • third_party/blink/web_tests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt
  35. cros: Move most event/widget handling logic out of LoginBubble

    Changed by Quan Nguyen - qnnguyenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:18:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61287973e8f4522ed673ac1a77de0dc56eb1bc8

    Comments

    cros: Move most event/widget handling logic out of LoginBubble
    
    Changes made:
    - Move the (keyboard/click/tap) event handling logic into a
      LoginBubbleHandler class.
    - Move the widget handling into LoginBaseBubbleView itself
    
    Bug: 912658
    Change-Id: Ia1a9bf4b8d847ef74ef1716e73dfe1b16b8d19b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366516
    Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614544}

    Changed files

    • ash/login/ui/login_base_bubble_view.cc
    • ash/login/ui/login_base_bubble_view.h
    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble.h
  36. Fixed UKM API docs to match the current API.

    Changed by Matt Giuca - mgiucaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:18:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c1e47620c5653fbf40e7df3eea08869cff4dcd7

    Comments

    Fixed UKM API docs to match the current API.
    
    Change-Id: If0cb49393d3c04414687d16427a50d591cf216d1
    Reviewed-on: https://chromium-review.googlesource.com/c/1349152
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Commit-Queue: Matt Giuca <mgiuca@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614543}

    Changed files

    • services/metrics/ukm_api.md
  37. arc: Start/stop arc-vm job

    Changed by Yusuke Sato - yusukesohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:17:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c29cfc31d659799b277676557231dd600c3f6a3

    Comments

    arc: Start/stop arc-vm job
    
    BUG=b:118408409
    TEST=sign in, tap Play Store icon, check arc-vm job is running, sign out,
     check arc-vm job is stopped
    TEST=check that the socket is chronos:chronos and 0600 on eve-arcvm
    
    Change-Id: Ibfa140a4aaee58f562ae898a0f308067388c6f22
    Reviewed-on: https://chromium-review.googlesource.com/c/1363964
    Commit-Queue: Yusuke Sato <yusukes@chromium.org>
    Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614542}

    Changed files

    • components/arc/arc_session_impl.cc
    • components/arc/arc_vm_client_adapter.cc
  38. Roll src/third_party/chromite aee33ef79380..0979b51ccfc5 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:17:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a37a6778df3a131eaf11267d6a4326fb224d84db

    Comments

    Roll src/third_party/chromite aee33ef79380..0979b51ccfc5 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/aee33ef79380..0979b51ccfc5
    
    
    git log aee33ef79380..0979b51ccfc5 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 dgarrett@google.com chromeos_config: No vm/hwtests on postsubmit builders.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@0979b51ccfc5
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I4e3e4301aa9906f500ad68cf36b931128256259e
    Reviewed-on: https://chromium-review.googlesource.com/c/1366362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614541}

    Changed files

    • DEPS
  39. Reland "Perfetto: Stop splitting _COMPLETE events"

    Changed by Oystein Eftevaag - oysteineohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:16:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d830c214cd1c59958ee19403b446fa5b796e794

    Comments

    Reland "Perfetto: Stop splitting _COMPLETE events"
    
    This is a reland of 53e8b2a294d66219b5c4daf00dda1cb9f822a54f
    
    Relanding after https://chromium-review.googlesource.com/c/catapult/+/1364251
    which is what caused the failures triggering the revert last time.
    
    Original change's description:
    > Perfetto: Stop splitting _COMPLETE events
    >
    > The current Perfetto backend splits _COMPLETE trace events into
    > separate _BEGIN and _END pairs, as it's not very feasible to modify
    > existing events after they're written into the Shared Memory Buffers.
    >
    > This is causing some issues with the trace-viewer which has some
    > assumptions about the ordering of begin/end events vs. async events,
    > and is also bloating the sizes of traces and adding extra
    > overhead for the perf infra.
    >
    > Instead, we now keep the _COMPLETE events in an internal stack in
    > TLS and only emit them when we have their duration.
    >
    TBR=eseckler@chromium.org,skyostil@chromium.org
    >
    > Bug: 909728,888558
    > Change-Id: I80e37264de66d8bbcb6c9095d21047957fd6eb9f
    > Reviewed-on: https://chromium-review.googlesource.com/c/1354503
    > Commit-Queue: oysteine <oysteine@chromium.org>
    > Reviewed-by: Eric Seckler <eseckler@chromium.org>
    > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#612360}
    
    Bug: 909728, 888558
    Change-Id: I5e3d6e0f170066011e2a5b452969d9c8cd18ac4f
    Reviewed-on: https://chromium-review.googlesource.com/c/1359304
    Reviewed-by: oysteine <oysteine@chromium.org>
    Commit-Queue: oysteine <oysteine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614540}

    Changed files

    • base/trace_event/trace_log.cc
    • base/trace_event/trace_log.h
    • base/trace_event/traced_value.cc
    • services/tracing/public/cpp/perfetto/trace_event_data_source.cc
    • services/tracing/public/cpp/perfetto/trace_event_data_source.h
    • services/tracing/public/cpp/perfetto/trace_event_data_source_unittest.cc
  40. child user: Add ParentAccessCodeConfig user policy

    Changed by Aga Wronska - agawronskaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:16:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24fde26e7643d0bb161d27cc1a1b79432e5752e5

    Comments

    child user: Add ParentAccessCodeConfig user policy
    
    This policy specifies configuration that is used to generate/verify
    Parent Access Code on child user's device.
    This policy applies only to child user.
    The value of this policy should not be displayed in the UI and
    it is marked as 'sensitiveValue' therefore.
    
    Bug: 911326
    Test: policy_test_cases.json
    Change-Id: Iee3dafce712b67f038cea52d5fc8810a6532e809
    Reviewed-on: https://chromium-review.googlesource.com/c/1359893
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Aga Wronska <agawronska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614539}

    Changed files

    • chrome/browser/chromeos/child_accounts/screen_time_controller.cc
    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • chrome/test/data/policy/policy_test_cases.json
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  41. Remove support for calling UsbDeviceHandle methods from any thread

    Changed by Reilly Grant - reillygohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:15:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99cbf6105655ac0c6818ec08bacf7fe27c46439c

    Comments

    Remove support for calling UsbDeviceHandle methods from any thread
    
    As of r613802 the last remaining user of this quirk in the
    UsbDeviceHandle API has been migrated to the USB Mojo interface and so
    the ability to call methods on UsbDeviceHandle from any thread and have
    the callback posted back to the caller's thread can be removed.
    
    Bug: 699790
    Change-Id: Ieb3adecc2e971909aa69f612036d9bc0f5d69f31
    Reviewed-on: https://chromium-review.googlesource.com/c/1364224
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614538}

    Changed files

    • device/usb/usb_device_handle.h
    • device/usb/usb_device_handle_impl.cc
    • device/usb/usb_device_handle_impl.h
    • device/usb/usb_device_handle_usbfs.cc
    • device/usb/usb_device_handle_usbfs.h
    • device/usb/usb_device_handle_win.cc
    • device/usb/usb_device_handle_win.h
  42. Fix org.chromium.content.browser.BrowserStartupControllerTest failures on Android.

    Changed by Xi Han - hanxiohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:15:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03089e2445101e1a2dce3b89262abfdb107def6f

    Comments

    Fix org.chromium.content.browser.BrowserStartupControllerTest failures on Android.
    
    The crash is caused due to junit test BrowserStartupControllerTest doesn't
    initialize the native but call serviceManagerStartupComplete. In that function,
    we record startup metrics and failed due to native doesn't initialized. Therefore,
    we add a protect function for the metrics record and override it in the
    TestBrowserStartupController.
    
    Bug: 912619
    Change-Id: Ifa6ba36bc926f0f033f7df0f4e6a67fce0ca340f
    Reviewed-on: https://chromium-review.googlesource.com/c/1366717
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Xi Han <hanxi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614537}

    Changed files

    • content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java
    • content/public/android/javatests/src/org/chromium/content/browser/BrowserStartupControllerTest.java
  43. Roll src-internal c67e56ecd9f7..fb4f6083a23a (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:14:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e1e2d94aa4b3a81993943ac762d6ae0ef585e7c

    Comments

    Roll src-internal c67e56ecd9f7..fb4f6083a23a (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c67e56ecd9f7..fb4f6083a23a
    
    
    Created with:
      gclient setdep -r src-internal@fb4f6083a23a
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I32f9955376d2494ce2bdd5a7f352257f01e7694d
    Reviewed-on: https://chromium-review.googlesource.com/c/1366365
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614536}

    Changed files

    • DEPS
  44. Introducing URLLoaderFactoryParams::request_initiator_origin_lock.

    Changed by Lukasz Anforowicz - lukaszaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:14:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e686969e6098169e9306ae8cbc245e80c416dad

    Comments

    Introducing URLLoaderFactoryParams::request_initiator_origin_lock.
    
    This CL is a step toward the world where we don't trust the origin
    reported by the renderer in network::ResourceRequest::request_initiator
    and instead know the request initiator a priori (e.g. it gets computed
    by the browser process).
    
    This CL only logs UMA that says whether the newly introduced lock is
    compatible with the request initiator requested by the user of the
    NetworkService (e.g. by the renderer process).  This CL doesn't yet
    enforce the request_initiator_origin_lock - the enforcement will be
    enabled in a separate, follow-up CL.
    
    This CL builds upon the fact that in most cases
    RenderProcessHostImpl::CreateURLLoaderFactory knows which origin will
    use the factory to initiate requests.  In presence of NetworkService,
    this knowledge allows locking of URLLoaderFactory to this specific
    origin.
    
    The only cases where the origin is not known should eventually disappear
    after https://crbug.com/891872 is dealt with.  Note that CL has to deal
    with the fact that because of https://crbug.com/888079 sometimes only a
    site URL (rather than origin) may be known at the commit time.  This is
    why the lock is temporarily called |request_initiator_site_lock| rather
    than |request_initiator_origin_lock|.
    
    Bug: 871827
    Change-Id: I97cc8285ace65e072bd7780da45522b10cb5ba57
    Reviewed-on: https://chromium-review.googlesource.com/c/1351574
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Nasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614535}

    Changed files

    • content/browser/DEPS
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
    • content/browser/loader/cross_site_document_blocking_browsertest.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • content/browser/renderer_host/render_process_host_impl.h
    • content/public/browser/render_process_host.h
    • content/public/test/mock_render_process_host.cc
    • content/public/test/mock_render_process_host.h
    • extensions/browser/url_loader_factory_manager.cc
    • services/network/public/mojom/network_context.mojom
    • services/network/url_loader.cc
    • services/network/url_loader.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  45. Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz."

    Changed by Max Moroz - mmorozohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:13:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ef757a81180101de6b2e09c57509077d8588376

    Comments

    Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz."
    
    This reverts commit 0baa5bdf0ed91499211384b636161ae9749f5ade.
    
    Reason for revert: is not needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457
    
    Original change's description:
    > Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz.
    > 
    > Bug: 911836
    > Change-Id: Ia76687b3cb8d329792e5ef0310faee93d05344f2
    > Reviewed-on: https://chromium-review.googlesource.com/c/1361725
    > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > Commit-Queue: Max Moroz <mmoroz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#613792}
    
    TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 911836
    Change-Id: Ibc4c88faadd5c1e603fc0f26ce956c282909798e
    Reviewed-on: https://chromium-review.googlesource.com/c/1365083
    Reviewed-by: Max Moroz <mmoroz@chromium.org>
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614534}

    Changed files

    • third_party/fontconfig/BUILD.gn
  46. Roll src/third_party/perfetto 82c3965be4fb..f4a214430436 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 01:13:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e171d8b83984479dc365214912e21c34421fd20d

    Comments

    Roll src/third_party/perfetto 82c3965be4fb..f4a214430436 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/82c3965be4fb..f4a214430436
    
    
    git log 82c3965be4fb..f4a214430436 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 primiano@google.com Merge "Add shmempages to mm_counters + deal with future unknowns"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f4a214430436
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I1256def975b7a9590aefaae9c38b379783bebeaf
    Reviewed-on: https://chromium-review.googlesource.com/c/1366775
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614533}

    Changed files

    • DEPS
  47. [Mac] Sign bundled dylibs in the Framework's Libraries directory.

    Changed by Robert Sesek - rsesekohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:12:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9670dd54c8b6b8d22ccd21c35e692a02173901d7

    Comments

    [Mac] Sign bundled dylibs in the Framework's Libraries directory.
    
    Bug: 912686
    Change-Id: I3725ed02fca95eec846819aa22f33ef072a116db
    Reviewed-on: https://chromium-review.googlesource.com/c/1366857
    Reviewed-by: Mark Mentovai <mark@chromium.org>
    Commit-Queue: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614532}

    Changed files

    • chrome/installer/mac/sign_app.sh.in
    • chrome/installer/mac/sign_versioned_dir.sh.in
  48. Dark Mode: give user-facing WebUI pages data on whether dark mode is on

    Changed by Dan Beam - dbeamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:12:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1793df0e4ba009b98744de629534a7f000716341

    Comments

    Dark Mode: give user-facing WebUI pages data on whether dark mode is on
    
    R=dpapad@chromium.org
    BUG=883049
    
    Change-Id: Ia0657f1333ee3c3e556b36515f97c66a666309d9
    Reviewed-on: https://chromium-review.googlesource.com/c/1354685
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614531}

    Changed files

    • chrome/browser/resources/md_bookmarks/bookmarks.html
    • chrome/browser/resources/md_downloads/downloads.html
    • chrome/browser/resources/md_extensions/extensions.html
    • chrome/browser/resources/md_history/history.html
    • chrome/browser/resources/md_user_manager/user_manager.html
    • chrome/browser/resources/print_preview/print_preview_new.html
    • chrome/browser/resources/settings/settings.html
    • chrome/browser/ui/webui/dark_mode_handler.cc
    • chrome/browser/ui/webui/dark_mode_handler.h
    • chrome/browser/ui/webui/dark_mode_handler_unittest.cc
    • chrome/browser/ui/webui/extensions/extensions_ui.cc
    • chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc
    • chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
    • chrome/browser/ui/webui/md_history_ui.cc
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/browser/ui/webui/settings/md_settings_ui.cc
    • chrome/browser/ui/webui/signin/md_user_manager_ui.cc
    • third_party/closure_compiler/externs/pending.js
    • ui/webui/resources/PRESUBMIT.py
    • ui/webui/resources/html/dark_mode.html
    • ui/webui/resources/js/BUILD.gn
    • ui/webui/resources/js/dark_mode.js
    • ui/webui/resources/webui_resources.grd
  49. WebUI: cr-slider, simplify slider logic by removing |updateValueInstantly| property

    Changed by Esmael El-Moslimany - aeeohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:11:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 52964c260bee1e96f746517215ac398ccd2c67ba

    Comments

    WebUI: cr-slider, simplify slider logic by removing |updateValueInstantly| property
    
    |updateValueInstantly| is only used by the display size slider. The property
    was passed through settings-slider. This CL moves the |updateValueInstantly|
    logic to settings-slider.
    
    The reasoning is that cr-slider had a property |value| that represents the
    slider value unless the slider was in a dragging state and
    |updateValueInstantly| was false. A new value called |immediateValue_|
    was added to always have the correct value even during drag. But this
    was only to ultimately stop a value-changed event from being handled
    which would update |pref.value|. Instead of having two properties in
    cr-slider and one property in settings-slider to store the slider value,
    moving the |updateValueInstantly| logic to settings-slider significantly
    simplifies the code.
    
    Bug: 902873
    Change-Id: I5d5d8771aa8246850bfd9b4926d820180e43c211
    Reviewed-on: https://chromium-review.googlesource.com/c/1363642
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614530}

    Changed files

    • chrome/browser/resources/settings/controls/settings_slider.html
    • chrome/browser/resources/settings/controls/settings_slider.js
    • chrome/test/data/webui/cr_elements/cr_slider_test.js
    • chrome/test/data/webui/settings/settings_slider_tests.js
    • ui/webui/resources/cr_elements/cr_slider/cr_slider.html
    • ui/webui/resources/cr_elements/cr_slider/cr_slider.js
  50. [bluetooth][win] Force uncached descriptor value reads

    Changed by Reilly Grant - reillygohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:11:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc08cacbde1ee26cbe43bbf576097dd9528467f2

    Comments

    [bluetooth][win] Force uncached descriptor value reads
    
    This is a follow-up to r614437 which updates ReadRemoteDescriptor() to also use
    the uncached variant of the ReadValueAsync() function so as not to return a
    stale value.
    
    Bug: 904114
    Change-Id: Ifb7e0be25f799eadc4f1e65aea6c6c5850649019
    Reviewed-on: https://chromium-review.googlesource.com/c/1366321
    Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614529}

    Changed files

    • device/bluetooth/bluetooth_remote_gatt_descriptor_winrt.cc
    • device/bluetooth/test/fake_gatt_descriptor_winrt.cc
  51. Revert "[AF] Test that removing wallet data results in removing wallet metadata"

    Changed by Jeffrey Yasskin - jyasskinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:09:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7810b8be795d32099d6589963c0ed8949106bbab

    Comments

    Revert "[AF] Test that removing wallet data results in removing wallet metadata"
    
    This reverts commit f16eb38ad60352dbdf7241ebb0f40b546d1197a1.
    
    Reason for revert: FindIt says its tests are flaky: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjE2ZWIzOGFkNjAzNTJkYmRmNzI0MWViYjBmNDBiNTQ2ZDExOTdhMQw
    
    Original change's description:
    > [AF] Test that removing wallet data results in removing wallet metadata
    > 
    > This CL adds two more sync integration tests for autofill wallet sync.
    > 
    > Bug: 894001
    > Change-Id: I00e1db0e44aba311a0872e88eddf50f395d33fb7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1358508
    > Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#613261}
    
    TBR=sebsg@chromium.org,jkrcal@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 894001, 911953
    Change-Id: I20bb26bbd973d8ee7411c3269dc4ab6f98e0e272
    Reviewed-on: https://chromium-review.googlesource.com/c/1366876
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614528}

    Changed files

    • chrome/browser/sync/test/integration/two_client_wallet_sync_test.cc
    • chrome/browser/sync/test/integration/wallet_helper.cc
    • chrome/browser/sync/test/integration/wallet_helper.h
  52. [Clank MR] Fix several issues in FlingingControllerAdapter

    Changed by Zhiqiang Zhang - zqzhangohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:09:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 118df4e7ec6d5ce91fd45bddde32c384b6f59c6c

    Comments

    [Clank MR] Fix several issues in FlingingControllerAdapter
    
    RemoteMediaClient.getApproximateStreamPosition() is expensive for
    polling as it has an internal lock. This CL will calculate the
    approximate stream position in Clank, so we only read from
    RemoteMediaClient upon status update. A new class
    (StreamPositionExtrapolator) is migrated from the non-CAF code,
    which is used as a helper class for position calculation.
    
    Also the loaded state is cleared if the player state is idle and
    finished, which solves the "seek after finished" issue.
    
    Bug: 711860
    Change-Id: I95b1fe67f3ae12ef7012c6ce1f5e7fe7af2d13be
    Reviewed-on: https://chromium-review.googlesource.com/c/1364065
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614527}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/remoting/FlingingControllerAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/media/router/caf/remoting/StreamPositionExtrapolator.java
    • chrome/android/java_sources.gni
  53. Simplify json source side of performance_test_suite of linux-perf-fyi bot

    Changed by Ned Nguyen - nednguyenohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 01:08:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5dfc4fc873896dc668f7060914800c4e48a0b0f

    Comments

    Simplify json source side of performance_test_suite of linux-perf-fyi bot
    
    The *_layout_ng tests are currently not running (see https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi/417), so cleaning them up to prepare
    for further refactoring
    
    Bug: 902089
    Change-Id: Iadd871b8975793fdfcd848be06de690f40cf2058
    Reviewed-on: https://chromium-review.googlesource.com/c/1361929
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614526}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
  54. Remove IsNestedWorker()

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:08:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b47801ae2af0092ff6f701c8b21de5cc744ad93

    Comments

    Remove IsNestedWorker()
    
    No longer used after
    https://chromium-review.googlesource.com/1351929.
    
    Bug: 880027
    Change-Id: Ic8e633dca12f60431530f803730286b02927cd3f
    Reviewed-on: https://chromium-review.googlesource.com/c/1350902
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614525}

    Changed files

    • third_party/blink/renderer/core/workers/dedicated_worker_global_scope.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_global_scope.h
    • third_party/blink/renderer/core/workers/dedicated_worker_thread.cc
    • third_party/blink/renderer/core/workers/dedicated_worker_thread.h
    • third_party/blink/renderer/core/workers/worker_global_scope.h
  55. Refactor decoder support query utils

    Changed by chcunningham - chcunninghamohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:07:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78534522cdb0c3881263661a2aba2606f246bf76

    Comments

    Refactor decoder support query utils
    
    Until now, media/ decoder capabilities were described by
    media/base/decode_capabilities.*. Embedders could override those
    abilities via MediaClient. This meant 2 steps to query for
    what configs were supported
    1) if MediaClient exists, ask it
    2) fallback to functions in decode_capabilites
    
    We have two places where these steps should be followed:
    MimeUtilInternal and WebMediaCapabilitiesClientImpl. Until now,
    only MimeUtilInternal did both.
    
    We anticipate a third caller (when creating FFmpegDemuxerStreams), so
    the time is right to put these two steps into a utility function:
    	bool IsSupported{Audio|Video}Type(...);
    
    This is defined in a new file: media/base/supported_types.h. media/'s
    default capabilities are also described in that file, via
    	bool IsDefaultSupported*Type(...);
    
    This change also renames the struct inputs to these APIs from
    *Config to *Type. *Config was too close to *DecoderConfig and
    *Type is a closer match to the web APIs we're trying to serve
    (IsTypeSupported and CanPlayType).
    
    Change-Id: I5c49d28f3d7ad9e824388cb346369795c3a621f9
    Bug: 911823
    Reviewed-on: https://chromium-review.googlesource.com/c/1361938
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614524}

    Changed files

    • chromecast/renderer/cast_content_renderer_client.cc
    • chromecast/renderer/cast_content_renderer_client.h
    • content/public/renderer/content_renderer_client.cc
    • content/public/renderer/content_renderer_client.h
    • content/renderer/media/render_media_client.cc
    • content/renderer/media/render_media_client.h
    • media/base/BUILD.gn
    • media/base/decode_capabilities.h
    • media/base/key_systems_unittest.cc
    • media/base/media_client.h
    • media/base/media_types.h
    • media/base/mime_util_internal.cc
    • media/base/supported_types.cc
    • media/base/supported_types.h
    • media/base/supported_types_unittest.cc
    • media/blink/webmediacapabilitiesclient_impl.cc
    • media/renderers/audio_renderer_impl_unittest.cc
  56. Update TODO about hiding the main frame RenderWidget when swapping out

    Changed by danakj - danakjohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:07:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc8b1e563f106abfcd3e153bcaf03f3c6a272d81

    Comments

    Update TODO about hiding the main frame RenderWidget when swapping out
    
    Combine 2 TODOs into one explanation about why this is done for main
    frames only (subframes don't need it since we drop the RenderWidget
    when the frame is detached during SwapOut).
    
    R=creis@chromium.org
    
    Change-Id: Ib10c51401994f9a3a6d8270b45eb1006297ecb50
    Bug: 908582
    Reviewed-on: https://chromium-review.googlesource.com/c/1362104
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614523}

    Changed files

    • content/browser/frame_host/render_frame_host_manager.cc
  57. Rename the last vestiges of "SlimmingPaintV2" to "CompositeAfterPaint"

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:06:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10022953931784acabd9033bba08839e8aaa46c6

    Comments

    Rename the last vestiges of "SlimmingPaintV2" to "CompositeAfterPaint"
    
    This patch cleans up a few remaining instances of Slimming Paint V2
    since it has been renamed Composite After Paint.
    
    Bug: 909899
    Change-Id: Ibb09cb7c603b10359ce6e5e954f2c67bd395a906
    Reviewed-on: https://chromium-review.googlesource.com/c/1366257
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614522}

    Changed files

    • cc/layers/layer.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/property_tree.h
    • third_party/blink/web_tests/virtual/composite-after-paint/compositing/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/block/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/borders/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/clip/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/css/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/overflow/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/fast/repaint/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/paint/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/paint/subpixel/README.txt
    • third_party/blink/web_tests/virtual/composite-after-paint/svg/README.txt
    • tools/metrics/histograms/histograms.xml
  58. Disable standard instrumentation tests on O

    Changed by bsheedy - bsheedyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:05:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0183346307f959af42efec29b8ee773c15a8b00c

    Comments

    Disable standard instrumentation tests on O
    
    chrome_public_test_apk and webview_instrumentation_test_apk have always
    failed on O and end up burning a lot of device time with no one actively
    monitoring them or trying to fix them. This combined with the few number
    of devices that have Oreo means that the other tests that run on Oreo
    that are monitored can end up not running due to capacity issues. So,
    disable these tests on Oreo until they're either fixed or more capacity
    is added.
    
    Bug: 884413
    Change-Id: Ica3a501ed078075dfb462f9cbcd7b3f26cb8dcad
    Reviewed-on: https://chromium-review.googlesource.com/c/1366255
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614521}

    Changed files

    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
  59. Plumb the top frame origin of resource requests to the net stack

    Changed by Josh Karlin - jkarlinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:05:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be37f9105bb8760e009c71e61770b514449fe398

    Comments

    Plumb the top frame origin of resource requests to the net stack
    
    In order to experiment with splitting the disk cache by top frame
    origin, we'll need to plumb the top frame origin up to the network stack
    for each resource request.
    
    We're focused on just document subresource requests and navigation
    requests for now because that's the majority of request types and this
    is meant to support an early experiment. We will need to include other
    types of requests (e.g., from workers, or signed exchange redirects)
    later.
    
    Subresources requests (and subframe navigations) don't change the top
    frame origin on redirect. Top frame navigations do however.
    
    Bug: 898855
    Change-Id: I86a1c5a61986d15c445991c4e50482209f051cca
    Reviewed-on: https://chromium-review.googlesource.com/c/1335869
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Josh Karlin <jkarlin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614520}

    Changed files

    • content/browser/devtools/devtools_url_loader_interceptor.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request_info.cc
    • content/browser/frame_host/navigation_request_info.h
    • content/browser/frame_host/navigator_impl_unittest.cc
    • content/browser/loader/navigation_url_loader_impl.cc
    • content/browser/loader/navigation_url_loader_impl_unittest.cc
    • content/browser/loader/navigation_url_loader_unittest.cc
    • content/browser/loader/resource_dispatcher_host_impl.cc
    • content/browser/loader/resource_dispatcher_host_unittest.cc
    • content/browser/navigation_browsertest.cc
    • content/common/service_worker/service_worker_loader_helpers.cc
    • content/common/throttling_url_loader.cc
    • content/renderer/loader/web_url_loader_impl.cc
    • content/renderer/loader/web_url_loader_impl_unittest.cc
    • content/test/data/page_with_iframe_and_image.html
    • headless/test/test_network_interceptor.cc
    • net/url_request/redirect_info.cc
    • net/url_request/redirect_info.h
    • net/url_request/redirect_info_unittest.cc
    • net/url_request/url_request.cc
    • net/url_request/url_request.h
    • net/url_request/url_request_job.cc
    • net/url_request/url_request_unittest.cc
    • services/network/public/cpp/net_ipc_param_traits.h
    • services/network/public/cpp/network_ipc_param_traits.h
    • services/network/public/cpp/resource_request.h
    • services/network/url_loader.cc
    • third_party/blink/public/platform/web_url_loader_client.h
    • third_party/blink/public/platform/web_url_request.h
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/exported/web_document_test.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.h
    • third_party/blink/renderer/platform/exported/web_url_request.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_loader.h
    • third_party/blink/renderer/platform/loader/fetch/resource_request.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_request.h
    • third_party/blink/renderer/platform/loader/fetch/resource_request_test.cc
    • third_party/blink/renderer/platform/testing/weburl_loader_mock.cc
  60. Add BufferedFileWriter class.

    Changed by Erik Jensen - rkjnsnohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:04:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad6a38199aa947ed053a75a19b89172f4a4ee0ba

    Comments

    Add BufferedFileWriter class.
    
    FileOperations::Writer only allows one operation to be pending at a
    time, while chunks from the network will be delivered to
    FileTransferMessageHandler as soon as they arrive. BufferedFileWriter
    will sit between the two and maintain a queue of chunks to be written,
    passing them to the Writer in sequence.
    
    Bug: 679313
    Change-Id: Id10c8d3f34c4811feb373e6cb60f470d2a2a59d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1362455
    Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614519}

    Changed files

    • remoting/host/file_transfer/BUILD.gn
    • remoting/host/file_transfer/buffered_file_writer.cc
    • remoting/host/file_transfer/buffered_file_writer.h
    • remoting/host/file_transfer/buffered_file_writer_unittest.cc
    • remoting/host/file_transfer/fake_file_operations.cc
    • remoting/host/file_transfer/fake_file_operations.h
  61. Import AHardwareBuffer into a Vulkan Image.

    Changed by Vikas Soni - vikassoniohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:04:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8e53d0f70e2e8bc9736e55cacd1bf939efc18da

    Comments

    Import AHardwareBuffer into a Vulkan Image.
    
    Added a utility function to create a vulkan image and import AHardwareBuffer
    created outside of vulkan device into a vulkan image.
    
    Bug: 891060
    Change-Id: Id6a81c0b21e53bac4c439c3a7d8f787cbc32b68b
    Reviewed-on: https://chromium-review.googlesource.com/c/1357658
    Commit-Queue: vikas soni <vikassoni@chromium.org>
    Reviewed-by: Eric Karl <ericrk@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614518}

    Changed files

    • components/viz/common/BUILD.gn
    • gpu/vulkan/BUILD.gn
    • gpu/vulkan/android/vulkan_android_unittests.cc
    • gpu/vulkan/android/vulkan_implementation_android.cc
    • gpu/vulkan/android/vulkan_implementation_android.h
    • gpu/vulkan/generate_bindings.py
    • gpu/vulkan/vulkan_function_pointers.cc
    • gpu/vulkan/vulkan_function_pointers.h
    • gpu/vulkan/vulkan_implementation.h
  62. [AF] Add SyncState suffix to some key autofill metrics.

    Changed by sebsg - sebsgohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 119a2fe85a3ae98d60d9e5a5b0837c20cb21bfb3

    Comments

    [AF] Add SyncState suffix to some key autofill metrics.
    
    The suffixes describing the sync state are:
    SignedOut
    SignedIn
    kSignedInAndWalletSyncTransportEnabled
    SignedInAndSyncFeature
    
    The metrics that will have those suffixes are
    Autofill.FormEvents
    Autofill.IsEnabled.PageLoad
    Autofill.SaveCreditCardPrompt
    
    The previous histograms will continue to be logged. This is only
    additional logging.
    
    Bug: 903290
    Change-Id: Ibc96a1db12408f13d40fe75ed9aec96af80eac96
    Reviewed-on: https://chromium-review.googlesource.com/c/1326602
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614517}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_external_delegate_unittest.cc
    • components/autofill/core/browser/autofill_manager.cc
    • components/autofill/core/browser/autofill_manager.h
    • components/autofill/core/browser/autofill_manager_unittest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • components/autofill/core/browser/autofill_metrics_unittest.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
    • components/autofill/core/browser/personal_data_manager_unittest.cc
    • components/autofill/core/browser/sync_utils.h
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • tools/metrics/histograms/histograms.xml
  63. Fuchsia: Use SandboxPolicyFuchsia for context process.

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:03:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df0d5a5590ab54ffcc074b8dcc0ca2ed92a06a60

    Comments

    Fuchsia: Use SandboxPolicyFuchsia for context process.
    
    1. Updated SandboxPolicyFuchsia to support sandbox policy for context
       process.
    2. Updated ContextProviderImpl to use SandboxPolicyFuchsia.
    3. SandboxPolicyFuchsia now provides Vulkan access to Context process.
    
    Bug: 861853
    Change-Id: If0e72e424bbadc0199a1c06e7c27e5df4245c7c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1354563
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614516}

    Changed files

    • services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.cc
    • services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.h
    • services/service_manager/sandbox/sandbox_type.h
    • webrunner/BUILD.gn
    • webrunner/service/context_provider_impl.cc
  64. Fix double-parenting in AXWindowObjWrapper under mash

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:02:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a15d7535017f58556cb996cb75328512d91efe5d

    Comments

    Fix double-parenting in AXWindowObjWrapper under mash
    
    Under mus/mash both the WindowTreeHost's root aura::Window and the content
    aura::Window will return the same Widget for GetWidgetForNativeView(). Only
    return the Widget for the content window, not the root, since otherwise
    we'll end up with two children in the AX node tree that have the same
    parent.
    
    This allows AXAuraWindowUtilsTest to run under views_mus_unittests and
    unblocks some future tests.
    
    Bug: 911945, 911776
    Test: views_unittests, views_mus_unittests
    Change-Id: I554c77e0dca90f1901a42d3331bca0a05e7bbd88
    Reviewed-on: https://chromium-review.googlesource.com/c/1365986
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614515}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/accessibility/ax_window_obj_wrapper.cc
  65. [Fuchsia] Remove the batch limit for net_unittests

    Changed by Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:01:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9de2c414af3dcffebb07593f33da6d4a0815301a

    Comments

    [Fuchsia] Remove the batch limit for net_unittests
    
    Bug: 844416, 847915
    Change-Id: Id9b4d2a330978e81863557665ba0aa66889cc4bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1364079
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614514}

    Changed files

    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/test_suites.pyl
  66. Gives Media Element focus upon mouse iteration.

    Changed by CJ DiMeglio - lethalantidoteohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:01:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c0284d5fa813c6b993da4ac57a54db665c2b523

    Comments

    Gives Media Element focus upon mouse iteration.
    
    This change makes it such that when a user interacts with the media element
    or its controls,the media element will be given focus. This allows one to use
    the keyboard controls to control the video.
    
    Bug: 827565
    Change-Id: I21a6d5ab2b75aeb3bf646c694eeac62f787c89aa
    Reviewed-on: https://chromium-review.googlesource.com/c/1292814
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614513}

    Changed files

    • third_party/blink/renderer/core/html/media/html_media_element.cc
    • third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
    • third_party/blink/web_tests/fullscreen/full-screen-test.js
    • third_party/blink/web_tests/fullscreen/video-controls-timeline.html
    • third_party/blink/web_tests/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html
    • third_party/blink/web_tests/media/video-controls-mouse-events-captured.html
    • third_party/blink/web_tests/media/video-mouse-focus.html
  67. [IndexedDB] Testing ordering and error handling for transaction.commit

    Changed by Daniel Murphy - dmurphohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:00:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0bd6d5bc0487315bdc89ba96df55b318cadc7b6

    Comments

    [IndexedDB] Testing ordering and error handling for transaction.commit
    
    * Tests that transaction ordering is consistent, even if a transaction
      calls commit().
    * Tests that request errors cause a commit()-ed transaction to abort.
    
    The second case seems to be broken in our implementation.
    
    R=andreasbutler@google.com, cmp@chromium.org
    
    Bug: 911877
    Change-Id: I47da6ce9d350f6c47afcd02cf808d4fefb5f013f
    Reviewed-on: https://chromium-review.googlesource.com/c/1362477
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Chase Phillips <cmp@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614512}

    Changed files

    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any-expected.txt
    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.js
    • third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.worker-expected.txt
  68. Android: Don't create .srcjar for generated version_info file

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 01:00:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 09e78caaf8a95c230efdd010b1c11a828d7a421d

    Comments

    Android: Don't create .srcjar for generated version_info file
    
    Bug: 908479
    Change-Id: Ibb6192e9c77342b67e0342e724de18c87a021b1f
    Reviewed-on: https://chromium-review.googlesource.com/c/1364611
    Reviewed-by: Paul Miller <paulmiller@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614511}

    Changed files

    • components/version_info/android/BUILD.gn
  69. [ScrollTimeline] Upstream based currentTime tests to WPT

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:59:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 42baeb7ae71e916dc19433ce698de5c02d5fa169

    Comments

    [ScrollTimeline] Upstream based currentTime tests to WPT
    
    This CL starts to upstream the currentTime tests to WPT. To split this
    up, we start with just the 'basic' tests - basic functionality,
    adjusting for time range, and start/end scroll offsets. The writing mode
    and NaN tests will follow in later patches.
    
    There are a few mostly non-behavioral changes to the tests in this CL:
    
      * Some comments were edited for clarity.
      * For tests with more than one assert_equals(), descriptions were
        added to the asserts. This is to help locate failing assert_equal
        lines, as jsharness does not print out the line number of a failure.
      * In a few places we had more than one assert_equals for the same
        scenario (e.g. multiple cases where scroll was after the
        startScrollOffset point). These have been deduplicated.
    
    Bug: 911254
    Change-Id: I783fcf7f43cda876defa9c36db9a0e7dff4e82c7
    Reviewed-on: https://chromium-review.googlesource.com/c/1366297
    Reviewed-by: Yi Gu <yigu@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614510}

    Changed files

    • third_party/blink/web_tests/external/wpt/scroll-animations/current-time.html
    • third_party/blink/web_tests/external/wpt/scroll-animations/resources/scrolltimeline-utils.js
    • third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-currenttime.html
  70. Support using gtest_filter and test-launcher-filter-file together on Android

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:59:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10692b98cca291e29f79fe8df9aae71b1ac452ff

    Comments

    Support using gtest_filter and test-launcher-filter-file together on Android
    
    These args used to be mutually exclusive, which would cause errors when
    retrying the Android network service tests (which use
    --test-launcher-filter-file). This combines the filters specified in the
    filter file with the gtest_filter argument.
    
    See here for an example of a failure:
    https://chromium-swarm.appspot.com/task?id=41984d0ac388e010
    
    Bug: 880915
    Change-Id: I2fee107d13c44bd90cd9532bcabda4bb12f7e111
    Reviewed-on: https://chromium-review.googlesource.com/c/1364071
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614509}

    Changed files

    • build/android/pylib/utils/test_filter.py
    • build/android/pylib/utils/test_filter_test.py
  71. Android: cleaning up some Proguard flags

    Changed by Sam Maier - smaierohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:58:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a48fa4727e3291b992bd9e7f30e69f6112392493

    Comments

    Android: cleaning up some Proguard flags
    
    Making these keep rules more explicit.
    
    Bug: 887942
    Change-Id: I70038c8c58025892a7003fad5bb3ff83384f13f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1366262
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614508}

    Changed files

    • chrome/android/java/proguard.flags
  72. [M72] Add tooltip on Save card prompt to explain saving the card to

    Changed by Jason Guo - jiahuiguoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:58:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a4e41ee265aa46f1c650cd1c8bdaf84b166c32b

    Comments

    [M72] Add tooltip on Save card prompt to explain saving the card to
    Google Account in Butter mode.
    
    
    BUG: 905393
    Change-Id: I71eca987c5e2d865efbd6bc00b6212b160f5ea3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1357634
    Reviewed-by: Evan Stade <estade@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Jason Guo <jiahuiguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614507}

    Changed files

    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_offer_bubble_views.h
    • components/autofill_strings.grdp
  73. Also considering about:srcdoc in url::Origin::Resolve.

    Changed by Lukasz Anforowicz - lukaszaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:57:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b309508508f232e7a91aa34891f652313afa7840

    Comments

    Also considering about:srcdoc in url::Origin::Resolve.
    
    about:srcdoc inherits the origin of its parent frame (similarly to
    about:blank).  Therefore url::Origin::Resolve should also consider
    about:srcdoc.
    
    Bug: 911683
    Change-Id: I114cdd21ff5b317c38cd50e648a16fb0879ceed9
    Reviewed-on: https://chromium-review.googlesource.com/c/1361284
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614506}

    Changed files

    • url/origin.cc
    • url/origin_unittest.cc
  74. Add doodle sharing to local NTP. Sharing consists of a sharing button and a sharing dialog box. Also includes browser tests.

    Changed by David Lu - davidluphdohnoyoudont@google.com
    Changed at Friday, 07-Dec-18 00:57:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c81cefa5985be68912e54cfbd5a3d8467b25f2ce

    Comments

    Add doodle sharing to local NTP. Sharing consists of a sharing button and a sharing dialog box. Also includes browser tests.
    
    Bug:896461
    
    -Enable using the Google local NTP -> Enabled
    -Enable doodles on the local NTP -> Enabled
    -?force-doodle=0 (for simple) or ?force-doodle=1 (for animated)
    
    Test: Set the following flags in chrome://flags:
    Change-Id: If900a18e2cada746132d894aa104f273f914bd90
    Reviewed-on: https://chromium-review.googlesource.com/c/1330356
    Reviewed-by: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: David Lu <davidluphd@google.com>
    Cr-Commit-Position: refs/heads/master@{#614505}

    Changed files

    • chrome/browser/resources/local_ntp/icons/close.svg
    • chrome/browser/resources/local_ntp/icons/copy.svg
    • chrome/browser/resources/local_ntp/icons/facebook.svg
    • chrome/browser/resources/local_ntp/icons/mail.svg
    • chrome/browser/resources/local_ntp/icons/twitter.svg
    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/resources/local_ntp/local_ntp.js
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/ui/search/local_ntp_doodle_browsertest.cc
    • components/search_provider_logos/google_logo_api.cc
    • components/search_provider_logos/logo_cache.cc
    • components/search_provider_logos/logo_common.h
  75. cros: Remove the touchable app context menu flag.

    Changed by Alex Newcomer - newcomerohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0cb7753a7379fe8910ea1dda4d70915f45f4e5e

    Comments

    cros: Remove the touchable app context menu flag.
    
    The feature has been enabled by default, so remove the flag.
    
    Bug: 906684
    Change-Id: I0ea6f282ef1054c1098fbb8b9fd4b537088db74b
    Reviewed-on: https://chromium-review.googlesource.com/c/1351752
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614504}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  76. Navi Onboarding: fix double-recording Welcome.SigninPrompt

    Changed by Scott Chen - scottchenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:56:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9dfaf94c590c701314cb691deb74eb194468930c

    Comments

    Navi Onboarding: fix double-recording Welcome.SigninPrompt
    
    Welcome.SigninPrompt was doubly recorded because during onboarding we
    sometimes redirect users back to the welcome page. This CL fixes the issue
    by detecting if the welcome page instance is a redirected impression, and
    skip recording SigninPrompt if so.
    
    Bug: 905785
    Change-Id: Iff60b8813ee8a1f6c1f2eb3887b32356a5e3e00e
    Reviewed-on: https://chromium-review.googlesource.com/c/1362199
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614503}

    Changed files

    • chrome/browser/ui/webui/welcome/welcome_handler.cc
    • chrome/browser/ui/webui/welcome/welcome_handler.h
  77. Explicitly list all $root_out_dir/resources/inspector files in the isolate.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:20:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f213164d219da210c4c0383d4878c02633599965

    Comments

    Explicitly list all $root_out_dir/resources/inspector files in the isolate.
    
    Listing a generated directory in the isolate means that incremental
    builders (and devs doing incremental builds) can have stale files in
    their generated isolated files.
    
    Bug: 911761
    Change-Id: I8652b272b44b031771e4458d43d5091abb093428
    Reviewed-on: https://chromium-review.googlesource.com/c/1366443
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614502}

    Changed files

    • BUILD.gn
    • third_party/blink/renderer/devtools/BUILD.gn
  78. Revert "Reland "Android: Factor InProductHelp UI out of Tab""

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 22:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fbe75ef510a9d9123f6c7f8cbd54d5f5b5680277

    Comments

    Revert "Reland "Android: Factor InProductHelp UI out of Tab""
    
    This reverts commit 76d39b3a8d8fbd0e990f92a992d80213724de9bd.
    
    Reason for revert:  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/2097 
    
    https://crbug.com/907602 doesn't seem to be addressed.
    
    Original change's description:
    > Reland "Android: Factor InProductHelp UI out of Tab"
    > 
    > 
    > https://chromium-review.googlesource.com/c/chromium/src/+/1272779 had a couple
    > of bugs in |ToolbarButtonInProductHelpController|:
    > 
    > 1) Ignored |profile| passed into |maybeShowDownloadContinuingIPH()| and
    >    always used Profile.getLastUsedProfile()
    > 2) |OnDismissListener| was instantiated (and menu got highlight for
    >    the text bubble) every time |setupAndMaybeShowIPHForFeature| is called,
    >    even when the method doesn't meet the condition for IPH text bubble
    >    and has to early out.
    > 
    > The CL got reverted due to numerous regressions . This CL fixes them and
    > relands it.
    > 
    > This reverts commit d436a7a2e33ee105a1d85370970fde3c88255302.
    > 
    > Bug: 889682, 907502, 907503, 907770, 907505, 907602
    > Change-Id: Id6de148a9fd4fd91ad7df986ca0ba78ed18e79e4
    > Reviewed-on: https://chromium-review.googlesource.com/c/1349142
    > Reviewed-by: Theresa <twellington@chromium.org>
    > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614161}
    
    TBR=twellington@chromium.org,jinsukkim@chromium.org
    
    Change-Id: Id92d47e6ac65a0b1a50f4ad4cb1c0b9a11189993
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 889682, 907502, 907503, 907770, 907505, 907602
    Reviewed-on: https://chromium-review.googlesource.com/c/1366456
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614501}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarButtonInProductHelpController.java
  79. remove skia legacy define

    Changed by Cary Clark - caryclarkohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 21:40:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59f5d8a34c2c5dbc2b9178cd1b1450b0a3220bc6

    Comments

    remove skia legacy define
    
    Skia change has landed.
    Looks like a handful of tests have minor changes.
    
    R=fmalita@chromium.org
    
    Bug: 843966
    Change-Id: I5809a7a317e33a20c738a1b3ce4156a886b4d174
    Reviewed-on: https://chromium-review.googlesource.com/c/1363213
    Commit-Queue: Cary Clark <caryclark@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614500}

    Changed files

    • skia/config/SkUserConfig.h
    • third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/W3C-SVG-1.1/text-text-08-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/text/text-selection-deco-01-b-expected.png
    • third_party/blink/web_tests/platform/linux/svg/text/text-selection-text-08-b-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.10/fast/text/stroking-expected.png
    • third_party/blink/web_tests/platform/mac-mac10.12/fast/text/stroking-expected.png
    • third_party/blink/web_tests/platform/mac/fast/text/stroking-expected.png
  80. Do not leak WK internal URL from pending item.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Thursday, 06-Dec-18 21:37:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112172d28d486c5d9776c794b89413bf6f314cd7

    Comments

    Do not leak WK internal URL from pending item.
    
    Extend WebStateTest.RestoreLargeSession test to verify that during
    session restoration GetPendingItemIndex() returns -1 and
    GetPendingItem() returns null.
    
    Pending Item will appear after first post-restore navigation is
    started, which happens before session restoration is considered
    complete. Session restoration is complete after first post-restore
    navigation is finished.
    
    Bug: 877671
    Change-Id: Iec922bc71a0101e14a7d12cca6c53a039d71674e
    Reviewed-on: https://chromium-review.googlesource.com/c/1363958
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614499}

    Changed files

    • ios/web/navigation/legacy_navigation_manager_impl.h
    • ios/web/navigation/legacy_navigation_manager_impl.mm
    • ios/web/navigation/navigation_manager_impl.h
    • ios/web/navigation/navigation_manager_impl.mm
    • ios/web/navigation/navigation_manager_impl_unittest.mm
    • ios/web/navigation/navigation_manager_util.mm
    • ios/web/navigation/wk_based_navigation_manager_impl.h
    • ios/web/navigation/wk_based_navigation_manager_impl.mm
    • ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm
    • ios/web/web_state/ui/crw_web_controller.mm
    • ios/web/web_state/web_state_unittest.mm
  81. Increase spacing to 4dp between "Lite" and verticial separator on CCT

    Changed by Robert Ogden - robertogdenohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:36:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d46232aa20ed1d0374be90517e41d9d3009bc479

    Comments

    Increase spacing to 4dp between "Lite" and verticial separator on CCT
    
    Looks like this should have been 4dp all along.
    
    Bug: 912308
    Change-Id: I4781124f174fe60cff1dcfeab4a18f6e1758fe6b
    Reviewed-on: https://chromium-review.googlesource.com/c/1366363
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Robert Ogden <robertogden@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614498}

    Changed files

    • chrome/android/java/res/values/dimens.xml
  82. Fix #endif comment

    Changed by Ayu Ishii - ayuiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:35:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c286ce55b1135cc731048a7a4bd869b9d9f2b1f

    Comments

    Fix #endif comment
    
    Bug: None
    Change-Id: Ie12298fd5bc4dc52cd2d25a180d36f5ace4ec90f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365895
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Commit-Queue: Ayu Ishii <ayui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614497}

    Changed files

    • third_party/blink/renderer/modules/bluetooth/bluetooth_characteristic_properties.h
  83. Disable flaky ChromeVox tests.

    Changed by Jeffrey Yasskin - jyasskinohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:35:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6af09c65d9c1cc347f08573eda20c25e49765bd6

    Comments

    Disable flaky ChromeVox tests.
    
    These started flaking with https://crrev.com/613661 which changed timing
    in the renderer process.
    
    Bug: 912390
    Change-Id: Ia41f0dc73210d83b2562f9ff55e9a7407d102448
    Tbr: dmazzoni@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/c/1366360
    Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org>
    Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614496}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs
  84. Crash if ProxyList::Get() is called on an empty list.

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:34:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7d0cd07fb1d38548b7d7f539f6bd07a2c960d3f

    Comments

    Crash if ProxyList::Get() is called on an empty list.
    
    Bug: 912217
    Change-Id: Id9f31535bfb9378ed1d7ea8cc6ca917726a127cc
    Reviewed-on: https://chromium-review.googlesource.com/c/1366298
    Reviewed-by: Clark DuVall <cduvall@chromium.org>
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614495}

    Changed files

    • net/proxy_resolution/proxy_list.cc
  85. [Fuchsia] Enable the http_service_tests suite on CQ.

    Changed by Fabrice de Gans-Riberi - fdegansohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:31:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe231e0f716579f6c858e0fd97566ae15feff72

    Comments

    [Fuchsia] Enable the http_service_tests suite on CQ.
    
    Following various fixes, the test suite is now stable on FYI
    bots. This test suite is quite small so the overhead should be
    minimal.
    
    Bug: 896884
    Change-Id: I44821e78b8807b6593d107c0d903f1130c1a3aed
    Reviewed-on: https://chromium-review.googlesource.com/c/1366261
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614494}

    Changed files

    • testing/buildbot/chromium.linux.json
    • testing/buildbot/test_suite_exceptions.pyl
  86. Add initial configuration for chromium.fyi:mac-hermetic-upgrade-rel.

    Changed by John Budorick - jbudorickohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:29:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29d6599ae563a6ee8bae0e8e8468254ec88cfc6d

    Comments

    Add initial configuration for chromium.fyi:mac-hermetic-upgrade-rel.
    
    Bug: 907173
    Change-Id: I53c971e1f8d429acee7cfa00fdf9d04c7c02b3eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1361667
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614493}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  87. Roll src/third_party/perfetto 2d82f1496ad6..82c3965be4fb (3 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 21:24:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d05f31593e8b94d0c1addc51761cffbf94d88e6

    Comments

    Roll src/third_party/perfetto 2d82f1496ad6..82c3965be4fb (3 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/2d82f1496ad6..82c3965be4fb
    
    
    git log 2d82f1496ad6..82c3965be4fb --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 fmayer@google.com Add Dockerfile for continuous fuzzer.
    2018-12-06 fmayer@google.com Merge "profiling: switch to using swap for assignment operators."
    2018-12-06 hjd@google.com perfetto-ui: Avoid bug with NULL refs when adding counter tracks
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@82c3965be4fb
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:69150303
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ia009b8a8794cc5bf713b1ec153f8773ed9ca9fd5
    Reviewed-on: https://chromium-review.googlesource.com/c/1366475
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614492}

    Changed files

    • DEPS
  88. Password manager: Style changes in the website column

    Changed by Yue Cen - rsgingerrsohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:20:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b974f8e7a514acf61ed018d55565731ff5d02e5

    Comments

    Password manager: Style changes in the website column
    
    - Increase the padding between the icon and the domain like in
      chrome://history.
    - Make the URLS for the domain black (but still clickable).
    
    Bug: 890118
    Change-Id: If63006dced601b2891e9b0864b788808acc1faa8
    Reviewed-on: https://chromium-review.googlesource.com/c/1332258
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Yue Cen <rsgingerrs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614491}

    Changed files

    • chrome/browser/resources/settings/autofill_page/passwords_shared_css.html
  89. Change SpdyHeaderBlockNetLogCallback() dict value type.

    Changed by Bence Béky - bncohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:11:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66871e3ef3779595d6294e09e95cf4c59e2c7342

    Comments

    Change SpdyHeaderBlockNetLogCallback() dict value type.
    
    SpdyHeaderBlockNetLogCallback() returns a base::DictionaryValue with a
    single entry with key "headers".  This CL changes the value of that
    entry from a base::DictionaryValue to a base::ListValue.  The motivation
    is that this way duplicate code with ElideSpdyHeaderBlockForNetLog() can
    be eliminated, so it will be enough to fix https://crbug.com/800282 in
    one function.
    
    Also make sure that unittests only use base::Value methods that are not
    marked as deprecated.
    
    Bug: 800282
    Change-Id: Ie9396f7299acb84ad21892894ae5607ee8af7f34
    Reviewed-on: https://chromium-review.googlesource.com/c/1362086
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Commit-Queue: Bence Béky <bnc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614490}

    Changed files

    • net/spdy/spdy_log_util.cc
    • net/spdy/spdy_log_util_unittest.cc
    • net/spdy/spdy_network_transaction_unittest.cc
  90. [NTP] Display promos on the local NTP

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:10:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f966bb5956e85d829d23ed59cf2370ac36d6f10

    Comments

    [NTP] Display promos on the local NTP
    
    If promo data is available display it on the local NTP.
    
    Bug: 906278
    Change-Id: Ibd9e60e180bc9d37a2c99a1bf86dca7fc5fa8516
    Reviewed-on: https://chromium-review.googlesource.com/c/1353988
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614489}

    Changed files

    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/local_ntp.js
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/search/local_ntp_source.h
    • chrome/browser/search/promos/promo_service.h
    • chrome/browser/ui/search/local_ntp_promos_browsertest.cc
    • chrome/test/BUILD.gn
    • tools/metrics/histograms/histograms.xml
  91. Run network service tests in-process on FYI bots

    Changed by Clark DuVall - cduvallohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 21:06:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a89d2f882b65865b5a53241d197691e7f6f4ea3d

    Comments

    Run network service tests in-process on FYI bots
    
    This runs all Android tests in-process on the Mojo Android bot, and runs
    browser_tests in-process on Windows/Linux.
    
    Bug: 908993
    Change-Id: I86a683885c0c3081533623d5771ffb4f24561a70
    Reviewed-on: https://chromium-review.googlesource.com/c/1361921
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614488}

    Changed files

    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  92. Add some BBC domains to the HSTS preload list

    Changed by Nick Harper - nharperohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:59:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b41d1d9efacade5fe7e3cfc9fa59fc001ab64d92

    Comments

    Add some BBC domains to the HSTS preload list
    
    Change-Id: If98e0cbe08d98b77b0652364b036fc4f720f19c0
    Reviewed-on: https://chromium-review.googlesource.com/c/1363901
    Reviewed-by: Bence Béky <bnc@chromium.org>
    Commit-Queue: Nick Harper <nharper@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614487}

    Changed files

    • net/http/transport_security_state_static.json
  93. Reland: Add util method to update ArchiveAnalyzerResults for a single file

    Changed by Daniel Rubery - druberyohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:57:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c065bb11d7a6e0227c0d32e043e458e1ef76091

    Comments

    Reland: Add util method to update ArchiveAnalyzerResults for a single file
    
    This CL breaks out the code that inspects an individual file within a
    ZIP archive. This will be shared between the ZIP and RAR inspection,
    when RAR files begin doing content inspection.
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1354103
    The OOB read has been fixed between patchsets 1 and 2.
    
    Bug: 909778
    Change-Id: I707364516217136ee95174bbae930b5df0cf54ed
    TBR: jcivelli@
    Reviewed-on: https://chromium-review.googlesource.com/c/1359037
    Commit-Queue: Daniel Rubery <drubery@chromium.org>
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614486}

    Changed files

    • chrome/common/safe_browsing/BUILD.gn
    • chrome/common/safe_browsing/archive_analyzer_results.cc
    • chrome/common/safe_browsing/archive_analyzer_results.h
    • chrome/common/safe_browsing/zip_analyzer.cc
    • chrome/services/file_util/public/cpp/sandboxed_zip_analyzer_unittest.cc
    • chrome/utility/safe_browsing/mac/BUILD.gn
    • tools/metrics/histograms/histograms.xml
  94. Roll src/third_party/catapult 285509d0e41e..d18d6c7c7183 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 20:56:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2610d29728707cc0f9959c1f6a610d4baa478a62

    Comments

    Roll src/third_party/catapult 285509d0e41e..d18d6c7c7183 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/285509d0e41e..d18d6c7c7183
    
    
    git log 285509d0e41e..d18d6c7c7183 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 oysteine@google.com Remove precision check from the EQT metric calculation
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@d18d6c7c7183
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: I3020fbca08d04e3b2f88c7ad1298a32f966adcad
    Reviewed-on: https://chromium-review.googlesource.com/c/1366476
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614485}

    Changed files

    • DEPS
  95. Network Service: Add DCHECK() for |callback_| in SiteDataClearer destructor

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:55:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5dfaf338a6b7f5c283e093059fc9e8dbfcc7c1d1

    Comments

    Network Service: Add DCHECK() for |callback_| in SiteDataClearer destructor
    
    This CL adds a DCHECK() in the SiteDataClearer destructor to make sure the
    |callback_| is already null when the destructor is called.
    
    Bug: 909826
    Change-Id: I0cb3b039e23e16d3c827e9c877ea413619542158
    Reviewed-on: https://chromium-review.googlesource.com/c/1359295
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614484}

    Changed files

    • content/browser/browsing_data/clear_site_data_utils.cc
  96. Roll src/third_party/SPIRV-Tools/src aa270e568a3f..cf37ab7213d2 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 20:50:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e519987067ebabb7f08680c97681d5107e2414b

    Comments

    Roll src/third_party/SPIRV-Tools/src aa270e568a3f..cf37ab7213d2 (1 commits)
    
    https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/aa270e568a3f..cf37ab7213d2
    
    
    git log aa270e568a3f..cf37ab7213d2 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 zoddicus@users.noreply.github.com Merge two implementations of ValidateMemorySemantics (#2175)
    
    
    Created with:
      gclient setdep -r src/third_party/SPIRV-Tools/src@cf37ab7213d2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I0e60385ff1e52620d37b9424fe2d27538ff3bf0a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366364
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614483}

    Changed files

    • DEPS
  97. [ios] feature flag for find in page iframe

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:46:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77905ac0652a3187769ee51328a1308d23510f6a

    Comments

    [ios] feature flag for find in page iframe
    
    Bug: 896867
    Change-Id: Ia83521278052848fe57f3a99f91e1ad9dd51deac
    Reviewed-on: https://chromium-review.googlesource.com/c/1364334
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614482}

    Changed files

    • ios/chrome/browser/BUILD.gn
    • ios/chrome/browser/about_flags.mm
    • ios/chrome/browser/find_in_page/BUILD.gn
    • ios/chrome/browser/find_in_page/features.h
    • ios/chrome/browser/find_in_page/features.mm
    • ios/chrome/browser/ios_chrome_flag_descriptions.cc
    • ios/chrome/browser/ios_chrome_flag_descriptions.h
  98. Roll src/third_party/skia ae9dfc0e5845..055539a9c2d9 (8 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 20:41:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a077191ee370c20676895e4fdbafc826b0affe8f

    Comments

    Roll src/third_party/skia ae9dfc0e5845..055539a9c2d9 (8 commits)
    
    https://skia.googlesource.com/skia.git/+log/ae9dfc0e5845..055539a9c2d9
    
    
    git log ae9dfc0e5845..055539a9c2d9 --date=short --no-merges --format='%ad %ae %s'
    2018-12-06 egdaniel@google.com Revert "switched GrVkCopyManager to use secondary command buffer instead of AMD-specific workaround"
    2018-12-06 reed@google.com more simple makers for textblobs
    2018-12-06 michaelludwig@google.com Fix performance regresion on Mali, while preserving sk_FragCoord.w
    2018-12-06 reed@google.com remove SkPaint breakText, use SkFont instead (or don't call it)
    2018-12-06 caryclark@skia.org bookmaker nightly fix
    2018-12-06 ethannicholas@google.com Removed mustSubmitCommandsBeforeCopyOp
    2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c730c3846064..c0f92f2308d1 (1 commits)
    2018-12-06 brianosman@google.com Add a hash of all vertex attributes to the GrProgramDesc key
    
    
    Created with:
      gclient setdep -r src/third_party/skia@055539a9c2d9
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jcgregorio@chromium.org
    
    Change-Id: I7ce4bcec21cebf5c2a2d5cb1bb4c5a58fa799c51
    Reviewed-on: https://chromium-review.googlesource.com/c/1366361
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614481}

    Changed files

    • DEPS
  99. Update V8 to version 7.3.52.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 06-Dec-18 20:40:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 198249d8c27c9f6844515bc2a2d71f59027118d9

    Comments

    Update V8 to version 7.3.52.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/f5137533..c5bfa5d3
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I4ccd02b6270fbebb451a491ef83c14c47f5f218f
    Reviewed-on: https://chromium-review.googlesource.com/c/1365718
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614480}

    Changed files

    • DEPS
  100. Make WebWidget methods on WebView private.

    Changed by danakj - danakjohnoyoudont@chromium.org
    Changed at Thursday, 06-Dec-18 20:35:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 497a616eccb04d08841535091b1ab4c9c3599a72

    Comments

    Make WebWidget methods on WebView private.
    
    Callers should go through WebView's MainFrameWidget() to get to them.
    While WebViewImpl inherits privately from WebWidget, the overrides of
    its methods were all public. This moves them to the private section
    with the single exception of GetPagePopup(). This method probably
    belongs on WebView, but WebViewImpl changes its return type, so it's
    harder to simply move mechanically. A TODO is left for that one.
    
    This change is mechanical and not opinionated. All callers that failed
    to compile are simply switched to call MainFrameWidget()-> in order to
    get to the methods.
    
    R=dcheng@chromium.org
    
    Change-Id: I44cb270a97f3a4034f00c00631dad8631678ef53
    Bug: 912193
    Reviewed-on: https://chromium-review.googlesource.com/c/1363855
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614479}

    Changed files

    • third_party/blink/public/web/web_view.h
    • third_party/blink/renderer/core/animation/compositor_animations_test.cc
    • third_party/blink/renderer/core/editing/finder/text_finder_test.cc
    • third_party/blink/renderer/core/editing/link_selection_test.cc
    • third_party/blink/renderer/core/events/web_input_event_conversion_test.cc
    • third_party/blink/renderer/core/exported/web_frame_serializer_sanitization_test.cc
    • third_party/blink/renderer/core/exported/web_frame_test.cc
    • third_party/blink/renderer/core/exported/web_layer_test.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
    • third_party/blink/renderer/core/exported/web_plugin_container_test.cc
    • third_party/blink/renderer/core/exported/web_view_impl.h
    • third_party/blink/renderer/core/exported/web_view_test.cc
    • third_party/blink/renderer/core/frame/browser_controls_test.cc
    • third_party/blink/renderer/core/frame/document_loading_rendering_test.cc
    • third_party/blink/renderer/core/frame/frame_overlay_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.cc
    • third_party/blink/renderer/core/frame/fullscreen_controller.cc
    • third_party/blink/renderer/core/frame/rotation_viewport_anchor_test.cc
    • third_party/blink/renderer/core/frame/visual_viewport_test.cc
    • third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
    • third_party/blink/renderer/core/html/anchor_element_metrics_test.cc
    • third_party/blink/renderer/core/html/forms/external_popup_menu_test.cc
    • third_party/blink/renderer/core/html/image_document_test.cc
    • third_party/blink/renderer/core/html/imports/html_import_sheets_test.cc
    • third_party/blink/renderer/core/html/lazy_load_frame_observer_test.cc
    • third_party/blink/renderer/core/html/media_element_filling_viewport_test.cc
    • third_party/blink/renderer/core/input/event_handler_test.cc
    • third_party/blink/renderer/core/input/ime_on_focus_test.cc
    • third_party/blink/renderer/core/input/overscroll_behavior_test.cc
    • third_party/blink/renderer/core/input/pointer_event_manager_test.cc
    • third_party/blink/renderer/core/input/scroll_snap_test.cc
    • third_party/blink/renderer/core/input/touch_action_test.cc
    • third_party/blink/renderer/core/input/touch_event_manager_test.cc
    • third_party/blink/renderer/core/intersection_observer/intersection_observer_test.cc
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
    • third_party/blink/renderer/core/loader/programmatic_scroll_test.cc
    • third_party/blink/renderer/core/page/autoscroll_controller_test.cc
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/drag_controller_test.cc
    • third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
    • third_party/blink/renderer/core/page/scrolling/scroll_into_view_test.cc
    • third_party/blink/renderer/core/page/scrolling/scroll_metrics_test.cc
    • third_party/blink/renderer/core/page/scrolling/scrolling_coordinator_test.cc
    • third_party/blink/renderer/core/page/viewport_test.cc
    • third_party/blink/renderer/core/paint/link_highlight_impl_test.cc
    • third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
    • third_party/blink/renderer/core/testing/sim/sim_compositor.cc
  101. <blame list capped at 100 commits>

    Changed by <blame list capped at 100 commits> -
    Changed at N/A
    Repository
    Branch
    Revision

    Comments

    <blame list capped at 100 commits>