Home | Search | chromium - Builders
Login

Builder Nougat Phone Tester Build 7884 Canonical Ubuntu

Results:

Failure chrome_public_test_vr_apk-ddready-ddview on Android device Pixel 1 XL

Trigger Info:

Projectchromium
Revision78efc0e62ef2a44cad7007296d20e29541758860
Got Revision78efc0e62ef2a44cad7007296d20e29541758860

Execution:

Steps and Logfiles:

Show:
  1. ( 376 ms ) setup_build
    running recipe: "chromium"
  2. ( 987 ms ) report builders
     
    running tester 'Nougat Phone Tester' on master 'chromium.android'
  3. ( 6 mins 54 secs ) bot_update
    [78GB/295GB used (26%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 43 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 554 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 17 secs ) clean local files
  9. ( 1 secs ) tree truth steps
  10. ( 471 ms ) build directory
  11. ( 1 secs ) find isolated tests
  12. ( 8 mins 10 secs ) wait for tasks
  13. ( 5 secs ) chrome_public_test_vr_apk-ddready-dynamicsettings on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 46s
    Shard duration: 0:05:24.584034
  14. ( 8 mins 2 secs ) wait for tasks (2)
  15. ( 2 secs ) chrome_public_test_vr_apk-ddready-cardboard on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 43s
    Shard duration: 0:15:37.584894
  16. ( 22 mins 47 secs ) chrome_public_test_vr_apk-ddready-ddview on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 46s
    Shard duration: 0:38:18.513922
    failures:
    org.chromium.chrome.browser.vr.WebXrVrInputTest#testInSessionPermissionRequestsIncognito__ChromeTabbedActivity
    org.chromium.chrome.browser.vr.VrBrowserNavigationTest#testBackDoesntBackgroundChrome
    org.chromium.chrome.browser.vr.WebXrVrInputTest#testAppButtonLongPressDisplaysPermissionsIncognito__ChromeTabbedActivity
    org.chromium.chrome.browser.vr.VrBrowserNavigationTest#testNavigationButtons
    org.chromium.chrome.browser.vr.WebXrVrTabTest#testPermissionsInOtherTabIncognito__ChromeTabbedActivity
     
  17. ( 233 ms ) Tests statistics
     
    Stats
    Total shards: 3
    Total runtime: 0:57:50.788382
     
  18. ( 239 ms ) test_report
  19. ( 1 ms ) Failure reason

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm376-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541714986464423, "id": "8930388382311711472", "project": "chromium", "tags": ["builder:Nougat Phone Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/78efc0e62ef2a44cad7007296d20e29541758860", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm64 Builder (dbg)", "parent_buildnumber:33964", "scheduler_invocation_id:9095818444913090208", "scheduler_job_id:chromium/Nougat Phone Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Nougat Phone Tester" setup_build
buildnumber 7884 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm64 Builder (dbg)" setup_build
parent_got_angle_revision "d856ca48f4256c13c29d53a74d19a3c7b1d053de" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "78efc0e62ef2a44cad7007296d20e29541758860" setup_build
parent_got_revision_cp "refs/heads/master@{#606593}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "993edbb473cb0de2360e22d055db67d50571859d" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.280@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "78efc0e62ef2a44cad7007296d20e29541758860" setup_build
swarm_hashes {"android_webview_unittests": "cb43ee65ef05d828f507bb30f36a2ea734a73ffb", "angle_unittests": "9fdfb760a6c045e5a8ddaade4a2ca05ff5ee9a54", "base_unittests": "a4a90d8b2aac64d1601edf06c814b066b9bd0365", "blink_common_unittests": "66657a166b6607d601e4dff5a250a4a5ea408f2d", "blink_heap_unittests": "cda925e57942849f5bef59884d5024196e7047c7", "blink_platform_unittests": "36cb6f4444bd69842936ac9c8ef2a655940476c0", "boringssl_crypto_tests": "de5a2fb3a412a6e40cd13ffddb7bcf4883fd2003", "boringssl_ssl_tests": "c20b2a2a729f483bbcf1bc79022dc0dbc00bbd54", "breakpad_unittests": "3e0ea9ece6053ab9597c6def16bd8846ef74b7aa", "cacheinvalidation_unittests": "ee50401b0c2d2b4cf5c983d716ff915577d57970", "capture_unittests": "61611a14f314b3dc41d7c1a8a626542c7cdbeb07", "cast_unittests": "41160a73c97bfcefb7d532131afb7fcba702295b", "cc_unittests": "b9bf7cb42e99f30efc22f044acbbcdc87723725f", "chrome_public_test_apk": "b4dde9a8722d4fc6967ff1c03f2f4058654c33fe", "chrome_public_test_vr_apk": "3b6cc7a91d714a927fa97cc0f64560fda6775b27", "components_browsertests": "86699c6659cf6a90bfcfab803478203e4339cfa3", "components_unittests": "2c4c70a9d9aa627f984491e35517724dfa716e69", "content_browsertests": "b80dbca57a3069e8086639c2c226e32a59c0c8cc", "content_shell_test_apk": "561e8c6c404e3258fa8caa71716b51c2a8e26843", "content_unittests": "79e26deaca905d38fb6d2f35907356c214995a6d", "crypto_unittests": "06d87bcc185aa5d9de450ae453e793d65cdbb4f8", "device_unittests": "80b48fb9affba8fcd820299926a722a2363b10c2", "display_unittests": "28fd86e9a97b697a1259991f16e456b7a5cd2c2b", "events_unittests": "6857e9fef0129c5333f4181d29f43776386ee3bb", "gcm_unit_tests": "6d9ee5290442c5f816702d9774a498167c5d84ce", "gfx_unittests": "3134ee0a90ac94a8763a760a56ec2cedfb46d223", "gin_unittests": "956fc82c6ab6e0009dc1e90298aa3d6670506efa", "gl_tests": "fbdd10b9588ca5c5b583bcd7784ccba655d92d3e", "gl_unittests": "ca470ba6c8b37bef184d96f25c2864751acdbd5e", "google_apis_unittests": "05e8a35ad6821e65aa49830a29e46fd881669104", "gpu_unittests": "b9c2974a3e9ade5fe195bfdb38254f13006d16a4", "ipc_tests": "95ca73919ddcc1f88fd70da20c2789b989fc813f", "jingle_unittests": "80f7171adcfbd81988c92cbd72c63d469b1988ac", "latency_unittests": "0260f5f92fc27672eddbed681cefc84d3b7c7de1", "libjingle_xmpp_unittests": "c7616de8ba47cb1f4faf468c6c715bd01e6bedcf", "media_blink_unittests": "3c528f87cc4a16be0bac9bcc71b1794e7a876eca", "media_service_unittests": "df75d292f6e083e76a1952fea9c797512663fca7", "media_unittests": "75cfde151dd022e64e7967ca834094c79cadb966", "midi_unittests": "13726163ce3cd1997650a747b723bc182c46384c", "mojo_test_apk": "8eecd882e6b3836c0a34b0bd70ce6a42163ea313", "mojo_unittests": "70c1243c615eb0c218b40c8182d342da040eef14", "monochrome_public_test_ar_apk": "7239f614e936644f5399131f02882799449ee469", "net_unittests": "7496571bcbcfe01edf934f5a5f37b07e315ef98d", "sandbox_linux_unittests": "387b61cee119f89f62d3ae799e713272f1c45d0a", "services_unittests": "5b61250af074a409b36bc167685599ae36d06c50", "shell_dialogs_unittests": "98c5b0033b27efefd88ca16a8597a0c919e4e248", "skia_unittests": "d4ca3b4ee5ddf4cd6db86d817d8ac183cf88fc75", "sql_unittests": "077eea9cfae6db2218254f3c28dfdef2db47ed31", "storage_unittests": "be6df40f22cbc6007fb0fbc58dcbfb034af4ab7a", "ui_android_unittests": "d5ba5940282d539b3d2471870a3838e809a03b14", "ui_base_unittests": "06bf6e05e5d212f4411a699548913d0cd88ee9ab", "ui_touch_selection_unittests": "ff0bb0742a1e277244d9a3722eea50cc841dbb75", "unit_tests": "2cfe94de16506225938993de31f01d915ab9aecc", "url_unittests": "e9ca035845a073060ee200260ad972247f1ef347", "viz_unittests": "a09f1687d4b3cd961817664f0034e7c622c93077", "vr_common_unittests": "f3963689bad6d42ce19a882cccc56971c0a71962", "vr_pixeltests": "d67c407a5958fd5435f29f9074c95e5c09e28d5f", "webkit_unit_tests": "fa1bcc951d37b2aeb496072f3a1142ff1a8c473e", "webview_instrumentation_test_apk": "7616c137d38e6eb58d7483570f53fed14b5d4e44", "wtf_unittests": "9cfef56244e8bfbb8ca75813f77c83d4381f7703"} setup_build
got_angle_revision "d856ca48f4256c13c29d53a74d19a3c7b1d053de" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "78efc0e62ef2a44cad7007296d20e29541758860" bot_update
got_revision_cp "refs/heads/master@{#606593}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "993edbb473cb0de2360e22d055db67d50571859d" bot_update
got_v8_revision_cp "refs/heads/7.2.280@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  2. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  3. Mitsuru Oshima (oshimaohnoyoudont@chromium.org)
  4. Fady Samuel (fsamuelohnoyoudont@chromium.org)
  5. sczs (sczsohnoyoudont@chromium.org)
  6. Tomas Popela (tomas.popelaohnoyoudont@gmail.com)
  7. Ivan Šandrk (isandrkohnoyoudont@chromium.org)
  8. Dirk Pranke (dprankeohnoyoudont@chromium.org)
  9. Weidong Guo (weidonggohnoyoudont@chromium.org)
  10. Stephen Chenney (schenneyohnoyoudont@chromium.org)
  11. Eric Roman (eromanohnoyoudont@chromium.org)
  12. Mike Frysinger (vapierohnoyoudont@chromium.org)
  13. Stephen Chenney (schenneyohnoyoudont@chromium.org)
  14. Ehsan Chiniforooshan (chiniforooshanohnoyoudont@chromium.org)
  15. Dale Curtis (dalecurtisohnoyoudont@chromium.org)
  16. Donn Denman (donndohnoyoudont@chromium.org)
  17. James Cook (jamescookohnoyoudont@chromium.org)
  18. Camillo Bruni (cbruniohnoyoudont@chromium.org)
  19. Stephen Chenney (schenneyohnoyoudont@chromium.org)
  20. Yiming Zhou (uwyimingohnoyoudont@google.com)
  21. Ella Ge (eirageohnoyoudont@chromium.org)
  22. Gordana Cmiljanovic (gordana.cmiljanovicohnoyoudont@mips.com)
  23. Michael Ludwig (michaelludwigohnoyoudont@google.com)
  24. Eric Seckler (esecklerohnoyoudont@chromium.org)
  25. Scott Graham (scottmgohnoyoudont@chromium.org)
  26. Nick Harper (nharperohnoyoudont@chromium.org)
  27. Scott Violet (skyohnoyoudont@chromium.org)
  28. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  29. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  30. James Hawkins (jhawkinsohnoyoudont@chromium.org)
  31. James Hawkins (jhawkinsohnoyoudont@chromium.org)

Timing:

Create Thursday, 08-Nov-18 22:09:46 UTC
Start Thursday, 08-Nov-18 22:10:21 UTC
End Thursday, 08-Nov-18 22:58:44 UTC
Pending 35 secs
Execution 48 mins 22 secs

All Changes:

  1. Roll src/third_party/pdfium e5e0aea5a404..625c7d270c1b (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Thursday, 08-Nov-18 20:42:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78efc0e62ef2a44cad7007296d20e29541758860

    Comments

    Roll src/third_party/pdfium e5e0aea5a404..625c7d270c1b (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/e5e0aea5a404..625c7d270c1b
    
    
    git log e5e0aea5a404..625c7d270c1b --date=short --no-merges --format='%ad %ae %s'
    2018-11-08 thestig@chromium.org Clean up CPDF_TransferFunc.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@625c7d270c1b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I7de81829e0e267160d20bde30c0f665100bd11a3
    Reviewed-on: https://chromium-review.googlesource.com/c/1327342
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606593}

    Changed files

    • DEPS
  2. [DevTools] Use PageMock in last-execution-context.js

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:41:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a079ebe818c533010c7e992a493f57c493407da

    Comments

    [DevTools] Use PageMock in last-execution-context.js
    
    Bug: 775132
    Change-Id: I7f7f58f56e437895afd91002e2316c4ef40c92ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1324455
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606592}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/last-execution-context.js
    • third_party/blink/renderer/devtools/front_end/sdk_test_runner/PageMockTestRunner.js
  3. Do not reuse mask layer in AppsGridView

    Changed by Mitsuru Oshima - oshimaohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:37:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8dd318bc03f11f8d365db71450fdf7a437d58486

    Comments

    Do not reuse mask layer in AppsGridView
    
    Because the mask layer may be used by a detached layer, and re-using
    before the detached layer is deleted can lead to a crash.
    
    Bug: b/118822974
    Test: manual. See bug for repro step.
    Change-Id: I82379d6f10f7b00fba8b581e667198f28f82f645
    Reviewed-on: https://chromium-review.googlesource.com/c/1325565
    Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606591}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
  4. viz: Plumb LocalSurfaceIdAllocation to more places [part 4]

    Changed by Fady Samuel - fsamuelohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:34:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6b52ea6880ee965f9e51441db277a63cea909fe

    Comments

    viz: Plumb LocalSurfaceIdAllocation to more places [part 4]
    
    viz::LocalSurfaceIdAllocation bundles a viz::LocalSurfaceId and an
    allocation time for that viz::LocalSurfaceId. The purpose of this allocation
    time is to determine how long it takes for a surface to get embedded once
    an ID has been allocated for it.
    
    There was some concern raised about drift between LocalSurfaceIds and allocation
    times and so a previous CL bundled the two together in a class. This CL plumbs
    LocalSurfaceIdAllocation to more places to ensure the two quantities remain
    in sync with one another.
    
    This CL plumbs LocalSurfaceIdAllocation through FrameVisualProperties which
    ensures we plumb valid timestamps from a parent renderer to the browser and
    ultimately to child renderers.
    
    Bug: 655231
    Change-Id: I1cb7e3e3acacc4fc5398d65f6f62892a2127346d
    Reviewed-on: https://chromium-review.googlesource.com/c/1324097
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606590}

    Changed files

    • content/browser/browser_plugin/browser_plugin_guest.cc
    • content/browser/browser_plugin/browser_plugin_guest.h
    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/frame_host/cross_process_frame_connector.h
    • content/browser/renderer_host/frame_connector_delegate.cc
    • content/browser/renderer_host/frame_connector_delegate.h
    • content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
    • content/common/browser_plugin/browser_plugin_messages.h
    • content/common/frame_messages.h
    • content/common/frame_visual_properties.h
    • content/public/test/browser_test_utils.cc
    • content/public/test/browser_test_utils.h
    • content/renderer/browser_plugin/browser_plugin.cc
    • content/renderer/render_frame_proxy.cc
  5. [ios] Deletes Infobar Sizing Delegates

    Changed by sczs - sczsohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:29:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed44ca7afd8bf781788f73b8df6db9f3bde38a18

    Comments

    [ios] Deletes Infobar Sizing Delegates
    
    Before this CL Infobar.cc was informing InfobarContainer of an InfobarView
    resize. Also, the InfobarView was being set by Infobar.cc it now sets its
    own height.
    
    This CL:
    - Adds functionality so InfobarContainer resizing is driven by UiKit.
    - Deletes InfobarViewSizing and InfobarViewSizingDelegate.
    - Removes the plumbing from InfobarView that informs Infobar.cc of a
    resize.
    - Removes InfobarIOS and InfobarController methods that were used to
    resize the InfobarView.
    
    Bug: 892376
    Change-Id: Iaae3c0ec36ce226fc89fb405cb3d9c40376d3a79
    Reviewed-on: https://chromium-review.googlesource.com/c/1321849
    Commit-Queue: Sergio Collazos <sczs@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606589}

    Changed files

    • ios/chrome/browser/infobars/confirm_infobar_controller.mm
    • ios/chrome/browser/infobars/infobar.h
    • ios/chrome/browser/infobars/infobar.mm
    • ios/chrome/browser/infobars/infobar_controller+protected.h
    • ios/chrome/browser/infobars/infobar_controller.h
    • ios/chrome/browser/infobars/infobar_controller.mm
    • ios/chrome/browser/infobars/infobar_controller_delegate.h
    • ios/chrome/browser/translate/after_translate_infobar_controller.mm
    • ios/chrome/browser/translate/before_translate_infobar_controller.mm
    • ios/chrome/browser/translate/never_translate_infobar_controller.mm
    • ios/chrome/browser/translate/translate_message_infobar_controller.mm
    • ios/chrome/browser/ui/autofill/save_card_infobar_controller.mm
    • ios/chrome/browser/ui/autofill/save_card_infobar_view.h
    • ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
    • ios/chrome/browser/ui/infobars/BUILD.gn
    • ios/chrome/browser/ui/infobars/confirm_infobar_view.h
    • ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
    • ios/chrome/browser/ui/infobars/infobar_container_view_controller.mm
    • ios/chrome/browser/ui/infobars/infobar_view_sizing.h
    • ios/chrome/browser/ui/infobars/infobar_view_sizing_delegate.h
  6. Add support for variadic arguments in generated stubs

    Changed by Tomas Popela - tomas.popelaohnoyoudont@gmail.com
    Changed at Thursday, 08-Nov-18 20:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d27bb5431562964962e8eef4a4374d27290b218d

    Comments

    Add support for variadic arguments in generated stubs
    
    Previously we were using va_list for variadic arguments. The downside
    for this was that only the first value from the variadic argument was
    passed to the original function.
    
    To make it work properly we have to use the __VA_ARGS__ variadic macro
    that was introduces in C99 and is available in all major C/C++
    compilers.
    
    Change-Id: I50652f7348a16214811aaab8af116d78cdb70444
    Reviewed-on: https://chromium-review.googlesource.com/c/1323089
    Reviewed-by: Patrik Höglund <phoglund@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#606588}

    Changed files

    • tools/generate_stubs/generate_stubs.py
    • tools/generate_stubs/generate_stubs_unittest.py
  7. [Remote user wipe] Update wrong year on one file (2014 -> 2018)

    Changed by Ivan Šandrk - isandrkohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:28:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd3fd842611b201d8f4cbbce07578d443746f6ba

    Comments

    [Remote user wipe] Update wrong year on one file (2014 -> 2018)
    
    This was a mistake on my part when writing the original file, and it
    was just too bothering to see the wrong year on the file and get
    confused by it, so I had to update it :-)
    
    Change-Id: Ia59fd264f11bda490448a386528b9b2fc0606473
    Reviewed-on: https://chromium-review.googlesource.com/c/1326641
    Reviewed-by: James Cook <jamescook@chromium.org>
    Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606587}

    Changed files

    • chrome/browser/chromeos/system/user_removal_manager.cc
  8. Fix missing data_deps on //chrome:chrome on Windows.

    Changed by Dirk Pranke - dprankeohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:24:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d93d4102d04411f2432716d7de7fcc5dff9c881

    Comments

    Fix missing data_deps on //chrome:chrome on Windows.
    
    The //chrome:chrome group was missing a data_deps declaration
    on //chrome:reorder_imports, which meant that chrome would build
    fine but if you ran `mb zip //out/Release //chrome` you'd only
    get the copy in //out/Release/initialexe/chrome.exe and not
    the final version in //out/Release.
    
    Bug: 902010
    
    Change-Id: I0f3b662ced4c34eef974e8bede01fb9c89410dc1
    Reviewed-on: https://chromium-review.googlesource.com/c/1325554
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606586}

    Changed files

    • chrome/BUILD.gn
  9. Fix page slip issue after dragging

    Changed by Weidong Guo - weidonggohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:23:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 05e6d6110b8ee4c29a04943ac021bf59c1d62c72

    Comments

    Fix page slip issue after dragging
    
    Changes:
    Update the selected page to be the target page of dragged item at the
    end of dragging.
    
    Bug: 893832
    Change-Id: I91dcf8e03f62eab1597e3899bdbcafdad1fec2df
    Reviewed-on: https://chromium-review.googlesource.com/c/1324851
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Alex Newcomer <newcomer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606585}

    Changed files

    • ash/app_list/views/apps_grid_view.cc
  10. Improve testing and fix bugs for LocalFrameUKMAggregator

    Changed by Stephen Chenney - schenneyohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:18:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8a077f10a84eb683272f77e6f801129a39bf658

    Comments

    Improve testing and fix bugs for LocalFrameUKMAggregator
    
    Add testing for the ratio metrics and fix bugs that were detected.
    
    Rename the ratio metrics to be specific to MainFrame to prepare for future ratios.
    
    R=pdr@chromium.org
    BUG=892861
    
    Change-Id: I01ad5d059d423366e118335ff9288e7eb2cdb339
    Reviewed-on: https://chromium-review.googlesource.com/c/1320692
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Stephen Chenney <schenney@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606584}

    Changed files

    • third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.cc
    • third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.h
    • third_party/blink/renderer/core/frame/local_frame_ukm_aggregator_test.cc
  11. Remove ProxyBypassRules::Equals() and ProxyBypassRules::AssignFrom().

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:15:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e1ecbb6ae4a5e1e74e780999f191fb2cb600c98

    Comments

    Remove ProxyBypassRules::Equals() and ProxyBypassRules::AssignFrom().
    
    Instead use operator== and operator=.
    
    Change-Id: Ia2f694e75f3a5f22338d97ec7c4ce61e1a500996
    Reviewed-on: https://chromium-review.googlesource.com/c/1324133
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606583}

    Changed files

    • chromeos/network/onc/onc_utils.cc
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_unittest.cc
    • net/proxy_resolution/proxy_bypass_rules.cc
    • net/proxy_resolution/proxy_bypass_rules.h
    • net/proxy_resolution/proxy_bypass_rules_unittest.cc
    • net/proxy_resolution/proxy_config.cc
  12. grit: fix buildinfo help output

    Changed by Mike Frysinger - vapierohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:14:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c212d9a18134fd10ec28dba91a71497ed42765a

    Comments

    grit: fix buildinfo help output
    
    The usage docs were in the wrong docstring.
    
    Bug: 747171
    Change-Id: Ia08331f8c41f86ce41c795ff1494e258c0d33bf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1323807
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Mike Frysinger <vapier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606582}

    Changed files

    • tools/grit/grit/tool/buildinfo.py
  13. For tests with 5 or more calls, create a local UpdateAllLifecyclePhases

    Changed by Stephen Chenney - schenneyohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7260681b864d2cd058801324181de3a3fc9a7c2f

    Comments

    For tests with 5 or more calls, create a local UpdateAllLifecyclePhases
    
    In preparation for a series of patches that change the arguments to
    UpdateAllLifecyclePhases, create a local helper in tests that do not
    derive from PageTest so that only one call site needs to be changed.
    
    There is no change in functionality at all. Tests writers no need to be
    less concerned about the arguments to lifecycle updates.
    
    R=pdr@chromium.org
    
    Bug: 902436
    Change-Id: Icee20e327aa5d88ecdc38852d41d1b9bda4e2454
    Reviewed-on: https://chromium-review.googlesource.com/c/1324230
    Commit-Queue: Stephen Chenney <schenney@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Reviewed-by: Rick Byers <rbyers@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606581}

    Changed files

    • content/shell/test_runner/event_sender.cc
    • content/shell/test_runner/event_sender.h
    • third_party/blink/renderer/core/css/style_engine_test.cc
    • third_party/blink/renderer/core/exported/web_plugin_container_test.cc
    • third_party/blink/renderer/core/exported/web_view_test.cc
    • third_party/blink/renderer/core/frame/browser_controls_test.cc
    • third_party/blink/renderer/core/frame/use_counter_test.cc
    • third_party/blink/renderer/core/frame/visual_viewport_test.cc
    • third_party/blink/renderer/core/html/forms/text_control_element_test.cc
    • third_party/blink/renderer/core/layout/jank_tracker_test.cc
    • third_party/blink/renderer/core/layout/layout_geometry_map_test.cc
    • third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
    • third_party/blink/renderer/core/page/scrolling/scroll_metrics_test.cc
    • third_party/blink/renderer/core/page/spatial_navigation_test.cc
    • third_party/blink/renderer/core/paint/link_highlight_impl_test.cc
    • third_party/blink/renderer/core/scheduler/frame_throttling_test.cc
  14. Telemetry: do display tracing in rendering.mobile

    Changed by Ehsan Chiniforooshan - chiniforooshanohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:13:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4726135f893e414928888cdfb2c36f852d0a0ff7

    Comments

    Telemetry: do display tracing in rendering.mobile
    
    Bug: 903204
    Change-Id: I7d2cbff9184eb9f0fa93bfe14708ca719f145e7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327150
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606580}

    Changed files

    • tools/perf/benchmarks/rendering.py
  15. Move libopus SSE4.1 source into the SSE4.1 block.

    Changed by Dale Curtis - dalecurtisohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:12:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae94013397d9409b164e6f66f946c6927a2fe9c3

    Comments

    Move libopus SSE4.1 source into the SSE4.1 block.
    
    BUG=webrtc:9530
    TEST=cq
    R=sergeyu
    
    Change-Id: I7c007d4dfd12aa86a56fccaef176d614531533c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1327151
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606579}

    Changed files

    • third_party/opus/BUILD.gn
  16. [TTS] Minor cleanup to CS usage of Ranker

    Changed by Donn Denman - donndohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:07:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b884937ff9adc2e154e2e4f4441aa1a38546a489

    Comments

    [TTS] Minor cleanup to CS usage of Ranker
    
    Fixes a bug in the existing Ranker code: the native logger cannot log
    64-bit values, so we rename some misleading methods. Also fix some
    references to @Nullable.
    
    BUG=872902
    
    Change-Id: I496c8140293200d7f8041fba1a5ede8fac26646a
    Reviewed-on: https://chromium-review.googlesource.com/c/1321670
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Donn Denman <donnd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606578}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
    • chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFakeServer.java
    • chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc
    • chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.h
  17. Create lock screen app widgets maximized by default

    Changed by James Cook - jamescookohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:05:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50efb07037ee20bafe268fde806eb9492eb8170b

    Comments

    Create lock screen app widgets maximized by default
    
    Ash will end up maximizing the windows when they are added to the
    lock screen container. Creating the widget maximized avoids some
    back-and-forth with the window manager under mash. It also simplifies
    testing.
    
    Bug: 899055
    Test: browser_tests
    Change-Id: I168ba67c1cc7c680cd0c9a4b4a1b22c3c40bd500
    Reviewed-on: https://chromium-review.googlesource.com/c/1316438
    Commit-Queue: James Cook <jamescook@chromium.org>
    Reviewed-by: Toni Baržić <tbarzic@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606577}

    Changed files

    • chrome/browser/chromeos/lock_screen_apps/note_taking_browsertest.cc
    • chrome/browser/chromeos/lock_screen_apps/state_controller.h
    • chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
    • chrome/test/data/extensions/lock_screen_apps/app_launch/test.js
  18. [perf] Add browse:media:pinterest:2018 system health story

    Changed by Camillo Bruni - cbruniohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:02:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b9f495b188ae42ca674b0d68273b463e585722c

    Comments

    [perf] Add browse:media:pinterest:2018 system health story
    
    
    Bug: 878390
    Change-Id: Ib536680adcbba24e86452ae16502c133eef01ddc
    Reviewed-on: https://chromium-review.googlesource.com/c/1256776
    Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606576}

    Changed files

    • tools/perf/benchmarks/system_health_smoke_test.py
    • tools/perf/page_sets/data/system_health_desktop.json
    • tools/perf/page_sets/data/system_health_desktop_939ec7010c.wprgo.sha1
    • tools/perf/page_sets/login_helpers/pinterest_login.py
    • tools/perf/page_sets/system_health/browsing_stories.py
  19. Fix MainFrame metrics recording call sites

    Changed by Stephen Chenney - schenneyohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 20:00:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b508a247814ad7a8adb9dc4ab557a733ce03c2d6

    Comments

    Fix MainFrame metrics recording call sites
    
    WebFrameWidgetImpl was missing a call to record metrics, resulting in OOPIF not
    recording main frame metrics for their update. And the SingleThreadProxy was
    not recording metrics at all, which causes crashes with an upcoming patch.
    
    R=pdr@chromium.org
    BUG=902434
    
    Change-Id: I96e4666d098ef22c2b5aec74851470319dd133f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1320691
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Stephen Chenney <schenney@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606575}

    Changed files

    • cc/trees/single_thread_proxy.cc
    • third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
    • third_party/blink/renderer/core/frame/web_frame_widget_impl.h
  20. Support subdirectories inside password manager tests.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 19:59:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 93ebd76593e8331e824a15e5d2fdb9a29b3ee5b8

    Comments

    Support subdirectories inside password manager tests.
    
    There are 15 different test scenario for password manager on each site. We therefore need to have subdirectories for different scenarios. This change adds support for 1 level of subdirectories in the password manager captured sites tests.
    
    Bug: 847905
    Change-Id: If3b52088bf857f8fcb0b42a5abcbf33ba9382055
    Reviewed-on: https://chromium-review.googlesource.com/c/1325309
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606574}

    Changed files

    • chrome/browser/password_manager/password_manager_captured_sites_interactive_uitest.cc
  21. remove set oopif mouse capture on text selection

    Changed by Ella Ge - eirageohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 19:57:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c0558c5bdbd9676fe8bbcdd2cdd524c87b5e475b

    Comments

    remove set oopif mouse capture on text selection
    
    In crrev.com/588115 introduced capture mouse events to widget during
    text selection; and a later change crrev.com/599408 make subframe
    widgets capture mouse events on MouseDown, which follows the behavior
    without OOPIF.
    Since we are captureing mouse events on MouseDown and release the
    capture on MouseUp, we don't need to treat the text selection case
    special.
    
    Bug: 647378
    Change-Id: I207777d16e11e069fb1ab60579d45324cb5b06c4
    Reviewed-on: https://chromium-review.googlesource.com/c/1308606
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606573}

    Changed files

    • content/browser/site_per_process_hit_test_browsertest.cc
    • third_party/blink/renderer/core/editing/selection_controller.cc
  22. [MIPS] Enable swiftshader for mipsel and mips64el

    Changed by Gordana Cmiljanovic - gordana.cmiljanovicohnoyoudont@mips.com
    Changed at Thursday, 08-Nov-18 19:48:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a5e7d8df1a8d9359c9ed77f0ed31a1c6f4336223

    Comments

    [MIPS] Enable swiftshader for mipsel and mips64el
    
    BUG=
    
    Change-Id: I621c411f767d2f1442bc45db78f3562101700c27
    Reviewed-on: https://chromium-review.googlesource.com/c/1322870
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606572}

    Changed files

    • ui/gl/BUILD.gn
  23. Suppress layout test for Skia roll

    Changed by Michael Ludwig - michaelludwigohnoyoudont@google.com
    Changed at Thursday, 08-Nov-18 19:45:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad0f5062a489913325c0dd5eaf0ec38c53799d43

    Comments

    Suppress layout test for Skia roll
    
    Bug: 903289
    Change-Id: Ibc84f1083d0cb121435418fcda226b16917d1b87
    Reviewed-on: https://chromium-review.googlesource.com/c/1327223
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606571}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  24. Reland "tracing: Address TracingControllerAndroid test failures."

    Changed by Eric Seckler - esecklerohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 19:41:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee630768a346b9744dce7315162388b74c1616cb

    Comments

    Reland "tracing: Address TracingControllerAndroid test failures."
    
    This is a reland of 2fc9f6f25249bf221e970854bbdd9ddc6eaed3a9
    
    The crashes in flakiness were due to calling destroy() on the wrong
    thread, which has been addressed in the new patch set.
    
    Original change's description:
    > tracing: Address TracingControllerAndroid test failures.
    >
    > Fixes the flakiness of buffer usage / known categories tests by
    > resolving an accidental race condition. Also restricts disabling
    > the other two tests to <= kitkat devices since those seem to be
    > the only ones that show (inexplicable) flakiness.
    >
    > TBR=yfriedman@chromium.org
    >
    > Bug: 899894
    > Change-Id: I0225c1519ea19910492ffb60a242bcc71b2275b4
    > Reviewed-on: https://chromium-review.googlesource.com/c/1307433
    > Reviewed-by: Eric Seckler <eseckler@chromium.org>
    > Commit-Queue: Eric Seckler <eseckler@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#604209}
    
    Bug: 899894
    Change-Id: I3cb002950f32bc6b6b4d25892adc3073c2fdb967
    Reviewed-on: https://chromium-review.googlesource.com/c/1327407
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Eric Seckler <eseckler@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606570}

    Changed files

    • content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidImplTest.java
  25. Fuchsia: Add support for vector of enum in FIDL/JS

    Changed by Scott Graham - scottmgohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 19:40:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1453d9de047aedd6b084f3abdacb858109c0f576

    Comments

    Fuchsia: Add support for vector of enum in FIDL/JS
    
    Bug: 883496
    Change-Id: Ib611c2d195b401475bb343099c8b12a644e942a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1324095
    Commit-Queue: Scott Graham <scottmg@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606569}

    Changed files

    • build/fuchsia/fidlgen_js/gen.py
    • build/fuchsia/fidlgen_js/test/fidlgen_js_unittest.cc
    • build/fuchsia/fidlgen_js/test/simple.fidl
  26. Remove Channel ID code from SSLClientSocketImpl

    Changed by Nick Harper - nharperohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 19:39:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7f7011e7ae4417f59d3e8738c9129f0d7145a56

    Comments

    Remove Channel ID code from SSLClientSocketImpl
    
    Bug: 875053
    Change-Id: I3d798801537d6ede56d2f7acd8c26982e7291313
    Reviewed-on: https://chromium-review.googlesource.com/c/1325568
    Commit-Queue: Nick Harper <nharper@chromium.org>
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606568}

    Changed files

    • net/log/net_log_event_type_list.h
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_impl.h
    • net/socket/ssl_client_socket_unittest.cc
  27. chromeos: disables test as it fails

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 19:34:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6b1a44bc8e7e6048bd2fb00e18769889684eb9a9

    Comments

    chromeos: disables test as it fails
    
    This test enables tablet mode, but it enables tablet mode in such a way
    that MultiUserWindowManager doesn't see (and process) the change. When
    the test is updated to correctly notify MultiUserWindowManager the test then
    fails. I think this may indicate a regression from recent changes and needs
    to be investigated.
    
    I came across this while doing some refactoring to MultiUserWindowManager.
    
    I've updated the test to ensure MultiUserWindowManager is called correctly
    and disabled it.
    
    BUG=756085,903427
    TEST=none
    
    Change-Id: I7b6ead448ba8d942516e42d9ef5ee745a547cc2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1327159
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606567}

    Changed files

    • chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
  28. Roll src-internal b628aaf43bd1..148454cafef1 (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Thursday, 08-Nov-18 19:33:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d87d70450cb1d3b226596430dd4dbb1fea6a9430

    Comments

    Roll src-internal b628aaf43bd1..148454cafef1 (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b628aaf43bd1..148454cafef1
    
    
    Created with:
      gclient setdep -r src-internal@148454cafef1
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Id2747d7d7e285f40149084ae4dc08c5ab2293bda
    Reviewed-on: https://chromium-review.googlesource.com/c/1327242
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606566}

    Changed files

    • DEPS
  29. Update V8 to version 7.2.280.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Thursday, 08-Nov-18 19:31:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7ac743814e45f98f24e816e000a86fe92e62774b

    Comments

    Update V8 to version 7.2.280.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/f69f7d51..993edbb4
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ieba0c084f7f69570e4adf961c5f9e4b55619d424
    Reviewed-on: https://chromium-review.googlesource.com/c/1327144
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606565}

    Changed files

    • DEPS
  30. Proximity Auth: Remove kMultiDeviceApi flagging from ProximityMonitorImpl.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 19:30:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cf72a0774107216880566d82a66625c8ecbc4cae

    Comments

    Proximity Auth: Remove kMultiDeviceApi flagging from ProximityMonitorImpl.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: I331612216739e82fb46d674aef5853b7777b7a7d
    Reviewed-on: https://chromium-review.googlesource.com/c/1325549
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606564}

    Changed files

    • chromeos/components/proximity_auth/proximity_monitor_impl.cc
    • chromeos/components/proximity_auth/proximity_monitor_impl.h
    • chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
    • chromeos/components/proximity_auth/unlock_manager_impl.cc
  31. Smart Lock: Remove unused Chrome app manifest.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Thursday, 08-Nov-18 19:24:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d98b722cb5b520317c9892b24845e1f9956ae1f

    Comments

    Smart Lock: Remove unused Chrome app manifest.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: I08eff200cd6d8eb2eaad989d0abcab7fc1f3d53f
    Reviewed-on: https://chromium-review.googlesource.com/c/1321030
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606563}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_factory.cc
    • chrome/browser/extensions/component_extensions_whitelist/whitelist.cc
    • chrome/browser/resources/easy_unlock/OWNERS
    • chrome/browser/resources/easy_unlock/manifest.json
    • chrome/browser/resources/easy_unlock/manifest_signin.json