Home | Search | chromium - Builders
Login

Builder Nougat Phone Tester Build 7654 Canonical Ubuntu

Results:

Failure chrome_public_test_vr_apk-ddready-ddview on Android device Pixel 1 XL

Trigger Info:

Projectchromium
Revision68550e484d7eecf6bd1d39fca300644ab2c21f5d
Got Revision68550e484d7eecf6bd1d39fca300644ab2c21f5d

Execution:

Steps and Logfiles:

Show:
  1. ( 321 ms ) setup_build
    running recipe: "chromium"
  2. ( 771 ms ) report builders
     
    running tester 'Nougat Phone Tester' on master 'chromium.android'
  3. ( 5 mins 42 secs ) bot_update
    [57GB/295GB used (19%)]
  4. ( 0 ) ensure_goma
  5. ( 2 secs ) swarming.py --version
    0.13
  6. ( 41 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 594 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  9. ( 17 secs ) clean local files
  10. ( 4 secs ) tree truth steps
  11. ( 486 ms ) build directory
  12. ( 1 secs ) find isolated tests
  13. ( 0 ) test_pre_run
  14. ( 14 mins 59 secs ) chrome_public_test_vr_apk-ddready-cardboard on Android device Pixel 1 XL
    Run on OS: 'Android'
    Shard duration: 0:14:42.383129
  15. ( 15 mins 42 secs ) chrome_public_test_vr_apk-ddready-ddview on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 12s
    Shard duration: 0:30:19.493558
  16. ( 2 secs ) chrome_public_test_vr_apk-ddready-dynamicsettings on Android device Pixel 1 XL
    Run on OS: 'Android'
    Pending time: 26s
    Shard duration: 0:05:05.545534
  17. ( 214 ms ) Tests statistics
     
    Stats
    Total shards: 3
    Total runtime: 0:49:11.803473
     
  18. ( 222 ms ) test_report

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm376-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539346731780293, "id": "8932871677335434672", "project": "chromium", "tags": ["builder:Nougat Phone Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/68550e484d7eecf6bd1d39fca300644ab2c21f5d", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm64 Builder (dbg)", "parent_buildnumber:33500", "scheduler_invocation_id:9098301739493534656", "scheduler_job_id:chromium/Nougat Phone Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Nougat Phone Tester" setup_build
buildnumber 7654 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm64 Builder (dbg)" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "68550e484d7eecf6bd1d39fca300644ab2c21f5d" setup_build
parent_got_revision_cp "refs/heads/master@{#599169}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25136}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "68550e484d7eecf6bd1d39fca300644ab2c21f5d" setup_build
swarm_hashes {"android_webview_unittests": "aabd509d4cfce3f14e23cdff1c46d9436a0d4c0a", "angle_unittests": "c73fed3294b96e57f26144e4d379bf605b7fc3b9", "base_unittests": "3a6f3eca310f94b116add10faadb6548b14bb329", "blink_common_unittests": "ca7cd3eca935f91925c15f98e90ef3a4a27e04f8", "blink_heap_unittests": "a5982553fe28def9679dea3b62cabfe312afa5e9", "blink_platform_unittests": "f758e22ad6f4362afbe2f8bcd539aa848c9e15aa", "boringssl_crypto_tests": "9cf50a8f5005b3ae19a5a9c361489fa24ff4bd64", "boringssl_ssl_tests": "5381865c8f9fdcfbb71e9c62070b0a84f67f66ab", "breakpad_unittests": "37885163ca35b465a7b45502515870eacbb418db", "cacheinvalidation_unittests": "9d62107acf8658b968126bf76e8705a5c84b2f0a", "capture_unittests": "a672eb294f83fe09c075a2e052d77f3b11b6f4ff", "cast_unittests": "0f0db257eb54d1c4af5b3787e9f5d65670613db8", "cc_unittests": "347809b7516c97b930eb3afae982f3587454dd46", "chrome_public_test_apk": "fa6521e0533b2000586b577c1637a1056f44c0cc", "chrome_public_test_vr_apk": "1202e8668390f49afbdac69ee21bc5f6e0be8489", "chrome_sync_shell_test_apk": "9192b806f952ffc0560b83c0eba417f43a655f03", "components_browsertests": "e8225366d279ca414782cef3e1bbb5fbf748ddbe", "components_unittests": "0985a9de683926b8e978d8dd478977f12ab0def9", "content_browsertests": "c830b324f31687d660fa11f8916527efe121d559", "content_shell_test_apk": "27d7b09397afba311a2635619f093b071b36abc1", "content_unittests": "28e1db3025e72221f0e43167ed8b32605854d976", "crypto_unittests": "474e1b771ea2a36bfc06369170bc6979da9076bd", "device_unittests": "b7a7ae9d67ffb8d66e84c6b54a73609c1a6ae508", "display_unittests": "ace8b6469a14b94956f88e8a8b3dc1f64facefaa", "events_unittests": "2394911c03850cdc95b1820209df4e3a5e8bbe51", "gcm_unit_tests": "e22a13ee9f4e65245d9a4f7996c8c50491e6b616", "gfx_unittests": "47e99b57a65183639cfee0c0755fd5b3eb5b6731", "gin_unittests": "1fda9c52ccdb7c32460a52e54b62793a9ddfced7", "gl_tests": "5530d6ab8b9552db78d299539e53defa63c53089", "gl_unittests": "2c79503b94336e299b80458ddcc2e18132bda149", "google_apis_unittests": "4e0b2af7e24a6b4baa6d9dd116ea252e1772ce98", "gpu_unittests": "f81838e75935002cbd7ad20bfc4785b28bcfcb90", "ipc_tests": "c3f1f5fafa98cefdd7ea0f1b31db9b1d04b45b9d", "jingle_unittests": "0e62dd5e5d41d08a553f219901f936307f0fe969", "latency_unittests": "80d2325e2ff31dd7172086d1aa7bec9c4a5feb0d", "libjingle_xmpp_unittests": "24f81aad4089b9f632a2564d2c273dbf6b5a4fb9", "media_blink_unittests": "a61e36e712656a8a8457693d7b9bafb5bec39e28", "media_service_unittests": "68ee6371f3f693b7bf0c87ae4f8a9089d2b7a7b9", "media_unittests": "99156b2f1db2603bb42ef7b0fbce2e3e1e3882de", "midi_unittests": "68e4d6b0eef832ba4729a653a1893bfddbc8b3b1", "mojo_test_apk": "6d8646017b732fb3ade3d3d7a97d9de34c275878", "mojo_unittests": "3939e94c585cad984a4029d28b7f2a0690ff02cc", "monochrome_public_test_ar_apk": "30b8bf43b8fd6db54164c0ba7e5c5158911b55fe", "net_unittests": "c0060152ca31db33bb67e3a64d311da0b2a29102", "sandbox_linux_unittests": "55ed03db1840e072d05031704cf5ea9c33390e23", "services_unittests": "0945167dbd0c271b7f116e2a3ce938bc6f5d7183", "shell_dialogs_unittests": "219ab9bd3f9f117f0a0097d589bf688127a8f5e3", "skia_unittests": "d06a57e80d695c94fc20956dfbe5d70ae99a2a4e", "sql_unittests": "e6d2b39786544157d9960e2bb2ee03db65b81a30", "storage_unittests": "075ac04f9f9ed3ac532f4d68075951cc65c088d5", "ui_android_unittests": "38dce2c937c7032b939a52d8dfc91c790d719d83", "ui_base_unittests": "cc69c62565f75b13c285c17a0a986e69fd30a961", "ui_touch_selection_unittests": "88238ef3f2c6be2d79d27a3a7c60e05b3b4a48ef", "unit_tests": "5d6827e526f399b4f1fa12f23b9a7542612d2a46", "url_unittests": "a5944cb1f440d1a34aa4d26d8af51b55461bc94b", "viz_unittests": "0568047fbe50f8d02a0f48475eabd9b97526472c", "vr_common_unittests": "4e37bf3ab034235a7224b569ba556362f3e08adf", "vr_pixeltests": "d945396c77c119c9ad48490f7a35059b7810afd5", "webkit_unit_tests": "72534aaeebd7b3f3a7bfa3fe1d63d6243a7c2fcb", "webview_instrumentation_test_apk": "4f309425235334b09b6b62ca482ba742d4cacf40", "wtf_unittests": "594eda3323ddc3c2e87c29a06a47226ebff60cc9"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "68550e484d7eecf6bd1d39fca300644ab2c21f5d" bot_update
got_revision_cp "refs/heads/master@{#599169}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  2. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  3. Scott Wu (scottwuohnoyoudont@chromium.org)
  4. Laís Minchillo (laisminchilloohnoyoudont@chromium.org)
  5. Scott Wu (scottwuohnoyoudont@chromium.org)
  6. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  7. Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
  8. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)
  10. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  11. Fan Yang (fayangohnoyoudont@chromium.org)
  12. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  13. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  14. vasilii (vasiliiohnoyoudont@chromium.org)
  15. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  16. Yuki Yamada (yukiyohnoyoudont@google.com)
  17. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  18. Peter E Conn (peconnohnoyoudont@chromium.org)
  19. Florent Castelli (orphisohnoyoudont@chromium.org)
  20. Mostyn Bramley-Moore (mostynbohnoyoudont@vewd.com)
  21. Olivier Robin (olivierrobinohnoyoudont@chromium.org)
  22. Leszek Swirski (leszeksohnoyoudont@chromium.org)
  23. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  24. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  25. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  26. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  27. Florent Castelli (orphisohnoyoudont@chromium.org)
  28. Fergal Daly (fergalohnoyoudont@chromium.org)
  29. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  30. A Olsen (olsenohnoyoudont@chromium.org)
  31. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  32. Roman Sorokin (rsorokinohnoyoudont@chromium.org)
  33. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  34. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  35. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  36. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  37. Yuta Kitamura (yutakohnoyoudont@chromium.org)
  38. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  39. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  40. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  41. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
  42. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  43. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)

Timing:

Create Friday, 12-Oct-18 12:18:51 UTC
Start Friday, 12-Oct-18 12:19:46 UTC
End Friday, 12-Oct-18 12:58:32 UTC
Pending 55 secs
Execution 38 mins 45 secs

All Changes:

  1. Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68550e484d7eecf6bd1d39fca300644ab2c21f5d

    Comments

    Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0
    
    Using wpt-import in Chromium afc97ac06f5d3677c1016d1530c1e196844e2432.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25973
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    binji@chromium.org:
      external/wpt/wasm
    jsbell@chromium.org:
      external/wpt/resources
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I02e2714a05f60a13999e2efa76ad5039324ed566
    Reviewed-on: https://chromium-review.googlesource.com/c/1278537
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599169}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/dom/interfaces_exclude=Node-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/resources/idlharness.js
    • third_party/WebKit/LayoutTests/external/wpt/shape-detection/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/resources/load_wasm.js
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  2. Reland "Remove IDC_SHOW_SYNC_SETUP"

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:48:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 290bc882fa0022afd17118d11949266c86fa631b

    Comments

    Reland "Remove IDC_SHOW_SYNC_SETUP"
    
    This reverts commit 2ec520568c51bcd167a1ed24baa3a6f45023f02b.
    
    Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL.
    
    Original change's description:
    > Revert "Remove IDC_SHOW_SYNC_SETUP"
    > 
    > This reverts commit eafee2dc30fa6fdb34e07c664fd858a361cb5424.
    > 
    > Reason for revert: Still needed for http://crbug.com/888776
    > 
    > Original change's description:
    > > Remove IDC_SHOW_SYNC_SETUP
    > > 
    > > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This
    > > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up
    > > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP
    > > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing.
    > > 
    > > Bug: 870239
    > > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402
    > > Reviewed-on: https://chromium-review.googlesource.com/1236263
    > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > > Reviewed-by: Scott Violet <sky@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#593138}
    > 
    > TBR=sky@chromium.org,msarda@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 870239
    > Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338
    > Reviewed-on: https://chromium-review.googlesource.com/1245381
    > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#594261}
    
    TBR=sky@chromium.org,msarda@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 870239
    Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278745
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599168}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/browser/ui/browser_command_controller.cc
    • chrome/browser/ui/browser_command_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
  3. Rename PasswordControllerHelper to PasswordFormHelper

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:44:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 830919bab9ae548252386c0e0b2bb97b4a22152e

    Comments

    Rename PasswordControllerHelper to PasswordFormHelper
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
    Reviewed-on: https://chromium-review.googlesource.com/c/1278670
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599167}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_form_helper.h
    • components/password_manager/ios/password_form_helper.mm
    • components/password_manager/ios/password_form_helper_unittest.mm
    • components/password_manager/ios/password_suggestion_helper.h
    • ios/chrome/browser/passwords/password_controller.h
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/chrome/browser/passwords/password_controller_unittest.mm
    • ios/web_view/internal/passwords/cwv_password_controller.mm
  4. [aw] Add callback to proxy override methods

    Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2dd9b16afe9c2808aaa11566aa54fa854282db2

    Comments

    [aw] Add callback to proxy override methods
    
    Add an optional callback to proxy override methods introduced in change
    https://chromium-review.googlesource.com/c/chromium/src/+/1148384
    
    This adds an optional callback developers can use to know when the
    changes have been made to the network settings, since the methods are
    not synchronous with the UI thread.
    
    Bug: 851995
    Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
    Reviewed-on: https://chromium-review.googlesource.com/c/1258770
    Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599166}

    Changed files

    • android_webview/browser/aw_contents_statics.cc
    • android_webview/browser/net/aw_url_request_context_getter.cc
    • android_webview/browser/net/aw_url_request_context_getter.h
    • android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
    • android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
    • android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
    • net/proxy_resolution/proxy_config_service_android.cc
    • net/proxy_resolution/proxy_config_service_android.h
    • net/proxy_resolution/proxy_config_service_android_unittest.cc
  5. Move password suggestion logic into components.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9a4429e3b49acb3be07a11697d3d9680f08e616

    Comments

    Move password suggestion logic into components.
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1264455
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599165}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_suggestion_helper.h
    • components/password_manager/ios/password_suggestion_helper.mm
    • ios/chrome/browser/passwords/password_controller.mm
  6. [css-properties-values-api] Multi-value StylePropertyMap.set.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d84303e41153ea9cb0f6475b6bb9e430666022a2

    Comments

    [css-properties-values-api] Multi-value StylePropertyMap.set.
    
    This adds support for setting multiple values with TypedOM for list-valued
    custom properties. For example, for a property --x with syntax <length>+,
    it will now be possible to do:
    
      element.attributeStyleMap.set('--x', CSS.px(1), CSS.px(2));
    
    This is done by producing a CSSVariableReferenceValue holding tokens
    equivalent to the incoming CSSStyleValues, provided that those values
    match the grammar of the custom property.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: Ic28497edbbea894a9c09b840dcb6c8fb825d99bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1270963
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599164}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/css_syntax_descriptor.h
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
  7. [Autofill Assistant] Make various improvements to the UI.

    Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 10:29:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e83ced5f800af6a60da52d8a183776b002c7b54

    Comments

    [Autofill Assistant] Make various improvements to the UI.
    
    Screenshot before: https://screenshot.googleplex.com/5zbTV7W40Rh.png
    Screenshot after: https://screenshot.googleplex.com/59OsupD4J5o.png
    
    Binary-Size: Increase is due to adding new bottom bar background.
    Bug: 806868
    Change-Id: Ie6863f6922eca210f3e823c22318cd6bd323be81
    Reviewed-on: https://chromium-review.googlesource.com/c/1273518
    Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599163}

    Changed files

    • chrome/android/BUILD.gn
    • chrome/android/java/res_autofill_assistant/drawable-hdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-mdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_normal.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_pressed.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_chip.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/res_autofill_assistant/values-v17/styles.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
  8. Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 10:26:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31904c2ab872bb48841916acaa8dd9fad167589e

    Comments

    Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2727ef6f5dc..03ec3c699be2
    
    
    git log e2727ef6f5dc..03ec3c699be2 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 vapier@chromium.org cros_portage_upgrade_unittest: convert to mock
    2018-10-12 vapier@chromium.org gsutil: add wrapper script for our pinned version
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@03ec3c699be2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I9f381f438b01450da63805d85cec801baa22ec4d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278706
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599162}

    Changed files

    • DEPS
  9. [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.

    Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61701cc0ee389e0dae437516d9b8edad2f874b18

    Comments

    [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.
    
    Now that the scroll proxy's contentInset is not guaranteed to be zero,
    we need to check against the contentInset instead of CGPointZero.
    
    Bug: 894617
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I5ba5131c969a4584879be905a92f0736a34d7f46
    Reviewed-on: https://chromium-review.googlesource.com/c/1277674
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599161}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
  10. Roll src-internal 7781cb9daa22..f37e9866851d (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 10:10:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 042ad90ac5334bd95efe24e495bdf3274930305e

    Comments

    Roll src-internal 7781cb9daa22..f37e9866851d (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7781cb9daa22..f37e9866851d
    
    
    Created with:
      gclient setdep -r src-internal@f37e9866851d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I1d534c0a85bbd4bb0af445e93060dbd898251de6
    Reviewed-on: https://chromium-review.googlesource.com/c/1278707
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599160}

    Changed files

    • DEPS
  11. Drop Dynamic from CreateIncomingDynamicStream, ShouldCreateIncomingDynamicStream and ShouldCreateOutgoingDynamicStream.

    Changed by Fan Yang - fayangohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:05:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a3bddfbdef537e0ec1eca74bef7fa64596ae5dd

    Comments

    Drop Dynamic from CreateIncomingDynamicStream, ShouldCreateIncomingDynamicStream and ShouldCreateOutgoingDynamicStream.
    
    Merge internal change: 214983203
    
    R=rch@chromium.org
    
    Change-Id: Iacfc81d8ed6e4a8931aab9fcc52ce8d847bd0e06
    Reviewed-on: https://chromium-review.googlesource.com/c/1276445
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Commit-Queue: Fan Yang <fayang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599159}

    Changed files

    • net/quic/quic_chromium_client_session.cc
    • net/quic/quic_chromium_client_session.h
    • net/quic/quic_chromium_client_session_peer.cc
    • net/quic/quic_chromium_client_session_peer.h
    • net/quic/quic_chromium_client_session_test.cc
    • net/quic/quic_chromium_client_stream_test.cc
    • net/third_party/quic/core/http/quic_server_session_base.cc
    • net/third_party/quic/core/http/quic_server_session_base.h
    • net/third_party/quic/core/http/quic_server_session_base_test.cc
    • net/third_party/quic/core/http/quic_spdy_client_session.cc
    • net/third_party/quic/core/http/quic_spdy_client_session.h
    • net/third_party/quic/core/http/quic_spdy_client_session_test.cc
    • net/third_party/quic/core/http/quic_spdy_session.h
    • net/third_party/quic/core/http/quic_spdy_session_test.cc
    • net/third_party/quic/core/quic_dispatcher_test.cc
    • net/third_party/quic/core/quic_session.cc
    • net/third_party/quic/core/quic_session.h
    • net/third_party/quic/core/quic_session_test.cc
    • net/third_party/quic/quartc/quartc_session.cc
    • net/third_party/quic/quartc/quartc_session.h
    • net/third_party/quic/quartc/quartc_stream_test.cc
    • net/third_party/quic/test_tools/quic_test_server.cc
    • net/third_party/quic/test_tools/quic_test_utils.h
    • net/third_party/quic/tools/quic_simple_server_session.cc
    • net/third_party/quic/tools/quic_simple_server_session.h
    • net/third_party/quic/tools/quic_simple_server_session_test.cc
    • net/third_party/quic/tools/quic_simple_server_stream_test.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc
    • third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.h
  12. media/gpu/VEA unittest: Enable VEAs to test with any yuv format stream

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:04:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd7080ae434cf6f6b7a0e388b466ae7c7b6dbee1

    Comments

    media/gpu/VEA unittest: Enable VEAs to test with any yuv format stream
    
    VEA unittest is only able to test I420 format input file.
    This enables it to test any yuv format stream.
    
    NV12, NV12 and YV21 formated raw videos are created by following commands.
    $ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt nv12 bear_320x192_40frames.nv12.yuv
    $ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt nv21 bear_320x192_40frames.nv21.yuv
    $ ffmpeg -s 320x192 -i bear_320x192_40frames.yuv -pix_fmt yuv420p -vf shuffleplanes=0:2:1 bear_320x192_40frames.yv12.yuv
    
    BUG=chromium:894381
    TEST=[kevin] ./video_encode_accelerator_unittest --test_stream_data=bear_320x192_40frames.nv12.yuv:320:192:1:bear.out:200000:30:::6 --ozone-platform=gbm
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I8a6b142671fc0532ba872f7eff966d43a2848ad9
    Reviewed-on: https://chromium-review.googlesource.com/c/1135106
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
    Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599158}

    Changed files

    • media/gpu/video_encode_accelerator_unittest.cc
    • media/test/data/README.md
    • media/test/data/bear_320x192_40frames.nv12.yuv
    • media/test/data/bear_320x192_40frames.nv21.yuv
    • media/test/data/bear_320x192_40frames.yv12.yuv
  13. Fix radio button bug on sync_page.html

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:04:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b00f3499c1dc74c8e0419384a69f041ebcd2442

    Comments

    Fix radio button bug on sync_page.html
    
    The second radio button in the passphrase section
    was not visibly checked on selection.
    
    To solve this, move the spans containing the conditional
    strings inside one radio-button, instead off having two
    conditional radio buttons.
    
    Additional change:
     - Remove aria-label attribute because the visible text
       is used automatically as radio button title.
    
    Bug: 894385
    Change-Id: Ie339def905ca976444880166552ba580068b9271
    Reviewed-on: https://chromium-review.googlesource.com/c/1276645
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599157}

    Changed files

    • chrome/browser/resources/settings/people_page/sync_page.html
  14. Rename the iVars in confirm_infobar_view.mm to match the style guide.

    Changed by vasilii - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:00:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6016fba9fe8d6a5a7d2b13de035b34eb16d303

    Comments

    Rename the iVars in confirm_infobar_view.mm to match the style guide.
    
    It's a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1270922
    
    Bug: 890336
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Iea3b7be1d588cdcdbdded5409927e18c069812b4
    Reviewed-on: https://chromium-review.googlesource.com/c/1277287
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599156}

    Changed files

    • ios/chrome/browser/ui/infobars/confirm_infobar_view.mm
  15. [iOS] Add SwitchToTab button to the omnibox popup

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:59:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2cc06f195b610cbe4aef0645fd96ddc29b2ab72a

    Comments

    [iOS] Add SwitchToTab button to the omnibox popup
    
    This CL adds the SwitchToTab image and handling to the omnibox popup
    row. It allows to switch easily to an opened tab based on omnibox
    suggestions.
    
    Bug: 893121
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ib440267802c1210ea416066c679a2ff4e963fbb6
    Reviewed-on: https://chromium-review.googlesource.com/c/1268344
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599155}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/browser_view_controller_unittest.mm
    • ios/chrome/browser/ui/commands/browser_commands.h
    • ios/chrome/browser/ui/omnibox/autocomplete_result_consumer.h
    • ios/chrome/browser/ui/omnibox/popup/BUILD.gn
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.h
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_mediator.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.h
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_row.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm
    • ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller_unittest.mm
    • ios/chrome/browser/ui/omnibox/popup/resources/BUILD.gn
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/Contents.json
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match.png
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match@2x.png
    • ios/chrome/browser/ui/omnibox/popup/resources/omnibox_popup_tab_match.imageset/omnibox_popup_tab_match@3x.png
  16. Added security check for cross origin

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 09:45:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d2509fc2ebc7c9848726c1b208483e1e1efc485

    Comments

    Added security check for cross origin
    
    This CL adds a security check for cross origin with
    BindingSecurity::ShouldAllowAccessToCreationContext().
    |js_event|, a V8 wrapper object for event object, must be created in the
    relevant realm of the event target, but it is possible that listener's
    relevant context cannnot access the relevant realm of event target
    (ex. when Document.origin is changed).
    We have to check this before invoking event listener.
    
    Bug: 872138, 884516
    Change-Id: Ic5d0c8e6cda4db57a2097ce230e75cc59905b350
    Reviewed-on: https://chromium-review.googlesource.com/c/1270300
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599154}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  17. [iOS] Support Dynamic Type for ReadingList empty string

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:41:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe100b299e7bc889ccafc03cf8854efe64020679

    Comments

    [iOS] Support Dynamic Type for ReadingList empty string
    
    This CL changes the string displayed when the ReadingList is empty so
    it doesn't overflow below the bottom and top toolbar when the font is
    too big. It does that by limiting the font size.
    
    Bug: 893535
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I03335f2c1fee192a765b6e85011627c0f5ae2019
    Reviewed-on: https://chromium-review.googlesource.com/c/1276925
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599153}

    Changed files

    • ios/chrome/browser/ui/reading_list/empty_reading_list_message_util.mm
    • ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
  18. 🛃 Protect against disk read in queryIntentActivities

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:29:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5275c3572a1a4f0255f17e3c50d20465922cfd1e

    Comments

    🛃 Protect against disk read in queryIntentActivities
    
    Bug: 894160
    Change-Id: Idd2daa239adee9245690aaa8ae258437bf16c41f
    Reviewed-on: https://chromium-review.googlesource.com/c/1275431
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599152}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
  19. Mark virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction.html as failing

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:14:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 944dd0e6749ab63a23d50ddce1fae3ad610c47f3

    Comments

    Mark virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction.html as failing
    
    TBR=mstensho@chromium.org
    
    Bug: 635619
    Change-Id: I6dee9c7fd68b317c816216f3a8c521501acce255
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/1278785
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599151}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  20. [jumbo] fixup after recent headless network service work

    Changed by Mostyn Bramley-Moore - mostynbohnoyoudont@vewd.com
    Changed at Friday, 12-Oct-18 09:11:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed8c927801fdf271cff29cb95a46546cef0a9239

    Comments

    [jumbo] fixup after recent headless network service work
    
    Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1263566
    which introduced a namespace clash between ::network and ::headless::network.
    
    Also, rename one of two kProductName's.
    
    TBR=caseq@chromium.org
    
    Bug: 838291,792676
    Change-Id: Ie1fc9ab2096a09651ba2dd45aa262ab30bfd3efc
    Reviewed-on: https://chromium-review.googlesource.com/c/1277992
    Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
    Reviewed-by: Daniel Bratell <bratell@opera.com>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599150}

    Changed files

    • headless/lib/browser/headless_request_context_manager.cc
    • headless/public/headless_browser.cc
  21. Stop observing prefs in MainController on Shutdown

    Changed by Olivier Robin - olivierrobinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:04:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ef542ab7a3cb7a63148fc8bf922e9b0cb3a7dc3

    Comments

    Stop observing prefs in MainController on Shutdown
    
    Bug: 893486
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Iba70383fe0993c7c921a118197197497c1d42572
    Reviewed-on: https://chromium-review.googlesource.com/c/1270899
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Peter Lee <pkl@chromium.org>
    Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599149}

    Changed files

    • ios/chrome/app/main_controller.mm
  22. [blink] Control ScriptStreamer with ScriptResource

    Changed by Leszek Swirski - leszeksohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 09:03:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bd9163502462762e58d8010577dbf36aeef6c13

    Comments

    [blink] Control ScriptStreamer with ScriptResource
    
    Move the ScriptStreamer control logic from ClassicPendingScript to
    ScriptResource. In the future, this will allow us to start streaming
    a ScriptResource before the ClassicPendingScript is available, e.g on
    preload.
    
    The ClassicPendingScript now only sends one "finished" callback, from
    ScriptResource. This callback is either when the streaming completes,
    or when there is no streaming and the ClassicPendingScript has told
    the ScriptResource that it doesn't intend to start streaming. In the
    long run, we want all scripts to go through the streaming interface,
    and we want ScriptResource to control when streaming starts, so the
    "no more streaming" call will disappear -- however it is necessary to
    maintain the current behaviour, and be able to control it with a
    runtime flag.
    
    Bug: chromium:865098
    Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599148}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  23. Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 08:52:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae1d881f2c19438f9bf1efad82eaaaa11980b30f

    Comments

    Roll src/third_party/webrtc a54daf162fac..28d200c24624 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/a54daf162fac..28d200c24624
    
    
    git log a54daf162fac..28d200c24624 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 37b6d53f02..d47784f23e (598967:599082)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@28d200c24624
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I6547afd3d833e047bb877b0bece2206b5c8661ec
    Reviewed-on: https://chromium-review.googlesource.com/c/1278304
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599147}

    Changed files

    • DEPS
  24. Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:49:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 30958ae060dbfee80d985b84caa9e3c5f4d9c4cc

    Comments

    Chrome OS: move DiscoverManager ownership to ChromeBrowserMainPartsChromeos.
    
    TBR=sky@chromium.org
    
    Bug: 828999
    Change-Id: I46514f21581ab6d30e1c4b38719b66e43b075f42
    Reviewed-on: https://chromium-review.googlesource.com/c/1278129
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599146}

    Changed files

    • chrome/browser/browser_process_platform_part_chromeos.cc
    • chrome/browser/browser_process_platform_part_chromeos.h
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
  25. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  26. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  27. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  28. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h
  29. Chrome OS Powerwash screen: update icon and illustration.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afc97ac06f5d3677c1016d1530c1e196844e2432

    Comments

    Chrome OS Powerwash screen: update icon and illustration.
    
    
    Bug: 894280
    Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1278211
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599141}

    Changed files

    • chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
    • chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
    • chrome/browser/resources/chromeos/login/oobe_reset.css
    • chrome/browser/resources/chromeos/login/oobe_reset.html
  30. Move InstallAttributes to chromeos/settings

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6c62dce936e966e2db445045dd04414553642b

    Comments

    Move InstallAttributes to chromeos/settings
    
    Necessary for moving CrosSettings to chromeos/settings, so it
    can eventually be used by Mustash.
    
    The following changes were necessary:
    1. Move install_attributes{.h, .cc} and unit_test.cc
    2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    (destination)
    3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    which is included by install_attributes.h
    
    4. Unfortunately, that same dependency lead to a circular dependency.
    I was able to avoid that by separating out a "common_constants" rule in
    components/policy/core/common, so that chromeos/settings only depends on
    that, and not on all of components/policy. So I had to change
    components/policy/core/common/BUILD.gn
    and I removed an unnecessary include from
    components/policy/core/common/cloud/cloud_policy_constants.cc
    
    5. Update #include directives for install_attributes to point to new
    location. This is the other 22 files, all with diffs of +1 -1.
    
    Bug: 446937
    Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599140}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • chromeos/settings/install_attributes.cc
    • chromeos/settings/install_attributes.h
    • chromeos/settings/install_attributes_unittest.cc
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  31. Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0

    Comments

    Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
    
    Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hongchan@chromium.org, rtoy@chromium.org:
      external/wpt/webaudio
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02
    Reviewed-on: https://chromium-review.googlesource.com/c/1278059
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599139}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html
  32. Override stub path before PreEarlyInitDBus

    Changed by Roman Sorokin - rsorokinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:10:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b80ea1c80ef7c8ec439c14def8120498fc35eda8

    Comments

    Override stub path before PreEarlyInitDBus
    
    Otherwise install attributes are not loaded on the linux Chrome OS
    build.
    
    TEST=manual
    
    Bug: 848615, 729596
    Change-Id: I445b2b337b707822459c076058610f49f02767ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1264643
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599138}

    Changed files

    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/metrics/chrome_feature_list_creator.cc
  33. Chrome OS: Integrate Discover PIN setup into First run UI.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a

    Comments

    Chrome OS: Integrate Discover PIN setup into First run UI.
    
    Bug: 852553
    Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
    Reviewed-on: https://chromium-review.googlesource.com/c/1250136
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599137}

    Changed files

    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
    • chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/wizard_controller.cc
    • chrome/browser/chromeos/login/wizard_controller.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
  34. Fix naming issue when renaming files inside My files

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:02:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40a6cb9be79a8d05395498a705e59d50cbb77f57

    Comments

    Fix naming issue when renaming files inside My files
    
    Change DirectoryModel to "unwrap" VolumeEntry when it's selected via
    file list. This fixes the issue where after selecting a VolumeEntry any
    operation in the private API would fail because it wouldn't be able to
    send a VolumeEntry to private API, because it requires a real Entry.
    
    This fixes the user issue of trying to rename and always getting "Use
    shorter name" error, even with a short name.
    
    Update FakeEntry to be an implementation of FilesAppDirEntry, since all
    users were using as directory, also update some functions to typing to
    use FilesAppDirEntry instead of FakeEntry which is more correct.
    
    Test: browser_tests --gtest_filter="*/myFilesFolderRename"
    Bug: 889636
    Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1276067
    Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599136}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/file_manager/background/js/volume_info_impl.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
    • ui/file_manager/file_manager/foreground/js/file_watcher.js
    • ui/file_manager/integration_tests/file_manager/my_files.js
  35. media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:54:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 029544dab67d79059b7610a92890091520ef7603

    Comments

    media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
    
    libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make
    it return 0 planes for single-plane multiplanar formats. We obviously
    cannot have a multiplanar format with 0 planes, so add a workaround at
    the fake-ioctl level. Implement it as a case-switch for future-proofing
    against other workarounds we will likely have to add.
    
    Also add a few recommendations in v4l2_device.cc against the temptation
    to spare some memory by using an appropriately-sized array of
    v4l2_planes: it turns out libv4l2 also likes to write above the number
    of passed planes, and using anything shorter than VIDEO_MAX_PLANES will
    result in memory corruption DCHECKS being raised.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on both hana and nyan_big.
    
    Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225
    Reviewed-on: https://chromium-review.googlesource.com/c/1275727
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599135}

    Changed files

    • media/gpu/v4l2/tegra_v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.cc
  36. Add browser tests for when we show the cookie exception

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:53:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df554d02051d43d493d30cdf39fb1ee7566355bf

    Comments

    Add browser tests for when we show the cookie exception
    
    Depending on the sync / sign-in state.
    
    BUG=890925
    R=tangltom@chromium.org, msarda@chromium.org
    
    Change-Id: I784f13a4981250f851df770d111a13969a6892a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1273521
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599134}

    Changed files

    • chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
    • chrome/test/BUILD.gn
  37. Move thread-related functionalities in Platform to Thread.

    Changed by Yuta Kitamura - yutakohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:47:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9deeac4682dc2c2a45fdf483c376c75011a09241

    Comments

    Move thread-related functionalities in Platform to Thread.
    
    This CL moves the most of implementation for Thread in Platform to
    Thread, so the Platform would contain less implementation (ideally,
    Platform should be a pure interface to embedders).
    
    Previously the global state of threads was stored in Platform, and
    this CL moves it to Thread. Now the thread-local storage for Blink
    threads and the main and compositor thread objects are stored as
    the global variable in thread.cc. This way, the threads state is
    completely separated from Platform. Old threading functions in
    Platform are deprecated now, and they will be migrated to Thread ones
    later.
    
    Due to those changes, some test utilities need to be updated. As the
    state of threads is not stored in Platform, the tests that need to
    override their main thread have to do that by themselves. To
    facilitate this, two new utility classes, ScopedMainThreadOverrider
    and ScopedSchedulerOverrider, are introduced, and TestingPlatform-
    SupportWithCustomScheduler is removed in favor of the new utilities.
    
    Bug: 826203
    Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058
    Reviewed-on: https://chromium-review.googlesource.com/c/1273115
    Commit-Queue: Yuta Kitamura <yutak@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599133}

    Changed files

    • content/renderer/render_thread_impl.cc
    • third_party/blink/public/platform/platform.h
    • third_party/blink/renderer/core/dom/idle_deadline_test.cc
    • third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/exported/platform.cc
    • third_party/blink/renderer/platform/scheduler/common/thread.cc
    • third_party/blink/renderer/platform/scheduler/public/thread.h
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.h
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.h
    • third_party/blink/renderer/platform/testing/testing_platform_support.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
  38. Let ClientControlledState apply animation during bounds change.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 07:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68084907a40caccccb72dd14c0ad3139b97747f7

    Comments

    Let ClientControlledState apply animation during bounds change.
    
    This CL introduces a new BoundsChangeAnimationType for
    ClientControlledState which will animate the window bounds for a
    specified duration.
    
    Bug: b/115291749
    Bug: 841886
    Test: Tested with local PIP prototype - applies animation.
    Change-Id: I8eda8b2131b8d3f679ade5cfbe64d7378efd6881
    Reviewed-on: https://chromium-review.googlesource.com/c/1218385
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599132}

    Changed files

    • ash/wm/client_controlled_state.cc
    • ash/wm/client_controlled_state.h
    • ash/wm/client_controlled_state_unittest.cc
    • ash/wm/default_state.cc
    • ash/wm/window_state.cc
    • ash/wm/window_state.h
    • ash/wm/wm_event.cc
    • ash/wm/wm_event.h
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  39. [iOS] Remove ReadingList empty view

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:44:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a53cbb1cdf96e0695e4d24cd408b52cc826d5088

    Comments

    [iOS] Remove ReadingList empty view
    
    This view was used in the old ReadingList implementation.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Id4fa1df5a00f0dd572a2d4951764f422231e3874
    Reviewed-on: https://chromium-review.googlesource.com/c/1276966
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599131}

    Changed files

    • ios/chrome/browser/ui/reading_list/BUILD.gn
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.h
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.mm
    • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
  40. Chrome OS: Integrate PIN setup into Discover UI

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:43:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f479db8f992be027ddc9b715919df65ad4e40bb6

    Comments

    Chrome OS: Integrate PIN setup into Discover UI
    
    Bug: 852553
    Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1249496
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599130}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/resources/chromeos/login/discover/discover_app.html
    • chrome/browser/resources/chromeos/login/discover/discover_app.js
    • chrome/browser/resources/chromeos/login/discover/discover_components.html
    • chrome/browser/resources/chromeos/login/discover/discover_components.js
    • chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
    • chrome/browser/resources/chromeos/login/discover/discover_ui.html
    • chrome/browser/resources/chromeos/login/discover/discover_ui.js
    • chrome/browser/resources/chromeos/login/discover/discover_welcome.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/screen_discover.html
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
    • chrome/common/extensions/api/_api_features.json
  41. Change cpp.tmpl files to cc.tmpl

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Friday, 12-Oct-18 07:35:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07c46624768cb8f779f4c872aa5951d3cb7d7920

    Comments

    Change cpp.tmpl files to cc.tmpl
    
    Formats of C++ template files are mixed up with cpp.tmpl and cc.tmpl.
    Unify C++ template files to cc.tmpl
    
    Bug: 894684
    Change-Id: I4f7413f29809bcd3262a20c7f40a23e63ba45d3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278567
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#599129}

    Changed files

    • third_party/blink/renderer/bindings/scripts/code_generator_v8.py
    • third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py
    • third_party/blink/renderer/bindings/templates/attributes.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_function.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_invoke.cc.tmpl
    • third_party/blink/renderer/bindings/templates/constants.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.h.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl_common.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_v8.cc.tmpl
    • third_party/blink/renderer/bindings/templates/external_reference_table.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface_base.cc.tmpl
    • third_party/blink/renderer/bindings/templates/methods.cc.tmpl
    • third_party/blink/renderer/bindings/templates/partial_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/templates.gni
    • third_party/blink/renderer/bindings/templates/union_container.cc.tmpl
    • third_party/blink/renderer/bindings/templates/utilities.cc.tmpl
    • third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
    • third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
    • third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
    • third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
    • third_party/blink/renderer/core/css/css_primitive_value.h
  42. CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:33:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 836e5cd90af24fa6af71e4e633d1c0fb41ca0765

    Comments

    CrOS FilesApp: Add Manage Linux sharing top menu link to settings page
    
    Shown when crostini and flag crostini-files are enabled.
    Links to chrome://settings/crostini/crostiniShared.
    Record UMA for clicks.
    
    Bug: 878324
    Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
    Reviewed-on: https://chromium-review.googlesource.com/c/1277130
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599128}

    Changed files

    • chrome/app/file_manager_strings.grdp
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
    • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
    • tools/metrics/histograms/enums.xml
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/main.html
    • ui/file_manager/file_manager/test/crostini_share.js
  43. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 07:17:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS