Home | Search | chromium - Builders
Login

Builder Marshmallow Tablet Tester Build 741 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision75c9e38bcfe01f3a7c2637050ddcb2f342dd3034
Got Revision75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

Execution:

Steps and Logfiles:

Show:
  1. ( 307 ms ) setup_build
    running recipe: "chromium"
  2. ( 6 secs ) remove .cipd
  3. ( 3 mins 46 secs ) bot_update
    [81GB/295GB used (27%)]
  4. ( 0 ) ensure_goma
  5. ( 1 secs ) swarming.py --version
    0.13
  6. ( 37 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 15 secs ) clean local files
  9. ( 650 ms ) tree truth steps
  10. ( 1 secs ) build directory
  11. ( 8 mins 56 secs ) extract build
  12. ( 1 secs ) find isolated tests
  13. ( 0 ) test_pre_run
  14. ( 42 secs ) android_webview_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:17.304800
  15. ( 6 secs ) angle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:06:55.855790
  16. ( 4 secs ) base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:06:25.410290
  17. ( 2 secs ) blink_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:00.810270
  18. ( 2 secs ) blink_heap_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:38.432940
  19. ( 1 mins 28 secs ) blink_platform_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 10s
    Shard duration: 0:04:12.117560
  20. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:32.193650
  21. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:10.479670
  22. ( 2 secs ) breakpad_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 35s
  23. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 50s
  24. ( 2 secs ) capture_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 12s
    Shard duration: 0:01:28.566320
  25. ( 2 secs ) cast_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 35s
    Shard duration: 0:01:25.801580
  26. ( 1 mins 54 secs ) cc_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 38s
    Shard duration: 0:05:58.708240
  27. ( 43 mins 53 secs ) chrome_public_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:35:05.526020 (shard #19)
    Max shard duration: 0:16:52.464680 (shard #6)
    Min shard duration: 0:11:44.136220 (shard #19)
  28. ( 1 mins 5 secs ) chrome_sync_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:41:42.177770
    Shard duration: 0:09:57.516200
  29. ( 2 secs ) components_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:45:03.438060
    Shard duration: 0:05:00.384280
  30. ( 16 mins 7 secs ) components_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:47:19.041070 (shard #1)
    Max shard duration: 0:20:11.736240 (shard #1)
    Min shard duration: 0:17:30.144390 (shard #0)
  31. ( 17 mins 33 secs ) content_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:04:03.035490 (shard #5)
    Max shard duration: 0:26:25.562790 (shard #1)
    Min shard duration: 0:19:01.722410 (shard #2)
  32. ( 3 mins 35 secs ) content_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:10:05.245620 (shard #1)
    Max shard duration: 0:18:35.430500 (shard #1)
    Min shard duration: 0:18:22.734870 (shard #0)
  33. ( 6 secs ) content_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:15:32.803390 (shard #2)
    Max shard duration: 0:08:04.953770 (shard #2)
    Min shard duration: 0:06:12.949980 (shard #1)
  34. ( 2 secs ) crypto_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:11.015550
  35. ( 2 secs ) device_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:16:02.956900
    Shard duration: 0:01:55.755890
  36. ( 2 secs ) display_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:05.266550
  37. ( 2 secs ) events_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:18:45.741970
    Shard duration: 0:01:14.487990
  38. ( 2 secs ) gcm_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:23.173990
  39. ( 5 secs ) gfx_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:04:50.620370
  40. ( 2 secs ) gin_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:15.482040
  41. ( 2 secs ) gl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:18:57.462330
    Shard duration: 0:01:30.415020
  42. ( 2 secs ) gl_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 56s
  43. ( 2 secs ) google_apis_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:21.631340
  44. ( 4 secs ) gpu_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:05:44.120550
  45. ( 2 secs ) ipc_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:00.907340
  46. ( 2 secs ) jingle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:25.432230
  47. ( 2 secs ) latency_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:05.417250
  48. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:12.690880
  49. ( 4 secs ) media_blink_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:18:47.990970
    Shard duration: 0:03:30.068370
  50. ( 2 secs ) media_service_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:20:15.416090
    Shard duration: 0:01:23.005840
  51. ( 1 mins 11 secs ) media_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:20:54.869460
    Shard duration: 0:10:18.843560
  52. ( 2 secs ) midi_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 58s
  53. ( 2 secs ) mojo_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:59.114590
  54. ( 2 secs ) mojo_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:10.829220
  55. ( 28 secs ) net_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max shard duration: 0:18:25.693290 (shard #0)
    Min shard duration: 0:17:02.162380 (shard #2)
  56. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 29s
  57. ( 3 secs ) services_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:22:02.820990
    Shard duration: 0:04:07.880980
  58. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:23:16.927620
    Shard duration: 0:01:11.011710
  59. ( 2 secs ) skia_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:23:41.370850
    Shard duration: 0:01:08.964650
  60. ( 2 secs ) sql_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:02.376490
  61. ( 2 secs ) storage_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:25:05.468840
    Shard duration: 0:02:13.410760
  62. ( 2 secs ) ui_android_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:25:17.116260
    Shard duration: 0:01:19.383180
  63. ( 2 secs ) ui_base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:21.894160
  64. ( 3 secs ) ui_touch_selection_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 58s
  65. ( 9 mins 24 secs ) unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:26:37.579120 (shard #1)
    Max shard duration: 0:16:42.347940 (shard #0)
    Min shard duration: 0:11:27.088210 (shard #1)
  66. ( 2 secs ) url_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:18.324140
  67. ( 3 secs ) viz_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:26:39.327240
    Shard duration: 0:01:51.288890
  68. ( 2 secs ) vr_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:27:36.460300
    Shard duration: 0:02:15.397840
  69. ( 2 secs ) vr_pixeltests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:27:44.566040
    Shard duration: 0:02:03.516610
  70. ( 13 mins 8 secs ) webkit_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 1:28:36.587880
    Shard duration: 0:26:36.406010
  71. ( 3 mins 45 secs ) webview_instrumentation_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:44:18.009220 (shard #5)
    Max shard duration: 0:19:18.546390 (shard #1)
    Min shard duration: 0:14:27.921870 (shard #3)
  72. ( 2 secs ) wtf_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:15.917460
  73. ( 373 ms ) Tests statistics
     
    Stats
    Total shards: 95
    Total runtime: 13:25:18.087597
     
  74. ( 774 ms ) test_report
  75. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm100-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531392497964180, "id": "8941212296012814896", "project": "chromium", "tags": ["builder:Marshmallow Tablet Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/75c9e38bcfe01f3a7c2637050ddcb2f342dd3034", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:36190", "scheduler_invocation_id:9106642358349185168", "scheduler_job_id:chromium/Marshmallow Tablet Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Marshmallow Tablet Tester" setup_build
buildnumber 741 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" setup_build
parent_got_revision_cp "refs/heads/master@{#574507}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "75c9e38bcfe01f3a7c2637050ddcb2f342dd3034" bot_update
got_revision_cp "refs/heads/master@{#574507}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23944}" bot_update
swarm_hashes {"android_webview_unittests": "b915bccf27e827cd8e1d02565b0522012c4b3196", "angle_unittests": "e853ca169c1c1783b8fb35cef224c33e1ca0acc8", "base_unittests": "08bb01d3a3cb8d780fa9e844dbb862d42b9fcb1b", "blink_common_unittests": "e195a4e707cb283f49ba6f35a744c633fef4a8c7", "blink_heap_unittests": "e6d35af9a28279da49541557dc05b4e6c88d90d3", "blink_platform_unittests": "4cf8327d8ba37d2d6a00a6de0c9954c38322841b", "boringssl_crypto_tests": "4d44086b89b68e97803b7679c8c7e07d0afe6277", "boringssl_ssl_tests": "2bd4e548f7d586e984739d1d44495ea3f37a3045", "breakpad_unittests": "c03c672f64ad93ed8ed448a7de8d9e283bea56d8", "cacheinvalidation_unittests": "db526fab815338448a63c849e0991156bb67ac12", "capture_unittests": "af65d88ac45d858d1942ab9e485ac0d0d1519256", "cast_unittests": "bdc8384338a216fb893772eaf6b99858e735d399", "cc_unittests": "388117ca2c8d671d1d3cb1ad55c9aae6febd7d4c", "chrome_public_test_apk": "b8502271b87ff4d7fa4284644cbf32e90ece59b2", "chrome_public_test_vr_apk": "b8e5b75c870f123e23daa8cf2a92e6022b8c921d", "chrome_sync_shell_test_apk": "bdd8540b00e06d8136a2cedde688c4933da352b7", "components_browsertests": "4d32544bbca55f86a4552e6ff87d75fff33aa34a", "components_unittests": "e37f295fabc142af475430da068ffeb9852a4b05", "content_browsertests": "e7a8e732d10ce99f9195c3ec17e18a4f97e871e3", "content_shell_test_apk": "fb9ad60fdc9100f6a18aee8ded2d92911a408791", "content_unittests": "6902081b77ae4c3394eaef06ffdab212dad6ddf1", "crypto_unittests": "111c85fd91f671d9257561ec79b8891003a49864", "device_unittests": "f8249601d4a654f8a2eb457037b3e90a490c6127", "display_unittests": "3e6fccef598480ab972d78b5aef2ba5628e56817", "events_unittests": "58c50fe0615058264fcf5e911af998e2732bb5e1", "gcm_unit_tests": "acb2d88d385a335a81ee193a5743e6e315b7992b", "gfx_unittests": "58d05add0bf4a213bf780197b8877cc0d6a599c7", "gin_unittests": "d1dc7b0d66d5bceb46380c348372c5059cd8840f", "gl_tests": "9ca4efab756d30836108d161395e54bf9bffc20b", "gl_unittests": "44623a4283a8eeaa6c375ddce0f5c6312d0c10cc", "google_apis_unittests": "23246c305c275e668ef3959f83ce7db95ab7e368", "gpu_unittests": "cc6472e2524d2f26ff90690d473cbb9542ec419d", "ipc_tests": "7df5faaa016abb233dd4dc41e4f8fb1356220673", "jingle_unittests": "1d37dd95c140a73d571bf2999c81bf114466e1c3", "latency_unittests": "7912271d9aa54081892548cb3c4cb667f7f0a72b", "libjingle_xmpp_unittests": "da6ec485b57f4bbd87ab12d60654a3e6a460a3ad", "media_blink_unittests": "0b4e4efd82847db88f73cf05d52ac28fc6f8279f", "media_service_unittests": "4e96325337ca2c54cb2ec2f1762edd4b18e05045", "media_unittests": "6d34c5468b28efee0513751415aa4ef8df552572", "midi_unittests": "7feb95ed8d448390c63bbe09f3dc76c5cbbb3436", "mojo_test_apk": "ea0463d0febfbabe2d1a6eb0236de9a30c54e7d6", "mojo_unittests": "a5d495bca01551b461d12a436c003720db3992ad", "net_unittests": "91b21110d3962433cde5c33a39b30407ab2f5dea", "sandbox_linux_unittests": "3e9d1c803c502bbf3c6fa0faf2dad99465cc18a1", "services_unittests": "4f0f25678ad28e90497b11c575b96ad1730112d9", "shell_dialogs_unittests": "b9b5af6ccb9e488801d91f19f050057d22bfdfc0", "skia_unittests": "f7fdc49d2b7fa176d0905aaac911811c65e58c0c", "sql_unittests": "68ec56ca49fc6e64a987eae9e5cc36639b5aeba4", "storage_unittests": "655c2e39810dbf10d076989acbebe59856174ce9", "ui_android_unittests": "697523db51e31e5822cb5555f947355c5fa8c3ee", "ui_base_unittests": "ba1367bb29427276dd59d616e90921cc1c3357f6", "ui_touch_selection_unittests": "6eee9bc319dd0de814ced669a414036c444d93c1", "unit_tests": "4df0e953ff112838ee2131003ddc651559710ad2", "url_unittests": "386d342199f197f5bfec2a07d8c3510e4a1aa1ee", "viz_unittests": "17e9f84f56b0d3c401986c529bb4d561500c9cbd", "vr_common_unittests": "52dfb1267eb0ec439eeb71d96970dc119f8ad562", "vr_pixeltests": "b5c426477fbbab81e56a67673729d948c02a5523", "webkit_unit_tests": "3aa778ba9ed443e0276ffa8b1d552e6ce5786fa6", "webview_instrumentation_test_apk": "484db07e659be32fe555cfcbaa36cf8f7d8e1d73", "wtf_unittests": "cd26ba4f6e54716edaffd97ad0ceb8f41cff4f20"} find isolated tests

Blamelist:

  1. Matt Falkenhagen (falkenohnoyoudont@chromium.org)
  2. rajendrant (rajendrantohnoyoudont@chromium.org)
  3. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  4. Aleks Totic (atoticohnoyoudont@chromium.org)
  5. Makoto Shimazu (shimazuohnoyoudont@chromium.org)
  6. Anita Woodruff (awdfohnoyoudont@chromium.org)
  7. Hitoshi Yoshida (periaohnoyoudont@chromium.org)
  8. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  9. Alan Cutter (alancutterohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 10:48:17 UTC
Start Thursday, 12-Jul-18 10:48:50 UTC
End Thursday, 12-Jul-18 13:04:49 UTC
Pending 32 secs
Execution 2 hrs 15 mins

All Changes:

  1. Add service worker README.md.

    Changed by Matt Falkenhagen - falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

    Comments

    Add service worker README.md.
    
    Bug: 795989
    Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d
    Reviewed-on: https://chromium-review.googlesource.com/1134718
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574507}

    Changed files

    • content/browser/service_worker/README.md
    • content/common/service_worker/README.md
    • third_party/blink/common/service_worker/README.md
    • third_party/blink/public/common/service_worker/README.md
    • third_party/blink/public/mojom/service_worker/README.md
    • third_party/blink/public/platform/modules/service_worker/README.md
    • third_party/blink/public/web/modules/service_worker/README.md
    • third_party/blink/renderer/modules/service_worker/README.md
  2. Use PLM for data saver site-breakdown

    Changed by rajendrant - rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62

    Comments

    Use PLM for data saver site-breakdown
    
    This CL adds PLM observer for site-breakdown that records the data use
    by host. The new codepath is enabled and the old data use asriber observer
    based site-breakdown codepath is disabled, based on a feature.
    
    Bug: 836029
    Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219
    Reviewed-on: https://chromium-review.googlesource.com/1050868
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574506}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • chrome/test/BUILD.gn
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
  3. Add new methods to EntryList and tests

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76bc398de31290a2d97ee6b7ea804a55d1d5451d

    Comments

    Add new methods to EntryList and tests
    
    Change the logic to add entries to My Files to account for volume being
    mounted/unmounted. This fixes some broken tests when running with the
    flag enabled by default, so test to cover this is on
    crrev.com/c/1131025.
    
    Fix test getMetadata function name.
    
    Bug: 857335
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id056b0e0d5c77a07c2561f6566bfc99111864917
    Reviewed-on: https://chromium-review.googlesource.com/1133613
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574505}

    Changed files

    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
  4. [LayoutNG] Fix static position for inline containing block

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f321a196a45bce7d32257d0b93b472dba89e205a

    Comments

    [LayoutNG] Fix static position for inline containing block
    
    Bug: 740993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Iacdfc2694b2522c06a2512000ed1ca7f043b7541
    Reviewed-on: https://chromium-review.googlesource.com/1134386
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574504}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
  5. NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

    Changed by Makoto Shimazu - shimazuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:13:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 670a4fd7d5c89c8904f638edda72083e41e5d016

    Comments

    NetS13nServiceWorker: Add more info to traces in SWNavigationLoader
    
    Bug: 806658
    Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17
    Reviewed-on: https://chromium-review.googlesource.com/1134711
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574503}

    Changed files

    • content/browser/service_worker/service_worker_navigation_loader.cc
  6. [Android PageInfo] Refactor PageInfoController to enable testing

    Changed by Anita Woodruff - awdfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:05:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfb08c4ccef342639df17f6a423643df1784b767

    Comments

    [Android PageInfo] Refactor PageInfoController to enable testing
    
    - Extracted PermissionParamsListBuilder from PageInfoController
    to handle all the permission-related logic when displaying
    permissions in page info. This new class requires fewer
    hard-to-unit-test dependencies so its logic can now be tested.
    
    Bug: 691898
    Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4
    Reviewed-on: https://chromium-review.googlesource.com/1103564
    Commit-Queue: Anita Woodruff <awdf@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574502}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
  7. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by Hitoshi Yoshida - periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc
  8. Change test to use full-path-for-testing attribute selector

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
  9. Add find bar icon to hosted app windows

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows
    
    This CL moves the find icon from LocationBarView into PageActionIconContainerView
    enabling the icon to appear in hosted app window title bars.
    
    This change also fixes the find icon getting nudged by
    crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.
    
    Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
    Before CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
    After CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1
    
    Bug: 788051, 814531
    Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
    Reviewed-on: https://chromium-review.googlesource.com/1054908
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h