Home | Search | chromium - Builders
Login

Builder Marshmallow Tablet Tester Build 1646 Canonical Ubuntu

Results:

Failure viz_unittests on Android device Nexus 7 [2013] Failure content_browsertests on Android device Nexus 7 [2013] Failure chrome_public_test_apk on Android device Nexus 7 [2013]

Trigger Info:

Projectchromium
Revisionb8143822153ed2373d843fd588593070ed59894c
Got Revisionb8143822153ed2373d843fd588593070ed59894c

Execution:

Steps and Logfiles:

Show:
  1. ( 324 ms ) setup_build
    running recipe: "chromium"
  2. ( 733 ms ) report builders
     
    running tester 'Marshmallow Tablet Tester' on master 'chromium.android'
  3. ( 3 mins 43 secs ) bot_update
    [58GB/295GB used (19%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 36 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  7. ( 548 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  8. ( 15 secs ) clean local files
  9. ( 1 secs ) tree truth steps
  10. ( 461 ms ) build directory
  11. ( 1 secs ) find isolated tests
  12. ( 41 secs ) android_webview_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:08.159705
  13. ( 3 mins 46 secs ) angle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 12s
    Shard duration: 0:05:44.126304
  14. ( 4 secs ) base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:05:54.883913
  15. ( 2 secs ) blink_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 17s
    Shard duration: 0:01:05.591500
  16. ( 2 secs ) blink_heap_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 26s
    Shard duration: 0:02:54.864659
  17. ( 4 secs ) blink_platform_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 28s
    Shard duration: 0:04:59.356720
  18. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:45.405506
  19. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:11.479546
  20. ( 2 secs ) breakpad_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:05.456262
  21. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:02.544703
  22. ( 2 secs ) capture_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 31s
    Shard duration: 0:01:20.153967
  23. ( 2 secs ) cast_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 31s
    Shard duration: 0:01:19.860813
  24. ( 4 secs ) cc_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 46s
    Shard duration: 0:05:14.394884
  25. ( 4 mins 24 secs ) chrome_sync_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 51s
    Shard duration: 0:10:30.705544
  26. ( 2 secs ) components_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:02:23.010092
    Shard duration: 0:05:21.110932
  27. ( 2 secs ) perfetto_content_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:02:32.095207
    Shard duration: 0:03:15.649748
  28. ( 2 secs ) crypto_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 56s
  29. ( 2 secs ) device_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:02:40.814454
    Shard duration: 0:02:00.804766
  30. ( 2 secs ) display_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 52s
  31. ( 4 secs ) events_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:02:58.375022
    Shard duration: 0:01:29.463181
  32. ( 2 secs ) gcm_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:03:47.866546
    Shard duration: 0:01:14.141461
  33. ( 5 secs ) gfx_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:05:32.040960
  34. ( 2 secs ) gin_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:02.433909
  35. ( 2 secs ) gl_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:05:12.411882
    Shard duration: 0:02:15.112534
  36. ( 2 secs ) gl_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 53s
  37. ( 2 secs ) google_apis_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:05:34.379800
    Shard duration: 0:01:27.877182
  38. ( 5 secs ) gpu_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:05:37.779941
    Shard duration: 0:05:13.664557
  39. ( 2 secs ) ipc_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:01.650352
  40. ( 2 secs ) jingle_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:06:03.065553
    Shard duration: 0:01:06.608699
  41. ( 2 secs ) latency_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:04.698043
  42. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:06:10.871943
    Shard duration: 0:01:04.583943
  43. ( 3 secs ) media_blink_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:06:15.373132
    Shard duration: 0:02:56.165099
  44. ( 2 secs ) media_service_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:06:23.210191
    Shard duration: 0:01:26.496531
  45. ( 2 mins 20 secs ) media_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:07:40.922394
    Shard duration: 0:07:07.739171
  46. ( 2 secs ) midi_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:31.986829
  47. ( 2 secs ) mojo_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:03:34.673323
  48. ( 2 secs ) mojo_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:02:36.027028
  49. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 39s
  50. ( 4 secs ) services_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:07:40.757591
    Shard duration: 0:05:28.757081
  51. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:07:44.727992
    Shard duration: 0:01:02.279263
  52. ( 2 secs ) skia_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:07:56.144737
    Shard duration: 0:01:05.589130
  53. ( 2 secs ) sql_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:22.383486
  54. ( 2 secs ) storage_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:07:56.418127
    Shard duration: 0:02:29.398575
  55. ( 2 secs ) ui_android_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:08:11.873270
    Shard duration: 59s
  56. ( 2 secs ) ui_base_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:19.565973
  57. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 59s
  58. ( 2 secs ) url_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:06.378205
  59. ( 3 secs ) viz_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:09:13.585504
    Shard duration: 0:04:07.117839
    failures:
    GLScalerShaderPixelTest.ThreeTapBilinear/0
    GLScalerShaderPixelTest.BicubicUpscale/3
    GLScalerShaderPixelTest.BicubicUpscale/1
    GLScalerShaderPixelTest.BicubicUpscale/0
    GLScalerShaderPixelTest.BicubicUpscale/2
    GLScalerShaderPixelTest.Export_Planar/3
    GLScalerShaderPixelTest.Bilinear/2
    GLScalerShaderPixelTest.Bilinear/1
    GLScalerShaderPixelTest.Export_Planar/0
    GLScalerShaderPixelTest.Bilinear/3
    GLScalerShaderPixelTest.ValidateTestHelpers/1
    GLScalerShaderPixelTest.ValidateTestHelpers/3
    GLScalerShaderPixelTest.ValidateTestHelpers/2
    GLScalerShaderPixelTest.Export_Planar/2
    GLScalerShaderPixelTest.Bilinear/0
    GLScalerShaderPixelTest.Export_Planar/1
     
  60. ( 2 secs ) vr_common_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:09:28.430822
    Shard duration: 0:02:01.599355
  61. ( 2 secs ) vr_pixeltests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Pending time: 0:09:27.941456
    Shard duration: 0:02:05.645694
  62. ( 2 secs ) wtf_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Shard duration: 0:01:05.616806
  63. ( 12 mins 36 secs ) webkit_unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:11:00.445652 (shard #1)
    Max shard duration: 0:17:35.012469 (shard #0)
    Min shard duration: 0:17:15.240369 (shard #1)
  64. ( 3 secs ) content_shell_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:12:02.635383 (shard #2)
    Max shard duration: 0:12:15.270315 (shard #2)
    Min shard duration: 0:10:58.719091 (shard #1)
  65. ( 6 secs ) content_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:14:48.567470 (shard #2)
    Max shard duration: 0:07:23.671646 (shard #2)
    Min shard duration: 0:06:45.744484 (shard #1)
  66. ( 34 secs ) net_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max shard duration: 0:19:04.568276 (shard #0)
    Min shard duration: 0:16:21.567013 (shard #2)
  67. ( 4 mins 38 secs ) components_unittests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:22:51.165194 (shard #3)
    Max shard duration: 0:11:28.932713 (shard #2)
    Min shard duration: 0:09:31.647771 (shard #3)
  68. ( 11 mins 41 secs ) webview_instrumentation_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:31:45.552056 (shard #6)
    Max shard duration: 0:15:23.567226 (shard #4)
    Min shard duration: 0:11:49.674184 (shard #6)
  69. ( 18 mins 39 secs ) content_browsertests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 0:46:37.463899 (shard #8)
    Max shard duration: 0:20:33.436303 (shard #4)
    Min shard duration: 0:16:45.578538 (shard #8)
    failures:
    MediaColorTest.Yuv420pH264
    MediaColorTest.Yuv420pRec709H264
     
  70. ( 10 mins 32 secs ) unit_tests on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:06:49.420672 (shard #8)
    Max shard duration: 0:10:59.266590 (shard #6)
    Min shard duration: 0:06:19.907556 (shard #3)
  71. ( 38 mins 48 secs ) chrome_public_test_apk on Android device Nexus 7 [2013]
    Run on OS: 'Android'
    Max pending time: 1:39:39.771123 (shard #19)
    Max shard duration: 0:19:02.639485 (shard #14)
    Min shard duration: 0:12:17.193952 (shard #3)
    failures:
    org.chromium.chrome.browser.download.DownloadMediaParserTest#testParseVideoH264
     
  72. ( 255 ms ) Tests statistics
     
    Stats
    Total shards: 112
    Total runtime: 15:20:29.223020
     
  73. ( 255 ms ) test_report
  74. ( 3 ms ) Failure reason

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm100-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539329591681758, "id": "8932889650031936112", "project": "chromium", "tags": ["builder:Marshmallow Tablet Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b8143822153ed2373d843fd588593070ed59894c", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:37872", "scheduler_invocation_id:9098319712168732224", "scheduler_job_id:chromium/Marshmallow Tablet Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Marshmallow Tablet Tester" setup_build
buildnumber 1646 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "b8143822153ed2373d843fd588593070ed59894c" setup_build
parent_got_revision_cp "refs/heads/master@{#599107}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "8f4bc41c42318534a564e75e48b01f065f2cbc57" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25133}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "b8143822153ed2373d843fd588593070ed59894c" setup_build
swarm_hashes {"android_webview_unittests": "1a088e1cc69c77f9ea4739e61dc701337dfb6e76", "angle_unittests": "abc499e66662f8cb17b086eec46a2375eb732bf5", "base_unittests": "1e2cc71071890ed43aad0c28bc3a95c454cc5bae", "blink_common_unittests": "28a45dcf352a53aec8e112255260556ccdc9e930", "blink_heap_unittests": "564c1d67a17b9e904d0cdf468c3988c8c6a5ad35", "blink_platform_unittests": "c7672618aa358e660fa98ac371db58dde94cc299", "boringssl_crypto_tests": "21b538511bd6f2a0b87b8c8ea7b841a33969781a", "boringssl_ssl_tests": "6131c493da957c15607d2ce36a6e678d98e37ebf", "breakpad_unittests": "ca5b1c054049b4d784740bd0e25c17ca208a4693", "cacheinvalidation_unittests": "3b7a7d4756b10711a5353fcf10fb08c61a94f7b4", "capture_unittests": "c71e317e4ec8224fa82bd015e811ffa08586f949", "cast_unittests": "c83a55298d855ba21f9e50ffa21f9860602b0ea9", "cc_unittests": "ba2bda8b43385242923daaebff1f0d4e40f3944e", "chrome_public_test_apk": "d90aeaf3b7ffb053f393f93e68c7dad00cf4b48e", "chrome_public_test_vr_apk": "29082413a05b2f8b87c57809d80bb50470d87986", "chrome_sync_shell_test_apk": "9206b0fda1fb9a31c8daf6eca4a1ce5406ec3f32", "components_browsertests": "eca20988cc3978d3795e3062dc3711d514c23e86", "components_unittests": "1ba6664f699e9b4d29a4eb86ad9e36c6aa30c362", "content_browsertests": "a3d357f7106be9c15932c7fe16017e5073a33f3b", "content_shell_test_apk": "de28ffc6956e785f9ef4b4f6818e556fd550b424", "content_unittests": "10803daa29a4520814021cc55cfdd17231b007e5", "crypto_unittests": "c18efe8957e74955a4cfd1dc0505e51e97b5a95b", "device_unittests": "86b816f77a0923d9b5b2cd6b26daf1be4d385754", "display_unittests": "20fc927ccd49fc175de5bb9d6cc5ca56ffc3a84b", "events_unittests": "8125b0f092897e07ece02f949be2295712f7fa4f", "gcm_unit_tests": "ebbf4da8a9d42161f89c4fa1822708635ae5964c", "gfx_unittests": "2defdfebb4ceac8dc681d6945b8b61c58f9c6703", "gin_unittests": "b791dde3e244cbef95ab751f567000a15366f877", "gl_tests": "813d017fe008cb5a68d4497ba3562617a6da1aff", "gl_unittests": "00353fb053aca3eb5480cb4f0c46971ef435c1f4", "google_apis_unittests": "ac8912cab981e3caa93c44d5d682541d753c820f", "gpu_unittests": "a5ff53d01f6260c3a95ee9dc8cf7869dcdf11644", "ipc_tests": "4515bc962edf812f5953a36abddab9f97ab70eaf", "jingle_unittests": "60b637b449c97de349d9f64624bb32c93b5297ff", "latency_unittests": "2ccb0aef852405d41afe5ce7a61ea046b5887ddc", "libjingle_xmpp_unittests": "9bdaa299cf3ed6756ab649d96efb589823f6b021", "media_blink_unittests": "5ed05d77a58cee49b23218663ceebeb595c59aab", "media_service_unittests": "62fe4a651a7472fe7aa05aa03075dcc2e8460c83", "media_unittests": "a931524112725c6c2ba81ca913513e517547186c", "midi_unittests": "b8f36be5bfbe4a98e981646c1626005af6e30184", "mojo_test_apk": "8d2d7542399215022c157f878723bbc08f3d64a5", "mojo_unittests": "e94e20c84341411cb23b47cdce6ef120881f745c", "net_unittests": "558462bbf92bbc3987cae5303b917c60693a2b2a", "sandbox_linux_unittests": "4e16cbe475c7ec1fb1dece400d0bc7e7e8a75583", "services_unittests": "b02eb7c8db6c675b7c290c141d7e648b6d2ae81b", "shell_dialogs_unittests": "6cbc05c5267aa50873f270fdf30d8c8d4994be50", "skia_unittests": "eb1bab87b4678457ef4b50f1bdb3373a18407d1d", "sql_unittests": "b9bce5dcff487dab03722347cb6e6d90c4022fdd", "storage_unittests": "040f9467ef1890b727bac37b76dc6013c070193f", "ui_android_unittests": "c0dd2ab0f0f18e2c9083c9811069f4c61c4f1214", "ui_base_unittests": "2dcf42236617b16c56361048e47b467f48a28f3d", "ui_touch_selection_unittests": "ac56dec4f4466004dd931b80aa7e74f21cf7b575", "unit_tests": "0e4121b11214acac522acb840c088e44bb73e41b", "url_unittests": "509dca221f98c1108d9cba558db68f6845440bbb", "viz_unittests": "7d1058dbd12cde79c13a94849209efe0229c5e1b", "vr_common_unittests": "224eaaeca436dbdc0c388f4434fab080a42df6c7", "vr_pixeltests": "56c3f71f196e947a6f29990a2cb8f5f4159863b0", "webkit_layout_tests_exparchive": "129a833335357c8671109ba8df8f9d9a82635ea1", "webkit_unit_tests": "088a2520746760e068d87da554d8e5da33b98617", "webview_cts_tests": "4ebedec847af13b3492cff11c6a8eb56a9537d21", "webview_instrumentation_test_apk": "bcb8d2c3ac9eef27c2b9946de08687197aa02e6a", "wtf_unittests": "f677ca166abefe1454e55d1ebdaa44ddc7fc12a2"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "b8143822153ed2373d843fd588593070ed59894c" bot_update
got_revision_cp "refs/heads/master@{#599107}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "8f4bc41c42318534a564e75e48b01f065f2cbc57" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25133}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  2. Kunihiko Sakamoto (ksakamotoohnoyoudont@chromium.org)
  3. Mohamed Amir Yosef (mamirohnoyoudont@chromium.org)
  4. Yuki Yamada (yukiyohnoyoudont@google.com)
  5. Kouhei Ueno (kouheiohnoyoudont@chromium.org)
  6. Justin Cohen (justincohenohnoyoudont@google.com)
  7. John Z Wu (jzwohnoyoudont@chromium.org)
  8. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  10. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  11. Keiichi Watanabe (keiichiwohnoyoudont@chromium.org)
  12. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  13. Koji Ishii (kojiiohnoyoudont@chromium.org)
  14. Findit (findit-for-meohnoyoudont@appspot.gserviceaccount.com)
  15. Leon Han (leon.hanohnoyoudont@intel.com)
  16. Fergal Daly (fergalohnoyoudont@chromium.org)
  17. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  18. Tommy Steimel (steimelohnoyoudont@chromium.org)
  19. Gang Wu (gangwuohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 07:33:11 UTC
Start Friday, 12-Oct-18 07:33:43 UTC
End Friday, 12-Oct-18 09:35:33 UTC
Pending 32 secs
Execution 2 hrs 1 mins

All Changes:

  1. Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b8143822153ed2373d843fd588593070ed59894c

    Comments

    Roll src-internal 09c355ef00f4..aebffd21b13f (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09c355ef00f4..aebffd21b13f
    
    
    Created with:
      gclient setdep -r src-internal@aebffd21b13f
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I816f02425f0557bf4030f14078bb453721cca6fe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278300
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599107}

    Changed files

    • DEPS
  2. Signed Exchange: Populate completion time for inner response

    Changed by Kunihiko Sakamoto - ksakamotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:49:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb0dee4694e580a614f5d380e0c60526cdfd2b90

    Comments

    Signed Exchange: Populate completion time for inner response
    
    This fixes a bug where Resource Timing for prefetched Signed Exchange
    had negative duration value.
    
    Bug: 803774
    Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1278546
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599106}

    Changed files

    • content/browser/web_package/signed_exchange_loader.cc
    • third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-prefetch-resource-timing.html
  3. [Sync::USS] Handle corrupted bookmarks metadata

    Changed by Mohamed Amir Yosef - mamirohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:42:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb7986d88b0b8f174020916003d6939d2d928b83

    Comments

    [Sync::USS] Handle corrupted bookmarks metadata
    
    At startup, the persisted sync metadata (if available) are loaded
    and tracked.
    
    This CL adds some integrity checks and makes sure that corrupted
    metadata are ignored, and that Sync starts clean in such case.
    
    
    Bug: 516866
    Change-Id: Idf42cce2306f18a94941d40caa1816f737732156
    Reviewed-on: https://chromium-review.googlesource.com/c/1274106
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599105}

    Changed files

    • components/sync_bookmarks/BUILD.gn
    • components/sync_bookmarks/DEPS
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_bookmarks/bookmark_model_type_processor.h
    • components/sync_bookmarks/bookmark_model_type_processor_unittest.cc
    • components/sync_bookmarks/synced_bookmark_tracker.cc
    • components/sync_bookmarks/synced_bookmark_tracker.h
    • components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
  4. Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()

    Changed by Yuki Yamada - yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:38:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e151e38b3dabf71057cd3f303490937fbc24bad

    Comments

    Add a comment for backup_incumbent_scope in JSEventHandler::SetCompiledHandler()
    
    This adds a comment for the previous change:
    https://chromium-review.googlesource.com/c/chromium/src/+/1276406
    
    Bug: 893951
    Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278070
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599104}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_event_handler.cc
  5. Implement SignedExchange.Prefetch UMAs

    Changed by Kouhei Ueno - kouheiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 97df84454db873390762a20012a30407d6bd1ed5

    Comments

    Implement SignedExchange.Prefetch UMAs
    
    Bug: 890180
    Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd
    Reviewed-on: https://chromium-review.googlesource.com/c/1275746
    Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599103}

    Changed files

    • content/browser/loader/prefetch_url_loader_service.cc
    • content/browser/web_package/signed_exchange_loader.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.cc
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder.h
    • content/browser/web_package/signed_exchange_prefetch_metric_recorder_unittest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/test/BUILD.gn
    • tools/metrics/histograms/histograms.xml
  6. [ios] Move FYI xcode-clang bot back to Xcode 10.

    Changed by Justin Cohen - justincohenohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 05:20:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1af4ddc196ec7424ff808b37f3ec67aa36577a0c

    Comments

    [ios] Move FYI xcode-clang bot back to Xcode 10.
    
    This bot was erronously moved from Xcode 10 beta 4 all the way to Xcode 10.1
    beta.  Now that Xcode 10 GM is in goma, roll to Xcode 10.
    
    Note: This rolls to 10a254a, which is slightly different than the package
    goma installed, but it has the same compiler (clang-1000.11.45.2) so it should
    work the same.  If not, we'll have to investigate why and upload a new package
    to CIPD.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I46e90d60eb562f69d1848df3ff48db3d82cf1cc1
    Reviewed-on: https://chromium-review.googlesource.com/c/1278331
    Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599102}

    Changed files

    • ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json
  7. Some fixes for sync:

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 05:16:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 877046da44d232fb9de9bcbaee249c83ff8b0d1e

    Comments

    Some fixes for sync:
    
    1. Disable feature SyncUserConsentSeparateType for now.
    2. Use ReloadCredentials since LoadCredentials DCHECKs and fix up the tests.
    
    Bug: 867548
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I3a9af1b353b3138b411ee9fdab6cc67c447ee109
    Reviewed-on: https://chromium-review.googlesource.com/c/1278471
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: John Wu <jzw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599101}

    Changed files

    • ios/web_view/BUILD.gn
    • ios/web_view/internal/sync/cwv_sync_controller.mm
    • ios/web_view/internal/sync/cwv_sync_controller_unittest.mm
    • ios/web_view/internal/web_view_web_main_parts.mm
  8. Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:16:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 155a1c23d2f8953f50fcff84366cfaea19f0691e

    Comments

    Roll src/third_party/angle c4533eae082f..671809e62e80 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/c4533eae082f..671809e62e80
    
    
    git log c4533eae082f..671809e62e80 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D
    2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@671809e62e80
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=fjhenigman@chromium.org
    
    Change-Id: Ie918b1391ee226eb39be833dc7768cec9bdbee65
    Reviewed-on: https://chromium-review.googlesource.com/c/1278299
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599100}

    Changed files

    • DEPS
  9. Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 05:06:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 86871d7222d501610f9de98a22fd8a41b495d0c3

    Comments

    Roll src/third_party/chromite 9a72c51a329f..89e4bf93b1a1 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a72c51a329f..89e4bf93b1a1
    
    
    git log 9a72c51a329f..89e4bf93b1a1 --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 derat@chromium.org chromeos_config: Run Tast on {amd64-generic,betty}-paladin.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@89e4bf93b1a1
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I29f302fb260fcd75ce3d9d3b538f0eed2c2a1f21
    Reviewed-on: https://chromium-review.googlesource.com/c/1278493
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599099}

    Changed files

    • DEPS
  10. CrOS FilesApp: refactor only: split out crostini UI tests

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:53:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2500163be8a63b6dd75c9427640f8763d6d46b33

    Comments

    CrOS FilesApp: refactor only: split out crostini UI tests
    
    Split crostini UI tests from crostini.js into test files:
     * crostini_mount.js
     * crostini_share.js
     * crostini_tasks.js
    The existing tests are getting a bit too large and pushing
    the bot testing time limits.
    
    Bug: 878324
    Change-Id: I882a38e3f644916e3c904709f3bfc540034b1383
    Reviewed-on: https://chromium-review.googlesource.com/c/1278429
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599098}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_uitest.cc
    • ui/file_manager/file_manager/test/BUILD.gn
    • ui/file_manager/file_manager/test/crostini.js
    • ui/file_manager/file_manager/test/crostini_mount.js
    • ui/file_manager/file_manager/test/crostini_share.js
    • ui/file_manager/file_manager/test/crostini_tasks.js
  11. [Video Capture, Test] Make tests requiring real webcam fail if it's not found

    Changed by Keiichi Watanabe - keiichiwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:50:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfeab488cdc95233b19b9edeedef3d0b7581b17e

    Comments

    [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    
    Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    add checking whether webcam is found or not.
    Accordingly, exclude such test cases from test suites for devices that have no
    camera.
    
    Bug: 893494
    Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
          and it failed.
    Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
          and it passed.
    Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
          and it passed.
    
    Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599097}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  12. Roll src-internal 616feb1a7c2c..09c355ef00f4 (2 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 04:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5fc416b1492c1141613708a7234048954198b839

    Comments

    Roll src-internal 616feb1a7c2c..09c355ef00f4 (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/616feb1a7c2c..09c355ef00f4
    
    
    Created with:
      gclient setdep -r src-internal@09c355ef00f4
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I31399eb2e92dae352d53dc7fcde8bf49c0966418
    Reviewed-on: https://chromium-review.googlesource.com/c/1278531
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599096}

    Changed files

    • DEPS
  13. [auto] Update FlagExpectations for LayoutNG

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:22:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfdec8007a6f8a83d060f176a335b42537cb8ba9

    Comments

    [auto] Update FlagExpectations for LayoutNG
    
    Following bot results are included.
    10421 10431 10436 10446 10458 10478 10484 10489 10494 10496
    10498 10499 10503 10509 10514 10516 10519 10523 10525 10530
    10541 10549 10550 10552
    
    1 lines were removed and 3 lines were deflaked by consecutive
    results since 10503.
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I937b189ec5c0061d7c1607828b6ac5fc0bfe71b4
    Reviewed-on: https://chromium-review.googlesource.com/c/1270498
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599095}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  14. Revert "Fling bubbles from OOPIF properly."

    Changed by Findit - findit-for-meohnoyoudont@appspot.gserviceaccount.com
    Changed at Friday, 12-Oct-18 04:21:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb03212f2a4bd93f4f87da036a5f9eaeb2256466

    Comments

    Revert "Fling bubbles from OOPIF properly."
    
    This reverts commit a12ef847a57f4aa0282ca47b555c04da18b00f9e.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the
    culprit for flakes in the build cycles as shown on:
    https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw
    
    Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516
    
    Sample Failed Step: content_browsertests
    
    Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF
    
    Original change's description:
    > Fling bubbles from OOPIF properly.
    > 
    > While we are bubbling a scroll sequence GFS is sent to the fling controllers
    > of both the oopif and the bubbling target. The fling controller of the oopif
    > calls progressFling and generates a GSU with inertial phase, the GSU gets acked
    > immediately before getting sent to the renderer since we are in bubbling mode.
    > Then the oopif's fling controller receives the unconsumed GSU ack and generates
    > a GSE to complete the scrolling sequence on the oopif. The bubbling target's
    > fling controller receives and processes the GFS and generates GSUs which are
    > sent to the target's renderer.
    > 
    > If the GSE generated by the oopif's fling controller gets bubbled before
    > the GFS, the bubbling target gets reset and the target does not receive the
    > GFS. This cl fixes the issue by making sure that the events generated by the
    > oopif's fling controller are not bubbled to the target. Also in case of
    > GFS bubbling, the GFC should also get sent to the bubbling target to make
    > sure that the fling controller in charge of flinging receives the GFC.
    > 
    > 
    > Bug: 884728, 249063
    > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF
    > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274193
    > Reviewed-by: Kevin McNee <mcnee@chromium.org>
    > Reviewed-by: Charlie Reis <creis@chromium.org>
    > Commit-Queue: Charlie Reis <creis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599001}
    
    Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 884728, 249063, 894703
    Reviewed-on: https://chromium-review.googlesource.com/c/1278536
    Cr-Commit-Position: refs/heads/master@{#599094}

    Changed files

    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/renderer_host/input/fling_browsertest.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
  15. [OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration

    Changed by Leon Han - leon.hanohnoyoudont@intel.com
    Changed at Friday, 12-Oct-18 04:17:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6856b267639d14077ac2aac923503f586f3c955

    Comments

    [OnionSoup] Reduce usages of blink::WebServiceWorkerRegistration
    
    Currently some modules (push_messaging, background_fetch etc.) are
    calling blink::SWRegistration::WebRegistration() to get a pointer to
    blink::WebSWRegistration to continue their work there.
    However, they use that blink::WebSWRegistration just to retrieve the
    service worker registration id, i.e. what they really want is not
    blink::WebSWRegistration, but just the registration id.
    
    So, this CL removes blink::SWRegistration::WebRegistration() and
    provides a new function blink::SWRegistration::RegistrationId() for
    those users instead.
    
    This CL is in preparation for https://crrev.com/c/1275300 which plans to
    merge content::WebSWRegistrationImpl into blink::SWRegistration and
    remove the public interface blink::WebSWRegistration completely.
    
    BUG=789857,879019
    
    Change-Id: Iafb245ec6f978dfaa294f58ee800d80c5ba60fac
    Reviewed-on: https://chromium-review.googlesource.com/c/1275298
    Commit-Queue: Leon Han <leon.han@intel.com>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Ian Clelland <iclelland@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599093}

    Changed files

    • content/renderer/push_messaging/push_messaging_client.cc
    • content/renderer/push_messaging/push_messaging_client.h
    • content/renderer/push_messaging/push_provider.cc
    • content/renderer/push_messaging/push_provider.h
    • third_party/blink/public/platform/modules/push_messaging/web_push_client.h
    • third_party/blink/public/platform/modules/push_messaging/web_push_provider.h
    • third_party/blink/renderer/modules/background_fetch/background_fetch_bridge.cc
    • third_party/blink/renderer/modules/background_sync/sync_manager.cc
    • third_party/blink/renderer/modules/cookie_store/cookie_store.cc
    • third_party/blink/renderer/modules/notifications/notification_manager.cc
    • third_party/blink/renderer/modules/notifications/notification_manager.h
    • third_party/blink/renderer/modules/notifications/service_worker_registration_notifications.cc
    • third_party/blink/renderer/modules/push_messaging/push_manager.cc
    • third_party/blink/renderer/modules/push_messaging/push_subscription.cc
    • third_party/blink/renderer/modules/service_worker/navigation_preload_manager.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_registration.h
  16. [css, dom] Improve docs on partmap parser.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 04:09:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb88d559e0a370eae92cb3812eee20197ec0cd6f

    Comments

    [css, dom] Improve docs on partmap parser.
    
    Make the state transitions more clear and document which transitions
    consume a character.
    
    Bug: 805271
    
    Change-Id: I363cb6c9d459b560d0ec1b4cb6649cce981deffc
    Reviewed-on: https://chromium-review.googlesource.com/c/1275747
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599092}

    Changed files

    • third_party/blink/renderer/core/dom/names_map.cc
  17. Roll src/third_party/webrtc 1cd39fa9ea0c..8f4bc41c4231 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 03:48:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5de92169da01a3247e6397fc71f44c83447a8a12

    Comments

    Roll src/third_party/webrtc 1cd39fa9ea0c..8f4bc41c4231 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/1cd39fa9ea0c..8f4bc41c4231
    
    
    git log 1cd39fa9ea0c..8f4bc41c4231 --date=short --no-merges --format='%ad %ae %s'
    2018-10-11 oprypin@webrtc.org Revert "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h"
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@8f4bc41c4231
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I926d7ea870bf3c7c76c519c12806778129e89659
    Reviewed-on: https://chromium-review.googlesource.com/c/1277843
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599091}

    Changed files

    • DEPS
  18. [Picture in Picture] Add resize handle for CrOS.

    Changed by Tommy Steimel - steimelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ccd3669d8798ee2013539723323bfd8d982b36a6

    Comments

    [Picture in Picture] Add resize handle for CrOS.
    
    This change adds a UI affordance that the window is resizable and
    draggable on ChromeOS. This adds a ResizeHandleButton made specifically
    as the affordance.
    
    This icon is on the edge of the window that points to the center of
    the workspace screen. For example, if the window is on the bottom right
    quadrant, the icon will be on the top left. In the case where the window
    is on the bottom left quadrant, the icon replaces the close button. The
    close button is then shifted to the top left corner.
    
    Bug: 890113
    Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2
    Reviewed-on: https://chromium-review.googlesource.com/c/1275526
    Commit-Queue: Tommy Steimel <steimel@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599090}

    Changed files

    • chrome/app/generated_resources.grd
    • chrome/app/vector_icons/BUILD.gn
    • chrome/app/vector_icons/resize_handle.icon
    • chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/overlay/close_image_button.cc
    • chrome/browser/ui/views/overlay/close_image_button.h
    • chrome/browser/ui/views/overlay/overlay_window_views.cc
    • chrome/browser/ui/views/overlay/overlay_window_views.h
    • chrome/browser/ui/views/overlay/resize_handle_button.cc
    • chrome/browser/ui/views/overlay/resize_handle_button.h
  19. [Feed] Wire the logging report with the logging bridge

    Changed by Gang Wu - gangwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 03:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5a1ef3e0e0069c84adc62075ae09afbd612c78

    Comments

    [Feed] Wire the logging report with the logging bridge
    
    Wired most of the UMA logging, there are two methods in the bridge not
    connected since it is new UMA, will do in next CL.
    
    Bug: 831641
    Change-Id: I154261aa3266d1f6d0af07ccb7510b3879f2744e
    Reviewed-on: https://chromium-review.googlesource.com/c/1275130
    Commit-Queue: Gang Wu <gangwu@chromium.org>
    Reviewed-by: Sky Malice <skym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599089}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedProcessScopeFactory.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
    • components/feed/core/feed_logging_metrics.cc
    • components/feed/core/feed_logging_metrics.h
    • components/feed/core/feed_logging_metrics_unittest.cc