Home | Search | chromium - Builders
Login

Builder Marshmallow 64 bit Tester Build 22677 Canonical Ubuntu

Results:

Failure chrome_public_test_apk on Android device Nexus 5X (experimental)

Trigger Info:

Projectchromium
Revisionef49be42c92ed17ab5ae4635843eeb4c35737eb5
Got Revisionef49be42c92ed17ab5ae4635843eeb4c35737eb5

Execution:

Steps and Logfiles:

Show:
  1. ( 331 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) remove .cipd
  3. ( 6 mins 53 secs ) bot_update
    [131GB/295GB used (44%)]
  4. ( 0 ) ensure_goma
  5. ( 572 ms ) swarming.py --version
    0.13
  6. ( 50 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 4 secs ) clean local files
  9. ( 2 secs ) tree truth steps
  10. ( 4 secs ) build directory
  11. ( 29 mins 29 secs ) extract build
  12. ( 7 secs ) find isolated tests
  13. ( 0 ) test_pre_run
  14. ( 51 secs ) android_webview_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:12.196520
  15. ( 2 mins 38 secs ) angle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:49.339830
  16. ( 8 secs ) base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:05:09.436010
  17. ( 2 secs ) blink_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  18. ( 2 secs ) blink_heap_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:10.867490
  19. ( 4 secs ) blink_platform_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:21.293250
  20. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:55.421280
  21. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  22. ( 2 secs ) breakpad_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 25s
  23. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 42s
  24. ( 2 secs ) capture_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:32.949780
  25. ( 2 secs ) cast_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 54s
  26. ( 4 secs ) cc_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:58.444940
  27. ( 10 mins 59 secs ) chrome_public_test_apk on Android device Nexus 5X (experimental)
    Run on OS: 'Android'
    Max shard duration: 0:16:20.208350 (shard #6)
    Min shard duration: 0:12:37.218430 (shard #10)
  28. ( 2 secs ) chrome_public_test_vr_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:13:16.577420
  29. ( 2 secs ) chrome_sync_shell_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:07:15.253580
  30. ( 2 secs ) components_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:11.154420
  31. ( 14 secs ) components_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:13:03.807310 (shard #0)
    Min shard duration: 0:12:10.389450 (shard #1)
  32. ( 11 secs ) content_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:13:17.854740 (shard #6)
    Min shard duration: 0:09:15.622630 (shard #8)
  33. ( 3 secs ) content_shell_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:09:55.348000 (shard #1)
    Min shard duration: 0:08:11.897600 (shard #2)
  34. ( 7 secs ) content_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:06:08.367630 (shard #1)
    Min shard duration: 0:05:35.460220 (shard #0)
  35. ( 2 secs ) crypto_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  36. ( 2 secs ) device_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:23.827180
  37. ( 2 secs ) display_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 51s
  38. ( 2 secs ) events_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 56s
  39. ( 7 secs ) gcm_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:24.596130
  40. ( 5 secs ) gfx_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:57.000900
  41. ( 2 secs ) gin_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 50s
  42. ( 2 secs ) gl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:30.496510
  43. ( 2 secs ) gl_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 47s
  44. ( 2 secs ) google_apis_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:10.374040
  45. ( 5 secs ) gpu_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:14.821590
  46. ( 2 secs ) ipc_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  47. ( 3 secs ) jingle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:09.845320
  48. ( 2 secs ) latency_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 47s
  49. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 50s
  50. ( 4 secs ) media_blink_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:26.096790
  51. ( 2 secs ) media_service_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:14.537450
  52. ( 6 secs ) media_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:05:59.925740
  53. ( 2 secs ) midi_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  54. ( 2 secs ) mojo_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:18.175080
  55. ( 3 secs ) mojo_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:00.738100
  56. ( 36 secs ) net_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:12:19.374600 (shard #1)
    Min shard duration: 0:11:08.135070 (shard #2)
  57. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 27s
  58. ( 3 secs ) services_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:07.141700
  59. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  60. ( 2 secs ) skia_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 50s
  61. ( 2 secs ) sql_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 55s
  62. ( 2 secs ) storage_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:50.843150
  63. ( 2 secs ) ui_android_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  64. ( 2 secs ) ui_base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:24.050370
  65. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 51s
  66. ( 6 secs ) unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:12:17.430130 (shard #3)
    Min shard duration: 0:10:31.127700 (shard #2)
  67. ( 2 secs ) url_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  68. ( 3 secs ) viz_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:23.659570
  69. ( 2 secs ) vr_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:56.654800
  70. ( 1 mins 4 secs ) vr_pixeltests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:53.374140
  71. ( 9 secs ) webkit_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:16:11.046410
  72. ( 6 secs ) webview_instrumentation_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:10:36.343420 (shard #2)
    Min shard duration: 0:08:45.450860 (shard #1)
  73. ( 2 secs ) wtf_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 55s
  74. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 98
    Total runtime: 10:17:27.522108
     
  75. ( 768 ms ) test_report
  76. ( 4 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm970-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531424619599270, "id": "8941178614037595264", "project": "chromium", "tags": ["builder:Marshmallow 64 bit Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/ef49be42c92ed17ab5ae4635843eeb4c35737eb5", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm64 Builder (dbg)", "parent_buildnumber:31826", "scheduler_invocation_id:9106608676192288464", "scheduler_job_id:chromium/Marshmallow 64 bit Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Marshmallow 64 bit Tester" setup_build
buildnumber 22677 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm64 Builder (dbg)" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "ef49be42c92ed17ab5ae4635843eeb4c35737eb5" setup_build
parent_got_revision_cp "refs/heads/master@{#574629}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23952}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "ef49be42c92ed17ab5ae4635843eeb4c35737eb5" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "ef49be42c92ed17ab5ae4635843eeb4c35737eb5" bot_update
got_revision_cp "refs/heads/master@{#574629}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23952}" bot_update
swarm_hashes {"android_webview_unittests": "fdbdd21c75f364774f1bbcf0e10680c896e869d1", "angle_unittests": "febce5e77bbbf086a258bbe0730d4c1cd3262bfe", "base_unittests": "df87fe0d6c98cf6481538e50e84ac9ab36d17449", "blink_common_unittests": "5ac65c465dd5ad3b2f7ae1ff20601b54f9229dba", "blink_heap_unittests": "ee00a305b52de21136886fb147b165ef3e9a2426", "blink_platform_unittests": "9d5452cd0c3f4de7d1d226493babbd3d825f0bd3", "boringssl_crypto_tests": "10255c965397060f92020f7e15518ed79b617b89", "boringssl_ssl_tests": "b4c3fdb617596afc62fc0cf793c97d133ff7f9f6", "breakpad_unittests": "adf63551e0533c66512bf7943b68c1882b319bbf", "cacheinvalidation_unittests": "f7b17d2b16d5169f4f559523faad0240aa16a162", "capture_unittests": "5691b96244bc47bb1e0725c6639a4222f1da6d8d", "cast_unittests": "0dd9d45f68bc8c01fd347110197f7106ee687698", "cc_unittests": "1955cb0c05b7eaafb99aed6b32b14ef3c9cf0e60", "chrome_public_test_apk": "78e4885cec7cd53aad7e13b4599a92b2e5021ecb", "chrome_public_test_vr_apk": "82c26ff3737e9912eaef515fffbe84498abfc312", "chrome_sync_shell_test_apk": "e65b5b153b83bcd4df57021e38e8d880cd405430", "components_browsertests": "244b4b43385e54f798dc57f807500c2d9b4b4a8c", "components_unittests": "f94664cccb48fb180ff5941eb967f5166c768743", "content_browsertests": "0ef66bf8333dabbcc2c39b42b4fdde9bdd5ac11f", "content_shell_test_apk": "7678b312a1975e389c14c4a6d5959b4fbb741bfe", "content_unittests": "dafdaebf13bed63d22eee9b375e5cb605548ed4a", "crypto_unittests": "448ee300a08b2079885600c4bd6b445892373920", "device_unittests": "339feadeaff7d6fede4d97984ace1dd0bd78a758", "display_unittests": "b13b2888c641f670ce47f0d35cff034173001baa", "events_unittests": "91f2b5bc986a958875b836e5a3a2e92537c3f7cc", "gcm_unit_tests": "4e9414abf8fc20ffea226b9231cbcf042b88c97b", "gfx_unittests": "9a41ffdd2e2f72729630c1c265832789986d7b19", "gin_unittests": "8961919e12a3ac26ab6ace8a42bbd55a5a6defec", "gl_tests": "f4f298ffe56ec8bd54eddbf3ecb4d8972acb44b5", "gl_unittests": "5d94ad2e49d626dce502007177ae411099ea3e12", "google_apis_unittests": "dd62fc7842b5085d866795c923311d8ad405c68c", "gpu_unittests": "54d1c8df93ef2bc69342de494e87aa08224520bd", "ipc_tests": "3b9afbb187a4a574e66687c7476d35f4344c959b", "jingle_unittests": "0d494dd25ae8ae0a7d9210c13be55455145f8299", "latency_unittests": "293b5ac1fa1faa82a20d40ee119034ecb8297124", "libjingle_xmpp_unittests": "d0e5a26f6746f4d7542d1181372992a6f037c988", "media_blink_unittests": "477a6f9a8ba9f8a453fd70a3abcd097b6d024806", "media_service_unittests": "231e08a82a354e52c13871828df9a80d1f9a0329", "media_unittests": "5f9b18f5525f07247f76bdf531057b9bec432f65", "midi_unittests": "950fc2b8788653b70bb54f1d0b11f0a7839dc907", "mojo_test_apk": "15f9463fb97d26366dc73f473cb64f1df8c4b73e", "mojo_unittests": "53e8f64ee8c36799003ba3365b63dde6c08b05ff", "net_unittests": "3e88961086665048a467683e623c98561b37f0e4", "sandbox_linux_unittests": "02e040486d7337e79195e228b1e1d0bc3c46ce0c", "services_unittests": "32abb0cb4f88ac899f275b8ca99c96d8b67f8e25", "shell_dialogs_unittests": "5c77bf9c41dc272fc9fe241d53e4ea1b7992b1dd", "skia_unittests": "0a8f3dbcae33feb7190ff20e430e9df7a8edb56e", "sql_unittests": "8d4745568e92c9acc92c337385f696ec6194b5e8", "storage_unittests": "1afb18c16812657c7085c2689b050067a4633c64", "ui_android_unittests": "8444b81fdb9e0d9ccd7b0cd8498d845c46353004", "ui_base_unittests": "6b7f026f47d95ea7babee3134fb52a3614bbb27f", "ui_touch_selection_unittests": "fb3485f46969333f2af38d0df360a5ead9d19eff", "unit_tests": "896aed5ab847828ba44192229e0860c402879a4f", "url_unittests": "4d877f04b5e569eff9c1f88ed19086ef4665585b", "viz_unittests": "6db3bca6e5c2d3ba3dfc9c0d5c2032d3b0ccf3f6", "vr_common_unittests": "1a198ad081f22f47867f4b736ba52a6bdba1b3d4", "vr_pixeltests": "f78243003f43577385407210b71eda63d0e598df", "webkit_unit_tests": "10951cd59f1183fecbfb4c2ce1db02da093a8003", "webview_instrumentation_test_apk": "e29bf3ea53b1b150bd6534a998daad882d6f17cc", "wtf_unittests": "2c8ec67cfb60412981a2e375546d7de88214cacf"} find isolated tests

Blamelist:

  1. khmel@google.com (khmelohnoyoudont@google.com)
  2. erikchen (erikchenohnoyoudont@chromium.org)
  3. Mark Pilgrim (pilgrimohnoyoudont@chromium.org)
  4. Takumi Fujimoto (takumifohnoyoudont@chromium.org)
  5. Kyle Horimoto (khorimotoohnoyoudont@google.com)
  6. Ella Ge (eirageohnoyoudont@chromium.org)
  7. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  8. Michael Thiessen (mthiesseohnoyoudont@chromium.org)
  9. Carlos IL (carlosilohnoyoudont@chromium.org)
  10. Mark Pilgrim (pilgrimohnoyoudont@chromium.org)
  11. David Black (dmblackohnoyoudont@google.com)
  12. David Black (dmblackohnoyoudont@google.com)
  13. Peter K. Lee (pklohnoyoudont@chromium.org)
  14. Ian Clelland (iclellandohnoyoudont@chromium.org)
  15. Peter Kvitek (kvitekpohnoyoudont@chromium.org)
  16. Justin Novosad (junovohnoyoudont@chromium.org)
  17. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  18. Kyle Milka (kmilkaohnoyoudont@chromium.org)
  19. Anna Offenwanger (offenwangerohnoyoudont@chromium.org)
  20. Alexandr Ilin (alexilinohnoyoudont@chromium.org)
  21. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  22. David 'Digit' Turner (digitohnoyoudont@google.com)
  23. Peter Wen (wnwenohnoyoudont@chromium.org)
  24. Istiaque Ahmed (lazyboyohnoyoudont@chromium.org)
  25. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  26. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  27. Colin Blundell (blundellohnoyoudont@chromium.org)
  28. Jun Cai (juncaiohnoyoudont@chromium.org)
  29. Etienne Pierre-doray (etiennepohnoyoudont@chromium.org)
  30. Kim Paulhamus (kpaulhamusohnoyoudont@chromium.org)
  31. Eugene But (eugenebutohnoyoudont@google.com)
  32. Sergey Ulanov (sergeyuohnoyoudont@chromium.org)
  33. Becky Zhou (huayinzohnoyoudont@chromium.org)
  34. Nico Weber (thakisohnoyoudont@chromium.org)
  35. David Grogan (dgroganohnoyoudont@chromium.org)
  36. Nick Burris (nburrisohnoyoudont@google.com)
  37. Rayan Kanso (rayankansohnoyoudont@chromium.org)
  38. Mike Reed (reedohnoyoudont@google.com)
  39. Peter E Conn (peconnohnoyoudont@chromium.org)
  40. Peter Kasting (pkastingohnoyoudont@chromium.org)
  41. Takuto Ikuta (tikutaohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 19:43:39 UTC
Start Thursday, 12-Jul-18 19:44:35 UTC
End Thursday, 12-Jul-18 20:49:15 UTC
Pending 55 secs
Execution 1 hrs 4 mins

All Changes:

  1. arc: Remove data on child transition fail.

    Changed by khmel@google.com - khmelohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:54:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef49be42c92ed17ab5ae4635843eeb4c35737eb5

    Comments

    arc: Remove data on child transition fail.
    
    This optionally resets ARC++ container in case child transition fails.
    This shows confirmation dialog and in case user accepts removes data and
    restart ARC++.
    
    TEST=Manually
    BUG=841939
    
    Change-Id: I07ecb1153acab7368f17ac15a957803132d6a101
    Reviewed-on: https://chromium-review.googlesource.com/1132529
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Yury Khmel <khmel@google.com>
    Cr-Commit-Position: refs/heads/master@{#574629}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/browser/chromeos/arc/auth/arc_auth_service.cc
    • chrome/browser/chromeos/arc/auth/arc_auth_service.h
    • chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/app_list/arc/arc_data_removal_dialog.h
    • chrome/browser/ui/browser_dialogs.h
    • chrome/browser/ui/views/arc_data_removal_dialog_view.cc
  2. [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:52:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e0fccc527819cb8e09682bc280fb35d4b3fafdd

    Comments

    [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.
    
    The first CL caused test failures because the browser_test was ignoring the
    "shift" key when searching for menu items. The IDC_SELECT_NEXT_TAB and
    IDC_SELECT_PREVIOUS_TAB only differ by the presence of "shift", so it cannot be
    ignored.
    
    > This matches other macOS application like Safari, Terminal, etc. All existing
    > hotkeys will still work.
    >
    > This CL uses the same hotkey for "previous tab" that Safari and Terminal use,
    > which is [ctr + shift + "Horizontal Tab"]. This also causes tests to pass.
    > However, pressing that key combination actually generates [ctr + shift + "End of
    > Medium"], which renderers in the Main Menu as a backwards tab. This CL updates
    > NSMenuItem(ChromeAdditions) to check for this special case.
    >
    > This CL removes two incorrect DCHECKs from render_widget_host_view_cocoa.mm. I
    > regularly hit both of them when running Chromium on a local build. They both
    > rely on the false assumption that keyEquivalents in the main menu must have the
    > command modifier.
    >
    > Bug: 851714
    > Reviewed-on: https://chromium-review.googlesource.com/1106659
    > Commit-Queue: Erik Chen <erikchen@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574211}
    
    Change-Id: Id87f364f5c5b303e8b9668e79f813a1c23376c98
    TBR: avi@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134203
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574628}

    Changed files

    • chrome/app/nibs/MainMenu.xib
    • chrome/browser/global_keyboard_shortcuts_mac.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
    • content/browser/renderer_host/render_widget_host_view_cocoa.mm
    • ui/events/test/cocoa_test_event_utils.mm
  3. Migrate AffiliationFetcher to SimpleURLLoader

    Changed by Mark Pilgrim - pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:48:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 176a3a3154870bc3e0722934c03d6dc3b5dae748

    Comments

    Migrate AffiliationFetcher to SimpleURLLoader
    
    Bug: 844947
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I08b3921d4a6e8ad2489a175cea5a5b883af32bbb
    Reviewed-on: https://chromium-review.googlesource.com/1129322
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574627}

    Changed files

    • chrome/browser/password_manager/password_store_factory.cc
    • components/password_manager/core/browser/BUILD.gn
    • components/password_manager/core/browser/DEPS
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.h
    • components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.h
    • components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/test_affiliation_fetcher_factory.h
    • components/password_manager/core/browser/password_store_factory_util.cc
    • components/password_manager/core/browser/password_store_factory_util.h
    • ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
  4. Fix a crash in MediaRouterDialogControllerViews

    Changed by Takumi Fujimoto - takumifohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:44:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ebcff160836f5c7057cad3694d19e7237475c26

    Comments

    Fix a crash in MediaRouterDialogControllerViews
    
    When trying to show the Views Cast Dialog, abort if a browser instance
    for the initiator WebContents is not found.
    
    Bug: 862671
    Change-Id: I00fd25490f8790624e87d2f77c9bfc8b95f59403
    Reviewed-on: https://chromium-review.googlesource.com/1134043
    Reviewed-by: Derek Cheng <imcheng@chromium.org>
    Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574626}

    Changed files

    • chrome/browser/ui/views/media_router/media_router_dialog_controller_views.cc
  5. [CrOS MultiDevice] Improve logging performance.

    Changed by Kyle Horimoto - khorimotoohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f39a6efa39053b51201f6c601a43955a5dd58a5f

    Comments

    [CrOS MultiDevice] Improve logging performance.
    
    Previously std::stringstream::str() was called twice, which generates
    two distinct (but identical) strings. This CL caches the result of the
    call and uses it twice.
    
    Bug: 862725
    Change-Id: I0384981a259b12d6c3ecf1420436f71e1e002fe6
    Reviewed-on: https://chromium-review.googlesource.com/1134218
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574625}

    Changed files

    • chromeos/components/proximity_auth/logging/logging.cc
  6. update hoverable pointerevent wpt

    Changed by Ella Ge - eirageohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:39:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df94a28e9988135e91dc8d0d841864344b7cde7c

    Comments

    update hoverable pointerevent wpt
    
    Update test wpt/pointerevent_attributes_hoverable_pointers
    
    This test was failing occationally on manual test, when we have
    clientX == box.right or clientY == box.bottom.
    update the test assertion so coordinates on border can be consider
    inside box.
    
    Note that on right border can also be outside box for the mouseevents.
    because we truncate the coordinates into interger.
    
    Bug: 863029
    Change-Id: Id20fbe0b6cf8566e6cdee229f427a0c747ed0c0a
    Reviewed-on: https://chromium-review.googlesource.com/1135432
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574624}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_attributes_hoverable_pointers-manual.html
  7. Reland "Fix OOPIF hit testing in layout tests."

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:38:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c09ebfd64bd9d402997f4c1ab5624d95347e2245

    Comments

    Reland "Fix OOPIF hit testing in layout tests."
    
    This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    
    The revert of this CL was determined to be the cause of some flaky tests
    on the chromeos bot. However those tests are disabled on linux and
    have been flaky on chromeos for a long time. See
    https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&builder=chromium.chromiumos%3Alinux-chromeos-rel&sortOrder=forward&sortColumn=test
    
    Original change's description:
    > Fix OOPIF hit testing in layout tests.
    >
    > If we haven't received an activated surface yet ensure that we fallback
    > to querying the renderer for the target of input events.
    >
    > BUG=601584
    >
    > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
    > Reviewed-on: https://chromium-review.googlesource.com/1131219
    > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573789}
    
    TBR=kenrb@chromium.org
    
    Bug: 601584
    Change-Id: Ifdd26f20bf6d44e704c33a7b7c4380a2de8c3696
    Reviewed-on: https://chromium-review.googlesource.com/1135471
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574623}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  8. Merge vr_shell/ Java namespace into vr/ namespace.

    Changed by Michael Thiessen - mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:35:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbe916af89d21e6e4be335879b819bf3efaf8353

    Comments

    Merge vr_shell/ Java namespace into vr/ namespace.
    
    Bug: 862741
    
    NOPRESUBMIT=true
    TBR=yusufo@chromium.org
    
    Change-Id: If26bb6664b6b882db33327d381ccac6594d5ef65
    Reviewed-on: https://chromium-review.googlesource.com/1134091
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574622}

    Changed files

    • WATCHLISTS
    • base/android/jni_generator/jni_exception_list.gni
    • chrome/android/BUILD.gn
    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
    • chrome/android/java/src/org/chromium/chrome/browser/NavigationBarColorController.java
    • chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidUiGestureTarget.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidVSyncHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/EmptySniffingVrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/NoopCanvas.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnDispatchTouchEventCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnExitVrRequestListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VR_JAVA_OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrAlertDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCancelAnimationActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapperImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCompositorSurfaceManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreInfo.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionChecker.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionCheckerImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApi.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApiImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialogManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFeedbackStatus.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrInputConnection.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrMainActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrModalPresenter.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrPopupWindow.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToast.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToastManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrUiWidgetFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrWindowAndroid.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/BuildConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/GvrKeyboardLoaderClient.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/TextEditAction.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/VrInputMethodManagerWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/EmulatedVrController.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrFeedbackInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrInstallUpdateInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellCompositorViewHolderTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellControllerInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellDialogTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNativeUiTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNavigationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellWebInputEditingTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrDeviceTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTabTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockBrowserKeyboardInterface.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrCoreVersionCheckerImpl.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrDaydreamApi.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/AndroidManifest.xml
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/SimNfcActivity.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/HeadTrackingMode.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestriction.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestrictionRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/HeadTrackingUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NativeUiUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NfcSimUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/TransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrInfoBarUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrShellDelegateUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/vr_test_framework.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/browser/android/vr/BUILD.gn
    • chrome/browser/android/vr/vr_core_info.h
    • chrome/browser/android/vr/vr_shell_delegate.h
    • chrome/browser/vr/metrics/session_metrics_helper.h
    • chrome/browser/vr/test/vr_xr_browser_test.h
    • chrome/browser/vr/text_edit_action.h
    • chrome/browser/vr/ui_test_input.h
    • chrome/browser/vr/ui_unsupported_mode.h
    • chrome/browser/vr/webvr_input_browser_test.cc
    • chrome/browser/vr/webvr_tab_browser_test.cc
    • chrome/browser/vr/webvr_transition_browser_test.cc
    • chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeJUnit4ClassRunner.java
    • tools/perf/contrib/vr_benchmarks/vr_browsing_mode_pages.py
  9. Changed committed-interstitials flag from switch to feature.

    Changed by Carlos IL - carlosilohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49040ae795592d3b0c6a5b03533565caeb9ae266

    Comments

    Changed committed-interstitials flag from switch to feature.
    
    Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
    base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
    doing separate rampups for each kind of committed interstitial. Switch was
    changed to Feature so that it can be enabled via variations.
    
    Bug: 755632
    Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
    Reviewed-on: https://chromium-review.googlesource.com/1118975
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574621}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
    • chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
    • chrome/browser/ssl/connection_help_tab_helper.cc
    • chrome/browser/ssl/connection_help_tab_helper_browsertest.cc
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest_util.cc
    • chrome/browser/ssl/ssl_error_controller_client.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
    • chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
    • tools/metrics/histograms/enums.xml
  10. Migrate captive_portal to BindOnce

    Changed by Mark Pilgrim - pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:31:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dc10fe1b9fb22e9c1fb5a412b8440ba873866cf

    Comments

    Migrate captive_portal to BindOnce
    
    Bug: 714018
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia2bf1a8fa963f7540272a0d28961bfc961f14dd0
    Reviewed-on: https://chromium-review.googlesource.com/1131994
    Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574620}

    Changed files

    • chrome/browser/captive_portal/captive_portal_service.cc
    • components/captive_portal/captive_portal_detector.cc
    • components/captive_portal/captive_portal_detector.h
    • components/captive_portal/captive_portal_detector_unittest.cc
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.h
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.mm
  11. Removes Assistant horizontal page.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:30:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3753827af78b5c5e3f458acaf9017c1afd082459

    Comments

    Removes Assistant horizontal page.
    
    No longer needed.
    
    Bug: b:111315529
    Change-Id: Ic16af0891a296a535d67c46d43bc63eb86f6f6f1
    Reviewed-on: https://chromium-review.googlesource.com/1132347
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574619}

    Changed files

    • ash/app_list/BUILD.gn
    • ash/app_list/views/assistant_container_view.cc
    • ash/app_list/views/assistant_container_view.h
    • ash/app_list/views/horizontal_page_container.cc
    • ash/app_list/views/horizontal_page_container.h
  12. Adds caption bar to AssistantWebView UI.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:25:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 633097c22fed7171c82aabd1a3d001aab4510c78

    Comments

    Adds caption bar to AssistantWebView UI.
    
    In addition, this CL:
    - Adds a back button to the caption bar.
    - Adds API to change caption button visibility.
    
    Known issue:
    When navigating back from AssistantWebView UI, the Assistant
    container should not shrink. This is tracked in b/110433519.
    
    See bug for demo.
    
    Bug: b:111009446
    Change-Id: I63b47337d7ffcc8861c36529d04e9139800f4f4b
    Reviewed-on: https://chromium-review.googlesource.com/1132298
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#574618}

    Changed files

    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/ui/assistant_main_view.cc
    • ash/assistant/ui/assistant_web_view.cc
    • ash/assistant/ui/assistant_web_view.h
    • ash/assistant/ui/caption_bar.cc
    • ash/assistant/ui/caption_bar.h
    • ash/assistant/util/deep_link_util.cc
  13. [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895

    Changed by Peter K. Lee - pklohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:23:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f873a34ef2a72ed5d6bfcad35f5317c259d25fc7

    Comments

    [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895
    
    Added MDCShapedView.
    
    Bug: 863001
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ibfdc8430ff9d3f184eac341cd8d6fdf1fe5041d2
    Reviewed-on: https://chromium-review.googlesource.com/1135191
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574617}

    Changed files

    • DEPS
    • ios/third_party/material_components_ios/BUILD.gn
  14. Finish renaming "whitelist" to "allowlist".

    Changed by Ian Clelland - iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:17:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a27b817c70dec1ea68f4ea4b8711697ca694fb62

    Comments

    Finish renaming "whitelist" to "allowlist".
    
    Bug: 822317
    Change-Id: I155df06759c529dbd3183530c4722be3c4e0feb1
    Reviewed-on: https://chromium-review.googlesource.com/1133308
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574616}

    Changed files

    • content/browser/frame_host/render_frame_host_feature_policy_unittest.cc
    • third_party/blink/public/mojom/feature_policy/feature_policy.mojom
    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/feature_policy/feature_policy.h
  15. Separated harness and target page base urls.

    Changed by Peter Kvitek - kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2eb30bfc9ba51a4ac3a4f28bf2c728c3252620d

    Comments

    Separated harness and target page base urls.
    
    Change-Id: Ie6b2097fd8c03b486c2cab8ec3357a8c55907e92
    Reviewed-on: https://chromium-review.googlesource.com/1134498
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574615}

    Changed files

    • headless/test/data/protocol/inspector-protocol-test.html
    • headless/test/headless_protocol_browsertest.cc
    • third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
  16. Refactor canvas code to centralize CanvasResourceProvider ownership

    Changed by Justin Novosad - junovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8b8872f2080130c2b5bdf026f32f46aad7598da

    Comments

    Refactor canvas code to centralize CanvasResourceProvider ownership
    
    With this change, CanvasResourceProvider is always owned
    by CanvasResourceHost, except for a a few special case that use
    ephemeral resource providers.  This is a step towards unifying
    canvas and OffscreenCanvas presentation code paths.
    
    BUG=788439
    TBR=fserb@chromium.org, zmo@chromium.org
    NOTRY=true
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Id9bdbb2c3e93b264f67946b887419b47599df65d
    Reviewed-on: https://chromium-review.googlesource.com/1134182
    Commit-Queue: Justin Novosad <junov@chromium.org>
    Reviewed-by: Justin Novosad <junov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574614}

    Changed files

    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.h
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
    • third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
    • third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
    • third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.cc
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.h
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h
  17. Deflake resource loading hints and previews browsertest

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:14:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a875a2ea21d8a321295a11440c80af01bcf7fa86

    Comments

    Deflake resource loading hints and previews browsertest
    
    Attempt to deflake resource loading hints and previews
    browsertest by waiting for hints to be processed.
    
    Currently, the hints are processed on the background thread,
    and so may not be processed immediately.
    
    Log from the failed Linux test bots seem to indicate that
    the hints are not processed in time.
    See http://shortn/_IjBGHDP2Rp
    
    Bug: 789542,831838
    Change-Id: I6b30b1a86dc5d2cdef1cd8274cf5c6088bec8634
    Reviewed-on: https://chromium-review.googlesource.com/1134598
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574613}

    Changed files

    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  18. [NTP] Anchor custom backgrounds to the center of the window

    Changed by Kyle Milka - kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06072d0984b80b680e26ed0f498911ef35800af2

    Comments

    [NTP] Anchor custom backgrounds to the center of the window
    
    Bug: 862789
    Change-Id: Ia23e75d07d738e02571010aaf9cbd0a1bc486060
    Reviewed-on: https://chromium-review.googlesource.com/1134435
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574612}

    Changed files

    • chrome/renderer/searchbox/searchbox_extension.cc
  19. Modify XRSession so that session geometry is only sent when it changes

    Changed by Anna Offenwanger - offenwangerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a32f749ecae1923fda1485aa423b8e46dafddcf

    Comments

    Modify XRSession so that session geometry is only sent when it changes
    
    Making it so that instead of receiving geometry every frame, ar_core
    only gets geometry (frame size and rotation) when it changes. This saves
    some processing every frame, and allows the GetFrameData interface to be
    made uniform for AR and VR.
    
    Bug: 856259,846521
    Change-Id: I5828f57e1292f932c68148ac1e6b898f966b8d00
    Reviewed-on: https://chromium-review.googlesource.com/1115776
    Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Klaus Weidner <klausw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574611}

    Changed files

    • chrome/browser/android/vr/arcore_device/arcore_device.cc
    • chrome/browser/android/vr/arcore_device/arcore_device.h
    • chrome/browser/android/vr/arcore_device/arcore_gl.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl.h
    • device/vr/vr_device_base.cc
    • device/vr/vr_device_base.h
    • device/vr/vr_display_impl.cc
    • device/vr/vr_display_impl.h
    • third_party/blink/renderer/modules/xr/xr_frame_provider.cc
    • third_party/blink/renderer/modules/xr/xr_frame_provider.h
    • third_party/blink/renderer/modules/xr/xr_session.cc
    • third_party/blink/renderer/modules/xr/xr_session.h
  20. Allow WritableSharedMemoryRegion to Unsafe conversion

    Changed by Alexandr Ilin - alexilinohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:08:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecfbde9b593ca7f497375f56da8d076eb29772fa

    Comments

    Allow WritableSharedMemoryRegion to Unsafe conversion
    
    This CL adds a new ConvertToUnsafe() method to the WritableSharedMemoryRegion
    class. This new method is similar to ConvertToReadOnly() in structure. The
    conversion does not modify an underlying platform handle (except it closes a
    read-only handle on POSIX) but changes region's type.
    
    Bug: 795291
    Change-Id: Ie0a6b4c9850c0e223ee9299655f9bfd6c79c383b
    Reviewed-on: https://chromium-review.googlesource.com/985981
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574610}

    Changed files

    • base/memory/platform_shared_memory_region.h
    • base/memory/platform_shared_memory_region_android.cc
    • base/memory/platform_shared_memory_region_fuchsia.cc
    • base/memory/platform_shared_memory_region_mac.cc
    • base/memory/platform_shared_memory_region_posix.cc
    • base/memory/platform_shared_memory_region_unittest.cc
    • base/memory/platform_shared_memory_region_win.cc
    • base/memory/writable_shared_memory_region.cc
    • base/memory/writable_shared_memory_region.h
  21. [Background Fetch] Deserialize icon from metadata on browser restart.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:07:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0f9d40078cf7c016aeefb8a0aba4c498ed86aba

    Comments

    [Background Fetch] Deserialize icon from metadata on browser restart.
    
    Bug: 855789
    Change-Id: Ida29d5cbf111838c9bf8bc2639dddf7509169199
    Reviewed-on: https://chromium-review.googlesource.com/1128965
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574609}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.h
  22. android: Update bundletool binary to 0.5.0

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:07:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc6d74d7b8c120d3d8d90ab8c68c5285e384a7f8

    Comments

    android: Update bundletool binary to 0.5.0
    
    This release contains a bugfix required to generate Android
    app bundle APKs archives that can be installed on all devices.
    
    For more context, see:
    https://buganizer.corp.google.com/issues/110777526
    
    BUG=846633,820459
    R=agrieve@chromium.org, bensmason@chromium.org, yfriedman@chromium.org
    
    Change-Id: Ic71445f49a4548c8610f5d18598cdd3d3d5692c4
    Reviewed-on: https://chromium-review.googlesource.com/1135127
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: David Turner <digit@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574608}

    Changed files

    • DEPS
    • build/android/gyp/bundletool.py
    • third_party/android_build_tools/bundletool/README.chromium
  23. Android: Fix jinja template deps

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:05:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 001fc64fc2945bb7b18e6ffb20b6048c007ac6b8

    Comments

    Android: Fix jinja template deps
    
    Temporarily add missing deps to the depfile. Will no longer be necessary
    once all downstream targets are fixed.
    
    Bug: 843562
    Change-Id: Id797ea032a6a3818dac6013dcacb6f68baef2b6b
    Reviewed-on: https://chromium-review.googlesource.com/1134884
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574607}

    Changed files

    • build/android/gyp/jinja_template.py
  24. [Extensions] Remove linked_ptr usage from extension_messages.cc

    Changed by Istiaque Ahmed - lazyboyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:59:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision abb887f1fe0523ed4ab633530a3a55fd3e479731

    Comments

    [Extensions] Remove linked_ptr usage from extension_messages.cc
    
    This CL also makes ExtensionMsg_Load_Params non-copyable. There
    shouldn't be any behavior change in this CL.
    
    Bug: 556939
    Change-Id: If7d11919f8fee0442578371d44d6b715d08efe3a
    Reviewed-on: https://chromium-review.googlesource.com/1132572
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574606}

    Changed files

    • extensions/browser/renderer_startup_helper.cc
    • extensions/common/extension_messages.cc
    • extensions/common/extension_messages.h
    • extensions/common/extension_messages_unittest.cc
  25. Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 16:57:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cae26c020606a88289e746e446999dd9c101019d

    Comments

    Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/58c79f66dd3a..798ee75d2365
    
    
    git log 58c79f66dd3a..798ee75d2365 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 kthelgason@webrtc.org Always disable RED when ULPFEC is disabled.
    2018-07-12 hta@webrtc.org Buffer ICE candidates that can't be added immediately.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@798ee75d2365
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ia3faf57f19146a8b08a9a5cbe8915a9750b91210
    Reviewed-on: https://chromium-review.googlesource.com/1135226
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574605}

    Changed files

    • DEPS
  26. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc

    Comments

    [unified-consent] Add unity logic to OneClickSigninSyncStarter
    
    All unified consent services are enabled when the unified
    consent is given through the OneClickSigninSyncStarter.
    
    Bug: 862202
    Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
    Reviewed-on: https://chromium-review.googlesource.com/1135001
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h
  27. Revert "Have Device Service observe MessageLoop destruction"

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"
    
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.
    
    Bug: 856771, 794105
    
    Original change's description:
    > Have Device Service observe MessageLoop destruction
    >
    > The Device Service needs to clean up parts of its internal state as part
    > of browser shutdown. However, it also needs to run on the UI thread,
    > and embedded services that run on the UI thread are not guaranteed to
    > be destroyed as part of browser shutdown (tasks to destroy these
    > services are posted from the IO thread by
    > ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
    > typically shut down before these posted tasks are run).
    >
    > To solve this issue we discussed adding plumbing wherein embedded
    > services could inform //content that they wanted to be notified when
    > shutdown was occurring on the main thread. However, on investigation
    > this plumbing would be painful to implement: it is only
    > EmbeddedInstanceManager that has direct information of these service
    > instances, and that object lives far away from //content's
    > ServiceManagerContext, the object that knows when shutdown is occurring
    > on the main thread.
    >
    > This CL takes an alternative approach of having the Device Service
    > implementation observe the destruction of its MessageLoop. I have
    > verified that the observation is triggered on shutdown of Chrome.
    >
    > Bug: 794105
    > Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
    > Reviewed-on: https://chromium-review.googlesource.com/1099245
    > Commit-Queue: Colin Blundell <blundell@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    
    TBR=rockot@chromium.org,blundell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h
  28. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented
    
    This is a follow-up CL per comments at:
    https://chromium-review.googlesource.com/c/chromium/src/+/1120955
    
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc
  29. [Autofill]: Create a policy flag for AutofillProfileEnabled.

    Changed by Etienne Pierre-doray - etiennepohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:50:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b27097af312f3f4a4ee22bf0ea2c65239de03ff

    Comments

    [Autofill]: Create a policy flag for AutofillProfileEnabled.
    
    AutofillProfileEnabled was added as a preference setting in 1127344.
    This CL creates a policy flag for AutofillProfileEnabled that can
    overwrite the user preference.
    
    Bug: 860526
    Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
    Reviewed-on: https://chromium-review.googlesource.com/1127463
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Reviewed-by: Drew Wilson <atwilson@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574601}

    Changed files

    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/test/data/policy/policy_test_cases.json
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_profile_policy_handler.cc
    • components/autofill/core/browser/autofill_profile_policy_handler.h
    • components/autofill/core/browser/autofill_profile_policy_handler_unittest.cc
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  30. Mark window-focus-self as flaky on Win10

    Changed by Kim Paulhamus - kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:49:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7be9cc2e39f872aeb8e03afb7d0aabf92ffde03

    Comments

    Mark window-focus-self as flaky on Win10
    
    Tbr: tkent@chromium.org
    Bug: 863067
    Change-Id: I9f043eec8363dbb26ccaa8d901321e0d579f1a4f
    Reviewed-on: https://chromium-review.googlesource.com/1135433
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574600}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  31. Add testDownloadWhileBrowsing EG test.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:48:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cce6875386037980e3245c630a9b9bac926f91e

    Comments

    Add testDownloadWhileBrowsing EG test.
    
    After tapping Download this test opens a separate tabs and loads the URL
    there. Then closes the tab and waits for the download completion.
    
    Bug: 854232
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id05c9344d1da80a57b6c7cc663b2b8a835f18e82
    Reviewed-on: https://chromium-review.googlesource.com/1111916
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574599}

    Changed files

    • ios/chrome/browser/ui/download/BUILD.gn
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/test/BUILD.gn
    • ios/chrome/test/scoped_eg_synchronization_disabler.h
  32. [Fuchsia] Address CR comments in sys::Runner implementation

    Changed by Sergey Ulanov - sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:39:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c234b0272dff6ce746e9eaac813497986913c3

    Comments

    [Fuchsia] Address CR comments in sys::Runner implementation
    
    When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
    prematurely and landed the change without my changes that addresed
    review comments. Landing them separately.
    
    Bug: 856416
    Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
    Reviewed-on: https://chromium-review.googlesource.com/1133968
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574598}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/app/component_controller_impl.cc
    • webrunner/app/component_controller_impl.h
    • webrunner/app/main.cc
    • webrunner/app/web_content_runner.cc
    • webrunner/app/web_content_runner.h
  33. [Feed] Scroll and focus handling for the FeedNewTabPage

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:36:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54d1975f16b7efae2408a1428fbde7207556a29

    Comments

    [Feed] Scroll and focus handling for the FeedNewTabPage
    
    + Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
    + Refactor snap scroll logic to a new class to make it reusable
    + Add top padding for the FeedNewTabPage to display correctly on tablet
    + Fix a small bug that search box is not enabled after auto snap scroll
    
    Bug: 860028, 860032, 862470
    Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
    Reviewed-on: https://chromium-review.googlesource.com/1133594
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574597}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
  34. Remove most android-specific hard_timeout and shard overrides.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a64d6771d8b24f079f24e41ebaf14f672747084

    Comments

    Remove most android-specific hard_timeout and shard overrides.
    
    These were added during android swarming bring-up.  We shouldn't use
    per-bot exceptions for this.
    
    Also remove a random sharding setting for base_unittests on ToTMac
    that doesn't look necessary.
    
    Bug: 843511
    Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
    Reviewed-on: https://chromium-review.googlesource.com/1134531
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574596}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.swarm.json
    • testing/buildbot/test_suite_exceptions.pyl
  35. [css-tables] Make table's max-content honor captions' min-content

    Changed by David Grogan - dgroganohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dff5931455e0302289a3cc9027fd3f98cfe22fca

    Comments

    [css-tables] Make table's max-content honor captions' min-content
    
    Table's min-content already honored it.
    
    We'd apparently never been bitten before by tables occasionally having
    min-content > max-content. A new DCHECK in LayoutNG exposed it.
    
    Bug: 857185
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
    Reviewed-on: https://chromium-review.googlesource.com/1121251
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574595}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/table/caption-min-greater-than-max-crash.html
    • third_party/WebKit/LayoutTests/fast/table/spans-min-greater-than-max-crash.html
    • third_party/blink/renderer/core/layout/layout_table.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  36. Settings WebUI: Fix extensions url on cleanup result page

    Changed by Nick Burris - nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  37. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by Rayan Kanso - rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  38. suppress until skia roll

    Changed by Mike Reed - reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  39. 🤝 Add flag to force showing TWA disclosure.

    Changed by Peter E Conn - peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  40. Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b2b9af8ace2bbc3384147241601d4293f0c2259

    Comments

    Once TabStrip doesn't need it, there's no reason to expose GetTopOffset().
    
    Bug: none
    Change-Id: Ia78dd54f4364e7010ddf3ce16b01e5f5f3c764e4
    Reviewed-on: https://chromium-review.googlesource.com/1134499
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574590}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
  41. Keep timestamp in aar.py when file is not changed

    Changed by Takuto Ikuta - tikutaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:22:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d186e03f89aa3fa40dc7266cbc33a0310ac3dd8

    Comments

    Keep timestamp in aar.py when file is not changed
    
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1127565
    I didn't understand filecmp.dircmp.
    
    Changed to use md5_check.CallAndRecordIfStale instead.
    Also let ExtractAll create directory even when it is empty.
    
    Bug: 810298, 860251
    Change-Id: I0d1e2e385ff1a12981473ef422099f638ca174cf
    Reviewed-on: https://chromium-review.googlesource.com/1132818
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574589}

    Changed files

    • build/android/gyp/aar.py
    • build/android/gyp/util/build_utils.py