Home | Search | chromium - Builders
Login

Builder Marshmallow 64 bit Tester Build 22674 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision7dcd444b288c6dc6237db97575abc35e4e4d81ce
Got Revision7dcd444b288c6dc6237db97575abc35e4e4d81ce

Execution:

Steps and Logfiles:

Show:
  1. ( 323 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) remove .cipd
  3. ( 2 mins 29 secs ) bot_update
    [131GB/295GB used (44%)]
  4. ( 0 ) ensure_goma
  5. ( 585 ms ) swarming.py --version
    0.13
  6. ( 47 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 4 secs ) clean local files
  9. ( 1 secs ) tree truth steps
  10. ( 5 secs ) build directory
  11. ( 28 mins 47 secs ) extract build
  12. ( 6 secs ) find isolated tests
  13. ( 0 ) test_pre_run
  14. ( 38 secs ) android_webview_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:58.567450
  15. ( 6 secs ) angle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:09.841850
  16. ( 2 mins 2 secs ) base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:09.720730
  17. ( 2 secs ) blink_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  18. ( 2 secs ) blink_heap_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:14.235530
  19. ( 4 secs ) blink_platform_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:12.279600
  20. ( 3 secs ) boringssl_crypto_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:56.749160
  21. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 52s
  22. ( 2 secs ) breakpad_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 27s
  23. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 41s
  24. ( 2 secs ) capture_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:26.719450
  25. ( 2 secs ) cast_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 51s
  26. ( 5 secs ) cc_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:35.933240
  27. ( 10 mins 53 secs ) chrome_public_test_apk on Android device Nexus 5X (experimental)
    Run on OS: 'Android'
    Max shard duration: 0:15:18.957220 (shard #0)
    Min shard duration: 0:12:24.936580 (shard #7)
  28. ( 3 secs ) chrome_public_test_vr_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:14:10.934560
  29. ( 2 secs ) chrome_sync_shell_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:07:49.295160
  30. ( 2 secs ) components_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:20.826290
  31. ( 14 secs ) components_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:14:23.138250 (shard #0)
    Min shard duration: 0:11:39.108420 (shard #1)
  32. ( 11 secs ) content_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:14:42.567660 (shard #4)
    Min shard duration: 0:12:22.897070 (shard #2)
  33. ( 3 secs ) content_shell_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:09:29.501140 (shard #2)
    Min shard duration: 0:07:32.002770 (shard #1)
  34. ( 7 secs ) content_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:06:20.558780 (shard #0)
    Min shard duration: 0:05:46.660590 (shard #1)
  35. ( 2 secs ) crypto_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 41s
  36. ( 2 secs ) device_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:23.592750
  37. ( 2 secs ) display_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 44s
  38. ( 2 secs ) events_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:46.871130
  39. ( 2 secs ) gcm_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:08.844660
  40. ( 5 secs ) gfx_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:09.733420
  41. ( 2 secs ) gin_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  42. ( 2 secs ) gl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:05.189860
  43. ( 2 secs ) gl_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  44. ( 2 secs ) google_apis_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:10.465050
  45. ( 5 secs ) gpu_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:57.911710
  46. ( 2 secs ) ipc_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  47. ( 2 secs ) jingle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:06.918430
  48. ( 2 secs ) latency_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  49. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 51s
  50. ( 3 secs ) media_blink_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:16.235090
  51. ( 2 secs ) media_service_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:08.651170
  52. ( 6 secs ) media_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:05:34.510410
  53. ( 2 secs ) midi_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 41s
  54. ( 2 secs ) mojo_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:30.949670
  55. ( 3 secs ) mojo_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:49.652840
  56. ( 36 secs ) net_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:11:19.515210 (shard #1)
    Min shard duration: 0:09:56.754770 (shard #2)
  57. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 25s
  58. ( 3 secs ) services_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:59.312670
  59. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 47s
  60. ( 2 secs ) skia_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 51s
  61. ( 2 secs ) sql_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  62. ( 3 secs ) storage_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:51.791890
  63. ( 2 secs ) ui_android_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 53s
  64. ( 2 secs ) ui_base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:12.285410
  65. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 43s
  66. ( 7 secs ) unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:14:23.539440 (shard #0)
    Min shard duration: 0:10:39.469300 (shard #1)
  67. ( 2 secs ) url_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  68. ( 2 secs ) viz_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:15.632380
  69. ( 2 secs ) vr_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:56.284990
  70. ( 2 secs ) vr_pixeltests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:56.475590
  71. ( 10 secs ) webkit_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:17:05.638240
  72. ( 6 secs ) webview_instrumentation_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:09:10.234050 (shard #4)
    Min shard duration: 0:07:25.932640 (shard #0)
  73. ( 2 secs ) wtf_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 58s
  74. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 93
    Total runtime: 9:25:22.172060
     
  75. ( 848 ms ) test_report
  76. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm970-c4" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531407397606020, "id": "8941196672605789152", "project": "chromium", "tags": ["builder:Marshmallow 64 bit Tester", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/7dcd444b288c6dc6237db97575abc35e4e4d81ce", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm64 Builder (dbg)", "parent_buildnumber:31823", "scheduler_invocation_id:9106626734688943904", "scheduler_job_id:chromium/Marshmallow 64 bit Tester", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Marshmallow 64 bit Tester" setup_build
buildnumber 22674 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm64 Builder (dbg)" setup_build
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" setup_build
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" setup_build
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" setup_build
parent_got_revision "7dcd444b288c6dc6237db97575abc35e4e4d81ce" setup_build
parent_got_revision_cp "refs/heads/master@{#574548}" setup_build
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" setup_build
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" setup_build
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" setup_build
parent_got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#23950}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "7dcd444b288c6dc6237db97575abc35e4e4d81ce" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "7dcd444b288c6dc6237db97575abc35e4e4d81ce" bot_update
got_revision_cp "refs/heads/master@{#574548}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes {"android_webview_unittests": "d97b27c38b87315c47e7291d1103c19165ac9e69", "angle_unittests": "77932599ba11affae28003593c031956173d98b2", "base_unittests": "42024000e254cf6f0586358c771504d68280c0ac", "blink_common_unittests": "8882114132c35987844af5b287608527e5d4a907", "blink_heap_unittests": "b44b88341b4a181e960ae56fdf1718cc63bb1d79", "blink_platform_unittests": "d3166e176f127b3a42e671ab5c8d40379bd5a72b", "boringssl_crypto_tests": "90affe09b2078c9b8ea220413f37a264fdf3d70b", "boringssl_ssl_tests": "b91084f11b383643ec2b893f44e5b1222f87b754", "breakpad_unittests": "bd1bb2693b5782df3f98d72ee1c00244e169df63", "cacheinvalidation_unittests": "30f08533a863b9da5c508b7f8983c042df0878d7", "capture_unittests": "61a3e75971993dd3e6e3333ab41f555eea014518", "cast_unittests": "626d4bf2e58b1593de035c206fc717048367db0e", "cc_unittests": "8caff299eed084af1cddc86a793a1f8d1d0f07e9", "chrome_public_test_apk": "2d92332679aab610a3c88e0787766cfa8219a606", "chrome_public_test_vr_apk": "5078792104a5c01d46a41c69aac27bb44c739c00", "chrome_sync_shell_test_apk": "9a8fb1e51153581d2172aaa7cbde79592b2fd2f6", "components_browsertests": "192477f1413841551f3f7f0a2492d4d308c98d22", "components_unittests": "2c7e04d47a819851dcff6f37acab8fcb9fb1376a", "content_browsertests": "1c94fee5f3deca354d055954a2ff26ec7f14d5b4", "content_shell_test_apk": "6f7ff147b1cd1f83a4d439c41c3ff7855523fe44", "content_unittests": "612b982239da9a815784016e6273a451531acd39", "crypto_unittests": "c9d61a8d7a7379b77d8b9fa8247ee1f49bc974b8", "device_unittests": "c8e70f2fdb32b6f6adcb61cea56ea6d655535f48", "display_unittests": "637471cc2ca9cdc7e2a63c1a491314e16871c1c4", "events_unittests": "7dab8d82aea2007f73f6d7ef03cb285880798a4e", "gcm_unit_tests": "8ec9fe0af21f1ba333e1010f40a0a4e6f6c81f5b", "gfx_unittests": "c47e4008ff3a8a54a3d764353623cca63cf6d6c4", "gin_unittests": "d1dddb2036ba5776c3bfbbe36e2e0f86d2696171", "gl_tests": "80fd60b09025bdbd9a2a05200d8380cc17238fde", "gl_unittests": "023da8fd1eefb14836e8fe1e588398d8045d10d1", "google_apis_unittests": "d4482c54562568137ae986deeeca4a43930a67a3", "gpu_unittests": "5fb03ef4ebbc56b80f73972fca5bb98fca08ebf2", "ipc_tests": "66fde598bd5f043f0e173ada6c7010374faf5199", "jingle_unittests": "c15d7edf5cf6b4618b00af9be23e057535c6993c", "latency_unittests": "e9a848d0fee4f6bdf295d372bc0d18fc67e2acb8", "libjingle_xmpp_unittests": "11456a4a8e0a9c35b93a863dd385f80f87cc6cb9", "media_blink_unittests": "0ff71d44e82c433cf9a8f229b2abe09f4436ac6e", "media_service_unittests": "d31e82861ea9813d1c21abf9ab8db674000a3244", "media_unittests": "e8d65e6c439b027156fddcdb81df132b04e35673", "midi_unittests": "1db91250aca4fa76b2fac81db9f08c7540fa137e", "mojo_test_apk": "74a3a31bfbe2e78657455ed8b6c6a6c83618d656", "mojo_unittests": "703a43ad352cd8daea19bbfb3327a5d0f5b310dc", "net_unittests": "646ab869d165db340f96465df535cbf77f75065f", "sandbox_linux_unittests": "356c492745d718d89479327cef0222c5c5ea832d", "services_unittests": "37422da42834a1dd9142e81e06cfaad340f23f4f", "shell_dialogs_unittests": "fe71677b93deed3ae5eb02f3afc567edda0c64a6", "skia_unittests": "3236ce9435063fdb08ef036e5ad903f46149f564", "sql_unittests": "c293740aca64ddc2bf12443f90ea8b193bd05da9", "storage_unittests": "0834f74d6aa1eec08ebc164be5285a51f0287ef0", "ui_android_unittests": "043b574ce05b2402766d4c22259b178c73695ab2", "ui_base_unittests": "6d52f46335df15a433f3f5910898491e8342f306", "ui_touch_selection_unittests": "7c7733acdc8fe4a3196dfde99e8b7889bdd048c9", "unit_tests": "d308970fd56a7d8059701e859b0b3e8008e13f82", "url_unittests": "7df1d3948e6064a3e54b3c3fa2f5637b6d3e54e7", "viz_unittests": "18164be6291bcee72e539fe0b80b6648cc1146ce", "vr_common_unittests": "1594cc991d60d7cb8ee0a21471ba4874702cc25f", "vr_pixeltests": "584a02da8c19dfec8b5439d769c92d2bfb97de35", "webkit_unit_tests": "0dad3e3a913186cb9330bc9446f9be259373e02b", "webview_instrumentation_test_apk": "142daa71f3133992db2c673e74927bb458dd1e52", "wtf_unittests": "7a9b915ae805f2240b38c56ac04c356fcf277a44"} find isolated tests

Blamelist:

  1. Thomas Tangl (tangltomohnoyoudont@chromium.org)
  2. Nico Weber (thakisohnoyoudont@chromium.org)
  3. Stephen McGruer (smcgruerohnoyoudont@chromium.org)
  4. Aaron Leventhal (aleventhalohnoyoudont@chromium.org)
  5. pdfium-chromium-autoroll (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  6. webrtc-chromium-autoroll (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  7. Emily Hanley (eyaichohnoyoudont@google.com)
  8. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  9. Yoshisato Yanagisawa (yyanagisawaohnoyoudont@chromium.org)
  10. Mike West (mkwstohnoyoudont@chromium.org)
  11. Elly Fong-Jones (ellyjonesohnoyoudont@chromium.org)
  12. Chromite Chromium Autoroll (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  13. Kent Tamura (tkentohnoyoudont@chromium.org)
  14. Ivan Sandrk (isandrkohnoyoudont@google.com)
  15. Mike West (mkwstohnoyoudont@chromium.org)
  16. Arthur Hemery (ahemeryohnoyoudont@chromium.org)
  17. skia-chromium-autoroll (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  18. yoshiki iguchi (yoshikiohnoyoudont@chromium.org)
  19. Shik Chen (shikohnoyoudont@chromium.org)
  20. Benoit Lize (lizebohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 14:56:37 UTC
Start Thursday, 12-Jul-18 14:57:35 UTC
End Thursday, 12-Jul-18 15:54:03 UTC
Pending 58 secs
Execution 56 mins 27 secs

All Changes:

  1. [Dice] Add drop down button to signin button in user menu

    Changed by Thomas Tangl - tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:27:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dcd444b288c6dc6237db97575abc35e4e4d81ce

    Comments

    [Dice] Add drop down button to signin button in user menu
    
    The "Sync to another account" button in the user menu
    is removed and instead a drop down button is added to
    the right of the sign-in button.
    
    Bug: 824546
    Change-Id: I8b1b892962b17229dfdc057169a7f18132ffb58b
    Reviewed-on: https://chromium-review.googlesource.com/1133978
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574548}

    Changed files

    • chrome/browser/ui/views/profiles/profile_chooser_view.cc
  2. Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:25:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb527397d46f689b27ba693793620d1a2fb98493

    Comments

    Run filesystem_service_unittests, leveldb_service_unittests on all desktop bots.
    
    Bug: 843511
    Change-Id: I082a2c9e4d5e573f07bef1e0176f32db6344f2f0
    Reviewed-on: https://chromium-review.googlesource.com/1132400
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574547}

    Changed files

    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  3. Remove webkit-appearance.tentative.html WPT test

    Changed by Stephen McGruer - smcgruerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:22:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af6945a93a039f0717fbc6037dd66a1db081fa65

    Comments

    Remove webkit-appearance.tentative.html WPT test
    
    This test is not a good indicator of -webkit-appearance support; it only
    checks whether computed-value == applied-value for -webkit-appearance
    values specified on a vanilla <div>. In reality most values of
    -webkit-appearance are not of interest to other UAs (see
    https://github.com/whatwg/compat/issues/6), and the behavior is
    different on different elements (e.g. <input>).
    
    Since this has caused issues across different platforms on Chrome (see
    bug), remove it.
    
    Bug: 810162
    Change-Id: I9d469cb624569f453978f3c56cc180eb07435b5b
    Reviewed-on: https://chromium-review.googlesource.com/1134387
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574546}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/compat/webkit-appearance.tentative.html
    • third_party/WebKit/LayoutTests/platform/mac/external/wpt/compat/webkit-appearance.tentative-expected.txt
  4. Avoid incomplete live region text change announcements

    Changed by Aaron Leventhal - aleventhalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 13:04:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a32928f26183dce010284f0abcee28508e44a6f8

    Comments

    Avoid incomplete live region text change announcements
    
    When a live region change occurs we sometimes fire text change events
    for only part of the text. For example, if "car" changes to "cat", we
    fire an event that makes it look like only the "t" changed.
    
    This changes the heuristic so that when a live region occurs that is
    not in an editor, it will prefer to indicate that entire text nodes
    have changed.
    
    Bug: 778478
    Change-Id: If87f1ac8c9c0b237bd422e8b7217d8d0347a13ab
    Reviewed-on: https://chromium-review.googlesource.com/1134201
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574545}

    Changed files

    • content/test/data/accessibility/event/description-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/name-change-indirect-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
    • ui/accessibility/platform/ax_platform_node_win.h
  5. Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)

    Changed by pdfium-chromium-autoroll - pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0aeff28f34f12485a9148321c00383c633d48c63

    Comments

    Roll src/third_party/pdfium 68d04f284423..5ff09fb5ee90 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/68d04f284423..5ff09fb5ee90
    
    
    git log 68d04f284423..5ff09fb5ee90 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 art-snake@yandex-team.ru Remove CPDF_HintTables::GetItemLength()
    2018-07-12 art-snake@yandex-team.ru Implement CPDF_HintsTable::SharedObjGroupInfo.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@5ff09fb5ee90
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I687479f194e638319b40fa5357179d8144f4b197
    Reviewed-on: https://chromium-review.googlesource.com/1134948
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574544}

    Changed files

    • DEPS
  6. Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)

    Changed by webrtc-chromium-autoroll - webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 13:03:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e1637ff7a416934beedc7a637455779b85f6042

    Comments

    Roll src/third_party/webrtc 5795489e83ad..58c79f66dd3a (6 commits)
    
    https://webrtc.googlesource.com/src.git/+log/5795489e83ad..58c79f66dd3a
    
    
    git log 5795489e83ad..58c79f66dd3a --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 saza@webrtc.org Add saza to fuzzer owners
    2018-07-12 ilnik@webrtc.org Temporarly disable KSVC perf tests on Mac because of crashes
    2018-07-12 mbonadei@webrtc.org Removing -Wno-reorder from audio_device.
    2018-07-12 danilchap@webrtc.org Fix buffer overflow in ulpfec recovery
    2018-07-12 danilchap@webrtc.org Fix handling invalid empty red packets
    2018-07-12 buildbot@webrtc.org Roll chromium_revision 720dadbc21..efbdada3f7 (574387:574489)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@58c79f66dd3a
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None,chromium:856823,chromium:856823,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I2e736098249694bb9480b4f170b065e60ddd44a2
    Reviewed-on: https://chromium-review.googlesource.com/1134949
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574543}

    Changed files

    • DEPS
  7. Updating names for job triggers on nexus5x and win 10 perf

    Changed by Emily Hanley - eyaichohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:55:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896ba71bc975b53346521228a32536296ea5d80e

    Comments

    Updating names for job triggers on nexus5x and win 10 perf
    
    Dependent on crrev.com/c/1131227
    
    NOTRY=True
    
    Bug: 758326
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: Icd5c18a166e815be5c2570cafd511bae4c545975
    Reviewed-on: https://chromium-review.googlesource.com/1131230
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574542}

    Changed files

    • infra/config/global/luci-milo-dev.cfg
    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py
  8. [unified-consent] USER_EVENT has its own sync pref group

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:50:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4432c3f9d16a93276eeb9c60a860190223888d96

    Comments

    [unified-consent] USER_EVENT has its own sync pref group
    
    This CL passes the information that unified consent is enabled to
    the sync service. It then uses it to move USER_EVENTS data type in
    a separate pref group (instead of having it tied to TYPED_URLS as
    before).
    
    The goal is not to un-link USER_EVENTS from HISTORY, but to have a
    separate toggle for USER_EVENTS (which will be linked to HISTORY toggle
    in the toggle UI).
    
    Unit tests have been updated accordingly.
    
    Bug: 860515
    
    Change-Id: Ic5461470114c0b05ec770817890c9123b81f3d77
    Reviewed-on: https://chromium-review.googlesource.com/1128876
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574541}

    Changed files

    • chrome/browser/android/contextualsearch/contextual_search_delegate.cc
    • chrome/browser/sync/profile_sync_service_factory.cc
    • chrome/browser/sync/test/integration/enable_disable_test.cc
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/sync/base/sync_prefs.cc
    • components/sync/base/sync_prefs.h
    • components/sync/base/sync_prefs_unittest.cc
  9. compare_build_artifacts: make ninja path command line option.

    Changed by Yoshisato Yanagisawa - yyanagisawaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:49:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3f55b21a7a48593a9ce1622346dad112a8b2e2f

    Comments

    compare_build_artifacts: make ninja path command line option.
    
    ninja seems not be in PATH when compare_build_artifacts.py is executed.
    Then compare_build_artifacts cannot compare object files difference,
    and just fails with exception.
    To fix that, let me make ninja path given with command line option.
    
    Bug: 862917
    Change-Id: Ieb7d7bd1db30217222f5cd5006e120244da28fd5
    Reviewed-on: https://chromium-review.googlesource.com/1134710
    Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
    Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574540}

    Changed files

    • tools/determinism/compare_build_artifacts.py
  10. Mark several layout tests as flaky.

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:44:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704b3f013b80c7a5f93296e3d146758d5c0b0ccc

    Comments

    Mark several layout tests as flaky.
    
    - css3/filters/effect-brightness-clamping-hw.html
    - virtual/gpu/fast/canvas/canvas-blending-image-over-image.html
    - css3/filters/effect-drop-shadow-hw.html
    - external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862716, 862729, 862806, 862826
    Change-Id: I08126b22afdc0a7a4ef776dde8cc1120643acdcc
    Reviewed-on: https://chromium-review.googlesource.com/1134990
    Commit-Queue: Mike West <mkwst@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574539}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  11. macviews: switch back to Cocoa menus for Views context menus

    Changed by Elly Fong-Jones - ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus
    
    This change:
    1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
       the Cocoa menu runner code;
    2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
    3) Fixes a latent bug in Textfield that could cause it to delete its context
       menu while handling a context menu activation - this is fine with Views menus
       but forbidden with Cocoa menus.
    
    Bug: 860673
    Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
    Reviewed-on: https://chromium-review.googlesource.com/1131564
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc
  12. Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

    Changed by Chromite Chromium Autoroll - chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:32:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78a0a24222fde0f77a45d4f78b1f4502496c434e

    Comments

    Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c228d491eb86..3973c26575e2
    
    
    git log c228d491eb86..3973c26575e2 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 dhanyaganesh@chromium.org CreateTarball: Add debug code with lsof
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@3973c26575e2
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Iabf74616719c8b90e6b34c6576772eeb313a7183
    Reviewed-on: https://chromium-review.googlesource.com/1134906
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574537}

    Changed files

    • DEPS
  13. Oilpan: Do not include wtf/functional.h

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

    Comments

    Oilpan: Do not include wtf/functional.h
    
    No one in platform/heap/ needs wtf/functional.h, though persistent.h
    needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.
    
    This CL reduces the pre-processed size of handle.h by 31KB.
    
    Bug: 242216
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
    Reviewed-on: https://chromium-review.googlesource.com/1134809
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574536}

    Changed files

    • third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
    • third_party/blink/renderer/modules/budget/budget_service.cc
    • third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
    • third_party/blink/renderer/modules/filesystem/directory_reader.cc
    • third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
    • third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
    • third_party/blink/renderer/modules/locks/lock.cc
    • third_party/blink/renderer/modules/mediastream/media_devices_test.cc
    • third_party/blink/renderer/modules/payments/payment_manager.cc
    • third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
    • third_party/blink/renderer/modules/webusb/usb_device.cc
    • third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/skia_texture_holder.h
    • third_party/blink/renderer/platform/heap/persistent.h
    • third_party/blink/renderer/platform/heap/thread_state.h
    • third_party/blink/renderer/platform/testing/empty_web_media_player.h
    • third_party/blink/renderer/platform/testing/unit_test_helpers.cc
  14. Add UMA for locked-fullscreen state

    Changed by Ivan Sandrk - isandrkohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fe933a784678f6aa62203b7d57a638051c15f2a

    Comments

    Add UMA for locked-fullscreen state
    
    Locked-fullscreen state will be used for giving student quizzes on managed
    Chrome OS devices in schools. Add a UMA to track feature adoption.
    
    Change-Id: I59f809e2aecd67a4e9f10ee21a28658796c03b15
    Reviewed-on: https://chromium-review.googlesource.com/1126241
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ivan Ĺ andrk <isandrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574535}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  15. Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

    Changed by Mike West - mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84356c12447981846eda650f06085913fa831126

    Comments

    Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky
    
    TBR=kpaulhamus@chromium.org
    
    Bug: 862907
    Change-Id: If6ce15cb1633ae74177e385774a1cef7010e67c0
    Reviewed-on: https://chromium-review.googlesource.com/1134989
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574534}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  16. Navigation: Refactoring WebContents unittests to use NavigationSimulator

    Changed by Arthur Hemery - ahemeryohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:20:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c65bc1abc46c630c53a3e21bb0670dc602e8d37d

    Comments

    Navigation: Refactoring WebContents unittests to use NavigationSimulator
    
    Removed the usage of TestWebContents->DidNavigate variants in
    web_contents_impl_unittest.cc. Some usage remains, linked to
    overlapping navigations and other specific usages.
    
    Bug: 728571
    Change-Id: Ie2d6b73cb5deea077f720114fdd45ab4ee714c0a
    Reviewed-on: https://chromium-review.googlesource.com/1076240
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Commit-Queue: Arthur Hemery <ahemery@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574533}

    Changed files

    • content/browser/web_contents/web_contents_impl_unittest.cc
  17. Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)

    Changed by skia-chromium-autoroll - skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a66959734236ca95f9372334bfa18bbc7a5a1b52

    Comments

    Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)
    
    https://skia.googlesource.com/skia.git/+log/fcc10da18eb5..4d6a844365e7
    
    
    git log fcc10da18eb5..4d6a844365e7 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
    2018-07-12 herb@google.com Use new SkGlyphIDSet - v3
    2018-07-12 bungeman@google.com Remove SkDrawFilter.
    2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 5c8113d3c20f..5598148b7613 (8 commits)
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 robertphillips@google.com Revert "build debug on linux for gdb"
    2018-07-12 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-12 caryclark@google.com build debug on linux for gdb
    2018-07-12 benjaminwagner@google.com Update Win10 in Skolo.
    
    
    Created with:
      gclient setdep -r src/third_party/skia@4d6a844365e7
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ifd4c74ca893ddae66e41fe10ff663287be1cf325
    Reviewed-on: https://chromium-review.googlesource.com/1134148
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574532}

    Changed files

    • DEPS
  18. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshiki iguchi - yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification
    
    When a non-ARC normal window (eg. Chrome browser window) was active, the
    inline textbox didn't work for the second time and later. This CL solves
    this issue.
    
    This was because the widget was not activated correctly (IsActive() was
    true but CanActivate() was false) in that case. This CL removes the
    IsActive() guard to make the widget active correctly whenever the inline
    reply opens.
    
    Bug: b/111100376
    Bug: 858938
    Test: manual (inline reply can be used multiple times)
    
    Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
    Reviewed-on: https://chromium-review.googlesource.com/1133039
    Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
  19. media: sync the camera metadata definitions

    Changed by Shik Chen - shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions
    
    We need some new metadata tags for external camera, so regenerate and
    sync all of them in arc-camera, chromium, and ARC++.
    
    Some "arc" are replaced by "cros" manually.
    
    BUG=b:77833131
    TEST=Verify CCA works on Nautilus.
    
    Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
    Reviewed-on: https://chromium-review.googlesource.com/1117970
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom
  20. blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

    Changed by Benoit Lize - lizebohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b

    Comments

    blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
    
    When a MovableString is parked, actually park the content, and poison
    the previous allocation. This is intended to find cached raw pointer
    accesses, which are not allowed beyond the UI thread task per the
    contract of the class.
    Enabled only when DCHECK_IS_ON to prevent potential crashes.
    
    Changes with and without DCHECK()s:
    - Cache some String properties in MovableStringImpl
    - Add a parked_strings_ to MovableStringTable for accounting, and
      update tests accordingly.
    
    Changes with DCHECK()s:
    - Add a parked_string_ member to MovableStringImpl
    - Copy the string to the parked version in Park(), and poison the
      previous allocation.
    - Restore the string in Unpark().
    
    Bug: 837659
    Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
    Reviewed-on: https://chromium-review.googlesource.com/1133169
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574529}

    Changed files

    • third_party/blink/renderer/platform/wtf/text/movable_string.cc
    • third_party/blink/renderer/platform/wtf/text/movable_string.h
    • third_party/blink/renderer/platform/wtf/text/movable_string_test.cc