Builder Mac10.13 Tests
Build 7432
Results:
Internal Failure
Trigger Info:
| Project | chromium |
| Revision | b38c320095ae37996d50a735f7d2690c9e0eed10 |
Execution:
- Source: Task 41a053c37eaf0d10
- Bot: vm73-m9
- Recipe: chromium
Steps and Logfiles:
Show:Debug Logs:
-
- - no logs -
Build Properties:
| Name | Value | Source |
|---|
Blamelist:
- Chromium WPT Sync (wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
- Hiroki Nakagawa (nhirokiohnoyoudont@chromium.org)
- chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
- maxmorin (maxmorinohnoyoudont@chromium.org)
- Charles Zhao (charleszhaoohnoyoudont@chromium.org)
- Alan Cutter (alancutterohnoyoudont@chromium.org)
Timing:
| Create | Friday, 07-Dec-18 07:11:57 UTC |
| Start | Friday, 07-Dec-18 07:12:01 UTC |
| End | Friday, 07-Dec-18 07:19:51 UTC |
| Pending | 4 secs |
| Execution | 7 mins 49 secs |
All Changes:
-
Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720
Changed by Chromium WPT Sync - wpt-autorollerohnoyoudont@chops-service-accounts.iam.gserviceaccount.com Changed at Friday, 07-Dec-18 06:36:58 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b38c320095ae37996d50a735f7d2690c9e0eed10 Comments
Import wpt@2d0f68b3c512b4ba268b09fac224830f866a5720 Using wpt-import in Chromium c71812f1007dae45bce45b451c384bf9c0dbd356. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I379fefc2dcbcf7082675a8eced0893890f23b0ef Reviewed-on: https://chromium-review.googlesource.com/c/1367132 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614627}
Changed files
- third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
- third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https-expected.txt
- third_party/blink/web_tests/external/wpt/webrtc/RTCPeerConnection-track-stats.https.html
- third_party/blink/web_tests/external/wpt/webrtc/legacy/RTCPeerConnection-addStream.https.html
- third_party/blink/web_tests/external/wpt/webrtc/no-media-call.html
-
Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs
Changed by Hiroki Nakagawa - nhirokiohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 06:31:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 593b9acb3dea58c30c4a4cd8d251938f66a47c1e Comments
Worklet: Use <meta name="timeout"> instead of SlowTests annotations for slow WPTs <meta name="timeout"> is prefereable for WPTs: https://web-platform-tests.org/writing-tests/testharness-api.html#harness-timeout Bug: 912240 Change-Id: I3c4a9acb1fb070c34d10f59ff9d3fd3d2bd11afb Reviewed-on: https://chromium-review.googlesource.com/c/1366469 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#614626}
Changed files
- third_party/blink/web_tests/SlowTests
- third_party/blink/web_tests/external/wpt/worklets/animation-worklet-csp.https.html
- third_party/blink/web_tests/external/wpt/worklets/audio-worklet-csp.https.html
-
Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits)
Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com Changed at Friday, 07-Dec-18 06:29:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision a61e410e3beb88a04880f973dbde7c0099dbdff6 Comments
Roll src/third_party/catapult 5d7bcad36ff4..62ba44ace70c (1 commits) https://chromium.googlesource.com/catapult.git/+log/5d7bcad36ff4..62ba44ace70c git log 5d7bcad36ff4..62ba44ace70c --date=short --no-merges --format='%ad %ae %s' 2018-12-06 rmhasan@google.com Adds another verification to the Test expectation parser Created with: gclient setdep -r src/third_party/catapult@62ba44ace70c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:905426 TBR=sullivan@chromium.org Change-Id: Ibda0e80cd77c7ecd1434701f064e2f99db1b8307 Reviewed-on: https://chromium-review.googlesource.com/c/1367099 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614625}
Changed files
- DEPS
-
Activate audio thread hang monitoring when OOP
Changed by maxmorin - maxmorinohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 06:26:36 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c67047dd2ff166e62aa72f9d461e3a00baf5e573 Comments
Activate audio thread hang monitoring when OOP Also includes cleaning up the hang monitor: * Actually a class! * Actually possible to stop the hang monitor! * Tests! * When OOP, uploads dumps (without crashing). A kill switch is added for this. * Switch the UMA enum to kCase, make it a class enum, and use the simpler UMA histogram. * Switch from "tail posting" the periodic task to using RepeatingTimer. * Runs on the task scheduler rather than on the browser IO thread. * Some suspend/resume code was simplified. The hang monitor is now owned by the AudioThread implementation. Extra functionality (such a nuking the audio process in case of a hang) is coming later. Bug: 866442, 905681 Change-Id: Icfe83cc3e7626b164648a8b502d13cf2cfc25518 Reviewed-on: https://chromium-review.googlesource.com/c/1340264 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#614624}
Changed files
- content/browser/renderer_host/media/audio_output_authorization_handler_unittest.cc
- content/browser/renderer_host/render_process_host_impl.cc
- media/audio/BUILD.gn
- media/audio/audio_features.cc
- media/audio/audio_features.h
- media/audio/audio_manager.cc
- media/audio/audio_manager.h
- media/audio/audio_thread.h
- media/audio/audio_thread_hang_monitor.cc
- media/audio/audio_thread_hang_monitor.h
- media/audio/audio_thread_hang_monitor_unittest.cc
- media/audio/audio_thread_impl.cc
- media/audio/audio_thread_impl.h
- media/audio/test_audio_thread.cc
- media/audio/test_audio_thread.h
- services/audio/owning_audio_manager_accessor.cc
-
TabRanker: Fix Query time logging.
Changed by Charles Zhao - charleszhaoohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 06:26:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 6378752b810e6122744cefac544c8d84278dcc71 Comments
TabRanker: Fix Query time logging. TabRanker query time logging was landed in this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1350445 TabManager::GetSortedLifecycleUnitsFromTabRanker() was created to bypass calls to TabManager::GetSortedLifecycleUnits() But this was wrong on two aspects: (1) TabManagerDelegate::LowMemoryKillImpl is still calling GetSortedLifecycleUnits(), so ChromeOS discards are all skipped. (2) TabManagerDelegate::Candidate is calling lifecycle_unit_->GetSortKey() for inferring sorting, Which means TabRanker model won't work for ChromeOS discards. The fix: (1) Change TabManager, TabLifecycleUnit back to their previous code, which were sorting LifecycleUnits by TabRanker when it's enabled. (2) Add TabActivityWatcher::LogOldestNTabFeatures() and call this function in TabManager::DiscardTab for query time logging. Bug: 911474 Change-Id: I103e8237cd96ea87667536b7b44b27fe8772abb4 Reviewed-on: https://chromium-review.googlesource.com/c/1360471 Reviewed-by: Christopher Morin <cmtm@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614623}
Changed files
- chrome/browser/resource_coordinator/tab_activity_watcher.cc
- chrome/browser/resource_coordinator/tab_activity_watcher.h
- chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc
- chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
- chrome/browser/resource_coordinator/tab_manager.cc
- chrome/browser/resource_coordinator/tab_manager.h
-
Revert "Timer notification UI improvement:"
Changed by Alan Cutter - alancutterohnoyoudont@chromium.org Changed at Friday, 07-Dec-18 06:18:17 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e Comments
Revert "Timer notification UI improvement:" This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6. Reason for revert: Broke compile: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395 ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found #include "libassistant/shared/internal_api/alarm_timer_types.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Original change's description: > Timer notification UI improvement: > > * Add timer deeplinks for: > - Stop timer > - Add time to timer > * Add "add 1 min to timer" button to timer notification. > > Using a feature flag to guard the usage of the deeplink as > AlarmTimerManager is not fully available yet. > > Bug: b:119116816 > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe > Reviewed-on: https://chromium-review.googlesource.com/c/1340786 > Commit-Queue: Li Lin <llin@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614618} TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:119116816 Reviewed-on: https://chromium-review.googlesource.com/c/1367081 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#614622}
Changed files
- ash/assistant/assistant_controller.cc
- ash/assistant/assistant_interaction_controller.cc
- ash/assistant/assistant_interaction_controller.h
- ash/assistant/util/deep_link_util.cc
- ash/assistant/util/deep_link_util.h
- ash/assistant/util/deep_link_util_unittest.cc
- chromeos/chromeos_strings.grd
- chromeos/services/assistant/assistant_manager_service_impl.cc
- chromeos/services/assistant/assistant_manager_service_impl.h
- chromeos/services/assistant/fake_assistant_manager_service_impl.cc
- chromeos/services/assistant/fake_assistant_manager_service_impl.h
- chromeos/services/assistant/public/features.cc
- chromeos/services/assistant/public/features.h
- chromeos/services/assistant/public/mojom/assistant.mojom
- chromeos/services/assistant/test_support/mock_assistant.h