Home | Search | chromium - Builders
Login

Builder Mac10.13 Tests Build 5669 Apple OSX

Results:

Failure webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6

Trigger Info:

Projectchromium
Revision755d6f957abd6af5b8bbbf045ac622b92fea60a5
Got Revision755d6f957abd6af5b8bbbf045ac622b92fea60a5

Execution:

Steps and Logfiles:

Show:
  1. ( 475 ms ) setup_build
    running recipe: "chromium"
  2. ( 337 ms ) report builders
     
    running tester 'Mac10.13 Tests' on master 'chromium.mac'
  3. ( 1 mins 29 secs ) bot_update
    [90GB/232GB used (38%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 209 ms ) ensure_installed
  6. ( 19 secs ) gclient runhooks
  7. ( 889 ms ) read test spec (chromium.mac.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
  8. ( 557 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 1 secs ) build directory
  10. ( 3 mins 23 secs ) extract build
  11. ( 590 ms ) find isolated tests
  12. ( 24 secs ) webkit_lint
  13. ( 2 secs ) accessibility_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  14. ( 4 secs ) angle_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:19.342592
  15. ( 2 secs ) app_shell_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 36s
  16. ( 3 secs ) base_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 30s
  17. ( 1 secs ) blink_common_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  18. ( 1 secs ) blink_fuzzer_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  19. ( 2 secs ) blink_heap_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 21s
  20. ( 3 secs ) blink_platform_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 56s
  21. ( 2 secs ) boringssl_crypto_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  22. ( 2 secs ) boringssl_ssl_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  23. ( 1 secs ) cacheinvalidation_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
  24. ( 2 secs ) capture_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  25. ( 2 secs ) cast_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  26. ( 3 secs ) cc_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:01.680671
  27. ( 2 secs ) chrome_app_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 30s
  28. ( 2 secs ) chromedriver_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  29. ( 2 secs ) components_browsertests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 43s
  30. ( 8 secs ) components_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:09.410071
  31. ( 8 mins 28 secs ) content_browsertests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:13:08.851315
  32. ( 2 secs ) perfetto_content_browsertests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 31s
  33. ( 4 secs ) content_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:21.021019
  34. ( 2 secs ) crashpad_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  35. ( 1 secs ) cronet_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  36. ( 1 secs ) cronet_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  37. ( 2 secs ) crypto_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
  38. ( 2 secs ) device_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  39. ( 2 secs ) display_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  40. ( 2 secs ) events_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  41. ( 2 secs ) extensions_browsertests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 57s
  42. ( 2 secs ) extensions_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 31s
  43. ( 1 secs ) filesystem_service_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
  44. ( 2 secs ) gcm_unit_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  45. ( 3 secs ) gfx_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  46. ( 2 secs ) gin_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  47. ( 2 secs ) google_apis_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  48. ( 4 secs ) gpu_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 19s
  49. ( 2 secs ) headless_browsertests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 36s
  50. ( 1 secs ) headless_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  51. ( 2 secs ) webui_polymer2_interactive_ui_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:32.370605
  52. ( 2 secs ) ipc_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 16s
  53. ( 2 secs ) jingle_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  54. ( 2 secs ) latency_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  55. ( 2 secs ) leveldb_service_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  56. ( 2 secs ) libjingle_xmpp_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 20s
  57. ( 2 secs ) mac_installer_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  58. ( 2 secs ) media_blink_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 26s
  59. ( 1 secs ) media_service_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  60. ( 4 secs ) media_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 32s
  61. ( 1 secs ) message_center_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  62. ( 2 secs ) midi_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
  63. ( 2 secs ) mojo_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  64. ( 2 secs ) nacl_loader_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 23s
  65. ( 1 secs ) native_theme_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
  66. ( 16 secs ) net_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:03:13.183618
  67. ( 1 secs ) pdf_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 13s
  68. ( 2 secs ) ppapi_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  69. ( 1 secs ) printing_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  70. ( 2 secs ) remoting_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 24s
  71. ( 2 secs ) sandbox_mac_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
  72. ( 2 secs ) service_manager_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  73. ( 3 secs ) services_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 45s
  74. ( 2 secs ) shell_dialogs_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  75. ( 1 secs ) skia_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
  76. ( 1 secs ) snapshot_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 11s
  77. ( 1 secs ) sql_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  78. ( 2 secs ) storage_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 15s
  79. ( 2 secs ) sync_integration_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:07:11.867224
  80. ( 2 secs ) traffic_annotation_auditor_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  81. ( 2 secs ) ui_base_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 17s
  82. ( 1 secs ) ui_touch_selection_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 10s
  83. ( 7 secs ) unit_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:23.015908
  84. ( 2 secs ) url_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
  85. ( 2 secs ) views_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 41s
  86. ( 2 secs ) viz_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:01.771221
  87. ( 7 secs ) webkit_unit_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:14.622905
  88. ( 2 secs ) wtf_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 14s
  89. ( 2 secs ) interactive_ui_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:06:12.555345 (shard #2)
    Min shard duration: 0:04:24.392051 (shard #1)
  90. ( 2 secs ) webui_polymer2_browser_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:04:48.135504 (shard #0)
    Min shard duration: 0:03:55.739511 (shard #3)
  91. ( 2 secs ) chromedriver_py_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:03:27.928214
    Total tests: 142
    * Passed: 142 (142 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  92. ( 1 secs ) chromedriver_replay_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 9s
    Total tests: 33
    * Passed: 33 (33 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  93. ( 2 secs ) components_perftests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:01:27.876173
    Total tests: n/a
     
  94. ( 2 secs ) content_shell_crash_test on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 45s
    Total tests: n/a
     
  95. ( 1 secs ) metrics_python_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  96. ( 2 secs ) telemetry_gpu_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 50s
    Total tests: 35
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  97. ( 3 secs ) telemetry_unittests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Max shard duration: 0:04:52.807128 (shard #0)
    Min shard duration: 0:03:56.592411 (shard #1)
    Total tests: 1169
    * Passed: 1074 (1074 expected, 0 unexpected)
    * Skipped: 95 (95 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  98. ( 1 secs ) views_perftests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 12s
    Total tests: n/a
     
  99. ( 4 mins 4 secs ) webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:12:28.476283 (shard #4)
    Min shard duration: 0:09:26.998467 (shard #2)
    Total tests: 87453
    * Passed: 74077 (73980 expected, 97 unexpected)
    * Skipped: 10698 (10698 expected, 0 unexpected)
    * Failed: 2567 (2566 expected, >>>1 unexpected<<<)
    * Flaky: 111 (111 expected, 0 unexpected)
     
    Unexpected Failures:
    * virtual/layout_ng/fast/block/float/nopaint-after-layer-destruction.html
     
  100. ( 3 secs ) webkit_python_tests on (none) GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 18s
    Total tests: 1551
    * Passed: 1551 (1551 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  101. ( 316 ms ) Tests statistics
     
    Stats
    Total shards: 107
    Total runtime: 3:09:50.148823
     
  102. ( 3 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm73-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539335135564832, "id": "8932883836849317040", "project": "chromium", "tags": ["builder:Mac10.13 Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/755d6f957abd6af5b8bbbf045ac622b92fea60a5", "gitiles_ref:refs/heads/master", "parent_buildername:Mac Builder", "parent_buildnumber:90632", "scheduler_invocation_id:9098313899018165088", "scheduler_job_id:chromium/Mac10.13 Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac10.13 Tests" setup_build
buildnumber 5669 setup_build
mastername "chromium.mac" setup_build
parent_buildername "Mac Builder" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" setup_build
parent_got_revision_cp "refs/heads/master@{#599145}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25135}" setup_build
parent_mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" setup_build
swarm_hashes {"accessibility_unittests": "b8297560268b78e9f048b85c1d39f1df81040957", "angle_unittests": "c32c73f7e3d97ad497164e56b030583e6e904c16", "app_shell_unittests": "c004d9e84bd056d1503166d7ef247c7aec5cb0f9", "base_unittests": "f0e8d38a7e4befa75fa5a323c37101ff167a3a7b", "blink_common_unittests": "f071caa4929a7b11604387c93c180858c6d5fdd9", "blink_fuzzer_unittests": "d6e7f544253f0ead0df344b33c18782bc77bb646", "blink_heap_unittests": "9e267c3ec23257ae820250f744dcf6a5af5e840a", "blink_platform_unittests": "4db63ba163cec5c616584bd499e37280aec2a2c5", "boringssl_crypto_tests": "2b764b4207c8eae34301b67fbcf8d9a83fe03e53", "boringssl_ssl_tests": "82a1ef9e9c0e18151210377c601ca3dc00e344a2", "browser_tests": "87511b5ec4882728b7f0e467aad66370f3514dcc", "cacheinvalidation_unittests": "977e0ae716656deecd7f6606e0169b7ec51f17bb", "capture_unittests": "870d7343b2cb7d53f390fc343aa869ff47c63adb", "cast_unittests": "2d898c7eeb62411a7835fcb879ec9849f394e146", "cc_unittests": "d13fa37bd7788b3215a22b2397246eba080809a6", "chrome_app_unittests": "69926032438fa941fdfdf874e9bfeb462cd8c136", "chromedriver_py_tests": "4da4d06f15b98b65cea73a21570d96aa812db211", "chromedriver_replay_unittests": "950c040334ad8a7d3fc3ab9bf98bea1f48abdaec", "chromedriver_unittests": "3b641407ad34eaf941f7b83e01bb2b45cf55dace", "components_browsertests": "0e3c5a8bbfc245f77367b512aa275efd600e6b22", "components_perftests": "b4afb9d0719f62a6503afc60a5c200f9a15ed5cd", "components_unittests": "aac61b90b052f31a8b3f50c2612c8f51362bf5d2", "content_browsertests": "7b5b9bdc1eeb0a7423fa26bc2bcacf5bdfb5311a", "content_shell_crash_test": "6825aa075846cebd87a6aa27fd7f44f4234a7ae1", "content_unittests": "a0264157d178826edf1a6dc99607ee0a641d9697", "crashpad_tests": "27572b66b58333e2446bfbdf879f6562f67348a6", "cronet_tests": "911e27b58d973821e1a0df8f4d78a558ec542c5f", "cronet_unittests": "6ad712f7217e3617807980436a78d3a0be86db46", "crypto_unittests": "be2b03d8c0d36cca99b534015e7c19bf45509679", "device_unittests": "e6f58cc192de7477c56ae307527ac69a7af526e3", "display_unittests": "c88ef4cb54b4eedb0dd2c53657d1e3b36493a43e", "events_unittests": "fa8949f79893d7cd294ca2091e3f49a90381607d", "extensions_browsertests": "3974e300970dcbe0c08c826f57d032591757a428", "extensions_unittests": "ff89273d6bb1c940bf09c03532ebf5cfd2a451e9", "filesystem_service_unittests": "29bde0b547afdebb59dc3c1d07ceeabdf149fc71", "gcm_unit_tests": "3ebfd918d853ef804f6a90e124d14406ab958e77", "gfx_unittests": "3f6eb31122011c46b6c8b63efb21797c029aa26d", "gin_unittests": "8844f0ae82fae64588a489b84520a677ea168db8", "google_apis_unittests": "5c2497956c11241f3212fbdfc27138e511d6290f", "gpu_unittests": "bc1bf02a93ac560b3d33d00cd01c7656ae917d76", "headless_browsertests": "aee38b5139ccec2bcf270598228e1e34c89b349b", "headless_unittests": "ea906e55f0a616d68a06c00f0c61b09796e21d8d", "interactive_ui_tests": "33a0d7fdd6bb405dbcd1fd9bf0a0117acfbf5680", "ipc_tests": "77b93f932c19729e4f1350ccb2d090a1baf36981", "jingle_unittests": "3ffd2e9d676f19b5ac077ebba52ec37a686f0279", "latency_unittests": "bf7c2e039e4966ff6d59b9df26f644b4cb661649", "leveldb_service_unittests": "b37f7b355eeeec374cd0ff002249464d4802d8d0", "libjingle_xmpp_unittests": "d8d6f35275807aa93ed42c6ea8a38918ae308792", "mac_installer_unittests": "b443b217e52a9811856e9f02887afec90519aef8", "media_blink_unittests": "a45f8eee6f35725373815f6aba4c3d0c9feadaa4", "media_service_unittests": "251c4e4606396c02765b314cfb91c40e6d5ac0f8", "media_unittests": "75b52b0404009a886dceebce3b5e77174b6ae4bf", "message_center_unittests": "c1dbd7f5207e7d1e6757be48dee3f58453ad8aef", "metrics_python_tests": "a7ea6892f85a3f6a50a4cca2c0b6bc4fb51b579d", "midi_unittests": "5e08022d85cb6bfe34e04a049219cb36d1d5de27", "mojo_unittests": "d0fc72bc28ada8b750fe04ec2817eeb5211d370c", "nacl_loader_unittests": "08459cf5e6cf13c5a5ee92b876f7016f87f34c18", "native_theme_unittests": "7930fefe672e30c379eec53bd7705aef3162968c", "net_unittests": "9d5d3a0ad827cc1af4035303bedc4f22db920f3c", "pdf_unittests": "475066028461bd223e3ed457b591517b8d0a066f", "ppapi_unittests": "7c86fe207a5719995ce8ba84bad0baf8b5e16608", "printing_unittests": "095f5325fe1c563b25571e7c235ebdae4996d2a6", "remoting_unittests": "1218a9cf9149a025a4e8df5829a032ffb51b87af", "sandbox_mac_unittests": "31f0aabf957f7269bf9d14b0fd7a49d9f119bfde", "service_manager_unittests": "210fca4cc04960bf7d5ce7e1585da1dc0284c33f", "services_unittests": "2f7e952dd66172c6c1475a807081859f6ec87df3", "shell_dialogs_unittests": "91ba7e11188aa2dc1485afa76e8cbe2cf0361df9", "skia_unittests": "add07ba3b9806e03c63e762b0bb726fa23172645", "snapshot_unittests": "af07df1dada934a2fe930192516583f01ede698a", "sql_unittests": "2634e4f4b8b13c09373372590c63271523f34e18", "storage_unittests": "6811128ed910c7505209acba48f34f2dc9fd3078", "sync_integration_tests": "4c486d66c0771c7f03a79d3c718a0b3740640bfc", "telemetry_gpu_unittests": "bcccabdbc64cbe564a5a4052d85d37c3d2ae7ebd", "telemetry_perf_unittests": "73e92c88906b02df587a1d33c741f7fd222d8255", "telemetry_unittests": "56765531148ea505153822b8a7b156b94b9a2a61", "traffic_annotation_auditor_unittests": "c32a84bfbc78c6f206bef59642538d6ac2321da0", "ui_base_unittests": "b9d0b2c050a249e58bafea215bc7932e6937b948", "ui_touch_selection_unittests": "cb6fe0eeaea2be55932322047166b3e94cf0d733", "unit_tests": "beebf89bedabf3ab9ec638d0d823074adf99bb0a", "url_unittests": "766e6300044abc12cd5efb29a3b4d0a438020afb", "views_perftests": "696d8c8274a4fe46a7eaa801e4213b3c0c772617", "views_unittests": "401d8ae309199f8a3e97eb3d580766f499ddda3f", "viz_unittests": "05d745dd1f64bde2e4b54872907b45a46171197a", "webkit_layout_tests_exparchive": "4ceb16ee2cb79435ff20dafdd243344aab52cedc", "webkit_python_tests": "79d04ef92dffaa604ec80e513816995983971080", "webkit_unit_tests": "fc5bff3343d6567bf1fdd62b78e312c8da52d872", "wtf_unittests": "ac575f437d529142293741c3a7c23087f4478409"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "755d6f957abd6af5b8bbbf045ac622b92fea60a5" bot_update
got_revision_cp "refs/heads/master@{#599145}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25135}" bot_update
swarm_hashes {"accessibility_unittests": "b8297560268b78e9f048b85c1d39f1df81040957", "angle_unittests": "c32c73f7e3d97ad497164e56b030583e6e904c16", "app_shell_unittests": "c004d9e84bd056d1503166d7ef247c7aec5cb0f9", "base_unittests": "f0e8d38a7e4befa75fa5a323c37101ff167a3a7b", "blink_common_unittests": "f071caa4929a7b11604387c93c180858c6d5fdd9", "blink_fuzzer_unittests": "d6e7f544253f0ead0df344b33c18782bc77bb646", "blink_heap_unittests": "9e267c3ec23257ae820250f744dcf6a5af5e840a", "blink_platform_unittests": "4db63ba163cec5c616584bd499e37280aec2a2c5", "boringssl_crypto_tests": "2b764b4207c8eae34301b67fbcf8d9a83fe03e53", "boringssl_ssl_tests": "82a1ef9e9c0e18151210377c601ca3dc00e344a2", "browser_tests": "87511b5ec4882728b7f0e467aad66370f3514dcc", "cacheinvalidation_unittests": "977e0ae716656deecd7f6606e0169b7ec51f17bb", "capture_unittests": "870d7343b2cb7d53f390fc343aa869ff47c63adb", "cast_unittests": "2d898c7eeb62411a7835fcb879ec9849f394e146", "cc_unittests": "d13fa37bd7788b3215a22b2397246eba080809a6", "chrome_app_unittests": "69926032438fa941fdfdf874e9bfeb462cd8c136", "chromedriver_py_tests": "4da4d06f15b98b65cea73a21570d96aa812db211", "chromedriver_replay_unittests": "950c040334ad8a7d3fc3ab9bf98bea1f48abdaec", "chromedriver_unittests": "3b641407ad34eaf941f7b83e01bb2b45cf55dace", "components_browsertests": "0e3c5a8bbfc245f77367b512aa275efd600e6b22", "components_perftests": "b4afb9d0719f62a6503afc60a5c200f9a15ed5cd", "components_unittests": "aac61b90b052f31a8b3f50c2612c8f51362bf5d2", "content_browsertests": "7b5b9bdc1eeb0a7423fa26bc2bcacf5bdfb5311a", "content_shell_crash_test": "6825aa075846cebd87a6aa27fd7f44f4234a7ae1", "content_unittests": "a0264157d178826edf1a6dc99607ee0a641d9697", "crashpad_tests": "27572b66b58333e2446bfbdf879f6562f67348a6", "cronet_tests": "911e27b58d973821e1a0df8f4d78a558ec542c5f", "cronet_unittests": "6ad712f7217e3617807980436a78d3a0be86db46", "crypto_unittests": "be2b03d8c0d36cca99b534015e7c19bf45509679", "device_unittests": "e6f58cc192de7477c56ae307527ac69a7af526e3", "display_unittests": "c88ef4cb54b4eedb0dd2c53657d1e3b36493a43e", "events_unittests": "fa8949f79893d7cd294ca2091e3f49a90381607d", "extensions_browsertests": "3974e300970dcbe0c08c826f57d032591757a428", "extensions_unittests": "ff89273d6bb1c940bf09c03532ebf5cfd2a451e9", "filesystem_service_unittests": "29bde0b547afdebb59dc3c1d07ceeabdf149fc71", "gcm_unit_tests": "3ebfd918d853ef804f6a90e124d14406ab958e77", "gfx_unittests": "3f6eb31122011c46b6c8b63efb21797c029aa26d", "gin_unittests": "8844f0ae82fae64588a489b84520a677ea168db8", "google_apis_unittests": "5c2497956c11241f3212fbdfc27138e511d6290f", "gpu_unittests": "bc1bf02a93ac560b3d33d00cd01c7656ae917d76", "headless_browsertests": "aee38b5139ccec2bcf270598228e1e34c89b349b", "headless_unittests": "ea906e55f0a616d68a06c00f0c61b09796e21d8d", "interactive_ui_tests": "33a0d7fdd6bb405dbcd1fd9bf0a0117acfbf5680", "ipc_tests": "77b93f932c19729e4f1350ccb2d090a1baf36981", "jingle_unittests": "3ffd2e9d676f19b5ac077ebba52ec37a686f0279", "latency_unittests": "bf7c2e039e4966ff6d59b9df26f644b4cb661649", "leveldb_service_unittests": "b37f7b355eeeec374cd0ff002249464d4802d8d0", "libjingle_xmpp_unittests": "d8d6f35275807aa93ed42c6ea8a38918ae308792", "mac_installer_unittests": "b443b217e52a9811856e9f02887afec90519aef8", "media_blink_unittests": "a45f8eee6f35725373815f6aba4c3d0c9feadaa4", "media_service_unittests": "251c4e4606396c02765b314cfb91c40e6d5ac0f8", "media_unittests": "75b52b0404009a886dceebce3b5e77174b6ae4bf", "message_center_unittests": "c1dbd7f5207e7d1e6757be48dee3f58453ad8aef", "metrics_python_tests": "a7ea6892f85a3f6a50a4cca2c0b6bc4fb51b579d", "midi_unittests": "5e08022d85cb6bfe34e04a049219cb36d1d5de27", "mojo_unittests": "d0fc72bc28ada8b750fe04ec2817eeb5211d370c", "nacl_loader_unittests": "08459cf5e6cf13c5a5ee92b876f7016f87f34c18", "native_theme_unittests": "7930fefe672e30c379eec53bd7705aef3162968c", "net_unittests": "9d5d3a0ad827cc1af4035303bedc4f22db920f3c", "pdf_unittests": "475066028461bd223e3ed457b591517b8d0a066f", "ppapi_unittests": "7c86fe207a5719995ce8ba84bad0baf8b5e16608", "printing_unittests": "095f5325fe1c563b25571e7c235ebdae4996d2a6", "remoting_unittests": "1218a9cf9149a025a4e8df5829a032ffb51b87af", "sandbox_mac_unittests": "31f0aabf957f7269bf9d14b0fd7a49d9f119bfde", "service_manager_unittests": "210fca4cc04960bf7d5ce7e1585da1dc0284c33f", "services_unittests": "2f7e952dd66172c6c1475a807081859f6ec87df3", "shell_dialogs_unittests": "91ba7e11188aa2dc1485afa76e8cbe2cf0361df9", "skia_unittests": "add07ba3b9806e03c63e762b0bb726fa23172645", "snapshot_unittests": "af07df1dada934a2fe930192516583f01ede698a", "sql_unittests": "2634e4f4b8b13c09373372590c63271523f34e18", "storage_unittests": "6811128ed910c7505209acba48f34f2dc9fd3078", "sync_integration_tests": "4c486d66c0771c7f03a79d3c718a0b3740640bfc", "telemetry_gpu_unittests": "bcccabdbc64cbe564a5a4052d85d37c3d2ae7ebd", "telemetry_perf_unittests": "73e92c88906b02df587a1d33c741f7fd222d8255", "telemetry_unittests": "56765531148ea505153822b8a7b156b94b9a2a61", "traffic_annotation_auditor_unittests": "c32a84bfbc78c6f206bef59642538d6ac2321da0", "ui_base_unittests": "b9d0b2c050a249e58bafea215bc7932e6937b948", "ui_touch_selection_unittests": "cb6fe0eeaea2be55932322047166b3e94cf0d733", "unit_tests": "beebf89bedabf3ab9ec638d0d823074adf99bb0a", "url_unittests": "766e6300044abc12cd5efb29a3b4d0a438020afb", "views_perftests": "696d8c8274a4fe46a7eaa801e4213b3c0c772617", "views_unittests": "401d8ae309199f8a3e97eb3d580766f499ddda3f", "viz_unittests": "05d745dd1f64bde2e4b54872907b45a46171197a", "webkit_layout_tests_exparchive": "4ceb16ee2cb79435ff20dafdd243344aab52cedc", "webkit_python_tests": "79d04ef92dffaa604ec80e513816995983971080", "webkit_unit_tests": "fc5bff3343d6567bf1fdd62b78e312c8da52d872", "wtf_unittests": "ac575f437d529142293741c3a7c23087f4478409"} find isolated tests

Blamelist:

  1. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  2. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  3. Florent Castelli (orphisohnoyoudont@chromium.org)
  4. Fergal Daly (fergalohnoyoudont@chromium.org)
  5. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  6. A Olsen (olsenohnoyoudont@chromium.org)
  7. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  8. Roman Sorokin (rsorokinohnoyoudont@chromium.org)
  9. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  10. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  11. Alexandre Courbot (acourbotohnoyoudont@chromium.org)
  12. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  13. Yuta Kitamura (yutakohnoyoudont@chromium.org)
  14. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  15. Gauthier Ambard (gambardohnoyoudont@chromium.org)
  16. Alexander Alekseev (alemateohnoyoudont@chromium.org)
  17. Amos Lim (eui-sang.limohnoyoudont@samsung.com)
  18. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  19. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  20. momohatt (momohatt10ohnoyoudont@gmail.com)
  21. Noel Gordon (noelohnoyoudont@chromium.org)
  22. John Z Wu (jzwohnoyoudont@chromium.org)
  23. Henrik Grunell (grunellohnoyoudont@chromium.org)
  24. Jochen Eisinger (jochenohnoyoudont@chromium.org)
  25. yiyix (yiyixohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 09:05:35 UTC
Start Friday, 12-Oct-18 09:06:34 UTC
End Friday, 12-Oct-18 09:39:25 UTC
Pending 59 secs
Execution 32 mins 50 secs

All Changes:

  1. [iOS] Support Accessibility ContentSize on NTP header

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 755d6f957abd6af5b8bbbf045ac622b92fea60a5

    Comments

    [iOS] Support Accessibility ContentSize on NTP header
    
    This CL changes the header of the "Articles for you" section of the NTP
    to have a better support for the "accessibility" categories of preferred
    content size chosen by the user.
    
    Bug: 893524
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I56ed6f89e7767697083c3e8e5d5a796db3066aee
    Reviewed-on: https://chromium-review.googlesource.com/c/1273522
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599145}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_articles_header_item.mm
    • ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
  2. [iOS] Use Dynamic Type in the empty NTP cell

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:35:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c245af46fb47db066cbdc99a5f578e2b94b2ca2f

    Comments

    [iOS] Use Dynamic Type in the empty NTP cell
    
    This CL adds Dynamic Type to the cell displayed when the NTP's articles
    section is empty.
    
    Bug: 893527
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If36d6ece1eaac888f606f7730de379aec11ba6be
    Reviewed-on: https://chromium-review.googlesource.com/c/1273536
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599144}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_text_item.mm
  3. Revert "Move InstallAttributes to chromeos/settings"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f32368f166f8a2d51078a6c6c2f6ffc8c3f2f7a9

    Comments

    Revert "Move InstallAttributes to chromeos/settings"
    
    This reverts commit aa6c62dce936e966e2db445045dd04414553642b.
    
    Reason for revert: Breaks build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/33402
    
    Original change's description:
    > Move InstallAttributes to chromeos/settings
    > 
    > Necessary for moving CrosSettings to chromeos/settings, so it
    > can eventually be used by Mustash.
    > 
    > The following changes were necessary:
    > 1. Move install_attributes{.h, .cc} and unit_test.cc
    > 2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    > (destination)
    > 3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    > which is included by install_attributes.h
    > 
    > 4. Unfortunately, that same dependency lead to a circular dependency.
    > I was able to avoid that by separating out a "common_constants" rule in
    > components/policy/core/common, so that chromeos/settings only depends on
    > that, and not on all of components/policy. So I had to change
    > components/policy/core/common/BUILD.gn
    > and I removed an unnecessary include from
    > components/policy/core/common/cloud/cloud_policy_constants.cc
    > 
    > 5. Update #include directives for install_attributes to point to new
    > location. This is the other 22 files, all with diffs of +1 -1.
    > 
    > Bug: 446937
    > Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    > Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    > Commit-Queue: A Olsen <olsen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599140}
    
    TBR=stevenjb@chromium.org,emaxx@chromium.org,olsen@chromium.org
    
    Change-Id: I50c58b55830961d97834d86a76088dc50eff672d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 446937
    Reviewed-on: https://chromium-review.googlesource.com/c/1278748
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599143}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/install_attributes.cc
    • chrome/browser/chromeos/settings/install_attributes.h
    • chrome/browser/chromeos/settings/install_attributes_unittest.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  4. [css, dom] Support partmap="foo: bar" syntax.

    Changed by Fergal Daly - fergalohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:26:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cb84b573a62d8db8d168de16560b4ff78df5bda

    Comments

    [css, dom] Support partmap="foo: bar" syntax.
    
    This is the new syntax agreed for partmap.
    
    Bug: 805271
    Change-Id: I5e8e34551167b4a56706980dae8054e4b7a6fba2
    Reviewed-on: https://chromium-review.googlesource.com/c/1278566
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599142}

    Changed files

    • third_party/WebKit/LayoutTests/css-shadow-parts/double-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-part-name-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-change-partmap-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/invalidation-complex-selector-forward.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/precedence-part-vs-part.html
    • third_party/WebKit/LayoutTests/css-shadow-parts/simple-forward.html
    • third_party/blink/renderer/core/dom/element_test.cc
    • third_party/blink/renderer/core/dom/names_map.cc
    • third_party/blink/renderer/core/dom/names_map_test.cc
    • third_party/blink/renderer/core/html/parser/html_parser_idioms.h
  5. Chrome OS Powerwash screen: update icon and illustration.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afc97ac06f5d3677c1016d1530c1e196844e2432

    Comments

    Chrome OS Powerwash screen: update icon and illustration.
    
    
    Bug: 894280
    Change-Id: I0d478790d35323008a0622404ebde6983fea06ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1278211
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599141}

    Changed files

    • chrome/browser/resources/chromeos/login/images/1x/reset_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/images/2x/reset_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/images/reset_illustration_1x.png
    • chrome/browser/resources/chromeos/login/images/reset_illustration_2x.png
    • chrome/browser/resources/chromeos/login/oobe_reset.css
    • chrome/browser/resources/chromeos/login/oobe_reset.html
  6. Move InstallAttributes to chromeos/settings

    Changed by A Olsen - olsenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa6c62dce936e966e2db445045dd04414553642b

    Comments

    Move InstallAttributes to chromeos/settings
    
    Necessary for moving CrosSettings to chromeos/settings, so it
    can eventually be used by Mustash.
    
    The following changes were necessary:
    1. Move install_attributes{.h, .cc} and unit_test.cc
    2. Update c/b/chromeos/BUILD.gn (source) and chromeos/settings/BUILD.gn
    (destination)
    3. Update chromeos/DEPS to allow a dependency on cloud_policy_constants.h,
    which is included by install_attributes.h
    
    4. Unfortunately, that same dependency lead to a circular dependency.
    I was able to avoid that by separating out a "common_constants" rule in
    components/policy/core/common, so that chromeos/settings only depends on
    that, and not on all of components/policy. So I had to change
    components/policy/core/common/BUILD.gn
    and I removed an unnecessary include from
    components/policy/core/common/cloud/cloud_policy_constants.cc
    
    5. Update #include directives for install_attributes to point to new
    location. This is the other 22 files, all with diffs of +1 -1.
    
    Bug: 446937
    Change-Id: Icc8ba19c5fec91b13004b19680ead9c9f8b0a288
    Reviewed-on: https://chromium-review.googlesource.com/c/1264757
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599140}

    Changed files

    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/chromeos/app_mode/kiosk_app_manager.h
    • chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/chromeos/dbus/dbus_helper.cc
    • chrome/browser/chromeos/login/demo_mode/demo_session.cc
    • chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
    • chrome/browser/chromeos/policy/blocking_login_browsertest.cc
    • chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
    • chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
    • chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
    • chrome/browser/chromeos/policy/enrollment_status_chromeos.h
    • chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
    • chrome/browser/chromeos/settings/device_settings_provider.cc
    • chrome/browser/chromeos/settings/stub_install_attributes.h
    • chrome/browser/chromeos/system/device_disabling_manager.cc
    • chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
    • chrome/browser/ui/webui/policy_ui_handler.cc
    • chromeos/DEPS
    • chromeos/settings/BUILD.gn
    • chromeos/settings/install_attributes.cc
    • chromeos/settings/install_attributes.h
    • chromeos/settings/install_attributes_unittest.cc
    • components/policy/core/common/BUILD.gn
    • components/policy/core/common/cloud/cloud_policy_constants.cc
  7. Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:18:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 112288aae86b2fcd3dde5b2a67872e292e54a8b0

    Comments

    Import wpt@6446b4dc89324df48019ef6fa4999595d1f80abf
    
    Using wpt-import in Chromium fb7986d88b0b8f174020916003d6939d2d928b83.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25972
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    hongchan@chromium.org, rtoy@chromium.org:
      external/wpt/webaudio
    
    NOAUTOREVERT=true
    TBR=robertma
    
    No-Export: true
    Change-Id: I9f8c2a91eb58657997bd243420a319e96a3ebc02
    Reviewed-on: https://chromium-review.googlesource.com/c/1278059
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599139}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-reuse.html
  8. Override stub path before PreEarlyInitDBus

    Changed by Roman Sorokin - rsorokinohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:10:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b80ea1c80ef7c8ec439c14def8120498fc35eda8

    Comments

    Override stub path before PreEarlyInitDBus
    
    Otherwise install attributes are not loaded on the linux Chrome OS
    build.
    
    TEST=manual
    
    Bug: 848615, 729596
    Change-Id: I445b2b337b707822459c076058610f49f02767ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1264643
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599138}

    Changed files

    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • chrome/browser/metrics/chrome_feature_list_creator.cc
  9. Chrome OS: Integrate Discover PIN setup into First run UI.

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:08:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 761a7e81af6dfcf0e5e1c29721d9a9c73a3dd19a

    Comments

    Chrome OS: Integrate Discover PIN setup into First run UI.
    
    Bug: 852553
    Change-Id: I215392305eee1555441d5dd66f0bb2908d0f5525
    Reviewed-on: https://chromium-review.googlesource.com/c/1250136
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599137}

    Changed files

    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc
    • chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.h
    • chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/wizard_controller.cc
    • chrome/browser/chromeos/login/wizard_controller.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_ui.cc
  10. Fix naming issue when renaming files inside My files

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 08:02:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40a6cb9be79a8d05395498a705e59d50cbb77f57

    Comments

    Fix naming issue when renaming files inside My files
    
    Change DirectoryModel to "unwrap" VolumeEntry when it's selected via
    file list. This fixes the issue where after selecting a VolumeEntry any
    operation in the private API would fail because it wouldn't be able to
    send a VolumeEntry to private API, because it requires a real Entry.
    
    This fixes the user issue of trying to rename and always getting "Use
    shorter name" error, even with a short name.
    
    Update FakeEntry to be an implementation of FilesAppDirEntry, since all
    users were using as directory, also update some functions to typing to
    use FilesAppDirEntry instead of FakeEntry which is more correct.
    
    Test: browser_tests --gtest_filter="*/myFilesFolderRename"
    Bug: 889636
    Change-Id: Ieb75ffbb811a91e4742fb7a49a3badfd129376ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1276067
    Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599136}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • ui/file_manager/file_manager/background/js/volume_info_impl.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/directory_model.js
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_transfer_controller.js
    • ui/file_manager/file_manager/foreground/js/file_watcher.js
    • ui/file_manager/integration_tests/file_manager/my_files.js
  11. media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.

    Changed by Alexandre Courbot - acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:54:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 029544dab67d79059b7610a92890091520ef7603

    Comments

    media/gpu/v4l2: workaround VIDIOC_G_FMT bug in libtegrav4l2.so.
    
    libtegrav4l2.so's implementation of V4L2_G_FMT has a bug which will make
    it return 0 planes for single-plane multiplanar formats. We obviously
    cannot have a multiplanar format with 0 planes, so add a workaround at
    the fake-ioctl level. Implement it as a case-switch for future-proofing
    against other workarounds we will likely have to add.
    
    Also add a few recommendations in v4l2_device.cc against the temptation
    to spare some memory by using an appropriately-sized array of
    v4l2_planes: it turns out libv4l2 also likes to write above the number
    of passed planes, and using anything shorter than VIDEO_MAX_PLANES will
    result in memory corruption DCHECKS being raised.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on both hana and nyan_big.
    
    Change-Id: I7ea638f19f5bf0bdfaa0a47885577eb9dec4c225
    Reviewed-on: https://chromium-review.googlesource.com/c/1275727
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599135}

    Changed files

    • media/gpu/v4l2/tegra_v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.cc
  12. Add browser tests for when we show the cookie exception

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:53:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df554d02051d43d493d30cdf39fb1ee7566355bf

    Comments

    Add browser tests for when we show the cookie exception
    
    Depending on the sync / sign-in state.
    
    BUG=890925
    R=tangltom@chromium.org, msarda@chromium.org
    
    Change-Id: I784f13a4981250f851df770d111a13969a6892a6
    Reviewed-on: https://chromium-review.googlesource.com/c/1273521
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599134}

    Changed files

    • chrome/browser/browsing_data/counters/browsing_data_counter_utils_browsertest.cc
    • chrome/test/BUILD.gn
  13. Move thread-related functionalities in Platform to Thread.

    Changed by Yuta Kitamura - yutakohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:47:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9deeac4682dc2c2a45fdf483c376c75011a09241

    Comments

    Move thread-related functionalities in Platform to Thread.
    
    This CL moves the most of implementation for Thread in Platform to
    Thread, so the Platform would contain less implementation (ideally,
    Platform should be a pure interface to embedders).
    
    Previously the global state of threads was stored in Platform, and
    this CL moves it to Thread. Now the thread-local storage for Blink
    threads and the main and compositor thread objects are stored as
    the global variable in thread.cc. This way, the threads state is
    completely separated from Platform. Old threading functions in
    Platform are deprecated now, and they will be migrated to Thread ones
    later.
    
    Due to those changes, some test utilities need to be updated. As the
    state of threads is not stored in Platform, the tests that need to
    override their main thread have to do that by themselves. To
    facilitate this, two new utility classes, ScopedMainThreadOverrider
    and ScopedSchedulerOverrider, are introduced, and TestingPlatform-
    SupportWithCustomScheduler is removed in favor of the new utilities.
    
    Bug: 826203
    Change-Id: Ieb702dc85b7ffd75991055038f1165c2bfd7d058
    Reviewed-on: https://chromium-review.googlesource.com/c/1273115
    Commit-Queue: Yuta Kitamura <yutak@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599133}

    Changed files

    • content/renderer/render_thread_impl.cc
    • third_party/blink/public/platform/platform.h
    • third_party/blink/renderer/core/dom/idle_deadline_test.cc
    • third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/exported/platform.cc
    • third_party/blink/renderer/platform/scheduler/common/thread.cc
    • third_party/blink/renderer/platform/scheduler/public/thread.h
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_main_thread_overrider.h
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.cc
    • third_party/blink/renderer/platform/testing/scoped_scheduler_overrider.h
    • third_party/blink/renderer/platform/testing/testing_platform_support.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_custom_scheduler.h
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
  14. Let ClientControlledState apply animation during bounds change.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 07:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68084907a40caccccb72dd14c0ad3139b97747f7

    Comments

    Let ClientControlledState apply animation during bounds change.
    
    This CL introduces a new BoundsChangeAnimationType for
    ClientControlledState which will animate the window bounds for a
    specified duration.
    
    Bug: b/115291749
    Bug: 841886
    Test: Tested with local PIP prototype - applies animation.
    Change-Id: I8eda8b2131b8d3f679ade5cfbe64d7378efd6881
    Reviewed-on: https://chromium-review.googlesource.com/c/1218385
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599132}

    Changed files

    • ash/wm/client_controlled_state.cc
    • ash/wm/client_controlled_state.h
    • ash/wm/client_controlled_state_unittest.cc
    • ash/wm/default_state.cc
    • ash/wm/window_state.cc
    • ash/wm/window_state.h
    • ash/wm/wm_event.cc
    • ash/wm/wm_event.h
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  15. [iOS] Remove ReadingList empty view

    Changed by Gauthier Ambard - gambardohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:44:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a53cbb1cdf96e0695e4d24cd408b52cc826d5088

    Comments

    [iOS] Remove ReadingList empty view
    
    This view was used in the old ReadingList implementation.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Id4fa1df5a00f0dd572a2d4951764f422231e3874
    Reviewed-on: https://chromium-review.googlesource.com/c/1276966
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599131}

    Changed files

    • ios/chrome/browser/ui/reading_list/BUILD.gn
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.h
    • ios/chrome/browser/ui/reading_list/empty_reading_list_background_view.mm
    • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
  16. Chrome OS: Integrate PIN setup into Discover UI

    Changed by Alexander Alekseev - alemateohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:43:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f479db8f992be027ddc9b715919df65ad4e40bb6

    Comments

    Chrome OS: Integrate PIN setup into Discover UI
    
    Bug: 852553
    Change-Id: I460a420b1dd0024eaebb114aac2368a7bb3f28ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1249496
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599130}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_DONE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_SUBTITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_PASSWORD_TITLE.png.sha1
    • chrome/app/chromeos_strings_grdp/IDS_DISCOVER_PIN_SETUP_SUBTITLE3.png.sha1
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/resources/chromeos/login/discover/discover_app.html
    • chrome/browser/resources/chromeos/login/discover/discover_app.js
    • chrome/browser/resources/chromeos/login/discover/discover_components.html
    • chrome/browser/resources/chromeos/login/discover/discover_components.js
    • chrome/browser/resources/chromeos/login/discover/discover_module_behavior.js
    • chrome/browser/resources/chromeos/login/discover/discover_ui.html
    • chrome/browser/resources/chromeos/login/discover/discover_ui.js
    • chrome/browser/resources/chromeos/login/discover/discover_welcome.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.css
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html
    • chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_1x.svg
    • chrome/browser/resources/chromeos/login/discover/modules/images/pin_illustration_2x.svg
    • chrome/browser/resources/chromeos/login/screen_discover.html
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.cc
    • chrome/browser/ui/webui/chromeos/login/discover/discover_manager.h
    • chrome/browser/ui/webui/chromeos/login/discover/discover_module.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_launch_help_app.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_redeem_offers.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_sync_files.h
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.cc
    • chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_welcome.h
    • chrome/common/extensions/api/_api_features.json
  17. Change cpp.tmpl files to cc.tmpl

    Changed by Amos Lim - eui-sang.limohnoyoudont@samsung.com
    Changed at Friday, 12-Oct-18 07:35:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07c46624768cb8f779f4c872aa5951d3cb7d7920

    Comments

    Change cpp.tmpl files to cc.tmpl
    
    Formats of C++ template files are mixed up with cpp.tmpl and cc.tmpl.
    Unify C++ template files to cc.tmpl
    
    Bug: 894684
    Change-Id: I4f7413f29809bcd3262a20c7f40a23e63ba45d3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278567
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Amos Lim <eui-sang.lim@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#599129}

    Changed files

    • third_party/blink/renderer/bindings/scripts/code_generator_v8.py
    • third_party/blink/renderer/bindings/scripts/generate_v8_context_snapshot_external_references.py
    • third_party/blink/renderer/bindings/templates/attributes.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_function.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/callback_invoke.cc.tmpl
    • third_party/blink/renderer/bindings/templates/constants.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl.h.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_impl_common.cc.tmpl
    • third_party/blink/renderer/bindings/templates/dictionary_v8.cc.tmpl
    • third_party/blink/renderer/bindings/templates/external_reference_table.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/interface_base.cc.tmpl
    • third_party/blink/renderer/bindings/templates/methods.cc.tmpl
    • third_party/blink/renderer/bindings/templates/partial_interface.cc.tmpl
    • third_party/blink/renderer/bindings/templates/templates.gni
    • third_party/blink/renderer/bindings/templates/union_container.cc.tmpl
    • third_party/blink/renderer/bindings/templates/utilities.cc.tmpl
    • third_party/blink/renderer/bindings/tests/results/core/array_buffer_or_array_buffer_view_or_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_element_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_string_or_unrestricted_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/byte_string_sequence_sequence_or_byte_string_byte_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_double_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_long_or_boolean_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/double_or_string_or_double_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/element_sequence_or_byte_string_double_or_string_record.cc
    • third_party/blink/renderer/bindings/tests/results/core/float_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_boolean.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_or_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/long_sequence_or_event.cc
    • third_party/blink/renderer/bindings/tests/results/core/nested_union_type.cc
    • third_party/blink/renderer/bindings/tests/results/core/node_or_node_list.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_array_buffer_or_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/string_or_string_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_double.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_or_null_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_enum_or_test_enum_sequence.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_2_or_uint8_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_long.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_interface_or_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/unrestricted_double_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/core/unsigned_long_long_or_boolean_or_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_optional_any_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_any_callback_function_variadic_any_args.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_array_buffer_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_data_view.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_long_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_string_sequence_callback_function_long_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_svg_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_attributes.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_functions.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_constants.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_dictionary_derived.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_integer_indexed_primary_global.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_check_security.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_conditional_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_3.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_constructor_4.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_custom_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_document.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_empty.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_init_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_event_target.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_named_constructor_2.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_origin_trial_enabled.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_interface_secure_context.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_legacy_callback_interface.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_node.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_object.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_permissive_dictionary.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_special_operations_not_enumerable.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_typedefs.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_test_variadic_constructor_arguments.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_boolean_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_treat_non_object_as_null_void_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_uint8_clamped_array.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_dictionary_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_enum_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_interface_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_test_interface_sequence_arg.cc
    • third_party/blink/renderer/bindings/tests/results/core/v8_void_callback_function_typedef.cc
    • third_party/blink/renderer/bindings/tests/results/core/xml_http_request_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/boolean_or_string.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_inherited_legacy_unenumerable_named_properties.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_2_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_5.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_interface_partial.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_not_enumerable_named_getter.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_test_sub_object.cc
    • third_party/blink/renderer/bindings/tests/results/modules/v8_void_callback_function_modules.cc
    • third_party/blink/renderer/core/css/css_primitive_value.h
  18. CrOS FilesApp: Add Manage Linux sharing top menu link to settings page

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:33:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 836e5cd90af24fa6af71e4e633d1c0fb41ca0765

    Comments

    CrOS FilesApp: Add Manage Linux sharing top menu link to settings page
    
    Shown when crostini and flag crostini-files are enabled.
    Links to chrome://settings/crostini/crostiniShared.
    Record UMA for clicks.
    
    Bug: 878324
    Change-Id: Ie09cd5c07edbe6dc0d0bcc22fee78b14981b2020
    Reviewed-on: https://chromium-review.googlesource.com/c/1277130
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599128}

    Changed files

    • chrome/app/file_manager_strings.grdp
    • chrome/app/file_manager_strings_grdp/IDS_FILE_BROWSER_MANAGE_LINUX_SHARING_BUTTON_LABEL.png.sha1
    • chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
    • tools/metrics/histograms/enums.xml
    • ui/file_manager/file_manager/foreground/js/file_manager.js
    • ui/file_manager/file_manager/foreground/js/file_manager_commands.js
    • ui/file_manager/file_manager/main.html
    • ui/file_manager/file_manager/test/crostini_share.js
  19. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 07:17:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS
  20. [ServiceWorker] Add WPT tests to check request header for update

    Changed by momohatt - momohatt10ohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 07:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4512662655ea5694ebba6c13055e99c9a0b2d096

    Comments

    [ServiceWorker] Add WPT tests to check request header for update
    
    Spec requires that during the update of service workers, request headers
    for fetching main scripts should include "Service-Worker" field, while
    that for fetching importScripts() resources should not.
    This patch adds WPT tests to validate this behavior.
    
    Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267297
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599126}

    Changed files

    • AUTHORS
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html
  21. Add Quick View audio load test

    Changed by Noel Gordon - noelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae2fcf0ef323eb487edced1ab876a090b3f9ce1e

    Comments

    Add Quick View audio load test
    
    Now we have the QuickView <webview> infra to detect the 'loaded' state
    of the <webview> content, add a <file-safe-media> audio test, and also
    check the <webview> renders its content on a transparent black body.
    
    This test exposed an issue in Blink node code. When the modal <dialog>
    is calling showModal(), its flat tree distribution can be out-of-date,
    causing a DCHECK crash when testing if the Quick View <dialog> element
    contains sibling <iframe id="command-dispatcher"> [1].
    
    Fix that: FlatTreeTraversal::ContainsIncludingPseudoElement() requires
    that its node arguments have up-to-date flat tree distribution. Ensure
    the <dialog>'s flat tree distribution is up-of-date _before_ trying to
    propagate the "inert" bit into sub-frames.
    
    Add crash test: html/dialog/showmodal-shadow-sibling-frame-crash.html
    
    [1] Known crash reports already exist: issue 789094 issue 804047.
    
    test: browser_tests --gtest_filter="QuickView*openQuickViewAudio"
    Bug: 891150, 789094, 804047
    Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961
    Reviewed-on: https://chromium-review.googlesource.com/c/1264138
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599125}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
    • ui/file_manager/integration_tests/file_manager/quick_view.js
  22. Clarify |stopSyncAndClearIdentity| with additional comment.

    Changed by John Z Wu - jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3255a4ba5a80b407cc61864a85c469842894f469

    Comments

    Clarify |stopSyncAndClearIdentity| with additional comment.
    
    Namely, it is OK to call it multiple times.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278061
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599124}

    Changed files

    • ios/web_view/public/cwv_sync_controller.h
  23. Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"

    Changed by Henrik Grunell - grunellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bb43df173039894cf46c8b3476913f0f20ae6d1

    Comments

    Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"
    
    This reverts commit dfeab488cdc95233b19b9edeedef3d0b7581b17e.
    
    Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091
    
    Original change's description:
    > [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    > 
    > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    > add checking whether webcam is found or not.
    > Accordingly, exclude such test cases from test suites for devices that have no
    > camera.
    > 
    > Bug: 893494
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado)
    >       and it failed.
    > Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado)
    >       and it passed.
    > Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin)
    >       and it passed.
    > 
    > Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7
    > Reviewed-on: https://chromium-review.googlesource.com/c/1276407
    > Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
    > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599097}
    
    TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org
    
    Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893494
    Reviewed-on: https://chromium-review.googlesource.com/c/1278272
    Reviewed-by: Henrik Grunell <grunell@chromium.org>
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599123}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  24. Remove the round-robin list for third-party additions

    Changed by Jochen Eisinger - jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:51:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS
  25. GPU_Tests: Remove expectations after rebaseline

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py