Home | Search | chromium - Builders
Login

Builder Mac10.11 Tests Build 30553 Apple OSX

Results:

Success

Trigger Info:

Projectchromium
Revisionf513b7c0c1803fe4688b8eee2dab06f48dabf081
Got Revisionf513b7c0c1803fe4688b8eee2dab06f48dabf081

Execution:

Steps and Logfiles:

Show:
  1. ( 482 ms ) setup_build
    running recipe: "chromium"
  2. ( 333 ms ) report builders
     
    running tester 'Mac10.11 Tests' on master 'chromium.mac'
  3. ( 2 mins 16 secs ) bot_update
    [79GB/232GB used (34%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 357 ms ) ensure_installed
  6. ( 26 secs ) gclient runhooks
  7. ( 906 ms ) read test spec (chromium.mac.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.mac.json
  8. ( 541 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  9. ( 2 secs ) build directory
  10. ( 578 ms ) find isolated tests
  11. ( 1 secs ) wait for tasks
  12. ( 3 secs ) gpu_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 15s
    Shard duration: 22s
  13. ( 1 secs ) chrome_app_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 12s
    Shard duration: 23s
  14. ( 2 secs ) boringssl_crypto_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 19s
  15. ( 3 secs ) blink_platform_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 24s
  16. ( 2 secs ) display_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 21s
    Shard duration: 49s
  17. ( 2 secs ) extensions_browsertests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 18s
    Shard duration: 48s
  18. ( 1 secs ) perfetto_content_browsertests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 25s
    Shard duration: 41s
  19. ( 1 secs ) midi_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 11s
  20. ( 1 secs ) blink_common_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 12s
  21. ( 1 secs ) nacl_loader_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 37s
    Shard duration: 14s
  22. ( 1 secs ) boringssl_ssl_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 45s
  23. ( 1 secs ) libjingle_xmpp_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 20s
  24. ( 2 secs ) chromedriver_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 14s
    Shard duration: 15s
  25. ( 2 secs ) leveldb_service_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 14s
  26. ( 1 secs ) cacheinvalidation_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 43s
  27. ( 1 secs ) chromedriver_replay_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 10s
    Total tests: 33
    * Passed: 33 (33 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 1 secs ) sandbox_mac_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 11s
  29. ( 2 secs ) extensions_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 17s
    Shard duration: 25s
  30. ( 2 secs ) crashpad_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 12s
  31. ( 1 secs ) ipc_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 21s
  32. ( 2 secs ) events_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 19s
    Shard duration: 16s
  33. ( 3 secs ) media_blink_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 23s
    Shard duration: 21s
  34. ( 2 secs ) cronet_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 17s
  35. ( 2 secs ) accessibility_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 15s
  36. ( 1 secs ) native_theme_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 39s
    Shard duration: 13s
  37. ( 3 secs ) cronet_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 0:01:09.957051
  38. ( 2 secs ) message_center_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 23s
    Shard duration: 15s
  39. ( 3 secs ) cast_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 10s
    Shard duration: 22s
  40. ( 2 secs ) headless_browsertests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 15s
    Shard duration: 30s
  41. ( 1 secs ) metrics_python_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 11s
    Total tests: 74
    * Passed: 74 (74 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  42. ( 4 secs ) angle_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 0:01:06.443582
  43. ( 4 secs ) gfx_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 13s
    Shard duration: 24s
  44. ( 2 secs ) mojo_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 35s
    Shard duration: 16s
  45. ( 1 secs ) headless_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 19s
    Shard duration: 16s
  46. ( 17 secs ) net_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 0:03:11.182714
  47. ( 3 secs ) crypto_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 48s
  48. ( 2 secs ) device_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 21s
    Shard duration: 15s
  49. ( 2 secs ) blink_heap_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 22s
  50. ( 3 secs ) base_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 0:02:21.810183
  51. ( 2 secs ) google_apis_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 11s
    Shard duration: 16s
  52. ( 2 secs ) components_browsertests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 14s
    Shard duration: 44s
  53. ( 4 secs ) cc_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 13s
    Shard duration: 0:01:01.430278
  54. ( 2 secs ) sql_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 11s
  55. ( 2 secs ) webkit_python_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 18s
    Total tests: 1578
    * Passed: 1578 (1578 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  56. ( 2 secs ) blink_fuzzer_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 13s
  57. ( 2 secs ) gin_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 10s
  58. ( 2 secs ) wtf_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 11s
  59. ( 4 secs ) content_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 24s
    Shard duration: 49s
  60. ( 2 secs ) app_shell_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 18s
  61. ( 1 secs ) filesystem_service_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 11s
  62. ( 2 secs ) capture_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 16s
  63. ( 2 secs ) gcm_unit_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 14s
    Shard duration: 18s
  64. ( 1 secs ) media_service_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 24s
    Shard duration: 17s
  65. ( 2 secs ) url_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Shard duration: 10s
  66. ( 2 secs ) latency_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 25s
    Shard duration: 12s
  67. ( 4 secs ) media_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 23s
    Shard duration: 32s
  68. ( 3 secs ) jingle_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 25s
    Shard duration: 15s
  69. ( 1 secs ) wait for tasks (2)
  70. ( 6 secs ) webkit_unit_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 59s
    Shard duration: 0:01:04.011894
  71. ( 2 secs ) telemetry_gpu_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 55s
    Shard duration: 47s
    Total tests: 38
    * Passed: 38 (38 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  72. ( 2 secs ) shell_dialogs_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 56s
    Shard duration: 15s
  73. ( 1 secs ) components_perftests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 56s
    Shard duration: 33s
    Total tests: n/a
     
  74. ( 2 secs ) interactive_ui_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Max pending time: 24s (shard #1)
    Max shard duration: 0:04:55.539253 (shard #2)
    Min shard duration: 0:03:59.785650 (shard #1)
  75. ( 2 secs ) chromedriver_py_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 57s
    Shard duration: 0:03:44.098366
    Total tests: 144
    * Passed: 144 (144 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  76. ( 2 secs ) services_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 57s
    Shard duration: 26s
  77. ( 2 secs ) printing_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 50s
    Shard duration: 10s
  78. ( 9 secs ) components_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 16s
    Shard duration: 0:01:42.851158
  79. ( 5 secs ) browser_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Max shard duration: 0:04:50.933259 (shard #2)
    Min shard duration: 0:03:06.949503 (shard #4)
  80. ( 2 secs ) viz_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 57s
    Shard duration: 57s
  81. ( 3 secs ) remoting_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 49s
    Shard duration: 23s
  82. ( 7 secs ) unit_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 0:01:00.134515
    Shard duration: 0:01:53.424742
  83. ( 2 secs ) skia_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 55s
    Shard duration: 12s
  84. ( 1 secs ) webui_polymer2_interactive_ui_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 24s
    Shard duration: 0:01:17.837411
  85. ( 2 secs ) ui_touch_selection_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 0:01:00.973281
    Shard duration: 14s
  86. ( 2 secs ) views_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 58s
    Shard duration: 22s
  87. ( 2 secs ) pdf_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 50s
    Shard duration: 12s
  88. ( 1 secs ) ppapi_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 49s
    Shard duration: 14s
  89. ( 2 secs ) storage_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 0:01:05.243625
    Shard duration: 16s
  90. ( 2 secs ) service_manager_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 47s
    Shard duration: 25s
  91. ( 2 secs ) content_shell_crash_test on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 56s
    Shard duration: 0:01:57.991371
    Total tests: n/a
     
  92. ( 2 secs ) snapshot_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 55s
    Shard duration: 12s
  93. ( 1 secs ) views_perftests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 0:01:42.575976
    Shard duration: 13s
    Total tests: n/a
     
  94. ( 2 secs ) ui_base_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 0:01:01.591012
    Shard duration: 15s
  95. ( 1 secs ) wait for tasks (3)
  96. ( 3 secs ) webui_polymer2_browser_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Max shard duration: 0:11:08.562790 (shard #0)
    Min shard duration: 0:03:20.750501 (shard #3)
  97. ( 2 secs ) sync_integration_tests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 0:01:02.093652
    Shard duration: 0:07:01.800169
  98. ( 34 secs ) wait for tasks (4)
  99. ( 3 secs ) telemetry_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Max pending time: 0:01:38.283877 (shard #3)
    Max shard duration: 0:09:08.838530 (shard #0)
    Min shard duration: 0:08:38.977248 (shard #3)
    Total tests: 1141
    * Passed: 1046 (1046 expected, 0 unexpected)
    * Skipped: 95 (95 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  100. ( 1 secs ) wait for tasks (5)
  101. ( 4 mins 16 secs ) webkit_layout_tests on (none) GPU on Mac on Mac-10.11.6
    Run on OS: 'Mac-10.11.6'
    Max pending time: 0:02:30.705430 (shard #11)
    Max shard duration: 0:08:25.040148 (shard #5)
    Min shard duration: 0:06:54.385248 (shard #6)
    Total tests: 88202
    * Passed: 74719 (74663 expected, 56 unexpected)
    * Skipped: 10722 (10722 expected, 0 unexpected)
    * Failed: 2509 (2509 expected, 0 unexpected)
    * Flaky: 252 (252 expected, 0 unexpected)
     
  102. ( 1 secs ) wait for tasks (6)
  103. ( 2 secs ) telemetry_perf_unittests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Max pending time: 0:01:35.313374 (shard #10)
    Max shard duration: 0:11:04.854814 (shard #9)
    Min shard duration: 0:01:47.748136 (shard #11)
    Total tests: 281
    * Passed: 228 (228 expected, 0 unexpected)
    * Skipped: 53 (53 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  104. ( 3 secs ) content_browsertests on (none) GPU on Mac on Mac-10.11
    Run on OS: 'Mac-10.11'
    Pending time: 25s
    Shard duration: 0:12:33.016904
  105. ( 1 secs ) Tests statistics
     
    Stats
    Total shards: 127
    Total runtime: 4:29:13.347795
     
  106. ( 2 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "vm51-m9" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541784385149370, "id": "8930315612515863552", "project": "chromium", "tags": ["builder:Mac10.11 Tests", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f513b7c0c1803fe4688b8eee2dab06f48dabf081", "gitiles_ref:refs/heads/master", "parent_buildername:Mac Builder", "parent_buildnumber:91666", "scheduler_invocation_id:9095745674700455088", "scheduler_job_id:chromium/Mac10.11 Tests", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Mac10.11 Tests" setup_build
buildnumber 30553 setup_build
mastername "chromium.mac" setup_build
parent_buildername "Mac Builder" setup_build
parent_got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" setup_build
parent_got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" setup_build
parent_got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" setup_build
parent_got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" setup_build
parent_got_revision "f513b7c0c1803fe4688b8eee2dab06f48dabf081" setup_build
parent_got_revision_cp "refs/heads/master@{#606864}" setup_build
parent_got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" setup_build
parent_got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" setup_build
parent_got_v8_revision_cp "refs/heads/7.2.286@{#1}" setup_build
parent_got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25544}" setup_build
parent_mastername "chromium.mac" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "f513b7c0c1803fe4688b8eee2dab06f48dabf081" setup_build
swarm_hashes {"accessibility_unittests": "752dfdaa259803b2467afddbfef28be089c88921", "angle_unittests": "0273d0b09a9005f59f3083bdd4c6fbec74f42ad9", "app_shell_unittests": "582f8b77f80c755471e263e53c4b4a2db725a1ff", "base_unittests": "6426034712dd76a3539843a5e59ff9f32a190881", "blink_common_unittests": "9cfd7f334012fd0ad51229659a401150e958657e", "blink_fuzzer_unittests": "d36dff91098b45ef20d43547f0169586b9d0a0a8", "blink_heap_unittests": "9b097f5bfec299674324c61eacdcfbe2e522072b", "blink_platform_unittests": "2f23096aa9d789e627608dc2d6c573a180627470", "boringssl_crypto_tests": "426db1456b410f195fd22d145fdd673de9209897", "boringssl_ssl_tests": "053a83092c5c2b8ba0a508e0aceb93d8e7a1e583", "browser_tests": "9440c7f6b47b48aec46bae8aa0cc2f0a1df16838", "cacheinvalidation_unittests": "af61809d78109519de6737d54d20eb7fd19dd4d3", "capture_unittests": "016a9191a834ebfd051e2eb98c239b28a55784d6", "cast_unittests": "484349bcc70fbd04413f97d1790c473def55f440", "cc_unittests": "16832a1c9bd9df0831f8ac424bcde424c3e7d451", "chrome_app_unittests": "eb64634b7492e59b29de691c59b31e11fc7f5719", "chromedriver_py_tests": "492ba4d207703805fc528cef615e8009fe0b5229", "chromedriver_replay_unittests": "80dcdd65faa3e5c2519bd1b938064835370c9584", "chromedriver_unittests": "1b4c2ddd1155011377af6860cfbffd3278719251", "components_browsertests": "c0529a9c230dc59ee3dc7578160b265ddbad2941", "components_perftests": "41180f9f7e8121ed6170b104c634780f0b3a3ccc", "components_unittests": "9a66873d75047653e64f59aa2765d5d71303c926", "content_browsertests": "8a559a7f566d10f8a9978c7293df0802e29ebbae", "content_shell_crash_test": "9c3a95867f3557ff7accf71134dc87845c271ed0", "content_unittests": "72d1c5cfebee5f845fded7b8080488f0f4b39099", "crashpad_tests": "e8b906841c229e2486aed8715939251cb3819394", "cronet_tests": "00753f4e1921f70608f4f44f841ee6066382b5f0", "cronet_unittests": "933c653ed9dd29d604404301d5d2b9cf007dc161", "crypto_unittests": "2e16ab6e6c1a9164fdec4a3e3d4c4467b5376a39", "device_unittests": "c7eb347da4f0c4ad0c5cb51f2b2cbf08ac19daa3", "display_unittests": "0671c02856b023142c013a35a1820a8d7184b6ee", "events_unittests": "0441e149f8ae950afc0c3949302dfb7c09699d8f", "extensions_browsertests": "9b773108b99aee07f2f63e3bfeeab8be4209b1d2", "extensions_unittests": "77772b522b1213ad58ded552bef7c35e30ba11a2", "filesystem_service_unittests": "8be0d39e111dba3e1893b8fd8417331def9c4e0d", "gcm_unit_tests": "890279c87171b6030987c1eada9862a0f1957a7c", "gfx_unittests": "addea18eb1193d4451eee97b969229f59411a3d4", "gin_unittests": "6cf8f382f2f49120f5aa645ad312b38a426c380e", "google_apis_unittests": "9551d3209a9b3a8c3a8b97e31b2332749c0aea92", "gpu_unittests": "fad3045729d7cac499339ac79fad0726a640dedf", "headless_browsertests": "ed598ec5e73f56ea6f73ac9bbc94bacacf012e3a", "headless_unittests": "f7848b3cbac651bfb83ba8512fe160cdb38220d7", "interactive_ui_tests": "4d03092cb5b1366127456f55aaa76d2b9f003a90", "ipc_tests": "ee61b79c7ce36d7a65dc0ce23c9534952892d344", "jingle_unittests": "fad062ee88265a0f916f9d7f834f7f48a9f530e4", "latency_unittests": "01a97b41c24ec962cd16b552555f75bc97674fe8", "leveldb_service_unittests": "55535faf204c1b9000390f5c1aebd414a5eef0a3", "libjingle_xmpp_unittests": "a86539925babcc5aaa6972f248379ecfbe72f323", "media_blink_unittests": "668af98fc5c393119aaffd593af6b814286e8166", "media_service_unittests": "6c4d26228dfceea39337a3855171763a240c8610", "media_unittests": "430dded0be54fcb5a503fa25d4c2198122e380dc", "message_center_unittests": "a8b53a19c829b714a0164b626fa2d2a6399ba9f8", "metrics_python_tests": "9907bb172b116c79bdae366b4c3f631973ec5e01", "midi_unittests": "203247344736f90bfbbe1f1e76dbc444b5822bc3", "mojo_unittests": "862a68b0a3a069b69abc9156ee2a8d4f30bada4e", "nacl_loader_unittests": "981e941a480610561d61a0a1b051ba39aa03be6a", "native_theme_unittests": "61755792d548d1ec2fee0d44fcf6abc5ce4835c0", "net_unittests": "95250d85098efaeb3a28810881ba5d89455d5d32", "pdf_unittests": "54f871c60c3f2beb6218ea494e32d0016048fec9", "ppapi_unittests": "2d8902c2dc280285f2234f55482089315d701e43", "printing_unittests": "92a6e393382292ce86cfaefa4bc0aff1c05efcee", "remoting_unittests": "ff4b67d98f44e54027a531cc19479216684fa13f", "sandbox_mac_unittests": "d3391f3fa64e7cd6555fdf16ade501945cdc2449", "service_manager_unittests": "ca1145f7e197ead55ffdfeda6e133beafde1900a", "services_unittests": "d890f66193837bdb5c5f83df6bf8b8a5e04c76d0", "shell_dialogs_unittests": "58ea7fbad1a7b6dda4b86477b5566874081f826a", "skia_unittests": "cf6f39cdd46fbf8e7b538d310df1cb7399be5456", "snapshot_unittests": "e06914553b05c8e7eb9162fd3c91af5f8d2a0e15", "sql_unittests": "4952403c8cd481b7ba83ccee00ef8a281ce532a9", "storage_unittests": "817d1f322918dfb9ee443bf26e0674abd4d37d38", "sync_integration_tests": "473bd3858028e8585a64fba6f0076df111280e52", "telemetry_gpu_unittests": "8403109888e68585bf365ae45055ffd71775a511", "telemetry_perf_unittests": "b94b9c13f8352e56301fb60d97735befbeb2d87a", "telemetry_unittests": "ebff26f093e736eaa97ca2ccf26637bc6af6c35f", "ui_base_unittests": "64b57826928311a0935dbe0c90920823df13168d", "ui_touch_selection_unittests": "81c9ccc0665fe116399b70e985d3424f0e4fbcee", "unit_tests": "e0758bf88db7a06233bcb4b192e125795a48d2d3", "url_unittests": "62d68e791d948b435983ad06cab0f90969ba40c5", "views_perftests": "ca10258cc282f1c2642cff09b3e1f2b085569b39", "views_unittests": "c9c8d2d52b58e297d06dd4ba828cfdbb700fd5d4", "viz_unittests": "18cacd72975062d59c27f57901a2e466c9fdca46", "webkit_layout_tests_exparchive": "109d2a9293aef640964e97d6c831d3ab2be91a1f", "webkit_python_tests": "3a528ab286f83fddd1d62f30807378cbd31c61ed", "webkit_unit_tests": "7b9055c0a8d2253c5d108e117b6a766e66bd35fe", "wtf_unittests": "b0a22df76771373ae3318b33003694e17a2b7856"} setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "f513b7c0c1803fe4688b8eee2dab06f48dabf081" bot_update
got_revision_cp "refs/heads/master@{#606864}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Antonio Gomes (tonikitooohnoyoudont@igalia.com)
  2. Vasilii Sukhanov (vasiliiohnoyoudont@chromium.org)
  3. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. Fernando Serboncini (fserbohnoyoudont@chromium.org)
  5. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  6. Nico Weber (thakisohnoyoudont@chromium.org)
  7. Nektarios Paisios (nektarohnoyoudont@chromium.org)
  8. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  9. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  10. Eugene But (eugenebutohnoyoudont@google.com)
  11. Eugene But (eugenebutohnoyoudont@google.com)
  12. Pavel Shmakov (pshmakovohnoyoudont@google.com)

Timing:

Create Friday, 09-Nov-18 17:26:25 UTC
Start Friday, 09-Nov-18 17:26:52 UTC
End Friday, 09-Nov-18 17:50:32 UTC
Pending 27 secs
Execution 23 mins 39 secs

All Changes:

  1. Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy

    Changed by Antonio Gomes - tonikitooohnoyoudont@igalia.com
    Changed at Friday, 09-Nov-18 16:24:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f513b7c0c1803fe4688b8eee2dab06f48dabf081

    Comments

    Use network::ResourceRequestInfo::proxy_server instead of was_fetched_via_proxy
    
    ... and remove the later.
    
    This is a follow up of mmenke's request in [1].
    
    [1] https://crrev.com/c/1251642/3/services/network/url_loader.cc#70
    
    TBR=nparker@chromium (components/safe_browsing/browser/threat_details_cache.cc)
    TBR=jam@chromium.org (content/browser/loader/resource_loader.cc)
    
    BUG=773295
    
    Change-Id: I932315bec7d1790dbc8726eeb1decce6e76172b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1320769
    Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606864}

    Changed files

    • components/policy/core/common/cloud/device_management_service.cc
    • components/safe_browsing/browser/threat_details_cache.cc
    • content/browser/loader/resource_loader.cc
    • services/network/public/cpp/resource_response.cc
    • services/network/public/cpp/resource_response_info.cc
    • services/network/public/cpp/resource_response_info.h
    • services/network/url_loader.cc
  2. Ignore blur events caused by the password generation.

    Changed by Vasilii Sukhanov - vasiliiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:18:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acf9b5dcb5ffe3dbc2fc3d6fd79578dd7066a5b6

    Comments

    Ignore blur events caused by the password generation.
    
    When PasswordGenerationAgent copies the password value from the password field
    to "Confirm Password" filed, a blur event is generated. It hides the currently
    open generation prompt. Those events are just side-effects of how the class
    works and should be ignored.
    
    Bug: 899756,850079
    Change-Id: Ia5d4f0184900fda97118252c48209ffcf1ce3444
    Reviewed-on: https://chromium-review.googlesource.com/c/1327205
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Ioana Pandele <ioanap@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606863}

    Changed files

    • chrome/renderer/autofill/fake_password_manager_client.cc
    • chrome/renderer/autofill/fake_password_manager_client.h
    • chrome/renderer/autofill/password_generation_agent_browsertest.cc
    • components/autofill/content/renderer/autofill_agent.cc
    • components/autofill/content/renderer/password_generation_agent.cc
    • components/autofill/content/renderer/password_generation_agent.h
  3. Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:12:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5657f328e5325aa821d8714a3f7686c078603a43

    Comments

    Roll src/third_party/perfetto fd986312652f..cf90797ef05a (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/fd986312652f..cf90797ef05a
    
    
    git log fd986312652f..cf90797ef05a --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: associate rss stat and mem info events with process"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@cf90797ef05a
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Iae90928bbe8ba71f08a8b348c2f4165763d2fc9f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329362
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606862}

    Changed files

    • DEPS
  4. Save transform context for filters

    Changed by Fernando Serboncini - fserbohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d07d7323809b59b52b1237dacb94330cc9dab4bd

    Comments

    Save transform context for filters
    
    Otherwise we get weird behavior on filters while transforming.
    
    TBR=
    
    Bug: 901759
    Change-Id: I1d487f500024a309bdb4002ba19a20387b3bb251
    Reviewed-on: https://chromium-review.googlesource.com/c/1329342
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Commit-Queue: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606861}

    Changed files

    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.h
  5. Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:10:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99e210e29e5e55c29142398eb11e164801f7d0c8

    Comments

    Roll src/third_party/skia 88e15bdaf539..c244c2fbbbf8 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/88e15bdaf539..c244c2fbbbf8
    
    
    git log 88e15bdaf539..c244c2fbbbf8 --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 mtklein@google.com remove SkBlitMask::PlatformRowProcs
    
    
    Created with:
      gclient setdep -r src/third_party/skia@c244c2fbbbf8
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=allanmac@chromium.org
    
    Change-Id: I59ebc97baec374297a4ec2b6ba5761d443086155
    Reviewed-on: https://chromium-review.googlesource.com/c/1329045
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606860}

    Changed files

    • DEPS
  6. Remove v8_context_snapshot.bin determinism hack.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:08:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d2acccc10cf8afd5a3709f5fd562d700d6b96979

    Comments

    Remove v8_context_snapshot.bin determinism hack.
    
    Reverts parts of
    https://chromium-review.googlesource.com/c/chromium/src/+/1293791 that should
    no longer be needed after https://chromium-review.googlesource.com/c/1304441
    
    Bug: 870584
    Change-Id: I76fa59eb5c88c34cd222f2a40c983a4f4e615b27
    Reviewed-on: https://chromium-review.googlesource.com/c/1328823
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606859}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/v8_context_snapshot.cc
  7. Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file

    Changed by Nektarios Paisios - nektarohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:06:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7669a6683a5f927ae9a3fa2c2d7802e2a8d5c165

    Comments

    Ensures that selection test data files are non-empty on the bots by adding data dependency to the BUILD file
    
    In case the files are somehow not found or unreadable on the bots, the tests should fail.
    R=dmazzoni@chromium.org
    
    Change-Id: I31668ab7a1b023a9eeda251b3ae0e7079f262171
    Reviewed-on: https://chromium-review.googlesource.com/c/1324232
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606858}

    Changed files

    • third_party/blink/renderer/modules/BUILD.gn
    • third_party/blink/renderer/modules/accessibility/testing/accessibility_selection_test.cc
  8. Roll src-internal 6166365225d6..827de2c806ba (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 16:04:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56904b670753b8f8a1f5131ef61b9e1027f34c6e

    Comments

    Roll src-internal 6166365225d6..827de2c806ba (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6166365225d6..827de2c806ba
    
    
    Created with:
      gclient setdep -r src-internal@827de2c806ba
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I3e94550aad679738b88e45953fbc781a647de4ab
    Reviewed-on: https://chromium-review.googlesource.com/c/1329361
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606857}

    Changed files

    • DEPS
  9. Wire the resizeMode property to the constraints parsing mechanism.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:02:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c6c086d575a9e131e70eaf6512a0da14150442

    Comments

    Wire the resizeMode property to the constraints parsing mechanism.
    
    This CL adds resizeMode support for MediaStreamTrack.getConstraints()
    and marks resizeMode as a supported constrainable property.
    
    Support for getUserMedia(), applyConstraints() and getCapabilities()
    will be added in follow-up CLs in this series.
    
    Intent to Ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V2srjdzRCXE
    
    Bug: 854980
    Change-Id: Ia23b8119768ab67ab498f0f8e2267aeb388f9fc3
    Reviewed-on: https://chromium-review.googlesource.com/c/1309749
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606856}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-getSupportedConstraints.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints.html
    • third_party/blink/public/platform/web_media_constraints.h
    • third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
    • third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
    • third_party/blink/renderer/platform/exported/web_media_constraints.cc
  10. Call WebStateObserver::PageLoaded after loading placeholder URL.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:00:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 386114b5bacc02e12b584786671d67b6080f02e7

    Comments

    Call WebStateObserver::PageLoaded after loading placeholder URL.
    
    Before this CL PageLoaded was called right from
    didFailProvisionalNavigation:, where URL may still represent the
    previous page.
    
    Bug: 903497
    Change-Id: I712dd120340353f37d2fe739c5b05e843cb11d7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327608
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606855}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  11. Update SadTabTabHelper to work with SadTabCoordinator.

    Changed by Eugene But - eugenebutohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9773a84184a277ad674bbe729aa26677f1f3c800

    Comments

    Update SadTabTabHelper to work with SadTabCoordinator.
    
    SadTabTabHelper now calls sadTabTabHelperDidHide: and
    sadTabTabHelper:didShowForRepeatedFailure:
    
    Bug: 901563
    Change-Id: If2b75702c951c247d44368b681ce360bbb6464d5
    Reviewed-on: https://chromium-review.googlesource.com/c/1327167
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606854}

    Changed files

    • ios/chrome/browser/web/sad_tab_tab_helper.h
    • ios/chrome/browser/web/sad_tab_tab_helper.mm
    • ios/chrome/browser/web/sad_tab_tab_helper_unittest.mm
  12. Refactor Trusted Web Activity UI code to MVC

    Changed by Pavel Shmakov - pshmakovohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 15:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a5daa30c703af7c6e90dd5088cdbd5fdcfdc7d0

    Comments

    Refactor Trusted Web Activity UI code to MVC
    
    The code is restructured according to the high-level MVC picture, but
    low-level details such as view binding mechanism are not used, as
    it seems to be an overkill at this point. We can easily install those
    mechanisms in future should the model become more complicated.
    
    Verification is extracted to TrustedWebActivityVerifier in the
    controller layer. Several controllers observe verification and update
    the model. Several independent Views are observing the changes in the
    model and updating themselves accordingly.
    
    Change-Id: I8882da2d648fcea21b85fd4a1c0568dd00e47113
    Reviewed-on: https://chromium-review.googlesource.com/c/1323069
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606853}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/ClientAppDataRegister.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityUi.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/TrustedWebActivityModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/PersistentNotificationController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityOpenTimeRecorder.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityToolbarController.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityVerifier.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/PersistentNotificationView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityDisclosureView.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/view/TrustedWebActivityToolbarView.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/dependency_injection/CustomTabActivityComponent.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosureTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/ClientAppDataRecorderTest.java
    • chrome/android/junit/src/org/chromium/chrome/browser/browserservices/trustedwebactivityui/controller/TrustedWebActivityDisclosureControllerTest.java